activeadmin 0.6.6 → 1.0.0.pre1

data/spec/support/detect_rails_version.rb

@@ -1,42 +1,34 @@
 # Detects the current version of Rails that is being used
 #
 #
-unless defined? RAILS_VERSION_FILE
-  RAILS_VERSION_FILE = File.expand_path("../../../.rails-version", __FILE__)
-end
+RAILS_VERSION_FILE ||= File.expand_path("../../../.rails-version", __FILE__)
 
 unless defined? TRAVIS_CONFIG
   require 'yaml'
   filename = File.expand_path("../../../.travis.yml", __FILE__)
   TRAVIS_CONFIG = YAML.load_file filename
-  TRAVIS_RAILS_VERSIONS = TRAVIS_CONFIG['env'].grep(/RAILS=(.*)/){ $1 }.sort
+  TRAVIS_RAILS_VERSIONS = TRAVIS_CONFIG['env']['matrix'].grep(/RAILS=(.*)/){ $1 }
 end
 
-unless defined? DEFAULT_RAILS_VERSION
-  DEFAULT_RAILS_VERSION = TRAVIS_RAILS_VERSIONS.last
-end
+DEFAULT_RAILS_VERSION ||= TRAVIS_RAILS_VERSIONS.first
 
 def detect_rails_version
-  version = version_from_file || version_from_env || DEFAULT_RAILS_VERSION
-
+  version = version_from_file || ENV['RAILS'] || DEFAULT_RAILS_VERSION
+ensure
   puts "Detected Rails: #{version}" if ENV['DEBUG']
+end
 
-  version
+def detect_rails_version!
+  detect_rails_version or raise "can't find a version of Rails to use!"
 end
 
 def version_from_file
   if File.exists?(RAILS_VERSION_FILE)
     version = File.read(RAILS_VERSION_FILE).chomp.strip
-    version = nil if version == ""
-
-    version
+    version unless version == ''
   end
 end
 
-def version_from_env
-  ENV['RAILS']
-end
-
 def write_rails_version(version)
   File.open(RAILS_VERSION_FILE, "w+"){|f| f << version }
 end

data/spec/support/rails_template.rb

@@ -1,5 +1,8 @@
 # Rails template to build the sample app for specs
 
+run "rm Gemfile"
+run "rm -r test"
+
 # Create a cucumber database and environment
 copy_file File.expand_path('../templates/cucumber.rb', __FILE__),                "config/environments/cucumber.rb"
 copy_file File.expand_path('../templates/cucumber_with_reloading.rb', __FILE__), "config/environments/cucumber_with_reloading.rb"
@@ -8,34 +11,53 @@ gsub_file 'config/database.yml', /^test:.*\n/, "test: &test\n"
 gsub_file 'config/database.yml', /\z/, "\ncucumber:\n  <<: *test\n  database: db/cucumber.sqlite3"
 gsub_file 'config/database.yml', /\z/, "\ncucumber_with_reloading:\n  <<: *test\n  database: db/cucumber.sqlite3"
 
-generate :model, "post title:string body:text published_at:datetime author_id:integer category_id:integer starred:boolean"
+if File.exists? 'config/secrets.yml'
+  gsub_file 'config/secrets.yml', /\z/, "\ncucumber:\n  secret_key_base: #{'o' * 128}"
+  gsub_file 'config/secrets.yml', /\z/, "\ncucumber_with_reloading:\n  secret_key_base: #{'o' * 128}"
+end
+
+generate :model, "post title:string body:text published_at:datetime author_id:integer position:integer custom_category_id:integer starred:boolean foo_id:integer"
 inject_into_file 'app/models/post.rb', %q{
-  belongs_to :category
-  belongs_to :author, :class_name => 'User'
+  belongs_to :category, foreign_key: :custom_category_id
+  belongs_to :author, class_name: 'User'
+  has_many :taggings
   accepts_nested_attributes_for :author
-  attr_accessible :author if Rails::VERSION::STRING >= '3.2'
-}, :after => 'class Post < ActiveRecord::Base'
+  accepts_nested_attributes_for :taggings
+  attr_accessible :author, :position unless Rails::VERSION::MAJOR > 3 && !defined? ProtectedAttributes
+}, after: 'class Post < ActiveRecord::Base'
 copy_file File.expand_path('../templates/post_decorator.rb', __FILE__), "app/models/post_decorator.rb"
 
+generate :model, "blog/post title:string body:text published_at:datetime author_id:integer position:integer custom_category_id:integer starred:boolean foo_id:integer"
+inject_into_file 'app/models/blog/post.rb', %q{
+  belongs_to :category, foreign_key: :custom_category_id
+  belongs_to :author, class_name: 'User'
+  has_many :taggings
+  accepts_nested_attributes_for :author
+  accepts_nested_attributes_for :taggings
+  attr_accessible :author, :position unless Rails::VERSION::MAJOR > 3 && !defined? ProtectedAttributes
+}, after: 'class Blog::Post < ActiveRecord::Base'
+
+
 generate :model, "user type:string first_name:string last_name:string username:string age:integer"
 inject_into_file 'app/models/user.rb', %q{
-  has_many :posts, :foreign_key => 'author_id'
+  has_many :posts, foreign_key: 'author_id'
   def display_name
     "#{first_name} #{last_name}"
   end
-}, :after => 'class User < ActiveRecord::Base'
+}, after: 'class User < ActiveRecord::Base'
 
 generate :model, 'publisher --migration=false --parent=User'
 generate :model, 'category name:string description:text'
 inject_into_file 'app/models/category.rb', %q{
-  has_many :posts
+  has_many :posts, foreign_key: :custom_category_id
+  has_many :authors, through: :posts
   accepts_nested_attributes_for :posts
-}, :after => 'class Category < ActiveRecord::Base'
+}, after: 'class Category < ActiveRecord::Base'
 generate :model, 'store name:string'
 
 # Generate a model with string ids
 generate :model, "tag name:string"
-gsub_file(Dir['db/migrate/*_create_tags.rb'][0], /\:tags\sdo\s.*/, ":tags, :id => false, :primary_key => :id do |t|\n\t\t\tt.string :id\n")
+gsub_file(Dir['db/migrate/*_create_tags.rb'][0], /\:tags\sdo\s.*/, ":tags, id: false, primary_key: :id do |t|\n\t\t\tt.string :id\n")
 inject_into_file 'app/models/tag.rb', %q{
   self.primary_key = :id
   before_create :set_id
@@ -44,17 +66,23 @@ inject_into_file 'app/models/tag.rb', %q{
   def set_id
     self.id = 8.times.inject("") { |s,e| s << (i = Kernel.rand(62); i += ((i < 10) ? 48 : ((i < 36) ? 55 : 61 ))).chr }
   end
-}, :after => 'class Tag < ActiveRecord::Base'
+}, after: 'class Tag < ActiveRecord::Base'
 
-if Rails::VERSION::MAJOR == 3 && Rails::VERSION::MINOR == 1 #Rails 3.1 Gotcha
-  gsub_file 'app/models/tag.rb', /self\.primary_key.*$/, "define_attr_method :primary_key, :id"
-end
+generate :model, "tagging post_id:integer tag_id:integer"
+inject_into_file 'app/models/tagging.rb', %q{
+  belongs_to :post
+  belongs_to :tag
+}, after: 'class Tagging < ActiveRecord::Base'
 
 # Configure default_url_options in test environment
-inject_into_file "config/environments/test.rb", "  config.action_mailer.default_url_options = { :host => 'example.com' }\n", :after => "config.cache_classes = true\n"
+inject_into_file "config/environments/test.rb", "  config.action_mailer.default_url_options = { host: 'example.com' }\n", after: "config.cache_classes = true\n"
 
 # Add our local Active Admin to the load path
-inject_into_file "config/environment.rb", "\n$LOAD_PATH.unshift('#{File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib'))}')\nrequire \"active_admin\"\n", :after => "require File.expand_path('../application', __FILE__)"
+inject_into_file "config/environment.rb", "\n$LOAD_PATH.unshift('#{File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib'))}')\nrequire \"active_admin\"\n", after: "require File.expand_path('../application', __FILE__)"
+inject_into_file "config/application.rb", "\nrequire 'devise'\n", after: "require 'rails/all'"
+
+# Force strong parameters to raise exceptions
+inject_into_file 'config/application.rb', "\n\n    config.action_controller.action_on_unpermitted_parameters = :raise if Rails::VERSION::MAJOR == 4\n\n", after: 'class Application < Rails::Application'
 
 # Add some translations
 append_file "config/locales/en.yml", File.read(File.expand_path('../templates/en.yml', __FILE__))
@@ -62,31 +90,32 @@ append_file "config/locales/en.yml", File.read(File.expand_path('../templates/en
 # Add predefined admin resources
 directory File.expand_path('../templates/admin', __FILE__), "app/admin"
 
-run "rm Gemfile"
-run "rm -r test"
-run "rm -r spec"
+# Add predefined policies
+directory File.expand_path('../templates/policies', __FILE__), 'app/policies'
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 
-generate :'active_admin:install'
+generate 'active_admin:install'
 
-rake "db:migrate"
-rake "db:test:prepare"
-run "/usr/bin/env RAILS_ENV=cucumber rake db:migrate"
+inject_into_file "config/routes.rb", "\n  root to: redirect('/admin')", after: /.*::Application.routes.draw do/
+remove_file "public/index.html" if File.exists? "public/index.html"
 
-# Setup parallel_tests
-def setup_parallel_tests_database(after, force_insert_same_content = false)
-  inject_into_file 'config/database.yml', "<%= ENV['TEST_ENV_NUMBER'] %>", :after => after, :force => force_insert_same_content
-end
+# Devise master doesn't set up its secret key on Rails 4.1
+# https://github.com/plataformatec/devise/issues/2554
+gsub_file 'config/initializers/devise.rb', /# config.secret_key =/, 'config.secret_key ='
 
-setup_parallel_tests_database "test.sqlite3"
-setup_parallel_tests_database "cucumber.sqlite3", true
+rake "db:migrate db:test:prepare"
+run "/usr/bin/env RAILS_ENV=cucumber rake db:migrate"
+
+if ENV['INSTALL_PARALLEL']
+  inject_into_file 'config/database.yml', "<%= ENV['TEST_ENV_NUMBER'] %>", after: 'test.sqlite3'
+  inject_into_file 'config/database.yml', "<%= ENV['TEST_ENV_NUMBER'] %>", after: 'cucumber.sqlite3', force: true
 
-# Note: this is hack!
-# Somehow, calling parallel_tests tasks from Rails generator using Thor does not work ...
-# RAILS_ENV variable never makes it to parallel_tests tasks.
-# We need to call these tasks in the after set up hook in order to creates cucumber DBs + run migrations on test & cucumber DBs
-create_file 'lib/tasks/parallel.rake', %q{
+  # Note: this is hack!
+  # Somehow, calling parallel_tests tasks from Rails generator using Thor does not work ...
+  # RAILS_ENV variable never makes it to parallel_tests tasks.
+  # We need to call these tasks in the after set up hook in order to creates cucumber DBs + run migrations on test & cucumber DBs
+  create_file 'lib/tasks/parallel.rake', %q{
 namespace :parallel do
   def run_in_parallel(cmd, options)
     count = "-n #{options[:count]}" if options[:count]
@@ -106,4 +135,4 @@ namespace :parallel do
   end
 end
 }
-
+end

data/spec/support/rails_template_with_data.rb

@@ -7,7 +7,7 @@ apply File.expand_path("../rails_template.rb", __FILE__)
 end
 
 scopes = <<-EOF
-  scope :all, :default => true
+  scope :all, default: true
 
   scope :drafts do |posts|
     posts.where(["published_at IS NULL"])
@@ -22,23 +22,23 @@ scopes = <<-EOF
   end
 
   scope :my_posts do |posts|
-    posts.where(:author_id => current_admin_user.id)
+    posts.where(author_id: current_admin_user.id)
   end
 EOF
-inject_into_file 'app/admin/posts.rb', scopes , :after => "ActiveAdmin.register Post do\n"
+inject_into_file 'app/admin/posts.rb', scopes , after: "ActiveAdmin.register Post do\n"
 
 # Setup some default data
 append_file "db/seeds.rb", <<-EOF
   users = ["Jimi Hendrix", "Jimmy Page", "Yngwie Malmsteen", "Eric Clapton", "Kirk Hammett"].collect do |name|
     first, last = name.split(" ")
-    User.create!  :first_name => first,
-                  :last_name => last,
-                  :username => [first,last].join('-').downcase,
-                  :age => rand(80)
+    User.create!  first_name: first,
+                  last_name: last,
+                  username: [first,last].join('-').downcase,
+                  age: rand(80)
   end
 
   categories = ["Rock", "Pop Rock", "Alt-Country", "Blues", "Dub-Step"].collect do |name|
-    Category.create! :name => name
+    Category.create! name: name
   end
 
   published_at_values = [Time.now.utc - 5.days, Time.now.utc - 1.day, nil, Time.now.utc + 3.days]
@@ -47,12 +47,12 @@ append_file "db/seeds.rb", <<-EOF
     user = users[i % users.size]
     cat = categories[i % categories.size]
     published_at = published_at_values[i % published_at_values.size]
-    Post.create :title => "Blog Post \#{i}",
-                :body => "Blog post \#{i} is written by \#{user.username} about \#{cat.name}",
-                :category => cat,
-                :published_at => published_at,
-                :author => user,
-                :starred => true
+    Post.create title: "Blog Post \#{i}",
+                body: "Blog post \#{i} is written by \#{user.username} about \#{cat.name}",
+                category: cat,
+                published_at: published_at,
+                author: user,
+                starred: true
   end
 EOF
 

data/spec/support/templates/admin/stores.rb

@@ -1,5 +1,9 @@
 ActiveAdmin.register Store do
 
-  index :pagination_total => false
+  if Rails::VERSION::MAJOR == 4
+    permit_params :name
+  end
+
+  index pagination_total: false
 
 end

data/spec/support/templates/policies/active_admin/comment_policy.rb

@@ -0,0 +1,9 @@
+module ActiveAdmin
+  class CommentPolicy < ApplicationPolicy
+    class Scope < Struct.new(:user, :scope)
+      def resolve
+        scope
+      end
+    end
+  end
+end

data/spec/support/templates/policies/active_admin/page_policy.rb

@@ -0,0 +1,18 @@
+module ActiveAdmin
+  class PagePolicy < ApplicationPolicy
+    class Scope < Struct.new(:user, :scope)
+      def resolve
+        scope
+      end
+    end
+
+    def show?
+      case record.name
+      when "Dashboard"
+        true
+      else
+        false
+      end
+    end
+  end
+end

data/spec/support/templates/policies/admin_user_policy.rb

@@ -0,0 +1,11 @@
+class AdminUserPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def destroy?
+    record != user
+  end
+end

data/spec/support/templates/policies/application_policy.rb

@@ -0,0 +1,45 @@
+class ApplicationPolicy
+  attr_reader :user, :record
+
+  def initialize(user, record)
+    @user = user
+    @record = record
+  end
+
+  def index?
+    true
+  end
+
+  def show?
+    scope.where(:id => record.id).exists?
+  end
+
+  def new?
+    create?
+  end
+
+  def create?
+    true
+  end
+
+  def edit?
+    update?
+  end
+
+  def update?
+    true
+  end
+
+  def destroy?
+    true
+  end
+
+  def destroy_all?
+    true
+  end
+
+
+  def scope
+    Pundit.policy_scope!(user, record.class)
+  end
+end

data/spec/support/templates/policies/category_policy.rb

@@ -0,0 +1,7 @@
+class CategoryPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+end

data/spec/support/templates/policies/post_policy.rb

@@ -0,0 +1,15 @@
+class PostPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def update?
+    record.author == user
+  end
+
+  def destroy?
+    update?
+  end
+end

data/spec/support/templates/policies/store_policy.rb

@@ -0,0 +1,11 @@
+class StorePolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def destroy?
+    false
+  end
+end

data/spec/support/templates/policies/user_policy.rb

@@ -0,0 +1,11 @@
+class UserPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def destroy_all?
+    true
+  end
+end

data/spec/support/templates/post_decorator.rb

@@ -1,53 +1,11 @@
-# Minimal example of a decorator
-require_dependency 'post'
+require 'draper'
 
-# DelegateClass(Post) does not delegate attribute methods
-# in some environments:
-# http://travis-ci.org/#!/gregbell/active_admin/jobs/2021466
-#
-class PostDecorator < SimpleDelegator
-  delegate :id, :to => :__getobj__
-
-  def self.decorate(object)
-    new(object)
-  end
-
-  def self.decorate_collection(collection)
-    DecoratedEnumerableProxy.new(collection)
-  end
-
-  def self.model_name
-    ActiveModel::Name.new Post
-  end
+class PostDecorator < Draper::Decorator
+  decorates :post
+  delegate_all
 
   def decorator_method
     'A method only available on the decorator'
   end
-
-  # Minimal example of decorating a collection.
-  # A full example can be found in the draper project:
-  # https://github.com/jcasimir/draper/blob/master/lib/draper/decorated_enumerable_proxy.rb
-  class DecoratedEnumerableProxy < DelegateClass(ActiveRecord::Relation)
-    include Enumerable
-
-    delegate :as_json, :collect, :map, :each, :[], :all?, :include?, :first, :last, :shift, :to => :decorated_collection
-
-    def klass
-      PostDecorator
-    end
-
-    def wrapped_collection
-      __getobj__
-    end
-
-    def decorated_collection
-      @decorated_collection ||= wrapped_collection.collect { |member| klass.decorate(member) }
-    end
-    alias_method :to_ary, :decorated_collection
-
-    def each(&blk)
-      to_ary.each(&blk)
-    end
-  end
 end