invenio-app-ils 4.6.0__py2.py3-none-any.whl → 5.0.0__py2.py3-none-any.whl

tests/api/ill/test_ill_brw_reqs_patron_loan_extension_actions.py

@@ -1,280 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test ILL borrowing requests actions."""
-
-import json
-from datetime import timedelta
-
-import arrow
-from flask import url_for
-
-from invenio_app_ils.ill.api import BORROWING_REQUEST_PID_TYPE
-from tests.helpers import user_login, user_logout
-
-
-def _create_on_loan_brwreq(
-    patron_id, loan_start_date, loan_end_date, client, json_headers
-):
-    """Create a new ON_LOAN ILL borrowing request."""
-
-    def _create_brwreq(patron_id):
-        brwreq = dict(
-            document_pid="docid-3",
-            provider_pid="ill-provid-2",
-            patron_pid=patron_id,
-            status="REQUESTED",
-            type="PHYSICAL_COPY",
-        )
-        url = url_for("invenio_records_rest.illbid_list")
-        res = client.post(url, headers=json_headers, data=json.dumps(brwreq))
-        assert res.status_code == 201
-        brw_req = res.get_json()["metadata"]
-        return brw_req["pid"]
-
-    def _create_loan_action(pid):
-        """Send request to create a new loan from the ILL."""
-        data = dict(
-            loan_start_date=loan_start_date,
-            loan_end_date=loan_end_date,
-            transaction_location_pid="locid-1",
-        )
-        url = url_for("invenio_app_ils_ill.illbid_create_loan", pid_value=pid)
-        res = client.post(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code == 200
-        brw_req = res.get_json()["metadata"]
-        assert brw_req["status"] == "ON_LOAN"
-        return brw_req
-
-    brwreq_pid = _create_brwreq(patron_id)
-    return _create_loan_action(brwreq_pid)
-
-
-def _create_on_loan_brwreq_random_dates(patron_id, client, json_headers):
-    """Create a new ON_LOAN ILL borrowing request with random start/end."""
-    loan_start_date = arrow.utcnow()
-    loan_end_date = loan_start_date + timedelta(days=15)
-    brwreq = _create_on_loan_brwreq(
-        patron_id,
-        loan_start_date.date().isoformat(),
-        loan_end_date.date().isoformat(),
-        client,
-        json_headers,
-    )
-    return brwreq, brwreq["pid"]
-
-
-def _create_on_loan_brwreq_with_pending_extension(patron_id, client, json_headers):
-    """Create a new ON_LOAN ILL borrowing request with pending extension."""
-    today = arrow.utcnow().date().isoformat()
-    brwreq, brwreq_pid = _create_on_loan_brwreq_random_dates("1", client, json_headers)
-    res = _request_extension_action(brwreq_pid, client, json_headers)
-    assert res.status_code == 200
-
-    brwreq = res.get_json()["metadata"]
-    patron_loan = brwreq["patron_loan"]
-
-    assert patron_loan["loan"]["state"] == "ITEM_ON_LOAN"
-    assert "extension_count" not in patron_loan["loan"]
-    assert patron_loan["extension"]["status"] == "PENDING"
-    assert patron_loan["extension"]["request_date"] == today
-
-    return brwreq, brwreq["pid"]
-
-
-def _request_extension_action(pid, client, json_headers):
-    """Send HTTP request to request extension of ILL Borrowing Request."""
-    url = url_for("invenio_app_ils_ill.illbid_request_extension", pid_value=pid)
-    return client.post(url, headers=json_headers, data=json.dumps({}))
-
-
-def _accept_extension_action(pid, data, client, json_headers):
-    """Send HTTP request to accept extension of ILL Borrowing Request."""
-    data["transaction_location_pid"] = "locid-1"
-    url = url_for("invenio_app_ils_ill.illbid_accept_extension", pid_value=pid)
-    return client.post(url, headers=json_headers, data=json.dumps(data))
-
-
-def _decline_extension_action(pid, _, client, json_headers):
-    """Send HTTP request to decline extension of ILL Borrowing Request."""
-    url = url_for("invenio_app_ils_ill.illbid_decline_extension", pid_value=pid)
-    return client.post(url, headers=json_headers, data=json.dumps({}))
-
-
-def test_brwreq_request_extension_only_owner(client, testdata, json_headers, users):
-    """Test that patron can request extension only for his own loan."""
-    user_login(client, "librarian", users)
-
-    brwreq, brwreq_pid = _create_on_loan_brwreq_random_dates("1", client, json_headers)
-
-    # anonymous, forbidden
-    user_logout(client)
-    res = _request_extension_action(brwreq_pid, client, json_headers)
-    assert res.status_code == 401
-
-    # patron2 is not the owner, forbidden
-    user_login(client, "patron2", users)
-    res = _request_extension_action(brwreq_pid, client, json_headers)
-    assert res.status_code == 403
-
-    # patron1 is the owner, success
-    user_login(client, "patron1", users)
-    res = _request_extension_action(brwreq_pid, client, json_headers)
-    assert res.status_code == 200
-    extension = res.get_json()["metadata"]["patron_loan"]["extension"]
-    assert extension["status"] == "PENDING"
-    assert extension["request_date"] == arrow.now().date().isoformat()
-
-    # create a new one with patron2 owner, librarian can request extension
-    user_login(client, "librarian", users)
-    brwreq, brwreq_pid = _create_on_loan_brwreq_random_dates("2", client, json_headers)
-    res = _request_extension_action(brwreq_pid, client, json_headers)
-    assert res.status_code == 200
-    assert extension["status"] == "PENDING"
-    assert extension["request_date"] == arrow.now().date().isoformat()
-
-
-def test_brwreq_accept_decline_extension_only_librarian(
-    client, testdata, json_headers, users
-):
-    """Test that only librarian can accept or decline an extension."""
-
-    tests = [_accept_extension_action, _decline_extension_action]
-    for action in tests:
-        user_login(client, "librarian", users)
-
-        # create request
-        brwreq, brwreq_pid = _create_on_loan_brwreq_with_pending_extension(
-            "1", client, json_headers
-        )
-
-        loan_end_date = arrow.utcnow() + timedelta(days=15)
-        data = dict(loan_end_date=loan_end_date.date().isoformat())
-
-        # accept/decline
-
-        # anonymous, forbidden
-        user_logout(client)
-        res = action(brwreq_pid, data, client, json_headers)
-        assert res.status_code == 401
-
-        # patron, forbidden
-        user_login(client, "patron1", users)
-        res = action(brwreq_pid, data, client, json_headers)
-        assert res.status_code == 403
-
-        # librarian, success
-        user_login(client, "librarian", users)
-        res = action(brwreq_pid, data, client, json_headers)
-        assert res.status_code == 200
-
-
-def test_brwreq_request_extension_fails_on_wrong_status(
-    client, testdata, json_headers, users
-):
-    user_login(client, "patron1", users)
-    # demo data "illbid-1" is not ON_LOAN
-    res = _request_extension_action("illbid-1", client, json_headers)
-    assert res.status_code == 400
-    # demo data "illbid-7" has already a pending request extension
-    res = _request_extension_action("illbid-7", client, json_headers)
-    assert res.status_code == 400
-    # demo data "illbid-" has declined request extension
-    res = _request_extension_action("illbid-8", client, json_headers)
-    assert res.status_code == 400
-
-
-def test_brwreq_accept_decline_extension_should_fail_when_loan_not_active(
-    client, testdata, json_headers, users
-):
-    """Test that accept or decline an extension fails on loan not active."""
-
-    tests = [_accept_extension_action, _decline_extension_action]
-    for action in tests:
-        user_login(client, "librarian", users)
-
-        # create request
-        brwreq, brwreq_pid = _create_on_loan_brwreq_with_pending_extension(
-            "1", client, json_headers
-        )
-
-        # check-in loan
-        loan_pid = brwreq["patron_loan"]["pid"]
-        url = url_for(
-            "invenio_circulation_loan_actions.loanid_actions",
-            pid_value=loan_pid,
-            action="checkin",
-        )
-        item_pid = dict(type=BORROWING_REQUEST_PID_TYPE, value=brwreq["pid"])
-        params = dict(
-            document_pid=brwreq["document_pid"],
-            item_pid=item_pid,
-            patron_pid=brwreq["patron_pid"],
-            transaction_location_pid="locid-1",
-            transaction_user_pid="1",
-        )
-        res = client.post(url, headers=json_headers, data=json.dumps(params))
-        assert res.status_code == 202
-
-        # accept extension
-        loan_end_date = arrow.utcnow() + timedelta(days=15)
-        data = dict(loan_end_date=loan_end_date.date().isoformat())
-
-        res = action(brwreq_pid, data, client, json_headers)
-        assert res.status_code == 400
-
-
-def test_brwreq_accept_extension_success(client, testdata, json_headers, users):
-    """Test accept extension success."""
-    user_login(client, "librarian", users)
-
-    # create request
-    brwreq, brwreq_pid = _create_on_loan_brwreq_with_pending_extension(
-        "1", client, json_headers
-    )
-
-    loan_end_date = arrow.utcnow() + timedelta(days=15)
-    end_date = loan_end_date.date().isoformat()
-    data = dict(loan_end_date=end_date)
-
-    user_login(client, "librarian", users)
-    # accept extension
-    res = _accept_extension_action(brwreq_pid, data, client, json_headers)
-    assert res.status_code == 200
-
-    patron_loan = res.get_json()["metadata"]["patron_loan"]
-    assert patron_loan["loan"]["state"] == "ITEM_ON_LOAN"
-    assert patron_loan["loan"]["extension_count"] == 1
-    assert patron_loan["loan"]["end_date"] == end_date
-    assert "status" not in patron_loan["extension"]
-
-
-def test_brwreq_decline_extension_success(client, testdata, json_headers, users):
-    """Test declone extension success."""
-    user_login(client, "librarian", users)
-
-    # create request
-    brwreq, brwreq_pid = _create_on_loan_brwreq_with_pending_extension(
-        "1", client, json_headers
-    )
-    end_date = brwreq["patron_loan"]["loan"]["end_date"]
-
-    user_login(client, "librarian", users)
-    # decline extension
-    res = _decline_extension_action(brwreq_pid, dict(), client, json_headers)
-    assert res.status_code == 200
-
-    patron_loan = res.get_json()["metadata"]["patron_loan"]
-    assert patron_loan["loan"]["state"] == "ITEM_ON_LOAN"
-    assert "extension_count" not in patron_loan["loan"]
-    assert patron_loan["loan"]["end_date"] == end_date
-    assert patron_loan["extension"]["status"] == "DECLINED"
-
-    # request again should now fail because it has been declined
-    user_login(client, "patron1", users)
-    res = _request_extension_action(brwreq_pid, client, json_headers)
-    assert res.status_code == 400

tests/api/ill/test_ill_brw_reqs_permissions.py

@@ -1,163 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test ILL borrowing requests."""
-
-import json
-
-from flask import url_for
-from invenio_search import current_search
-
-from tests.helpers import user_login
-
-_HTTP_OK = [200, 201, 204]
-BRWREQ_PID = "illbid-1"
-ITEM_ENDPOINT = "invenio_records_rest.illbid_item"
-LIST_ENDPOINT = "invenio_records_rest.illbid_list"
-
-
-def test_ill_brwreqs_list_permissions(client, testdata, json_headers, users):
-    """Test borrowing requests list permissions."""
-    patron1_brwreq = dict(
-        status="PENDING",
-        document_pid="docid-1",
-        patron_pid="1",
-        provider_pid="ill-provid-1",
-        type="PHYSICAL_COPY",
-    )
-    patron2_brwreq = dict(
-        status="PENDING",
-        document_pid="docid-1",
-        patron_pid="2",
-        provider_pid="ill-provid-1",
-        type="PHYSICAL_COPY",
-    )
-
-    def _test_list(expected_status, pids):
-        """Test get list for given pids."""
-        q = " OR ".join(["pid:{}".format(pid) for pid in pids])
-        list_url = url_for(LIST_ENDPOINT, q=q)
-        res = client.get(list_url, headers=json_headers)
-        assert res.status_code in expected_status
-        return res.get_json()
-
-    # create records
-    list_url = url_for(LIST_ENDPOINT)
-    user_login(client, "admin", users)
-    res = client.post(list_url, headers=json_headers, data=json.dumps(patron1_brwreq))
-    patron1_brwreq_pid = res.get_json()["metadata"]["pid"]
-
-    res = client.post(list_url, headers=json_headers, data=json.dumps(patron2_brwreq))
-    patron2_brwreq_pid = res.get_json()["metadata"]["pid"]
-    all_pids = [patron1_brwreq_pid, patron2_brwreq_pid]
-    # wait for ES
-    current_search.flush_and_refresh(index="ill_borrowing_requests")
-
-    # test results
-    tests = [
-        ("admin", _HTTP_OK, all_pids),
-        ("librarian", _HTTP_OK, all_pids),
-        ("patron1", _HTTP_OK, [patron1_brwreq_pid]),
-        ("patron2", _HTTP_OK, [patron2_brwreq_pid]),
-    ]
-    for username, expected_status, expected_pids in tests:
-        user_login(client, username, users)
-        results = _test_list(expected_status, all_pids)
-        assert results["hits"]["total"] == len(expected_pids)
-        found_pids = [hit["metadata"]["pid"] for hit in results["hits"]["hits"]]
-        assert set(expected_pids) == set(found_pids)
-
-    # anonymous
-    user_login(client, "anonymous", users)
-    _test_list([401], [])
-
-
-def test_ill_brwreq_details_permissions(client, testdata, json_headers, users):
-    """Test borrowing requests details permissions."""
-    dummy_borrowing_request = dict(
-        status="PENDING",
-        document_pid="docid-1",
-        patron_pid="1",
-        provider_pid="ill-provid-1",
-        type="PHYSICAL_COPY",
-    )
-
-    def _test_create(expected_status, data, user):
-        """Test record creation."""
-        url = url_for(LIST_ENDPOINT)
-        res = client.post(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-
-        if res.status_code < 400:
-            brw_req = res.get_json()["metadata"]
-            assert brw_req["status"] == "PENDING"
-            expected_created_by = dict(type="user_id", value=str(user.id))
-            assert brw_req["created_by"] == expected_created_by
-            assert not brw_req.get("updated_by")
-            return brw_req["pid"]
-
-    def _test_update(expected_status, data, pid, user):
-        """Test record update."""
-        pid_value = pid or BRWREQ_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.put(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-        if res.status_code < 400:
-            expected_changed_by = dict(type="user_id", value=str(user.id))
-            brw_req = res.get_json()["metadata"]
-            assert brw_req["created_by"] == expected_changed_by
-            assert brw_req["updated_by"] == expected_changed_by
-
-    def _test_read(expected_status, pid):
-        """Test record read."""
-        pid_value = pid or BRWREQ_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    def _test_delete(expected_status, pid):
-        """Test record delete."""
-        url = url_for(ITEM_ENDPOINT, pid_value=pid)
-        res = client.delete(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    # create/update
-    tests = [
-        ("anonymous", [401], dummy_borrowing_request),
-        ("patron2", [403], dummy_borrowing_request),
-        ("patron1", [403], dummy_borrowing_request),
-        ("librarian", _HTTP_OK, dummy_borrowing_request),
-        ("admin", _HTTP_OK, dummy_borrowing_request),
-    ]
-    for username, expected_status, data in tests:
-        user = user_login(client, username, users)
-        pid = _test_create(expected_status, data, user)
-        _test_update(expected_status, data, pid, user)
-
-    # get
-    tests = [
-        ("anonymous", [401]),
-        ("patron2", [403]),
-        ("patron1", _HTTP_OK),
-        ("librarian", _HTTP_OK),
-        ("admin", _HTTP_OK),
-    ]
-    for username, expected_status in tests:
-        user_login(client, username, users)
-        _test_read(expected_status, BRWREQ_PID)
-
-    # delete
-    tests = [
-        ("anonymous", [401]),
-        ("patron2", [403]),
-        ("patron1", [403]),
-        ("librarian", [403]),
-        ("admin", _HTTP_OK),
-    ]
-    for username, expected_status in tests:
-        user_login(client, username, users)
-        _test_delete(expected_status, BRWREQ_PID)

tests/api/ill/test_ill_providers_permissions.py

@@ -1,82 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test ILL providers."""
-
-import json
-
-from flask import url_for
-
-from tests.helpers import user_login
-
-_HTTP_OK = [200, 201, 204]
-PROVIDER_PID = "ill-provid-1"
-PROVIDER_NAME = "A library"
-PROVIDER_TYPE = "LIBRARY"
-ITEM_ENDPOINT = "invenio_records_rest.provid_item"
-LIST_ENDPOINT = "invenio_records_rest.provid_list"
-
-
-def test_ill_providers_permissions(client, testdata, json_headers, users):
-    """Test providers endpoints permissions."""
-    dummy_provider = dict(name=PROVIDER_NAME, type=PROVIDER_TYPE)
-    tests = [
-        ("admin", _HTTP_OK, dummy_provider),
-        ("librarian", _HTTP_OK, dummy_provider),
-        ("patron1", [403], dummy_provider),
-        ("anonymous", [401], dummy_provider),
-    ]
-
-    def _test_list(expected_status):
-        """Test get list."""
-        url = url_for(LIST_ENDPOINT)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    def _test_create(expected_status, data):
-        """Test record creation."""
-        url = url_for(LIST_ENDPOINT)
-        res = client.post(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-
-        if res.status_code < 400:
-            record = res.get_json()["metadata"]
-            assert record["name"] == PROVIDER_NAME
-            assert record["type"] == PROVIDER_TYPE
-            return record["pid"]
-
-    def _test_update(expected_status, data, pid):
-        """Test record update."""
-        pid_value = pid or PROVIDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.put(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-        if res.status_code < 400:
-            record = res.get_json()["metadata"]
-            assert record["name"] == PROVIDER_NAME
-
-    def _test_read(expected_status, pid):
-        """Test record read."""
-        pid_value = pid or PROVIDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    def _test_delete(expected_status, pid):
-        """Test record delete."""
-        pid_value = pid or PROVIDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.delete(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    for username, expected_status, data in tests:
-        user_login(client, username, users)
-        _test_list(expected_status)
-        pid = _test_create(expected_status, data)
-        _test_update(expected_status, data, pid)
-        _test_read(expected_status, pid)
-        _test_delete(expected_status, pid)

tests/api/ils/__init__.py

@@ -1,8 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""ILS API Tests."""

tests/api/ils/documents/__init__.py

@@ -1,8 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Document API Tests."""

tests/api/ils/documents/test_document_crud.py

@@ -1,57 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# Invenio-Circulation is free software; you can redistribute it and/or modify
-# it under the terms of the MIT License; see LICENSE file for more details.
-
-"""Tests documents CRUD."""
-
-from invenio_app_ils.documents.api import Document
-
-
-def _assert_extra_fields(doc):
-    """Test that extra fields are automatically added."""
-    assert "$schema" in doc
-    assert "circulation" in doc and "$ref" in doc["circulation"]
-    assert "relations" in doc and "$ref" in doc["relations"]
-    assert "eitems" in doc and "$ref" in doc["eitems"]
-    assert "items" in doc and "$ref" in doc["items"]
-    assert "stock" in doc and "$ref" in doc["stock"]
-
-
-def test_document_creation_refs(app):
-    """Test creation of a document."""
-    d = dict(
-        pid="a1bc",
-        created_by={"type": "script", "value": "demo"},
-        title="Test title",
-        authors=[dict(full_name="John Doe")],
-        publication_year="2010",
-        document_type="BOOK",
-    )
-    doc = Document.create(d)
-
-    _assert_extra_fields(doc)
-
-
-def test_document_update_refs(app):
-    """Test update of a document."""
-    d = dict(
-        pid="a1bc",
-        title="Test title",
-        created_by={"type": "script", "value": "demo"},
-        authors=[dict(full_name="John Doe")],
-        publication_year="2010",
-        document_type="BOOK",
-    )
-    doc = Document.create(d)
-    del doc["circulation"]
-    del doc["relations"]
-    del doc["eitems"]
-    del doc["items"]
-    del doc["stock"]
-    doc.update(dict(title="Test title 2"))
-
-    _assert_extra_fields(doc)
-    assert doc["title"] == "Test title 2"