invenio-app-ils 4.6.0__py2.py3-none-any.whl → 5.0.0__py2.py3-none-any.whl

tests/api/circulation/test_loan_item_permissions.py

@@ -1,135 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2018-2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test loans item permissions."""
-
-import json
-from copy import deepcopy
-
-from flask import url_for
-
-from tests.helpers import user_login
-
-NEW_LOAN = {
-    "item_pid": {"type": "pitmid", "value": "itemid-1"},
-    "document_pid": "docid-1",
-    "patron_pid": "1",
-    "transaction_location_pid": "locid-1",
-    "pickup_location_pid": "locid-1",
-}
-
-
-def _fetch_loan(client, json_headers, loan):
-    """Return the loan fetched with a REST call."""
-    url = url_for("invenio_records_rest.loanid_item", pid_value=loan["pid"])
-    return client.get(url, headers=json_headers)
-
-
-def _assert_get_loan_success(client, json_headers, loan):
-    """Assert that GET API call succeeded."""
-    res = _fetch_loan(client, json_headers, loan)
-    assert res.status_code == 200
-    data = json.loads(res.data.decode("utf-8"))["metadata"]
-    assert data["pid"] == loan["pid"]
-    assert data["patron_pid"] == loan["patron_pid"]
-
-
-def test_anonymous_cannot_get_any_loan(client, json_headers, testdata):
-    """Test that anonymous cannot get any loan."""
-    loan_patron1 = testdata["loans"][0]
-    assert loan_patron1["patron_pid"] == "1"
-    loan_patron2 = testdata["loans"][3]
-    assert loan_patron2["patron_pid"] == "2"
-
-    res = _fetch_loan(client, json_headers, loan_patron1)
-    assert res.status_code == 401
-    res = _fetch_loan(client, json_headers, loan_patron2)
-    assert res.status_code == 401
-
-
-def test_admin_or_librarian_can_get_any_loan(client, json_headers, users, testdata):
-    """Test that admins and librarians can get any loan."""
-    for username in ["admin", "librarian"]:
-        user_login(client, username, users)
-        # GET loans of Patron 1
-        loan_patron1 = testdata["loans"][0]
-        assert loan_patron1["patron_pid"] == "1"
-        _assert_get_loan_success(client, json_headers, loan_patron1)
-
-        # GET loans of Patron 2
-        loan_patron2 = testdata["loans"][3]
-        assert loan_patron2["patron_pid"] == "2"
-        _assert_get_loan_success(client, json_headers, loan_patron2)
-
-
-def test_patron_can_get_only_his_loans(client, json_headers, users, testdata):
-    """Test that patrons can get only their loans."""
-    loan_patron1 = testdata["loans"][0]
-    assert loan_patron1["patron_pid"] == "1"
-
-    loan_patron2 = testdata["loans"][3]
-    assert loan_patron2["patron_pid"] == "2"
-
-    # Patron 1 GET his loans
-    user_login(client, "patron1", users)
-    _assert_get_loan_success(client, json_headers, loan_patron1)
-    # Patron 1 GET loans of Patron 2
-    res = _fetch_loan(client, json_headers, loan_patron2)
-    assert res.status_code == 403
-
-    # Patron 2 GET his loans
-    user_login(client, "patron2", users)
-    _assert_get_loan_success(client, json_headers, loan_patron2)
-    # Patron 2 GET loans of Patron 1
-    res = _fetch_loan(client, json_headers, loan_patron1)
-    assert res.status_code == 403
-
-
-def _test_post_new_loan(client, json_headers, user_id, response_code):
-    """Test POST new loan."""
-    url = url_for("invenio_records_rest.loanid_list")
-    params = deepcopy(NEW_LOAN)
-    params["transaction_user_pid"] = user_id
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == response_code
-    if res.status_code == 201:
-        data = json.loads(res.data.decode("utf-8"))["metadata"]
-        return data["pid"]
-
-
-def _test_replace_existing_loan(client, json_headers, user_id, loanid, response_code):
-    """Test PUT existing loan."""
-    url = url_for("invenio_records_rest.loanid_item", pid_value=loanid)
-    params = deepcopy(NEW_LOAN)
-    params["transaction_user_pid"] = user_id
-    res = client.put(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == response_code
-
-
-def _test_delete_existing_loan(client, json_headers, loanid, response_code):
-    """Test DELETE existing loan."""
-    url = url_for("invenio_records_rest.loanid_item", pid_value=loanid)
-    res = client.delete(url, headers=json_headers)
-    assert res.status_code == response_code
-
-
-def test_anonymous_cannot_update_loans(client, json_headers, testdata):
-    """Test that anonymous cannot update loans."""
-    loanid = "loanid-1"
-    _test_post_new_loan(client, json_headers, user_id="", response_code=401)
-    _test_replace_existing_loan(
-        client, json_headers, user_id="", loanid=loanid, response_code=401
-    )
-
-
-def test_patron_cannot_update_loans(client, json_headers, users, testdata):
-    """Test that patrons cannot update loans."""
-    loanid = "loanid-1"
-    user = user_login(client, "patron1", users)
-    _test_post_new_loan(client, json_headers, user.id, 403)
-    _test_replace_existing_loan(client, json_headers, user.id, loanid, 403)
-    _test_delete_existing_loan(client, json_headers, loanid, 403)

tests/api/circulation/test_loan_item_resolver.py

@@ -1,26 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2019 CERN.
-#
-# Invenio-Circulation is free software; you can redistribute it and/or modify
-# it under the terms of the MIT License; see LICENSE file for more details.
-
-"""Tests for loan item resolver."""
-
-from invenio_circulation.api import Loan
-
-
-def test_loan_item_resolver(app, testdata):
-    """Test item resolving from loan."""
-    loan_pid = testdata["loans"][1]["pid"]
-    loan = Loan.get_record_by_pid(loan_pid)
-    loan = loan.replace_refs()
-    assert loan["item"]["pid"] == loan["item_pid"]["value"]
-
-
-def test_loan_item_resolver_for_empty_item_pid(app, testdata):
-    """Test item resolving from loan."""
-    loan_pid = testdata["loans"][0]["pid"]
-    loan = Loan.get_record_by_pid(loan_pid)
-    loan = loan.replace_refs()
-    assert loan["item"] == dict()

tests/api/circulation/test_loan_list_permissions.py

@@ -1,98 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2018-2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test loans list permissions."""
-
-import json
-
-from flask import url_for
-
-from tests.helpers import user_login, user_logout
-
-
-def _search_loans(client, json_headers, **kwargs):
-    """Return the loan fetched with a REST call."""
-    url = url_for("invenio_records_rest.loanid_list", **kwargs)
-    return client.get(url, headers=json_headers)
-
-
-def test_anonymous_cannot_search_any_loan(client, json_headers, users):
-    """Test that anonymous cannot search any loan in search results."""
-    res = _search_loans(client, json_headers)
-    assert res.status_code == 401
-
-
-def test_admin_or_librarian_can_search_any_loan(client, json_headers, users, testdata):
-    """Test that admins and librarians can search any loan."""
-    for username in ["admin", "librarian"]:
-        user_login(client, username, users)
-        res = _search_loans(client, json_headers)
-        assert res.status_code == 200
-        hits = json.loads(res.data.decode("utf-8"))
-        assert len(hits["hits"]["hits"]) == len(testdata["loans"])
-
-
-def test_patrons_can_search_their_own_loans(client, json_headers, users, testdata):
-    """Test that patrons can search their own loans."""
-
-    def _validate_only_patron_loans(res, user, state):
-        """Assert that result loans belong to the given user only."""
-        patron_loans = [
-            loan
-            for loan in testdata["loans"]
-            if loan["patron_pid"] == str(user.id) and loan["state"] == state
-        ]
-
-        assert res.status_code == 200
-        hits = json.loads(res.data.decode("utf-8"))
-        assert len(hits["hits"]["hits"]) == len(patron_loans)
-        for hit in hits["hits"]["hits"]:
-            assert hit["metadata"]["patron_pid"] == str(user.id)
-
-    state = "PENDING"
-    for username in ["patron1", "patron2"]:
-        user = user_login(client, username, users)
-        # search with no params
-        res = _search_loans(client, json_headers, state=state)
-        _validate_only_patron_loans(res, user, state)
-
-        # search with params
-        res = _search_loans(
-            client,
-            json_headers,
-            state=state,  # test extra query
-            q="patron_pid:{}".format(str(user.id)),
-        )
-        _validate_only_patron_loans(res, user, state)
-
-
-def test_patrons_cannot_search_other_loans(client, json_headers, users, testdata):
-    """Test that patrons cannot search for loans of other patrons."""
-    user_login(client, "patron1", users)
-    res = _search_loans(
-        client,
-        json_headers,
-        state="PENDING",  # test extra query
-        q="patron_pid:{}".format(str(users["patron2"].id)),
-    )
-    assert res.status_code == 403
-
-
-def test_most_loaned_permissions(client, json_headers, users, testdata):
-    """Test that only the backoffice is able to list the most loaned items."""
-    url = url_for("invenio_app_ils_circulation_stats.most-loaned")
-    tests = [
-        ("admin", 200),
-        ("librarian", 200),
-        ("patron1", 403),
-        ("anonymous", 401),
-    ]
-    for username, status in tests:
-        user_login(client, username, users)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code == status
-        user_logout(client)

tests/api/circulation/test_loan_patron_resolver.py

@@ -1,38 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2019-2020 CERN.
-#
-# Invenio-Circulation is free software; you can redistribute it and/or modify
-# it under the terms of the MIT License; see LICENSE file for more details.
-
-"""Tests for loan patron resolver."""
-
-from invenio_circulation.api import Loan
-
-
-def test_loan_patron_resolver(app, testdata):
-    """Test item resolving from loan."""
-    loan_pid = testdata["loans"][0]["pid"]
-    loan = Loan.get_record_by_pid(loan_pid)
-    loan = loan.replace_refs()
-    assert loan["patron_pid"] == loan["patron"]["id"]
-
-
-def test_loan_patron_resolver_for_non_existing_patron_pid(app, testdata):
-    """Test item resolving from loan."""
-    AnonymousPatron = app.config["ILS_PATRON_ANONYMOUS_CLASS"]
-    loan_pid = testdata["loans"][6]["pid"]
-    loan = Loan.get_record_by_pid(loan_pid)
-    loan = loan.replace_refs()
-    assert loan["patron_pid"] == str(20)
-    assert loan["patron"]["id"] == str(AnonymousPatron.id)
-    assert loan["patron"]["name"] == "anonymous"
-
-
-def test_loan_patron_resolver_for_anonymous_patron_pid(app, testdata):
-    """Test item resolving from loan."""
-    loan_pid = testdata["loans"][7]["pid"]
-    loan = Loan.get_record_by_pid(loan_pid)
-    loan = loan.replace_refs()
-    assert loan["patron_pid"] == loan["patron"]["id"]
-    assert loan["patron"]["name"] == "anonymous"

tests/api/circulation/test_loan_request.py

@@ -1,338 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2019-2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test loans item permissions."""
-
-import json
-from copy import deepcopy
-from datetime import timedelta
-
-import arrow
-from flask import url_for
-from invenio_search import current_search
-
-from tests.helpers import user_login
-
-NEW_LOAN = {
-    "document_pid": "CHANGE ME IN EACH TEST",
-    "patron_pid": "3",
-    "transaction_location_pid": "locid-1",
-    "pickup_location_pid": "locid-1",
-    "delivery": {"method": "PICKUP"},
-    "request_start_date": "2019-09-10",
-    "request_expire_date": "2019-09-20",
-}
-
-NEW_LOAN_2 = {
-    "document_pid": "CHANGE ME IN EACH TEST",
-    "patron_pid": "4",
-    "transaction_location_pid": "locid-4",  # With Sat and Sun closures
-    "pickup_location_pid": "locid-4",
-    "delivery": {"method": "PICKUP"},
-    "request_start_date": "2024-03-15",  # Friday
-    "request_expire_date": "CHANGE-MY-DATE",
-}
-
-
-def test_anonymous_cannot_request_loan(client, json_headers, testdata):
-    """Test that anonymous users cannot request a loan."""
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    res = client.post(url, headers=json_headers, data=json.dumps(NEW_LOAN))
-    assert res.status_code == 401
-
-
-def test_patron_can_request_loan(client, json_headers, users, testdata):
-    """Test that a patron can request a loan."""
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    user = user_login(client, "patron1", users)
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-3"
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "PENDING"
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["transaction_date"]
-
-
-def test_patron_can_cancel_loan(client, json_headers, users, testdata, app_config):
-    """Test that a patron can cancel its own loan."""
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    user = user_login(client, "patron3", users)
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-3"
-    params["transaction_user_pid"] = str(user.id)
-
-    # Create a Loan
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    loan = res.get_json()
-
-    cancel_url = loan["links"]["actions"]["cancel"]
-    meta = loan["metadata"]
-    payload = {
-        "document_pid": meta["document_pid"],
-        "patron_pid": meta["patron_pid"],
-        "transaction_location_pid": meta["transaction_location_pid"],
-        "transaction_user_pid": meta["transaction_user_pid"],
-        "cancel_reason": "USER_CANCEL",
-    }
-    assert res.status_code == 202
-
-    # Try to cancel a loan that belongs to patron3 as patron1
-    user_login(client, "patron1", users)
-    cancel_res = client.post(cancel_url, headers=json_headers, data=json.dumps(payload))
-    assert cancel_res.status_code == 403
-
-    # Try to cancel a loan that belongs to patron3 as patron3
-    user_login(client, "patron3", users)
-    cancel_res = client.post(cancel_url, headers=json_headers, data=json.dumps(payload))
-    assert cancel_res.status_code == 202
-
-
-def test_patron_can_request_loan_with_or_without_end_date(
-    app, client, json_headers, users, testdata
-):
-    """Test that a patron can request a loan [with/without] end date."""
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    user = user_login(client, "patron1", users)
-
-    now = arrow.utcnow()
-    start_date = (now + timedelta(days=3)).date().isoformat()
-    end_date = (now + timedelta(days=15)).date().isoformat()
-
-    # it should succeed when start/end dates provided
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-2"
-    params["request_start_date"] = start_date
-    params["request_expire_date"] = end_date
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "PENDING"
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["request_start_date"] == start_date
-    assert loan["request_expire_date"] == end_date
-    assert loan["transaction_date"]
-
-    # it should fail when wrong date provided
-    params = deepcopy(NEW_LOAN)
-    past_end_date = now - timedelta(days=30)
-    params["request_expire_date"] = past_end_date.date().isoformat()
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-
-    # it should fail when request duration over max
-    params = deepcopy(NEW_LOAN)
-    days = app.config["ILS_CIRCULATION_LOAN_REQUEST_DURATION_DAYS"]
-    past_end_date = now + timedelta(days=days + 1)
-    params["request_expire_date"] = past_end_date.date().isoformat()
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-
-    # it should fail when request start/end date not provided
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-4"
-    params["transaction_user_pid"] = str(user.id)
-    del params["request_start_date"]
-    del params["request_expire_date"]
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    now = arrow.utcnow()
-    start_date = now.date().isoformat()
-    days = app.config["ILS_CIRCULATION_LOAN_REQUEST_DURATION_DAYS"]
-    end_date = (now + timedelta(days=days)).date().isoformat()
-    assert loan["request_start_date"] == start_date
-    assert loan["request_expire_date"] == end_date
-
-
-def test_request_loan_with_or_without_delivery(
-    app, client, json_headers, users, testdata
-):
-    """Test that loan request with or without delivery."""
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    user = user_login(client, "patron1", users)
-
-    previous_dev_methods = app.config["ILS_CIRCULATION_DELIVERY_METHODS"]
-    app.config["ILS_CIRCULATION_DELIVERY_METHODS"] = {}
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-12"
-    params["transaction_user_pid"] = str(user.id)
-    del params["delivery"]
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-
-    app.config["ILS_CIRCULATION_DELIVERY_METHODS"] = {
-        "TEST_METHOD1": "",
-        "TEST_METHOD2": "",
-    }
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-6"
-    params["delivery"] = {"method": "TEST_METHOD1"}
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-
-    app.config["ILS_CIRCULATION_DELIVERY_METHODS"] = {"TEST_METHOD": ""}
-    params = deepcopy(NEW_LOAN)
-    params["transaction_user_pid"] = str(user.id)
-    del params["delivery"]
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    app.config["ILS_CIRCULATION_DELIVERY_METHODS"] = {"TEST_METHOD": ""}
-    params = deepcopy(NEW_LOAN)
-    params["delivery"] = {"method": "NON_EXISTING_METHOD"}
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    # restore
-    app.config["ILS_CIRCULATION_DELIVERY_METHODS"] = previous_dev_methods
-
-
-def test_request_loan_with_active_loan_or_loan_request(
-    app, client, json_headers, users, testdata
-):
-    """Test that a patron cannot request a loan with already an active loan or
-    a loan request on the same document.
-    """
-    # Try to request document with already a loan request
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    user = user_login(client, "patron1", users)
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-3"
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    current_search.flush_and_refresh(index="*")
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-
-    # Try to request document with already an active loan
-    user_login(client, "librarian", users)
-    url = url_for("invenio_app_ils_circulation.loan_checkout")
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-3"
-    params["transaction_user_pid"] = str(users["librarian"].id)
-    params["item_pid"] = dict(type="pitmid", value="itemid-60")
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    current_search.flush_and_refresh(index="*")
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    user = user_login(client, "patron1", users)
-    params = deepcopy(NEW_LOAN)
-    params["document_pid"] = "docid-3"
-    params["transaction_user_pid"] = str(user.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-
-
-def test_request_loan_minimum_days(app, client, json_headers, users, testdata):
-    """Test that a patron can only request a loan after a set minimum days"""
-    url = url_for("invenio_app_ils_circulation.loan_request")
-    user = user_login(client, "patron1", users)
-    app.config["ILS_CIRCULATION_LOAN_REQUEST_OFFSET"] = 4
-    params = deepcopy(NEW_LOAN)
-
-    now = arrow.utcnow()
-    start_date = now.date().isoformat()
-    params["request_start_date"] = start_date
-    params["transaction_user_pid"] = str(user.id)
-
-    params["document_pid"] = "docid-4"
-    end_date = (now + timedelta(days=2)).date().isoformat()  # FAIL
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    params["document_pid"] = "docid-5"
-    end_date = (now - timedelta(days=2)).date().isoformat()  # FAIL
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    params["document_pid"] = "docid-6"
-    end_date = now.date().isoformat()  # FAIL
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    params["document_pid"] = "docid-7"
-    end_date = (now + timedelta(days=4)).date().isoformat()  # PASS
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "PENDING"
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["transaction_date"]
-
-    params["document_pid"] = "docid-8"
-    end_date = (now + timedelta(days=8)).date().isoformat()  # PASS
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "PENDING"
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["transaction_date"]
-
-    app.config["ILS_CIRCULATION_LOAN_REQUEST_OFFSET"] = -3
-
-    params["document_pid"] = "docid-9"
-    end_date = now.date().isoformat()  # FAIL
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    params["document_pid"] = "docid-10"
-    end_date = (now - timedelta(days=2)).date().isoformat()  # FAIL
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    app.config["ILS_CIRCULATION_LOAN_REQUEST_OFFSET"] = 2
-    # By-pass default location validation for testing closures on a different location
-    location_validator, app.config["CIRCULATION_TRANSACTION_LOCATION_VALIDATOR"] = (
-        app.config["CIRCULATION_TRANSACTION_LOCATION_VALIDATOR"],
-        lambda _: True,
-    )
-    # Request Date is Friday
-    params = deepcopy(NEW_LOAN_2)
-    params["transaction_user_pid"] = str(user.id)
-
-    params["document_pid"] = "docid-11"
-    # Monday
-    params["request_expire_date"] = "2024-03-18"  # FAIL
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-    assert res.get_json()["message"] == "Validation error."
-
-    params["document_pid"] = "docid-12"
-    # Tuesday
-    params["request_expire_date"] = "2024-03-19"  # PASS
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "PENDING"
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["transaction_date"]
-
-    # Set the config back to its original state
-    app.config["CIRCULATION_TRANSACTION_LOCATION_VALIDATOR"] = location_validator