invenio-app-ils 4.6.0__py2.py3-none-any.whl → 5.0.0__py2.py3-none-any.whl

tests/api/document_requests/test_document_requests.py

@@ -1,131 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test document requests."""
-
-import json
-
-from flask import url_for
-
-from tests.helpers import user_login
-
-
-def _compare_list_data(all_expected, data, user_id, is_admin):
-    """Compare list data with expected values."""
-    if is_admin:
-        expected = []
-        for pids in all_expected.values():
-            for pid in pids:
-                expected.append(pid)
-    else:
-        expected = all_expected[str(user_id)]
-
-    for hit in data["hits"]["hits"]:
-        assert hit["metadata"]["pid"] in expected
-
-
-def test_request_list_permissions(client, testdata, json_headers, users):
-    """Test doc req list permissions."""
-    url = url_for("invenio_records_rest.dreqid_list")
-    res = client.get(url, headers=json_headers)
-    assert res.status_code == 401
-
-    requests_by_patron = {}
-    for req in testdata["document_requests"]:
-        if req["patron_pid"] not in requests_by_patron:
-            requests_by_patron[req["patron_pid"]] = []
-        requests_by_patron[req["patron_pid"]].append(req["pid"])
-
-    for username in users.keys():
-        user = user_login(client, username, users)
-        url = url_for("invenio_records_rest.dreqid_list")
-        res = client.get(url, headers=json_headers)
-        assert res.status_code == 200
-        data = json.loads(res.data.decode("utf-8"))
-        is_admin = "librarian" in user.email or "admin" in user.email
-        _compare_list_data(requests_by_patron, data, user.id, is_admin)
-
-
-def test_create_document_request(client, testdata, json_headers, users):
-    """Test creating document requests."""
-    tests = [
-        (
-            "admin",
-            201,
-            dict(
-                title="Test title",
-                request_type="LOAN",
-                medium="Paper",
-                patron_pid="1",
-            ),
-        ),
-        (
-            "librarian",
-            400,
-            dict(
-                patron_pid="1",
-            ),
-        ),
-        (
-            "admin",
-            201,
-            dict(
-                patron_pid="1",
-                title="Test",
-                invalid_param="Test",
-                request_type="LOAN",
-                medium="Paper",
-            ),
-        ),
-        (
-            "librarian",
-            201,
-            dict(
-                title="Test title",
-                patron_pid="1",
-                request_type="BUY",
-                medium="Paper",
-            ),
-        ),
-        (
-            "patron1",
-            201,
-            dict(
-                title="Test title",
-                patron_pid="1",
-                request_type="BUY",
-                medium="Paper",
-            ),
-        ),
-        (
-            "patron2",
-            400,
-            dict(
-                title="Test title",
-                patron_pid="1",
-                request_type="LOAN",
-                medium="Paper",
-            ),
-        ),
-        (
-            "patron2",
-            201,
-            dict(
-                title="Test title",
-                patron_pid="2",
-                request_type="LOAN",
-                medium="Paper",
-            ),
-        ),
-    ]
-    for username, expected_status, data in tests:
-        user_login(client, username, users)
-        url = url_for("invenio_records_rest.dreqid_list")
-        res = client.post(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code == expected_status
-        if res.status_code == 201:
-            assert "invalid_param" not in json.loads(res.data)["metadata"]

tests/api/document_requests/test_document_requests_permissions.py

@@ -1,159 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test accessibility of document request resource endpoints."""
-
-from flask import url_for
-
-from tests.helpers import user_login, validate_response
-
-
-def test_get_document_request_endpoint(client, json_headers, testdata, users):
-    """Test GET permissions."""
-
-    tests = [
-        ("patron1", "dreq-1", 200),
-        ("librarian", "dreq-1", 200),
-        ("admin", "dreq-1", 200),
-        ("patron2", "dreq-1", 403),
-        ("anonymous", "dreq-1", 401),
-        ("patron2", "dreq-2", 200),
-        ("librarian", "dreq-2", 200),
-        ("admin", "dreq-2", 200),
-        ("patron1", "dreq-2", 403),
-        ("anonymous", "dreq-2", 401),
-    ]
-
-    for user, res_id, expected_resp_code in tests:
-        user_login(client, user, users)
-        url = url_for("invenio_records_rest.dreqid_item", pid_value=res_id)
-        validate_response(client, "get", url, json_headers, None, expected_resp_code)
-
-
-def test_document_request_add_document(client, json_headers, testdata, users):
-    """Test add document to Document Request permissions."""
-
-    tests = [
-        ("patron1", "dreq-1", 403),
-        ("librarian", "dreq-1", 202),
-        ("admin", "dreq-1", 202),
-        ("anonymous", "dreq-1", 401),
-    ]
-
-    for user, res_id, expected_resp_code in tests:
-        user_login(client, user, users)
-        url = url_for(
-            "invenio_app_ils_document_requests.dreqid_document",
-            pid_value=res_id,
-        )
-        data = {"document_pid": "docid-1"}
-        validate_response(client, "post", url, json_headers, data, expected_resp_code)
-
-
-def test_document_request_remove_document(client, json_headers, testdata, users):
-    """Test remove document from Document Request permissions."""
-
-    tests = [
-        ("patron1", "dreq-1", 403),
-        ("librarian", "dreq-1", 202),
-        ("admin", "dreq-1", 202),
-        ("anonymous", "dreq-1", 401),
-    ]
-
-    for user, res_id, expected_resp_code in tests:
-        user_login(client, user, users)
-        url = url_for(
-            "invenio_app_ils_document_requests.dreqid_document",
-            pid_value=res_id,
-        )
-        data = {"document_pid": "docid-1"}
-        validate_response(client, "delete", url, json_headers, data, expected_resp_code)
-
-
-def test_document_request_add_provider(client, json_headers, testdata, users):
-    """Test add provider to Document Request permissions."""
-
-    tests = [
-        ("patron1", "dreq-1", 403),
-        ("librarian", "dreq-1", 202),
-        ("admin", "dreq-1", 202),
-        ("anonymous", "dreq-1", 401),
-    ]
-
-    for user, res_id, expected_resp_code in tests:
-        user_login(client, user, users)
-        url = url_for(
-            "invenio_app_ils_document_requests.dreqid_provider",
-            pid_value=res_id,
-        )
-        data = {
-            "physical_item_provider": {
-                "pid": "acqoid-1",
-                "pid_type": "acqoid",
-            }
-        }
-        validate_response(client, "post", url, json_headers, data, expected_resp_code)
-
-
-def test_document_request_remove_provider(client, json_headers, testdata, users):
-    """Test remove provider from Document Request permissions."""
-
-    tests = [
-        ("patron1", "dreq-1", 403),
-        ("librarian", "dreq-1", 202),
-        ("admin", "dreq-1", 202),
-        ("anonymous", "dreq-1", 401),
-    ]
-
-    for user, res_id, expected_resp_code in tests:
-        user_login(client, user, users)
-        url = url_for(
-            "invenio_app_ils_document_requests.dreqid_provider",
-            pid_value=res_id,
-        )
-        validate_response(client, "delete", url, json_headers, None, expected_resp_code)
-
-
-def test_document_request_accept(client, json_headers, testdata, users):
-    """Test Document Request permissions to accept request."""
-
-    tests = [
-        ("patron1", "dreq-1", 403),
-        ("librarian", "dreq-5", 202),
-        ("admin", "dreq-6", 202),
-        ("anonymous", "dreq-1", 401),
-        ("admin", "dreq-2", 400),
-    ]
-
-    for user, res_id, expected_resp_code in tests:
-        user_login(client, user, users)
-        url = url_for(
-            "invenio_app_ils_document_requests.dreqid_accept", pid_value=res_id
-        )
-        data = {"state": "ACCEPTED"}
-        validate_response(client, "post", url, json_headers, data, expected_resp_code)
-
-
-def test_document_request_decline(client, json_headers, testdata, users):
-    """Test Document Request permissions to decline request."""
-
-    tests = [
-        ("patron1", "dreq-1", 202),
-        ("librarian", "dreq-5", 202),
-        ("admin", "dreq-6", 202),
-        ("anonymous", "dreq-1", 401),
-        ("admin", "dreq-2", 400),
-    ]
-
-    for user, res_id, expected_resp_code in tests:
-        user_login(client, user, users)
-        url = url_for(
-            "invenio_app_ils_document_requests.dreqid_decline",
-            pid_value=res_id,
-        )
-        data = {"decline_reason": "USER_CANCEL"}
-        validate_response(client, "post", url, json_headers, data, expected_resp_code)

tests/api/document_requests/test_notifications_filter.py

@@ -1,35 +0,0 @@
-from invenio_app_ils.document_requests.notifications.api import (
-    send_document_request_notification,
-)
-
-
-def test_notification_document_request_filter(app_with_notifs, mocker, users, testdata):
-    """Test notification filtering."""
-
-    def filter_document_request_messages(record, action, **kwargs):
-        """Define notification filter."""
-        if action == "decline":
-            return False
-        return True
-
-    send_mocked = mocker.patch("invenio_app_ils.notifications.backends.mail.send")
-    send_mocked.__name__ = "send"
-    send_mocked.__annotations__ = "send"
-    backends = mocker.patch(
-        "invenio_app_ils.notifications.api._get_notification_backends",
-        return_value=[send_mocked],
-    )
-    document_request = testdata["document_requests"][0]
-    with app_with_notifs.app_context():
-        # remove footer
-        app_with_notifs.config["ILS_NOTIFICATIONS_TEMPLATES"] = {}
-        # set filtering on the document requests
-        app_with_notifs.config["ILS_NOTIFICATIONS_FILTER_DOCUMENT_REQUEST"] = (
-            filter_document_request_messages
-        )
-
-        send_document_request_notification(
-            document_request, action="decline", msg_extra_ctx={}
-        )
-
-        assert not send_mocked.apply_async.called

tests/api/ill/__init__.py

@@ -1,8 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""ILL API Tests."""

tests/api/ill/test_ill_brw_crud.py

@@ -1,74 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2021 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test record CRUD."""
-
-import pytest
-
-from invenio_app_ils.errors import DocumentNotFoundError, PatronNotFoundError
-from invenio_app_ils.ill.api import BorrowingRequest
-from invenio_app_ils.ill.errors import ILLError
-from invenio_app_ils.providers.errors import ProviderNotFoundError
-
-
-def test_brw_req_refs(app, testdata):
-    """Test creation of a borrowing request."""
-    brw_req = BorrowingRequest.create(
-        dict(
-            pid="illlid-99",
-            document_pid="docid-1",
-            patron_pid="1",
-            provider_pid="ill-provid-1",
-            status="PENDING",
-            type="PHYSICAL_COPY",
-        )
-    )
-    assert "$schema" in brw_req
-    assert "provider" in brw_req and "$ref" in brw_req["provider"]
-    assert "document" in brw_req and "$ref" in brw_req["document"]
-    assert "patron" in brw_req and "$ref" in brw_req["patron"]
-
-    brw_req = BorrowingRequest.get_record_by_pid("illbid-1")
-    brw_req = brw_req.replace_refs()
-    assert "provider" in brw_req and brw_req["provider"]["name"]
-    assert "document" in brw_req and brw_req["document"]["title"]
-    assert "patron" in brw_req and brw_req["patron"]["name"]
-
-
-def test_ill_brw_validation(db, testdata):
-    """Test validation when updating a borrowing request."""
-    borrowing_request_pid = testdata["ill_brw_reqs"][0]["pid"]
-
-    # change document pid
-    borrowing_request = BorrowingRequest.get_record_by_pid(borrowing_request_pid)
-    borrowing_request["document_pid"] = "not_found_doc"
-    with pytest.raises(DocumentNotFoundError):
-        borrowing_request.commit()
-
-    # change provider pid
-    borrowing_request = BorrowingRequest.get_record_by_pid(borrowing_request_pid)
-    borrowing_request["provider_pid"] = "not_found_lib"
-    with pytest.raises(ProviderNotFoundError):
-        borrowing_request.commit()
-
-    # change patron pid
-    borrowing_request = BorrowingRequest.get_record_by_pid(borrowing_request_pid)
-    borrowing_request["patron_pid"] = "9999"
-    with pytest.raises(PatronNotFoundError):
-        borrowing_request.commit()
-
-    # add cancel reason without status CANCELLED
-    borrowing_request = BorrowingRequest.get_record_by_pid(borrowing_request_pid)
-    borrowing_request["cancel_reason"] = "USER_CANCEL"
-    with pytest.raises(ILLError):
-        borrowing_request.commit()
-
-    # update status to CANCELLED without cancel_reason
-    borrowing_request = BorrowingRequest.get_record_by_pid(borrowing_request_pid)
-    borrowing_request["status"] = "CANCELLED"
-    with pytest.raises(ILLError):
-        borrowing_request.commit()

tests/api/ill/test_ill_brw_reqs_patron_loan_create_action.py

@@ -1,198 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test ILL borrowing requests actions."""
-
-import json
-from datetime import timedelta
-
-import arrow
-from flask import url_for
-
-from invenio_app_ils.ill.api import BORROWING_REQUEST_PID_TYPE, BorrowingRequest
-from tests.helpers import user_login
-
-_HTTP_OK = [200, 201, 204]
-ITEM_ENDPOINT = "invenio_records_rest.illbid_item"
-LIST_ENDPOINT = "invenio_records_rest.illbid_list"
-
-
-def _create_loan_action(pid, data, client, json_headers):
-    """Send request to create a new loan from the ILL."""
-    url = url_for("invenio_app_ils_ill.illbid_create_loan", pid_value=pid)
-    data["transaction_location_pid"] = "locid-1"
-    return client.post(url, headers=json_headers, data=json.dumps(data))
-
-
-def _assert_create_loan_action_fails(pid, data, client, json_headers):
-    """Asserts that the create loan action validation fails."""
-    res = _create_loan_action(pid, data, client, json_headers)
-    assert res.status_code == 400
-
-
-def test_brwreq_create_loan_only_backoffice(client, testdata, json_headers, users):
-    """Test that patron have no permission of creating loans from ILLs."""
-    user_login(client, "patron1", users)
-    res = _create_loan_action("illbid-2", dict(), client, json_headers)
-    assert res.status_code == 403
-
-
-def test_brwreq_create_loan_fails_on_wrong_status(
-    db, client, testdata, json_headers, users
-):
-    """Test borrowing requests create loan action fails on wrong status."""
-    user_login(client, "librarian", users)
-
-    def _create_new_brwreq(data=None):
-        brwreq = data or dict(
-            document_pid="docid-3",
-            provider_pid="ill-provid-2",
-            patron_pid="1",
-            status="PENDING",
-            type="PHYSICAL_COPY",
-        )
-        url = url_for(LIST_ENDPOINT)
-        res = client.post(url, headers=json_headers, data=json.dumps(brwreq))
-        assert res.status_code in _HTTP_OK
-        brw_req = res.get_json()["metadata"]
-        return brw_req["pid"]
-
-    def _update_brwreq_with_new_status(pid, status):
-        rec = BorrowingRequest.get_record_by_pid(pid)
-        rec["status"] = status
-        if status == "CANCELLED":
-            rec["cancel_reason"] = "OTHER"
-        rec.commit()
-        db.session.commit()
-
-    def _assert_fail_when_status(pid, status):
-        _update_brwreq_with_new_status(pid, status)
-
-        now = arrow.utcnow()
-        future = now + timedelta(days=15)
-        data = dict(loan_start_date=now.isoformat(), loan_end_date=future.isoformat())
-        _assert_create_loan_action_fails(pid, data, client, json_headers)
-
-    pid = _create_new_brwreq()
-
-    _assert_fail_when_status(pid, "PENDING")
-    _assert_fail_when_status(pid, "ON_LOAN")
-    _assert_fail_when_status(pid, "RETURNED")
-    _assert_fail_when_status(pid, "CANCELLED")
-
-
-def test_brwreq_create_loan_fails_on_wrong_loan_end_date(
-    db, client, testdata, json_headers, users
-):
-    """Test borrowing requests create loan action fails on wrong end date."""
-    user_login(client, "librarian", users)
-
-    # demo data "illbid-2" has the valid state `REQUESTED`
-    pid = "illbid-2"
-    # missing date param
-    _assert_create_loan_action_fails(pid, dict(), client, json_headers)
-
-    now = arrow.utcnow()
-
-    # wrong format date
-    future = now + timedelta(days=5)
-    data = dict(
-        loan_start_date=now.isoformat(),
-        loan_end_date=future.date().isoformat(),
-    )
-    _assert_create_loan_action_fails(pid, data, client, json_headers)
-    data = dict(
-        loan_start_date=now.date().isoformat(),
-        loan_end_date=future.isoformat(),
-    )
-    _assert_create_loan_action_fails(pid, data, client, json_headers)
-
-    # past date
-    past = now - timedelta(days=15)
-    data = dict(
-        loan_start_date=now.date().isoformat(),
-        loan_end_date=past.date().isoformat(),
-    )
-    _assert_create_loan_action_fails(pid, data, client, json_headers)
-
-
-def test_brwreq_create_loan_fails_on_loan_pid_already_attached(
-    db, client, testdata, json_headers, users
-):
-    """Test borrowing requests create loan action fails on loan_pid already."""
-    user_login(client, "librarian", users)
-
-    # demo data "illbid-2" has the valid state `REQUESTED`
-    pid = "illbid-2"
-
-    rec = BorrowingRequest.get_record_by_pid(pid)
-    rec.setdefault("patron_loan", {})
-    rec["patron_loan"]["pid"] = "loanid-3"
-    rec.commit()
-    db.session.commit()
-
-    # already with a loan pid for some reasons
-    now = arrow.utcnow()
-    future = now + timedelta(days=5)
-    data = dict(
-        loan_start_date=now.date().isoformat(),
-        loan_end_date=future.date().isoformat(),
-    )
-    _assert_create_loan_action_fails(pid, data, client, json_headers)
-
-
-def test_brwreq_create_loan_succeeds(db, client, testdata, json_headers, users):
-    """Test borrowing requests create loan action succeeds."""
-    user = user_login(client, "librarian", users)
-
-    # demo data "illbid-2" has the valid state `REQUESTED`
-    pid = "illbid-2"
-
-    now = arrow.utcnow()
-    start = (now + timedelta(days=3)).date().isoformat()
-    future = (now + timedelta(days=5)).date().isoformat()
-    data = dict(loan_start_date=start, loan_end_date=future)
-    res = _create_loan_action(pid, data, client, json_headers)
-    assert res.status_code in _HTTP_OK
-    brw_req = res.get_json()["metadata"]
-
-    assert brw_req["status"] == "ON_LOAN"
-    assert "patron_loan" in brw_req
-    patron_loan = brw_req["patron_loan"]
-    assert "pid" in patron_loan
-    assert "loan" in patron_loan
-    loan = patron_loan["loan"]
-    assert patron_loan["pid"] == loan["pid"]
-    assert loan["end_date"] == future
-    loan_pid = loan["pid"]
-
-    # fetch the loan
-    url = url_for("invenio_records_rest.loanid_item", pid_value=loan_pid)
-    res = client.get(url, headers=json_headers)
-    assert res.status_code in _HTTP_OK
-    loan = res.get_json()["metadata"]
-
-    # make sure the loan is created with the data from the ILL
-    assert loan["item_pid"] == dict(type=BORROWING_REQUEST_PID_TYPE, value=pid)
-    assert loan["start_date"] == start
-    assert loan["end_date"] == future
-    assert loan["document_pid"] == brw_req["document_pid"]
-    assert loan["patron_pid"] == brw_req["patron_pid"]
-    assert loan["transaction_user_pid"] == str(user.id)
-
-    # update notes (a random field)
-    brw_req["notes"] = "This is a note"
-    url = url_for(ITEM_ENDPOINT, pid_value=pid)
-    res = client.put(url, headers=json_headers, data=json.dumps(brw_req))
-    assert res.status_code in _HTTP_OK
-    updated_brw_req = res.get_json()["metadata"]
-
-    # make sure `patron_loan` system field is preserved
-    assert updated_brw_req["notes"] == "This is a note"
-    assert "patron_loan" in updated_brw_req
-    assert "pid" in patron_loan
-    assert "loan" in patron_loan