crackerjack 0.37.9__py3-none-any.whl → 0.45.2__py3-none-any.whl

crackerjack/managers/hook_manager.py

@@ -1,81 +1,403 @@
-import subprocess
 import typing as t
+from contextlib import suppress
 from pathlib import Path
 
-from rich.console import Console
+from acb.console import Console
+from acb.depends import depends
 
+from crackerjack.config import CrackerjackSettings
 from crackerjack.config.hooks import HookConfigLoader
 from crackerjack.executors.hook_executor import HookExecutor
 from crackerjack.executors.lsp_aware_hook_executor import LSPAwareHookExecutor
+from crackerjack.executors.progress_hook_executor import ProgressHookExecutor
 from crackerjack.models.task import HookResult
 
+if t.TYPE_CHECKING:
+    from crackerjack.orchestration.hook_orchestrator import HookOrchestratorAdapter
+
 
 class HookManagerImpl:
+    executor: HookExecutor | LSPAwareHookExecutor | ProgressHookExecutor
+
+    def _setup_git_service(self, use_incremental: bool, pkg_path: Path):
+        """Setup GitService for incremental execution."""
+        from crackerjack.services.git import GitService
+
+        git_service = None
+        if use_incremental:
+            git_service = GitService(self.console, pkg_path)
+        return git_service
+
+    def _setup_executor(
+        self,
+        pkg_path: Path,
+        verbose: bool,
+        quiet: bool,
+        debug: bool,
+        enable_lsp_optimization: bool,
+        enable_tool_proxy: bool,
+        use_incremental: bool,
+        git_service: t.Any,
+    ):
+        """Setup the appropriate executor based on configuration."""
+        if enable_lsp_optimization:
+            self.executor = LSPAwareHookExecutor(
+                self.console,
+                pkg_path,
+                verbose,
+                quiet,
+                debug,
+                use_tool_proxy=enable_tool_proxy,
+                use_incremental=use_incremental,
+                git_service=git_service,
+            )
+        else:
+            # Use HookExecutor - match what tests expect
+            # Pass only the expected positional arguments for test compatibility
+            self.executor = HookExecutor(  # type: ignore[assignment]
+                self.console,
+                pkg_path,
+                verbose,
+                quiet,
+            )
+
+    def _load_from_project_config(
+        self,
+        config_path: Path,
+        enable_orchestration: bool | None,
+        orchestration_mode: str | None,
+    ) -> None:
+        """Load orchestration config from project .crackerjack.yaml file."""
+        from crackerjack.orchestration.config import OrchestrationConfig
+
+        loaded_config = OrchestrationConfig.load(config_path)
+        self._orchestration_config: t.Any = loaded_config  # Can be either OrchestrationConfig or HookOrchestratorSettings
+        # Extract orchestration settings with param override
+        self.orchestration_enabled = (
+            enable_orchestration
+            if enable_orchestration is not None
+            else loaded_config.enable_orchestration
+        )
+        self.orchestration_mode = (
+            orchestration_mode
+            if orchestration_mode is not None
+            else loaded_config.orchestration_mode
+        )
+
+    def _create_default_orchestration_config(
+        self,
+        enable_orchestration: bool | None,
+        orchestration_mode: str | None,
+        enable_caching: bool,
+        cache_backend: str,
+    ) -> None:
+        """Create default orchestration config from constructor params."""
+        from crackerjack.orchestration.hook_orchestrator import (
+            HookOrchestratorSettings,
+        )
+
+        self._orchestration_config = HookOrchestratorSettings(
+            enable_caching=enable_caching,
+            cache_backend=cache_backend,
+        )
+        # Default to enabled unless explicitly disabled
+        # Fallback chain: explicit param -> DI settings -> True (application default)
+        self.orchestration_enabled = (
+            bool(enable_orchestration)
+            if enable_orchestration is not None
+            else getattr(self._settings, "enable_orchestration", True)
+        )
+        self.orchestration_mode = (
+            orchestration_mode
+            if orchestration_mode is not None
+            else (self._settings.orchestration_mode or "acb")
+        )
+
+    def _load_orchestration_config(
+        self,
+        pkg_path: Path,
+        orchestration_config: t.Any,
+        enable_orchestration: bool | None,
+        orchestration_mode: str | None,
+        enable_caching: bool,
+        cache_backend: str,
+    ):
+        """Load orchestration configuration with priority."""
+        # Get settings from ACB dependency injection
+        self._settings = depends.get_sync(CrackerjackSettings)
+
+        # Load orchestration config with priority:
+        # 1. Explicit orchestration_config param (highest - for testing)
+        # 2. Project .crackerjack.yaml file (middle - for project-specific settings)
+        # 3. Create from constructor params + DI settings (lowest - for defaults)
+        if orchestration_config:
+            # Explicit config object provided - use its values directly
+            # Legacy parameters (enable_orchestration, orchestration_mode) are ignored
+            # when an explicit config object is provided
+            self._orchestration_config = orchestration_config
+            self.orchestration_enabled = getattr(
+                orchestration_config, "enable_orchestration", False
+            )
+            self.orchestration_mode = getattr(
+                orchestration_config, "orchestration_mode", "acb"
+            )
+        else:
+            config_path = pkg_path / ".crackerjack.yaml"
+            if config_path.exists():
+                self._load_from_project_config(
+                    config_path, enable_orchestration, orchestration_mode
+                )
+            else:
+                self._create_default_orchestration_config(
+                    enable_orchestration,
+                    orchestration_mode,
+                    enable_caching,
+                    cache_backend,
+                )
+
     def __init__(
         self,
-        console: Console,
         pkg_path: Path,
         verbose: bool = False,
         quiet: bool = False,
+        debug: bool = False,
         enable_lsp_optimization: bool = False,
         enable_tool_proxy: bool = True,
+        use_incremental: bool = False,
+        # Legacy parameters kept for backward compatibility (deprecated)
+        orchestration_config: t.Any = None,
+        enable_orchestration: bool | None = None,
+        orchestration_mode: str | None = None,
+        enable_caching: bool = True,
+        cache_backend: str = "memory",
+        console: t.Any = None,  # Accept console parameter for DI
     ) -> None:
-        self.console = console
         self.pkg_path = pkg_path
-        self.executor: HookExecutor
+        self.debug = debug
+
+        # Use provided console or get from DI
+        self.console = console or depends.get_sync(Console)
+
+        # Get GitService for incremental execution
+        git_service = self._setup_git_service(use_incremental, pkg_path)
 
         # Use LSP-aware executor if optimization is enabled
-        if enable_lsp_optimization:
-            self.executor = LSPAwareHookExecutor(
-                console, pkg_path, verbose, quiet, use_tool_proxy=enable_tool_proxy
-            )
-        else:
-            self.executor = HookExecutor(console, pkg_path, verbose, quiet)
+        self._setup_executor(
+            pkg_path,
+            verbose,
+            quiet,
+            debug,
+            enable_lsp_optimization,
+            enable_tool_proxy,
+            use_incremental,
+            git_service,
+        )
 
         self.config_loader = HookConfigLoader()
         self._config_path: Path | None = None
         self.lsp_optimization_enabled = enable_lsp_optimization
         self.tool_proxy_enabled = enable_tool_proxy
 
+        self._load_orchestration_config(
+            pkg_path,
+            orchestration_config,
+            enable_orchestration,
+            orchestration_mode,
+            enable_caching,
+            cache_backend,
+        )
+
+        self._orchestrator: HookOrchestratorAdapter | None = None
+
     def set_config_path(self, config_path: Path) -> None:
         self._config_path = config_path
 
+    async def _init_orchestrator(self) -> None:
+        """Initialize orchestrator if not already initialized."""
+        if self._orchestrator is not None:
+            return  # Already initialized
+
+        from crackerjack.orchestration.hook_orchestrator import (
+            HookOrchestratorAdapter,
+            HookOrchestratorSettings,
+        )
+
+        # Create orchestrator settings from orchestration config
+        # Handle both OrchestrationConfig (uses orchestration_mode) and
+        # HookOrchestratorSettings (uses execution_mode)
+        execution_mode = getattr(
+            self._orchestration_config,
+            "execution_mode",
+            getattr(self._orchestration_config, "orchestration_mode", "acb"),
+        )
+
+        orchestrator_settings = HookOrchestratorSettings(
+            execution_mode=execution_mode,
+            enable_caching=self._orchestration_config.enable_caching,
+            cache_backend=self._orchestration_config.cache_backend,
+            max_parallel_hooks=self._orchestration_config.max_parallel_hooks,
+            enable_adaptive_execution=getattr(
+                self._orchestration_config, "enable_adaptive_execution", True
+            ),
+        )
+
+        self._orchestrator = HookOrchestratorAdapter(
+            settings=orchestrator_settings,
+            hook_executor=self.executor,  # Provide executor for legacy mode fallback
+        )
+
+        await self._orchestrator.init()
+
+    async def _run_fast_hooks_orchestrated(self) -> list[HookResult]:
+        """Run fast hooks using orchestrator (async path)."""
+        await self._init_orchestrator()
+        assert self._orchestrator is not None
+
+        strategy = self.config_loader.load_strategy("fast")
+
+        if self._config_path:
+            for hook in strategy.hooks:
+                hook.config_path = self._config_path
+
+        # Check for progress callback from PhaseCoordinator
+        getattr(self, "_progress_callback", None)
+
+        return await self._orchestrator.execute_strategy(
+            strategy,
+            progress_callback=getattr(self, "_progress_callback", None),
+            progress_start_callback=getattr(self, "_progress_start_callback", None),
+        )
+
+    async def _run_comprehensive_hooks_orchestrated(self) -> list[HookResult]:
+        """Run comprehensive hooks using orchestrator (async path)."""
+        await self._init_orchestrator()
+        assert self._orchestrator is not None
+
+        strategy = self.config_loader.load_strategy("comprehensive")
+
+        if self._config_path:
+            for hook in strategy.hooks:
+                hook.config_path = self._config_path
+
+        # Check for progress callback from PhaseCoordinator
+        getattr(self, "_progress_callback", None)
+
+        return await self._orchestrator.execute_strategy(
+            strategy,
+            progress_callback=getattr(self, "_progress_callback", None),
+            progress_start_callback=getattr(self, "_progress_start_callback", None),
+        )
+
     def run_fast_hooks(self) -> list[HookResult]:
+        # Use orchestrator if enabled (Phase 3+)
+        if self.orchestration_enabled:
+            import asyncio
+
+            # Check if we're already in an event loop (e.g., during testing)
+            try:
+                asyncio.get_running_loop()
+                # We're in an event loop, run in thread
+                import concurrent.futures
+
+                # Let executor show progress - orchestrator doesn't display progress
+                with concurrent.futures.ThreadPoolExecutor() as executor:
+                    future = executor.submit(
+                        asyncio.run, self._run_fast_hooks_orchestrated()
+                    )
+                    return future.result()
+            except RuntimeError:
+                # No event loop running, safe to use asyncio.run()
+                return asyncio.run(self._run_fast_hooks_orchestrated())
+
+        # Legacy executor path (Phase 1-2)
         strategy = self.config_loader.load_strategy("fast")
 
         if self._config_path:
             for hook in strategy.hooks:
                 hook.config_path = self._config_path
+        # Wire progress callbacks for legacy executor path so ticks update
+        with suppress(Exception):
+            self.executor.set_progress_callbacks(
+                started_cb=getattr(self, "_progress_start_callback", None),
+                completed_cb=getattr(self, "_progress_callback", None),
+                total=len(strategy.hooks),
+            )
         execution_result = self.executor.execute_strategy(strategy)
         return execution_result.results
 
     def run_comprehensive_hooks(self) -> list[HookResult]:
+        # Use orchestrator if enabled (Phase 3+)
+        if self.orchestration_enabled:
+            import asyncio
+
+            # Check if we're already in an event loop (e.g., during testing)
+            try:
+                asyncio.get_running_loop()
+                # We're in an event loop, run in thread
+                import concurrent.futures
+
+                # Let executor show progress - orchestrator doesn't display progress
+                with concurrent.futures.ThreadPoolExecutor() as executor:
+                    future = executor.submit(
+                        asyncio.run, self._run_comprehensive_hooks_orchestrated()
+                    )
+                    return future.result()
+            except RuntimeError:
+                # No event loop running, safe to use asyncio.run()
+                return asyncio.run(self._run_comprehensive_hooks_orchestrated())
+
+        # Legacy executor path (Phase 1-2)
         strategy = self.config_loader.load_strategy("comprehensive")
 
         if self._config_path:
             for hook in strategy.hooks:
                 hook.config_path = self._config_path
+        # Wire progress callbacks for legacy executor path so ticks update
+        with suppress(Exception):
+            self.executor.set_progress_callbacks(
+                started_cb=getattr(self, "_progress_start_callback", None),
+                completed_cb=getattr(self, "_progress_callback", None),
+                total=len(strategy.hooks),
+            )
         execution_result = self.executor.execute_strategy(strategy)
         return execution_result.results
 
+    async def _run_hooks_parallel(self) -> list[HookResult]:
+        """Run fast and comprehensive strategies in parallel (async helper)."""
+        import asyncio
+
+        fast_task = self._run_fast_hooks_orchestrated()
+        comp_task = self._run_comprehensive_hooks_orchestrated()
+
+        fast_results, comp_results = await asyncio.gather(fast_task, comp_task)
+        return fast_results + comp_results
+
     def run_hooks(self) -> list[HookResult]:
-        fast_results = self.run_fast_hooks()
-        comprehensive_results = self.run_comprehensive_hooks()
-        return fast_results + comprehensive_results
+        # Phase 5-7: Enable strategy-level parallelism when orchestration is enabled
+        # Use config's enable_strategy_parallelism setting (defaults to True if not set)
+        enable_parallelism = getattr(
+            self._orchestration_config, "enable_strategy_parallelism", True
+        )
+        if self.orchestration_enabled and enable_parallelism:
+            import asyncio
 
-    def get_execution_info(self) -> dict[str, t.Any]:
-        """Get information about current execution mode and capabilities."""
-        info = {
-            "lsp_optimization_enabled": self.lsp_optimization_enabled,
-            "tool_proxy_enabled": self.tool_proxy_enabled,
-            "executor_type": type(self.executor).__name__,
-        }
+            # Check if we're already in an event loop (e.g., during testing)
+            try:
+                asyncio.get_running_loop()
+                # We're in an event loop, use nest_asyncio or run in thread
+                import concurrent.futures
 
-        # Get LSP-specific info if available
-        if hasattr(self.executor, "get_execution_mode_summary"):
-            info.update(self.executor.get_execution_mode_summary())
+                with concurrent.futures.ThreadPoolExecutor() as executor:
+                    future = executor.submit(asyncio.run, self._run_hooks_parallel())
+                    return future.result()
+            except RuntimeError:
+                # No event loop running, safe to use asyncio.run()
+                return asyncio.run(self._run_hooks_parallel())
 
-        return info
+        # Legacy path: Sequential execution (backward compatibility)
+        fast_results = self.run_fast_hooks()
+        comprehensive_results = self.run_comprehensive_hooks()
+        return fast_results + comprehensive_results
 
     def configure_lsp_optimization(self, enable: bool) -> None:
         """Enable or disable LSP optimization by switching executors."""
@@ -84,7 +406,7 @@ class HookManagerImpl:
 
         # Switch executor based on the enable flag
         if enable:
-            self.executor = LSPAwareHookExecutor(
+            self.executor = LSPAwareHookExecutor(  # type: ignore[assignment]
                 self.console,
                 self.pkg_path,
                 verbose=getattr(self.executor, "verbose", False),
@@ -92,7 +414,7 @@ class HookManagerImpl:
                 use_tool_proxy=self.tool_proxy_enabled,
             )
         else:
-            self.executor = HookExecutor(
+            self.executor = HookExecutor(  # type: ignore[assignment]
                 self.console,
                 self.pkg_path,
                 verbose=getattr(self.executor, "verbose", False),
@@ -127,18 +449,54 @@ class HookManagerImpl:
             if self._config_path:
                 pass  # Config path handled at manager level
 
-    def validate_hooks_config(self) -> bool:
-        try:
-            result = subprocess.run(
-                ["uv", "run", "pre-commit", "validate-config"],
-                cwd=self.pkg_path,
-                capture_output=True,
-                text=True,
-                check=False,
-            )
-            return result.returncode == 0
-        except Exception:
-            return False
+    async def get_orchestration_stats(self) -> dict[str, t.Any] | None:
+        """Get orchestration statistics if orchestrator is initialized.
+
+        Returns:
+            Dictionary with orchestration stats, or None if orchestration disabled
+        """
+        if not self.orchestration_enabled or self._orchestrator is None:
+            return None
+
+        return await self._orchestrator.get_cache_stats()
+
+    def get_execution_info(self) -> dict[str, t.Any]:
+        """Get information about current execution mode and capabilities."""
+        info = {
+            "lsp_optimization_enabled": self.lsp_optimization_enabled,
+            "tool_proxy_enabled": self.tool_proxy_enabled,
+            "executor_type": type(self.executor).__name__,
+            # Use instance properties which may override settings via constructor params
+            "orchestration_enabled": self.orchestration_enabled,
+            "orchestration_mode": (
+                self.orchestration_mode if self.orchestration_enabled else None
+            ),
+            "caching_enabled": (
+                self._orchestration_config.enable_caching
+                if self.orchestration_enabled
+                else False
+            ),
+            "cache_backend": (
+                self._orchestration_config.cache_backend
+                if self.orchestration_enabled
+                else None
+            ),
+        }
+
+        # Get LSP-specific info if available
+        if hasattr(self.executor, "get_execution_mode_summary"):
+            info.update(self.executor.get_execution_mode_summary())
+
+        return info
+
+    @staticmethod
+    def validate_hooks_config() -> bool:
+        """Validate hooks configuration.
+
+        Phase 8.5: This method is deprecated. Direct tool invocation doesn't require
+        pre-commit config validation. Always returns True for backward compatibility.
+        """
+        return True
 
     def get_hook_ids(self) -> list[str]:
         fast_strategy = self.config_loader.load_strategy("fast")
@@ -147,49 +505,55 @@ class HookManagerImpl:
         all_hooks = fast_strategy.hooks + comprehensive_strategy.hooks
         return [hook.name for hook in all_hooks]
 
+    def get_hook_count(self, suite_name: str) -> int:
+        """Get the number of hooks in a specific suite.
+
+        Args:
+            suite_name: Name of the suite ('fast' or 'comprehensive')
+
+        Returns:
+            Number of hooks in the suite
+        """
+        strategy = self.config_loader.load_strategy(suite_name)
+        return len(strategy.hooks)
+
     def install_hooks(self) -> bool:
-        try:
-            result = subprocess.run(
-                ["uv", "run", "pre-commit", "install"],
-                check=False,
-                cwd=self.pkg_path,
-                capture_output=True,
-                text=True,
-                timeout=30,
-            )
-            if result.returncode == 0:
-                self.console.print("[green]✅[/ green] Pre-commit hooks installed")
-                return True
-            self.console.print(
-                f"[red]❌[/ red] Failed to install hooks: {result.stderr}",
-            )
-            return False
-        except Exception as e:
-            self.console.print(f"[red]❌[/ red] Error installing hooks: {e}")
-            return False
+        """Install git hooks.
+
+        Phase 8.5: This method is deprecated. Direct tool invocation doesn't require
+        pre-commit hook installation. Returns True with informational message.
+        """
+        self.console.print(
+            "[yellow]ℹ️[/yellow] Hook installation not required with direct invocation"
+        )
+        return True
 
     def update_hooks(self) -> bool:
-        try:
-            result = subprocess.run(
-                ["uv", "run", "pre-commit", "autoupdate"],
-                check=False,
-                cwd=self.pkg_path,
-                capture_output=True,
-                text=True,
-                timeout=60,
-            )
-            if result.returncode == 0:
-                self.console.print("[green]✅[/ green] Pre-commit hooks updated")
-                return True
-            self.console.print(
-                f"[red]❌[/ red] Failed to update hooks: {result.stderr}",
-            )
-            return False
-        except Exception as e:
-            self.console.print(f"[red]❌[/ red] Error updating hooks: {e}")
-            return False
+        """Update hooks to latest versions.
+
+        Phase 8.5: This method is deprecated. Direct tool invocation uses UV for
+        dependency management. Returns True with informational message.
+        """
+        self.console.print(
+            "[yellow]ℹ️[/yellow] Hook updates managed via UV dependency resolution"
+        )
+        return True
 
-    def get_hook_summary(self, results: list[HookResult]) -> dict[str, t.Any]:
+    @staticmethod
+    def get_hook_summary(
+        results: list[HookResult], elapsed_time: float | None = None
+    ) -> dict[str, t.Any]:
+        """Calculate summary statistics for hook execution results.
+
+        Args:
+            results: List of hook execution results
+            elapsed_time: Optional wall-clock elapsed time in seconds.
+                         If provided, used as total_duration (critical for parallel execution).
+                         If None, falls back to sum of individual durations (sequential mode).
+
+        Returns:
+            Dictionary with execution statistics
+        """
         if not results:
             return {
                 "total": 0,
@@ -203,7 +567,13 @@ class HookManagerImpl:
         passed = sum(1 for r in results if r.status == "passed")
         failed = sum(1 for r in results if r.status == "failed")
         errors = sum(1 for r in results if r.status in ("timeout", "error"))
-        total_duration = sum(r.duration for r in results)
+
+        # Use wall-clock time if provided (parallel execution), else sum durations (sequential)
+        total_duration = (
+            elapsed_time
+            if elapsed_time is not None
+            else sum(r.duration for r in results)
+        )
 
         return {
             "total": len(results),