crackerjack 0.37.9__py3-none-any.whl → 0.45.2__py3-none-any.whl

crackerjack/orchestration/strategies/parallel_strategy.py

@@ -0,0 +1,237 @@
+"""Parallel execution strategy for hook orchestration.
+
+Implements concurrent hook execution with resource limits, timeout handling,
+and exception isolation. Uses asyncio.Semaphore for throttling.
+"""
+
+from __future__ import annotations
+
+import asyncio
+import logging
+import typing as t
+
+from crackerjack.config.hooks import HookDefinition
+from crackerjack.models.task import HookResult
+
+# Module-level logger
+logger = logging.getLogger(__name__)
+
+
+class ParallelExecutionStrategy:
+    """Parallel execution strategy with resource limits.
+
+    Features:
+    - Concurrent execution using asyncio.gather()
+    - Semaphore-based resource limiting (max concurrent hooks)
+    - Per-hook timeout handling with asyncio.wait_for()
+    - Exception isolation (one failure doesn't stop others)
+    - Structured logging for execution flow
+
+    Use when:
+    - Hooks are independent (no dependencies)
+    - Want to maximize throughput
+    - System has sufficient resources
+
+    Example:
+        ```python
+        strategy = ParallelExecutionStrategy(max_parallel=3)
+        results = await strategy.execute(hooks=[hook1, hook2, hook3], timeout=300)
+        ```
+    """
+
+    def __init__(
+        self,
+        max_parallel: int = 3,
+        default_timeout: int = 300,
+    ) -> None:
+        """Initialize parallel execution strategy.
+
+        Args:
+            max_parallel: Maximum concurrent hook executions
+            default_timeout: Default timeout per hook in seconds
+        """
+        self.max_parallel = max_parallel
+        self.default_timeout = default_timeout
+        self.semaphore: asyncio.Semaphore | None = None
+
+        logger.debug(
+            "ParallelExecutionStrategy initialized",
+            extra={
+                "max_parallel": max_parallel,
+                "default_timeout": default_timeout,
+            },
+        )
+
+    async def execute(
+        self,
+        hooks: list[HookDefinition],
+        max_parallel: int | None = None,
+        timeout: int | None = None,
+        executor_callable: t.Callable[[HookDefinition], t.Awaitable[HookResult]]
+        | None = None,
+    ) -> list[HookResult]:
+        """Execute hooks in parallel with resource limits.
+
+        Args:
+            hooks: List of hook definitions to execute
+            max_parallel: Optional override for max concurrent executions
+            timeout: Optional override for default timeout
+            executor_callable: Async function that executes a single hook
+
+        Returns:
+            List of HookResult objects (same order as input hooks)
+        """
+        if not hooks:
+            logger.debug("No hooks to execute")
+            return []
+
+        max_par = max_parallel or self.max_parallel
+        timeout_sec = timeout or self.default_timeout
+
+        # Create fresh semaphore for this execution
+        self.semaphore = asyncio.Semaphore(max_par)
+
+        logger.info(
+            "Starting parallel execution",
+            extra={
+                "hook_count": len(hooks),
+                "max_parallel": max_par,
+                "timeout": timeout_sec,
+            },
+        )
+
+        async def execute_with_limit(hook: HookDefinition) -> HookResult:
+            """Execute hook with semaphore and timeout."""
+            async with self.semaphore:  # type: ignore
+                try:
+                    hook_timeout = hook.timeout or timeout_sec
+                    logger.debug(
+                        f"Executing hook {hook.name}",
+                        extra={
+                            "hook": hook.name,
+                            "timeout": hook_timeout,
+                        },
+                    )
+
+                    if executor_callable:
+                        result = await asyncio.wait_for(
+                            executor_callable(hook), timeout=hook_timeout
+                        )
+                    else:
+                        # Placeholder if no executor provided
+                        result = self._placeholder_result(hook)
+
+                    logger.debug(
+                        f"Hook {hook.name} completed",
+                        extra={
+                            "hook": hook.name,
+                            "status": result.status,
+                            "duration": result.duration,
+                        },
+                    )
+                    return result
+
+                except TimeoutError:
+                    logger.warning(
+                        f"Hook {hook.name} timed out",
+                        extra={
+                            "hook": hook.name,
+                            "timeout": hook_timeout,
+                        },
+                    )
+                    return HookResult(
+                        id=hook.name,
+                        name=hook.name,
+                        status="timeout",
+                        duration=hook_timeout,
+                        issues_found=[f"Hook timed out after {hook_timeout}s"],
+                    )
+                except Exception as e:
+                    logger.error(
+                        f"Hook {hook.name} raised exception",
+                        extra={
+                            "hook": hook.name,
+                            "exception": str(e),
+                            "exception_type": type(e).__name__,
+                        },
+                    )
+                    return HookResult(
+                        id=hook.name,
+                        name=hook.name,
+                        status="error",
+                        duration=0.0,
+                        issues_found=[f"Exception: {type(e).__name__}: {e}"],
+                    )
+
+        # Create tasks for all hooks
+        tasks = [execute_with_limit(hook) for hook in hooks]
+
+        # Execute all tasks concurrently
+        results = await asyncio.gather(*tasks, return_exceptions=True)
+
+        # Handle any unexpected exceptions (shouldn't happen due to try/except above)
+        final_results = []
+        for hook, result in zip(hooks, results):
+            if isinstance(result, HookResult):
+                final_results.append(result)
+            else:
+                logger.error(
+                    "Unexpected exception from gather",
+                    extra={
+                        "hook": hook.name,
+                        "exception": str(result),
+                        "exception_type": type(result).__name__,
+                    },
+                )
+                final_results.append(self._error_result(hook, result))
+
+        logger.info(
+            "Parallel execution complete",
+            extra={
+                "total_hooks": len(final_results),
+                "passed": sum(1 for r in final_results if r.status == "passed"),
+                "failed": sum(1 for r in final_results if r.status == "failed"),
+                "errors": sum(
+                    1 for r in final_results if r.status in ("timeout", "error")
+                ),
+            },
+        )
+
+        return final_results
+
+    def get_execution_order(
+        self,
+        hooks: list[HookDefinition],
+    ) -> list[list[HookDefinition]]:
+        """Return batches of hooks for execution.
+
+        Parallel strategy can execute all hooks in a single batch.
+
+        Args:
+            hooks: List of hook definitions
+
+        Returns:
+            List containing one batch with all hooks
+        """
+        return [hooks] if hooks else []
+
+    def _placeholder_result(self, hook: HookDefinition) -> HookResult:
+        """Create placeholder result when no executor provided."""
+        return HookResult(
+            id=hook.name,
+            name=hook.name,
+            status="passed",
+            duration=0.0,
+            issues_found=[],  # Initialize with empty list to match expected format
+            files_processed=0,
+        )
+
+    def _error_result(self, hook: HookDefinition, error: BaseException) -> HookResult:
+        """Create error HookResult from exception."""
+        return HookResult(
+            id=hook.name,
+            name=hook.name,
+            status="error",
+            duration=0.0,
+            issues_found=[f"Exception: {type(error).__name__}: {error}"],
+        )

crackerjack/orchestration/strategies/sequential_strategy.py

@@ -0,0 +1,299 @@
+"""Sequential execution strategy for hook orchestration.
+
+Implements one-at-a-time hook execution with support for early exit on
+critical failures and dependency ordering.
+"""
+
+from __future__ import annotations
+
+import asyncio
+import logging
+import typing as t
+
+from crackerjack.config.hooks import HookDefinition, SecurityLevel
+from crackerjack.models.task import HookResult
+
+# Module-level logger
+logger = logging.getLogger(__name__)
+
+
+class SequentialExecutionStrategy:
+    """Sequential execution strategy for dependent hooks.
+
+    Features:
+    - One-at-a-time execution (respects dependencies)
+    - Early exit on critical security failures
+    - Per-hook timeout handling
+    - Comprehensive logging for debugging
+
+    Use when:
+    - Hooks have dependencies (gitleaks → bandit)
+    - Resource constraints require sequential execution
+    - Debugging requires isolated execution
+    - Critical failures should stop the pipeline
+
+    Example:
+        ```python
+        strategy = SequentialExecutionStrategy()
+        results = await strategy.execute(hooks=[hook1, hook2, hook3], timeout=300)
+        ```
+    """
+
+    def __init__(
+        self,
+        default_timeout: int = 300,
+        stop_on_critical_failure: bool = True,
+    ) -> None:
+        """Initialize sequential execution strategy.
+
+        Args:
+            default_timeout: Default timeout per hook in seconds
+            stop_on_critical_failure: Stop execution if critical hook fails
+        """
+        self.default_timeout = default_timeout
+        self.stop_on_critical_failure = stop_on_critical_failure
+
+        logger.debug(
+            "SequentialExecutionStrategy initialized",
+            extra={
+                "default_timeout": default_timeout,
+                "stop_on_critical_failure": stop_on_critical_failure,
+            },
+        )
+
+    async def execute(
+        self,
+        hooks: list[HookDefinition],
+        max_parallel: int | None = None,  # Ignored for sequential
+        timeout: int | None = None,
+        executor_callable: t.Callable[[HookDefinition], t.Awaitable[HookResult]]
+        | None = None,
+    ) -> list[HookResult]:
+        """Execute hooks sequentially.
+
+        Args:
+            hooks: List of hook definitions to execute
+            max_parallel: Ignored (kept for protocol compatibility)
+            timeout: Optional override for default timeout
+            executor_callable: Async function that executes a single hook
+
+        Returns:
+            List of HookResult objects (may be partial if early exit)
+        """
+        if not hooks:
+            logger.debug("No hooks to execute")
+            return []
+
+        timeout_sec = timeout or self.default_timeout
+        self._log_execution_start(hooks, timeout_sec)
+
+        results = []
+        for idx, hook in enumerate(hooks, 1):
+            result = await self._execute_single_hook(
+                hook, idx, len(hooks), timeout_sec, executor_callable
+            )
+            results.append(result)
+
+            if self._should_stop_execution(hook, result):
+                self._log_early_exit(hook, results, hooks)
+                break
+
+        self._log_execution_complete(results, hooks)
+        return results
+
+    def _log_execution_start(
+        self, hooks: list[HookDefinition], timeout_sec: int
+    ) -> None:
+        """Log sequential execution start information."""
+        logger.info(
+            "Starting sequential execution",
+            extra={
+                "hook_count": len(hooks),
+                "timeout": timeout_sec,
+                "stop_on_critical_failure": self.stop_on_critical_failure,
+            },
+        )
+
+    async def _execute_single_hook(
+        self,
+        hook: HookDefinition,
+        idx: int,
+        total_hooks: int,
+        timeout_sec: int,
+        executor_callable: t.Callable[[HookDefinition], t.Awaitable[HookResult]] | None,
+    ) -> HookResult:
+        """Execute a single hook with error handling."""
+        try:
+            hook_timeout = hook.timeout or timeout_sec
+            self._log_hook_execution(hook, idx, total_hooks, hook_timeout)
+
+            result = await self._run_hook(hook, hook_timeout, executor_callable)
+            self._log_hook_completion(hook, result)
+            return result
+
+        except TimeoutError:
+            return self._handle_timeout(hook, hook.timeout or timeout_sec)
+        except Exception as e:
+            return self._handle_exception(hook, e)
+
+    def _log_hook_execution(
+        self, hook: HookDefinition, idx: int, total_hooks: int, hook_timeout: int
+    ) -> None:
+        """Log hook execution start."""
+        logger.debug(
+            f"Executing hook {idx}/{total_hooks}: {hook.name}",
+            extra={
+                "hook": hook.name,
+                "hook_index": idx,
+                "total_hooks": total_hooks,
+                "timeout": hook_timeout,
+                "security_level": hook.security_level.value,
+            },
+        )
+
+    async def _run_hook(
+        self,
+        hook: HookDefinition,
+        hook_timeout: int,
+        executor_callable: t.Callable[[HookDefinition], t.Awaitable[HookResult]] | None,
+    ) -> HookResult:
+        """Run hook with executor or return placeholder."""
+        if executor_callable:
+            return await asyncio.wait_for(executor_callable(hook), timeout=hook_timeout)
+        return self._placeholder_result(hook)
+
+    def _log_hook_completion(self, hook: HookDefinition, result: HookResult) -> None:
+        """Log hook execution completion."""
+        logger.debug(
+            f"Hook {hook.name} completed",
+            extra={
+                "hook": hook.name,
+                "status": result.status,
+                "duration": result.duration,
+            },
+        )
+
+    def _handle_timeout(self, hook: HookDefinition, hook_timeout: int) -> HookResult:
+        """Handle hook timeout error."""
+        logger.warning(
+            f"Hook {hook.name} timed out",
+            extra={
+                "hook": hook.name,
+                "timeout": hook_timeout,
+            },
+        )
+        return HookResult(
+            id=hook.name,
+            name=hook.name,
+            status="timeout",
+            duration=hook_timeout,
+            issues_found=[f"Hook timed out after {hook_timeout}s"],
+        )
+
+    def _handle_exception(
+        self, hook: HookDefinition, exception: Exception
+    ) -> HookResult:
+        """Handle hook execution exception."""
+        logger.error(
+            f"Hook {hook.name} raised exception",
+            extra={
+                "hook": hook.name,
+                "exception": str(exception),
+                "exception_type": type(exception).__name__,
+            },
+        )
+        return HookResult(
+            id=hook.name,
+            name=hook.name,
+            status="error",
+            duration=0.0,
+            issues_found=[f"Exception: {type(exception).__name__}: {exception}"],
+        )
+
+    def _log_early_exit(
+        self,
+        hook: HookDefinition,
+        results: list[HookResult],
+        hooks: list[HookDefinition],
+    ) -> None:
+        """Log early exit due to critical failure."""
+        remaining_hooks = len(hooks) - len(results)
+        logger.warning(
+            f"Critical hook {hook.name} failed, stopping execution",
+            extra={
+                "hook": hook.name,
+                "security_level": hook.security_level.value,
+                "executed_hooks": len(results),
+                "remaining_hooks": remaining_hooks,
+            },
+        )
+
+    def _log_execution_complete(
+        self, results: list[HookResult], hooks: list[HookDefinition]
+    ) -> None:
+        """Log sequential execution completion."""
+        logger.info(
+            "Sequential execution complete",
+            extra={
+                "total_hooks": len(results),
+                "executed": len(results),
+                "skipped": len(hooks) - len(results),
+                "passed": sum(1 for r in results if r.status == "passed"),
+                "failed": sum(1 for r in results if r.status == "failed"),
+                "errors": sum(1 for r in results if r.status in ("timeout", "error")),
+            },
+        )
+
+    def get_execution_order(
+        self,
+        hooks: list[HookDefinition],
+    ) -> list[list[HookDefinition]]:
+        """Return batches of hooks for execution.
+
+        Sequential strategy returns one hook per batch.
+
+        Args:
+            hooks: List of hook definitions
+
+        Returns:
+            List of batches, each containing one hook
+        """
+        return [[hook] for hook in hooks]
+
+    def _should_stop_execution(
+        self,
+        hook: HookDefinition,
+        result: HookResult,
+    ) -> bool:
+        """Determine if execution should stop based on hook result.
+
+        Early exit conditions:
+        - stop_on_critical_failure is True
+        - Hook security level is CRITICAL
+        - Result status is failed, timeout, or error
+
+        Args:
+            hook: Hook definition that was executed
+            result: Result from hook execution
+
+        Returns:
+            True if execution should stop, False otherwise
+        """
+        if not self.stop_on_critical_failure:
+            return False
+
+        is_critical = hook.security_level == SecurityLevel.CRITICAL
+        is_failure = result.status in ("failed", "timeout", "error")
+
+        return is_critical and is_failure
+
+    def _placeholder_result(self, hook: HookDefinition) -> HookResult:
+        """Create placeholder result when no executor provided."""
+        return HookResult(
+            id=hook.name,
+            name=hook.name,
+            status="passed",
+            duration=0.0,
+            issues_found=[],  # Initialize with empty list to match expected format
+            files_processed=0,
+        )

crackerjack/orchestration/test_progress_streamer.py

@@ -5,7 +5,7 @@ import typing as t
 from dataclasses import dataclass
 from pathlib import Path
 
-from rich.console import Console
+from acb.console import Console
 
 from crackerjack.models.protocols import OptionsProtocol
 from crackerjack.services.regex_patterns import SAFE_PATTERNS, CompiledPatternCache

crackerjack/plugins/README.md

@@ -0,0 +1,11 @@
+> Crackerjack Docs: [Main](<../../README.md>) | [Crackerjack Package](<../README.md>) | [Plugins](<./README.md>)
+
+# Plugins
+
+Optional plugins and extensions to the core system.
+
+## Related
+
+- [Crackerjack Package](<../README.md>) - Parent package
+- [Agents](<../agents/README.md>) - AI agent system
+- [Services](<../services/README.md>) - Core services that plugins extend

crackerjack/plugins/hooks.py

@@ -3,7 +3,7 @@ import subprocess
 from dataclasses import dataclass, field
 from pathlib import Path
 
-from rich.console import Console
+from acb.console import Console
 
 from crackerjack.config.hooks import HookDefinition, HookStage
 from crackerjack.models.protocols import OptionsProtocol
@@ -131,9 +131,10 @@ class CustomHookPlugin(HookPluginBase):
         try:
             if hook_def.command is None:
                 return HookResult(
+                    id=f"hook_{hook_def.name}",
                     name=hook_def.name,
                     status="failed",
-                    message="Hook command is None",
+                    issues_found=["Hook command is None"],
                     duration=0.0,
                 )
             cmd = hook_def.command.copy()

crackerjack/plugins/loader.py

@@ -132,7 +132,7 @@ class PluginLoader:
 
     def _try_factory_function(
         self,
-        factory: t.Callable,
+        factory: t.Callable[..., t.Any],
         name: str,
     ) -> PluginBase | None:
         try:
@@ -264,7 +264,7 @@ class PluginDiscovery:
         if not directory.exists() or not directory.is_dir():
             return []
 
-        plugin_files = []
+        plugin_files: list[Path] = []
 
         patterns = ["*.py", "*.json", "*.yaml", "*.yml"]
 
@@ -277,7 +277,7 @@ class PluginDiscovery:
         return [f for f in plugin_files if self._looks_like_plugin_file(f)]
 
     def discover_in_project(self, project_path: Path) -> list[Path]:
-        plugin_files = []
+        plugin_files: list[Path] = []
 
         plugin_dirs = [
             project_path / "plugins",

crackerjack/plugins/managers.py

@@ -2,7 +2,7 @@ import logging
 import typing as t
 from pathlib import Path
 
-from rich.console import Console
+from acb.console import Console
 
 from crackerjack.models.protocols import OptionsProtocol