codelaw-rules-security-js 0.3.0__py3-none-any.whl
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- codelaw_rules_security_js/LICENSE +23 -0
- codelaw_rules_security_js/NOTICE +22 -0
- codelaw_rules_security_js/README.md +183 -0
- codelaw_rules_security_js/codelaw-pack.toml +6 -0
- codelaw_rules_security_js/corpus.toml +70 -0
- codelaw_rules_security_js/data/sources/browser.json +24 -0
- codelaw_rules_security_js/data/sources/express.json +28 -0
- codelaw_rules_security_js/data/sources/koa.json +18 -0
- codelaw_rules_security_js/data/sources/llm.json +14 -0
- codelaw_rules_security_js/data/sources/nextjs.json +13 -0
- codelaw_rules_security_js/presets/sec-js/recommended.toml +58 -0
- codelaw_rules_security_js/presets/sec-js/strict.toml +15 -0
- codelaw_rules_security_js/rules/sec-js/angularjs-sce-disabled.cases.md +129 -0
- codelaw_rules_security_js/rules/sec-js/angularjs-sce-disabled.md +132 -0
- codelaw_rules_security_js/rules/sec-js/cookie-flags.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/cookie-flags.md +117 -0
- codelaw_rules_security_js/rules/sec-js/express-hardening.cases.md +12 -0
- codelaw_rules_security_js/rules/sec-js/express-hardening.md +135 -0
- codelaw_rules_security_js/rules/sec-js/express-session-secret.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/express-session-secret.md +101 -0
- codelaw_rules_security_js/rules/sec-js/graphql-hardening.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/graphql-hardening.md +116 -0
- codelaw_rules_security_js/rules/sec-js/helmet-config.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/helmet-config.md +88 -0
- codelaw_rules_security_js/rules/sec-js/jwt-verify.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/jwt-verify.md +107 -0
- codelaw_rules_security_js/rules/sec-js/missing-rate-limit.cases.md +22 -0
- codelaw_rules_security_js/rules/sec-js/missing-rate-limit.md +119 -0
- codelaw_rules_security_js/rules/sec-js/no-archive-slip.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-archive-slip.md +119 -0
- codelaw_rules_security_js/rules/sec-js/no-bad-tag-filter.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-bad-tag-filter.md +85 -0
- codelaw_rules_security_js/rules/sec-js/no-biased-random.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-biased-random.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-bidi-characters.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-bidi-characters.md +123 -0
- codelaw_rules_security_js/rules/sec-js/no-child-process-shell.cases.md +71 -0
- codelaw_rules_security_js/rules/sec-js/no-child-process-shell.md +141 -0
- codelaw_rules_security_js/rules/sec-js/no-cleartext-http.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-cleartext-http.md +147 -0
- codelaw_rules_security_js/rules/sec-js/no-cors-wildcard-credentials.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-cors-wildcard-credentials.md +92 -0
- codelaw_rules_security_js/rules/sec-js/no-csrf-before-method-override.cases.md +12 -0
- codelaw_rules_security_js/rules/sec-js/no-csrf-before-method-override.md +128 -0
- codelaw_rules_security_js/rules/sec-js/no-dangerously-set-inner-html.cases.md +141 -0
- codelaw_rules_security_js/rules/sec-js/no-dangerously-set-inner-html.md +107 -0
- codelaw_rules_security_js/rules/sec-js/no-document-cookie-token.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-document-cookie-token.md +89 -0
- codelaw_rules_security_js/rules/sec-js/no-dynamic-script-src.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-dynamic-script-src.md +100 -0
- codelaw_rules_security_js/rules/sec-js/no-electron-insecure.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-electron-insecure.md +134 -0
- codelaw_rules_security_js/rules/sec-js/no-eval.cases.md +52 -0
- codelaw_rules_security_js/rules/sec-js/no-eval.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-format-string.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-format-string.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-crypto-key.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-crypto-key.md +96 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-secret.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-secret.md +112 -0
- codelaw_rules_security_js/rules/sec-js/no-header-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-header-injection.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-sanitization.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-sanitization.md +113 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-url-check.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-url-check.md +118 -0
- codelaw_rules_security_js/rules/sec-js/no-insecure-random.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-insecure-random.md +127 -0
- codelaw_rules_security_js/rules/sec-js/no-javascript-url.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-javascript-url.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-jquery-html-sink.cases.md +139 -0
- codelaw_rules_security_js/rules/sec-js/no-jquery-html-sink.md +131 -0
- codelaw_rules_security_js/rules/sec-js/no-ldap-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-ldap-injection.md +87 -0
- codelaw_rules_security_js/rules/sec-js/no-llm-output-to-sink.cases.md +34 -0
- codelaw_rules_security_js/rules/sec-js/no-llm-output-to-sink.md +105 -0
- codelaw_rules_security_js/rules/sec-js/no-log-injection.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-log-injection.md +113 -0
- codelaw_rules_security_js/rules/sec-js/no-mass-assignment.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-mass-assignment.md +100 -0
- codelaw_rules_security_js/rules/sec-js/no-new-buffer.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-new-buffer.md +120 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-fs-filename.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-fs-filename.md +151 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-require.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-require.md +88 -0
- codelaw_rules_security_js/rules/sec-js/no-nosql-injection.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-nosql-injection.md +114 -0
- codelaw_rules_security_js/rules/sec-js/no-open-redirect.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-open-redirect.md +106 -0
- codelaw_rules_security_js/rules/sec-js/no-path-traversal.cases.md +54 -0
- codelaw_rules_security_js/rules/sec-js/no-path-traversal.md +187 -0
- codelaw_rules_security_js/rules/sec-js/no-prompt-injection.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-prompt-injection.md +118 -0
- codelaw_rules_security_js/rules/sec-js/no-prototype-pollution.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-prototype-pollution.md +135 -0
- codelaw_rules_security_js/rules/sec-js/no-secret-in-log.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-secret-in-log.md +86 -0
- codelaw_rules_security_js/rules/sec-js/no-sensitive-get-query.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-sensitive-get-query.md +89 -0
- codelaw_rules_security_js/rules/sec-js/no-server-env-in-client.cases.md +42 -0
- codelaw_rules_security_js/rules/sec-js/no-server-env-in-client.md +107 -0
- codelaw_rules_security_js/rules/sec-js/no-sql-template.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-sql-template.md +112 -0
- codelaw_rules_security_js/rules/sec-js/no-ssrf.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-ssrf.md +165 -0
- codelaw_rules_security_js/rules/sec-js/no-ssti.cases.md +54 -0
- codelaw_rules_security_js/rules/sec-js/no-ssti.md +128 -0
- codelaw_rules_security_js/rules/sec-js/no-stack-trace-response.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-stack-trace-response.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-tls-bypass.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-tls-bypass.md +117 -0
- codelaw_rules_security_js/rules/sec-js/no-token-in-web-storage.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-token-in-web-storage.md +92 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-deserialize.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-deserialize.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-regex.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-regex.md +93 -0
- codelaw_rules_security_js/rules/sec-js/no-unsanitized-html.cases.md +199 -0
- codelaw_rules_security_js/rules/sec-js/no-unsanitized-html.md +143 -0
- codelaw_rules_security_js/rules/sec-js/no-unvalidated-dynamic-method.cases.md +34 -0
- codelaw_rules_security_js/rules/sec-js/no-unvalidated-dynamic-method.md +94 -0
- codelaw_rules_security_js/rules/sec-js/no-user-controlled-auth-bypass.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-user-controlled-auth-bypass.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-cipher.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-cipher.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-hash.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-hash.md +97 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-key-size.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-key-size.md +117 -0
- codelaw_rules_security_js/rules/sec-js/no-window-open-opener.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-window-open-opener.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-xpath-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-xpath-injection.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-xxe.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-xxe.md +124 -0
- codelaw_rules_security_js/rules/sec-js/password-hash-effort.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/password-hash-effort.md +97 -0
- codelaw_rules_security_js/rules/sec-js/postmessage-origin.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/postmessage-origin.md +125 -0
- codelaw_rules_security_js/rules/sec-js/timing-safe-compare.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/timing-safe-compare.md +142 -0
- codelaw_rules_security_js/rules/sec-js/upload-limits.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/upload-limits.md +115 -0
- codelaw_rules_security_js-0.3.0.dist-info/METADATA +193 -0
- codelaw_rules_security_js-0.3.0.dist-info/RECORD +148 -0
- codelaw_rules_security_js-0.3.0.dist-info/WHEEL +4 -0
- codelaw_rules_security_js-0.3.0.dist-info/licenses/LICENSE +23 -0
|
@@ -0,0 +1,61 @@
|
|
|
1
|
+
# sec-js/no-hardcoded-secret — cases
|
|
2
|
+
|
|
3
|
+
### case: a private key header in a template
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
const pem = `-----BEGIN RSA PRIVATE KEY-----\nMIIE...`;
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:13 sec-js/no-hardcoded-secret
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: a short placeholder is not flagged
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
const password = "x";
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
(none)
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: a cookie name is not a secret
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
const TOKEN_COOKIE_NAME = "my_app_session_token";
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
(none)
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
### case: a GitHub token
|
|
34
|
+
|
|
35
|
+
```js
|
|
36
|
+
const t = "ghp_abcdefghijklmnopqrstuvwxyz0123456789";
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
```expect
|
|
40
|
+
1:11 sec-js/no-hardcoded-secret
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
### case: an object password
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
const cfg = { password: "hunter2hunter2" };
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
```expect
|
|
50
|
+
1:15 sec-js/no-hardcoded-secret
|
|
51
|
+
```
|
|
52
|
+
|
|
53
|
+
### case: a Stripe key
|
|
54
|
+
|
|
55
|
+
```js
|
|
56
|
+
const k = "sk_live_abcdefghijklmnopqrstuvwx";
|
|
57
|
+
```
|
|
58
|
+
|
|
59
|
+
```expect
|
|
60
|
+
1:11 sec-js/no-hardcoded-secret
|
|
61
|
+
```
|
|
@@ -0,0 +1,112 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-hardcoded-secret
|
|
3
|
+
title: "No secret written into the source"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "where the secret comes from instead is a deployment decision"
|
|
7
|
+
stability: preview
|
|
8
|
+
ported_from: [bandit/B105, ruff/S105]
|
|
9
|
+
security: { cwe: [798], owasp: ["A07:2025"], severity: high }
|
|
10
|
+
since: 0.3.0
|
|
11
|
+
---
|
|
12
|
+
|
|
13
|
+
A cloud key, a token, a private key or a password is not a string literal in the code.
|
|
14
|
+
|
|
15
|
+
**Why:** Source goes to every clone, every CI log and every build; a secret in it is as public as the repository will ever be, and removing it later does not unpublish it (CWE-798).
|
|
16
|
+
|
|
17
|
+
```codelaw
|
|
18
|
+
match:
|
|
19
|
+
any:
|
|
20
|
+
- kind: string
|
|
21
|
+
regex: '^["'']?(AKIA|ASIA)[0-9A-Z]{16}["'']?$|AIza[0-9A-Za-z_-]{35}|\bgh[pousr]_[A-Za-z0-9]{36,}|\bgithub_pat_[A-Za-z0-9_]{50,}|\b[sr]k_(live|test)_[0-9a-zA-Z]{24,}|\bxox[abprs]-[0-9A-Za-z-]{10,}|-----BEGIN ([A-Z]+ )?PRIVATE KEY|\bsk-(ant-)?[A-Za-z0-9_-]{32,}'
|
|
22
|
+
- kind: template_string
|
|
23
|
+
regex: '-----BEGIN ([A-Z]+ )?PRIVATE KEY'
|
|
24
|
+
- all:
|
|
25
|
+
- kind: variable_declarator
|
|
26
|
+
- regex: '(?i)^[\w$]*(password|passwd|pwd|secret|api_?key|apikey|auth_?token|access_?token|private_?key|client_?secret)[\w$]*\s*=\s*["''][^"'']{8,}["'']$'
|
|
27
|
+
- not:
|
|
28
|
+
regex: '(?i)^[\w$]*(name|header|field|cookie|label|prefix|url|path|endpoint)[\w$]*\s*='
|
|
29
|
+
- all:
|
|
30
|
+
- kind: assignment_expression
|
|
31
|
+
- regex: '(?i)^[\w$.]*(password|passwd|pwd|secret|api_?key|apikey|auth_?token|access_?token|private_?key|client_?secret)[\w$]*\s*=\s*["''][^"'']{8,}["'']$'
|
|
32
|
+
- not:
|
|
33
|
+
regex: '(?i)^[\w$.]*(name|header|field|cookie|label|prefix|url|path|endpoint)[\w$]*\s*='
|
|
34
|
+
- all:
|
|
35
|
+
- kind: pair
|
|
36
|
+
- regex: '(?i)^["'']?[\w$]*(password|passwd|pwd|secret|api_?key|apikey|auth_?token|access_?token|private_?key|client_?secret)[\w$]*["'']?\s*:\s*["''][^"'']{8,}["'']$'
|
|
37
|
+
- not:
|
|
38
|
+
regex: '(?i)^["'']?[\w$]*(name|header|field|cookie|label|prefix|url|path|endpoint)[\w$]*["'']?\s*:'
|
|
39
|
+
message: "A secret is written into the source here"
|
|
40
|
+
```
|
|
41
|
+
|
|
42
|
+
## How to fix
|
|
43
|
+
|
|
44
|
+
1. Read the value from the environment or a secret store (`process.env.NAME`, AWS Secrets Manager, Vault) at start-up.
|
|
45
|
+
2. Treat the committed value as leaked: revoke it, issue a new one and, if it must be gone from history, rewrite it.
|
|
46
|
+
3. Keep test keys in a clearly fake form (`test_key_000`) so the scanner can tell them apart.
|
|
47
|
+
|
|
48
|
+
## Examples
|
|
49
|
+
|
|
50
|
+
### JavaScript
|
|
51
|
+
|
|
52
|
+
#### Don't
|
|
53
|
+
|
|
54
|
+
```js
|
|
55
|
+
const awsAccessKey = "AKIAIOSFODNN7EXAMPLE";
|
|
56
|
+
const dbPassword = "correct-horse-battery";
|
|
57
|
+
```
|
|
58
|
+
|
|
59
|
+
#### Do
|
|
60
|
+
|
|
61
|
+
```js
|
|
62
|
+
const awsAccessKey = process.env.AWS_ACCESS_KEY_ID;
|
|
63
|
+
const dbPassword = process.env.DB_PASSWORD;
|
|
64
|
+
```
|
|
65
|
+
|
|
66
|
+
### JSX
|
|
67
|
+
|
|
68
|
+
#### Don't
|
|
69
|
+
|
|
70
|
+
```jsx
|
|
71
|
+
const awsAccessKey = "AKIAIOSFODNN7EXAMPLE";
|
|
72
|
+
const dbPassword = "correct-horse-battery";
|
|
73
|
+
```
|
|
74
|
+
|
|
75
|
+
#### Do
|
|
76
|
+
|
|
77
|
+
```jsx
|
|
78
|
+
const awsAccessKey = process.env.AWS_ACCESS_KEY_ID;
|
|
79
|
+
const dbPassword = process.env.DB_PASSWORD;
|
|
80
|
+
```
|
|
81
|
+
|
|
82
|
+
### TypeScript
|
|
83
|
+
|
|
84
|
+
#### Don't
|
|
85
|
+
|
|
86
|
+
```ts
|
|
87
|
+
const awsAccessKey = "AKIAIOSFODNN7EXAMPLE";
|
|
88
|
+
const dbPassword = "correct-horse-battery";
|
|
89
|
+
```
|
|
90
|
+
|
|
91
|
+
#### Do
|
|
92
|
+
|
|
93
|
+
```ts
|
|
94
|
+
const awsAccessKey = process.env.AWS_ACCESS_KEY_ID;
|
|
95
|
+
const dbPassword = process.env.DB_PASSWORD;
|
|
96
|
+
```
|
|
97
|
+
|
|
98
|
+
### TSX
|
|
99
|
+
|
|
100
|
+
#### Don't
|
|
101
|
+
|
|
102
|
+
```tsx
|
|
103
|
+
const awsAccessKey = "AKIAIOSFODNN7EXAMPLE";
|
|
104
|
+
const dbPassword = "correct-horse-battery";
|
|
105
|
+
```
|
|
106
|
+
|
|
107
|
+
#### Do
|
|
108
|
+
|
|
109
|
+
```tsx
|
|
110
|
+
const awsAccessKey = process.env.AWS_ACCESS_KEY_ID;
|
|
111
|
+
const dbPassword = process.env.DB_PASSWORD;
|
|
112
|
+
```
|
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
# sec-js/no-header-injection — cases
|
|
2
|
+
|
|
3
|
+
### case: set
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
res.set("X-Next", req.query.next);
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:1 sec-js/no-header-injection
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: header
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
res.header("Location", req.body.to);
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
1:1 sec-js/no-header-injection
|
|
21
|
+
```
|
|
@@ -0,0 +1,95 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-header-injection
|
|
3
|
+
title: "No response header value taken from a request"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "encoding or rejecting is a choice that depends on the header"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [113], owasp: ["A05:2025"], severity: high }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
A response header is not set from request data unchanged.
|
|
13
|
+
|
|
14
|
+
**Why:** A value with a carriage return and a line feed in it ends the header and starts another one, or the body: response splitting (CWE-113).
|
|
15
|
+
|
|
16
|
+
```codelaw
|
|
17
|
+
match:
|
|
18
|
+
any:
|
|
19
|
+
- pattern: res.setHeader($N, $V)
|
|
20
|
+
- pattern: res.header($N, $V)
|
|
21
|
+
- pattern: res.set($N, $V)
|
|
22
|
+
- pattern: res.append($N, $V)
|
|
23
|
+
- pattern: response.setHeader($N, $V)
|
|
24
|
+
- pattern: response.header($N, $V)
|
|
25
|
+
- pattern: reply.header($N, $V)
|
|
26
|
+
- pattern: ctx.set($N, $V)
|
|
27
|
+
- pattern: ctx.append($N, $V)
|
|
28
|
+
- pattern: h.header($N, $V)
|
|
29
|
+
where:
|
|
30
|
+
$V: { from_source: { tables: [sources/express, sources/koa, sources/nextjs] } }
|
|
31
|
+
message: "`$V` comes from the request and is written into a response header"
|
|
32
|
+
```
|
|
33
|
+
|
|
34
|
+
## How to fix
|
|
35
|
+
|
|
36
|
+
1. Encode the value for a header (`encodeURIComponent`) or check it against an allow-list before it is written.
|
|
37
|
+
2. Reject a value that contains `\r` or `\n`.
|
|
38
|
+
|
|
39
|
+
## Examples
|
|
40
|
+
|
|
41
|
+
### JavaScript
|
|
42
|
+
|
|
43
|
+
#### Don't
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
res.setHeader("X-Name", req.query.name);
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
#### Do
|
|
50
|
+
|
|
51
|
+
```js
|
|
52
|
+
res.setHeader("X-Name", encodeURIComponent(req.query.name));
|
|
53
|
+
```
|
|
54
|
+
|
|
55
|
+
### JSX
|
|
56
|
+
|
|
57
|
+
#### Don't
|
|
58
|
+
|
|
59
|
+
```jsx
|
|
60
|
+
res.setHeader("X-Name", req.query.name);
|
|
61
|
+
```
|
|
62
|
+
|
|
63
|
+
#### Do
|
|
64
|
+
|
|
65
|
+
```jsx
|
|
66
|
+
res.setHeader("X-Name", encodeURIComponent(req.query.name));
|
|
67
|
+
```
|
|
68
|
+
|
|
69
|
+
### TypeScript
|
|
70
|
+
|
|
71
|
+
#### Don't
|
|
72
|
+
|
|
73
|
+
```ts
|
|
74
|
+
res.setHeader("X-Name", req.query.name);
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
#### Do
|
|
78
|
+
|
|
79
|
+
```ts
|
|
80
|
+
res.setHeader("X-Name", encodeURIComponent(req.query.name));
|
|
81
|
+
```
|
|
82
|
+
|
|
83
|
+
### TSX
|
|
84
|
+
|
|
85
|
+
#### Don't
|
|
86
|
+
|
|
87
|
+
```tsx
|
|
88
|
+
res.setHeader("X-Name", req.query.name);
|
|
89
|
+
```
|
|
90
|
+
|
|
91
|
+
#### Do
|
|
92
|
+
|
|
93
|
+
```tsx
|
|
94
|
+
res.setHeader("X-Name", encodeURIComponent(req.query.name));
|
|
95
|
+
```
|
|
@@ -0,0 +1,41 @@
|
|
|
1
|
+
# sec-js/no-incomplete-sanitization — cases
|
|
2
|
+
|
|
3
|
+
### case: one-pass stripping of ../
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
const p = name.replace(/\.\.\//g, "");
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:11 sec-js/no-incomplete-sanitization
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: a global regular expression
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
const s = v.replace(/</g, "<");
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
(none)
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: replace of &
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
s.replace("&", "&");
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
1:1 sec-js/no-incomplete-sanitization
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
### case: javascript:
|
|
34
|
+
|
|
35
|
+
```js
|
|
36
|
+
u.replace(/javascript:/gi, "");
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
```expect
|
|
40
|
+
1:1 sec-js/no-incomplete-sanitization
|
|
41
|
+
```
|
|
@@ -0,0 +1,113 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-incomplete-sanitization
|
|
3
|
+
title: "No escaping that stops at the first match, no one-pass stripping"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: suggest
|
|
6
|
+
fix_reason: "it changes how many matches are replaced, and `replaceAll` needs an ES2021 runtime"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [116], owasp: ["A05:2025"], severity: medium }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
`replace` with a string replaces only the first match, so a markup character is escaped with `replaceAll` or a global regular expression; and a path or script marker is not stripped in one pass.
|
|
13
|
+
|
|
14
|
+
**Why:** `"<<b>".replace("<", "<")` leaves the second `<`; and stripping `../` once turns `....//` back into `../` (CWE-116).
|
|
15
|
+
|
|
16
|
+
```codelaw
|
|
17
|
+
match:
|
|
18
|
+
any:
|
|
19
|
+
- all:
|
|
20
|
+
- pattern: $S.replace($P, $R)
|
|
21
|
+
- regex: '\.replace\(\s*["''][<>&/]["'']\s*,'
|
|
22
|
+
- all:
|
|
23
|
+
- pattern: $S2.replace($RE, "")
|
|
24
|
+
- regex: '\.replace\(\s*/(\\\.\\\.(\\/|\\\\)|javascript:)[^/]*/[gimsuy]*\s*,\s*[\x22\x27]{2}\s*\)$'
|
|
25
|
+
message: "This replacement misses later matches or can be rebuilt by the input"
|
|
26
|
+
fix:
|
|
27
|
+
- replace: "$S.replaceAll($P, $R)"
|
|
28
|
+
```
|
|
29
|
+
|
|
30
|
+
## How to fix
|
|
31
|
+
|
|
32
|
+
|
|
33
|
+
## Examples
|
|
34
|
+
|
|
35
|
+
### JavaScript
|
|
36
|
+
|
|
37
|
+
#### Don't
|
|
38
|
+
|
|
39
|
+
```js
|
|
40
|
+
const safe = input.replace("<", "<");
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
#### Do
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
const safe = input.replaceAll("<", "<");
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
#### Fixed
|
|
50
|
+
|
|
51
|
+
```js
|
|
52
|
+
const safe = input.replaceAll("<", "<");
|
|
53
|
+
```
|
|
54
|
+
|
|
55
|
+
### JSX
|
|
56
|
+
|
|
57
|
+
#### Don't
|
|
58
|
+
|
|
59
|
+
```jsx
|
|
60
|
+
const safe = input.replace("<", "<");
|
|
61
|
+
```
|
|
62
|
+
|
|
63
|
+
#### Do
|
|
64
|
+
|
|
65
|
+
```jsx
|
|
66
|
+
const safe = input.replaceAll("<", "<");
|
|
67
|
+
```
|
|
68
|
+
|
|
69
|
+
#### Fixed
|
|
70
|
+
|
|
71
|
+
```jsx
|
|
72
|
+
const safe = input.replaceAll("<", "<");
|
|
73
|
+
```
|
|
74
|
+
|
|
75
|
+
### TypeScript
|
|
76
|
+
|
|
77
|
+
#### Don't
|
|
78
|
+
|
|
79
|
+
```ts
|
|
80
|
+
const safe = input.replace("<", "<");
|
|
81
|
+
```
|
|
82
|
+
|
|
83
|
+
#### Do
|
|
84
|
+
|
|
85
|
+
```ts
|
|
86
|
+
const safe = input.replaceAll("<", "<");
|
|
87
|
+
```
|
|
88
|
+
|
|
89
|
+
#### Fixed
|
|
90
|
+
|
|
91
|
+
```ts
|
|
92
|
+
const safe = input.replaceAll("<", "<");
|
|
93
|
+
```
|
|
94
|
+
|
|
95
|
+
### TSX
|
|
96
|
+
|
|
97
|
+
#### Don't
|
|
98
|
+
|
|
99
|
+
```tsx
|
|
100
|
+
const safe = input.replace("<", "<");
|
|
101
|
+
```
|
|
102
|
+
|
|
103
|
+
#### Do
|
|
104
|
+
|
|
105
|
+
```tsx
|
|
106
|
+
const safe = input.replaceAll("<", "<");
|
|
107
|
+
```
|
|
108
|
+
|
|
109
|
+
#### Fixed
|
|
110
|
+
|
|
111
|
+
```tsx
|
|
112
|
+
const safe = input.replaceAll("<", "<");
|
|
113
|
+
```
|
|
@@ -0,0 +1,61 @@
|
|
|
1
|
+
# sec-js/no-incomplete-url-check — cases
|
|
2
|
+
|
|
3
|
+
### case: a file name is not a host
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
names.includes("index.js");
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
(none)
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: startsWith with a slash is fine
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
url.startsWith("https://example.com/");
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
(none)
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: an unanchored regular expression
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
/example\.com/.test(url);
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
1:1 sec-js/no-incomplete-url-check
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
### case: indexOf
|
|
34
|
+
|
|
35
|
+
```js
|
|
36
|
+
if (url.indexOf("example.com") !== -1) {}
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
```expect
|
|
40
|
+
1:5 sec-js/no-incomplete-url-check
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
### case: endsWith
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
host.endsWith("example.com");
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
```expect
|
|
50
|
+
1:1 sec-js/no-incomplete-url-check
|
|
51
|
+
```
|
|
52
|
+
|
|
53
|
+
### case: startsWith
|
|
54
|
+
|
|
55
|
+
```js
|
|
56
|
+
url.startsWith("https://example.com");
|
|
57
|
+
```
|
|
58
|
+
|
|
59
|
+
```expect
|
|
60
|
+
1:1 sec-js/no-incomplete-url-check
|
|
61
|
+
```
|
|
@@ -0,0 +1,118 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-incomplete-url-check
|
|
3
|
+
title: "No URL checked with a substring test"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "which hosts are allowed is a decision for the author"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [20], owasp: ["A01:2025"], severity: high }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
A URL or host is not checked with `includes`, `indexOf`, a bare `startsWith`/`endsWith` or an unanchored regular expression; it is parsed with `URL` and its `hostname` or `origin` compared.
|
|
13
|
+
|
|
14
|
+
**Why:** `url.includes("example.com")` is true for `https://evil.com/?example.com` and `https://example.com.evil.com`; the same holds for the other checks, so an attacker passes the test with a URL of their own (CWE-20).
|
|
15
|
+
|
|
16
|
+
```codelaw
|
|
17
|
+
match:
|
|
18
|
+
any:
|
|
19
|
+
- all:
|
|
20
|
+
- pattern: $U.includes($H)
|
|
21
|
+
- regex: 'includes\(\s*["''`][A-Za-z0-9.-]+\.(com|org|net|io|dev|app|co|edu|gov|ai|cloud|xyz|info|me|us|uk|de|in)["''`]\s*\)$'
|
|
22
|
+
- all:
|
|
23
|
+
- pattern: $U.startsWith($H)
|
|
24
|
+
- regex: 'startsWith\(\s*["'']https?://[A-Za-z0-9.-]+["'']\s*\)$'
|
|
25
|
+
- all:
|
|
26
|
+
- pattern: $U.endsWith($H)
|
|
27
|
+
- regex: 'endsWith\(\s*["''][A-Za-z0-9][A-Za-z0-9-]*\.(com|org|net|io|dev|app|co|edu|gov|ai|cloud|xyz|info|me|us|uk|de|in)["'']\s*\)$'
|
|
28
|
+
- all:
|
|
29
|
+
- pattern: $U.indexOf($H) !== -1
|
|
30
|
+
- regex: 'indexOf\(\s*["''`][A-Za-z0-9.-]+\.(com|org|net|io|dev|app|co|edu|gov|ai|cloud|xyz|info|me|us|uk|de|in)["''`]\s*\)'
|
|
31
|
+
- all:
|
|
32
|
+
- pattern: $U.indexOf($H) > -1
|
|
33
|
+
- regex: 'indexOf\(\s*["''`][A-Za-z0-9.-]+\.(com|org|net|io|dev|app|co|edu|gov|ai|cloud|xyz|info|me|us|uk|de|in)["''`]\s*\)'
|
|
34
|
+
- all:
|
|
35
|
+
- pattern: $RE.test($U)
|
|
36
|
+
- regex: '^/[^^/][^/]*\\\.(com|org|net|io|dev|app|co|edu|gov|ai|cloud|xyz|info|me|us|uk|de|in)[^$]*/[gimsuy]*\.test\('
|
|
37
|
+
message: "A substring test on a URL passes for hosts the author did not mean, such as `example.com.evil.com`"
|
|
38
|
+
```
|
|
39
|
+
|
|
40
|
+
## How to fix
|
|
41
|
+
|
|
42
|
+
1. Parse the value: `const u = new URL(value, base)`, and compare `u.protocol` and `u.hostname` (or `u.origin`) with exact allowed values.
|
|
43
|
+
2. To allow subdomains, compare `u.hostname === "example.com" || u.hostname.endsWith(".example.com")` (with the leading dot).
|
|
44
|
+
3. A value that fails to parse is rejected.
|
|
45
|
+
|
|
46
|
+
## Examples
|
|
47
|
+
|
|
48
|
+
### JavaScript
|
|
49
|
+
|
|
50
|
+
#### Don't
|
|
51
|
+
|
|
52
|
+
```js
|
|
53
|
+
if (url.includes("example.com")) {
|
|
54
|
+
trust(url);
|
|
55
|
+
}
|
|
56
|
+
```
|
|
57
|
+
|
|
58
|
+
#### Do
|
|
59
|
+
|
|
60
|
+
```js
|
|
61
|
+
if (new URL(url).hostname === "example.com") {
|
|
62
|
+
trust(url);
|
|
63
|
+
}
|
|
64
|
+
```
|
|
65
|
+
|
|
66
|
+
### JSX
|
|
67
|
+
|
|
68
|
+
#### Don't
|
|
69
|
+
|
|
70
|
+
```jsx
|
|
71
|
+
if (url.includes("example.com")) {
|
|
72
|
+
trust(url);
|
|
73
|
+
}
|
|
74
|
+
```
|
|
75
|
+
|
|
76
|
+
#### Do
|
|
77
|
+
|
|
78
|
+
```jsx
|
|
79
|
+
if (new URL(url).hostname === "example.com") {
|
|
80
|
+
trust(url);
|
|
81
|
+
}
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
### TypeScript
|
|
85
|
+
|
|
86
|
+
#### Don't
|
|
87
|
+
|
|
88
|
+
```ts
|
|
89
|
+
if (url.includes("example.com")) {
|
|
90
|
+
trust(url);
|
|
91
|
+
}
|
|
92
|
+
```
|
|
93
|
+
|
|
94
|
+
#### Do
|
|
95
|
+
|
|
96
|
+
```ts
|
|
97
|
+
if (new URL(url).hostname === "example.com") {
|
|
98
|
+
trust(url);
|
|
99
|
+
}
|
|
100
|
+
```
|
|
101
|
+
|
|
102
|
+
### TSX
|
|
103
|
+
|
|
104
|
+
#### Don't
|
|
105
|
+
|
|
106
|
+
```tsx
|
|
107
|
+
if (url.includes("example.com")) {
|
|
108
|
+
trust(url);
|
|
109
|
+
}
|
|
110
|
+
```
|
|
111
|
+
|
|
112
|
+
#### Do
|
|
113
|
+
|
|
114
|
+
```tsx
|
|
115
|
+
if (new URL(url).hostname === "example.com") {
|
|
116
|
+
trust(url);
|
|
117
|
+
}
|
|
118
|
+
```
|
|
@@ -0,0 +1,51 @@
|
|
|
1
|
+
# sec-js/no-insecure-random — cases
|
|
2
|
+
|
|
3
|
+
### case: a numeric code has no mechanical fix
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
const otp = Math.floor(Math.random() * 1000000);
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:7 sec-js/no-insecure-random
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: pseudoRandomBytes
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
const b = crypto.pseudoRandomBytes(16);
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
1:11 sec-js/no-insecure-random
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: a name that is not a secret
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
const jitter = Math.random() * 100;
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
(none)
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
### case: an object property
|
|
34
|
+
|
|
35
|
+
```js
|
|
36
|
+
const o = { sessionId: Math.random().toString(16) };
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
```expect
|
|
40
|
+
1:13 sec-js/no-insecure-random
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
### case: an assignment
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
this.token = Math.random().toString(36).substring(2);
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
```expect
|
|
50
|
+
1:1 sec-js/no-insecure-random
|
|
51
|
+
```
|