codelaw-rules-security-js 0.3.0__py3-none-any.whl
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- codelaw_rules_security_js/LICENSE +23 -0
- codelaw_rules_security_js/NOTICE +22 -0
- codelaw_rules_security_js/README.md +183 -0
- codelaw_rules_security_js/codelaw-pack.toml +6 -0
- codelaw_rules_security_js/corpus.toml +70 -0
- codelaw_rules_security_js/data/sources/browser.json +24 -0
- codelaw_rules_security_js/data/sources/express.json +28 -0
- codelaw_rules_security_js/data/sources/koa.json +18 -0
- codelaw_rules_security_js/data/sources/llm.json +14 -0
- codelaw_rules_security_js/data/sources/nextjs.json +13 -0
- codelaw_rules_security_js/presets/sec-js/recommended.toml +58 -0
- codelaw_rules_security_js/presets/sec-js/strict.toml +15 -0
- codelaw_rules_security_js/rules/sec-js/angularjs-sce-disabled.cases.md +129 -0
- codelaw_rules_security_js/rules/sec-js/angularjs-sce-disabled.md +132 -0
- codelaw_rules_security_js/rules/sec-js/cookie-flags.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/cookie-flags.md +117 -0
- codelaw_rules_security_js/rules/sec-js/express-hardening.cases.md +12 -0
- codelaw_rules_security_js/rules/sec-js/express-hardening.md +135 -0
- codelaw_rules_security_js/rules/sec-js/express-session-secret.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/express-session-secret.md +101 -0
- codelaw_rules_security_js/rules/sec-js/graphql-hardening.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/graphql-hardening.md +116 -0
- codelaw_rules_security_js/rules/sec-js/helmet-config.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/helmet-config.md +88 -0
- codelaw_rules_security_js/rules/sec-js/jwt-verify.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/jwt-verify.md +107 -0
- codelaw_rules_security_js/rules/sec-js/missing-rate-limit.cases.md +22 -0
- codelaw_rules_security_js/rules/sec-js/missing-rate-limit.md +119 -0
- codelaw_rules_security_js/rules/sec-js/no-archive-slip.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-archive-slip.md +119 -0
- codelaw_rules_security_js/rules/sec-js/no-bad-tag-filter.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-bad-tag-filter.md +85 -0
- codelaw_rules_security_js/rules/sec-js/no-biased-random.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-biased-random.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-bidi-characters.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-bidi-characters.md +123 -0
- codelaw_rules_security_js/rules/sec-js/no-child-process-shell.cases.md +71 -0
- codelaw_rules_security_js/rules/sec-js/no-child-process-shell.md +141 -0
- codelaw_rules_security_js/rules/sec-js/no-cleartext-http.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-cleartext-http.md +147 -0
- codelaw_rules_security_js/rules/sec-js/no-cors-wildcard-credentials.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-cors-wildcard-credentials.md +92 -0
- codelaw_rules_security_js/rules/sec-js/no-csrf-before-method-override.cases.md +12 -0
- codelaw_rules_security_js/rules/sec-js/no-csrf-before-method-override.md +128 -0
- codelaw_rules_security_js/rules/sec-js/no-dangerously-set-inner-html.cases.md +141 -0
- codelaw_rules_security_js/rules/sec-js/no-dangerously-set-inner-html.md +107 -0
- codelaw_rules_security_js/rules/sec-js/no-document-cookie-token.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-document-cookie-token.md +89 -0
- codelaw_rules_security_js/rules/sec-js/no-dynamic-script-src.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-dynamic-script-src.md +100 -0
- codelaw_rules_security_js/rules/sec-js/no-electron-insecure.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-electron-insecure.md +134 -0
- codelaw_rules_security_js/rules/sec-js/no-eval.cases.md +52 -0
- codelaw_rules_security_js/rules/sec-js/no-eval.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-format-string.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-format-string.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-crypto-key.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-crypto-key.md +96 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-secret.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-secret.md +112 -0
- codelaw_rules_security_js/rules/sec-js/no-header-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-header-injection.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-sanitization.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-sanitization.md +113 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-url-check.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-url-check.md +118 -0
- codelaw_rules_security_js/rules/sec-js/no-insecure-random.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-insecure-random.md +127 -0
- codelaw_rules_security_js/rules/sec-js/no-javascript-url.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-javascript-url.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-jquery-html-sink.cases.md +139 -0
- codelaw_rules_security_js/rules/sec-js/no-jquery-html-sink.md +131 -0
- codelaw_rules_security_js/rules/sec-js/no-ldap-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-ldap-injection.md +87 -0
- codelaw_rules_security_js/rules/sec-js/no-llm-output-to-sink.cases.md +34 -0
- codelaw_rules_security_js/rules/sec-js/no-llm-output-to-sink.md +105 -0
- codelaw_rules_security_js/rules/sec-js/no-log-injection.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-log-injection.md +113 -0
- codelaw_rules_security_js/rules/sec-js/no-mass-assignment.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-mass-assignment.md +100 -0
- codelaw_rules_security_js/rules/sec-js/no-new-buffer.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-new-buffer.md +120 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-fs-filename.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-fs-filename.md +151 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-require.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-require.md +88 -0
- codelaw_rules_security_js/rules/sec-js/no-nosql-injection.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-nosql-injection.md +114 -0
- codelaw_rules_security_js/rules/sec-js/no-open-redirect.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-open-redirect.md +106 -0
- codelaw_rules_security_js/rules/sec-js/no-path-traversal.cases.md +54 -0
- codelaw_rules_security_js/rules/sec-js/no-path-traversal.md +187 -0
- codelaw_rules_security_js/rules/sec-js/no-prompt-injection.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-prompt-injection.md +118 -0
- codelaw_rules_security_js/rules/sec-js/no-prototype-pollution.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-prototype-pollution.md +135 -0
- codelaw_rules_security_js/rules/sec-js/no-secret-in-log.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-secret-in-log.md +86 -0
- codelaw_rules_security_js/rules/sec-js/no-sensitive-get-query.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-sensitive-get-query.md +89 -0
- codelaw_rules_security_js/rules/sec-js/no-server-env-in-client.cases.md +42 -0
- codelaw_rules_security_js/rules/sec-js/no-server-env-in-client.md +107 -0
- codelaw_rules_security_js/rules/sec-js/no-sql-template.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-sql-template.md +112 -0
- codelaw_rules_security_js/rules/sec-js/no-ssrf.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-ssrf.md +165 -0
- codelaw_rules_security_js/rules/sec-js/no-ssti.cases.md +54 -0
- codelaw_rules_security_js/rules/sec-js/no-ssti.md +128 -0
- codelaw_rules_security_js/rules/sec-js/no-stack-trace-response.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-stack-trace-response.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-tls-bypass.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-tls-bypass.md +117 -0
- codelaw_rules_security_js/rules/sec-js/no-token-in-web-storage.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-token-in-web-storage.md +92 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-deserialize.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-deserialize.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-regex.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-regex.md +93 -0
- codelaw_rules_security_js/rules/sec-js/no-unsanitized-html.cases.md +199 -0
- codelaw_rules_security_js/rules/sec-js/no-unsanitized-html.md +143 -0
- codelaw_rules_security_js/rules/sec-js/no-unvalidated-dynamic-method.cases.md +34 -0
- codelaw_rules_security_js/rules/sec-js/no-unvalidated-dynamic-method.md +94 -0
- codelaw_rules_security_js/rules/sec-js/no-user-controlled-auth-bypass.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-user-controlled-auth-bypass.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-cipher.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-cipher.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-hash.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-hash.md +97 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-key-size.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-key-size.md +117 -0
- codelaw_rules_security_js/rules/sec-js/no-window-open-opener.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-window-open-opener.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-xpath-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-xpath-injection.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-xxe.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-xxe.md +124 -0
- codelaw_rules_security_js/rules/sec-js/password-hash-effort.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/password-hash-effort.md +97 -0
- codelaw_rules_security_js/rules/sec-js/postmessage-origin.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/postmessage-origin.md +125 -0
- codelaw_rules_security_js/rules/sec-js/timing-safe-compare.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/timing-safe-compare.md +142 -0
- codelaw_rules_security_js/rules/sec-js/upload-limits.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/upload-limits.md +115 -0
- codelaw_rules_security_js-0.3.0.dist-info/METADATA +193 -0
- codelaw_rules_security_js-0.3.0.dist-info/RECORD +148 -0
- codelaw_rules_security_js-0.3.0.dist-info/WHEEL +4 -0
- codelaw_rules_security_js-0.3.0.dist-info/licenses/LICENSE +23 -0
|
@@ -0,0 +1,115 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-biased-random
|
|
3
|
+
title: "No byte taken modulo a number that does not divide 256"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: suggest
|
|
6
|
+
fix_reason: "`crypto.randomInt` needs Node 14.10 or later, and a range that starts above zero needs the bounds written"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [327], owasp: ["A04:2025"], severity: medium }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
A random byte or integer from `crypto.randomBytes` is not reduced with `%`; `crypto.randomInt(max)` does it without bias.
|
|
13
|
+
|
|
14
|
+
**Why:** `byte % 6` makes some results more likely than others (256 is not a multiple of 6), which weakens a token, a die or a shuffle (CWE-327).
|
|
15
|
+
|
|
16
|
+
```codelaw
|
|
17
|
+
match:
|
|
18
|
+
any:
|
|
19
|
+
- pattern: crypto.randomBytes($N)[$I] % $K
|
|
20
|
+
- pattern: randomBytes($N)[$I] % $K
|
|
21
|
+
- pattern: crypto.randomBytes($N).readUInt8($I) % $K
|
|
22
|
+
- pattern: crypto.randomBytes($N).readUInt16BE($I) % $K
|
|
23
|
+
- pattern: crypto.randomBytes($N).readUInt32BE($I) % $K
|
|
24
|
+
- pattern: crypto.randomBytes($N).readUInt32LE($I) % $K
|
|
25
|
+
constraints:
|
|
26
|
+
K: { not: { regex: '^(2|4|8|16|32|64|128|256|512|1024)$' } }
|
|
27
|
+
message: "A random value reduced with `%` is biased"
|
|
28
|
+
fix:
|
|
29
|
+
- replace: "crypto.randomInt($K)"
|
|
30
|
+
```
|
|
31
|
+
|
|
32
|
+
## How to fix
|
|
33
|
+
|
|
34
|
+
|
|
35
|
+
## Examples
|
|
36
|
+
|
|
37
|
+
### JavaScript
|
|
38
|
+
|
|
39
|
+
#### Don't
|
|
40
|
+
|
|
41
|
+
```js
|
|
42
|
+
const roll = crypto.randomBytes(1)[0] % 6;
|
|
43
|
+
```
|
|
44
|
+
|
|
45
|
+
#### Do
|
|
46
|
+
|
|
47
|
+
```js
|
|
48
|
+
const roll = crypto.randomInt(6);
|
|
49
|
+
```
|
|
50
|
+
|
|
51
|
+
#### Fixed
|
|
52
|
+
|
|
53
|
+
```js
|
|
54
|
+
const roll = crypto.randomInt(6);
|
|
55
|
+
```
|
|
56
|
+
|
|
57
|
+
### JSX
|
|
58
|
+
|
|
59
|
+
#### Don't
|
|
60
|
+
|
|
61
|
+
```jsx
|
|
62
|
+
const roll = crypto.randomBytes(1)[0] % 6;
|
|
63
|
+
```
|
|
64
|
+
|
|
65
|
+
#### Do
|
|
66
|
+
|
|
67
|
+
```jsx
|
|
68
|
+
const roll = crypto.randomInt(6);
|
|
69
|
+
```
|
|
70
|
+
|
|
71
|
+
#### Fixed
|
|
72
|
+
|
|
73
|
+
```jsx
|
|
74
|
+
const roll = crypto.randomInt(6);
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
### TypeScript
|
|
78
|
+
|
|
79
|
+
#### Don't
|
|
80
|
+
|
|
81
|
+
```ts
|
|
82
|
+
const roll = crypto.randomBytes(1)[0] % 6;
|
|
83
|
+
```
|
|
84
|
+
|
|
85
|
+
#### Do
|
|
86
|
+
|
|
87
|
+
```ts
|
|
88
|
+
const roll = crypto.randomInt(6);
|
|
89
|
+
```
|
|
90
|
+
|
|
91
|
+
#### Fixed
|
|
92
|
+
|
|
93
|
+
```ts
|
|
94
|
+
const roll = crypto.randomInt(6);
|
|
95
|
+
```
|
|
96
|
+
|
|
97
|
+
### TSX
|
|
98
|
+
|
|
99
|
+
#### Don't
|
|
100
|
+
|
|
101
|
+
```tsx
|
|
102
|
+
const roll = crypto.randomBytes(1)[0] % 6;
|
|
103
|
+
```
|
|
104
|
+
|
|
105
|
+
#### Do
|
|
106
|
+
|
|
107
|
+
```tsx
|
|
108
|
+
const roll = crypto.randomInt(6);
|
|
109
|
+
```
|
|
110
|
+
|
|
111
|
+
#### Fixed
|
|
112
|
+
|
|
113
|
+
```tsx
|
|
114
|
+
const roll = crypto.randomInt(6);
|
|
115
|
+
```
|
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
# sec-js/no-bidi-characters — cases
|
|
2
|
+
|
|
3
|
+
### case: a string with a bidi character has no mechanical fix
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
const user = "admin ";
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:14 sec-js/no-bidi-characters
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: an escape is not a hidden character
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
const mark = "\u202E";
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
(none)
|
|
21
|
+
```
|
|
@@ -0,0 +1,123 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-bidi-characters
|
|
3
|
+
title: "No hidden bidirectional control characters in code"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: suggest
|
|
6
|
+
fix_reason: "a comment is removed whole, since its hidden text cannot be told from the rest; a string or regular expression with such a character has no mechanical fix"
|
|
7
|
+
stability: preview
|
|
8
|
+
ported_from: [eslint-plugin-security/detect-bidi-characters]
|
|
9
|
+
security: { owasp: ["A08:2025"], severity: high }
|
|
10
|
+
since: 0.3.0
|
|
11
|
+
---
|
|
12
|
+
|
|
13
|
+
Source code, comments, strings and regular expressions hold no bidirectional control characters (U+202A–U+202E, U+2066–U+2069).
|
|
14
|
+
|
|
15
|
+
**Why:** These characters reorder how an editor and a review tool show the code, so what a reviewer reads is not what the compiler runs: the Trojan Source attack (CVE-2021-42574).
|
|
16
|
+
|
|
17
|
+
```codelaw
|
|
18
|
+
match:
|
|
19
|
+
any:
|
|
20
|
+
- pattern: $C
|
|
21
|
+
kind: comment
|
|
22
|
+
regex: '[\u202A-\u202E\u2066-\u2069]'
|
|
23
|
+
- kind: string
|
|
24
|
+
regex: '[\u202A-\u202E\u2066-\u2069]'
|
|
25
|
+
- kind: template_string
|
|
26
|
+
regex: '[\u202A-\u202E\u2066-\u2069]'
|
|
27
|
+
- kind: regex
|
|
28
|
+
regex: '[\u202A-\u202E\u2066-\u2069]'
|
|
29
|
+
message: "This code holds a hidden bidirectional control character, which can make it read differently from what it does"
|
|
30
|
+
fix:
|
|
31
|
+
- remove: $C
|
|
32
|
+
```
|
|
33
|
+
|
|
34
|
+
## How to fix
|
|
35
|
+
|
|
36
|
+
1. Delete the character: show hidden characters in the editor (or run `git diff --word-diff-regex=.`) and remove each one.
|
|
37
|
+
2. If a string needs right-to-left text, write the characters as escapes (`\u202E`) so the source does not hide them.
|
|
38
|
+
|
|
39
|
+
## Examples
|
|
40
|
+
|
|
41
|
+
### JavaScript
|
|
42
|
+
|
|
43
|
+
#### Don't
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
const level = readLevel();
|
|
47
|
+
// check the access level admin
|
|
48
|
+
```
|
|
49
|
+
|
|
50
|
+
#### Do
|
|
51
|
+
|
|
52
|
+
```js
|
|
53
|
+
const level = readLevel();
|
|
54
|
+
```
|
|
55
|
+
|
|
56
|
+
#### Fixed
|
|
57
|
+
|
|
58
|
+
```js
|
|
59
|
+
const level = readLevel();
|
|
60
|
+
```
|
|
61
|
+
|
|
62
|
+
### JSX
|
|
63
|
+
|
|
64
|
+
#### Don't
|
|
65
|
+
|
|
66
|
+
```jsx
|
|
67
|
+
const level = readLevel();
|
|
68
|
+
// check the access level admin
|
|
69
|
+
```
|
|
70
|
+
|
|
71
|
+
#### Do
|
|
72
|
+
|
|
73
|
+
```jsx
|
|
74
|
+
const level = readLevel();
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
#### Fixed
|
|
78
|
+
|
|
79
|
+
```jsx
|
|
80
|
+
const level = readLevel();
|
|
81
|
+
```
|
|
82
|
+
|
|
83
|
+
### TypeScript
|
|
84
|
+
|
|
85
|
+
#### Don't
|
|
86
|
+
|
|
87
|
+
```ts
|
|
88
|
+
const level = readLevel();
|
|
89
|
+
// check the access level admin
|
|
90
|
+
```
|
|
91
|
+
|
|
92
|
+
#### Do
|
|
93
|
+
|
|
94
|
+
```ts
|
|
95
|
+
const level = readLevel();
|
|
96
|
+
```
|
|
97
|
+
|
|
98
|
+
#### Fixed
|
|
99
|
+
|
|
100
|
+
```ts
|
|
101
|
+
const level = readLevel();
|
|
102
|
+
```
|
|
103
|
+
|
|
104
|
+
### TSX
|
|
105
|
+
|
|
106
|
+
#### Don't
|
|
107
|
+
|
|
108
|
+
```tsx
|
|
109
|
+
const level = readLevel();
|
|
110
|
+
// check the access level admin
|
|
111
|
+
```
|
|
112
|
+
|
|
113
|
+
#### Do
|
|
114
|
+
|
|
115
|
+
```tsx
|
|
116
|
+
const level = readLevel();
|
|
117
|
+
```
|
|
118
|
+
|
|
119
|
+
#### Fixed
|
|
120
|
+
|
|
121
|
+
```tsx
|
|
122
|
+
const level = readLevel();
|
|
123
|
+
```
|
|
@@ -0,0 +1,71 @@
|
|
|
1
|
+
# sec-js/no-child-process-shell — cases
|
|
2
|
+
|
|
3
|
+
### case: a literal command is fine
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
exec("ls -l");
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
(none)
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: shell: true on spawn
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
spawn("ls", [dir], { shell: true });
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
1:1 sec-js/no-child-process-shell
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: spawn without a shell
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
spawn("ls", [dir], { cwd: "/tmp" });
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
(none)
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
### case: a regex exec is not a command
|
|
34
|
+
|
|
35
|
+
```js
|
|
36
|
+
const m = /a(b)/.exec(text);
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
```expect
|
|
40
|
+
(none)
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
### case: execSync with a template
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
execSync(`ls ${dir}`);
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
```expect
|
|
50
|
+
1:1 sec-js/no-child-process-shell
|
|
51
|
+
```
|
|
52
|
+
|
|
53
|
+
### case: a member call
|
|
54
|
+
|
|
55
|
+
```js
|
|
56
|
+
child_process.exec(cmd);
|
|
57
|
+
```
|
|
58
|
+
|
|
59
|
+
```expect
|
|
60
|
+
1:1 sec-js/no-child-process-shell
|
|
61
|
+
```
|
|
62
|
+
|
|
63
|
+
### case: a literal template
|
|
64
|
+
|
|
65
|
+
```js
|
|
66
|
+
exec(`ls -l`);
|
|
67
|
+
```
|
|
68
|
+
|
|
69
|
+
```expect
|
|
70
|
+
(none)
|
|
71
|
+
```
|
|
@@ -0,0 +1,141 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-child-process-shell
|
|
3
|
+
title: "No shell command built from a value"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "the program and its arguments have to be separated by hand"
|
|
7
|
+
stability: preview
|
|
8
|
+
ported_from: [eslint-plugin-security/detect-child-process, bandit/B602, ruff/S602]
|
|
9
|
+
security: { cwe: [78], owasp: ["A05:2025"], severity: high }
|
|
10
|
+
since: 0.3.0
|
|
11
|
+
---
|
|
12
|
+
|
|
13
|
+
`exec` and `execSync` (from `child_process`) are called with a literal command only, and `spawn`-style calls do not set `shell: true`.
|
|
14
|
+
|
|
15
|
+
**Why:** A command string is parsed by a shell, so a value spliced into it can add commands with `;`, `&&` or `$(…)` (CWE-78).
|
|
16
|
+
|
|
17
|
+
```codelaw
|
|
18
|
+
match:
|
|
19
|
+
any:
|
|
20
|
+
- pattern: exec($CMD)
|
|
21
|
+
- pattern: exec($CMD, $$$REST)
|
|
22
|
+
- pattern: execSync($CMD)
|
|
23
|
+
- pattern: execSync($CMD, $$$REST)
|
|
24
|
+
- pattern: child_process.exec($CMD)
|
|
25
|
+
- pattern: child_process.exec($CMD, $$$REST)
|
|
26
|
+
- pattern: child_process.execSync($CMD)
|
|
27
|
+
- pattern: child_process.execSync($CMD, $$$REST)
|
|
28
|
+
- pattern: childProcess.exec($CMD)
|
|
29
|
+
- pattern: childProcess.exec($CMD, $$$REST)
|
|
30
|
+
- pattern: childProcess.execSync($CMD)
|
|
31
|
+
- pattern: childProcess.execSync($CMD, $$$REST)
|
|
32
|
+
- pattern: cp.exec($CMD)
|
|
33
|
+
- pattern: cp.exec($CMD, $$$REST)
|
|
34
|
+
- pattern: cp.execSync($CMD)
|
|
35
|
+
- pattern: cp.execSync($CMD, $$$REST)
|
|
36
|
+
- pattern: child.exec($CMD)
|
|
37
|
+
- pattern: child.exec($CMD, $$$REST)
|
|
38
|
+
- pattern: child.execSync($CMD)
|
|
39
|
+
- pattern: child.execSync($CMD, $$$REST)
|
|
40
|
+
- all:
|
|
41
|
+
- any:
|
|
42
|
+
- pattern: spawn($$$ARGS)
|
|
43
|
+
- pattern: spawnSync($$$ARGS)
|
|
44
|
+
- pattern: execFile($$$ARGS)
|
|
45
|
+
- pattern: execFileSync($$$ARGS)
|
|
46
|
+
- pattern: child_process.spawn($$$ARGS)
|
|
47
|
+
- pattern: child_process.spawnSync($$$ARGS)
|
|
48
|
+
- pattern: child_process.execFile($$$ARGS)
|
|
49
|
+
- pattern: child_process.execFileSync($$$ARGS)
|
|
50
|
+
- pattern: childProcess.spawn($$$ARGS)
|
|
51
|
+
- pattern: childProcess.spawnSync($$$ARGS)
|
|
52
|
+
- pattern: childProcess.execFile($$$ARGS)
|
|
53
|
+
- pattern: childProcess.execFileSync($$$ARGS)
|
|
54
|
+
- pattern: cp.spawn($$$ARGS)
|
|
55
|
+
- pattern: cp.spawnSync($$$ARGS)
|
|
56
|
+
- pattern: cp.execFile($$$ARGS)
|
|
57
|
+
- pattern: cp.execFileSync($$$ARGS)
|
|
58
|
+
- pattern: child.spawn($$$ARGS)
|
|
59
|
+
- pattern: child.spawnSync($$$ARGS)
|
|
60
|
+
- pattern: child.execFile($$$ARGS)
|
|
61
|
+
- pattern: child.execFileSync($$$ARGS)
|
|
62
|
+
- has:
|
|
63
|
+
kind: pair
|
|
64
|
+
stopBy: end
|
|
65
|
+
regex: '^["'']?shell["'']?\s*:\s*true$'
|
|
66
|
+
constraints:
|
|
67
|
+
CMD: { not: { any: [ { kind: string }, { regex: '^`[^`$]*`$' } ] } }
|
|
68
|
+
message: "A shell command is built from a value here; a value in it can add commands"
|
|
69
|
+
```
|
|
70
|
+
|
|
71
|
+
## How to fix
|
|
72
|
+
|
|
73
|
+
1. Call `execFile` or `spawn` with the program name first and the values as an array: no shell parses them.
|
|
74
|
+
2. Leave `shell` at its default (`false`); if a shell feature (a pipe, a glob) is needed, do it in the program, not in a command string.
|
|
75
|
+
3. A value that must reach a command is checked against an allow-list first.
|
|
76
|
+
|
|
77
|
+
## Examples
|
|
78
|
+
|
|
79
|
+
### JavaScript
|
|
80
|
+
|
|
81
|
+
#### Don't
|
|
82
|
+
|
|
83
|
+
```js
|
|
84
|
+
const { exec } = require("child_process");
|
|
85
|
+
exec("convert " + name + " out.png");
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
#### Do
|
|
89
|
+
|
|
90
|
+
```js
|
|
91
|
+
const { execFile } = require("child_process");
|
|
92
|
+
execFile("convert", [name, "out.png"]);
|
|
93
|
+
```
|
|
94
|
+
|
|
95
|
+
### JSX
|
|
96
|
+
|
|
97
|
+
#### Don't
|
|
98
|
+
|
|
99
|
+
```jsx
|
|
100
|
+
const { exec } = require("child_process");
|
|
101
|
+
exec("convert " + name + " out.png");
|
|
102
|
+
```
|
|
103
|
+
|
|
104
|
+
#### Do
|
|
105
|
+
|
|
106
|
+
```jsx
|
|
107
|
+
const { execFile } = require("child_process");
|
|
108
|
+
execFile("convert", [name, "out.png"]);
|
|
109
|
+
```
|
|
110
|
+
|
|
111
|
+
### TypeScript
|
|
112
|
+
|
|
113
|
+
#### Don't
|
|
114
|
+
|
|
115
|
+
```ts
|
|
116
|
+
const { exec } = require("child_process");
|
|
117
|
+
exec("convert " + name + " out.png");
|
|
118
|
+
```
|
|
119
|
+
|
|
120
|
+
#### Do
|
|
121
|
+
|
|
122
|
+
```ts
|
|
123
|
+
const { execFile } = require("child_process");
|
|
124
|
+
execFile("convert", [name, "out.png"]);
|
|
125
|
+
```
|
|
126
|
+
|
|
127
|
+
### TSX
|
|
128
|
+
|
|
129
|
+
#### Don't
|
|
130
|
+
|
|
131
|
+
```tsx
|
|
132
|
+
const { exec } = require("child_process");
|
|
133
|
+
exec("convert " + name + " out.png");
|
|
134
|
+
```
|
|
135
|
+
|
|
136
|
+
#### Do
|
|
137
|
+
|
|
138
|
+
```tsx
|
|
139
|
+
const { execFile } = require("child_process");
|
|
140
|
+
execFile("convert", [name, "out.png"]);
|
|
141
|
+
```
|
|
@@ -0,0 +1,41 @@
|
|
|
1
|
+
# sec-js/no-cleartext-http — cases
|
|
2
|
+
|
|
3
|
+
### case: localhost is fine
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
fetch("http://localhost:3000/api");
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
(none)
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: a template
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
axios.get(`http://${host}/status`);
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
1:1 sec-js/no-cleartext-http
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: axios.post
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
axios.post("http://pay.example-bank.com/", body);
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
1:1 sec-js/no-cleartext-http
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
### case: an https URL
|
|
34
|
+
|
|
35
|
+
```js
|
|
36
|
+
fetch("https://a.example-bank.com");
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
```expect
|
|
40
|
+
(none)
|
|
41
|
+
```
|
|
@@ -0,0 +1,147 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-cleartext-http
|
|
3
|
+
title: "No request made over http://"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "the server must answer on HTTPS before the scheme is switched, and the text of a URL cannot be rewritten by an edit primitive"
|
|
7
|
+
stability: preview
|
|
8
|
+
ported_from: [bandit/B310, ruff/S310]
|
|
9
|
+
security: { cwe: [319], owasp: ["A04:2025"], severity: medium }
|
|
10
|
+
since: 0.3.0
|
|
11
|
+
---
|
|
12
|
+
|
|
13
|
+
`fetch`, `axios`, `http.get`, `got` and similar are not given a literal `http://` URL, other than for localhost.
|
|
14
|
+
|
|
15
|
+
**Why:** A request over plain HTTP can be read and rewritten by anyone on the network path, including the credentials and tokens in it (CWE-319).
|
|
16
|
+
|
|
17
|
+
```codelaw
|
|
18
|
+
match:
|
|
19
|
+
any:
|
|
20
|
+
- pattern: fetch($U)
|
|
21
|
+
- pattern: fetch($U, $$$REST)
|
|
22
|
+
- pattern: axios($U)
|
|
23
|
+
- pattern: axios($U, $$$REST)
|
|
24
|
+
- pattern: axios.get($U)
|
|
25
|
+
- pattern: axios.get($U, $$$REST)
|
|
26
|
+
- pattern: axios.post($U)
|
|
27
|
+
- pattern: axios.post($U, $$$REST)
|
|
28
|
+
- pattern: axios.put($U)
|
|
29
|
+
- pattern: axios.put($U, $$$REST)
|
|
30
|
+
- pattern: axios.patch($U)
|
|
31
|
+
- pattern: axios.patch($U, $$$REST)
|
|
32
|
+
- pattern: axios.delete($U)
|
|
33
|
+
- pattern: axios.delete($U, $$$REST)
|
|
34
|
+
- pattern: axios.head($U)
|
|
35
|
+
- pattern: axios.head($U, $$$REST)
|
|
36
|
+
- pattern: axios.request($U)
|
|
37
|
+
- pattern: axios.request($U, $$$REST)
|
|
38
|
+
- pattern: got($U)
|
|
39
|
+
- pattern: got($U, $$$REST)
|
|
40
|
+
- pattern: got.get($U)
|
|
41
|
+
- pattern: got.get($U, $$$REST)
|
|
42
|
+
- pattern: got.post($U)
|
|
43
|
+
- pattern: got.post($U, $$$REST)
|
|
44
|
+
- pattern: http.get($U)
|
|
45
|
+
- pattern: http.get($U, $$$REST)
|
|
46
|
+
- pattern: http.request($U)
|
|
47
|
+
- pattern: http.request($U, $$$REST)
|
|
48
|
+
- pattern: request($U)
|
|
49
|
+
- pattern: request($U, $$$REST)
|
|
50
|
+
- pattern: request.get($U)
|
|
51
|
+
- pattern: request.get($U, $$$REST)
|
|
52
|
+
- pattern: request.post($U)
|
|
53
|
+
- pattern: request.post($U, $$$REST)
|
|
54
|
+
- pattern: needle.get($U)
|
|
55
|
+
- pattern: needle.get($U, $$$REST)
|
|
56
|
+
- pattern: needle.post($U)
|
|
57
|
+
- pattern: needle.post($U, $$$REST)
|
|
58
|
+
- pattern: superagent.get($U)
|
|
59
|
+
- pattern: superagent.get($U, $$$REST)
|
|
60
|
+
- pattern: superagent.post($U)
|
|
61
|
+
- pattern: superagent.post($U, $$$REST)
|
|
62
|
+
- pattern: ky($U)
|
|
63
|
+
- pattern: ky($U, $$$REST)
|
|
64
|
+
- pattern: ky.get($U)
|
|
65
|
+
- pattern: ky.get($U, $$$REST)
|
|
66
|
+
- pattern: ky.post($U)
|
|
67
|
+
- pattern: ky.post($U, $$$REST)
|
|
68
|
+
- pattern: $.ajax($U)
|
|
69
|
+
- pattern: $.ajax($U, $$$REST)
|
|
70
|
+
- pattern: $.get($U)
|
|
71
|
+
- pattern: $.get($U, $$$REST)
|
|
72
|
+
- pattern: $.getJSON($U)
|
|
73
|
+
- pattern: $.getJSON($U, $$$REST)
|
|
74
|
+
constraints:
|
|
75
|
+
U:
|
|
76
|
+
any:
|
|
77
|
+
- kind: string
|
|
78
|
+
- kind: template_string
|
|
79
|
+
regex: '^["''`]http://'
|
|
80
|
+
not:
|
|
81
|
+
regex: '^["''`]http://(localhost|127\.0\.0\.1|0\.0\.0\.0|\[::1\]|[\w.-]*\.(local|localhost|test|invalid))([:/"''`]|$)'
|
|
82
|
+
message: "`$U` is fetched over plain HTTP; anyone on the path can read or change it"
|
|
83
|
+
```
|
|
84
|
+
|
|
85
|
+
## How to fix
|
|
86
|
+
|
|
87
|
+
1. Change `http://` to `https://` in the URL, and check the server answers on it.
|
|
88
|
+
2. Where the host has no certificate, get one (Let's Encrypt) rather than falling back to HTTP.
|
|
89
|
+
3. A URL that is only ever local (`localhost`, `127.0.0.1`) may stay; those are not flagged.
|
|
90
|
+
|
|
91
|
+
## Examples
|
|
92
|
+
|
|
93
|
+
### JavaScript
|
|
94
|
+
|
|
95
|
+
#### Don't
|
|
96
|
+
|
|
97
|
+
```js
|
|
98
|
+
const response = await fetch("http://api.example-bank.com/accounts");
|
|
99
|
+
```
|
|
100
|
+
|
|
101
|
+
#### Do
|
|
102
|
+
|
|
103
|
+
```js
|
|
104
|
+
const response = await fetch("https://api.example-bank.com/accounts");
|
|
105
|
+
```
|
|
106
|
+
|
|
107
|
+
### JSX
|
|
108
|
+
|
|
109
|
+
#### Don't
|
|
110
|
+
|
|
111
|
+
```jsx
|
|
112
|
+
const response = await fetch("http://api.example-bank.com/accounts");
|
|
113
|
+
```
|
|
114
|
+
|
|
115
|
+
#### Do
|
|
116
|
+
|
|
117
|
+
```jsx
|
|
118
|
+
const response = await fetch("https://api.example-bank.com/accounts");
|
|
119
|
+
```
|
|
120
|
+
|
|
121
|
+
### TypeScript
|
|
122
|
+
|
|
123
|
+
#### Don't
|
|
124
|
+
|
|
125
|
+
```ts
|
|
126
|
+
const response = await fetch("http://api.example-bank.com/accounts");
|
|
127
|
+
```
|
|
128
|
+
|
|
129
|
+
#### Do
|
|
130
|
+
|
|
131
|
+
```ts
|
|
132
|
+
const response = await fetch("https://api.example-bank.com/accounts");
|
|
133
|
+
```
|
|
134
|
+
|
|
135
|
+
### TSX
|
|
136
|
+
|
|
137
|
+
#### Don't
|
|
138
|
+
|
|
139
|
+
```tsx
|
|
140
|
+
const response = await fetch("http://api.example-bank.com/accounts");
|
|
141
|
+
```
|
|
142
|
+
|
|
143
|
+
#### Do
|
|
144
|
+
|
|
145
|
+
```tsx
|
|
146
|
+
const response = await fetch("https://api.example-bank.com/accounts");
|
|
147
|
+
```
|
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
# sec-js/no-cors-wildcard-credentials — cases
|
|
2
|
+
|
|
3
|
+
### case: a star
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
cors({ credentials: true, origin: "*" });
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:1 sec-js/no-cors-wildcard-credentials
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: an allow-list
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
cors({ origin: ["https://a.example"], credentials: true });
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
(none)
|
|
21
|
+
```
|