codelaw-rules-security-js 0.3.0__py3-none-any.whl
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- codelaw_rules_security_js/LICENSE +23 -0
- codelaw_rules_security_js/NOTICE +22 -0
- codelaw_rules_security_js/README.md +183 -0
- codelaw_rules_security_js/codelaw-pack.toml +6 -0
- codelaw_rules_security_js/corpus.toml +70 -0
- codelaw_rules_security_js/data/sources/browser.json +24 -0
- codelaw_rules_security_js/data/sources/express.json +28 -0
- codelaw_rules_security_js/data/sources/koa.json +18 -0
- codelaw_rules_security_js/data/sources/llm.json +14 -0
- codelaw_rules_security_js/data/sources/nextjs.json +13 -0
- codelaw_rules_security_js/presets/sec-js/recommended.toml +58 -0
- codelaw_rules_security_js/presets/sec-js/strict.toml +15 -0
- codelaw_rules_security_js/rules/sec-js/angularjs-sce-disabled.cases.md +129 -0
- codelaw_rules_security_js/rules/sec-js/angularjs-sce-disabled.md +132 -0
- codelaw_rules_security_js/rules/sec-js/cookie-flags.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/cookie-flags.md +117 -0
- codelaw_rules_security_js/rules/sec-js/express-hardening.cases.md +12 -0
- codelaw_rules_security_js/rules/sec-js/express-hardening.md +135 -0
- codelaw_rules_security_js/rules/sec-js/express-session-secret.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/express-session-secret.md +101 -0
- codelaw_rules_security_js/rules/sec-js/graphql-hardening.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/graphql-hardening.md +116 -0
- codelaw_rules_security_js/rules/sec-js/helmet-config.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/helmet-config.md +88 -0
- codelaw_rules_security_js/rules/sec-js/jwt-verify.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/jwt-verify.md +107 -0
- codelaw_rules_security_js/rules/sec-js/missing-rate-limit.cases.md +22 -0
- codelaw_rules_security_js/rules/sec-js/missing-rate-limit.md +119 -0
- codelaw_rules_security_js/rules/sec-js/no-archive-slip.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-archive-slip.md +119 -0
- codelaw_rules_security_js/rules/sec-js/no-bad-tag-filter.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-bad-tag-filter.md +85 -0
- codelaw_rules_security_js/rules/sec-js/no-biased-random.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-biased-random.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-bidi-characters.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-bidi-characters.md +123 -0
- codelaw_rules_security_js/rules/sec-js/no-child-process-shell.cases.md +71 -0
- codelaw_rules_security_js/rules/sec-js/no-child-process-shell.md +141 -0
- codelaw_rules_security_js/rules/sec-js/no-cleartext-http.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-cleartext-http.md +147 -0
- codelaw_rules_security_js/rules/sec-js/no-cors-wildcard-credentials.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-cors-wildcard-credentials.md +92 -0
- codelaw_rules_security_js/rules/sec-js/no-csrf-before-method-override.cases.md +12 -0
- codelaw_rules_security_js/rules/sec-js/no-csrf-before-method-override.md +128 -0
- codelaw_rules_security_js/rules/sec-js/no-dangerously-set-inner-html.cases.md +141 -0
- codelaw_rules_security_js/rules/sec-js/no-dangerously-set-inner-html.md +107 -0
- codelaw_rules_security_js/rules/sec-js/no-document-cookie-token.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-document-cookie-token.md +89 -0
- codelaw_rules_security_js/rules/sec-js/no-dynamic-script-src.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-dynamic-script-src.md +100 -0
- codelaw_rules_security_js/rules/sec-js/no-electron-insecure.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-electron-insecure.md +134 -0
- codelaw_rules_security_js/rules/sec-js/no-eval.cases.md +52 -0
- codelaw_rules_security_js/rules/sec-js/no-eval.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-format-string.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-format-string.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-crypto-key.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-crypto-key.md +96 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-secret.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-hardcoded-secret.md +112 -0
- codelaw_rules_security_js/rules/sec-js/no-header-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-header-injection.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-sanitization.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-sanitization.md +113 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-url-check.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-incomplete-url-check.md +118 -0
- codelaw_rules_security_js/rules/sec-js/no-insecure-random.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-insecure-random.md +127 -0
- codelaw_rules_security_js/rules/sec-js/no-javascript-url.cases.md +61 -0
- codelaw_rules_security_js/rules/sec-js/no-javascript-url.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-jquery-html-sink.cases.md +139 -0
- codelaw_rules_security_js/rules/sec-js/no-jquery-html-sink.md +131 -0
- codelaw_rules_security_js/rules/sec-js/no-ldap-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-ldap-injection.md +87 -0
- codelaw_rules_security_js/rules/sec-js/no-llm-output-to-sink.cases.md +34 -0
- codelaw_rules_security_js/rules/sec-js/no-llm-output-to-sink.md +105 -0
- codelaw_rules_security_js/rules/sec-js/no-log-injection.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-log-injection.md +113 -0
- codelaw_rules_security_js/rules/sec-js/no-mass-assignment.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-mass-assignment.md +100 -0
- codelaw_rules_security_js/rules/sec-js/no-new-buffer.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-new-buffer.md +120 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-fs-filename.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-fs-filename.md +151 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-require.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-non-literal-require.md +88 -0
- codelaw_rules_security_js/rules/sec-js/no-nosql-injection.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-nosql-injection.md +114 -0
- codelaw_rules_security_js/rules/sec-js/no-open-redirect.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-open-redirect.md +106 -0
- codelaw_rules_security_js/rules/sec-js/no-path-traversal.cases.md +54 -0
- codelaw_rules_security_js/rules/sec-js/no-path-traversal.md +187 -0
- codelaw_rules_security_js/rules/sec-js/no-prompt-injection.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-prompt-injection.md +118 -0
- codelaw_rules_security_js/rules/sec-js/no-prototype-pollution.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-prototype-pollution.md +135 -0
- codelaw_rules_security_js/rules/sec-js/no-secret-in-log.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-secret-in-log.md +86 -0
- codelaw_rules_security_js/rules/sec-js/no-sensitive-get-query.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-sensitive-get-query.md +89 -0
- codelaw_rules_security_js/rules/sec-js/no-server-env-in-client.cases.md +42 -0
- codelaw_rules_security_js/rules/sec-js/no-server-env-in-client.md +107 -0
- codelaw_rules_security_js/rules/sec-js/no-sql-template.cases.md +51 -0
- codelaw_rules_security_js/rules/sec-js/no-sql-template.md +112 -0
- codelaw_rules_security_js/rules/sec-js/no-ssrf.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-ssrf.md +165 -0
- codelaw_rules_security_js/rules/sec-js/no-ssti.cases.md +54 -0
- codelaw_rules_security_js/rules/sec-js/no-ssti.md +128 -0
- codelaw_rules_security_js/rules/sec-js/no-stack-trace-response.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-stack-trace-response.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-tls-bypass.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-tls-bypass.md +117 -0
- codelaw_rules_security_js/rules/sec-js/no-token-in-web-storage.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-token-in-web-storage.md +92 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-deserialize.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-deserialize.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-regex.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-unsafe-regex.md +93 -0
- codelaw_rules_security_js/rules/sec-js/no-unsanitized-html.cases.md +199 -0
- codelaw_rules_security_js/rules/sec-js/no-unsanitized-html.md +143 -0
- codelaw_rules_security_js/rules/sec-js/no-unvalidated-dynamic-method.cases.md +34 -0
- codelaw_rules_security_js/rules/sec-js/no-unvalidated-dynamic-method.md +94 -0
- codelaw_rules_security_js/rules/sec-js/no-user-controlled-auth-bypass.cases.md +11 -0
- codelaw_rules_security_js/rules/sec-js/no-user-controlled-auth-bypass.md +102 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-cipher.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-cipher.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-hash.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-hash.md +97 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-key-size.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-weak-key-size.md +117 -0
- codelaw_rules_security_js/rules/sec-js/no-window-open-opener.cases.md +31 -0
- codelaw_rules_security_js/rules/sec-js/no-window-open-opener.md +115 -0
- codelaw_rules_security_js/rules/sec-js/no-xpath-injection.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-xpath-injection.md +95 -0
- codelaw_rules_security_js/rules/sec-js/no-xxe.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/no-xxe.md +124 -0
- codelaw_rules_security_js/rules/sec-js/password-hash-effort.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/password-hash-effort.md +97 -0
- codelaw_rules_security_js/rules/sec-js/postmessage-origin.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/postmessage-origin.md +125 -0
- codelaw_rules_security_js/rules/sec-js/timing-safe-compare.cases.md +41 -0
- codelaw_rules_security_js/rules/sec-js/timing-safe-compare.md +142 -0
- codelaw_rules_security_js/rules/sec-js/upload-limits.cases.md +21 -0
- codelaw_rules_security_js/rules/sec-js/upload-limits.md +115 -0
- codelaw_rules_security_js-0.3.0.dist-info/METADATA +193 -0
- codelaw_rules_security_js-0.3.0.dist-info/RECORD +148 -0
- codelaw_rules_security_js-0.3.0.dist-info/WHEEL +4 -0
- codelaw_rules_security_js-0.3.0.dist-info/licenses/LICENSE +23 -0
|
@@ -0,0 +1,92 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-cors-wildcard-credentials
|
|
3
|
+
title: "No CORS that allows every origin together with credentials"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "which origins may call the API is a decision for the author"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [942], owasp: ["A02:2025"], severity: high }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
`cors()` is not given `origin: "*"` or `origin: true` together with `credentials: true`.
|
|
13
|
+
|
|
14
|
+
**Why:** `origin: true` reflects whatever origin asks, so any website can send the visitor's cookies to your API and read the answer (CWE-942).
|
|
15
|
+
|
|
16
|
+
```codelaw
|
|
17
|
+
match:
|
|
18
|
+
all:
|
|
19
|
+
- pattern: cors($$$ARGS)
|
|
20
|
+
- has:
|
|
21
|
+
kind: pair
|
|
22
|
+
stopBy: end
|
|
23
|
+
regex: '^["'']?origin["'']?\s*:\s*(["'']\*["'']|true)\s*$'
|
|
24
|
+
- has:
|
|
25
|
+
kind: pair
|
|
26
|
+
stopBy: end
|
|
27
|
+
regex: '^["'']?credentials["'']?\s*:\s*true\s*$'
|
|
28
|
+
message: "Every origin is allowed together with credentials; any site can use the visitor's session"
|
|
29
|
+
```
|
|
30
|
+
|
|
31
|
+
## How to fix
|
|
32
|
+
|
|
33
|
+
1. List the origins that may call the API: `origin: ["https://app.example.com"]`, or a function that checks a list.
|
|
34
|
+
2. Drop `credentials: true` if the API does not use cookies; then `origin: "*"` is acceptable for public data.
|
|
35
|
+
|
|
36
|
+
## Examples
|
|
37
|
+
|
|
38
|
+
### JavaScript
|
|
39
|
+
|
|
40
|
+
#### Don't
|
|
41
|
+
|
|
42
|
+
```js
|
|
43
|
+
app.use(cors({ origin: true, credentials: true }));
|
|
44
|
+
```
|
|
45
|
+
|
|
46
|
+
#### Do
|
|
47
|
+
|
|
48
|
+
```js
|
|
49
|
+
app.use(cors({ origin: ["https://app.example.com"], credentials: true }));
|
|
50
|
+
```
|
|
51
|
+
|
|
52
|
+
### JSX
|
|
53
|
+
|
|
54
|
+
#### Don't
|
|
55
|
+
|
|
56
|
+
```jsx
|
|
57
|
+
app.use(cors({ origin: true, credentials: true }));
|
|
58
|
+
```
|
|
59
|
+
|
|
60
|
+
#### Do
|
|
61
|
+
|
|
62
|
+
```jsx
|
|
63
|
+
app.use(cors({ origin: ["https://app.example.com"], credentials: true }));
|
|
64
|
+
```
|
|
65
|
+
|
|
66
|
+
### TypeScript
|
|
67
|
+
|
|
68
|
+
#### Don't
|
|
69
|
+
|
|
70
|
+
```ts
|
|
71
|
+
app.use(cors({ origin: true, credentials: true }));
|
|
72
|
+
```
|
|
73
|
+
|
|
74
|
+
#### Do
|
|
75
|
+
|
|
76
|
+
```ts
|
|
77
|
+
app.use(cors({ origin: ["https://app.example.com"], credentials: true }));
|
|
78
|
+
```
|
|
79
|
+
|
|
80
|
+
### TSX
|
|
81
|
+
|
|
82
|
+
#### Don't
|
|
83
|
+
|
|
84
|
+
```tsx
|
|
85
|
+
app.use(cors({ origin: true, credentials: true }));
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
#### Do
|
|
89
|
+
|
|
90
|
+
```tsx
|
|
91
|
+
app.use(cors({ origin: ["https://app.example.com"], credentials: true }));
|
|
92
|
+
```
|
|
@@ -0,0 +1,128 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-csrf-before-method-override
|
|
3
|
+
title: "No method-override before the CSRF check"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: suggest
|
|
6
|
+
fix_reason: "moving a middleware changes the order every route in the file runs them in"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [352], owasp: ["A01:2025"], severity: medium }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
`methodOverride` is registered after the CSRF middleware, not before it.
|
|
13
|
+
|
|
14
|
+
**Why:** The CSRF middleware decides by the request's method: a `POST` rewritten to `DELETE` after the check was never checked as one that changes state (CWE-352).
|
|
15
|
+
|
|
16
|
+
```codelaw
|
|
17
|
+
match:
|
|
18
|
+
all:
|
|
19
|
+
- kind: expression_statement
|
|
20
|
+
- has:
|
|
21
|
+
pattern: $A.use(methodOverride($$$M))
|
|
22
|
+
- precedes:
|
|
23
|
+
stopBy: end
|
|
24
|
+
pattern: $CSRF
|
|
25
|
+
kind: expression_statement
|
|
26
|
+
regex: '^\w+\.use\((csrf|csurf|lusca\.csrf|csrfProtection)\b'
|
|
27
|
+
message: "`methodOverride` runs before the CSRF check, so the check sees the wrong method"
|
|
28
|
+
fix:
|
|
29
|
+
- insert-after: { target: $CSRF, text: "\n$$MATCH" }
|
|
30
|
+
- remove
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
## How to fix
|
|
34
|
+
|
|
35
|
+
|
|
36
|
+
## Examples
|
|
37
|
+
|
|
38
|
+
### JavaScript
|
|
39
|
+
|
|
40
|
+
#### Don't
|
|
41
|
+
|
|
42
|
+
```js
|
|
43
|
+
app.use(methodOverride("_method"));
|
|
44
|
+
app.use(csurf());
|
|
45
|
+
```
|
|
46
|
+
|
|
47
|
+
#### Do
|
|
48
|
+
|
|
49
|
+
```js
|
|
50
|
+
app.use(csurf());
|
|
51
|
+
app.use(methodOverride("_method"));
|
|
52
|
+
```
|
|
53
|
+
|
|
54
|
+
#### Fixed
|
|
55
|
+
|
|
56
|
+
```js
|
|
57
|
+
app.use(csurf());
|
|
58
|
+
app.use(methodOverride("_method"));
|
|
59
|
+
```
|
|
60
|
+
|
|
61
|
+
### JSX
|
|
62
|
+
|
|
63
|
+
#### Don't
|
|
64
|
+
|
|
65
|
+
```jsx
|
|
66
|
+
app.use(methodOverride("_method"));
|
|
67
|
+
app.use(csurf());
|
|
68
|
+
```
|
|
69
|
+
|
|
70
|
+
#### Do
|
|
71
|
+
|
|
72
|
+
```jsx
|
|
73
|
+
app.use(csurf());
|
|
74
|
+
app.use(methodOverride("_method"));
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
#### Fixed
|
|
78
|
+
|
|
79
|
+
```jsx
|
|
80
|
+
app.use(csurf());
|
|
81
|
+
app.use(methodOverride("_method"));
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
### TypeScript
|
|
85
|
+
|
|
86
|
+
#### Don't
|
|
87
|
+
|
|
88
|
+
```ts
|
|
89
|
+
app.use(methodOverride("_method"));
|
|
90
|
+
app.use(csurf());
|
|
91
|
+
```
|
|
92
|
+
|
|
93
|
+
#### Do
|
|
94
|
+
|
|
95
|
+
```ts
|
|
96
|
+
app.use(csurf());
|
|
97
|
+
app.use(methodOverride("_method"));
|
|
98
|
+
```
|
|
99
|
+
|
|
100
|
+
#### Fixed
|
|
101
|
+
|
|
102
|
+
```ts
|
|
103
|
+
app.use(csurf());
|
|
104
|
+
app.use(methodOverride("_method"));
|
|
105
|
+
```
|
|
106
|
+
|
|
107
|
+
### TSX
|
|
108
|
+
|
|
109
|
+
#### Don't
|
|
110
|
+
|
|
111
|
+
```tsx
|
|
112
|
+
app.use(methodOverride("_method"));
|
|
113
|
+
app.use(csurf());
|
|
114
|
+
```
|
|
115
|
+
|
|
116
|
+
#### Do
|
|
117
|
+
|
|
118
|
+
```tsx
|
|
119
|
+
app.use(csurf());
|
|
120
|
+
app.use(methodOverride("_method"));
|
|
121
|
+
```
|
|
122
|
+
|
|
123
|
+
#### Fixed
|
|
124
|
+
|
|
125
|
+
```tsx
|
|
126
|
+
app.use(csurf());
|
|
127
|
+
app.use(methodOverride("_method"));
|
|
128
|
+
```
|
|
@@ -0,0 +1,141 @@
|
|
|
1
|
+
# sec-js/no-dangerously-set-inner-html — cases
|
|
2
|
+
|
|
3
|
+
### case: in JSX
|
|
4
|
+
|
|
5
|
+
```jsx
|
|
6
|
+
const a = <div dangerouslySetInnerHTML={{ __html: html }} />;
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:43 sec-js/no-dangerously-set-inner-html
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: a literal
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
const p = { dangerouslySetInnerHTML: { __html: "<b>x</b>" } };
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
(none)
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: an unsanitized call result
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
const p = { dangerouslySetInnerHTML: { __html: render(md) } };
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
1:40 sec-js/no-dangerously-set-inner-html
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
### case: extend: the project function passes
|
|
34
|
+
|
|
35
|
+
```js options={"sanitizers":[{"name":"cleanHtml","module":"@acme/security"}]}
|
|
36
|
+
import { cleanHtml } from "@acme/security";
|
|
37
|
+
const p = { dangerouslySetInnerHTML: { __html: cleanHtml(x) } };
|
|
38
|
+
```
|
|
39
|
+
|
|
40
|
+
```expect
|
|
41
|
+
(none)
|
|
42
|
+
```
|
|
43
|
+
|
|
44
|
+
### case: extend: the built-in DOMPurify still passes
|
|
45
|
+
|
|
46
|
+
```js options={"sanitizers":[{"name":"cleanHtml","module":"@acme/security"}]}
|
|
47
|
+
import DOMPurify from "dompurify";
|
|
48
|
+
const p = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(x) } };
|
|
49
|
+
```
|
|
50
|
+
|
|
51
|
+
```expect
|
|
52
|
+
(none)
|
|
53
|
+
```
|
|
54
|
+
|
|
55
|
+
### case: replace: the project function passes
|
|
56
|
+
|
|
57
|
+
```js options={"sanitizers":[{"name":"cleanHtml","module":"@acme/security"}],"sanitizers_mode":"replace"}
|
|
58
|
+
import { cleanHtml } from "@acme/security";
|
|
59
|
+
const p = { dangerouslySetInnerHTML: { __html: cleanHtml(x) } };
|
|
60
|
+
```
|
|
61
|
+
|
|
62
|
+
```expect
|
|
63
|
+
(none)
|
|
64
|
+
```
|
|
65
|
+
|
|
66
|
+
### case: replace: DOMPurify is reported
|
|
67
|
+
|
|
68
|
+
```js options={"sanitizers":[{"name":"cleanHtml","module":"@acme/security"}],"sanitizers_mode":"replace"}
|
|
69
|
+
import DOMPurify from "dompurify";
|
|
70
|
+
const p = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(x) } };
|
|
71
|
+
```
|
|
72
|
+
|
|
73
|
+
```expect
|
|
74
|
+
2:40 sec-js/no-dangerously-set-inner-html
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
### case: an aliased import passes
|
|
78
|
+
|
|
79
|
+
```js options={"sanitizers":[{"name":"cleanHtml","module":"@acme/security"}]}
|
|
80
|
+
import { cleanHtml as clean } from "@acme/security";
|
|
81
|
+
const p = { dangerouslySetInnerHTML: { __html: clean(x) } };
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
```expect
|
|
85
|
+
(none)
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
### case: a same-named local function is reported
|
|
89
|
+
|
|
90
|
+
```js
|
|
91
|
+
function sanitizeHtml(x) { return x; }
|
|
92
|
+
const p = { dangerouslySetInnerHTML: { __html: sanitizeHtml(x) } };
|
|
93
|
+
```
|
|
94
|
+
|
|
95
|
+
```expect
|
|
96
|
+
2:40 sec-js/no-dangerously-set-inner-html
|
|
97
|
+
```
|
|
98
|
+
|
|
99
|
+
### case: a function of the same name from another module is reported
|
|
100
|
+
|
|
101
|
+
```js options={"sanitizers":[{"name":"cleanHtml","module":"@acme/security"}]}
|
|
102
|
+
import { cleanHtml } from "left-pad";
|
|
103
|
+
const p = { dangerouslySetInnerHTML: { __html: cleanHtml(x) } };
|
|
104
|
+
```
|
|
105
|
+
|
|
106
|
+
```expect
|
|
107
|
+
2:40 sec-js/no-dangerously-set-inner-html
|
|
108
|
+
```
|
|
109
|
+
|
|
110
|
+
### case: the global DOMPurify passes
|
|
111
|
+
|
|
112
|
+
```js
|
|
113
|
+
const p = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(x) } };
|
|
114
|
+
```
|
|
115
|
+
|
|
116
|
+
```expect
|
|
117
|
+
(none)
|
|
118
|
+
```
|
|
119
|
+
|
|
120
|
+
### case: the built-in sanitize-html import passes
|
|
121
|
+
|
|
122
|
+
```js
|
|
123
|
+
import sanitizeHtml from "sanitize-html";
|
|
124
|
+
const p = { dangerouslySetInnerHTML: { __html: sanitizeHtml(x) } };
|
|
125
|
+
```
|
|
126
|
+
|
|
127
|
+
```expect
|
|
128
|
+
(none)
|
|
129
|
+
```
|
|
130
|
+
|
|
131
|
+
### case: an instance made by the module's factory passes
|
|
132
|
+
|
|
133
|
+
```js
|
|
134
|
+
import createDOMPurify from "dompurify";
|
|
135
|
+
const DOMPurify = createDOMPurify(window);
|
|
136
|
+
const p = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(html) } };
|
|
137
|
+
```
|
|
138
|
+
|
|
139
|
+
```expect
|
|
140
|
+
(none)
|
|
141
|
+
```
|
|
@@ -0,0 +1,107 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-dangerously-set-inner-html
|
|
3
|
+
title: "No dangerouslySetInnerHTML from a value that is not sanitized"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "whether the value needs markup at all is a decision for the author"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [79], owasp: ["A05:2025"], severity: high }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
options:
|
|
11
|
+
sanitizers:
|
|
12
|
+
type: "call[]"
|
|
13
|
+
description: "functions whose result may reach the sink: a callee path (global) or { name, module }; `sanitizers_mode: replace` makes them the only ones that count"
|
|
14
|
+
default:
|
|
15
|
+
- { name: DOMPurify.sanitize, module: [dompurify, isomorphic-dompurify] }
|
|
16
|
+
- DOMPurify.sanitize
|
|
17
|
+
- { name: sanitizeHtml, module: sanitize-html }
|
|
18
|
+
- { name: xss, module: xss }
|
|
19
|
+
- { name: filterXSS, module: xss }
|
|
20
|
+
- { name: escapeHtml, module: escape-html }
|
|
21
|
+
- { name: escape, module: [lodash, lodash-es, lodash/escape, he] }
|
|
22
|
+
- { name: _.escape, module: [lodash, lodash-es] }
|
|
23
|
+
- { name: he.escape, module: he }
|
|
24
|
+
- "*.createHTML"
|
|
25
|
+
---
|
|
26
|
+
|
|
27
|
+
React's `dangerouslySetInnerHTML` is given a literal, or a value that went through a sanitizer such as `DOMPurify.sanitize`.
|
|
28
|
+
|
|
29
|
+
**Your sanitizer:** a value passes when it is a call to one of the `sanitizers`: the built-in list (DOMPurify, sanitize-html, xss, escape-html, lodash and he `escape`, Trusted Types `createHTML`) plus your own, each matched by name and by the module it is imported from, so a local `function sanitize(x) { return x }` does not pass. `sanitizers_mode = "replace"` makes yours the only ones that count. It does not follow a value through a variable: `const c = clean(x)` then `c` at the sink is not a call. Add a project function with `sanitizers = [{ name = "sanitizeHtml", module = "@acme/security" }]`.
|
|
30
|
+
|
|
31
|
+
**Why:** The name is the warning: the value becomes the element's HTML, so markup an attacker supplies runs in the page (CWE-79).
|
|
32
|
+
|
|
33
|
+
```codelaw
|
|
34
|
+
match:
|
|
35
|
+
pattern:
|
|
36
|
+
context: '({ __html: $V })'
|
|
37
|
+
selector: pair
|
|
38
|
+
constraints:
|
|
39
|
+
V: { not: { any: [ { kind: string }, { regex: '^`[^`$]*`$' } ] } }
|
|
40
|
+
where:
|
|
41
|
+
$V: { not: { calls: sanitizers } }
|
|
42
|
+
message: "`$V` becomes HTML here without one of: $OPTION.sanitizers (add yours to `sanitizers`); markup in it runs in the page"
|
|
43
|
+
```
|
|
44
|
+
|
|
45
|
+
## How to fix
|
|
46
|
+
|
|
47
|
+
1. Render the value as text (`{comment.body}`) wherever it need not carry markup.
|
|
48
|
+
2. Where it must, pass it through a sanitizer first: `DOMPurify.sanitize(html)`, and keep the allowed tags narrow.
|
|
49
|
+
3. Sanitize once, at the edge, and keep the sanitized string in its own variable so the call is next to the use.
|
|
50
|
+
|
|
51
|
+
## Examples
|
|
52
|
+
|
|
53
|
+
### JavaScript
|
|
54
|
+
|
|
55
|
+
#### Don't
|
|
56
|
+
|
|
57
|
+
```js
|
|
58
|
+
const props = { dangerouslySetInnerHTML: { __html: comment.body } };
|
|
59
|
+
```
|
|
60
|
+
|
|
61
|
+
#### Do
|
|
62
|
+
|
|
63
|
+
```js
|
|
64
|
+
const props = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(comment.body) } };
|
|
65
|
+
```
|
|
66
|
+
|
|
67
|
+
### JSX
|
|
68
|
+
|
|
69
|
+
#### Don't
|
|
70
|
+
|
|
71
|
+
```jsx
|
|
72
|
+
const props = { dangerouslySetInnerHTML: { __html: comment.body } };
|
|
73
|
+
```
|
|
74
|
+
|
|
75
|
+
#### Do
|
|
76
|
+
|
|
77
|
+
```jsx
|
|
78
|
+
const props = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(comment.body) } };
|
|
79
|
+
```
|
|
80
|
+
|
|
81
|
+
### TypeScript
|
|
82
|
+
|
|
83
|
+
#### Don't
|
|
84
|
+
|
|
85
|
+
```ts
|
|
86
|
+
const props = { dangerouslySetInnerHTML: { __html: comment.body } };
|
|
87
|
+
```
|
|
88
|
+
|
|
89
|
+
#### Do
|
|
90
|
+
|
|
91
|
+
```ts
|
|
92
|
+
const props = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(comment.body) } };
|
|
93
|
+
```
|
|
94
|
+
|
|
95
|
+
### TSX
|
|
96
|
+
|
|
97
|
+
#### Don't
|
|
98
|
+
|
|
99
|
+
```tsx
|
|
100
|
+
const props = { dangerouslySetInnerHTML: { __html: comment.body } };
|
|
101
|
+
```
|
|
102
|
+
|
|
103
|
+
#### Do
|
|
104
|
+
|
|
105
|
+
```tsx
|
|
106
|
+
const props = { dangerouslySetInnerHTML: { __html: DOMPurify.sanitize(comment.body) } };
|
|
107
|
+
```
|
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
# sec-js/no-document-cookie-token — cases
|
|
2
|
+
|
|
3
|
+
### case: session
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
document.cookie = "session=" + id;
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:1 sec-js/no-document-cookie-token
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: append
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
document.cookie += "jwt=" + t;
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
1:1 sec-js/no-document-cookie-token
|
|
21
|
+
```
|
|
@@ -0,0 +1,89 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: sec-js/no-document-cookie-token
|
|
3
|
+
title: "No token or session written to document.cookie"
|
|
4
|
+
languages: [javascript, jsx, typescript, tsx]
|
|
5
|
+
fix: manual
|
|
6
|
+
fix_reason: "the cookie has to be set by the server, which is a change to the response"
|
|
7
|
+
stability: preview
|
|
8
|
+
security: { cwe: [1004], owasp: ["A07:2025"], severity: medium }
|
|
9
|
+
since: 0.3.0
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
A token, a session id or a password is not written to `document.cookie`; the server sets it with `Set-Cookie`.
|
|
13
|
+
|
|
14
|
+
**Why:** A cookie script can write is a cookie script can read, so it has no `HttpOnly` flag, and any XSS reads it (CWE-1004).
|
|
15
|
+
|
|
16
|
+
```codelaw
|
|
17
|
+
match:
|
|
18
|
+
any:
|
|
19
|
+
- all:
|
|
20
|
+
- pattern: document.cookie = $V
|
|
21
|
+
- regex: '(?i)(token|jwt|session|auth|secret|password|sid)\w*\s*='
|
|
22
|
+
- all:
|
|
23
|
+
- pattern: document.cookie += $W
|
|
24
|
+
- regex: '(?i)(token|jwt|session|auth|secret|password|sid)\w*\s*='
|
|
25
|
+
message: "A credential is written to a cookie script can read"
|
|
26
|
+
```
|
|
27
|
+
|
|
28
|
+
## How to fix
|
|
29
|
+
|
|
30
|
+
1. Return the credential in the response and let the server send `Set-Cookie: token=…; HttpOnly; Secure; SameSite=Lax`.
|
|
31
|
+
2. Keep the cookie out of script's reach: the page calls the API and the browser attaches the cookie.
|
|
32
|
+
|
|
33
|
+
## Examples
|
|
34
|
+
|
|
35
|
+
### JavaScript
|
|
36
|
+
|
|
37
|
+
#### Don't
|
|
38
|
+
|
|
39
|
+
```js
|
|
40
|
+
document.cookie = "token=" + token + "; path=/";
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
#### Do
|
|
44
|
+
|
|
45
|
+
```js
|
|
46
|
+
document.cookie = "theme=dark; path=/";
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
### JSX
|
|
50
|
+
|
|
51
|
+
#### Don't
|
|
52
|
+
|
|
53
|
+
```jsx
|
|
54
|
+
document.cookie = "token=" + token + "; path=/";
|
|
55
|
+
```
|
|
56
|
+
|
|
57
|
+
#### Do
|
|
58
|
+
|
|
59
|
+
```jsx
|
|
60
|
+
document.cookie = "theme=dark; path=/";
|
|
61
|
+
```
|
|
62
|
+
|
|
63
|
+
### TypeScript
|
|
64
|
+
|
|
65
|
+
#### Don't
|
|
66
|
+
|
|
67
|
+
```ts
|
|
68
|
+
document.cookie = "token=" + token + "; path=/";
|
|
69
|
+
```
|
|
70
|
+
|
|
71
|
+
#### Do
|
|
72
|
+
|
|
73
|
+
```ts
|
|
74
|
+
document.cookie = "theme=dark; path=/";
|
|
75
|
+
```
|
|
76
|
+
|
|
77
|
+
### TSX
|
|
78
|
+
|
|
79
|
+
#### Don't
|
|
80
|
+
|
|
81
|
+
```tsx
|
|
82
|
+
document.cookie = "token=" + token + "; path=/";
|
|
83
|
+
```
|
|
84
|
+
|
|
85
|
+
#### Do
|
|
86
|
+
|
|
87
|
+
```tsx
|
|
88
|
+
document.cookie = "theme=dark; path=/";
|
|
89
|
+
```
|
|
@@ -0,0 +1,31 @@
|
|
|
1
|
+
# sec-js/no-dynamic-script-src — cases
|
|
2
|
+
|
|
3
|
+
### case: an iframe
|
|
4
|
+
|
|
5
|
+
```js
|
|
6
|
+
iframe.setAttribute("src", url);
|
|
7
|
+
```
|
|
8
|
+
|
|
9
|
+
```expect
|
|
10
|
+
1:1 sec-js/no-dynamic-script-src
|
|
11
|
+
```
|
|
12
|
+
|
|
13
|
+
### case: an image is not code
|
|
14
|
+
|
|
15
|
+
```js
|
|
16
|
+
img.src = url;
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
```expect
|
|
20
|
+
(none)
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### case: a script variable
|
|
24
|
+
|
|
25
|
+
```js
|
|
26
|
+
tag.src = src;
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
```expect
|
|
30
|
+
(none)
|
|
31
|
+
```
|