arelle-release 2.17.1__py3-none-any.whl → 2.37.71__py3-none-any.whl

arelle/plugin/validate/{HMRC → UK}/__init__.py

@@ -1,155 +1,145 @@
-'''
+"""
 See COPYRIGHT.md for copyright information.
 
 References:
-  https://xbrl.frc.org.uk (taxonomies, filing requirements, consistency checks)
-  https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/434597/joint-filing-validation-checks.pdf
-  https://assets.publishing.service.gov.uk/government/uploads/system/uploads/attachment_data/file/893127/Joint-Filing-Common-Validation-Checks-v4.0.pdf
 
-  Style Guide: https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/434588/xbrl-style-guide.pdf
-
-'''
+- <https://xbrl.frc.org.uk> (taxonomies, filing requirements, consistency checks)
+- [Joint Filing Common Validation Checks](https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/434597/joint-filing-validation-checks.pdf)
+- [HMRC CT Inline XBRL Style Guide](https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/434588/xbrl-style-guide.pdf)
+"""
 import os
-from math import isnan
 from arelle import ModelDocument, XmlUtil
 from arelle.ModelValue import qname, dateTime, DATE
-from arelle.ValidateXbrlCalcs import inferredDecimals, rangeValue, insignificantDigits
+from arelle.ValidateDuplicateFacts import getDuplicateFactSets
+from arelle.ValidateXbrlCalcs import insignificantDigits
 from arelle.Version import authorLabel, copyrightLabel
 from arelle.XbrlConst import xbrli, qnXbrliXbrl
 import regex as re
+import tinycss2.ast
 from collections import defaultdict
 
+from .ValidateUK import ValidateUK
+
 FRC_URL_DOMAIN = "http://xbrl.frc.org.uk/"
 memNameNumPattern = re.compile(r"^([A-Za-z-]+)([0-9]+)$")
 compTxmyNamespacePattern = re.compile(r"http://www.govtalk.gov.uk/uk/fr/tax/uk-hmrc-ct/[0-9-]{10}")
-# capture background-image or list-style-image with URL function
-styleImgUrlPattern = re.compile(r"[a-z]+-image:\s*url[(][^)]+[)]")
+IMG_URL_CSS_PROPERTIES = frozenset([
+    "background", "background-image",
+    "border-image", "border-image-source",
+    "clip-path",
+    "content",
+    "cursor",
+    "filter",
+    "list-style", "list-style-image",
+    "mask-border",
+    "mask", "mask-image",
+    "shape-outside",
+])
 EMPTYDICT = {}
 _6_APR_2008 = dateTime("2008-04-06", type=DATE)
 
-commonMandatoryItems = {
-    "EntityCurrentLegalOrRegisteredName", "StartDateForPeriodCoveredByReport",
-    "EndDateForPeriodCoveredByReport", "BalanceSheetDate"}
+GENERIC_DIMENSION_VALIDATIONS = {
+    # "LocalName": (range of numbers if any, first item name, 2nd choice item name if any)
+    "SpecificDiscontinuedOperation": (1, 8, "DescriptionDiscontinuedOperationOrNon-currentAssetsOrDisposalGroupHeldForSale"),
+    "SpecificNon-currentAssetsDisposalGroupHeldForSale": (1, 8, "DescriptionDiscontinuedOperationOrNon-currentAssetsOrDisposalGroupHeldForSale"),
+    "Chairman": ("NameEntityOfficer",),
+    "ChiefExecutive": ("NameEntityOfficer",),
+    "ChairmanChiefExecutive": ("NameEntityOfficer",),
+    "SeniorPartnerLimitedLiabilityPartnership": ("NameEntityOfficer",),
+    "CorporateTrustee": (1, 3, "NameEntityOfficer"),
+    "DirectorOfCorporateTrustee": ("NameEntityOfficer",),
+    "CustodianTrustee": ("NameEntityOfficer",),
+    "Trustee": (1, 20, "NameEntityOfficer",),
+    "CompanySecretary": (1, 2, "NameEntityOfficer",),
+    "CompanySecretaryDirector": (1, 2, "NameEntityOfficer",),
+    "Director": (1, 40, "NameEntityOfficer",),
+    "PartnerLLP": (1, 20, "NameEntityOfficer"),
+    "ReportableOperatingSegment": (1, 20, "NameIndividualSegment"),
+    "ProductService": (1, 12, "NameIndividualSegment"),
+    "MajorCustomer": (1, 12, "NameIndividualSegment"),
+    "SpecificBusinessCombination": (1, 10, "NameAcquiredEntity"),
+    "ConsumableBiologicalAssetClass": (1, 5, "NameOrDescriptionBiologicalAssetClass"),
+    "BearerBiologicalAssetClass": (1, 5, "NameOrDescriptionBiologicalAssetClass"),
+    "Subsidiary": (1, 200, "NameSubsidiary"),
+    "Associate": (1, 50, "NameAssociate"),
+    "JointVenture": (1, 50, "NameJointVenture"),
+    "UnconsolidatedStructuredEntity": (1, 5, "NameUnconsolidatedStructuredEntity"),
+    "IntermediateParent": (1, 5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
+    "EntityWithJointControlOrSignificantInfluence": (1, 5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
+    "OtherGroupMember": (1, 8, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
+    "KeyManagementIndividualGroup": (1, 5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
+    "CloseFamilyMember": (1, 5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
+    "EntityControlledByKeyManagementPersonnel": (1, 5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
+    "OtherRelatedPartyRelationshipType1ComponentTotalRelatedParties": ("NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag",),
+    "OtherRelatedPartyRelationshipType2ComponentTotalRelatedParties": ("NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag",),
+    "OrdinaryShareClass": (1, 5, "DescriptionShareType"),
+    "PreferenceShareClass": (1, 5, "DescriptionShareType"),
+    "DeferredShareClass": (1, 5, "DescriptionShareType"),
+    "OtherShareClass": (1, 5, "DescriptionShareType"),
+    "Share-basedArrangement": (1, 8, "NameShare-basedPaymentArrangement"),
+    "Grant": (1, 10, "NameOrDescriptionGrantUnderShare-basedPaymentArrangement"),
+    "PensionPlan": (1, 6, "NameDefinedContributionPlan", "NameDefinedBenefitPlan"),
+    "Post-employmentMedicalPlan": (1, 2, "NameDefinedContributionPlan", "NameDefinedBenefitPlan"),
+    "OtherPost-employmentBenefitPlan": (1, 2, "NameDefinedContributionPlan", "NameDefinedBenefitPlan"),
+    "OtherContractType": (1, 2, "DescriptionOtherContractType"),
+    "OtherDurationType": (1, 2, "DescriptionOtherContractDurationType"),
+    "OtherChannelType": (1, 2, "DescriptionOtherSalesChannelType"),
+    "SalesChannel": (1, 2, "DescriptionOtherSalesChannelType"),
+}
+
+COMMON_MANDATORY_ITEMS = {
+    "AverageNumberEmployeesDuringPeriod", "EntityCurrentLegalOrRegisteredName", "StartDateForPeriodCoveredByReport",
+    "EndDateForPeriodCoveredByReport", "BalanceSheetDate"
+}
 
-COMMON_MANDATORY_FRS_ITEMS = commonMandatoryItems | {
+COMMON_MANDATORY_FRS_ITEMS = COMMON_MANDATORY_ITEMS | {
     "DateAuthorisationFinancialStatementsForIssue", "DirectorSigningFinancialStatements",
     "EntityDormantTruefalse", "EntityTradingStatus",
     "AccountingStandardsApplied", "AccountsStatusAuditedOrUnaudited",
     "LegalFormEntity", "DescriptionPrincipalActivities"
 }
-mandatoryItems = {
-    "ukGAAP": commonMandatoryItems | {
+
+MANDATORY_ITEMS = {
+    "ukGAAP": COMMON_MANDATORY_ITEMS | {
         "DateApprovalAccounts", "NameDirectorSigningAccounts", "EntityDormant", "EntityTrading",
         "DateSigningDirectorsReport", "DirectorSigningReport"
         },
-    "charities": commonMandatoryItems | {
+    "charities": COMMON_MANDATORY_ITEMS | {
         "DateAuthorisationFinancialStatementsForIssue", "DirectorSigningFinancialStatements",
         "EntityDormantTruefalse", "EntityTradingStatus",
-        "AccountingStandardsApplied", "AccountingStandardsApplied"},
-    "ukIFRS": commonMandatoryItems | {
+        "AccountingStandardsApplied", "AccountsStatusAuditedOrUnaudited"},
+    "ukIFRS": COMMON_MANDATORY_ITEMS | {
         "DateAuthorisationFinancialStatementsForIssue", "ExplanationOfBodyOfAuthorisation",
         "EntityDormant", "EntityTrading", "DateSigningDirectorsReport", "DirectorSigningReport"},
     "FRS": COMMON_MANDATORY_FRS_ITEMS | {"AccountsTypeFullOrAbbreviated"},
     "FRS-2022": COMMON_MANDATORY_FRS_ITEMS | {"AccountsType"}
 }
 
-genericDimensionValidation = {
-    # "taxonomyType": { "LocalName": (range of numbers if any, first item name, 2nd choice item name if any)
-    "ukGAAP": {"Acquisition": (1,10,"NameAcquisition"),
-        "Associate": (1,30,"NameAssociate"),
-        "BusinessSegment": (1,30,"NameBusinessSegment", "DescriptionBusinessSegment"),
-        "Disposal": (1,10,"NameOrDescriptionDisposal"),
-        "Joint-venture": (1,30,"NameJoint-venture"),
-        "OtherInvestment": (1,5,"NameOtherParticipatingInterestOrInvestment",    "DescriptionOtherParticipatingInterestOrInvestment"),
-        "OtherParticipatingInterest1": (1,5,"NameOtherParticipatingInterestOrInvestment",    "DescriptionOtherParticipatingInterestOrInvestment"),
-        "PensionScheme": (1,8,"NameDefinedContributionScheme","DescriptionContributionScheme"),
-        "Post-employmentMedicalScheme": (1,4,"NameDefinedBenefitScheme"    "DescriptionDefinedBenefitScheme"),
-        "Share-basedScheme": (1,8,"NameShare-basedArrangement","DescriptionShare-basedArrangement"),
-        "Subsidiary": (1,30, "NameSubsidiary"),
-        "Quasi-subsidiary": (1,10, "NameSubsidiary")},
-    "ukIFRS":    {"Associate": (1,50, "NameAssociate"),
-        "Joint-venture": (1,50, "NameJoint-venture"),
-        "MajorCustomer": (1,12,"NameIndividualSegmentMember"),
-        "PensionScheme": (1,10,"NameDefinedContributionScheme","DescriptionContributionScheme"),
-        "Post-employmentMedicalScheme": (1,4, "NameDefinedBenefitScheme", "DescriptionDefinedBenefitScheme"),
-        "ProductService": (1,12,"NameIndividualSegmentMember"),
-        "ReportableOperatingSegment": (1,20,"NameIndividualSegmentMember"),
-        "Share-basedScheme": (1,8,"NameShare-basedPaymentArrangement"),
-        "SpecificBusinessCombination": (1,10,"NameOfAcquiree"),
-        "SpecificDiscontinuedOperation": (1,8,"DescriptionNon-currentAssetOrDisposalGroup",     "DescriptionFactsCircumstancesSaleOrExpectedDisposal"),
-        "SpecificDisposalGroupHeldForSale": (1,8,"DescriptionNon-currentAssetOrDisposalGroup",    "DescriptionFactsCircumstancesSaleOrExpectedDisposal"),
-        "Subsidiary": (1,50,"NameSubsidiary")},
-    "business":    {"Director": (1,40,"NameEntityOfficer"),
-        "Chairman": ("NameEntityOfficer",),
-        "ChiefExecutive": ("NameEntityOfficer",),
-        "ChairmanChiefExecutive":  ("NameEntityOfficer",),
-        "ChiefPartnerLimitedLiabilityPartnership": ("NameEntityOfficer",),
-        "CompanySecretary": ("NameEntityOfficer",),
-        "CompanySecretaryDirector": ("NameEntityOfficer",),
-        "OrdinaryShareClass": (1,5,"DescriptionShareType"),
-        "PartnerLLP": (1,20,"NameEntityOfficer"),
-        "PreferenceShareClass": (1,5,"DescriptionShareType"),
-        "JointAgent": (1,3,"NameThirdPartyAgent"),
-        "PrincipalAgent": ("NameThirdPartyAgent",),
-        "Chairman": ("NameEntityOfficer",),
-        "ChiefExecutive": ("NameEntityOfficer",),
-        "ChairmanChiefExecutive": ("NameEntityOfficer",),
-        "SeniorPartnerLimitedLiabilityPartnership": ("NameEntityOfficer",),
-        "CompanySecretary1": ("NameEntityOfficer",),
-        "CompanySecretary2": ("NameEntityOfficer",),
-        "CompanySecretaryDirector1": ("NameEntityOfficer",),
-        "CompanySecretaryDirector2": ("NameEntityOfficer",),
-        "Director": (1,40,"NameEntityOfficer"),
-        "PartnerLLP": (1,20,"NameEntityOfficer"),
-        "OrdinaryShareClass": (1,5, "DescriptionShareType"),
-        "PreferenceShareClass": (1,5, "DescriptionShareType"),
-        "DeferredShareClass": (1,5, "DescriptionShareType"),
-        "OtherShareClass": (1,4, "DescriptionShareType")},
-    "charities":    {"Trustee": (1,40,"NameTrustee"),
-        "ChairTrustees": ("NameTrustee",),
-        "ChiefExecutiveCharity": ("NameTrustee",)},
-    "dpl":    {"CombinedCross-sectorActivities": (1,4, "DescriptionActivity"),
-        "OtherSpecificActivity": (1,5, "DescriptionActivity")},
-    "FRS":    {"SpecificDiscontinuedOperation": (1,8,"DescriptionDiscontinuedOperationOrNon-currentAssetsOrDisposalGroupHeldForSale"),
-        "SpecificNon-currentAssetsDisposalGroupHeldForSale": (1,8,"DescriptionDiscontinuedOperationOrNon-currentAssetsOrDisposalGroupHeldForSale"),
-        "ReportableOperatingSegment": (1,20,"NameIndividualSegment"),
-        "ProductService": (1,12, "NameIndividualSegment"),
-        "MajorCustomer": (1,12, "NameIndividualSegment"),
-        "SpecificBusinessCombination": (1,10, "NameAcquiredEntity"),
-        "ConsumableBiologicalAssetClass": (1,5, "NameOrDescriptionBiologicalAssetClass"),
-        "BearerBiologicalAssetClass": (1,5, "NameOrDescriptionBiologicalAssetClass"),
-        "Subsidiary": (1,50, "NameSubsidiary"),
-        "Associate": (1,50, "NameAssociate"),
-        "JointVenture": (1,50, "NameJointVenture"),
-        "UnconsolidatedStructuredEntity": (1,5, "NameUnconsolidatedStructuredEntity"),
-        "IntermediateParent": (1,5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
-        "EntityWithJointControlOrSignificantInfluence": (1,5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
-        "OtherGroupMember": (1,8, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
-        "KeyManagementIndividualGroup": (1,5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
-        "CloseFamilyMember": (1,5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
-        "EntityControlledByKeyManagementPersonnel": (1,5, "NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag"),
-        "OtherRelatedPartyRelationshipType1ComponentTotalRelatedParties": ("NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag",),
-        "OtherRelatedPartyRelationshipType2ComponentTotalRelatedParties": ("NameOrDescriptionRelatedPartyIfNotDefinedByAnotherTag",),
-        "Share-basedArrangement": (1,8, "NameShare-basedPaymentArrangement"),
-        "Grant": (1,10, "NameOrDescriptionGrantUnderShare-basedPaymentArrangement"),
-        "PensionPlan": (1,6, "NameDefinedContributionPlan", "NameDefinedBenefitPlan"),
-        "Post-employmentMedicalPlan": (1,2, "NameDefinedContributionPlan", "NameDefinedBenefitPlan"),
-        "OtherPost-employmentBenefitPlan": (1,2, "NameDefinedContributionPlan", "NameDefinedBenefitPlan")}}
-
-allowedImgMimeTypes = (
+MUST_HAVE_ONE_ITEM = {
+    "charities": {
+        "CharityRegistrationNumberEnglandWales", "CharityRegistrationNumberScotland",
+        "CharityRegistrationNumberNorthernIreland",
+    }
+}
+
+ALLOWED_IMG_MIME_TYPES = (
         "data:image/gif;base64",
         "data:image/jpeg;base64", "data:image/jpg;base64", # note both jpg and jpeg are in use
-        "data:image/png;base64")
+        "data:image/png;base64"
+)
+
 
 def dislosureSystemTypes(disclosureSystem, *args, **kwargs):
     # return ((disclosure system name, variable name), ...)
-    return (("HMRC", "HMRCplugin"),)
+    return (("HMRC", "UKplugin"),)
+
 
 def disclosureSystemConfigURL(disclosureSystem, *args, **kwargs):
     return os.path.join(os.path.dirname(__file__), "config.xml")
 
+
 def validateXbrlStart(val, parameters=None, *args, **kwargs):
-    val.validateHMRCplugin = val.validateDisclosureSystem and getattr(val.disclosureSystem, "HMRCplugin", False)
+    val.validateHMRCplugin = val.validateDisclosureSystem and getattr(val.disclosureSystem, "UKplugin", False)
     if not (val.validateHMRCplugin) or not val.modelXbrl.modelDocument:
         return
 
@@ -166,15 +156,12 @@ def validateXbrlStart(val, parameters=None, *args, **kwargs):
         val.isAccounts = not val.isComputation
 
     val.txmyType = None
-    for doc in val.modelXbrl.modelDocument.referencesDocument:
-        ns = doc.targetNamespace
-        if not ns:
-            continue
-        if ns.startswith("http://www.xbrl.org/uk/char/"):
+    for ns in val.modelXbrl.prefixedNamespaces.values():
+        if ns.startswith("http://www.xbrl.org/uk/char/") or ns.startswith("http://xbrl.frc.org.uk/char/"):
             val.txmyType = "charities"
         elif ns.startswith("http://www.xbrl.org/uk/gaap/"):
             val.txmyType = "ukGAAP"
-        elif ns.startswith("http://www.xbrl.org/uk/ifrs/"):
+        elif ns.startswith("http://www.xbrl.org/uk/ifrs/") or ns.startswith("https://xbrl.frc.org.uk/IFRS/"):
             val.txmyType = "ukIFRS"
         elif ns.startswith(FRC_URL_DOMAIN):
             val.txmyType = "FRS"
@@ -187,7 +174,7 @@ def validateXbrlStart(val, parameters=None, *args, **kwargs):
         break
     if val.txmyType:
         val.modelXbrl.debug("debug",
-                            "HMRC taxonomy type %(taxonomyType)s",
+                            "UK taxonomy type %(taxonomyType)s",
                             modelObject=val.modelXbrl, taxonomyType=val.txmyType)
     else:
         val.modelXbrl.error("HMRC.TBD",
@@ -214,7 +201,7 @@ def validateXbrlFinally(val, *args, **kwargs):
             scheme, identifier = c1.entityIdentifier
             if scheme == "http://www.companieshouse.gov.uk/":
                 companyReferenceNumberContexts[identifier].append(c1.id)
-
+        atLeastOneFacts = {}
         uniqueFacts = {}  # key = (qname, context hash, unit hash, lang)
         mandatoryFacts = {}
         mandatoryGDV = defaultdict(set)
@@ -227,7 +214,7 @@ def validateXbrlFinally(val, *args, **kwargs):
         contextsWithScenario = []
         for cntx in contextsUsed:
             for dim in cntx.qnameDims.values():
-                if dim.isExplicit:
+                if dim.isExplicit and dim.memberQname is not None:
                     _memName = dim.memberQname.localName
                     m = memNameNumPattern.match(_memName)
                     if m:
@@ -236,10 +223,7 @@ def validateXbrlFinally(val, *args, **kwargs):
                     else:
                         l = _memName
                         n = None
-                    for _gdvType in (val.txmyType, "business"):
-                        gdv = genericDimensionValidation.get(_gdvType,EMPTYDICT).get(l)
-                        if gdv: # take first match
-                            break
+                    gdv = GENERIC_DIMENSION_VALIDATIONS.get(l)
                     if (gdv and (n is None or
                                  (isinstance(gdv[0],int) and isinstance(gdv[1],int) and n >= gdv[0] and n <= gdv[1]))):
                         gdvFacts = [f for f in gdv if isinstance(f,str)]
@@ -265,8 +249,10 @@ def validateXbrlFinally(val, *args, **kwargs):
                 if (f.isNil or getattr(f,"xValid", 0) >= 4) and cntx is not None and f.concept is not None and f.concept.type is not None:
                     factNamespaceURI = f.qname.namespaceURI
                     factLocalName = f.qname.localName
-                    if factLocalName in mandatoryItems[val.txmyType]:
+                    if factLocalName in MANDATORY_ITEMS[val.txmyType]:
                         mandatoryFacts[factLocalName] = f
+                    if val.txmyType in MUST_HAVE_ONE_ITEM and factLocalName in MUST_HAVE_ONE_ITEM[val.txmyType]:
+                        atLeastOneFacts[factLocalName] = f
                     if factLocalName == "UKCompaniesHouseRegisteredNumber" and val.isAccounts:
                         if hasCompaniesHouseContext:
                             mandatoryFacts[factLocalName] = f
@@ -304,7 +290,7 @@ def validateXbrlFinally(val, *args, **kwargs):
                                     except (ValueError,TypeError):
                                         modelXbrl.error("HMRC.SG.4.5",
                                             _("Fact %(fact)s of context %(contextID)s decimals %(decimals)s value %(value)s causes Value Error exception."),
-                                            modelObject=f1, fact=f1.qname, contextID=f1.contextID, decimals=f1.decimals, value=f1.value)
+                                            modelObject=f, fact=f.qname, contextID=f.contextID, decimals=f.decimals, value=f.value)
                         except AttributeError:
                             pass  # if not validated it should have failed with a schema error
 
@@ -340,13 +326,17 @@ def validateXbrlFinally(val, *args, **kwargs):
         checkFacts(modelXbrl.facts)
 
         if val.isAccounts:
-            _missingItems = mandatoryItems[val.txmyType] - mandatoryFacts.keys()
+            _missingItems = MANDATORY_ITEMS[val.txmyType] - mandatoryFacts.keys()
             if hasCompaniesHouseContext and "UKCompaniesHouseRegisteredNumber" not in mandatoryFacts:
                 _missingItems.add("UKCompaniesHouseRegisteredNumber")
             if _missingItems:
                 modelXbrl.error("JFCVC.3312",
                     _("Facts are MANDATORY: %(missingItems)s"),
                     modelObject=modelXbrl, missingItems=", ".join(sorted(_missingItems)))
+            if not atLeastOneFacts and val.txmyType in MUST_HAVE_ONE_ITEM:
+                modelXbrl.error("JFCVC.3312.atLeastOne",
+                                _("At least one of the facts is MANDATORY: %(missingItems)s"),
+                                modelObject=modelXbrl, missingItems=", ".join(sorted(MUST_HAVE_ONE_ITEM[val.txmyType])))
 
             ''' removed with JFCVC v4.0 2020-06-09
             f = mandatoryFacts.get("StartDateForPeriodCoveredByReport")
@@ -364,62 +354,12 @@ def validateXbrlFinally(val, *args, **kwargs):
                     _("Generic dimension members have no associated name or description item, member names (name or description item): %(memberNames)s"),
                     modelObject=modelXbrl, memberNames=", ".join(sorted(memLocalNamesMissing)))
 
-
-
-        aspectEqualFacts = defaultdict(dict) # dict [(qname,lang)] of dict(cntx,unit) of [fact, fact]
-        for hashEquivalentFacts in factForConceptContextUnitHash.values():
-            if len(hashEquivalentFacts) > 1:
-                for f in hashEquivalentFacts: # check for hash collision by value checks on context and unit
-                    if getattr(f,"xValid", 0) >= 4:
-                        cuDict = aspectEqualFacts[(f.qname,
-                                                   (f.xmlLang or "").lower() if f.concept.type.isWgnStringFactType else None)]
-                        _matched = False
-                        for (_cntx,_unit),fList in cuDict.items():
-                            if (((_cntx is None and f.context is None) or (f.context is not None and f.context.isEqualTo(_cntx))) and
-                                ((_unit is None and f.unit is None) or (f.unit is not None and f.unit.isEqualTo(_unit)))):
-                                _matched = True
-                                fList.append(f)
-                                break
-                        if not _matched:
-                            cuDict[(f.context,f.unit)] = [f]
-                decVals = {}
-                for cuDict in aspectEqualFacts.values(): # dups by qname, lang
-                    for fList in cuDict.values():  # dups by equal-context equal-unit
-                        if len(fList) > 1:
-                            f0 = fList[0]
-                            if f0.concept.isNumeric:
-                                if any(f.isNil for f in fList):
-                                    _inConsistent = not all(f.isNil for f in fList)
-                                else: # not all have same decimals
-                                    _d = inferredDecimals(f0)
-                                    _v = f0.xValue
-                                    _inConsistent = isnan(_v) # NaN is incomparable, always makes dups inconsistent
-                                    decVals[_d] = _v
-                                    aMax, bMin, _inclA, _inclB = rangeValue(_v, _d)
-                                    for f in fList[1:]:
-                                        _d = inferredDecimals(f)
-                                        _v = f.xValue
-                                        if isnan(_v):
-                                            _inConsistent = True
-                                            break
-                                        if _d in decVals:
-                                            _inConsistent |= _v != decVals[_d]
-                                        else:
-                                            decVals[_d] = _v
-                                        a, b, _inclA, _inclB = rangeValue(_v, _d)
-                                        if a > aMax: aMax = a
-                                        if b < bMin: bMin = b
-                                    if not _inConsistent:
-                                        _inConsistent = (bMin < aMax)
-                                    decVals.clear()
-                            else:
-                                _inConsistent = any(not f.isVEqualTo(f0) for f in fList[1:])
-                            if _inConsistent:
-                                modelXbrl.error("JFCVC.3314",
-                                    "Inconsistent duplicate fact values %(fact)s: %(values)s.",
-                                    modelObject=fList, fact=f0.qname, contextID=f0.contextID, values=", ".join(f.value for f in fList))
-                aspectEqualFacts.clear()
-        del factForConceptContextUnitHash, aspectEqualFacts
+    for duplicateFactSet in getDuplicateFactSets(modelXbrl.facts, includeSingles=False):
+        if duplicateFactSet.areAnyInconsistent:
+            f0 = duplicateFactSet.facts[0]
+            modelXbrl.error("JFCVC.3314",
+                "Inconsistent duplicate fact values %(fact)s: %(values)s.",
+                modelObject=duplicateFactSet.facts, fact=f0.qname, values=", ".join(f'"{f.value}"' for f in duplicateFactSet))
 
     if modelXbrl.modelDocument.type == ModelDocument.Type.INLINEXBRL:
         rootElt = modelXbrl.modelDocument.xmlRootElement
@@ -439,24 +379,86 @@ def validateXbrlFinally(val, *args, **kwargs):
                     modelXbrl.error("HMRC.SG.3.3",
                         _("Element %(localName)s javascript %(javascript)s is disallowed."),
                         modelObject=elt, localName=localName, javascript=attrValue[:64])
-                if localName == "img" and not any(attrValue.startswith(m) for m in allowedImgMimeTypes):
+                if localName == "img" and not any(attrValue.startswith(m) for m in ALLOWED_IMG_MIME_TYPES):
                     modelXbrl.error("HMRC.SG.3.8",
                         _("Image scope must be base-64 encoded string (starting with data:image/*;base64), *=gif, jpeg or png.  src disallowed: %(src)s."),
                         modelObject=elt, src=attrValue[:128])
         for elt in rootElt.iterdescendants(tag="{http://www.w3.org/1999/xhtml}style"):
-            if elt.text and styleImgUrlPattern.match(elt.text):
-                modelXbrl.error("HMRC.SG.3.8",
-                    _("Style element has disallowed image reference: %(styleImage)s."),
-                    modelObject=elt, styleImage=styleImgUrlPattern.match(elt.text).group(1))
+            _validateStyleElement(elt, modelXbrl)
         for elt in rootElt.xpath("//xhtml:*[@style]", namespaces={"xhtml": "http://www.w3.org/1999/xhtml"}):
-            for match in styleImgUrlPattern.findall(elt.get("style")):
-                modelXbrl.error("HMRC.SG.3.8",
-                    _("Element %(elt)s style attribute has disallowed image reference: %(styleImage)s."),
-                    modelObject=elt, elt=elt.tag.rpartition("}")[2], styleImage=match)
+            _validateStyleAttribute(elt, modelXbrl)
+
+    hmrc = ValidateUK(modelXbrl)
+    if val.txmyType != "charities":
+        hmrc.validate()
+    elif val.txmyType == "charities":
+        hmrc.validateCharities()
 
     modelXbrl.profileActivity(_statusMsg, minTimeToShow=0.0)
     modelXbrl.modelManager.showStatus(None)
 
+
+def _validateStyleElement(elt, modelXbrl):
+    cssElements = tinycss2.parse_stylesheet(elt.text)
+    for css_element in cssElements:
+        if isinstance(css_element, tinycss2.ast.QualifiedRule):
+            cssProperty = None
+            for elem in css_element.content:
+                if isinstance(elem, tinycss2.ast.IdentToken):
+                    cssProperty = elem.lower_value
+                elif _isExternalImageUrl(cssProperty, elem):
+                        modelXbrl.error(
+                            "HMRC.SG.3.8",
+                            _("Style element has disallowed image reference: %(cssSelectors)s, %(styleImage)s."),
+                            modelObject=elt,
+                            cssSelectors=tinycss2.serialize(css_element.prelude).strip(),
+                            styleImage=elem.arguments[0].value,
+                        )
+                        return
+        elif isinstance(css_element, tinycss2.ast.ParseError):
+            modelXbrl.warning(
+                "ix.CssParsingError",
+                _("The style element contains erroneous CSS: %(parseError)s"),
+                modelObject=elt,
+                parseError=css_element.message,
+            )
+            return
+
+
+def _validateStyleAttribute(elt, modelXbrl):
+    styleValue = elt.get("style", "")
+    for declaration in tinycss2.parse_blocks_contents(styleValue):
+        if isinstance(declaration, tinycss2.ast.Declaration):
+            for val in declaration.value:
+                if _isExternalImageUrl(declaration.lower_name, val):
+                    modelXbrl.error(
+                        "HMRC.SG.3.8",
+                        _("Element %(elt)s style attribute has disallowed image reference: %(styleImage)s."),
+                        modelObject=elt,
+                        elt=elt.tag.rpartition("}")[2],
+                        styleImage=val.arguments[0].value,
+                    )
+                    return
+        elif isinstance(declaration, tinycss2.ast.ParseError):
+            modelXbrl.warning(
+                "ix.CssParsingError",
+                _("The style attribute contains erroneous CSS declaration \"%(styleContent)s\": %(parseError)s"),
+                modelObject=elt,
+                parseError=declaration.message,
+                styleContent=styleValue,
+            )
+            return
+
+
+def _isExternalImageUrl(cssProperty, elem):
+    return (
+        cssProperty in IMG_URL_CSS_PROPERTIES and
+        isinstance(elem, tinycss2.ast.FunctionBlock) and
+        elem.lower_name == "url" and
+        any(not arg.value.startswith("data:") for arg in elem.arguments)
+    )
+
+
 class GDV:
     def __init__(self, fact, altFact, memLocalName):
         self.fact = fact
@@ -479,9 +481,13 @@ class GDV:
     def __ne__(self,other):
         return not self.__eq__(other)
 
+
 __pluginInfo__ = {
     # Do not use _( ) in pluginInfo itself (it is applied later, after loading
-    'name': 'Validate HMRC',
+    'name': 'Validate UK',
+    "aliases": [
+        "validate/hmrc",
+    ],
     'version': '4.0',
     'description': '''HMRC Validation. JFCVC v4.0 2020-06-09.  Style guide v2.2''',
     'license': 'Apache-2',

arelle/plugin/validate/{HMRC → UK}/config.xml

@@ -32,4 +32,4 @@
      />
 
 
-</DisclosureSystems>
+</DisclosureSystems>

arelle/plugin/xbrlDB/SqlDb.py

@@ -36,7 +36,7 @@ try:
     mysqlProgrammingError = pymysql.ProgrammingError
     mysqlInterfaceError = pymysql.InterfaceError
     mysqlInternalError = pymysql.InternalError
-except ImportError:
+except (ImportError, OSError):
     try :
         import MySQLdb  # LGPL License and used on GAE, Python 2.7 only
         hasMySql = True

arelle/plugin/xbrlDB/XbrlOpenSqlDB.py

@@ -36,7 +36,7 @@ windows
 
 examples of arguments:
    store from instance into DB: -f "my_traditional_instance.xbrl" -v --plugins "xbrlDB" --store-to-XBRL-DB "localhost,8084,userid,passwd,open_db,90,pgOpenDB"
-   store from OIM excel instance into DB: -f "my_oim_instance.xlsx" -v --plugins "loadFromOIM.py|xbrlDB" --store-to-XBRL-DB "localhost,8084,userid,passwd,open_db,90,pgOpenDB"
+   store from OIM excel instance into DB: -f "my_oim_instance.xlsx" -v --plugins "xbrlDB" --store-to-XBRL-DB "localhost,8084,userid,passwd,open_db,90,pgOpenDB"
    load from DB save into instance: -f "output_instance.xbrl" --plugins "xbrlDB" --load-from-XBRL-DB "localhost,8084,userid,passwd,open_db,90,pgOpenDB,loadInstanceId=214147"
 '''
 
@@ -53,8 +53,8 @@ from arelle.PluginManager import pluginClassMethods
 from arelle.PrototypeInstanceObject import DimValuePrototype
 from arelle.PythonUtil import flattenSequence
 from arelle.ValidateXbrlCalcs import roundValue
-from arelle.XmlValidate import collapseWhitespacePattern, UNVALIDATED, VALID
-from arelle.XmlUtil import elementChildSequence, xmlstring, addQnameValue, addChild
+from arelle.XmlValidate import UNVALIDATED, VALID
+from arelle.XmlUtil import elementChildSequence, xmlstring, addQnameValue, addChild, collapseWhitespace
 from arelle import XbrlConst, ValidateXbrlDimensions
 from arelle.UrlUtil import authority, ensureUrl
 from .SqlDb import XPDBException, isSqlConnection, SqlDbConnection
@@ -1092,7 +1092,7 @@ class XbrlSqlDatabaseConnection(SqlDbConnection):
                                   fact.decimals,
                                   roundValue(fact.value, fact.precision, fact.decimals) if fact.isNumeric and not fact.isNil else None,
                                   fact.xmlLang if not fact.isNumeric and not fact.isNil else None,
-                                  collapseWhitespacePattern.sub(' ', fact.value.strip()) if fact.value is not None else None,
+                                  collapseWhitespace(value) if fact.value is not None else None,
                                   fact.value,
                                   ))
             table = self.getTable('fact', 'fact_pk',
@@ -1149,7 +1149,7 @@ class XbrlSqlDatabaseConnection(SqlDbConnection):
                                      None if isinstance(toObj, ModelFact) else toObj.role,
                                      self.factId[(self.documentIds[toObj.modelDocument], elementChildSequence(toObj))] if isinstance(toObj, ModelFact) else None,
                                      None if isinstance(toObj, ModelFact) else toObj.xmlLang,
-                                     None if isinstance(toObj, ModelFact) else collapseWhitespacePattern.sub(' ', xmlstring(toObj, stripXmlns=True, contentsOnly=True, includeText=True)),
+                                     None if isinstance(toObj, ModelFact) else collapseWhitespace(xmlstring(toObj, stripXmlns=True, contentsOnly=True, includeText=True)),
                                      None if isinstance(toObj, ModelFact) else xmlstring(toObj, stripXmlns=True, contentsOnly=True, includeText=True))
                                     for fact in self.modelXbrl.factsInInstance
                                     for footnoteRel in footnotesRelationshipSet.fromModelObject(fact)

arelle/plugin/xbrlDB/XbrlPublicPostgresDB.py

@@ -21,7 +21,7 @@ Arelle uses 9.1, via Python DB API 2.0 interface, using the pg8000 library.
 Information for the 'official' XBRL US-maintained database (this schema, containing SEC filings):
     Database Name: edgar_db
     Database engine: Postgres version 8.4
-    \Host: public.xbrl.us
+    Host: public.xbrl.us
     Port: 5432
 
 to use from command line:

arelle/plugin/xbrlDB/XbrlSemanticJsonDB.py

@@ -215,7 +215,7 @@ class XbrlSemanticJsonDatabaseConnection():
         if isinstance(results, str) and query is not None:
             parser = etree.HTMLParser()
             htmlDoc = etree.parse(io.StringIO(results), parser)
-            body = htmlDoc.find("//body")
+            body = htmlDoc.find(".//body")
             if body is not None:
                 error = "".join(text for text in body.itertext())
             else:

arelle/plugin/xbrlDB/XbrlSemanticRdfDB.py

@@ -282,7 +282,7 @@ class XbrlSemanticRdfDatabaseConnection():
         if isinstance(results, str) and query is not None:
             parser = etree.HTMLParser()
             htmlDoc = etree.parse(io.StringIO(results), parser)
-            body = htmlDoc.find("//body")
+            body = htmlDoc.find(".//body")
             if body is not None:
                 error = "".join(text for text in body.itertext())
             else:

arelle/plugin/xbrlDB/__init__.py

@@ -323,9 +323,12 @@ class LogToDbHandler(logging.Handler):
 
 
 __pluginInfo__ = {
-    'name': 'XBRL Database',
+    'name': 'xbrlDB',
     'version': '0.9',
     'description': "This plug-in implements the XBRL Public Postgres, Abstract Model and DPM Databases.  ",
+    'aliases': [
+        'XBRL Database',
+    ],
     'license': 'Apache-2 (Arelle plug-in), BSD license (pg8000 library)',
     'author': authorLabel,
     'copyright': f'{copyrightLabel} \n'