arelle-release 2.17.1__py3-none-any.whl → 2.37.71__py3-none-any.whl

arelle/ValidateXbrlDTS.py

@@ -2,6 +2,7 @@
 See COPYRIGHT.md for copyright information.
 '''
 from __future__ import annotations
+from enum import Enum, auto
 from typing import TYPE_CHECKING
 from arelle import (ModelDocument, ModelDtsObject, HtmlUtil, UrlUtil, XmlUtil, XbrlUtil, XbrlConst,
                     XmlValidate)
@@ -46,6 +47,39 @@ standard_roles_definitions = {
 standard_roles_other = ("xbrl.5.1.3", ())
 
 inlineDisplayNonePattern = re.compile(r"display\s*:\s*none")
+# lookbehind below is to ignore even numbers of \ before illegal escape character
+illegalXsdPatternEscapeChar = re.compile(r"(?:(?:^|[^\\])(?:\\\\)*)(\\[^nrt\\|.^?*+{}()[\]pPsSiIcCdDwW-])")
+
+class ValidateBaseTaxonomiesMode(Enum):
+    DISCLOSURE_SYSTEM = "disclosureSystem"
+    NONE = "none"
+    ALL = "all"
+
+    @staticmethod
+    def fromName(modeName: str) -> ValidateBaseTaxonomiesMode:
+        for mode in ValidateBaseTaxonomiesMode:
+            if mode.value == modeName:
+                return mode
+        raise ValueError(f"Unknown ValidateBaseTaxonomiesMode: {modeName}")
+
+    @staticmethod
+    def tooltip(enum: ValidateBaseTaxonomiesMode):
+        if enum == ValidateBaseTaxonomiesMode.DISCLOSURE_SYSTEM:
+            return _("Skip validation of base taxonomy files which are known to be valid by the disclosure system")
+        if enum == ValidateBaseTaxonomiesMode.NONE:
+            return _("Skip validation of all base taxonomy files")
+        if enum == ValidateBaseTaxonomiesMode.ALL:
+            return _("Validate all base taxonomy files")
+        raise ValueError(f"Unknown ValidateBaseTaxonomiesMode: {enum}")
+
+    @staticmethod
+    def menu():
+        return {
+            _("Use disclosure system settings"): ValidateBaseTaxonomiesMode.DISCLOSURE_SYSTEM.value,
+            _("Don't validate any base files"): ValidateBaseTaxonomiesMode.NONE.value,
+            _("Validate all base files"): ValidateBaseTaxonomiesMode.ALL.value,
+        }
+
 
 def arcFromConceptQname(arcElement):
     modelRelationship = baseSetRelationship(arcElement)
@@ -259,36 +293,42 @@ def checkDTS(val: ValidateXbrl, modelDocument: ModelDocument.ModelDocument, chec
     # XML validation checks (remove if using validating XML)
     val.extendedElementName = None
     isFilingDocument = False
-    # validate contents of entry point document or its sibling/descendant documents or in report package of entry point
-    if ((modelDocument.uri.startswith(val.modelXbrl.uriDir) or # document uri in same subtree as entry doocument
-         (val.modelXbrl.fileSource.isOpen and modelDocument.filepath.startswith(val.modelXbrl.fileSource.baseurl))) and # document in entry submission's package
-        modelDocument.targetNamespace not in val.disclosureSystem.baseTaxonomyNamespaces and
-        modelDocument.xmlDocument):
-        isFilingDocument = True
-        val.valUsedPrefixes = set()
-        val.schemaRoleTypes = {}
-        val.schemaArcroleTypes = {}
-        val.referencedNamespaces = set()
 
-        val.containsRelationship = False
+    if modelDocument.xmlDocument is not None:
+        isExtensionTaxonomyDoc = _isExtensionTaxonomyDocument(val, modelDocument)
+        if isExtensionTaxonomyDoc or _shouldValidateBaseTaxonomyDoc(val, modelDocument):
+            isFilingDocument = True
+            val.valUsedPrefixes = set()
+            val.schemaRoleTypes = {}
+            val.schemaArcroleTypes = {}
+            val.referencedNamespaces = set()
+
+            val.containsRelationship = False
 
-        checkElements(val, modelDocument, modelDocument.xmlDocument)
+            checkElements(val, modelDocument, modelDocument.xmlDocument)
 
-        if (modelDocument.type == ModelDocument.Type.INLINEXBRL and
-            val.validateGFM and
-            (val.documentTypeEncoding.lower() != 'utf-8' or val.metaContentTypeEncoding.lower() != 'utf-8')):
-            val.modelXbrl.error("GFM.1.10.4",
-                    _("XML declaration encoding %(encoding)s and meta content type encoding %(metaContentTypeEncoding)s must both be utf-8"),
-                    modelXbrl=modelDocument, encoding=val.documentTypeEncoding,
-                    metaContentTypeEncoding=val.metaContentTypeEncoding)
-        if val.validateSBRNL:
-            for pluginXbrlMethod in pluginClassMethods("Validate.SBRNL.DTS.document"):
-                pluginXbrlMethod(val, modelDocument)
-        del val.valUsedPrefixes
-        del val.schemaRoleTypes
-        del val.schemaArcroleTypes
-    for pluginXbrlMethod in pluginClassMethods("Validate.XBRL.DTS.document"):
-        pluginXbrlMethod(val, modelDocument, isFilingDocument)
+            if (modelDocument.type == ModelDocument.Type.INLINEXBRL and
+                val.validateGFM and
+                (val.documentTypeEncoding.lower() != 'utf-8' or val.metaContentTypeEncoding.lower() != 'utf-8')):
+                val.modelXbrl.error("GFM.1.10.4",
+                        _("XML declaration encoding %(encoding)s and meta content type encoding %(metaContentTypeEncoding)s must both be utf-8"),
+                        modelXbrl=modelDocument, encoding=val.documentTypeEncoding,
+                        metaContentTypeEncoding=val.metaContentTypeEncoding)
+            if val.validateSBRNL:
+                for pluginXbrlMethod in pluginClassMethods("Validate.SBRNL.DTS.document"):
+                    pluginXbrlMethod(val, modelDocument)
+            del val.valUsedPrefixes
+            del val.schemaRoleTypes
+            del val.schemaArcroleTypes
+
+        if isExtensionTaxonomyDoc:
+            # While not captured in the hook name, the Validate.XBRL.DTS.document hook has been historically used by
+            # plugins (see EDGAR plugin) to validate extension taxonomies. This worked because Arelle didn't fully
+            # validate base taxonomy documents. Although Arelle now validates all documents, it retains this logic for
+            # the plugin hook to prevent running validation rules intended solely for extension taxonomy documents
+            # against base taxonomy documents.
+            for pluginXbrlMethod in pluginClassMethods("Validate.XBRL.DTS.document"):
+                pluginXbrlMethod(val, modelDocument, isFilingDocument)
 
     val.roleRefURIs = None
     val.arcroleRefURIs = None
@@ -332,7 +372,7 @@ def checkElements(val, modelDocument, parent):
         if isinstance(parent,ModelObject): # element
             if (parent.localName == "meta" and parent.namespaceURI == XbrlConst.xhtml and
                 (parent.get("http-equiv") or "").lower() == "content-type"):
-                val.metaContentTypeEncoding = HtmlUtil.attrValue(parent.get("content"), "charset")
+                val.metaContentTypeEncoding = HtmlUtil.attrValue(parent.get("content"))
         elif isinstance(parent,etree._ElementTree): # documentNode
             val.documentTypeEncoding = modelDocument.documentEncoding # parent.docinfo.encoding
             val.metaContentTypeEncoding = ""
@@ -517,7 +557,14 @@ def checkElements(val, modelDocument, parent):
                         if val.validateSBRNL and localName == "attribute":
                             val.modelXbrl.error("SBR.NL.2.2.11.06",
                                 _('xs:attribute must not be used'), modelObject=elt)
-
+                    if localName == "pattern":
+                        value = elt.get("value")
+                        if value is not None:
+                            illegalEscapes =  illegalXsdPatternEscapeChar.findall(value)
+                            if illegalEscapes:
+                                val.modelXbrl.error("xmlSchema:patternEscapeDisallowed",
+                                    _("%(element)s contains disallowed escape %(escapes)s"),
+                                    modelObject=elt, element=localName, escapes=", ".join(illegalEscapes))
                     if localName == "appinfo":
                         if val.validateSBRNL:
                             if (parent.localName != "annotation" or parent.namespaceURI != XbrlConst.xsd or
@@ -966,6 +1013,10 @@ def checkElements(val, modelDocument, parent):
                                 modelObject=(elt,e2))
                     else:
                         c = XmlUtil.children(elt, '*', '*')
+                        if not c and XmlUtil.innerText(elt, strip = False) == '':
+                            val.modelXbrl.error(ixMsgCode("nonFraction", elt, sect="constraint"),
+                                _("Inline XBRL ix:nonFraction The text node child, if present, MUST be a non-empty string."),
+                                modelObject=elt)
                         if c and (len(c) != 1 or c[0].namespaceURI != elt.namespaceURI or c[0].localName != "nonFraction"):
                             val.modelXbrl.error(ixMsgCode("nonFractionChildren", elt, sect="validation"),
                                 _("Inline XBRL nil ix:nonFraction may only have one child ix:nonFraction"),
@@ -1375,3 +1426,21 @@ def checkIxContinuationChain(val, elt, chain=None):
                 if contAt is not None:
                     chain.append(elt)
                 checkIxContinuationChain(val, contAt, chain)
+
+def _isExtensionTaxonomyDocument(val: ValidateXbrl, modelDocument: ModelDocument.ModelDocument) -> bool:
+    if modelDocument.uri.startswith(val.modelXbrl.uriDir):
+        # document uri in same subtree as entry doocument.
+        return True
+
+    # check if document in entry submission's package.
+    return val.modelXbrl.fileSource.isOpen and modelDocument.filepath.startswith(val.modelXbrl.fileSource.baseurl)
+
+def _shouldValidateBaseTaxonomyDoc(val: ValidateXbrl, modelDocument: ModelDocument.ModelDocument) -> bool:
+    baseTaxonomyValidationMode = val.modelXbrl.modelManager.baseTaxonomyValidationMode
+    if baseTaxonomyValidationMode == ValidateBaseTaxonomiesMode.NONE:
+        return False
+    if baseTaxonomyValidationMode == ValidateBaseTaxonomiesMode.ALL:
+        return True
+    if baseTaxonomyValidationMode == ValidateBaseTaxonomiesMode.DISCLOSURE_SYSTEM:
+        return modelDocument.uri not in getattr(val.disclosureSystem, "standardTaxonomiesDict", {})
+    raise ValueError(f"Invalid base taxonomy validation mode: {baseTaxonomyValidationMode}")

arelle/Version.py

@@ -6,7 +6,7 @@ See COPYRIGHT.md for copyright information.
 """
 from __future__ import annotations
 
-from datetime import datetime
+from arelle.PythonUtil import tryRunCommand
 
 
 def getBuildVersion() -> str | None:
@@ -18,12 +18,7 @@ def getBuildVersion() -> str | None:
 
 
 def getGitHash() -> str | None:
-    import subprocess
-    p = subprocess.run(['git', 'rev-parse', 'HEAD'], capture_output=True, encoding='utf-8')
-    if not p.stderr:
-        return p.stdout.strip()
-    return None
-
+    return tryRunCommand('git', 'rev-parse', 'HEAD')
 
 def getDefaultVersion() -> str:
     return '0.0.0'

arelle/ViewFile.py

@@ -18,6 +18,7 @@ XLSX  = 2
 HTML  = 3
 XML   = 4
 JSON  = 5
+TABULAR_VIEW_TYPES = {CSV, XLSX, HTML}
 TYPENAMES = ["NOOUT", "CSV", "XLSX", "HTML", "XML", "JSON"] # null means no output
 nonNameCharPattern =  re.compile(r"[^\w\-\.:]")
 
@@ -106,6 +107,7 @@ class View:
             .yAxisHdrAbstract{border-top:.5pt solid windowtext;border-right:none;border-bottom:none;border-left:.5pt solid windowtext;}
             .yAxisHdrAbstractChildrenFirst{border-top:none;border-right:none;border-bottom:.5pt solid windowtext;border-left:.5pt solid windowtext;}
             .yAxisHdr{border-top:.5pt solid windowtext;border-right:none;border-bottom:none;border-left:.5pt solid windowtext;}
+            .yAxisTopSpanLeg{border-top:.5pt solid windowtext;border-right:none;border-bottom:none;border-left:none;}
             .cell{border-top:1.0pt solid windowtext;border-right:.5pt solid windowtext;border-bottom:.5pt solid windowtext;border-left:.5pt solid windowtext;}
             .abstractCell{border-top:1.0pt solid windowtext;border-right:.5pt solid windowtext;border-bottom:.5pt solid windowtext;border-left:.5pt solid windowtext;background:#e8e8e8;}
             .blockedCell{border-top:1.0pt solid windowtext;border-right:.5pt solid windowtext;border-bottom:.5pt solid windowtext;border-left:.5pt solid windowtext;background:#eee;}

arelle/ViewFileDTS.py

@@ -27,11 +27,16 @@ class ViewDTS(ViewFile.View):
     def viewDtsElement(self, modelDocument, referenceTypes, indent, visited):
         visited.add(modelDocument)
         dtsObjectType = modelDocument.gettype()
-        attr = {"file": modelDocument.basename, "referenceTypes": sorted(referenceTypes)}
+        xmlRowElementName = dtsObjectType
+        referenceTypes = sorted(referenceTypes)
+        if self.type == ViewFile.XML:
+            xmlRowElementName = xmlRowElementName.replace(" ", "-")
+            referenceTypes = " ".join(referenceTypes)
+        attr = {"file": modelDocument.basename, "referenceTypes": referenceTypes}
         if not modelDocument.inDTS:
             attr["inDTS"] = "false"
         self.addRow(["{0} - {1}".format(modelDocument.basename, dtsObjectType)], treeIndent=indent,
-                    xmlRowElementName=dtsObjectType, xmlRowEltAttr=attr, xmlCol0skipElt=True)
+                    xmlRowElementName=xmlRowElementName, xmlRowEltAttr=attr, xmlCol0skipElt=True)
         for referencedDocument, ref in modelDocument.referencesDocument.items():
             if referencedDocument not in visited:
                 self.viewDtsElement(referencedDocument, ref.referenceTypes, indent + 1, visited)

arelle/ViewFileFactList.py

@@ -116,7 +116,7 @@ class ViewFacts(ViewFile.View):
                         elif col == "Lang":
                             cols.append( lang )
                         elif col == "Value":
-                            cols.append( "(nil)" if modelFact.xsiNil == "true" else modelFact.effectiveValue.strip() )
+                            cols.append( "(nil)" if modelFact.xsiNil == "true" else modelFact.effectiveValue )
                         elif col == "EntityScheme":
                             cols.append( modelFact.context.entityIdentifier[0] )
                         elif col == "EntityIdentifier":

arelle/ViewFileFactTable.py

@@ -3,7 +3,7 @@ See COPYRIGHT.md for copyright information.
 '''
 from arelle import ViewFile, ModelDtsObject, XbrlConst, XmlUtil
 from arelle.XbrlConst import conceptNameLabelRole, standardLabel, terseLabel, documentationLabel
-from arelle.ViewFile import CSV, XLSX, HTML, XML, JSON
+from arelle.ViewFile import CSV, XLSX, HTML, XML, JSON, TABULAR_VIEW_TYPES
 import datetime
 import regex as re
 from collections import defaultdict
@@ -84,9 +84,9 @@ class ViewFacts(ViewFile.View):
                                  modelXbrl=self.modelXbrl, col1=col0)
         self.isCol0Label = col0 in ("Concept", "Label")
         relationshipSet = self.modelXbrl.relationshipSet(self.arcrole, self.linkrole, self.linkqname, self.arcqname)
+        linkroleUris = []
         if relationshipSet:
             # sort URIs by definition
-            linkroleUris = []
             for linkroleUri in relationshipSet.linkRoleUris:
                 modelRoleTypes = self.modelXbrl.roleTypes.get(linkroleUri)
                 if modelRoleTypes:
@@ -302,7 +302,7 @@ class ViewFacts(ViewFile.View):
             for i, modelRel in enumerate(relationshipSet.fromModelObject(concept)):
                 nestedRelationshipSet = relationshipSet
                 targetRole = modelRel.targetRole
-                if self.arcrole == XbrlConst.summationItem:
+                if self.arcrole in XbrlConst.summationItems:
                     childPrefix = "({:0g}) ".format(modelRel.weight) # format without .0 on integer weights
                 elif targetRole is None or len(targetRole) == 0:
                     targetRole = relationshipSet.linkrole
@@ -324,7 +324,7 @@ class ViewFacts(ViewFile.View):
             try:
                 colId = self.contextColId[fact.context.objectId()]
                 # special case of start date, pick column corresponding
-                if preferredLabel == XbrlConst.periodStartLabel:
+                if self.type in TABULAR_VIEW_TYPES and preferredLabel == XbrlConst.periodStartLabel:
                     date = fact.context.instantDatetime
                     if date:
                         if date in self.startdatetimeColId:

arelle/ViewFileRelationshipSet.py

@@ -1,18 +1,22 @@
 '''
 See COPYRIGHT.md for copyright information.
 '''
+from __future__ import annotations
+
 from arelle import ModelObject, ModelDtsObject, XbrlConst, XmlUtil, ViewFile
 from arelle.ModelDtsObject import ModelRelationship
 from arelle.ViewFile import NOOUT, CSV, XLSX, HTML, XML, JSON
 from arelle.ViewUtil import viewReferences
 from arelle.XbrlConst import conceptNameLabelRole, documentationLabel, widerNarrower
-from arelle.ModelRenderingObject import ModelEuAxisCoord, ModelRuleDefinitionNode
+from arelle.ModelRenderingObject import DefnMdlRuleDefinitionNode
 from arelle.ModelFormulaObject import Aspect
 
 import os
 
 def viewRelationshipSet(modelXbrl, outfile, header, arcrole, linkrole=None, linkqname=None, arcqname=None, labelrole=None, lang=None, cols=None):
-    modelXbrl.modelManager.showStatus(_("viewing relationships {0}").format(os.path.basename(arcrole)))
+    arcroles = (arcrole,) if isinstance(arcrole, str) else arcrole
+    arcMessage = (os.path.basename(role) for role in arcroles)
+    modelXbrl.modelManager.showStatus(_("viewing relationships {0}").format(', '.join(arcMessage)))
     view = ViewRelationshipSet(modelXbrl, outfile, header, labelrole, lang, cols)
     view.view(arcrole, linkrole, linkqname, arcqname)
     view.close()
@@ -27,6 +31,11 @@ COL_WIDTHS = {
     "Name": 40, "Namespace": 60, "LocalName": 40, "Documentation": 80
     }
 
+def hasCalcArcrole(arcroles: tuple[str | tuple[str, ...], ...] | str) -> bool:
+    if isinstance(arcroles, (tuple, list)):
+        return any(hasCalcArcrole(arcrole) for arcrole in arcroles)
+    return arcroles in XbrlConst.summationItems
+
 class ViewRelationshipSet(ViewFile.View):
     def __init__(self, modelXbrl, outfile, header, labelrole, lang, cols):
         super(ViewRelationshipSet, self).__init__(modelXbrl, outfile, header, lang)
@@ -39,7 +48,7 @@ class ViewRelationshipSet(ViewFile.View):
         # set up treeView widget and tabbed pane
         if arcrole == XbrlConst.parentChild: # extra columns
             heading = ["Presentation Relationships", "Pref. Label", "Type", "References"]
-        elif arcrole == XbrlConst.summationItem:    # add columns for calculation relationships
+        elif hasCalcArcrole(arcrole):    # add columns for calculation relationships
             heading = ["Calculation Relationships", "Weight", "Balance"]
         elif arcrole == "XBRL-dimensions":    # add columns for dimensional information
             heading = ["Dimensions Relationships", "Arcrole","CntxElt","Closed","Usable"]
@@ -120,7 +129,7 @@ class ViewRelationshipSet(ViewFile.View):
                 if arcrole == "XBRL-dimensions":
                     childRelationshipSet = self.modelXbrl.relationshipSet(XbrlConst.consecutiveArcrole.get(modelObject.arcrole,"XBRL-dimensions"),
                                                                           modelObject.linkrole)
-                elif self.arcrole == "Table-rendering" and isinstance(concept, (ModelEuAxisCoord, ModelRuleDefinitionNode)):
+                elif self.arcrole == "Table-rendering" and isinstance(concept, DefnMdlRuleDefinitionNode):
                     numDims = len(concept.aspectValue(None, Aspect.DIMENSIONS, inherit=False) or ()) * 2
                     if numDims > self.maxNumDims: self.maxNumDims = numDims
             for modelRel in childRelationshipSet.fromModelObject(concept):
@@ -166,19 +175,27 @@ class ViewRelationshipSet(ViewFile.View):
                 text = concept.localName
                 xmlRowElementName = text
             cols = [text]
-            if arcrole == "XBRL-dimensions" and isRelation:
-                relArcrole = modelObject.arcrole
-                cols.append( os.path.basename( relArcrole ) )
-                if relArcrole in (XbrlConst.all, XbrlConst.notAll):
-                    cols.append( modelObject.contextElement )
-                    cols.append( modelObject.closed )
+            if arcrole == "XBRL-dimensions":
+                if isRelation:
+                    relArcrole = modelObject.arcrole
+                    cols.append( os.path.basename( relArcrole ) )
+                    if relArcrole in (XbrlConst.all, XbrlConst.notAll):
+                        cols.append( modelObject.contextElement )
+                        cols.append( modelObject.closed )
+                    else:
+                        cols.append(None)
+                        cols.append(None)
+                    if relArcrole in (XbrlConst.dimensionDomain, XbrlConst.domainMember):
+                        cols.append( modelObject.usable  )
+                    else:
+                        cols.append(None)
+                    childRelationshipSet = self.modelXbrl.relationshipSet(XbrlConst.consecutiveArcrole.get(relArcrole,"XBRL-dimensions"),
+                                                                        modelObject.consecutiveLinkrole)
                 else:
                     cols.append(None)
                     cols.append(None)
-                if relArcrole in (XbrlConst.dimensionDomain, XbrlConst.domainMember):
-                    cols.append( modelObject.usable  )
-                childRelationshipSet = self.modelXbrl.relationshipSet(XbrlConst.consecutiveArcrole.get(relArcrole,"XBRL-dimensions"),
-                                                                      modelObject.consecutiveLinkrole)
+                    cols.append(None)
+                    cols.append(None)
             if self.arcrole == XbrlConst.parentChild: # extra columns
                 if isRelation:
                     preferredLabel = modelObject.preferredLabel
@@ -189,7 +206,7 @@ class ViewRelationshipSet(ViewFile.View):
                 cols.append(preferredLabel)
                 cols.append(concept.niceType)
                 cols.append(viewReferences(concept))
-            elif arcrole == XbrlConst.summationItem:
+            elif hasCalcArcrole(arcrole):
                 if isRelation:
                     cols.append("{:0g} ".format(modelObject.weight))
                 else:
@@ -210,7 +227,7 @@ class ViewRelationshipSet(ViewFile.View):
                 except AttributeError:
                     header = None # could be a filter
                 if isRelation:
-                    cols.append(modelObject.axisDisposition)
+                    cols.append(modelObject.axis)
                 else:
                     cols.append('')
                 if isRelation and header is None:
@@ -224,7 +241,7 @@ class ViewRelationshipSet(ViewFile.View):
                 else:
                     cols.append('')
                 cols.append(header)
-                if isRelation and isinstance(concept, (ModelEuAxisCoord, ModelRuleDefinitionNode)):
+                if isRelation and isinstance(concept, DefnMdlRuleDefinitionNode):
                     cols.append(concept.aspectValue(None, Aspect.CONCEPT))
                     if self.type in (CSV, XML, JSON): # separate dimension fields
                         for dim in (concept.aspectValue(None, Aspect.DIMENSIONS, inherit=False) or ()):
@@ -243,7 +260,7 @@ class ViewRelationshipSet(ViewFile.View):
                     cols.append(", ".join(w.label(preferredLabel,lang=self.lang,linkroleHint=relationshipSet.linkrole) for w in otherWider))
                 else:
                     cols.append("")
-            if self.cols and len(self.cols) > 1:
+            if self.cols:
                 for col in self.cols:
                     if col == "Name":
                         cols.append( (concept.qname or concept.prefixedName) )
@@ -261,7 +278,7 @@ class ViewRelationshipSet(ViewFile.View):
                 for modelRel in childRelationshipSet.fromModelObject(concept):
                     nestedRelationshipSet = relationshipSet
                     targetRole = modelRel.targetRole
-                    if arcrole == XbrlConst.summationItem:
+                    if hasCalcArcrole(arcrole):
                         childPrefix = "({:+0g}) ".format(modelRel.weight) # format without .0 on integer weights
                     elif targetRole is None or len(targetRole) == 0:
                         targetRole = relationshipSet.linkrole