warscript 0.0.1-dev.46595c8 → 0.0.1-dev.46e7a52

package/engine/behaviour/unit.lua

@@ -17,6 +17,11 @@ local getOrPut = ____lua_2Dmaps.getOrPut
 local mutableLuaMap = ____lua_2Dmaps.mutableLuaMap
 local ____lua_2Dsets = require("utility.lua-sets")
 local mutableLuaSet = ____lua_2Dsets.mutableLuaSet
+local ____bonus = require("engine.internal.unit.bonus")
+local addOrUpdateOrRemoveUnitBonus = ____bonus.addOrUpdateOrRemoveUnitBonus
+local getUnitBonus = ____bonus.getUnitBonus
+local removeUnitBonus = ____bonus.removeUnitBonus
+local safeCall = warpack.safeCall
 local behaviorsByEvent = {}
 local rangeByBehaviorByEvent = {}
 local listenerByBehaviorByEvent = {}
@@ -47,9 +52,27 @@ function UnitBehavior.prototype.onDestroy(self)
         end
         eventsByBehavior[self] = nil
     end
+    if self._bonusIdByBonusType ~= nil then
+        for bonusType, bonusId in pairs(self._bonusIdByBonusType) do
+            removeUnitBonus(self.object, bonusType, bonusId)
+        end
+    end
     return Behavior.prototype.onDestroy(self)
 end
-function UnitBehavior.prototype.registerInRangeUnitEvent(self, event, range, listener)
+function UnitBehavior.prototype.getUnitBonus(self, bonusType)
+    local ____opt_6 = self._bonusIdByBonusType
+    local bonusId = ____opt_6 and ____opt_6[bonusType]
+    return bonusId == nil and 0 or getUnitBonus(self.object, bonusType, bonusId)
+end
+function UnitBehavior.prototype.addOrUpdateOrRemoveUnitBonus(self, bonusType, value)
+    local bonusIdByBonusType = self._bonusIdByBonusType
+    if bonusIdByBonusType == nil then
+        bonusIdByBonusType = {}
+        self._bonusIdByBonusType = bonusIdByBonusType
+    end
+    bonusIdByBonusType[bonusType] = addOrUpdateOrRemoveUnitBonus(self.object, bonusType, bonusIdByBonusType[bonusType], value)
+end
+function UnitBehavior.prototype.registerInRangeUnitEvent(self, event, extractUnit, range, listener)
     local rangeByBehavior = getOrPut(rangeByBehaviorByEvent, event, mutableLuaMap)
     rangeByBehavior[self] = range
     local listenerByBehavior = getOrPut(listenerByBehaviorByEvent, event, mutableLuaMap)
@@ -57,14 +80,16 @@ function UnitBehavior.prototype.registerInRangeUnitEvent(self, event, range, lis
     getOrPut(eventsByBehavior, self, mutableLuaSet)[event] = true
     local behaviors = behaviorsByEvent[event]
     if behaviors == nil then
-        event:addListener(function(unit, ...)
+        event:addListener(function(...)
             local behaviors = behaviorsByEvent[event]
             if behaviors ~= nil then
-                for behavior in pairs(behaviors) do
-                    local range = rangeByBehavior[behavior]
-                    if range ~= nil and unit:getCollisionDistanceTo(behavior.unit) <= range then
-                        local ____self_6 = behavior
-                        ____self_6[listenerByBehavior[behavior]](____self_6, unit, ...)
+                local unit = extractUnit(...)
+                if unit ~= nil then
+                    for behavior in pairs(behaviors) do
+                        local range = rangeByBehavior[behavior]
+                        if range ~= nil and unit:getCollisionDistanceTo(behavior.unit) <= range then
+                            safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                        end
                     end
                 end
             end
@@ -104,10 +129,28 @@ function UnitBehavior.prototype.onAbilityChannelingStart(self, ability)
 end
 function UnitBehavior.prototype.onAbilityImpact(self, ability)
 end
+function UnitBehavior.prototype.onAbilityWidgetTargetImpact(self, ability, target)
+end
+function UnitBehavior.prototype.onAbilityUnitTargetImpact(self, ability, target)
+end
+function UnitBehavior.prototype.onAbilityItemTargetImpact(self, ability, target)
+end
+function UnitBehavior.prototype.onAbilityDestructibleTargetImpact(self, ability, target)
+end
+function UnitBehavior.prototype.onAbilityPointTargetImpact(self, ability, x, y)
+end
+function UnitBehavior.prototype.onAbilityNoTargetImpact(self, ability)
+end
 function UnitBehavior.prototype.onAbilityChannelingFinish(self, ability)
 end
 function UnitBehavior.prototype.onAbilityStop(self, ability)
 end
+function UnitBehavior.prototype.onTargetingAbilityChannelingStart(self, ability, source)
+end
+function UnitBehavior.prototype.onTargetingAbilityImpact(self, ability, source)
+end
+function UnitBehavior.prototype.onBuffGained(self, buff)
+end
 function UnitBehavior.prototype.onItemDropped(self, item)
 end
 function UnitBehavior.prototype.onItemPickedUp(self, item)
@@ -122,6 +165,8 @@ function UnitBehavior.prototype.onKill(self, target)
 end
 function UnitBehavior.prototype.onDeath(self, source)
 end
+function UnitBehavior.prototype.onOwnerChange(self, previousOwner)
+end
 __TS__SetDescriptor(
     UnitBehavior.prototype,
     "unit",
@@ -175,9 +220,37 @@ __TS__SetDescriptor(
     Unit.abilityChannelingStartEvent:addListener(function(source, ability)
         ____exports.UnitBehavior:forAll(source, "onAbilityChannelingStart", ability)
     end)
+    Unit.abilityUnitTargetChannelingStartEvent:addListener(function(source, ability, target)
+        ____exports.UnitBehavior:forAll(target, "onTargetingAbilityChannelingStart", ability, source)
+    end)
     Unit.abilityImpactEvent:addListener(function(source, ability)
         ____exports.UnitBehavior:forAll(source, "onAbilityImpact", ability)
     end)
+    Unit.abilityWidgetTargetImpactEvent:addListener(function(source, ability, target)
+        ____exports.UnitBehavior:forAll(source, "onAbilityWidgetTargetImpact", ability, target)
+    end)
+    Unit.abilityUnitTargetImpactEvent:addListener(function(source, ability, target)
+        ____exports.UnitBehavior:forAll(source, "onAbilityUnitTargetImpact", ability, target)
+        ____exports.UnitBehavior:forAll(target, "onTargetingAbilityImpact", ability, source)
+    end)
+    Unit.abilityItemTargetImpactEvent:addListener(function(source, ability, target)
+        ____exports.UnitBehavior:forAll(source, "onAbilityItemTargetImpact", ability, target)
+    end)
+    Unit.abilityDestructibleTargetImpactEvent:addListener(function(source, ability, target)
+        ____exports.UnitBehavior:forAll(source, "onAbilityDestructibleTargetImpact", ability, target)
+    end)
+    Unit.abilityPointTargetImpactEvent:addListener(function(source, ability, x, y)
+        ____exports.UnitBehavior:forAll(
+            source,
+            "onAbilityPointTargetImpact",
+            ability,
+            x,
+            y
+        )
+    end)
+    Unit.abilityNoTargetImpactEvent:addListener(function(source, ability)
+        ____exports.UnitBehavior:forAll(source, "onAbilityNoTargetImpact", ability)
+    end)
     Unit.abilityChannelingFinishEvent:addListener(function(source, ability)
         ____exports.UnitBehavior:forAll(source, "onAbilityChannelingFinish", ability)
     end)
@@ -205,6 +278,9 @@ __TS__SetDescriptor(
     Unit.itemChargesChangedEvent:addListener(function(unit, item)
         ____exports.UnitBehavior:forAll(unit, "onItemChargesChanged", item)
     end)
+    Unit.onOwnerChange:addListener(function(unit, previousOwner)
+        ____exports.UnitBehavior:forAll(unit, "onOwnerChange", previousOwner)
+    end)
 end)(UnitBehavior)
 Unit.destroyEvent:addListener(function(unit)
     ____exports.UnitBehavior:forAll(unit, "destroy")

package/engine/buff.d.ts

@@ -201,11 +201,8 @@ export declare class Buff<AdditionalParameters extends Prohibit<Record<string, a
     private readonly _spellStealPriority?;
     private readonly _learnLevelMinimum?;
     private readonly [BuffPropertyKey.MISS_PROBABILITY]?;
-    private _bonusIdByBonusType?;
     private readonly _abilityTypeIds?;
     private _behaviors?;
-    private getUnitBonus;
-    private addOrUpdateOrRemoveUnitBonus;
     constructor(target: Unit, ...parameters: BuffConstructorParameters<AdditionalParameters>);
     get level(): number;
     get remainingDamageOverDuration(): number;
@@ -278,6 +275,7 @@ export declare class Buff<AdditionalParameters extends Prohibit<Record<string, a
     onDeath(source: Unit | undefined): void;
     onDamageDealt(target: Unit, event: DamageEvent): void;
     onDamageReceived(source: Unit | undefined, event: DamageEvent): void;
-    static readonly destroyEvent: Event<[Buff<object>]>;
+    static readonly createdEvent: Event<[Buff<object>]>;
+    static readonly beingDestroyedEvent: Event<[Buff<object>]>;
 }
 export {};

package/engine/buff.lua

@@ -28,9 +28,6 @@ local ____math = require("math")
 local max = ____math.max
 local min = ____math.min
 local ____bonus = require("engine.internal.unit.bonus")
-local addOrUpdateOrRemoveUnitBonus = ____bonus.addOrUpdateOrRemoveUnitBonus
-local getUnitBonus = ____bonus.getUnitBonus
-local removeUnitBonus = ____bonus.removeUnitBonus
 local UnitBonusType = ____bonus.UnitBonusType
 local ____area_2Ddamage = require("engine.internal.mechanics.area-damage")
 local damageArea = ____area_2Ddamage.damageArea
@@ -304,7 +301,8 @@ buffHealingIntervalTimerCallback = function(buff)
         source:healTarget(buff[101], healingPerInterval)
     end
 end
-local buffDestroyEvent = __TS__New(Event)
+local buffCreatedEvent = __TS__New(Event)
+local buffBeingDestroyedEvent = __TS__New(Event)
 ____exports.Buff = __TS__Class()
 local Buff = ____exports.Buff
 Buff.name = "Buff"
@@ -506,64 +504,52 @@ function Buff.prototype.____constructor(self, _unit, typeIdOrTypeIds, polarityOr
     end
     self:onCreate()
     self[100] = 1
-end
-function Buff.prototype.getUnitBonus(self, bonusType)
-    local ____opt_38 = self._bonusIdByBonusType
-    local bonusId = ____opt_38 and ____opt_38[bonusType]
-    return bonusId == nil and 0 or getUnitBonus(self._unit, bonusType, bonusId)
-end
-function Buff.prototype.addOrUpdateOrRemoveUnitBonus(self, bonusType, value)
-    local bonusIdByBonusType = self._bonusIdByBonusType
-    if bonusIdByBonusType == nil then
-        bonusIdByBonusType = {}
-        self._bonusIdByBonusType = bonusIdByBonusType
-    end
-    bonusIdByBonusType[bonusType] = addOrUpdateOrRemoveUnitBonus(self._unit, bonusType, bonusIdByBonusType[bonusType], value)
+    Event.invoke(buffCreatedEvent, self)
 end
 function Buff.prototype.flashEffect(self, widgetOrXOrParametersOrDuration, yOrParametersOrDuration, parametersOrDuration)
     if type(widgetOrXOrParametersOrDuration) == "number" and type(yOrParametersOrDuration) == "number" then
         Effect:flash(self[105], widgetOrXOrParametersOrDuration, yOrParametersOrDuration, parametersOrDuration)
     else
         local isWidgetProvided = __TS__InstanceOf(widgetOrXOrParametersOrDuration, Unit) or __TS__InstanceOf(widgetOrXOrParametersOrDuration, Item) or __TS__InstanceOf(widgetOrXOrParametersOrDuration, Destructable)
-        local ____Effect_42 = Effect
-        local ____Effect_flash_43 = Effect.flash
-        local ____array_41 = __TS__SparseArrayNew(
+        local ____Effect_40 = Effect
+        local ____Effect_flash_41 = Effect.flash
+        local ____array_39 = __TS__SparseArrayNew(
             self[105],
             isWidgetProvided and widgetOrXOrParametersOrDuration or self._unit,
             stringValueByBuffTypeIdByFieldId[fourCC("feft")][self.typeId] or "origin"
         )
-        local ____isWidgetProvided_40
+        local ____isWidgetProvided_38
         if isWidgetProvided then
-            ____isWidgetProvided_40 = yOrParametersOrDuration
+            ____isWidgetProvided_38 = yOrParametersOrDuration
         else
-            ____isWidgetProvided_40 = widgetOrXOrParametersOrDuration
+            ____isWidgetProvided_38 = widgetOrXOrParametersOrDuration
         end
-        __TS__SparseArrayPush(____array_41, ____isWidgetProvided_40)
-        ____Effect_flash_43(
-            ____Effect_42,
-            __TS__SparseArraySpread(____array_41)
+        __TS__SparseArrayPush(____array_39, ____isWidgetProvided_38)
+        ____Effect_flash_41(
+            ____Effect_40,
+            __TS__SparseArraySpread(____array_39)
         )
     end
 end
 function Buff.prototype.flashSpecialEffect(self, widgetOrDuration, duration)
     local isWidgetProvided = type(widgetOrDuration) == "table"
-    local ____Effect_46 = Effect
-    local ____Effect_flash_47 = Effect.flash
-    local ____array_45 = __TS__SparseArrayNew(
+    local ____Effect_44 = Effect
+    local ____Effect_flash_45 = Effect.flash
+    local ____array_43 = __TS__SparseArrayNew(
         self[106],
         isWidgetProvided and widgetOrDuration or self._unit,
         stringValueByBuffTypeIdByFieldId[fourCC("fspt")][self.typeId] or "origin"
     )
-    local ____isWidgetProvided_44
+    local ____isWidgetProvided_42
     if isWidgetProvided then
-        ____isWidgetProvided_44 = duration
+        ____isWidgetProvided_42 = duration
     else
-        ____isWidgetProvided_44 = widgetOrDuration
+        ____isWidgetProvided_42 = widgetOrDuration
     end
-    __TS__SparseArrayPush(____array_45, ____isWidgetProvided_44)
-    ____Effect_flash_47(
-        ____Effect_46,
-        __TS__SparseArraySpread(____array_45)
+    __TS__SparseArrayPush(____array_43, ____isWidgetProvided_42)
+    ____Effect_flash_45(
+        ____Effect_44,
+        __TS__SparseArraySpread(____array_43)
     )
 end
 function Buff.prototype.onCreate(self)
@@ -602,7 +588,7 @@ function Buff.prototype.onDestroy(self)
     end
     if self[136] then
         if self[137] then
-            unit:decrementStunCounter()
+            unit:decrementForceStunCounter()
         end
         unit:decrementStunCounter()
     end
@@ -614,12 +600,7 @@ function Buff.prototype.onDestroy(self)
             unit:removeAbility(abilityTypeId)
         end
     end
-    if self._bonusIdByBonusType ~= nil then
-        for bonusType, bonusId in pairs(self._bonusIdByBonusType) do
-            removeUnitBonus(unit, bonusType, bonusId)
-        end
-    end
-    Event.invoke(buffDestroyEvent, self)
+    Event.invoke(buffBeingDestroyedEvent, self)
     self[100] = 3
     return UnitBehavior.prototype.onDestroy(self)
 end
@@ -648,8 +629,8 @@ function Buff.apply(self, ...)
     end
 end
 function Buff.getByTypeId(self, unit, typeId)
-    local ____opt_48 = buffByTypeIdByUnit[unit]
-    local buff = ____opt_48 and ____opt_48[typeId]
+    local ____opt_46 = buffByTypeIdByUnit[unit]
+    local buff = ____opt_46 and ____opt_46[typeId]
     if __TS__InstanceOf(buff, self) then
         return buff
     end
@@ -807,8 +788,8 @@ __TS__SetDescriptor(
                 return
             end
             self[112] = damageInterval
-            local ____opt_50 = self._timer
-            local elapsed = ____opt_50 and ____opt_50.elapsed or 0
+            local ____opt_48 = self._timer
+            local elapsed = ____opt_48 and ____opt_48.elapsed or 0
             local timer = self[114]
             if timer == nil then
                 timer = Timer:create()
@@ -887,8 +868,8 @@ __TS__SetDescriptor(
                 return
             end
             self[117] = healingInterval
-            local ____opt_52 = self._timer
-            local elapsed = ____opt_52 and ____opt_52.elapsed or 0
+            local ____opt_50 = self._timer
+            local elapsed = ____opt_50 and ____opt_50.elapsed or 0
             local timer = self[119]
             if timer == nil then
                 timer = Timer:create()
@@ -974,11 +955,11 @@ __TS__SetDescriptor(
     "turnsIntoGhost",
     {
         get = function(self)
-            local ____self__135_54 = self[135]
-            if ____self__135_54 == nil then
-                ____self__135_54 = false
+            local ____self__135_52 = self[135]
+            if ____self__135_52 == nil then
+                ____self__135_52 = false
             end
-            return ____self__135_54
+            return ____self__135_52
         end,
         set = function(self, turnsIntoGhost)
             if not turnsIntoGhost and self[135] then
@@ -997,22 +978,22 @@ __TS__SetDescriptor(
     "stuns",
     {
         get = function(self)
-            local ____self__136_55 = self[136]
-            if ____self__136_55 == nil then
-                ____self__136_55 = false
+            local ____self__136_53 = self[136]
+            if ____self__136_53 == nil then
+                ____self__136_53 = false
             end
-            return ____self__136_55
+            return ____self__136_53
         end,
         set = function(self, stuns)
             if not stuns and self[136] then
                 if self[137] then
-                    self.object:decrementStunCounter()
+                    self.object:decrementForceStunCounter()
                 end
                 self.object:decrementStunCounter()
                 self[136] = nil
             elseif stuns and not self[136] then
                 if self[137] then
-                    self.object:incrementStunCounter()
+                    self.object:incrementForceStunCounter()
                 end
                 self.object:incrementStunCounter()
                 self[136] = true
@@ -1026,21 +1007,21 @@ __TS__SetDescriptor(
     "ignoresStunImmunity",
     {
         get = function(self)
-            local ____self__137_56 = self[137]
-            if ____self__137_56 == nil then
-                ____self__137_56 = false
+            local ____self__137_54 = self[137]
+            if ____self__137_54 == nil then
+                ____self__137_54 = false
             end
-            return ____self__137_56
+            return ____self__137_54
         end,
         set = function(self, ignoresStunImmunity)
             if not ignoresStunImmunity and self[137] then
                 if self[136] then
-                    self.object:decrementStunCounter()
+                    self.object:decrementForceStunCounter()
                 end
                 self[137] = nil
             elseif ignoresStunImmunity and not self[137] then
                 if self[136] then
-                    self.object:incrementStunCounter()
+                    self.object:incrementForceStunCounter()
                 end
                 self[137] = true
             end
@@ -1053,11 +1034,11 @@ __TS__SetDescriptor(
     "disablesAutoAttack",
     {
         get = function(self)
-            local ____self__138_57 = self[138]
-            if ____self__138_57 == nil then
-                ____self__138_57 = false
+            local ____self__138_55 = self[138]
+            if ____self__138_55 == nil then
+                ____self__138_55 = false
             end
-            return ____self__138_57
+            return ____self__138_55
         end,
         set = function(self, disablesAutoAttack)
             if not disablesAutoAttack and self[138] then
@@ -1076,11 +1057,11 @@ __TS__SetDescriptor(
     "providesInvulnerability",
     {
         get = function(self)
-            local ____self__139_58 = self[139]
-            if ____self__139_58 == nil then
-                ____self__139_58 = false
+            local ____self__139_56 = self[139]
+            if ____self__139_56 == nil then
+                ____self__139_56 = false
             end
-            return ____self__139_58
+            return ____self__139_56
         end,
         set = function(self, providesInvulnerability)
             if not providesInvulnerability and self[139] then
@@ -1099,11 +1080,11 @@ __TS__SetDescriptor(
     "killsOnExpiration",
     {
         get = function(self)
-            local ____self__140_59 = self[140]
-            if ____self__140_59 == nil then
-                ____self__140_59 = false
+            local ____self__140_57 = self[140]
+            if ____self__140_57 == nil then
+                ____self__140_57 = false
             end
-            return ____self__140_59
+            return ____self__140_57
         end,
         set = function(self, killsOnExpiration)
             if not killsOnExpiration and self[140] then
@@ -1120,11 +1101,11 @@ __TS__SetDescriptor(
     "explodesOnExpiration",
     {
         get = function(self)
-            local ____self__141_60 = self[141]
-            if ____self__141_60 == nil then
-                ____self__141_60 = false
+            local ____self__141_58 = self[141]
+            if ____self__141_58 == nil then
+                ____self__141_58 = false
             end
-            return ____self__141_60
+            return ____self__141_58
         end,
         set = function(self, killsOnExpiration)
             if not killsOnExpiration and self[141] then
@@ -1252,13 +1233,13 @@ __TS__SetDescriptor(
     "remainingDuration",
     {
         get = function(self)
-            local ____opt_61 = self._timer
-            return ____opt_61 and ____opt_61.remaining or 0
+            local ____opt_59 = self._timer
+            return ____opt_59 and ____opt_59.remaining or 0
         end,
         set = function(self, remainingDuration)
-            local ____remainingDuration_65 = remainingDuration
-            local ____opt_63 = self._timer
-            local remainingDurationDelta = ____remainingDuration_65 - (____opt_63 and ____opt_63.remaining or 0)
+            local ____remainingDuration_63 = remainingDuration
+            local ____opt_61 = self._timer
+            local remainingDurationDelta = ____remainingDuration_63 - (____opt_61 and ____opt_61.remaining or 0)
             if remainingDurationDelta ~= 0 then
                 self[103] = self[103] + remainingDurationDelta
                 if remainingDuration <= 0 then
@@ -1288,7 +1269,8 @@ __TS__SetDescriptor(
     },
     true
 )
-Buff.destroyEvent = buffDestroyEvent;
+Buff.createdEvent = buffCreatedEvent
+Buff.beingDestroyedEvent = buffBeingDestroyedEvent;
 (function(self)
     local function destroyBuffIfNeeded(buff)
         if getUnitAbility(buff[101].handle, buff.typeId) ~= buff.handle and buff[100] == 1 then
@@ -1342,5 +1324,8 @@ Buff.destroyEvent = buffDestroyEvent;
             ____exports.checkBuffs(target)
         end
     )
+    buffCreatedEvent:addListener(function(buff)
+        UnitBehavior:forAll(buff.unit, "onBuffGained", buff)
+    end)
 end)(Buff)
 return ____exports

package/engine/internal/ability.d.ts

@@ -1,5 +1,5 @@
 /** @noSelfInFile */
-import { Handle } from "../../core/types/handle";
+import { Handle, HandleDestructor } from "../../core/types/handle";
 import { Event } from "../../event";
 import type { Item } from "../../core/types/item";
 import type { Unit } from "./unit";
@@ -67,6 +67,7 @@ export declare class UnitAbility extends Ability {
     get cooldownRemaining(): number;
     set cooldownRemaining(cooldownRemaining: number);
     interruptCast(): void;
+    protected onDestroy(): HandleDestructor;
     static get onCreate(): Event<[UnitAbility]>;
     static get onDestroy(): Event<[UnitAbility]>;
 }
@@ -93,6 +94,7 @@ export declare class ItemAbility extends Ability {
     get cooldownRemaining(): number;
     set cooldownRemaining(cooldownRemaining: number);
     interruptCast(): void;
+    protected onDestroy(): HandleDestructor;
     static get onCreate(): Event<[ItemAbility]>;
     static get onDestroy(): Event<[ItemAbility]>;
 }

package/engine/internal/ability.lua

@@ -232,6 +232,19 @@ ____exports.getOrderIdByAbilityTypeId = function(abilityTypeId)
     local parentTypeId = availableFields[abilityTypeId]
     return order2orderId(orders[____type(parentTypeId) == "number" and parentTypeId or abilityTypeId] or "")
 end
+---
+-- @internal For use by internal systems only.
+____exports.abilityTypeHasField = function(abilityTypeId, field)
+    field = ____type(field) == "number" and field or getHandleId(field)
+    if commonFields[field] then
+        return true
+    end
+    local id = availableFields[abilityTypeId]
+    if ____type(id) == "number" then
+        id = availableFields[id]
+    end
+    return not not (id and id[field])
+end
 ____exports.Ability = __TS__Class()
 local Ability = ____exports.Ability
 Ability.name = "Ability"
@@ -247,15 +260,7 @@ function Ability.prototype.getSnapshot(self)
     return nil
 end
 function Ability.prototype.hasField(self, field)
-    field = ____type(field) == "number" and field or getHandleId(field)
-    if commonFields[field] then
-        return true
-    end
-    local id = availableFields[self.typeId]
-    if ____type(id) == "number" then
-        id = availableFields[id]
-    end
-    return not not (id and id[field])
+    return ____exports.abilityTypeHasField(self.typeId, field)
 end
 function Ability.prototype.getField(self, field, level)
     local fieldType = match(
@@ -404,16 +409,28 @@ function UnitAbility.prototype.decrementHideCounter(self)
     unitHideAbility(self.u, self.typeId, false)
 end
 function UnitAbility.prototype.incrementDisableCounter(self)
-    unitDisableAbility(self.u, self.typeId, true, false)
+    local unit = self.u
+    local typeId = self.typeId
+    unitHideAbility(unit, typeId, true)
+    unitDisableAbility(unit, typeId, true, false)
     self.d = (self.d or 0) + 1
 end
 function UnitAbility.prototype.decrementDisableCounter(self)
-    unitDisableAbility(self.u, self.typeId, false, false)
+    local unit = self.u
+    local typeId = self.typeId
+    unitDisableAbility(unit, typeId, false, false)
+    unitHideAbility(unit, typeId, true)
     self.d = (self.d or 0) - 1
 end
 function UnitAbility.prototype.interruptCast(self)
     self.owner:interruptCast(self.typeId)
 end
+function UnitAbility.prototype.onDestroy(self)
+    if self.owner.state ~= 2 then
+        self.owner:removeAbility(self.typeId)
+    end
+    return UnitAbility.____super.prototype.onDestroy(self)
+end
 __TS__SetDescriptor(
     UnitAbility.prototype,
     "isDisabled",
@@ -506,6 +523,12 @@ function ItemAbility.prototype.interruptCast(self)
         setItemBooleanField(handle, ITEM_BF_ACTIVELY_USED, true)
     end
 end
+function ItemAbility.prototype.onDestroy(self)
+    if self.owner.state ~= 2 then
+        self.owner:removeAbility(self.typeId)
+    end
+    return ItemAbility.____super.prototype.onDestroy(self)
+end
 __TS__SetDescriptor(
     ItemAbility.prototype,
     "level",