vibecodingmachine-core 2026.2.26-1739 → 2026.3.9-850

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vibecodingmachine-core",
-  "version": "2026.02.26-1739",
+  "version": "2026.03.09-0850",
   "description": "Shared core logic for Vibe Coding Machine IDE integration",
   "main": "src/index.cjs",
   "module": "src/index.js",

package/src/agents/AgentCheckDiscoveryService.js

@@ -0,0 +1,180 @@
+/**
+ * Agent Check Discovery Service
+ * 
+ * Handles agent discovery integration with check operations.
+ * Constitutional requirement: <555 lines, test-first approach.
+ */
+
+const AgentDiscoveryService = require('./discovery/AgentDiscoveryService');
+
+/**
+ * Agent check discovery service
+ */
+class AgentCheckDiscoveryService {
+  /**
+   * Create discovery service instance
+   * @param {Object} config - Service configuration
+   */
+  constructor(config = {}) {
+    this.configManager = config.configManager || null;
+    this.logger = config.logger || null;
+    this.fileManager = config.fileManager || null;
+    
+    this.discoveryService = new AgentDiscoveryService({
+      configManager: this.configManager,
+      logger: this.logger,
+      fileManager: this.fileManager,
+      ...config.discovery
+    });
+  }
+
+  /**
+   * Discover new agents in the system
+   * @param {Object} options - Discovery options
+   * @returns {Promise<Object>} - Discovery results
+   */
+  async discoverAgents(options = {}) {
+    try {
+      if (this.logger) {
+        await this.logger.info('Starting agent discovery', options);
+      }
+
+      const discoveryOptions = {
+        includeDisabled: options.includeDisabled || false,
+        scanSystem: options.scanSystem !== false,
+        scanConfigFiles: options.scanConfigFiles !== false,
+        timeout: options.timeout || 300000, // 5 minutes
+        ...options
+      };
+
+      const discoveryResult = await this.discoveryService.discoverAgents(discoveryOptions);
+
+      if (this.logger) {
+        await this.logger.info('Agent discovery completed', {
+          discoveredCount: discoveryResult.discovered?.length || 0,
+          newCount: discoveryResult.new?.length || 0,
+          existingCount: discoveryResult.existing?.length || 0
+        });
+      }
+
+      return {
+        success: true,
+        ...discoveryResult,
+        message: `Discovered ${discoveryResult.discovered?.length || 0} agents (${discoveryResult.new?.length || 0} new)`
+      };
+
+    } catch (error) {
+      if (this.logger) {
+        await this.logger.error('Agent discovery failed', { error: error.message });
+      }
+
+      return {
+        success: false,
+        error: error.message,
+        message: 'Agent discovery failed'
+      };
+    }
+  }
+
+  /**
+   * Check agents with discovery (discover + install + verify)
+   * @param {Object} options - Check options with discovery
+   * @param {Function} checkAgentsFn - Function to perform agent check
+   * @returns {Promise<Object>} - Combined check and discovery results
+   */
+  async checkAgentsWithDiscovery(options = {}, checkAgentsFn) {
+    const {
+      runDiscovery = true,
+      addDiscovered = false,
+      ...checkOptions
+    } = options;
+
+    try {
+      const startTime = Date.now();
+      const results = {
+        discovery: null,
+        check: null,
+        summary: {
+          totalDuration: 0,
+          discoverySuccessful: false,
+          checkSuccessful: false,
+          newAgentsDiscovered: 0,
+          agentsChecked: 0
+        }
+      };
+
+      // Phase 0: Discovery (if requested)
+      if (runDiscovery) {
+        if (this.logger) {
+          await this.logger.info('Phase 0: Agent Discovery');
+        }
+
+        const discoveryOptions = {
+          includeDisabled: false,
+          scanSystem: true,
+          scanConfigFiles: true,
+          timeout: Math.floor((checkOptions.timeout || 600000) * 0.2), // 20% of time for discovery
+          ...options.discovery
+        };
+
+        results.discovery = await this.discoverAgents(discoveryOptions);
+        results.summary.discoverySuccessful = results.discovery.success;
+        results.summary.newAgentsDiscovered = results.discovery.new?.length || 0;
+
+        // Add discovered agents if requested
+        if (addDiscovered && results.discovery.new?.length > 0) {
+          if (this.logger) {
+            await this.logger.info(`Adding ${results.discovery.new.length} discovered agents`);
+          }
+
+          // Note: This would require AgentAdditionService integration
+          // For now, just log the discovered agents
+          for (const agent of results.discovery.new) {
+            if (this.logger) {
+              await this.logger.info(`Discovered new agent: ${agent.id} (${agent.name})`);
+            }
+          }
+        }
+      }
+
+      // Phase 1+: Regular agent check
+      if (this.logger) {
+        await this.logger.info('Phase 1+: Agent Check (Install + Verify)');
+      }
+
+      results.check = await checkAgentsFn(checkOptions);
+      results.summary.checkSuccessful = results.check.summary?.allSuccessful || false;
+      results.summary.agentsChecked = results.check.totalAgents || 0;
+
+      results.summary.totalDuration = Date.now() - startTime;
+
+      return {
+        success: results.summary.discoverySuccessful && results.summary.checkSuccessful,
+        ...results,
+        message: `Completed: ${results.summary.newAgentsDiscovered} new agents discovered, ${results.summary.agentsChecked} agents checked`
+      };
+
+    } catch (error) {
+      if (this.logger) {
+        await this.logger.error('Check agents with discovery failed', { error: error.message });
+      }
+
+      return {
+        success: false,
+        error: error.message,
+        message: 'Check agents with discovery failed'
+      };
+    }
+  }
+
+  /**
+   * Create discovery service with default configuration
+   * @param {Object} config - Configuration overrides
+   * @returns {AgentCheckDiscoveryService} - Service instance
+   */
+  static createDefault(config = {}) {
+    return new AgentCheckDiscoveryService(config);
+  }
+}
+
+module.exports = AgentCheckDiscoveryService;

package/src/agents/AgentCheckService.js

@@ -8,7 +8,8 @@
 const AgentInstallationService = require('./AgentInstallationService');
 const AgentVerificationService = require('./AgentVerificationService');
 const AgentSetupService = require('./AgentSetupService');
-const AgentDiscoveryService = require('./discovery/AgentDiscoveryService');
+const AgentCheckDiscoveryService = require('./AgentCheckDiscoveryService');
+const AgentCheckStatisticsService = require('./AgentCheckStatisticsService');
 const { AgentStatus } = require('./AgentStatus');
 
 /**
@@ -44,13 +45,20 @@ class AgentCheckService {
       ...config.setup
     });
     
-    this.discoveryService = new AgentDiscoveryService({
+    this.discoveryService = AgentCheckDiscoveryService.createDefault({
       configManager: this.configManager,
       logger: this.logger,
       fileManager: this.fileManager,
       ...config.discovery
     });
     
+    this.statisticsService = AgentCheckStatisticsService.createDefault({
+      configManager: this.configManager,
+      logger: this.logger,
+      fileManager: this.fileManager,
+      ...config.statistics
+    });
+    
     // Service configuration
     this.parallel = config.parallel !== false;
     this.maxConcurrency = config.maxConcurrency || 2;
@@ -320,78 +328,7 @@ class AgentCheckService {
    * @returns {Promise<Object>} - Check statistics
    */
   async getCheckStatistics() {
-    try {
-      const agents = this.configManager.getEnabledAgents();
-      
-      const stats = {
-        totalAgents: agents.length,
-        verified: 0,
-        notVerified: 0,
-        error: 0,
-        installing: 0,
-        lastCheck: null,
-        checkRate: 0
-      };
-
-      let latestCheck = null;
-      
-      for (const agent of agents) {
-        const status = await this.configManager.getAgentStatus(agent.id);
-        
-        if (status) {
-          switch (status.status) {
-            case AgentStatus.VERIFIED:
-              stats.verified++;
-              break;
-            case AgentStatus.NOT_INSTALLED:
-            case AgentStatus.INSTALLED:
-              stats.notVerified++;
-              break;
-            case AgentStatus.ERROR:
-              stats.error++;
-              break;
-            case AgentStatus.INSTALLING:
-              stats.installing++;
-              break;
-          }
-          
-          // Track latest check
-          if (status.lastChecked) {
-            const checkDate = new Date(status.lastChecked);
-            if (!latestCheck || checkDate > latestCheck) {
-              latestCheck = status.lastChecked;
-            }
-          }
-        } else {
-          stats.notVerified++;
-        }
-      }
-      
-      stats.lastCheck = latestCheck ? latestCheck.toISOString() : null;
-      
-      // Calculate check rate (agents that have been checked at least once)
-      const checkedAgents = stats.verified + stats.notVerified + stats.error;
-      stats.checkRate = agents.length > 0 ? (checkedAgents / agents.length) * 100 : 0;
-      
-      return stats;
-    } catch (error) {
-      if (this.logger) {
-        await this.logger.error('Failed to get check statistics', {
-          error: error.message
-        });
-      }
-      
-      return {
-        totalAgents: 0,
-        verified: 0,
-        notVerified: 0,
-        error: 0,
-        installing: 0,
-        lastCheck: null,
-        checkRate: 0,
-        error: error.message
-      };
-    }
+    return this.statisticsService.getCheckStatistics();
   }
 
   /**
@@ -400,53 +337,7 @@ class AgentCheckService {
    * @returns {Promise<Object>} - Detailed agent status
    */
   async getDetailedAgentStatus(agentId) {
-    try {
-      const agent = this.configManager.getAgent(agentId);
-      if (!agent) {
-        return {
-          agentId,
-          found: false,
-          error: 'Agent not found'
-        };
-      }
-
-      const status = await this.configManager.getAgentStatus(agentId);
-      const history = await this.getStatusHistory(agentId, 10);
-      
-      return {
-        agentId,
-        found: true,
-        agent: {
-          id: agent.id,
-          name: agent.name,
-          description: agent.description,
-          enabled: agent.enabled,
-          status: status ? status.status : AgentStatus.NOT_INSTALLED,
-          lastChecked: status ? status.lastChecked : null,
-          lastVerified: status ? status.lastVerified : null,
-          message: status ? status.message : '',
-          installationMethods: agent.installationMethods,
-          verificationCommands: agent.verificationCommands
-        },
-        status,
-        history,
-        canInstall: agent.enabled && status ? status.status === AgentStatus.NOT_INSTALLED : false,
-        canVerify: agent.enabled && status ? [AgentStatus.INSTALLED, AgentStatus.VERIFIED].includes(status.status) : false
-      };
-    } catch (error) {
-      if (this.logger) {
-        await this.logger.error('Failed to get detailed agent status', {
-          agentId,
-          error: error.message
-        });
-      }
-      
-      return {
-        agentId,
-        found: false,
-        error: error.message
-      };
-    }
+    return this.statisticsService.getDetailedAgentStatus(agentId);
   }
 
   /**
@@ -456,24 +347,7 @@ class AgentCheckService {
    * @returns {Promise<Array>} - Status history
    */
   async getStatusHistory(agentId, limit = 50) {
-    try {
-      if (this.fileManager) {
-        const logs = await this.fileManager.readLogs('status-change', { limit });
-        return logs
-          .filter(log => log.agentId === agentId)
-          .slice(-limit)
-          .reverse(); // Most recent first
-      }
-      return [];
-    } catch (error) {
-      if (this.logger) {
-        await this.logger.error('Failed to get status history', {
-          agentId,
-          error: error.message
-        });
-      }
-      return [];
-    }
+    return this.statisticsService.getStatusHistory(agentId, limit);
   }
 
   /**
@@ -482,46 +356,7 @@ class AgentCheckService {
    * @returns {Promise<Object>} - Discovery results
    */
   async discoverAgents(options = {}) {
-    try {
-      if (this.logger) {
-        await this.logger.info('Starting agent discovery', options);
-      }
-
-      const discoveryOptions = {
-        includeDisabled: options.includeDisabled || false,
-        scanSystem: options.scanSystem !== false,
-        scanConfigFiles: options.scanConfigFiles !== false,
-        timeout: options.timeout || 300000, // 5 minutes
-        ...options
-      };
-
-      const discoveryResult = await this.discoveryService.discoverAgents(discoveryOptions);
-
-      if (this.logger) {
-        await this.logger.info('Agent discovery completed', {
-          discoveredCount: discoveryResult.discovered?.length || 0,
-          newCount: discoveryResult.new?.length || 0,
-          existingCount: discoveryResult.existing?.length || 0
-        });
-      }
-
-      return {
-        success: true,
-        ...discoveryResult,
-        message: `Discovered ${discoveryResult.discovered?.length || 0} agents (${discoveryResult.new?.length || 0} new)`
-      };
-
-    } catch (error) {
-      if (this.logger) {
-        await this.logger.error('Agent discovery failed', { error: error.message });
-      }
-
-      return {
-        success: false,
-        error: error.message,
-        message: 'Agent discovery failed'
-      };
-    }
+    return this.discoveryService.discoverAgents(options);
   }
 
   /**
@@ -530,88 +365,10 @@ class AgentCheckService {
    * @returns {Promise<Object>} - Combined check and discovery results
    */
   async checkAgentsWithDiscovery(options = {}) {
-    const {
-      runDiscovery = true,
-      addDiscovered = false,
-      ...checkOptions
-    } = options;
-
-    try {
-      const startTime = Date.now();
-      const results = {
-        discovery: null,
-        check: null,
-        summary: {
-          totalDuration: 0,
-          discoverySuccessful: false,
-          checkSuccessful: false,
-          newAgentsDiscovered: 0,
-          agentsChecked: 0
-        }
-      };
-
-      // Phase 0: Discovery (if requested)
-      if (runDiscovery) {
-        if (this.logger) {
-          await this.logger.info('Phase 0: Agent Discovery');
-        }
-
-        const discoveryOptions = {
-          includeDisabled: false,
-          scanSystem: true,
-          scanConfigFiles: true,
-          timeout: Math.floor((checkOptions.timeout || 600000) * 0.2), // 20% of time for discovery
-          ...options.discovery
-        };
-
-        results.discovery = await this.discoverAgents(discoveryOptions);
-        results.summary.discoverySuccessful = results.discovery.success;
-        results.summary.newAgentsDiscovered = results.discovery.new?.length || 0;
-
-        // Add discovered agents if requested
-        if (addDiscovered && results.discovery.new?.length > 0) {
-          if (this.logger) {
-            await this.logger.info(`Adding ${results.discovery.new.length} discovered agents`);
-          }
-
-          // Note: This would require AgentAdditionService integration
-          // For now, just log the discovered agents
-          for (const agent of results.discovery.new) {
-            if (this.logger) {
-              await this.logger.info(`Discovered new agent: ${agent.id} (${agent.name})`);
-            }
-          }
-        }
-      }
-
-      // Phase 1+: Regular agent check
-      if (this.logger) {
-        await this.logger.info('Phase 1+: Agent Check (Install + Verify)');
-      }
-
-      results.check = await this.checkAgents(checkOptions);
-      results.summary.checkSuccessful = results.check.summary?.allSuccessful || false;
-      results.summary.agentsChecked = results.check.totalAgents || 0;
-
-      results.summary.totalDuration = Date.now() - startTime;
-
-      return {
-        success: results.summary.discoverySuccessful && results.summary.checkSuccessful,
-        ...results,
-        message: `Completed: ${results.summary.newAgentsDiscovered} new agents discovered, ${results.summary.agentsChecked} agents checked`
-      };
-
-    } catch (error) {
-      if (this.logger) {
-        await this.logger.error('Check agents with discovery failed', { error: error.message });
-      }
-
-      return {
-        success: false,
-        error: error.message,
-        message: 'Check agents with discovery failed'
-      };
-    }
+    return this.discoveryService.checkAgentsWithDiscovery(
+      options,
+      (checkOptions) => this.checkAgents(checkOptions)
+    );
   }
 
   /**

package/src/agents/AgentCheckStatisticsService.js

@@ -0,0 +1,195 @@
+/**
+ * Agent Check Statistics Service
+ * 
+ * Handles statistics and status tracking for agent checks.
+ * Constitutional requirement: <555 lines, test-first approach.
+ */
+
+const { AgentStatus } = require('./AgentStatus');
+
+/**
+ * Agent check statistics service
+ */
+class AgentCheckStatisticsService {
+  /**
+   * Create statistics service instance
+   * @param {Object} config - Service configuration
+   */
+  constructor(config = {}) {
+    this.configManager = config.configManager || null;
+    this.logger = config.logger || null;
+    this.fileManager = config.fileManager || null;
+  }
+
+  /**
+   * Get check operation statistics
+   * @returns {Promise<Object>} - Check statistics
+   */
+  async getCheckStatistics() {
+    try {
+      const agents = this.configManager.getEnabledAgents();
+      
+      const stats = {
+        totalAgents: agents.length,
+        verified: 0,
+        notVerified: 0,
+        error: 0,
+        installing: 0,
+        lastCheck: null,
+        checkRate: 0
+      };
+
+      let latestCheck = null;
+      
+      for (const agent of agents) {
+        const status = await this.configManager.getAgentStatus(agent.id);
+        
+        if (status) {
+          switch (status.status) {
+            case AgentStatus.VERIFIED:
+              stats.verified++;
+              break;
+            case AgentStatus.NOT_INSTALLED:
+            case AgentStatus.INSTALLED:
+              stats.notVerified++;
+              break;
+            case AgentStatus.ERROR:
+              stats.error++;
+              break;
+            case AgentStatus.INSTALLING:
+              stats.installing++;
+              break;
+          }
+          
+          // Track latest check
+          if (status.lastChecked) {
+            const checkDate = new Date(status.lastChecked);
+            if (!latestCheck || checkDate > latestCheck) {
+              latestCheck = status.lastChecked;
+            }
+          }
+        } else {
+          stats.notVerified++;
+        }
+      }
+      
+      stats.lastCheck = latestCheck ? latestCheck.toISOString() : null;
+      
+      // Calculate check rate (agents that have been checked at least once)
+      const checkedAgents = stats.verified + stats.notVerified + stats.error;
+      stats.checkRate = agents.length > 0 ? (checkedAgents / agents.length) * 100 : 0;
+      
+      return stats;
+    } catch (error) {
+      if (this.logger) {
+        await this.logger.error('Failed to get check statistics', {
+          error: error.message
+        });
+      }
+      
+      return {
+        totalAgents: 0,
+        verified: 0,
+        notVerified: 0,
+        error: 0,
+        installing: 0,
+        lastCheck: null,
+        checkRate: 0,
+        error: error.message
+      };
+    }
+  }
+
+  /**
+   * Get detailed agent status
+   * @param {string} agentId - Agent identifier
+   * @returns {Promise<Object>} - Detailed agent status
+   */
+  async getDetailedAgentStatus(agentId) {
+    try {
+      const agent = this.configManager.getAgent(agentId);
+      if (!agent) {
+        return {
+          agentId,
+          found: false,
+          error: 'Agent not found'
+        };
+      }
+
+      const status = await this.configManager.getAgentStatus(agentId);
+      const history = await this.getStatusHistory(agentId, 10);
+      
+      return {
+        agentId,
+        found: true,
+        agent: {
+          id: agent.id,
+          name: agent.name,
+          description: agent.description,
+          enabled: agent.enabled,
+          status: status ? status.status : AgentStatus.NOT_INSTALLED,
+          lastChecked: status ? status.lastChecked : null,
+          lastVerified: status ? status.lastVerified : null,
+          message: status ? status.message : '',
+          installationMethods: agent.installationMethods,
+          verificationCommands: agent.verificationCommands
+        },
+        status,
+        history,
+        canInstall: agent.enabled && status ? status.status === AgentStatus.NOT_INSTALLED : false,
+        canVerify: agent.enabled && status ? [AgentStatus.INSTALLED, AgentStatus.VERIFIED].includes(status.status) : false
+      };
+    } catch (error) {
+      if (this.logger) {
+        await this.logger.error('Failed to get detailed agent status', {
+          agentId,
+          error: error.message
+        });
+      }
+      
+      return {
+        agentId,
+        found: false,
+        error: error.message
+      };
+    }
+  }
+
+  /**
+   * Get status history for an agent
+   * @param {string} agentId - Agent identifier
+   * @param {number} limit - Maximum entries
+   * @returns {Promise<Array>} - Status history
+   */
+  async getStatusHistory(agentId, limit = 50) {
+    try {
+      if (this.fileManager) {
+        const logs = await this.fileManager.readLogs('status-change', { limit });
+        return logs
+          .filter(log => log.agentId === agentId)
+          .slice(-limit)
+          .reverse(); // Most recent first
+      }
+      return [];
+    } catch (error) {
+      if (this.logger) {
+        await this.logger.error('Failed to get status history', {
+          agentId,
+          error: error.message
+        });
+      }
+      return [];
+    }
+  }
+
+  /**
+   * Create statistics service with default configuration
+   * @param {Object} config - Configuration overrides
+   * @returns {AgentCheckStatisticsService} - Service instance
+   */
+  static createDefault(config = {}) {
+    return new AgentCheckStatisticsService(config);
+  }
+}
+
+module.exports = AgentCheckStatisticsService;