vellum 0.2.0 → 0.2.2

package/src/__tests__/task-tools.test.ts

@@ -34,20 +34,21 @@ mock.module('./indexer.js', () => ({
 }));
 
 import type { Database } from 'bun:sqlite';
-import { initializeDb, getDb } from '../memory/db.js';
+import { initializeDb, getDb, resetDb } from '../memory/db.js';
 import { createTask, createTaskRun } from '../tasks/task-store.js';
 import { createWorkItem } from '../work-items/work-item-store.js';
-import { taskSaveTool } from '../tools/tasks/task-save.js';
-import { taskRunTool } from '../tools/tasks/task-run.js';
-import { taskListTool } from '../tools/tasks/task-list.js';
-import { taskListShowTool } from '../tools/tasks/work-item-list.js';
-import { taskListAddTool } from '../tools/tasks/work-item-enqueue.js';
-import { taskDeleteTool } from '../tools/tasks/task-delete.js';
+import { executeTaskSave } from '../tools/tasks/task-save.js';
+import { executeTaskRun } from '../tools/tasks/task-run.js';
+import { executeTaskList } from '../tools/tasks/task-list.js';
+import { executeTaskListShow } from '../tools/tasks/work-item-list.js';
+import { executeTaskListAdd } from '../tools/tasks/work-item-enqueue.js';
+import { executeTaskDelete } from '../tools/tasks/task-delete.js';
 import type { ToolContext } from '../tools/types.js';
 
 initializeDb();
 
 afterAll(() => {
+  resetDb();
   try { rmSync(testDir, { recursive: true }); } catch { /* best effort */ }
 });
 
@@ -104,7 +105,7 @@ describe('task_save tool', () => {
     );
     addTestMessage(convId, 'assistant', 'Here is the summary...');
 
-    const result = await taskSaveTool.execute(
+    const result = await executeTaskSave(
       { conversation_id: convId },
       stubContext,
     );
@@ -120,7 +121,7 @@ describe('task_save tool', () => {
     addTestMessage(convId, 'user', 'Read and analyze the logs');
     addTestMessage(convId, 'assistant', 'Done!');
 
-    const result = await taskSaveTool.execute(
+    const result = await executeTaskSave(
       { conversation_id: convId, title: 'My Custom Title' },
       stubContext,
     );
@@ -134,7 +135,7 @@ describe('task_save tool', () => {
     addTestMessage(convId, 'user', 'Summarize the report');
     addTestMessage(convId, 'assistant', 'Done.');
 
-    const result = await taskSaveTool.execute({}, stubContext);
+    const result = await executeTaskSave({}, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Task saved successfully');
@@ -142,7 +143,7 @@ describe('task_save tool', () => {
   });
 
   test('returns error for nonexistent conversation', async () => {
-    const result = await taskSaveTool.execute(
+    const result = await executeTaskSave(
       { conversation_id: 'nonexistent' },
       stubContext,
     );
@@ -171,7 +172,7 @@ describe('task_run tool', () => {
       requiredTools: ['file_read'],
     });
 
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       { task_name: 'summarize', inputs: { file_path: '/tmp/report.txt' } },
       stubContext,
     );
@@ -188,7 +189,7 @@ describe('task_run tool', () => {
       inputSchema: { type: 'object', properties: { url: { type: 'string', description: 'URL' } } },
     });
 
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       { task_id: task.id, inputs: { url: 'https://prod.example.com' } },
       stubContext,
     );
@@ -204,7 +205,7 @@ describe('task_run tool', () => {
       template: 'Do something',
     });
 
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       { task_name: 'nonexistent' },
       stubContext,
     );
@@ -215,13 +216,13 @@ describe('task_run tool', () => {
   });
 
   test('returns error when task not found by ID', async () => {
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       { task_id: 'bad-id' },
       stubContext,
     );
 
     expect(result.isError).toBe(true);
-    expect(result.content).toContain('No task found with ID "bad-id"');
+    expect(result.content).toContain('No task template found with ID "bad-id"');
   });
 
   test('renders template with inputs', async () => {
@@ -237,7 +238,7 @@ describe('task_run tool', () => {
       },
     });
 
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       {
         task_name: 'multi-input',
         inputs: { file_path: '/home/user/data.csv', url: 'https://api.example.com/upload' },
@@ -259,7 +260,7 @@ describe('task_run tool', () => {
       },
     });
 
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       { task_name: 'input required' },
       stubContext,
     );
@@ -269,14 +270,14 @@ describe('task_run tool', () => {
   });
 
   test('returns error when neither task_name nor task_id provided', async () => {
-    const result = await taskRunTool.execute({}, stubContext);
+    const result = await executeTaskRun({}, stubContext);
 
     expect(result.isError).toBe(true);
     expect(result.content).toContain('At least one of task_name or task_id must be provided');
   });
 
   test('returns error with helpful message when no tasks exist', async () => {
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       { task_name: 'anything' },
       stubContext,
     );
@@ -292,7 +293,7 @@ describe('task_run tool', () => {
       requiredTools: ['file_read', 'bash'],
     });
 
-    const result = await taskRunTool.execute(
+    const result = await executeTaskRun(
       { task_name: 'tools' },
       stubContext,
     );
@@ -329,7 +330,7 @@ describe('task_list tool', () => {
       requiredTools: ['file_read', 'file_write'],
     });
 
-    const result = await taskListTool.execute({}, stubContext);
+    const result = await executeTaskList({}, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Found 2 task template(s)');
@@ -342,7 +343,7 @@ describe('task_list tool', () => {
   });
 
   test('returns empty message when no tasks exist', async () => {
-    const result = await taskListTool.execute({}, stubContext);
+    const result = await executeTaskList({}, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('No task templates found');
@@ -355,7 +356,7 @@ describe('task_list tool', () => {
       template: 'Something',
     });
 
-    const result = await taskListTool.execute({}, stubContext);
+    const result = await executeTaskList({}, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Status: active');
@@ -378,21 +379,17 @@ describe('task_list_show tool', () => {
     createWorkItem({ taskId: task.id, title: 'Work Item Alpha', priorityTier: 0 });
     createWorkItem({ taskId: task.id, title: 'Work Item Beta', notes: 'some notes', priorityTier: 1 });
 
-    const result = await taskListShowTool.execute({}, stubContext);
+    const result = await executeTaskListShow({}, stubContext);
 
     expect(result.isError).toBe(false);
-    expect(result.content).toContain('Found 2 work item(s)');
-    expect(result.content).toContain('Work Item Alpha');
-    expect(result.content).toContain('Work Item Beta');
-    expect(result.content).toContain('Status: queued');
-    expect(result.content).toContain('Notes: some notes');
+    expect(result.content).toContain('Opened Tasks window (2 items)');
   });
 
   test('returns empty message when no work items', async () => {
-    const result = await taskListShowTool.execute({}, stubContext);
+    const result = await executeTaskListShow({}, stubContext);
 
     expect(result.isError).toBe(false);
-    expect(result.content).toContain('No Tasks found');
+    expect(result.content).toContain('no tasks queued');
   });
 
   test('filters by status when status param is provided', async () => {
@@ -403,17 +400,13 @@ describe('task_list_show tool', () => {
     const doneItem = createWorkItem({ taskId: task.id, title: 'Done Item', priorityTier: 1 });
     raw.query('UPDATE work_items SET status = ? WHERE id = ?').run('done', doneItem.id);
 
-    const resultQueued = await taskListShowTool.execute({ status: 'queued' }, stubContext);
+    const resultQueued = await executeTaskListShow({ status: 'queued' }, stubContext);
     expect(resultQueued.isError).toBe(false);
-    expect(resultQueued.content).toContain('Found 1 work item(s)');
-    expect(resultQueued.content).toContain('Queued Item');
-    expect(resultQueued.content).not.toContain('Done Item');
+    expect(resultQueued.content).toContain('1 queued item');
 
-    const resultDone = await taskListShowTool.execute({ status: 'done' }, stubContext);
+    const resultDone = await executeTaskListShow({ status: 'done' }, stubContext);
     expect(resultDone.isError).toBe(false);
-    expect(resultDone.content).toContain('Found 1 work item(s)');
-    expect(resultDone.content).toContain('Done Item');
-    expect(resultDone.content).not.toContain('Queued Item');
+    expect(resultDone.content).toContain('1 done item');
   });
 });
 
@@ -430,7 +423,7 @@ describe('task_list_add tool', () => {
   test('successfully enqueues by task_id', async () => {
     const task = createTask({ title: 'Deploy Service', template: 'deploy it' });
 
-    const result = await taskListAddTool.execute({ task_id: task.id }, stubContext);
+    const result = await executeTaskListAdd({ task_id: task.id }, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Enqueued work item');
@@ -441,7 +434,7 @@ describe('task_list_add tool', () => {
   test('successfully enqueues by task_name (case-insensitive match)', async () => {
     createTask({ title: 'Run Database Migration', template: 'migrate' });
 
-    const result = await taskListAddTool.execute({ task_name: 'database migration' }, stubContext);
+    const result = await executeTaskListAdd({ task_name: 'database migration' }, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Enqueued work item');
@@ -452,7 +445,7 @@ describe('task_list_add tool', () => {
     createTask({ title: 'Deploy Frontend', template: 'deploy fe' });
     createTask({ title: 'Deploy Backend', template: 'deploy be' });
 
-    const result = await taskListAddTool.execute({ task_name: 'deploy' }, stubContext);
+    const result = await executeTaskListAdd({ task_name: 'deploy' }, stubContext);
 
     expect(result.isError).toBe(true);
     expect(result.content).toContain('Multiple task definitions match');
@@ -463,21 +456,21 @@ describe('task_list_add tool', () => {
   test('returns error when no matching task found', async () => {
     createTask({ title: 'Existing Task', template: 'do something' });
 
-    const result = await taskListAddTool.execute({ task_name: 'nonexistent' }, stubContext);
+    const result = await executeTaskListAdd({ task_name: 'nonexistent' }, stubContext);
 
     expect(result.isError).toBe(true);
     expect(result.content).toContain('No task definition found matching "nonexistent"');
   });
 
   test('returns error when no identifiers provided at all', async () => {
-    const result = await taskListAddTool.execute({}, stubContext);
+    const result = await executeTaskListAdd({}, stubContext);
 
     expect(result.isError).toBe(true);
     expect(result.content).toContain('You must provide either task_id, task_name, or title');
   });
 
   test('creates ad-hoc work item with just title (no task_id or task_name)', async () => {
-    const result = await taskListAddTool.execute(
+    const result = await executeTaskListAdd(
       { title: 'Check Gmail' },
       stubContext,
     );
@@ -491,7 +484,7 @@ describe('task_list_add tool', () => {
   });
 
   test('ad-hoc work item with notes and priority', async () => {
-    const result = await taskListAddTool.execute(
+    const result = await executeTaskListAdd(
       {
         title: 'Buy groceries',
         notes: 'Milk, eggs, bread',
@@ -507,21 +500,21 @@ describe('task_list_add tool', () => {
   });
 
   test('ad-hoc work item shows up in task_list_show', async () => {
-    await taskListAddTool.execute(
+    await executeTaskListAdd(
       { title: 'Call dentist' },
       stubContext,
     );
 
-    const listResult = await taskListShowTool.execute({}, stubContext);
+    const listResult = await executeTaskListShow({}, stubContext);
 
     expect(listResult.isError).toBe(false);
-    expect(listResult.content).toContain('Call dentist');
+    expect(listResult.content).toContain('Opened Tasks window (1 item)');
   });
 
   test('applies optional overrides (title, notes, priority_tier)', async () => {
     const task = createTask({ title: 'Generic Task', template: 'do it' });
 
-    const result = await taskListAddTool.execute(
+    const result = await executeTaskListAdd(
       {
         task_id: task.id,
         title: 'Custom Title Override',
@@ -551,7 +544,7 @@ describe('task_delete tool', () => {
   test('successfully deletes a single task', async () => {
     const task = createTask({ title: 'Doomed Task', template: 'bye' });
 
-    const result = await taskDeleteTool.execute({ task_ids: [task.id] }, stubContext);
+    const result = await executeTaskDelete({ task_ids: [task.id] }, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Deleted task: Doomed Task');
@@ -561,7 +554,7 @@ describe('task_delete tool', () => {
     const t1 = createTask({ title: 'Task One', template: 'one' });
     const t2 = createTask({ title: 'Task Two', template: 'two' });
 
-    const result = await taskDeleteTool.execute({ task_ids: [t1.id, t2.id] }, stubContext);
+    const result = await executeTaskDelete({ task_ids: [t1.id, t2.id] }, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Deleted 2 task(s)');
@@ -570,10 +563,10 @@ describe('task_delete tool', () => {
   });
 
   test('returns error for non-existent task ID', async () => {
-    const result = await taskDeleteTool.execute({ task_ids: ['nonexistent-id'] }, stubContext);
+    const result = await executeTaskDelete({ task_ids: ['nonexistent-id'] }, stubContext);
 
     expect(result.isError).toBe(true);
-    expect(result.content).toContain('No task found with ID nonexistent-id');
+    expect(result.content).toContain('No task template or work item found with ID "nonexistent-id"');
   });
 
   test('cascades deletion to associated task runs and work items', async () => {
@@ -588,7 +581,7 @@ describe('task_delete tool', () => {
     expect(runsBefore.count).toBe(1);
     expect(itemsBefore.count).toBe(1);
 
-    const result = await taskDeleteTool.execute({ task_ids: [task.id] }, stubContext);
+    const result = await executeTaskDelete({ task_ids: [task.id] }, stubContext);
 
     expect(result.isError).toBe(false);
     expect(result.content).toContain('Deleted task: Parent Task');

package/src/__tests__/tool-audit-listener.test.ts

@@ -103,6 +103,7 @@ describe('tool audit listener', () => {
       durationMs: 9,
       errorMessage: 'boom',
       isExpected: false,
+      errorCategory: 'tool_failure',
     });
 
     expect(records).toHaveLength(1);

package/src/__tests__/tool-domain-event-publisher.test.ts

@@ -190,6 +190,7 @@ describe('createToolDomainEventPublisher', () => {
       durationMs: 12,
       errorMessage: 'cat: /missing: No such file or directory',
       isExpected: false,
+      errorCategory: 'tool_failure',
       errorName: 'Error',
       errorStack: 'Error: cat: /missing: No such file or directory',
     });
@@ -229,6 +230,7 @@ describe('createToolDomainEventPublisher', () => {
       durationMs: 9,
       errorMessage: 'ENOENT',
       isExpected: false,
+      errorCategory: 'tool_failure',
       errorName: 'Error',
       errorStack: 'Error: ENOENT\n    at test',
     });