vellum 0.2.0 → 0.2.2

package/src/__tests__/asset-materialize-tool.test.ts

@@ -36,7 +36,7 @@ mock.module('../config/loader.js', () => ({
   }),
 }));
 
-import { initializeDb, getDb } from '../memory/db.js';
+import { initializeDb, getDb, resetDb } from '../memory/db.js';
 import { uploadAttachment, linkAttachmentToMessage } from '../memory/attachments-store.js';
 import { createConversation, addMessage } from '../memory/conversation-store.js';
 import { assetMaterializeTool } from '../tools/assets/materialize.js';
@@ -49,6 +49,7 @@ import { mkdirSync } from 'node:fs';
 mkdirSync(sandboxDir, { recursive: true });
 
 afterAll(() => {
+  resetDb();
   try { rmSync(testDir, { recursive: true }); } catch { /* best effort */ }
 });
 
@@ -103,7 +104,7 @@ describe('AssetMaterializeTool sandbox path enforcement', () => {
   beforeEach(resetTables);
 
   test('rejects path that escapes sandbox via ../', async () => {
-    const stored = uploadAttachment('ast-1', 'test.png', 'image/png', 'AAAA');
+    const stored = uploadAttachment('test.png', 'image/png', 'AAAA');
     const result = await assetMaterializeTool.execute(
       { attachment_id: stored.id, destination_path: '../../etc/evil.png' },
       dummyContext,
@@ -113,7 +114,7 @@ describe('AssetMaterializeTool sandbox path enforcement', () => {
   });
 
   test('rejects absolute path outside sandbox', async () => {
-    const stored = uploadAttachment('ast-1', 'test.png', 'image/png', 'AAAA');
+    const stored = uploadAttachment('test.png', 'image/png', 'AAAA');
     const result = await assetMaterializeTool.execute(
       { attachment_id: stored.id, destination_path: '/tmp/outside-sandbox/evil.png' },
       dummyContext,
@@ -123,7 +124,7 @@ describe('AssetMaterializeTool sandbox path enforcement', () => {
   });
 
   test('accepts relative path inside sandbox', async () => {
-    const stored = uploadAttachment('ast-1', 'test.png', 'image/png', 'AAAA');
+    const stored = uploadAttachment('test.png', 'image/png', 'AAAA');
     const result = await assetMaterializeTool.execute(
       { attachment_id: stored.id, destination_path: 'output.png' },
       dummyContext,
@@ -133,7 +134,7 @@ describe('AssetMaterializeTool sandbox path enforcement', () => {
   });
 
   test('accepts nested path inside sandbox with auto-created subdirs', async () => {
-    const stored = uploadAttachment('ast-1', 'test.png', 'image/png', 'AAAA');
+    const stored = uploadAttachment('test.png', 'image/png', 'AAAA');
     const result = await assetMaterializeTool.execute(
       { attachment_id: stored.id, destination_path: 'subdir/deep/output.png' },
       dummyContext,
@@ -172,7 +173,7 @@ describe('AssetMaterializeTool materialization', () => {
     const originalContent = 'Hello, World!';
     const base64Content = Buffer.from(originalContent).toString('base64');
 
-    const stored = uploadAttachment('ast-1', 'hello.txt', 'text/plain', base64Content);
+    const stored = uploadAttachment('hello.txt', 'text/plain', base64Content);
 
     const destPath = 'materialized-hello.txt';
     const result = await assetMaterializeTool.execute(
@@ -194,7 +195,7 @@ describe('AssetMaterializeTool materialization', () => {
     const binaryBytes = Buffer.from([0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A]);
     const base64Content = binaryBytes.toString('base64');
 
-    const stored = uploadAttachment('ast-1', 'tiny.png', 'image/png', base64Content);
+    const stored = uploadAttachment('tiny.png', 'image/png', base64Content);
 
     const result = await assetMaterializeTool.execute(
       { attachment_id: stored.id, destination_path: 'images/tiny.png' },
@@ -209,7 +210,7 @@ describe('AssetMaterializeTool materialization', () => {
 
   test('result includes resolved path', async () => {
     const base64Content = Buffer.from('test').toString('base64');
-    const stored = uploadAttachment('ast-1', 'doc.txt', 'text/plain', base64Content);
+    const stored = uploadAttachment('doc.txt', 'text/plain', base64Content);
 
     const result = await assetMaterializeTool.execute(
       { attachment_id: stored.id, destination_path: 'output/doc.txt' },
@@ -222,7 +223,7 @@ describe('AssetMaterializeTool materialization', () => {
 
   test('result includes filename, MIME type and size info', async () => {
     const base64Content = Buffer.from('some data here').toString('base64');
-    const stored = uploadAttachment('ast-1', 'report.pdf', 'application/pdf', base64Content);
+    const stored = uploadAttachment('report.pdf', 'application/pdf', base64Content);
 
     const result = await assetMaterializeTool.execute(
       { attachment_id: stored.id, destination_path: 'report.pdf' },
@@ -307,7 +308,7 @@ describe('AssetMaterializeTool visibility policy', () => {
   test('materializing from a standard thread works from any context', async () => {
     const standardConv = createConversation({ title: 'standard-conv' });
     const base64Content = Buffer.from('standard content').toString('base64');
-    const attachment = uploadAttachment('ast-1', 'public.txt', 'text/plain', base64Content);
+    const attachment = uploadAttachment('public.txt', 'text/plain', base64Content);
     const msg = addMessage(standardConv.id, 'user', 'standard message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -330,7 +331,7 @@ describe('AssetMaterializeTool visibility policy', () => {
   test('materializing from a private thread works within the same private thread', async () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
     const base64Content = Buffer.from('private content').toString('base64');
-    const attachment = uploadAttachment('ast-1', 'secret.txt', 'text/plain', base64Content);
+    const attachment = uploadAttachment('secret.txt', 'text/plain', base64Content);
     const msg = addMessage(privateConv.id, 'user', 'private message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -352,7 +353,7 @@ describe('AssetMaterializeTool visibility policy', () => {
   test('materializing from a private thread is REJECTED from a different conversation', async () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
     const base64Content = Buffer.from('private content').toString('base64');
-    const attachment = uploadAttachment('ast-1', 'secret.txt', 'text/plain', base64Content);
+    const attachment = uploadAttachment('secret.txt', 'text/plain', base64Content);
     const msg = addMessage(privateConv.id, 'user', 'private message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -376,7 +377,7 @@ describe('AssetMaterializeTool visibility policy', () => {
   test('error message is user-actionable', async () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
     const base64Content = Buffer.from('private content').toString('base64');
-    const attachment = uploadAttachment('ast-1', 'confidential.pdf', 'application/pdf', base64Content);
+    const attachment = uploadAttachment('confidential.pdf', 'application/pdf', base64Content);
     const msg = addMessage(privateConv.id, 'user', 'private message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -402,7 +403,7 @@ describe('AssetMaterializeTool visibility policy', () => {
   test('materializing from a different private thread is REJECTED', async () => {
     const privateConv1 = createConversation({ title: 'private-conv-1', threadType: 'private' });
     const base64Content = Buffer.from('private content').toString('base64');
-    const attachment = uploadAttachment('ast-1', 'secret.txt', 'text/plain', base64Content);
+    const attachment = uploadAttachment('secret.txt', 'text/plain', base64Content);
     const msg = addMessage(privateConv1.id, 'user', 'private message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -426,7 +427,7 @@ describe('AssetMaterializeTool visibility policy', () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
     const standardConv = createConversation({ title: 'standard-conv' });
     const base64Content = Buffer.from('shared content').toString('base64');
-    const attachment = uploadAttachment('ast-1', 'shared.txt', 'text/plain', base64Content);
+    const attachment = uploadAttachment('shared.txt', 'text/plain', base64Content);
 
     const msg1 = addMessage(privateConv.id, 'user', 'private message');
     const msg2 = addMessage(standardConv.id, 'user', 'standard message');

package/src/__tests__/asset-search-tool.test.ts

@@ -35,7 +35,7 @@ mock.module('../config/loader.js', () => ({
   }),
 }));
 
-import { initializeDb, getDb } from '../memory/db.js';
+import { initializeDb, getDb, resetDb } from '../memory/db.js';
 import { uploadAttachment, linkAttachmentToMessage } from '../memory/attachments-store.js';
 import { createConversation, addMessage } from '../memory/conversation-store.js';
 import { searchAttachments } from '../tools/assets/search.js';
@@ -45,6 +45,7 @@ import type { ToolContext } from '../tools/types.js';
 initializeDb();
 
 afterAll(() => {
+  resetDb();
   try { rmSync(testDir, { recursive: true }); } catch { /* best effort */ }
 });
 
@@ -66,10 +67,10 @@ function seedAttachments() {
   // Force createdAt by uploading then manipulating the DB
   const db = getDb();
 
-  const png1 = uploadAttachment('ast-1', 'selfie.png', 'image/png', 'AAAA');
-  const jpg1 = uploadAttachment('ast-1', 'photo.jpg', 'image/jpeg', 'BBBB');
-  const pdf1 = uploadAttachment('ast-1', 'report.pdf', 'application/pdf', 'CCCC');
-  const png2 = uploadAttachment('ast-1', 'screenshot.png', 'image/png', 'DDDD');
+  const png1 = uploadAttachment('selfie.png', 'image/png', 'AAAA');
+  const jpg1 = uploadAttachment('photo.jpg', 'image/jpeg', 'BBBB');
+  const pdf1 = uploadAttachment('report.pdf', 'application/pdf', 'CCCC');
+  const png2 = uploadAttachment('screenshot.png', 'image/png', 'DDDD');
 
   // Backdate some attachments for recency testing
   db.run(`UPDATE attachments SET created_at = ${oneDayAgo} WHERE id = '${jpg1.id}'`);
@@ -217,8 +218,8 @@ describe('searchAttachments with conversation_id', () => {
   beforeEach(resetTables);
 
   test('returns only attachments linked to the specified conversation', () => {
-    const png1 = uploadAttachment('ast-1', 'in-conv.png', 'image/png', 'AAAA');
-    const png2 = uploadAttachment('ast-1', 'other-conv.png', 'image/png', 'BBBB');
+    const png1 = uploadAttachment('in-conv.png', 'image/png', 'AAAA');
+    const png2 = uploadAttachment('other-conv.png', 'image/png', 'BBBB');
 
     const conv1 = createConversation();
     const conv2 = createConversation();
@@ -234,7 +235,7 @@ describe('searchAttachments with conversation_id', () => {
   });
 
   test('returns empty when conversation has no attachments', () => {
-    uploadAttachment('ast-1', 'orphan.png', 'image/png', 'AAAA');
+    uploadAttachment('orphan.png', 'image/png', 'AAAA');
     const conv = createConversation();
     addMessage(conv.id, 'user', 'No attachments here');
 
@@ -243,14 +244,14 @@ describe('searchAttachments with conversation_id', () => {
   });
 
   test('returns empty for nonexistent conversation_id', () => {
-    uploadAttachment('ast-1', 'file.png', 'image/png', 'AAAA');
+    uploadAttachment('file.png', 'image/png', 'AAAA');
     const results = searchAttachments({ conversation_id: 'conv-nonexistent' });
     expect(results.length).toBe(0);
   });
 
   test('combines conversation_id with mime_type filter', () => {
-    const png = uploadAttachment('ast-1', 'image.png', 'image/png', 'AAAA');
-    const pdf = uploadAttachment('ast-1', 'doc.pdf', 'application/pdf', 'BBBB');
+    const png = uploadAttachment('image.png', 'image/png', 'AAAA');
+    const pdf = uploadAttachment('doc.pdf', 'application/pdf', 'BBBB');
 
     const conv = createConversation();
     const msg = addMessage(conv.id, 'user', 'Both types');
@@ -264,8 +265,8 @@ describe('searchAttachments with conversation_id', () => {
   });
 
   test('combines conversation_id with filename filter', () => {
-    const a = uploadAttachment('ast-1', 'target.png', 'image/png', 'AAAA');
-    const b = uploadAttachment('ast-1', 'other.png', 'image/png', 'BBBB');
+    const a = uploadAttachment('target.png', 'image/png', 'AAAA');
+    const b = uploadAttachment('other.png', 'image/png', 'BBBB');
 
     const conv = createConversation();
     const msg = addMessage(conv.id, 'user', 'Both');
@@ -294,7 +295,7 @@ describe('AssetSearchTool.execute', () => {
   });
 
   test('returns formatted results for matching assets', async () => {
-    uploadAttachment('ast-1', 'selfie.png', 'image/png', 'AAAA');
+    uploadAttachment('selfie.png', 'image/png', 'AAAA');
     const result = await tool.execute({}, dummyContext);
     expect(result.isError).toBe(false);
     expect(result.content).toContain('selfie.png');
@@ -320,14 +321,14 @@ describe('AssetSearchTool.execute', () => {
   });
 
   test('includes attachment ID in output', async () => {
-    const stored = uploadAttachment('ast-1', 'chart.png', 'image/png', 'AAAA');
+    const stored = uploadAttachment('chart.png', 'image/png', 'AAAA');
     const result = await tool.execute({}, dummyContext);
     expect(result.isError).toBe(false);
     expect(result.content).toContain(stored.id);
   });
 
   test('includes MIME type and kind in output', async () => {
-    uploadAttachment('ast-1', 'chart.png', 'image/png', 'AAAA');
+    uploadAttachment('chart.png', 'image/png', 'AAAA');
     const result = await tool.execute({}, dummyContext);
     expect(result.isError).toBe(false);
     expect(result.content).toContain('image/png');
@@ -363,7 +364,7 @@ describe('AssetSearchTool visibility policy', () => {
 
   test('attachments from standard threads are visible from any context', async () => {
     const standardConv = createConversation({ title: 'standard-conv' });
-    const attachment = uploadAttachment('ast-1', 'public.png', 'image/png', 'AAAA');
+    const attachment = uploadAttachment('public.png', 'image/png', 'AAAA');
     const msg = addMessage(standardConv.id, 'user', 'standard message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -382,7 +383,7 @@ describe('AssetSearchTool visibility policy', () => {
 
   test('attachments from private threads are visible within the same private thread', async () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
-    const attachment = uploadAttachment('ast-1', 'secret.png', 'image/png', 'AAAA');
+    const attachment = uploadAttachment('secret.png', 'image/png', 'AAAA');
     const msg = addMessage(privateConv.id, 'user', 'private message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -400,7 +401,7 @@ describe('AssetSearchTool visibility policy', () => {
 
   test('attachments from private threads are NOT visible from a different conversation', async () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
-    const attachment = uploadAttachment('ast-1', 'secret.png', 'image/png', 'AAAA');
+    const attachment = uploadAttachment('secret.png', 'image/png', 'AAAA');
     const msg = addMessage(privateConv.id, 'user', 'private message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -419,7 +420,7 @@ describe('AssetSearchTool visibility policy', () => {
 
   test('attachments from private threads are NOT visible from standard threads', async () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
-    const attachment = uploadAttachment('ast-1', 'secret.png', 'image/png', 'AAAA');
+    const attachment = uploadAttachment('secret.png', 'image/png', 'AAAA');
     const msg = addMessage(privateConv.id, 'user', 'private message');
     linkAttachmentToMessage(msg.id, attachment.id, 0);
 
@@ -439,7 +440,7 @@ describe('AssetSearchTool visibility policy', () => {
   test('attachment linked to both private and standard threads is visible everywhere', async () => {
     const privateConv = createConversation({ title: 'private-conv', threadType: 'private' });
     const standardConv = createConversation({ title: 'standard-conv' });
-    const attachment = uploadAttachment('ast-1', 'shared.png', 'image/png', 'AAAA');
+    const attachment = uploadAttachment('shared.png', 'image/png', 'AAAA');
 
     const msg1 = addMessage(privateConv.id, 'user', 'private message');
     const msg2 = addMessage(standardConv.id, 'user', 'standard message');
@@ -460,7 +461,7 @@ describe('AssetSearchTool visibility policy', () => {
   });
 
   test('orphan attachments (no message linkage) remain visible', async () => {
-    uploadAttachment('ast-1', 'orphan.png', 'image/png', 'AAAA');
+    uploadAttachment('orphan.png', 'image/png', 'AAAA');
 
     const conv = createConversation({ title: 'any-conv' });
     const context: ToolContext = {