vellum 0.2.0 → 0.2.2

package/src/__tests__/runtime-attachment-metadata.test.ts

@@ -34,7 +34,7 @@ mock.module('../config/loader.js', () => ({
   }),
 }));
 
-import { initializeDb, getDb } from '../memory/db.js';
+import { initializeDb, getDb, resetDb } from '../memory/db.js';
 import * as conversationStore from '../memory/conversation-store.js';
 import { getOrCreateConversation } from '../memory/conversation-key-store.js';
 import {
@@ -46,6 +46,7 @@ import { RuntimeHttpServer } from '../runtime/http-server.js';
 initializeDb();
 
 afterAll(() => {
+  resetDb();
   try { rmSync(testDir, { recursive: true }); } catch { /* best effort */ }
 });
 
@@ -79,11 +80,10 @@ describe('Runtime attachment metadata', () => {
   });
 
   test('GET /messages includes attachment metadata for assistant messages', async () => {
-    const assistantId = 'ast-test-1';
     const conversationKey = 'test-conv-1';
 
-    // Set up conversation and messages
-    const mapping = getOrCreateConversation(assistantId, conversationKey);
+    // Set up conversation and messages using "self" as the assistantId
+    const mapping = getOrCreateConversation(conversationKey);
     conversationStore.addMessage(mapping.conversationId, 'user', 'Hello');
     const assistantMsg = conversationStore.addMessage(
       mapping.conversationId,
@@ -91,12 +91,12 @@ describe('Runtime attachment metadata', () => {
       JSON.stringify([{ type: 'text', text: 'Here is a chart' }]),
     );
 
-    // Upload and link an attachment
-    const stored = uploadAttachment(assistantId, 'chart.png', 'image/png', 'iVBOR');
+    // Upload and link an attachment using "self" as the assistantId
+    const stored = uploadAttachment('chart.png', 'image/png', 'iVBOR');
     linkAttachmentToMessage(assistantMsg.id, stored.id, 0);
 
     const res = await fetch(
-      `http://127.0.0.1:${port}/v1/assistants/${assistantId}/messages?conversationKey=${conversationKey}`,
+      `http://127.0.0.1:${port}/v1/messages?conversationKey=${conversationKey}`,
       { headers: AUTH_HEADERS },
     );
     const body = await res.json() as { messages: Array<{ role: string; content: string; attachments: Array<{ id: string; filename: string; mimeType: string; sizeBytes: number; kind: string }> }> };
@@ -120,10 +120,9 @@ describe('Runtime attachment metadata', () => {
   });
 
   test('GET /messages returns empty attachments when none linked', async () => {
-    const assistantId = 'ast-test-2';
     const conversationKey = 'test-conv-2';
 
-    const mapping = getOrCreateConversation(assistantId, conversationKey);
+    const mapping = getOrCreateConversation(conversationKey);
     conversationStore.addMessage(mapping.conversationId, 'user', 'Hello');
     conversationStore.addMessage(
       mapping.conversationId,
@@ -132,7 +131,7 @@ describe('Runtime attachment metadata', () => {
     );
 
     const res = await fetch(
-      `http://127.0.0.1:${port}/v1/assistants/${assistantId}/messages?conversationKey=${conversationKey}`,
+      `http://127.0.0.1:${port}/v1/messages?conversationKey=${conversationKey}`,
       { headers: AUTH_HEADERS },
     );
     const body = await res.json() as { messages: Array<{ role: string; attachments: unknown[] }> };
@@ -144,11 +143,10 @@ describe('Runtime attachment metadata', () => {
   });
 
   test('GET /attachments/:id returns attachment with payload', async () => {
-    const assistantId = 'ast-test-3';
-    const stored = uploadAttachment(assistantId, 'report.pdf', 'application/pdf', 'JVBER');
+    const stored = uploadAttachment('report.pdf', 'application/pdf', 'JVBER');
 
     const res = await fetch(
-      `http://127.0.0.1:${port}/v1/assistants/${assistantId}/attachments/${stored.id}`,
+      `http://127.0.0.1:${port}/v1/attachments/${stored.id}`,
       { headers: AUTH_HEADERS },
     );
     const body = await res.json() as {
@@ -164,22 +162,23 @@ describe('Runtime attachment metadata', () => {
     expect(body.sizeBytes).toBeGreaterThan(0);
   });
 
-  test('GET /attachments/:id returns 404 for wrong assistant', async () => {
-    const stored = uploadAttachment('ast-owner', 'secret.txt', 'text/plain', 'c2VjcmV0');
+  test('GET /attachments/:id returns attachment stored under "self"', async () => {
+    const stored = uploadAttachment('shared.txt', 'text/plain', 'c2hhcmVk');
 
     const res = await fetch(
-      `http://127.0.0.1:${port}/v1/assistants/ast-other/attachments/${stored.id}`,
+      `http://127.0.0.1:${port}/v1/attachments/${stored.id}`,
       { headers: AUTH_HEADERS },
     );
-    const body = await res.json() as { error: string };
+    const body = await res.json() as { id: string; filename: string };
 
-    expect(res.status).toBe(404);
-    expect(body.error).toBe('Attachment not found');
+    expect(res.status).toBe(200);
+    expect(body.id).toBe(stored.id);
+    expect(body.filename).toBe('shared.txt');
   });
 
   test('GET /attachments/:id returns 404 for nonexistent attachment', async () => {
     const res = await fetch(
-      `http://127.0.0.1:${port}/v1/assistants/ast-test-4/attachments/nonexistent-id`,
+      `http://127.0.0.1:${port}/v1/attachments/nonexistent-id`,
       { headers: AUTH_HEADERS },
     );
     const body = await res.json() as { error: string };

package/src/__tests__/runtime-runs-http.test.ts

@@ -58,7 +58,7 @@ function makeCompletingSession(): Session {
   return {
     isProcessing: () => processing,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
@@ -73,7 +73,7 @@ function makeFailingSession(errorMsg: string): Session {
   return {
     isProcessing: () => false,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: () => {},
     runAgentLoop: async (_content: string, _messageId: string, onEvent: (msg: ServerMessage) => void) => {
       onEvent({ type: 'error', message: errorMsg });
@@ -87,7 +87,7 @@ function makeConfirmationSession(toolName: string): Session {
   return {
     isProcessing: () => false,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: (handler: (msg: ServerMessage) => void) => {
       clientHandler = handler;
     },
@@ -113,7 +113,7 @@ function makeHangingSession(): Session {
   return {
     isProcessing: () => processing,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
@@ -127,7 +127,6 @@ function makeHangingSession(): Session {
 // Tests
 // ---------------------------------------------------------------------------
 
-const ASSISTANT_ID = 'ast-run-http';
 const TEST_TOKEN = 'test-bearer-token-runs';
 const AUTH_HEADERS = { Authorization: `Bearer ${TEST_TOKEN}` };
 
@@ -164,7 +163,7 @@ describe('runtime runs — HTTP layer', () => {
   }
 
   function runsUrl(path = ''): string {
-    return `http://127.0.0.1:${port}/v1/assistants/${ASSISTANT_ID}/runs${path}`;
+    return `http://127.0.0.1:${port}/v1/runs${path}`;
   }
 
   // ── Auth ────────────────────────────────────────────────────────────
@@ -363,23 +362,6 @@ describe('runtime runs — HTTP layer', () => {
     await stopServer();
   });
 
-  test('GET /runs/:id returns 404 for different assistant', async () => {
-    await startServer(() => makeCompletingSession());
-
-    const createRes = await fetch(runsUrl(), {
-      method: 'POST',
-      headers: { 'Content-Type': 'application/json', ...AUTH_HEADERS },
-      body: JSON.stringify({ conversationKey: 'conv-scope', content: 'Test' }),
-    });
-    const { id } = await createRes.json() as { id: string };
-
-    // Try to access via a different assistant
-    const res = await fetch(`http://127.0.0.1:${port}/v1/assistants/other-assistant/runs/${id}`, { headers: AUTH_HEADERS });
-    expect(res.status).toBe(404);
-
-    await stopServer();
-  });
-
   // ── POST /runs/:id/decision ─────────────────────────────────────────
 
   test('POST /runs/:id/decision returns accepted for pending confirmation', async () => {

package/src/__tests__/runtime-runs.test.ts

@@ -48,7 +48,7 @@ function makeCompletingSession(): Session {
   return {
     isProcessing: () => processing,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
@@ -66,7 +66,7 @@ function makeHangingSession(): Session {
   return {
     isProcessing: () => processing,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
@@ -82,7 +82,7 @@ function makeFailingSession(errorMsg: string): Session {
   return {
     isProcessing: () => false,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: () => {},
     runAgentLoop: async (_content: string, _messageId: string, onEvent: (msg: ServerMessage) => void) => {
       onEvent({ type: 'error', message: errorMsg });
@@ -97,7 +97,7 @@ function makeConfirmationSession(toolName: string, principal?: { kind?: string;
   return {
     isProcessing: () => false,
     persistUserMessage: () => undefined as unknown as string,
-    setAssistantId: () => {},
+    setChannelCapabilities: () => {},
     updateClient: (handler: (msg: ServerMessage) => void) => {
       clientHandler = handler;
     },
@@ -145,7 +145,7 @@ describe('runtime runs — swarm lifecycle', () => {
       resolveAttachments: () => [],
     });
 
-    const run = await orchestrator.startRun('assistant-1', conversation.id, 'Build a feature');
+    const run = await orchestrator.startRun(conversation.id, 'Build a feature');
     expect(run.status).toBe('running');
 
     // Wait for agent loop to complete
@@ -162,7 +162,7 @@ describe('runtime runs — swarm lifecycle', () => {
       resolveAttachments: () => [],
     });
 
-    const run = await orchestrator.startRun('assistant-1', conversation.id, 'Run swarm');
+    const run = await orchestrator.startRun(conversation.id, 'Run swarm');
 
     await new Promise((r) => setTimeout(r, 50));
 
@@ -178,7 +178,7 @@ describe('runtime runs — swarm lifecycle', () => {
       resolveAttachments: () => [],
     });
 
-    const run = await orchestrator.startRun('assistant-1', conversation.id, 'Delegate a swarm task');
+    const run = await orchestrator.startRun(conversation.id, 'Delegate a swarm task');
 
     // Give agent loop time to emit confirmation_request
     await new Promise((r) => setTimeout(r, 50));
@@ -195,7 +195,7 @@ describe('runtime runs — swarm lifecycle', () => {
       resolveAttachments: () => [],
     });
 
-    const run = await orchestrator.startRun('assistant-1', conversation.id, 'Run with approval');
+    const run = await orchestrator.startRun(conversation.id, 'Run with approval');
     await new Promise((r) => setTimeout(r, 50));
 
     // Verify pending state
@@ -220,12 +220,12 @@ describe('runtime runs — swarm lifecycle', () => {
     });
 
     // First run starts and hangs
-    await orchestrator.startRun('assistant-1', conversation.id, 'First run');
+    await orchestrator.startRun(conversation.id, 'First run');
     await new Promise((r) => setTimeout(r, 20));
 
     // Second run on the same session should be rejected
     try {
-      await orchestrator.startRun('assistant-1', conversation.id, 'Second run');
+      await orchestrator.startRun(conversation.id, 'Second run');
       // Should not reach here
       expect(true).toBe(false);
     } catch (err) {
@@ -252,7 +252,7 @@ describe('runtime runs — swarm lifecycle', () => {
       resolveAttachments: () => [],
     });
 
-    const run = await orchestrator.startRun('assistant-1', conversation.id, 'Run with principal');
+    const run = await orchestrator.startRun(conversation.id, 'Run with principal');
     await new Promise((r) => setTimeout(r, 50));
 
     const stored = orchestrator.getRun(run.id);