thanh-kit 2.5.0 → 2.5.2

package/templates/skills/tasks-code-review/SKILL.md

@@ -1,298 +0,0 @@
----
-name: code-review
-description: Use for QUICK PR reviews with structured checklists (architecture, patterns, security, performance). Provides step-by-step review process, git diff commands, and review report templates. Best for pull request reviews and pre-commit checks. NOT for deep refactoring analysis (use code-review instead).
-allowed-tools: Read, Write, Edit, Grep, Glob, Bash, Task
----
-
-# Code Review Workflow
-
-## When to Use This Skill
-
-- Reviewing pull requests
-- Analyzing code for refactoring
-- Pre-commit code quality check
-- Security and performance audit
-
-## Review Dimensions
-
-### 1. Architecture Compliance
-
-- [ ] Follows Clean Architecture layers
-- [ ] Uses correct repository pattern
-- [ ] No cross-service boundary violations
-- [ ] Proper separation of concerns
-
-### 2. Pattern Adherence
-
-- [ ] CQRS patterns followed (Command/Query/Handler in ONE file)
-- [ ] Entity patterns correct (expressions, computed properties)
-- [ ] Frontend component hierarchy respected
-- [ ] Platform base classes used correctly
-
-### 3. Code Quality
-
-- [ ] Single Responsibility Principle
-- [ ] No code duplication
-- [ ] Meaningful naming
-- [ ] Appropriate abstractions
-
-### 4. Security
-
-- [ ] No SQL injection vulnerabilities
-- [ ] Authorization checks present
-- [ ] Sensitive data handling
-- [ ] Input validation
-
-### 5. Performance
-
-- [ ] N+1 query prevention (eager loading)
-- [ ] Proper paging for large datasets
-- [ ] Parallel operations where applicable
-- [ ] Caching considerations
-
-## Review Process
-
-### Step 1: Understand Context
-
-```bash
-# Get changed files
-git diff --name-only main...HEAD
-
-# Get full diff
-git diff main...HEAD
-
-# Check commit messages
-git log main...HEAD --oneline
-```
-
-### Step 2: Categorize Changes
-
-```markdown
-## Files Changed
-
-### Domain Layer
-
-- `Entity.cs` - New entity
-
-### Application Layer
-
-- `SaveEntityCommand.cs` - New command
-
-### Persistence Layer
-
-- `EntityConfiguration.cs` - EF configuration
-
-### Frontend
-
-- `entity-list.component.ts` - List component
-```
-
-### Step 3: Review Each Category
-
-#### Backend Review Checklist
-
-```markdown
-## Entity Review
-
-- [ ] Inherits from correct base (RootEntity/RootAuditedEntity)
-- [ ] Static expressions for queries
-- [ ] Computed properties have empty `set { }`
-- [ ] Navigation properties have `[JsonIgnore]`
-- [ ] `[TrackFieldUpdatedDomainEvent]` on tracked fields
-
-## Command/Query Review
-
-- [ ] Command + Handler + Result in ONE file
-- [ ] Uses service-specific repository
-- [ ] Validation uses fluent API
-- [ ] No side effects in command handler
-- [ ] DTO mapping in DTO class, not handler
-
-## Repository Usage Review
-
-- [ ] Uses `GetQueryBuilder` for reusable queries
-- [ ] Uses `WhereIf` for optional filters
-- [ ] Parallel tuple queries for count + data
-- [ ] Proper eager loading
-
-## Event Handler Review
-
-- [ ] In `UseCaseEvents/` folder
-- [ ] Uses `PlatformCqrsEntityEventApplicationHandler<T>`
-- [ ] `HandleWhen` is `public override async Task<bool>`
-- [ ] Filters by `CrudAction` appropriately
-```
-
-#### Frontend Review Checklist
-
-```markdown
-## Component Review
-
-- [ ] Correct base class for use case
-- [ ] Store provided at component level
-- [ ] Loading/error states handled
-- [ ] `untilDestroyed()` on subscriptions
-- [ ] Track-by in `@for` loops
-
-## Store Review
-
-- [ ] State interface defined
-- [ ] `vmConstructor` provides defaults
-- [ ] Effects use `observerLoadingErrorState`
-- [ ] Immutable state updates
-
-## Form Review
-
-- [ ] `validateForm()` before submit
-- [ ] Async validators conditional
-- [ ] Dependent validations configured
-- [ ] Error messages for all rules
-
-## API Service Review
-
-- [ ] Extends `PlatformApiService`
-- [ ] Typed responses
-- [ ] Caching where appropriate
-```
-
-### Step 4: Security Review
-
-```markdown
-## Security Checklist
-
-### Authorization
-
-- [ ] `[PlatformAuthorize]` on controllers
-- [ ] Role checks in handlers
-- [ ] Data filtered by company/user context
-
-### Input Validation
-
-- [ ] All inputs validated
-- [ ] No raw SQL strings
-- [ ] File upload validation
-
-### Sensitive Data
-
-- [ ] No secrets in code
-- [ ] Passwords hashed
-- [ ] PII handled correctly
-```
-
-### Step 5: Performance Review
-
-```markdown
-## Performance Checklist
-
-### Database
-
-- [ ] Indexes on filtered columns
-- [ ] Eager loading for N+1 prevention
-- [ ] Paging for large datasets
-
-### API
-
-- [ ] Response size reasonable
-- [ ] Parallel operations used
-- [ ] Caching for static data
-
-### Frontend
-
-- [ ] Lazy loading for routes
-- [ ] Track-by for lists
-- [ ] OnPush change detection
-```
-
-## Common Issues to Flag
-
-### :x: Anti-Patterns
-
-```csharp
-// Issue: Side effect in command handler
-await notificationService.SendAsync(...);
-
-// Issue: Wrong repository type
-IPlatformRootRepository<Entity>  // Should be service-specific
-
-// Issue: DTO mapping in handler
-var entity = new Entity { Name = request.Name };  // Should use DTO.MapToEntity()
-
-// Issue: Missing eager loading
-var items = await repo.GetAllAsync(...);  // Missing relations
-items.ForEach(i => Console.WriteLine(i.Related.Name));  // N+1!
-```
-
-```typescript
-// Issue: No loading state
-this.api.getItems().subscribe(items => this.items = items);
-
-// Issue: Direct mutation
-this.state.items.push(newItem);
-
-// Issue: Missing cleanup
-this.data$.subscribe(...);  // Missing untilDestroyed()
-```
-
-## Review Report Template
-
-```markdown
-# Code Review Report
-
-## Summary
-
-- **PR/Changes**: [Description]
-- **Reviewer**: AI
-- **Date**: [Date]
-
-## Overall Assessment
-
-[APPROVED | APPROVED WITH COMMENTS | CHANGES REQUESTED]
-
-## Strengths
-
-1. [Positive point 1]
-2. [Positive point 2]
-
-## Issues Found
-
-### Critical (Must Fix)
-
-1. **[File:Line]**: [Description]
-    - Problem: [Explanation]
-    - Suggestion: [Fix]
-
-### Major (Should Fix)
-
-1. **[File:Line]**: [Description]
-
-### Minor (Consider Fixing)
-
-1. **[File:Line]**: [Description]
-
-## Recommendations
-
-1. [Recommendation 1]
-2. [Recommendation 2]
-```
-
-## Review Commands
-
-```bash
-# Find potential issues
-grep -r "new Entity {" --include="*.cs"  # DTO mapping in handler
-grep -r "SendAsync\|NotifyAsync" --include="*CommandHandler.cs"  # Side effects
-grep -r "IPlatformRootRepository" --include="*.cs"  # Generic repository
-
-# Check patterns
-grep -r "observerLoadingErrorState" --include="*.ts"  # Loading tracking
-grep -r "untilDestroyed" --include="*.ts"  # Subscription cleanup
-```
-
-## Verification Checklist
-
-- [ ] All changed files reviewed
-- [ ] Architecture compliance verified
-- [ ] Platform patterns followed
-- [ ] Security concerns addressed
-- [ ] Performance considered
-- [ ] Review report generated

package/templates/skills/tasks-documentation/SKILL.md

@@ -1,328 +0,0 @@
----
-name: documentation
-description: Use for WRITING documentation with ready-to-use code templates (C# XML docs, TypeScript JSDoc, API docs, README patterns). Best for implementing actual documentation, adding code comments, and creating docs from scratch. NOT for documentation planning (use documentation instead).
-allowed-tools: Read, Write, Edit, Grep, Glob, Bash
----
-
-# Documentation Workflow
-
-## When to Use This Skill
-
-- Creating API documentation
-- Writing code comments
-- Updating README files
-- Generating architecture documentation
-
-## Documentation Types
-
-### 1. Code Comments
-
-- XML docs for public APIs
-- Inline comments for complex logic
-- TODO/FIXME for technical debt
-
-### 2. API Documentation
-
-- Endpoint descriptions
-- Request/response schemas
-- Error codes and handling
-
-### 3. Architecture Documentation
-
-- Component diagrams
-- Data flow documentation
-- Integration guides
-
-## Pattern 1: C# XML Documentation
-
-```csharp
-/// <summary>
-/// Saves or updates an employee entity.
-/// </summary>
-/// <remarks>
-/// This command handles both create and update operations.
-/// For new employees, the Id should be null or empty.
-/// </remarks>
-/// <example>
-/// <code>
-/// var command = new SaveEmployeeCommand
-/// {
-///     Name = "John Doe",
-///     Email = "john@example.com"
-/// };
-/// var result = await handler.HandleAsync(command, cancellationToken);
-/// </code>
-/// </example>
-public sealed class SaveEmployeeCommand : PlatformCqrsCommand<SaveEmployeeCommandResult>
-{
-    /// <summary>
-    /// The unique identifier of the employee.
-    /// Null or empty for new employees.
-    /// </summary>
-    public string? Id { get; set; }
-
-    /// <summary>
-    /// The employee's full name.
-    /// </summary>
-    /// <value>Must be non-empty and max 200 characters.</value>
-    public string Name { get; set; } = string.Empty;
-}
-
-/// <summary>
-/// Represents a unique expression for finding an employee.
-/// </summary>
-/// <param name="companyId">The company identifier.</param>
-/// <param name="userId">The user identifier.</param>
-/// <returns>An expression that matches the unique employee.</returns>
-public static Expression<Func<Employee, bool>> UniqueExpr(string companyId, string userId)
-    => e => e.CompanyId == companyId && e.UserId == userId;
-```
-
-## Pattern 2: TypeScript JSDoc
-
-````typescript
-/**
- * Manages the feature list state and operations.
- *
- * @example
- * ```typescript
- * @Component({
- *   providers: [FeatureListStore]
- * })
- * export class FeatureListComponent {
- *   constructor(private store: FeatureListStore) {
- *     store.loadItems();
- *   }
- * }
- * ```
- */
-@Injectable()
-export class FeatureListStore extends PlatformVmStore<FeatureListState> {
-  /**
-   * Loads items from the API with current filters.
-   *
-   * @remarks
-   * This effect automatically tracks loading state under the key 'loadItems'.
-   * Use `isLoading$('loadItems')` to check loading status.
-   *
-   * @see {@link FeatureApiService.getList}
-   */
-  public loadItems = this.effectSimple(() => /* ... */);
-
-  /**
-   * Updates the filter criteria and resets to first page.
-   *
-   * @param filters - Partial filter object to merge with current filters
-   *
-   * @example
-   * ```typescript
-   * // Filter by status
-   * store.setFilters({ status: FeatureStatus.Active });
-   *
-   * // Filter by search text
-   * store.setFilters({ searchText: 'keyword' });
-   * ```
-   */
-  public setFilters(filters: Partial<FeatureFilters>): void {
-    // ...
-  }
-}
-
-/**
- * Represents a feature entity from the API.
- */
-export interface FeatureDto {
-  /** Unique identifier */
-  id: string;
-
-  /** Display name of the feature */
-  name: string;
-
-  /**
-   * Current status of the feature.
-   * @default FeatureStatus.Draft
-   */
-  status: FeatureStatus;
-}
-````
-
-## Pattern 3: API Endpoint Documentation
-
-```csharp
-/// <summary>
-/// Employee management endpoints.
-/// </summary>
-[ApiController]
-[Route("api/[controller]")]
-[PlatformAuthorize]
-public class EmployeeController : PlatformBaseController
-{
-    /// <summary>
-    /// Retrieves a paginated list of employees.
-    /// </summary>
-    /// <param name="query">Query parameters for filtering and pagination.</param>
-    /// <returns>Paginated list of employees.</returns>
-    /// <response code="200">Returns the employee list.</response>
-    /// <response code="400">Invalid query parameters.</response>
-    /// <response code="401">Unauthorized - authentication required.</response>
-    /// <response code="403">Forbidden - insufficient permissions.</response>
-    [HttpGet]
-    [ProducesResponseType(typeof(GetEmployeeListQueryResult), StatusCodes.Status200OK)]
-    [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)]
-    public async Task<IActionResult> GetList([FromQuery] GetEmployeeListQuery query)
-        => Ok(await Cqrs.SendAsync(query));
-
-    /// <summary>
-    /// Creates or updates an employee.
-    /// </summary>
-    /// <param name="command">Employee data to save.</param>
-    /// <returns>The saved employee.</returns>
-    /// <response code="200">Employee saved successfully.</response>
-    /// <response code="400">Validation failed.</response>
-    /// <response code="404">Employee not found (for updates).</response>
-    [HttpPost]
-    [ProducesResponseType(typeof(SaveEmployeeCommandResult), StatusCodes.Status200OK)]
-    [ProducesResponseType(typeof(ValidationProblemDetails), StatusCodes.Status400BadRequest)]
-    [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
-    public async Task<IActionResult> Save([FromBody] SaveEmployeeCommand command)
-        => Ok(await Cqrs.SendAsync(command));
-}
-```
-
-## Pattern 4: README Documentation
-
-```markdown
-# Feature Name
-
-Brief description of what this feature does.
-
-## Overview
-
-More detailed explanation of the feature's purpose and functionality.
-
-## Architecture
-```
-
-┌─────────────────┐ ┌──────────────────┐ ┌─────────────────┐
-│ Frontend │────▶│ API Layer │────▶│ Domain Layer │
-│ Component │ │ Controller │ │ Entity │
-└─────────────────┘ └──────────────────┘ └─────────────────┘
-
-````
-
-## Usage
-
-### Backend
-
-```csharp
-// Example usage
-var command = new SaveFeatureCommand { Name = "Example" };
-var result = await handler.HandleAsync(command, cancellationToken);
-````
-
-### Frontend
-
-```typescript
-// Example usage
-this.store.loadItems();
-```
-
-## Configuration
-
-| Setting        | Description               | Default |
-| -------------- | ------------------------- | ------- |
-| `MaxItems`     | Maximum items per page    | 50      |
-| `CacheTimeout` | Cache duration in seconds | 300     |
-
-## API Endpoints
-
-| Method | Endpoint            | Description           |
-| ------ | ------------------- | --------------------- |
-| GET    | `/api/feature`      | List features         |
-| POST   | `/api/feature`      | Create/update feature |
-| DELETE | `/api/feature/{id}` | Delete feature        |
-
-## Error Handling
-
-| Code | Description          |
-| ---- | -------------------- |
-| 400  | Invalid request data |
-| 404  | Feature not found    |
-| 409  | Conflict (duplicate) |
-
-## Related
-
-- [Entity Documentation](./Entity.md)
-- [API Reference](./API.md)
-
-````
-
-## Pattern 5: Inline Code Comments
-
-```csharp
-protected override async Task<SaveEmployeeCommandResult> HandleAsync(
-    SaveEmployeeCommand request, CancellationToken cancellationToken)
-{
-    // Step 1: Determine if this is a create or update operation
-    var isCreate = request.Id.IsNullOrEmpty();
-
-    // Step 2: Get or create the entity
-    var employee = isCreate
-        ? request.MapToNewEntity()
-            .With(e => e.CreatedBy = RequestContext.UserId())
-        : await repository.GetByIdAsync(request.Id, cancellationToken)
-            .EnsureFound($"Employee not found: {request.Id}")
-            .Then(existing => request.UpdateEntity(existing));
-
-    // Step 3: Validate business rules
-    // NOTE: This checks for duplicate codes within the same company
-    await employee.ValidateAsync(repository, cancellationToken).EnsureValidAsync();
-
-    // Step 4: Persist changes
-    // The repository automatically raises entity events for cross-service sync
-    var saved = await repository.CreateOrUpdateAsync(employee, cancellationToken);
-
-    // Step 5: Return result
-    return new SaveEmployeeCommandResult
-    {
-        Employee = new EmployeeDto(saved)
-    };
-}
-````
-
-## Documentation Guidelines
-
-### DO
-
-- Document public APIs with XML/JSDoc
-- Explain "why" not "what"
-- Include usage examples
-- Keep documentation close to code
-- Update docs when code changes
-
-### DON'T
-
-- State the obvious
-- Leave TODO comments indefinitely
-- Write documentation that duplicates code
-- Create separate docs that become stale
-
-## Comment Types
-
-| Type             | When to Use               |
-| ---------------- | ------------------------- |
-| `/// <summary>`  | Public API documentation  |
-| `// Explanation` | Complex logic explanation |
-| `// TODO:`       | Planned improvements      |
-| `// FIXME:`      | Known issues              |
-| `// HACK:`       | Temporary workarounds     |
-| `// NOTE:`       | Important information     |
-
-## Verification Checklist
-
-- [ ] Public APIs have XML/JSDoc documentation
-- [ ] Complex logic has explanatory comments
-- [ ] Examples are provided where helpful
-- [ ] Documentation is accurate and up-to-date
-- [ ] No obvious/redundant comments
-- [ ] TODO/FIXME items are actionable