react-native-tvos 0.82.1-0 → 0.83.0-0

package/ReactCommon/cxxreact/ReactNativeVersion.h

@@ -13,15 +13,15 @@
 #include <string_view>
 
 #define REACT_NATIVE_VERSION_MAJOR 0
-#define REACT_NATIVE_VERSION_MINOR 82
-#define REACT_NATIVE_VERSION_PATCH 1
+#define REACT_NATIVE_VERSION_MINOR 83
+#define REACT_NATIVE_VERSION_PATCH 0
 
 namespace facebook::react {
 
 constexpr struct {
   int32_t Major = 0;
-  int32_t Minor = 82;
-  int32_t Patch = 1;
+  int32_t Minor = 83;
+  int32_t Patch = 0;
   std::string_view Prerelease = "0";
 } ReactNativeVersion;
 

package/ReactCommon/cxxreact/RecoverableError.h

@@ -19,10 +19,10 @@ namespace facebook::react {
  * An exception that it is expected we should be able to recover from.
  */
 struct RecoverableError : public std::exception {
-  explicit RecoverableError(const std::string& what_)
-      : m_what{"facebook::react::Recoverable: " + what_} {}
+  explicit RecoverableError(const std::string &what_) : m_what{"facebook::react::Recoverable: " + what_} {}
 
-  virtual const char* what() const noexcept override {
+  virtual const char *what() const noexcept override
+  {
     return m_what.c_str();
   }
 
@@ -33,10 +33,11 @@ struct RecoverableError : public std::exception {
    * `act` routine into a recoverable error with the same message.
    */
   template <typename E>
-  inline static void runRethrowingAsRecoverable(std::function<void()> act) {
+  inline static void runRethrowingAsRecoverable(std::function<void()> act)
+  {
     try {
       act();
-    } catch (const E& err) {
+    } catch (const E &err) {
       throw RecoverableError(err.what());
     }
   }

package/ReactCommon/cxxreact/SystraceSection.h

@@ -17,11 +17,11 @@ namespace facebook::react {
 #if defined(WITH_LOOM_TRACE)
 #define SystraceSection TraceSection
 #else
-struct [[deprecated("Use TraceSection")]] SystraceSection
-    : public TraceSection {
+struct [[deprecated("Use TraceSection")]] SystraceSection : public TraceSection {
   template <typename... ConvertsToStringPiece>
-  explicit SystraceSection(const char* name, ConvertsToStringPiece&&... args)
-      : TraceSection(name, args...) {}
+  explicit SystraceSection(const char *name, ConvertsToStringPiece &&...args) : TraceSection(name, args...)
+  {
+  }
 };
 #endif
 

package/ReactCommon/cxxreact/TraceSection.h

@@ -69,13 +69,13 @@ namespace facebook::react {
 struct TraceSection {
  public:
   template <typename... ConvertsToStringPiece>
-  explicit TraceSection(
-      [[maybe_unused]] const char* name,
-      [[maybe_unused]] ConvertsToStringPiece&&... args) {
+  explicit TraceSection([[maybe_unused]] const char *name, [[maybe_unused]] ConvertsToStringPiece &&...args)
+  {
     TRACE_EVENT_BEGIN("react-native", perfetto::DynamicString{name}, args...);
   }
 
-  ~TraceSection() {
+  ~TraceSection()
+  {
     TRACE_EVENT_END("react-native");
   }
 };
@@ -84,10 +84,10 @@ using TraceSectionUnwrapped = TraceSection;
 struct ConcreteTraceSection {
  public:
   template <typename... ConvertsToStringPiece>
-  explicit ConcreteTraceSection(
-      const char* name,
-      ConvertsToStringPiece&&... args)
-      : m_section(TRACE_TAG_REACT, name, args...) {}
+  explicit ConcreteTraceSection(const char *name, ConvertsToStringPiece &&...args)
+      : m_section(TRACE_TAG_REACT, name, args...)
+  {
+  }
 
  private:
   fbsystrace::FbSystraceSection m_section;
@@ -97,9 +97,9 @@ using TraceSectionUnwrapped = ConcreteTraceSection;
 struct DummyTraceSection {
  public:
   template <typename... ConvertsToStringPiece>
-  explicit DummyTraceSection(
-      [[maybe_unused]] const char* name,
-      [[maybe_unused]] ConvertsToStringPiece&&... args) {}
+  explicit DummyTraceSection([[maybe_unused]] const char *name, [[maybe_unused]] ConvertsToStringPiece &&...args)
+  {
+  }
 };
 using TraceSectionUnwrapped = DummyTraceSection;
 #endif
@@ -110,14 +110,14 @@ using TraceSectionUnwrapped = DummyTraceSection;
  * In the case of WITH_LOOM_TRACE we don't use the signposts APIs because of the
  * templated type for TraceSection.
  */
-#if defined(__APPLE__) && OS_LOG_TARGET_HAS_10_15_FEATURES && \
-    !defined(WITH_LOOM_TRACE)
+#if defined(__APPLE__) && OS_LOG_TARGET_HAS_10_15_FEATURES && !defined(WITH_LOOM_TRACE)
 
 namespace systrace {
 
 template <typename T, typename = void>
 struct renderer {
-  static std::string render(const T& t) {
+  static std::string render(const T &t)
+  {
     std::ostringstream oss;
     oss << t;
     return oss.str();
@@ -125,19 +125,19 @@ struct renderer {
 };
 
 template <typename T>
-static auto render(const T& t)
-    -> decltype(renderer<T>::render(std::declval<const T&>())) {
+static auto render(const T &t) -> decltype(renderer<T>::render(std::declval<const T &>()))
+{
   return renderer<T>::render(t);
 }
 
 inline os_log_t instrumentsLogHandle = nullptr;
 
-static inline os_log_t getOrCreateInstrumentsLogHandle() {
+static inline os_log_t getOrCreateInstrumentsLogHandle()
+{
   static std::once_flag flag{};
   std::call_once(flag, []() {
     if (!instrumentsLogHandle) {
-      instrumentsLogHandle = os_log_create(
-          "dev.reactnative.instruments", OS_LOG_CATEGORY_DYNAMIC_TRACING);
+      instrumentsLogHandle = os_log_create("dev.reactnative.instruments", OS_LOG_CATEGORY_DYNAMIC_TRACING);
     }
   });
   return instrumentsLogHandle;
@@ -148,8 +148,8 @@ static inline os_log_t getOrCreateInstrumentsLogHandle() {
 struct TraceSection {
  public:
   template <typename... ConvertsToStringPiece>
-  explicit TraceSection(const char* name, ConvertsToStringPiece&&... args)
-      : systraceSectionUnwrapped_(name, args...) {
+  explicit TraceSection(const char *name, ConvertsToStringPiece &&...args) : systraceSectionUnwrapped_(name, args...)
+  {
     os_log_t instrumentsLogHandle = systrace::getOrCreateInstrumentsLogHandle();
 
     // If the log isn't enabled, we don't want the performance overhead of the
@@ -168,24 +168,14 @@ struct TraceSection {
 
     signpostID_ = os_signpost_id_make_with_pointer(instrumentsLogHandle, this);
 
-    os_signpost_interval_begin(
-        instrumentsLogHandle,
-        signpostID_,
-        "Systrace",
-        "%s begin: %s",
-        name,
-        argsString.c_str());
+    os_signpost_interval_begin(instrumentsLogHandle, signpostID_, "Systrace", "%s begin: %s", name, argsString.c_str());
   }
 
-  ~TraceSection() {
+  ~TraceSection()
+  {
     // We don't need to gate on os_signpost_enabled here because it's already
     // checked in os_signpost_interval_end.
-    os_signpost_interval_end(
-        systrace::instrumentsLogHandle,
-        signpostID_,
-        "Systrace",
-        "%s end",
-        name_.data());
+    os_signpost_interval_end(systrace::instrumentsLogHandle, signpostID_, "Systrace", "%s end", name_.data());
   }
 
  private:

package/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.h

@@ -12,27 +12,24 @@
 namespace facebook::react {
 
 using NativePartialReloadAndProfileConfig =
-    NativeReactDevToolsRuntimeSettingsModulePartialReloadAndProfileConfig<
-        std::optional<bool>,
-        std::optional<bool>>;
+    NativeReactDevToolsRuntimeSettingsModulePartialReloadAndProfileConfig<std::optional<bool>, std::optional<bool>>;
 
 template <>
 struct Bridging<NativePartialReloadAndProfileConfig>
     : NativeReactDevToolsRuntimeSettingsModulePartialReloadAndProfileConfigBridging<
           NativePartialReloadAndProfileConfig> {};
 
-using NativeReloadAndProfileConfig =
-    NativeReactDevToolsRuntimeSettingsModuleReloadAndProfileConfig<bool, bool>;
+using NativeReloadAndProfileConfig = NativeReactDevToolsRuntimeSettingsModuleReloadAndProfileConfig<bool, bool>;
 
 template <>
 struct Bridging<NativeReloadAndProfileConfig>
-    : NativeReactDevToolsRuntimeSettingsModuleReloadAndProfileConfigBridging<
-          NativeReloadAndProfileConfig> {};
+    : NativeReactDevToolsRuntimeSettingsModuleReloadAndProfileConfigBridging<NativeReloadAndProfileConfig> {};
 
 class DevToolsRuntimeSettings {
  public:
   // static to persist across Turbo Module reloads
-  static DevToolsRuntimeSettings& getInstance() {
+  static DevToolsRuntimeSettings &getInstance()
+  {
     static DevToolsRuntimeSettings instance;
     return instance;
   }
@@ -44,10 +41,10 @@ class DevToolsRuntimeSettings {
 
  public:
   ~DevToolsRuntimeSettings() = default;
-  DevToolsRuntimeSettings(const DevToolsRuntimeSettings&) = delete;
-  DevToolsRuntimeSettings(DevToolsRuntimeSettings&&) = delete;
-  void operator=(const DevToolsRuntimeSettings&) = delete;
-  void operator=(DevToolsRuntimeSettings&&) = delete;
+  DevToolsRuntimeSettings(const DevToolsRuntimeSettings &) = delete;
+  DevToolsRuntimeSettings(DevToolsRuntimeSettings &&) = delete;
+  void operator=(const DevToolsRuntimeSettings &) = delete;
+  void operator=(DevToolsRuntimeSettings &&) = delete;
 
   void setReloadAndProfileConfig(NativePartialReloadAndProfileConfig config);
   NativeReloadAndProfileConfig getReloadAndProfileConfig() const;

package/ReactCommon/hermes/executor/HermesExecutorFactory.h

@@ -13,24 +13,21 @@
 
 namespace facebook::react {
 
-class [[deprecated(
-    "This API will be removed along with the legacy architecture.")]] HermesExecutorFactory
+class [[deprecated("This API will be removed along with the legacy architecture.")]] HermesExecutorFactory
     : public JSExecutorFactory {
  public:
   explicit HermesExecutorFactory(
       JSIExecutor::RuntimeInstaller runtimeInstaller,
-      const JSIScopedTimeoutInvoker& timeoutInvoker =
-          JSIExecutor::defaultTimeoutInvoker,
+      const JSIScopedTimeoutInvoker &timeoutInvoker = JSIExecutor::defaultTimeoutInvoker,
       ::hermes::vm::RuntimeConfig runtimeConfig = defaultRuntimeConfig())
-      : runtimeInstaller_(runtimeInstaller),
-        timeoutInvoker_(timeoutInvoker),
-        runtimeConfig_(std::move(runtimeConfig)) {
+      : runtimeInstaller_(runtimeInstaller), timeoutInvoker_(timeoutInvoker), runtimeConfig_(std::move(runtimeConfig))
+  {
     assert(timeoutInvoker_ && "Should not have empty timeoutInvoker");
   }
 
   void setEnableDebugger(bool enableDebugger);
 
-  void setDebuggerName(const std::string& debuggerName);
+  void setDebuggerName(const std::string &debuggerName);
 
   std::unique_ptr<JSExecutor> createJSExecutor(
       std::shared_ptr<ExecutorDelegate> delegate,
@@ -46,20 +43,18 @@ class [[deprecated(
   std::string debuggerName_ = "Hermes React Native";
 };
 
-class [[deprecated(
-    "This API will be removed along with the legacy architecture.")]] HermesExecutor
+class [[deprecated("This API will be removed along with the legacy architecture.")]] HermesExecutor
     : public JSIExecutor {
  public:
   HermesExecutor(
       std::shared_ptr<jsi::Runtime> runtime,
       std::shared_ptr<ExecutorDelegate> delegate,
       std::shared_ptr<MessageQueueThread> jsQueue,
-      const JSIScopedTimeoutInvoker& timeoutInvoker,
+      const JSIScopedTimeoutInvoker &timeoutInvoker,
       RuntimeInstaller runtimeInstaller,
-      hermes::HermesRuntime& hermesRuntime);
+      hermes::HermesRuntime &hermesRuntime);
 
-  jsinspector_modern::RuntimeTargetDelegate& getRuntimeTargetDelegate()
-      override;
+  jsinspector_modern::RuntimeTargetDelegate &getRuntimeTargetDelegate() override;
 
  private:
   JSIScopedTimeoutInvoker timeoutInvoker_;

package/ReactCommon/hermes/inspector-modern/chrome/ConnectionDemux.cpp

@@ -89,8 +89,9 @@ DebugSessionToken ConnectionDemux::enableDebugging(
 
   auto waitForDebugger =
       (inspectedContexts_->find(title) != inspectedContexts_->end());
-  return addPage(hermes::inspector_modern::chrome::CDPHandler::create(
-      std::move(adapter), title, waitForDebugger));
+  return addPage(
+      hermes::inspector_modern::chrome::CDPHandler::create(
+          std::move(adapter), title, waitForDebugger));
 }
 
 void ConnectionDemux::disableDebugging(DebugSessionToken session) {

package/ReactCommon/hermes/inspector-modern/chrome/ConnectionDemux.h

@@ -30,30 +30,23 @@ namespace facebook::hermes::inspector_modern::chrome {
  */
 class ConnectionDemux {
  public:
-  explicit ConnectionDemux(
-      facebook::react::jsinspector_modern::IInspector& inspector);
+  explicit ConnectionDemux(facebook::react::jsinspector_modern::IInspector &inspector);
   ~ConnectionDemux();
 
-  ConnectionDemux(const ConnectionDemux&) = delete;
-  ConnectionDemux& operator=(const ConnectionDemux&) = delete;
+  ConnectionDemux(const ConnectionDemux &) = delete;
+  ConnectionDemux &operator=(const ConnectionDemux &) = delete;
 
-  DebugSessionToken enableDebugging(
-      std::unique_ptr<RuntimeAdapter> adapter,
-      const std::string& title);
+  DebugSessionToken enableDebugging(std::unique_ptr<RuntimeAdapter> adapter, const std::string &title);
   void disableDebugging(DebugSessionToken session);
 
  private:
-  int addPage(
-      std::shared_ptr<hermes::inspector_modern::chrome::CDPHandler> conn);
+  int addPage(std::shared_ptr<hermes::inspector_modern::chrome::CDPHandler> conn);
   void removePage(int pageId);
 
-  facebook::react::jsinspector_modern::IInspector& globalInspector_;
+  facebook::react::jsinspector_modern::IInspector &globalInspector_;
 
   std::mutex mutex_;
-  std::unordered_map<
-      int,
-      std::shared_ptr<hermes::inspector_modern::chrome::CDPHandler>>
-      conns_;
+  std::unordered_map<int, std::shared_ptr<hermes::inspector_modern::chrome::CDPHandler>> conns_;
   std::shared_ptr<std::unordered_set<std::string>> inspectedContexts_;
 };
 

package/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeAgentDelegate.cpp

@@ -50,19 +50,20 @@ class HermesRuntimeAgentDelegate::Impl final : public RuntimeAgentDelegate {
       HermesRuntime& runtime,
       HermesRuntimeTargetDelegate& runtimeTargetDelegate,
       const RuntimeExecutor& runtimeExecutor)
-      : hermes_(hermes::cdp::CDPAgent::create(
-            executionContextDescription.id,
-            runtimeTargetDelegate.getCDPDebugAPI(),
-            // RuntimeTask takes a HermesRuntime whereas our RuntimeExecutor
-            // takes a jsi::Runtime.
-            [runtimeExecutor,
-             &runtime](facebook::hermes::debugger::RuntimeTask fn) {
-              runtimeExecutor(
-                  [&runtime, fn = std::move(fn)](auto&) { fn(runtime); });
-            },
-            std::move(frontendChannel),
-            HermesStateWrapper::unwrapDestructively(
-                previouslyExportedState.get()))) {
+      : hermes_(
+            hermes::cdp::CDPAgent::create(
+                executionContextDescription.id,
+                runtimeTargetDelegate.getCDPDebugAPI(),
+                // RuntimeTask takes a HermesRuntime whereas our RuntimeExecutor
+                // takes a jsi::Runtime.
+                [runtimeExecutor,
+                 &runtime](facebook::hermes::debugger::RuntimeTask fn) {
+                  runtimeExecutor(
+                      [&runtime, fn = std::move(fn)](auto&) { fn(runtime); });
+                },
+                std::move(frontendChannel),
+                HermesStateWrapper::unwrapDestructively(
+                    previouslyExportedState.get()))) {
     if (sessionState.isRuntimeDomainEnabled) {
       hermes_->enableRuntimeDomain();
     }
@@ -72,10 +73,9 @@ class HermesRuntimeAgentDelegate::Impl final : public RuntimeAgentDelegate {
   }
 
   bool handleRequest(const cdp::PreparsedRequest& req) override {
-    // TODO: Change to string::starts_with when we're on C++20.
-    if (req.method.rfind("Log.", 0) == 0) {
-      // Since we know Hermes doesn't do anything useful with Log messages,
-      // but our containing HostAgent will, bail out early.
+    if (req.method.starts_with("Log.") || req.method.starts_with("Network.")) {
+      // Since we know Hermes doesn't do anything useful with Log or Network
+      // messages, but our containing HostAgent will, bail out early.
       // TODO: We need a way to negotiate this more dynamically with Hermes
       // through the API.
       return false;
@@ -104,14 +104,15 @@ HermesRuntimeAgentDelegate::HermesRuntimeAgentDelegate(
     HermesRuntime& runtime,
     HermesRuntimeTargetDelegate& runtimeTargetDelegate,
     RuntimeExecutor runtimeExecutor)
-    : impl_(std::make_unique<Impl>(
-          std::move(frontendChannel),
-          sessionState,
-          std::move(previouslyExportedState),
-          executionContextDescription,
-          runtime,
-          runtimeTargetDelegate,
-          std::move(runtimeExecutor))) {}
+    : impl_(
+          std::make_unique<Impl>(
+              std::move(frontendChannel),
+              sessionState,
+              std::move(previouslyExportedState),
+              executionContextDescription,
+              runtime,
+              runtimeTargetDelegate,
+              std::move(runtimeExecutor))) {}
 
 bool HermesRuntimeAgentDelegate::handleRequest(
     const cdp::PreparsedRequest& req) {

package/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeAgentDelegate.h

@@ -48,12 +48,11 @@ class HermesRuntimeAgentDelegate : public RuntimeAgentDelegate {
    */
   HermesRuntimeAgentDelegate(
       FrontendChannel frontendChannel,
-      SessionState& sessionState,
-      std::unique_ptr<RuntimeAgentDelegate::ExportedState>
-          previouslyExportedState,
-      const ExecutionContextDescription& executionContextDescription,
-      hermes::HermesRuntime& runtime,
-      HermesRuntimeTargetDelegate& runtimeTargetDelegate,
+      SessionState &sessionState,
+      std::unique_ptr<RuntimeAgentDelegate::ExportedState> previouslyExportedState,
+      const ExecutionContextDescription &executionContextDescription,
+      hermes::HermesRuntime &runtime,
+      HermesRuntimeTargetDelegate &runtimeTargetDelegate,
       RuntimeExecutor runtimeExecutor);
 
   /**
@@ -64,10 +63,9 @@ class HermesRuntimeAgentDelegate : public RuntimeAgentDelegate {
    * to the request (with either a success or error message). False if the
    * agent expects another agent to respond to the request instead.
    */
-  bool handleRequest(const cdp::PreparsedRequest& req) override;
+  bool handleRequest(const cdp::PreparsedRequest &req) override;
 
-  std::unique_ptr<RuntimeAgentDelegate::ExportedState> getExportedState()
-      override;
+  std::unique_ptr<RuntimeAgentDelegate::ExportedState> getExportedState() override;
 
  private:
   class Impl;
@@ -78,6 +76,5 @@ class HermesRuntimeAgentDelegate : public RuntimeAgentDelegate {
 } // namespace facebook::react::jsinspector_modern
 
 #else
-#error \
-    "HERMES_ENABLE_DEBUGGER must be enabled to use HermesRuntimeAgentDelegate."
+#error "HERMES_ENABLE_DEBUGGER must be enabled to use HermesRuntimeAgentDelegate."
 #endif // HERMES_ENABLE_DEBUGGER

package/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeSamplingProfileSerializer.h

@@ -15,9 +15,10 @@ namespace facebook::react::jsinspector_modern::tracing {
 
 class RawHermesRuntimeProfile : public RawRuntimeProfile {
  public:
-  explicit RawHermesRuntimeProfile(
-      hermes::sampling_profiler::Profile hermesProfile)
-      : hermesProfile_{std::move(hermesProfile)} {}
+  explicit RawHermesRuntimeProfile(hermes::sampling_profiler::Profile hermesProfile)
+      : hermesProfile_{std::move(hermesProfile)}
+  {
+  }
 
  private:
   hermes::sampling_profiler::Profile hermesProfile_;

package/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.cpp

@@ -78,6 +78,14 @@ class HermesRuntimeTargetDelegate::Impl final : public RuntimeTargetDelegate {
       return &hermesStackTrace_;
     }
 
+    const HermesStackTrace& operator*() const {
+      return hermesStackTrace_;
+    }
+
+    const HermesStackTrace* operator->() const {
+      return &hermesStackTrace_;
+    }
+
    private:
     HermesStackTrace hermesStackTrace_;
   };
@@ -216,6 +224,47 @@ class HermesRuntimeTargetDelegate::Impl final : public RuntimeTargetDelegate {
     return samplingProfileDelegate_->collectSamplingProfile();
   }
 
+  std::optional<folly::dynamic> serializeStackTrace(
+      const StackTrace& stackTrace) override {
+    if (auto* hermesStackTraceWrapper =
+            dynamic_cast<const HermesStackTraceWrapper*>(&stackTrace)) {
+      // The logic below is duplicated from
+      // facebook::hermes::cdp::message::makeCallFrames in
+      // hermes/cdp/MessageConverters.cpp (and rewritten to use Folly).
+      // TODO: Use a suitable Hermes API (D83560910 / D83560972 / D83562078) to
+      // serialize the stack trace to CDP-formatted JSON.
+      folly::dynamic cdpStackTrace = folly::dynamic::object();
+      auto& hermesStackTrace = **hermesStackTraceWrapper;
+      if (hermesStackTrace.callFrameCount() > 0) {
+        folly::dynamic callFrames = folly::dynamic::array();
+        callFrames.reserve(hermesStackTrace.callFrameCount());
+        for (int i = 0, n = hermesStackTrace.callFrameCount(); i != n; i++) {
+          auto callFrame = hermesStackTrace.callFrameForIndex(i);
+          if (callFrame.location.fileId ==
+              facebook::hermes::debugger::kInvalidLocation) {
+            continue;
+          }
+          folly::dynamic callFrameObj = folly::dynamic::object();
+          callFrameObj["functionName"] = callFrame.functionName;
+          callFrameObj["scriptId"] = std::to_string(callFrame.location.fileId);
+          callFrameObj["url"] = callFrame.location.fileName;
+          if (callFrame.location.line !=
+              facebook::hermes::debugger::kInvalidLocation) {
+            callFrameObj["lineNumber"] = callFrame.location.line - 1;
+          }
+          if (callFrame.location.column !=
+              facebook::hermes::debugger::kInvalidLocation) {
+            callFrameObj["columnNumber"] = callFrame.location.column - 1;
+          }
+          callFrames.push_back(std::move(callFrameObj));
+        }
+        cdpStackTrace["callFrames"] = std::move(callFrames);
+      }
+      return cdpStackTrace;
+    }
+    return std::nullopt;
+  }
+
  private:
   HermesRuntimeTargetDelegate& delegate_;
   std::shared_ptr<HermesRuntime> runtime_;
@@ -311,6 +360,11 @@ HermesRuntimeTargetDelegate::collectSamplingProfile() {
   return impl_->collectSamplingProfile();
 }
 
+std::optional<folly::dynamic> HermesRuntimeTargetDelegate::serializeStackTrace(
+    const StackTrace& stackTrace) {
+  return impl_->serializeStackTrace(stackTrace);
+}
+
 #ifdef HERMES_ENABLE_DEBUGGER
 CDPDebugAPI& HermesRuntimeTargetDelegate::getCDPDebugAPI() {
   return impl_->getCDPDebugAPI();

package/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.h

@@ -29,8 +29,7 @@ class HermesRuntimeTargetDelegate : public RuntimeTargetDelegate {
   /**
    * Creates a HermesRuntimeTargetDelegate for the given runtime.
    */
-  explicit HermesRuntimeTargetDelegate(
-      std::shared_ptr<hermes::HermesRuntime> hermesRuntime);
+  explicit HermesRuntimeTargetDelegate(std::shared_ptr<hermes::HermesRuntime> hermesRuntime);
 
   ~HermesRuntimeTargetDelegate() override;
 
@@ -38,28 +37,23 @@ class HermesRuntimeTargetDelegate : public RuntimeTargetDelegate {
 
   std::unique_ptr<jsinspector_modern::RuntimeAgentDelegate> createAgentDelegate(
       jsinspector_modern::FrontendChannel frontendChannel,
-      jsinspector_modern::SessionState& sessionState,
-      std::unique_ptr<jsinspector_modern::RuntimeAgentDelegate::ExportedState>
-          previouslyExportedState,
-      const jsinspector_modern::ExecutionContextDescription&
-          executionContextDescription,
+      jsinspector_modern::SessionState &sessionState,
+      std::unique_ptr<jsinspector_modern::RuntimeAgentDelegate::ExportedState> previouslyExportedState,
+      const jsinspector_modern::ExecutionContextDescription &executionContextDescription,
       RuntimeExecutor runtimeExecutor) override;
 
-  void addConsoleMessage(jsi::Runtime& runtime, ConsoleMessage message)
-      override;
+  void addConsoleMessage(jsi::Runtime &runtime, ConsoleMessage message) override;
 
   bool supportsConsole() const override;
 
-  std::unique_ptr<StackTrace> captureStackTrace(
-      jsi::Runtime& runtime,
-      size_t framesToSkip) override;
+  std::unique_ptr<StackTrace> captureStackTrace(jsi::Runtime &runtime, size_t framesToSkip) override;
 
   void enableSamplingProfiler() override;
-
   void disableSamplingProfiler() override;
-
   tracing::RuntimeSamplingProfile collectSamplingProfile() override;
 
+  std::optional<folly::dynamic> serializeStackTrace(const StackTrace &stackTrace) override;
+
  private:
   // We use the private implementation idiom to ensure this class has the same
   // layout regardless of whether HERMES_ENABLE_DEBUGGER is defined. The net
@@ -72,7 +66,7 @@ class HermesRuntimeTargetDelegate : public RuntimeTargetDelegate {
 #ifdef HERMES_ENABLE_DEBUGGER
   friend class HermesRuntimeAgentDelegate;
 
-  hermes::cdp::CDPDebugAPI& getCDPDebugAPI();
+  hermes::cdp::CDPDebugAPI &getCDPDebugAPI();
 #endif
 
   std::unique_ptr<Impl> impl_;

package/ReactCommon/hermes/inspector-modern/chrome/Registration.h

@@ -25,9 +25,7 @@ using DebugSessionToken = int;
  * should be called before any JS runs in the runtime. The returned token
  * can be used to disable debugging for this runtime.
  */
-extern DebugSessionToken enableDebugging(
-    std::unique_ptr<RuntimeAdapter> adapter,
-    const std::string& title);
+extern DebugSessionToken enableDebugging(std::unique_ptr<RuntimeAdapter> adapter, const std::string &title);
 
 /*
  * disableDebugging removes this runtime from the list of debuggable JS targets