react-native-tvos 0.82.1-0 → 0.83.0-0

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/DisplayMetricsHolder.kt

@@ -61,6 +61,7 @@ public object DisplayMetricsHolder {
   }
 
   @JvmStatic
+  @Suppress("DEPRECATION")
   public fun initDisplayMetrics(context: Context) {
     val displayMetrics = context.resources.displayMetrics
     windowDisplayMetrics = displayMetrics
@@ -72,7 +73,11 @@ public object DisplayMetricsHolder {
     //
     // See:
     // http://developer.android.com/reference/android/view/Display.html#getRealMetrics(android.util.DisplayMetrics)
-    @Suppress("DEPRECATION") wm.defaultDisplay.getRealMetrics(screenDisplayMetrics)
+    wm.defaultDisplay.getRealMetrics(screenDisplayMetrics)
+    // Preserve fontScale from the configuration because getRealMetrics() returns
+    // physical display metrics without the system font scale setting.
+    // This is needed for proper text scaling when fontScale < 1.0
+    screenDisplayMetrics.scaledDensity = displayMetrics.scaledDensity
     DisplayMetricsHolder.screenDisplayMetrics = screenDisplayMetrics
   }
 

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/FilterHelper.kt

@@ -21,9 +21,25 @@ import com.facebook.react.uimanager.PixelUtil.dpToPx
 import kotlin.math.cos
 import kotlin.math.sin
 
+/**
+ * Helper object for parsing and applying CSS filter effects on Android S+ (API 31+).
+ *
+ * This object provides utilities to convert CSS filter arrays into Android [RenderEffect] chains
+ * and [ColorMatrixColorFilter] objects. Supports filters like blur, brightness, contrast,
+ * grayscale, sepia, saturate, hue-rotate, invert, opacity, and drop-shadow.
+ *
+ * @see <a href="https://www.w3.org/TR/filter-effects-1/">CSS Filter Effects Module Level 1</a>
+ */
 @TargetApi(31)
 internal object FilterHelper {
 
+  /**
+   * Parses a ReadableArray of CSS filter definitions into a chained [RenderEffect].
+   *
+   * @param filters The array of filter definitions, or null
+   * @return A chained RenderEffect representing all filters, or null if no filters provided
+   * @throws IllegalArgumentException if an invalid filter name is encountered
+   */
   @JvmStatic
   fun parseFilters(filters: ReadableArray?): RenderEffect? {
     filters ?: return null

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/FloatUtil.kt

@@ -9,9 +9,30 @@ package com.facebook.react.uimanager
 
 import kotlin.math.abs
 
+/**
+ * Utility class for comparing floating-point numbers with epsilon-based equality.
+ *
+ * This class provides methods to compare float values while accounting for floating-point precision
+ * issues. Direct equality comparison of floats can be unreliable due to rounding errors in
+ * floating-point arithmetic. This utility uses an epsilon threshold to determine if two float
+ * values are "close enough" to be considered equal.
+ */
 public object FloatUtil {
+
   private const val EPSILON = .00001f
 
+  /**
+   * Compares two float values for equality using an epsilon threshold.
+   *
+   * This method handles special cases:
+   * - If both values are NaN, they are considered equal
+   * - If only one value is NaN, they are not equal
+   * - Otherwise, values are equal if their absolute difference is less than [EPSILON]
+   *
+   * @param f1 the first float value to compare
+   * @param f2 the second float value to compare
+   * @return `true` if the values are equal within the epsilon threshold, `false` otherwise
+   */
   @JvmStatic
   public fun floatsEqual(f1: Float, f2: Float): Boolean {
     return if (f1.isNaN() || f2.isNaN()) {
@@ -19,6 +40,18 @@ public object FloatUtil {
     } else abs(f2 - f1) < EPSILON
   }
 
+  /**
+   * Compares two nullable float values for equality using an epsilon threshold.
+   *
+   * This method handles null values:
+   * - If both values are null, they are considered equal
+   * - If only one value is null, they are not equal
+   * - If both values are non-null, delegates to [floatsEqual] with non-null parameters
+   *
+   * @param f1 the first nullable float value to compare
+   * @param f2 the second nullable float value to compare
+   * @return `true` if the values are equal (both null or equal within epsilon), `false` otherwise
+   */
   @JvmStatic
   public fun floatsEqual(f1: Float?, f2: Float?): Boolean {
     if (f1 == null) {

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/LengthPercentage.kt

@@ -24,26 +24,24 @@ public data class LengthPercentage(
 ) {
   public companion object {
     @JvmStatic
-    public fun setFromDynamic(dynamic: Dynamic): LengthPercentage? {
+    public fun setFromDynamic(dynamic: Dynamic, allowNegative: Boolean = false): LengthPercentage? {
       return when (dynamic.type) {
         ReadableType.Number -> {
           val value = dynamic.asDouble()
-          if (value >= 0f) {
-            LengthPercentage(value.toFloat(), LengthPercentageType.POINT)
-          } else {
-            null
+          if (value < 0 && !allowNegative) {
+            return null
           }
+          LengthPercentage(value.toFloat(), LengthPercentageType.POINT)
         }
         ReadableType.String -> {
           val s = dynamic.asString()
           if (s != null && s.endsWith("%")) {
             try {
               val value = s.substring(0, s.length - 1).toFloat()
-              if (value >= 0f) {
-                LengthPercentage(value, LengthPercentageType.PERCENT)
-              } else {
-                null
+              if (value < 0 && !allowNegative) {
+                return null
               }
+              LengthPercentage(value, LengthPercentageType.PERCENT)
             } catch (e: NumberFormatException) {
               FLog.w(ReactConstants.TAG, "Invalid percentage format: $s")
               null

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java

@@ -188,8 +188,6 @@ public class NativeViewHierarchyManager {
     try {
       View viewToUpdate = resolveView(tag);
 
-      viewToUpdate.setLayoutDirection(LayoutDirectionUtil.toAndroidFromYoga(layoutDirection));
-
       // Even though we have exact dimensions, we still call measure because some platform views
       // (e.g.
       // Switch) assume that method will always be called before onLayout and onDraw. They use it to
@@ -706,14 +704,14 @@ public class NativeViewHierarchyManager {
     UiThreadUtil.assertOnUiThread();
     View v = mTagsToViews.get(tag);
     if (v == null) {
-      throw new NoSuchNativeViewException("No native view for " + tag + " currently exists");
+      throw new IllegalViewOperationException("No native view for " + tag + " currently exists");
     }
 
     View rootView = (View) RootViewUtil.getRootView(v);
     // It is possible that the RootView can't be found because this view is no longer on the screen
     // and has been removed by clipping
     if (rootView == null) {
-      throw new NoSuchNativeViewException("Native view " + tag + " is no longer on screen");
+      throw new IllegalViewOperationException("Native view " + tag + " is no longer on screen");
     }
     computeBoundingBox(rootView, outputBuffer);
     int rootX = outputBuffer[0];
@@ -773,7 +771,7 @@ public class NativeViewHierarchyManager {
     UiThreadUtil.assertOnUiThread();
     View v = mTagsToViews.get(tag);
     if (v == null) {
-      throw new NoSuchNativeViewException("No native view for " + tag + " currently exists");
+      throw new IllegalViewOperationException("No native view for " + tag + " currently exists");
     }
 
     v.getLocationOnScreen(outputBuffer);

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactRoot.kt

@@ -0,0 +1,66 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.uimanager
+
+import android.os.Bundle
+import android.view.ViewGroup
+import com.facebook.react.uimanager.common.UIManagerType
+import java.util.concurrent.atomic.AtomicInteger
+
+/** Interface for the root native view of a React native application */
+public interface ReactRoot {
+
+  public companion object {
+    /** This constant represents that ReactRoot hasn't started yet or it has been destroyed. */
+    public const val STATE_STOPPED: Int = 0
+
+    /** This constant represents that ReactRoot has started. */
+    public const val STATE_STARTED: Int = 1
+  }
+
+  /** Return cached launch properties for app */
+  public fun getAppProperties(): Bundle?
+
+  public fun getJSModuleName(): String
+
+  /** Fabric or Default UI Manager, see [UIManagerType] */
+  @UIManagerType public fun getUIManagerType(): Int
+
+  public fun getRootViewTag(): Int
+
+  public fun setRootViewTag(rootViewTag: Int)
+
+  /** Calls into JS to start the React application. */
+  public fun runApplication()
+
+  /** Handler for stages [com.facebook.react.surface.ReactStage] */
+  public fun onStage(@ReactStage stage: Int)
+
+  /** Return native view for root */
+  public fun getRootViewGroup(): ViewGroup
+
+  /** @return Cached values for widthMeasureSpec. */
+  public fun getWidthMeasureSpec(): Int
+
+  /** @return Cached values for and heightMeasureSpec. */
+  public fun getHeightMeasureSpec(): Int
+
+  /** Sets a flag that determines whether to log that content appeared on next view added. */
+  public fun setShouldLogContentAppeared(shouldLogContentAppeared: Boolean)
+
+  /**
+   * @return a [String] that represents the root js application that is being rendered with this
+   *   [ReactRoot]
+   * @deprecated We recommend to not use this method as it is will be replaced in the near future.
+   */
+  @Deprecated("We recommend to not use this method as it is will be replaced in the near future.")
+  public fun getSurfaceID(): String?
+
+  /** @return an [AtomicInteger] that represents the state of the ReactRoot object. */
+  public fun getState(): AtomicInteger
+}

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java

@@ -106,8 +106,7 @@ public class ReactShadowNodeImpl implements ReactShadowNode<ReactShadowNodeImpl>
   public ReactShadowNodeImpl() {
     mDefaultPadding = new Spacing(0f);
     if (!isVirtual()) {
-      YogaNode node = YogaNodePool.get().acquire();
-      mYogaNode = node == null ? YogaNodeFactory.create(sYogaConfig) : node;
+      mYogaNode = YogaNodeFactory.create(sYogaConfig);
       mYogaNode.setData(this);
       Arrays.fill(mPadding, YogaConstants.UNDEFINED);
     } else {
@@ -1101,7 +1100,6 @@ public class ReactShadowNodeImpl implements ReactShadowNode<ReactShadowNodeImpl>
   public void dispose() {
     if (mYogaNode != null) {
       mYogaNode.reset();
-      YogaNodePool.get().release(mYogaNode);
     }
   }
 

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerHelper.kt

@@ -194,7 +194,8 @@ public object UIManagerHelper {
   public fun getSurfaceId(view: View): Int {
     if (view is ReactRoot) {
       val rootView = view as ReactRoot
-      return if (rootView.uiManagerType == UIManagerType.FABRIC) rootView.rootViewTag else -1
+      return if (rootView.getUIManagerType() == UIManagerType.FABRIC) rootView.getRootViewTag()
+      else -1
     }
 
     val reactTag = view.id

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java

@@ -219,7 +219,6 @@ public class UIManagerModule extends ReactContextBaseJavaModule
     ReactApplicationContext reactApplicationContext = getReactApplicationContext();
     reactApplicationContext.unregisterComponentCallbacks(mMemoryTrimCallback);
     reactApplicationContext.unregisterComponentCallbacks(mViewManagerRegistry);
-    YogaNodePool.get().clear();
     ViewManagerPropertyUpdater.clear();
   }
 
@@ -815,11 +814,7 @@ public class UIManagerModule extends ReactContextBaseJavaModule
   private static class MemoryTrimCallback implements ComponentCallbacks2 {
 
     @Override
-    public void onTrimMemory(int level) {
-      if (level >= TRIM_MEMORY_MODERATE) {
-        YogaNodePool.get().clear();
-      }
-    }
+    public void onTrimMemory(int level) {}
 
     @Override
     public void onConfigurationChanged(Configuration newConfig) {}

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java

@@ -418,7 +418,7 @@ public class UIViewOperationQueue {
     public void execute() {
       try {
         mNativeViewHierarchyManager.measure(mReactTag, mMeasureBuffer);
-      } catch (NoSuchNativeViewException e) {
+      } catch (IllegalViewOperationException e) {
         // Invoke with no args to signal failure and to allow JS to clean up the callback
         // handle.
         mCallback.invoke();
@@ -448,7 +448,7 @@ public class UIViewOperationQueue {
     public void execute() {
       try {
         mNativeViewHierarchyManager.measureInWindow(mReactTag, mMeasureBuffer);
-      } catch (NoSuchNativeViewException e) {
+      } catch (IllegalViewOperationException e) {
         // Invoke with no args to signal failure and to allow JS to clean up the callback
         // handle.
         mCallback.invoke();

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java

@@ -15,7 +15,6 @@ import androidx.annotation.Nullable;
 import com.facebook.common.logging.FLog;
 import com.facebook.react.bridge.BaseJavaModule;
 import com.facebook.react.bridge.ReactApplicationContext;
-import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.ReactNoCrashSoftException;
 import com.facebook.react.bridge.ReactSoftExceptionLogger;
 import com.facebook.react.bridge.ReadableArray;
@@ -487,11 +486,13 @@ public abstract class ViewManager<T extends View, C extends ReactShadowNode>
    * <p>Subclasses can override this method to implement custom resource prefetching for the
    * ViewManager.
    *
+   * @param surfaceId surface ID
    * @param reactContext {@link com.facebook.react.bridge.ReactContext} used for the view.
    * @param params {@link MapBuffer} prefetch request params defined in C++
    */
   @UnstableReactNativeAPI
-  public void experimental_prefetchResources(ReactContext reactContext, MapBuffer params) {
+  public void experimental_prefetchResources(
+      int surfaceId, ThemedReactContext reactContext, MapBuffer params) {
     return;
   }
 

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.kt

@@ -73,6 +73,9 @@ public object ViewProps {
   public const val ENABLED: String = "enabled"
   public const val BACKGROUND_COLOR: String = "backgroundColor"
   public const val BACKGROUND_IMAGE: String = "experimental_backgroundImage"
+  public const val BACKGROUND_SIZE: String = "experimental_backgroundSize"
+  public const val BACKGROUND_POSITION: String = "experimental_backgroundPosition"
+  public const val BACKGROUND_REPEAT: String = "experimental_backgroundRepeat"
   public const val FOREGROUND_COLOR: String = "foregroundColor"
   public const val COLOR: String = "color"
   public const val FONT_SIZE: String = "fontSize"

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/BackgroundDrawable.kt

@@ -11,18 +11,14 @@ import android.content.Context
 import android.graphics.Canvas
 import android.graphics.Color
 import android.graphics.ColorFilter
-import android.graphics.ComposeShader
 import android.graphics.Paint
 import android.graphics.Path
 import android.graphics.PixelFormat
-import android.graphics.PorterDuff
 import android.graphics.Rect
 import android.graphics.RectF
-import android.graphics.Shader
 import android.graphics.drawable.Drawable
 import com.facebook.react.uimanager.PixelUtil.dpToPx
 import com.facebook.react.uimanager.PixelUtil.pxToDp
-import com.facebook.react.uimanager.style.BackgroundImageLayer
 import com.facebook.react.uimanager.style.BorderInsets
 import com.facebook.react.uimanager.style.BorderRadiusStyle
 import com.facebook.react.uimanager.style.ComputedBorderRadius
@@ -59,14 +55,6 @@ internal class BackgroundDrawable(
   private var backgroundRect: RectF = RectF()
   private var backgroundRenderPath: Path? = null
 
-  var backgroundImageLayers: List<BackgroundImageLayer>? = null
-    set(value) {
-      if (field != value) {
-        field = value
-        invalidateSelf()
-      }
-    }
-
   private val backgroundPaint: Paint =
       Paint(Paint.ANTI_ALIAS_FLAG).apply {
         style = Paint.Style.FILL
@@ -123,24 +111,6 @@ internal class BackgroundDrawable(
       }
     }
 
-    backgroundPaint.alpha = 255
-    if (backgroundImageLayers != null && backgroundImageLayers?.isNotEmpty() == true) {
-      backgroundPaint.setShader(getBackgroundImageShader())
-      if (computedBorderRadius?.isUniform() == true && borderRadius?.hasRoundedBorders() == true) {
-        canvas.drawRoundRect(
-            backgroundRect,
-            computedBorderRadius?.topLeft?.horizontal?.dpToPx() ?: 0f,
-            computedBorderRadius?.topLeft?.vertical?.dpToPx() ?: 0f,
-            backgroundPaint,
-        )
-      } else if (borderRadius?.hasRoundedBorders() != true) {
-        canvas.drawRect(backgroundRect, backgroundPaint)
-      } else {
-        canvas.drawPath(checkNotNull(backgroundRenderPath), backgroundPaint)
-      }
-      backgroundPaint.setShader(null)
-    }
-    backgroundPaint.alpha = Color.alpha(backgroundColor)
     canvas.restore()
   }
 
@@ -154,24 +124,6 @@ internal class BackgroundDrawable(
         )
       }
 
-  private fun getBackgroundImageShader(): Shader? {
-    backgroundImageLayers?.let { layers ->
-      var compositeShader: Shader? = null
-      for (backgroundImageLayer in layers) {
-        val currentShader = backgroundImageLayer.getShader(bounds)
-
-        compositeShader =
-            if (compositeShader == null) {
-              currentShader
-            } else {
-              ComposeShader(currentShader, compositeShader, PorterDuff.Mode.SRC_OVER)
-            }
-      }
-      return compositeShader
-    }
-    return null
-  }
-
   private fun updatePath() {
     if (!needUpdatePath) {
       return