react-native-tvos 0.82.1-0 → 0.83.0-0

package/ReactCommon/react/utils/SharedFunction.h

@@ -29,27 +29,28 @@ class SharedFunction {
   using T = void(ArgumentT...);
 
   struct Pair {
-    Pair(std::function<T>&& function) : function(std::move(function)) {}
+    Pair(std::function<T> &&function) : function(std::move(function)) {}
     std::function<T> function;
     std::shared_mutex mutex{};
   };
 
  public:
-  SharedFunction(std::function<T>&& function = nullptr)
-      : pair_(std::make_shared<Pair>(std::move(function))) {}
+  SharedFunction(std::function<T> &&function = nullptr) : pair_(std::make_shared<Pair>(std::move(function))) {}
 
-  SharedFunction(const SharedFunction& other) = default;
-  SharedFunction(SharedFunction&& other) noexcept = default;
+  SharedFunction(const SharedFunction &other) = default;
+  SharedFunction(SharedFunction &&other) noexcept = default;
 
-  SharedFunction& operator=(const SharedFunction& other) = default;
-  SharedFunction& operator=(SharedFunction&& other) noexcept = default;
+  SharedFunction &operator=(const SharedFunction &other) = default;
+  SharedFunction &operator=(SharedFunction &&other) noexcept = default;
 
-  void assign(std::function<T> function) const {
+  void assign(std::function<T> function) const
+  {
     std::unique_lock lock(pair_->mutex);
     pair_->function = function;
   }
 
-  void operator()(ArgumentT... args) const {
+  void operator()(ArgumentT... args) const
+  {
     std::shared_lock lock(pair_->mutex);
     if (pair_->function) {
       pair_->function(args...);

package/ReactCommon/react/utils/SimpleThreadSafeCache.h

@@ -15,8 +15,7 @@
 namespace facebook::react {
 
 template <typename GeneratorT, typename ValueT>
-concept CacheGeneratorFunction = std::invocable<GeneratorT> &&
-    std::same_as<std::invoke_result_t<GeneratorT>, ValueT>;
+concept CacheGeneratorFunction = std::invocable<GeneratorT> && std::same_as<std::invoke_result_t<GeneratorT>, ValueT>;
 
 /*
  * Simple thread-safe LRU cache.
@@ -36,8 +35,8 @@ class SimpleThreadSafeCache {
    * generator function, stores it inside a cache and returns it.
    * Can be called from any thread.
    */
-  ValueT get(const KeyT& key, CacheGeneratorFunction<ValueT> auto generator)
-      const {
+  ValueT get(const KeyT &key, CacheGeneratorFunction<ValueT> auto generator) const
+  {
     return getMapIterator(key, std::move(generator))->second->second;
   }
 
@@ -47,9 +46,9 @@ class SimpleThreadSafeCache {
    * generator function, stores it inside a cache and returns it.
    * Can be called from any thread.
    */
-  std::pair<const KeyT*, const ValueT*> getWithKey(
-      const KeyT& key,
-      CacheGeneratorFunction<ValueT> auto generator) const {
+  std::pair<const KeyT *, const ValueT *> getWithKey(const KeyT &key, CacheGeneratorFunction<ValueT> auto generator)
+      const
+  {
     auto it = getMapIterator(key, std::move(generator));
     return std::make_pair(&it->first, &it->second->second);
   }
@@ -59,7 +58,8 @@ class SimpleThreadSafeCache {
    * If the value wasn't found in the cache, returns empty optional.
    * Can be called from any thread.
    */
-  std::optional<ValueT> get(const KeyT& key) const {
+  std::optional<ValueT> get(const KeyT &key) const
+  {
     std::lock_guard<std::mutex> lock(mutex_);
 
     if (auto it = map_.find(key); it != map_.end()) {
@@ -75,9 +75,8 @@ class SimpleThreadSafeCache {
   using EntryT = std::pair<KeyT, ValueT>;
   using iterator = typename std::list<EntryT>::iterator;
 
-  auto getMapIterator(
-      const KeyT& key,
-      CacheGeneratorFunction<ValueT> auto generator) const {
+  auto getMapIterator(const KeyT &key, CacheGeneratorFunction<ValueT> auto generator) const
+  {
     std::lock_guard<std::mutex> lock(mutex_);
 
     if (auto it = map_.find(key); it != map_.end()) {

package/ReactCommon/react/utils/Telemetry.h

@@ -30,13 +30,13 @@ using TelemetryDuration = std::chrono::nanoseconds;
 /*
  * Represents a time point which never happens.
  */
-static const TelemetryTimePoint kTelemetryUndefinedTimePoint =
-    TelemetryTimePoint::max();
+static const TelemetryTimePoint kTelemetryUndefinedTimePoint = TelemetryTimePoint::max();
 
 /*
  * Returns a time point representing the current point in time.
  */
-static inline TelemetryTimePoint telemetryTimePointNow() {
+static inline TelemetryTimePoint telemetryTimePointNow()
+{
   return TelemetryClock::now();
 }
 
@@ -45,28 +45,23 @@ static inline TelemetryTimePoint telemetryTimePointNow() {
  * point to a given time point. The epoch starting time point is not specified
  * but stays the same for an application run.
  */
-static inline int64_t telemetryTimePointToMilliseconds(
-    TelemetryTimePoint timePoint) {
-  return std::chrono::duration_cast<std::chrono::milliseconds>(
-             timePoint - TelemetryTimePoint{})
-      .count();
+static inline int64_t telemetryTimePointToMilliseconds(TelemetryTimePoint timePoint)
+{
+  return std::chrono::duration_cast<std::chrono::milliseconds>(timePoint - TelemetryTimePoint{}).count();
 }
 
 /*
  * Returns a number of seconds that passed from "Steady Clock" epoch starting
  * time point to a given time point.
  */
-static inline double telemetryTimePointToSteadyClockSeconds(
-    TelemetryTimePoint timePoint) {
+static inline double telemetryTimePointToSteadyClockSeconds(TelemetryTimePoint timePoint)
+{
   static_assert(
-      std::is_same<decltype(timePoint), std::chrono::steady_clock::time_point>::
-          value,
+      std::is_same<decltype(timePoint), std::chrono::steady_clock::time_point>::value,
       "`TelemetryClock` must be `std::chrono::steady_clock` to make the "
       "following implementation work correctly.");
 
-  auto nanoseconds = std::chrono::duration_cast<std::chrono::nanoseconds>(
-                         timePoint.time_since_epoch())
-                         .count();
+  auto nanoseconds = std::chrono::duration_cast<std::chrono::nanoseconds>(timePoint.time_since_epoch()).count();
   return (double)nanoseconds / 1.0e9;
 }
 
@@ -78,7 +73,8 @@ template <
     typename SourceTimePointT,
     typename DestnationClockT = typename DestinationTimePointT::clock,
     typename SourceClockT = typename SourceTimePointT::clock>
-DestinationTimePointT clockCast(SourceTimePointT timePoint) {
+DestinationTimePointT clockCast(SourceTimePointT timePoint)
+{
   auto sourseClockNow = SourceClockT::now();
   auto destinationClockNow = DestnationClockT::now();
   return std::chrono::time_point_cast<typename DestnationClockT::duration>(
@@ -90,13 +86,10 @@ DestinationTimePointT clockCast(SourceTimePointT timePoint) {
  * point to a given time point.
  * Also known as POSIX time or UNIX Timestamp.
  */
-static inline double telemetryTimePointToSecondsSinceEpoch(
-    TelemetryTimePoint timePoint) {
-  auto systemClockTimePoint =
-      clockCast<std::chrono::system_clock::time_point, TelemetryTimePoint>(
-          timePoint);
-  return (double)std::chrono::duration_cast<std::chrono::microseconds>(
-             systemClockTimePoint.time_since_epoch())
+static inline double telemetryTimePointToSecondsSinceEpoch(TelemetryTimePoint timePoint)
+{
+  auto systemClockTimePoint = clockCast<std::chrono::system_clock::time_point, TelemetryTimePoint>(timePoint);
+  return (double)std::chrono::duration_cast<std::chrono::microseconds>(systemClockTimePoint.time_since_epoch())
              .count() /
       1000000.0;
 }
@@ -104,10 +97,9 @@ static inline double telemetryTimePointToSecondsSinceEpoch(
 /*
  * Returns a number of milliseconds that represents the given duration object.
  */
-static inline int64_t telemetryDurationToMilliseconds(
-    TelemetryDuration duration) {
-  return std::chrono::duration_cast<std::chrono::milliseconds>(duration)
-      .count();
+static inline int64_t telemetryDurationToMilliseconds(TelemetryDuration duration)
+{
+  return std::chrono::duration_cast<std::chrono::milliseconds>(duration).count();
 }
 
 } // namespace facebook::react

package/ReactCommon/react/utils/TemplateStringLiteral.h

@@ -19,11 +19,13 @@ namespace facebook::react {
  */
 template <size_t N>
 struct TemplateStringLiteral {
-  /* implicit */ constexpr TemplateStringLiteral(const char (&str)[N]) {
+  /* implicit */ constexpr TemplateStringLiteral(const char (&str)[N])
+  { // NOLINT(modernize-avoid-c-arrays)
     std::copy_n(str, N, value.data());
   }
 
-  constexpr operator std::string_view() const {
+  constexpr operator std::string_view() const
+  {
     return {value.begin(), value.end() - 1};
   }
 

package/ReactCommon/react/utils/Uuid.cpp

@@ -0,0 +1,69 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "Uuid.h"
+
+#include <array>
+#include <iomanip>
+#include <random>
+#include <sstream>
+
+namespace {
+
+std::mt19937& getThreadLocalEngine() {
+  static thread_local std::random_device device;
+  static thread_local std::mt19937 engine(device());
+  return engine;
+}
+
+uint64_t randomUInt64(uint64_t max = std::numeric_limits<uint64_t>::max()) {
+  std::uniform_int_distribution<uint64_t> distribution(0, max);
+  return distribution(getThreadLocalEngine());
+}
+
+} // namespace
+
+namespace facebook::react {
+
+std::string generateRandomUuidString() {
+  static constexpr uint8_t kUuidLength = 16;
+  // see: https://tools.ietf.org/html/rfc4122#section-4.1.2 for reference
+  static constexpr uint8_t kTimeLowSegBufEnd = sizeof(uint32_t);
+  static constexpr uint8_t kTimeMidSegBufEnd =
+      kTimeLowSegBufEnd + sizeof(uint16_t);
+  static constexpr uint8_t kTimeHiAndVersionSegBufEnd =
+      kTimeMidSegBufEnd + sizeof(uint16_t);
+  static constexpr uint8_t kClockHiLoSegBufEnd =
+      kTimeHiAndVersionSegBufEnd + sizeof(uint16_t);
+  static constexpr uint8_t kNodeSegHiBufEnd =
+      kClockHiLoSegBufEnd + sizeof(uint16_t);
+
+  std::array<uint8_t, kUuidLength> uuidBytes;
+
+  *(uint64_t*)uuidBytes.data() = randomUInt64();
+  *(uint64_t*)(uuidBytes.data() + sizeof(uint64_t)) = randomUInt64();
+
+  // Conforming to RFC 4122: https://www.cryptosys.net/pki/uuid-rfc4122.html
+  uuidBytes[7] &= 0x0f;
+  uuidBytes[7] |= 0x40;
+  uuidBytes[9] &= 0x3f;
+  uuidBytes[9] |= 0x80;
+
+  std::stringstream ss;
+
+  ss << std::setfill('0') << std::setw(8) << std::right << std::hex
+     << *(uint32_t*)uuidBytes.data() << "-" << std::setw(4)
+     << *(uint16_t*)(uuidBytes.data() + kTimeLowSegBufEnd) << "-"
+     << *(uint16_t*)(uuidBytes.data() + kTimeMidSegBufEnd) << "-"
+     << *(uint16_t*)(uuidBytes.data() + kTimeHiAndVersionSegBufEnd) << "-"
+     << std::setw(8) << *(uint32_t*)(uuidBytes.data() + kNodeSegHiBufEnd)
+     << std::setw(4) << *(uint16_t*)(uuidBytes.data() + kClockHiLoSegBufEnd);
+
+  return ss.str();
+}
+
+} // namespace facebook::react

package/ReactCommon/react/utils/Uuid.h

@@ -0,0 +1,20 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <string>
+
+namespace facebook::react {
+
+/**
+ * Generates a random UUID version 4 string in the format
+ * xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx (lowercase).
+ */
+std::string generateRandomUuidString();
+
+} // namespace facebook::react

package/ReactCommon/react/utils/fnv1a.h

@@ -24,25 +24,27 @@ namespace facebook::react {
  * constexpr.
  */
 template <typename CharTransformT = std::identity>
-constexpr uint32_t fnv1a(std::string_view string) noexcept {
+constexpr uint32_t fnv1a(std::string_view string) noexcept
+{
   constexpr uint32_t offset_basis = 2166136261;
 
   uint32_t hash = offset_basis;
 
-  for (const auto& c : string) {
+  for (const auto &c : string) {
     hash ^= static_cast<int8_t>(CharTransformT{}(c));
     // Using shifts and adds instead of multiplication with a prime number.
     // This is faster when compiled with optimizations.
-    hash +=
-        (hash << 1) + (hash << 4) + (hash << 7) + (hash << 8) + (hash << 24);
+    hash += (hash << 1) + (hash << 4) + (hash << 7) + (hash << 8) + (hash << 24);
   }
 
   return hash;
 }
 
-constexpr uint32_t fnv1aLowercase(std::string_view string) {
+constexpr uint32_t fnv1aLowercase(std::string_view string)
+{
   struct LowerCaseTransform {
-    constexpr char operator()(char c) const {
+    constexpr char operator()(char c) const
+    {
       return toLower(c);
     }
   };

package/ReactCommon/react/utils/hash_combine.h

@@ -13,18 +13,20 @@
 namespace facebook::react {
 
 template <typename T>
-concept Hashable = !std::is_same_v<T, const char*> && (requires(T a) {
+concept Hashable = !std::is_same_v<T, const char *> && (requires(T a) {
   { std::hash<T>{}(a) } -> std::convertible_to<std::size_t>;
 });
 
 template <Hashable T, Hashable... Rest>
-void hash_combine(std::size_t& seed, const T& v, const Rest&... rest) {
+void hash_combine(std::size_t &seed, const T &v, const Rest &...rest)
+{
   seed ^= std::hash<T>{}(v) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
   (hash_combine(seed, rest), ...);
 }
 
 template <Hashable T, Hashable... Args>
-std::size_t hash_combine(const T& v, const Args&... args) {
+std::size_t hash_combine(const T &v, const Args &...args)
+{
   std::size_t seed = 0;
   hash_combine<T, Args...>(seed, v, args...);
   return seed;

package/ReactCommon/react/utils/iequals.h

@@ -15,7 +15,8 @@ namespace facebook::react {
 /**
  * constexpr check for case insensitive equality of two strings.
  */
-constexpr bool iequals(std::string_view a, std::string_view b) {
+constexpr bool iequals(std::string_view a, std::string_view b)
+{
   if (a.size() != b.size()) {
     return false;
   }

package/ReactCommon/react/utils/jsi-utils.h

@@ -23,9 +23,6 @@ namespace facebook::react {
  *   value: value
  * })
  */
-void defineReadOnlyGlobal(
-    jsi::Runtime& runtime,
-    const std::string& propName,
-    jsi::Value&& value);
+void defineReadOnlyGlobal(jsi::Runtime &runtime, const std::string &propName, jsi::Value &&value);
 
 } // namespace facebook::react

package/ReactCommon/react/utils/platform/android/react/utils/LowPriorityExecutor.cpp

@@ -18,7 +18,7 @@ namespace facebook::react::LowPriorityExecutor {
 struct LowPriorityExecutorThread {
   LowPriorityExecutorThread() : thread_{std::thread([this] { run(); })} {
     pthread_t hThread = thread_.native_handle();
-    struct sched_param param {};
+    struct sched_param param{};
     param.sched_priority = 19; // Higher value means lower priority
     pthread_setschedparam(hThread, SCHED_OTHER, &param);
   }

package/ReactCommon/react/utils/platform/android/react/utils/LowPriorityExecutor.h

@@ -9,6 +9,6 @@
 
 namespace facebook::react::LowPriorityExecutor {
 
-void execute(std::function<void()>&& workItem);
+void execute(std::function<void()> &&workItem);
 
 } // namespace facebook::react::LowPriorityExecutor

package/ReactCommon/react/utils/platform/cxx/react/utils/LowPriorityExecutor.h

@@ -11,7 +11,8 @@
 
 namespace facebook::react::LowPriorityExecutor {
 
-inline void execute(std::function<void()>&& workItem) {
+inline void execute(std::function<void()> &&workItem)
+{
   workItem();
 }
 

package/ReactCommon/react/utils/platform/ios/react/utils/FollyConvert.mm

@@ -33,7 +33,7 @@ id convertFollyDynamicToId(const folly::dynamic &dyn)
       NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:dyn.size()];
       for (const auto &elem : dyn) {
         id value = convertFollyDynamicToId(elem);
-        if (value) {
+        if (value != nullptr) {
           [array addObject:value];
         }
       }
@@ -44,7 +44,7 @@ id convertFollyDynamicToId(const folly::dynamic &dyn)
       for (const auto &elem : dyn.items()) {
         id key = convertFollyDynamicToId(elem.first);
         id value = convertFollyDynamicToId(elem.second);
-        if (key && value) {
+        if ((key != nullptr) && (value != nullptr)) {
           dict[key] = value;
         }
       }

package/ReactCommon/react/utils/platform/ios/react/utils/LowPriorityExecutor.h

@@ -11,6 +11,6 @@
 
 namespace facebook::react::LowPriorityExecutor {
 
-void execute(std::function<void()>&& workItem);
+void execute(std::function<void()> &&workItem);
 
 } // namespace facebook::react::LowPriorityExecutor

package/ReactCommon/react/utils/tests/UuidTest.cpp

@@ -0,0 +1,28 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include <react/utils/Uuid.h>
+
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+using namespace ::testing;
+
+namespace facebook::react {
+
+TEST(UuidTest, TestGenerateRandomUuidString) {
+  static constexpr auto kUuidV4Regex =
+      "[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}";
+
+  std::string uuid1 = generateRandomUuidString();
+  std::string uuid2 = generateRandomUuidString();
+  EXPECT_THAT(uuid1, MatchesRegex(kUuidV4Regex));
+  EXPECT_THAT(uuid2, MatchesRegex(kUuidV4Regex));
+  EXPECT_NE(uuid1, uuid2);
+}
+
+} // namespace facebook::react

package/ReactCommon/react/utils/tests/hash_combineTests.cpp

@@ -67,8 +67,8 @@ TEST(hash_combineTests, testStrings) {
 }
 
 TEST(hash_combineTests, testCustomTypes) {
-  auto person1 = Person{"John", "Doe"};
-  auto person2 = Person{"Jane", "Doe"};
+  auto person1 = Person{.firstName = "John", .lastName = "Doe"};
+  auto person2 = Person{.firstName = "Jane", .lastName = "Doe"};
 
   std::size_t seed = 0;
   hash_combine(seed, person1);

package/ReactCommon/react/utils/toLower.h

@@ -12,7 +12,8 @@ namespace facebook::react {
 /**
  * constexpr version of tolower
  */
-constexpr char toLower(char c) {
+constexpr char toLower(char c)
+{
   if (c >= 'A' && c <= 'Z') {
     return static_cast<char>(c + 32);
   }

package/ReactCommon/react/utils/to_underlying.h

@@ -15,7 +15,8 @@ namespace facebook::react {
  * Polyfill of C++ 23 to_underlying()
  * https://en.cppreference.com/w/cpp/utility/to_underlying
  */
-constexpr auto to_underlying(auto e) noexcept {
+constexpr auto to_underlying(auto e) noexcept
+{
   return static_cast<std::underlying_type_t<decltype(e)>>(e);
 }
 

package/ReactCommon/reactperflogger/fusebox/FuseboxTracer.cpp

@@ -52,16 +52,18 @@ bool FuseboxTracer::stopTracing(
   auto traceEvents = folly::dynamic::array();
 
   // Register "Main" process
-  traceEvents.push_back(folly::dynamic::object(
-      "args", folly::dynamic::object("name", "Main"))("cat", "__metadata")(
-      "name", "process_name")("ph", "M")("pid", PID)("tid", 0)("ts", 0));
+  traceEvents.push_back(
+      folly::dynamic::object("args", folly::dynamic::object("name", "Main"))(
+          "cat", "__metadata")("name", "process_name")("ph", "M")("pid", PID)(
+          "tid", 0)("ts", 0));
   // Register "Timings" track
   // NOTE: This is a hack to make the trace viewer show a "Timings" track
   // adjacent to custom tracks in our current build of Chrome DevTools.
   // In future, we should align events exactly.
-  traceEvents.push_back(folly::dynamic::object(
-      "args", folly::dynamic::object("name", "Timings"))("cat", "__metadata")(
-      "name", "thread_name")("ph", "M")("pid", PID)("tid", 1000)("ts", 0));
+  traceEvents.push_back(
+      folly::dynamic::object("args", folly::dynamic::object("name", "Timings"))(
+          "cat", "__metadata")("name", "thread_name")("ph", "M")("pid", PID)(
+          "tid", 1000)("ts", 0));
 
   auto savedBuffer = std::move(buffer_);
   buffer_.clear();
@@ -73,20 +75,22 @@ bool FuseboxTracer::stopTracing(
     if (!event.track.empty() && !trackIdMap.contains(event.track)) {
       auto trackId = nextTrack++;
       trackIdMap[event.track] = trackId;
-      traceEvents.push_back(folly::dynamic::object(
-          "args", folly::dynamic::object("name", event.track))(
-          "cat", "__metadata")("name", "thread_name")("ph", "M")("pid", PID)(
-          "tid", trackId)("ts", 0));
+      traceEvents.push_back(
+          folly::dynamic::object(
+              "args", folly::dynamic::object("name", event.track))(
+              "cat", "__metadata")("name", "thread_name")("ph", "M")(
+              "pid", PID)("tid", trackId)("ts", 0));
     }
 
     auto trackId =
         trackIdMap.contains(event.track) ? trackIdMap[event.track] : 1000;
 
     // Emit "blink.user_timing" trace event
-    traceEvents.push_back(folly::dynamic::object(
-        "args", folly::dynamic::object())("cat", "blink.user_timing")(
-        "dur", (event.end - event.start) * 1000)("name", event.name)("ph", "X")(
-        "ts", event.start * 1000)("pid", PID)("tid", trackId));
+    traceEvents.push_back(
+        folly::dynamic::object("args", folly::dynamic::object())(
+            "cat", "blink.user_timing")(
+            "dur", (event.end - event.start) * 1000)("name", event.name)(
+            "ph", "X")("ts", event.start * 1000)("pid", PID)("tid", trackId));
 
     if (traceEvents.size() >= 1000) {
       resultCallback(traceEvents);
@@ -109,8 +113,12 @@ void FuseboxTracer::addEvent(
   if (!tracing_) {
     return;
   }
-  buffer_.push_back(BufferEvent{
-      start, end, std::string(name), std::string(track.value_or(""))});
+  buffer_.push_back(
+      BufferEvent{
+          .start = start,
+          .end = end,
+          .name = std::string(name),
+          .track = std::string(track.value_or(""))});
 }
 
 bool FuseboxTracer::stopTracingAndWriteToFile(const std::string& path) {

package/ReactCommon/reactperflogger/fusebox/FuseboxTracer.h

@@ -28,7 +28,7 @@ struct BufferEvent {
  */
 class FuseboxTracer {
  public:
-  FuseboxTracer(const FuseboxTracer&) = delete;
+  FuseboxTracer(const FuseboxTracer &) = delete;
 
   bool isTracing();
   // Verifies that tracing isn't started and starts tracing all in one step.
@@ -37,16 +37,12 @@ class FuseboxTracer {
   // Verifies that we're tracing and dumps the trace all in one step to avoid
   // TOCTOU bugs. Returns false if we're not tracing. No result callbacks
   // are expected in that scenario.
-  bool stopTracing(const std::function<void(const folly::dynamic& eventsChunk)>&
-                       resultCallback);
-  bool stopTracingAndWriteToFile(const std::string& path);
-  void addEvent(
-      const std::string_view& name,
-      uint64_t start,
-      uint64_t end,
-      const std::optional<std::string_view>& track);
-
-  static FuseboxTracer& getFuseboxTracer();
+  bool stopTracing(const std::function<void(const folly::dynamic &eventsChunk)> &resultCallback);
+  bool stopTracingAndWriteToFile(const std::string &path);
+  void
+  addEvent(const std::string_view &name, uint64_t start, uint64_t end, const std::optional<std::string_view> &track);
+
+  static FuseboxTracer &getFuseboxTracer();
 
  private:
   FuseboxTracer() {}