react-native-audio-browser 0.2.0-next.53 → 0.2.0-next.55

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (599) hide show
  1. package/README.md +32 -19
  2. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  3. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  5. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  6. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  7. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  8. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  9. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  10. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  11. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  12. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  13. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  15. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  16. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  17. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  18. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  19. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  20. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  21. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  22. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  23. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  24. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  25. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  26. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  27. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  28. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  29. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  30. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  31. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  32. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  33. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  34. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  35. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  36. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  37. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  38. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  39. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  40. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  41. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  42. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  43. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  45. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  46. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  50. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  51. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  52. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  53. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  54. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  55. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  56. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  58. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  59. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  60. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  61. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  63. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  64. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  66. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +28 -48
  67. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  68. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  71. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  78. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  80. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  81. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  82. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  84. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  85. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  86. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  90. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  91. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  92. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  93. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  94. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  96. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  97. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  98. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  99. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  100. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  102. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  103. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  104. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  105. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  106. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  107. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  108. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  109. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  110. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  111. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  112. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  113. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  114. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  115. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  116. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  121. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  122. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  123. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  124. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  125. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  126. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  127. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  128. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  129. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  130. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  131. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  132. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  133. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  134. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  135. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  136. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  137. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  138. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  139. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  143. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  144. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +2 -2
  145. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  146. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +5 -1
  149. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  150. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  151. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  152. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  153. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  154. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  155. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  156. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +9 -10
  157. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +0 -1
  158. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  159. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  167. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  168. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  169. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  170. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  172. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  174. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  175. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  177. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  178. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  179. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  180. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  181. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  183. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  184. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  185. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  186. package/ios/AVPlayerEngine.swift +13 -21
  187. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  188. package/ios/Browser/BrowseGate.swift +7 -8
  189. package/ios/Browser/BrowserConfig.swift +19 -34
  190. package/ios/Browser/BrowserError.swift +0 -1
  191. package/ios/Browser/BrowserManager.swift +29 -75
  192. package/ios/Browser/BrowserPathHelper.swift +13 -93
  193. package/ios/Browser/FavoriteSet.swift +7 -10
  194. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  195. package/ios/Browser/JsonModels.swift +11 -51
  196. package/ios/Browser/NavigationErrorState.swift +3 -2
  197. package/ios/Browser/PageResolver.swift +13 -23
  198. package/ios/Browser/RequestLayer.swift +16 -20
  199. package/ios/Browser/RequestPipeline.swift +33 -43
  200. package/ios/Browser/SearchDrillIn.swift +7 -13
  201. package/ios/Browser/SectionScope.swift +14 -26
  202. package/ios/Browser/SimpleRouter.swift +8 -15
  203. package/ios/Browser/StyleResolver.swift +12 -29
  204. package/ios/Browser/TabBarEntries.swift +6 -11
  205. package/ios/Browser/TrackIdTemplate.swift +6 -14
  206. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  207. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  208. package/ios/CarPlay/CarPlayController.swift +4 -4
  209. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  210. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  211. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  212. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  213. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  214. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  215. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  216. package/ios/CarPlay/CarPlaySession.swift +13 -17
  217. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  218. package/ios/CarPlay/IntentHandlers.swift +3 -5
  219. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  220. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  221. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  222. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  223. package/ios/CarPlay/SectionPresentation.swift +18 -28
  224. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  225. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  226. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  227. package/ios/Extension/CxxVectorConformances.swift +4 -16
  228. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  229. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  230. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  231. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  232. package/ios/Extension/SearchParams+Query.swift +4 -4
  233. package/ios/Extension/Section+Copying.swift +3 -6
  234. package/ios/Extension/String+IcyCharset.swift +5 -5
  235. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  236. package/ios/Extension/Track+AVPlayer.swift +1 -2
  237. package/ios/Extension/Track+Copying.swift +2 -8
  238. package/ios/Extension/Track+Identity.swift +4 -9
  239. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  240. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  241. package/ios/Extension/Variant+Artwork.swift +8 -22
  242. package/ios/Http/HttpClient.swift +3 -3
  243. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  244. package/ios/HybridAudioBrowser+Options.swift +6 -9
  245. package/ios/HybridAudioBrowser+Player.swift +8 -16
  246. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  247. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  248. package/ios/HybridAudioBrowser.swift +54 -79
  249. package/ios/Model/NitroTypeStubs.swift +15 -22
  250. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  251. package/ios/Model/RemoteCommand.swift +2 -2
  252. package/ios/Model/TrackPlayerError.swift +9 -22
  253. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  254. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  255. package/ios/Observer/ItemObserver.swift +7 -5
  256. package/ios/Observer/PlayerObserver.swift +5 -5
  257. package/ios/PlaybackEvent.swift +2 -2
  258. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  259. package/ios/Player/AudioSessionController.swift +14 -15
  260. package/ios/Player/DeferredSeek.swift +2 -2
  261. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  262. package/ios/Player/ErrorStatus.swift +8 -7
  263. package/ios/Player/MediaLoader.swift +20 -24
  264. package/ios/Player/NowPlayingLines.swift +1 -4
  265. package/ios/Player/NowPlayingUpdater.swift +35 -61
  266. package/ios/Player/PersistedPlaybackState.swift +1 -2
  267. package/ios/Player/PlaybackFailure.swift +20 -24
  268. package/ios/Player/PlaybackPersistence.swift +5 -6
  269. package/ios/Player/PlaybackStateMachine.swift +8 -11
  270. package/ios/Player/PlaybackTimer.swift +8 -11
  271. package/ios/Player/Player.swift +6 -13
  272. package/ios/Player/PlayerEngine.swift +20 -20
  273. package/ios/Player/PlayerStatusTypes.swift +1 -2
  274. package/ios/Player/QueueManager.swift +23 -67
  275. package/ios/Player/RetryLoop.swift +39 -50
  276. package/ios/Player/ShuffleOrder.swift +17 -57
  277. package/ios/Player/SleepTimerManager.swift +13 -28
  278. package/ios/Player/VolumeFader.swift +16 -16
  279. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  280. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  281. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  282. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  283. package/ios/Tests/DeferredSeekTests.swift +1 -3
  284. package/ios/Tests/EmitterTests.swift +0 -1
  285. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  286. package/ios/Tests/FavoriteSetTests.swift +1 -0
  287. package/ios/Tests/GenerationMemoTests.swift +2 -2
  288. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  289. package/ios/Tests/JsonModelsTests.swift +5 -12
  290. package/ios/Tests/LRUCacheTests.swift +1 -5
  291. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  292. package/ios/Tests/MediaLoaderTests.swift +3 -12
  293. package/ios/Tests/ObserverTests.swift +3 -3
  294. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  295. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  296. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  297. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  298. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  299. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  300. package/ios/Tests/PlayerTests.swift +53 -88
  301. package/ios/Tests/PlayingStateTests.swift +0 -1
  302. package/ios/Tests/QueueManagerTests.swift +30 -80
  303. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  304. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  305. package/ios/Tests/RetryLoopTests.swift +12 -35
  306. package/ios/Tests/SearchDrillInTests.swift +4 -5
  307. package/ios/Tests/SectionPresentationTests.swift +3 -16
  308. package/ios/Tests/SectionScopeTests.swift +3 -6
  309. package/ios/Tests/SimpleRouterTests.swift +1 -5
  310. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  311. package/ios/Tests/StyleResolverTests.swift +4 -13
  312. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  313. package/ios/Tests/Support/TestTypes.swift +5 -15
  314. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  315. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  316. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  317. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  318. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  319. package/ios/Tests/TrackSelectorTests.swift +3 -15
  320. package/ios/TrackSelector.swift +13 -25
  321. package/ios/Util/ArtworkFreshness.swift +6 -6
  322. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  323. package/ios/Util/ConcurrentMap.swift +2 -2
  324. package/ios/Util/Emitter.swift +8 -13
  325. package/ios/Util/NetworkMonitor.swift +4 -6
  326. package/ios/Util/OutputPicker.swift +1 -1
  327. package/ios/Util/ReadyValue.swift +3 -2
  328. package/ios/Util/SFSymbolRenderer.swift +17 -30
  329. package/ios/Util/SVGProcessor.swift +5 -9
  330. package/lib/commonjs/CLAUDE.md +7 -2
  331. package/lib/commonjs/features/battery.js +16 -12
  332. package/lib/commonjs/features/battery.js.map +1 -1
  333. package/lib/commonjs/features/browser-config.js +1 -1
  334. package/lib/commonjs/features/browser.js +74 -24
  335. package/lib/commonjs/features/browser.js.map +1 -1
  336. package/lib/commonjs/features/carConnection.js +3 -4
  337. package/lib/commonjs/features/carConnection.js.map +1 -1
  338. package/lib/commonjs/features/equalizer.js +9 -5
  339. package/lib/commonjs/features/equalizer.js.map +1 -1
  340. package/lib/commonjs/features/errors.js +35 -21
  341. package/lib/commonjs/features/errors.js.map +1 -1
  342. package/lib/commonjs/features/favorites.js +15 -13
  343. package/lib/commonjs/features/favorites.js.map +1 -1
  344. package/lib/commonjs/features/gate.js +12 -6
  345. package/lib/commonjs/features/gate.js.map +1 -1
  346. package/lib/commonjs/features/metadata.js +16 -14
  347. package/lib/commonjs/features/metadata.js.map +1 -1
  348. package/lib/commonjs/features/network.js +5 -1
  349. package/lib/commonjs/features/network.js.map +1 -1
  350. package/lib/commonjs/features/nowPlaying.js +28 -14
  351. package/lib/commonjs/features/nowPlaying.js.map +1 -1
  352. package/lib/commonjs/features/output.js +8 -4
  353. package/lib/commonjs/features/output.js.map +1 -1
  354. package/lib/commonjs/features/playback/controls.js +10 -5
  355. package/lib/commonjs/features/playback/controls.js.map +1 -1
  356. package/lib/commonjs/features/playback/playWhenReady.js +6 -5
  357. package/lib/commonjs/features/playback/playWhenReady.js.map +1 -1
  358. package/lib/commonjs/features/playback/playing.js +5 -3
  359. package/lib/commonjs/features/playback/playing.js.map +1 -1
  360. package/lib/commonjs/features/playback/progress.js +11 -5
  361. package/lib/commonjs/features/playback/progress.js.map +1 -1
  362. package/lib/commonjs/features/playback/state.js +3 -3
  363. package/lib/commonjs/features/playback/state.js.map +1 -1
  364. package/lib/commonjs/features/playback/trackPlaybackTime.js +6 -1
  365. package/lib/commonjs/features/playback/trackPlaybackTime.js.map +1 -1
  366. package/lib/commonjs/features/playback/volume.js +6 -5
  367. package/lib/commonjs/features/playback/volume.js.map +1 -1
  368. package/lib/commonjs/features/player/options.js +20 -10
  369. package/lib/commonjs/features/player/options.js.map +1 -1
  370. package/lib/commonjs/features/player/setup.js +34 -38
  371. package/lib/commonjs/features/player/setup.js.map +1 -1
  372. package/lib/commonjs/features/queue/activeTrack.js +0 -1
  373. package/lib/commonjs/features/queue/activeTrack.js.map +1 -1
  374. package/lib/commonjs/features/queue/queue.js +48 -20
  375. package/lib/commonjs/features/queue/queue.js.map +1 -1
  376. package/lib/commonjs/features/queue/repeatMode.js +2 -1
  377. package/lib/commonjs/features/queue/repeatMode.js.map +1 -1
  378. package/lib/commonjs/features/queue/shuffle.js +0 -1
  379. package/lib/commonjs/features/queue/shuffle.js.map +1 -1
  380. package/lib/commonjs/features/remoteControls.js +59 -35
  381. package/lib/commonjs/features/remoteControls.js.map +1 -1
  382. package/lib/commonjs/features/sleepTimer.js +15 -6
  383. package/lib/commonjs/features/sleepTimer.js.map +1 -1
  384. package/lib/commonjs/utils/LazyNativeEmitter.js +6 -9
  385. package/lib/commonjs/utils/LazyNativeEmitter.js.map +1 -1
  386. package/lib/commonjs/utils/NativeUpdatedValue.js +13 -12
  387. package/lib/commonjs/utils/NativeUpdatedValue.js.map +1 -1
  388. package/lib/commonjs/utils/getTrackIdentity.js +6 -4
  389. package/lib/commonjs/utils/getTrackIdentity.js.map +1 -1
  390. package/lib/commonjs/utils/useDebug.js +16 -3
  391. package/lib/commonjs/utils/useDebug.js.map +1 -1
  392. package/lib/commonjs/web/NativeAudioBrowser.js +2 -4
  393. package/lib/commonjs/web/NativeAudioBrowser.js.map +1 -1
  394. package/lib/commonjs/web/browser/parseSearchResponse.js +3 -4
  395. package/lib/commonjs/web/browser/parseSearchResponse.js.map +1 -1
  396. package/lib/commonjs/web/browser/sections.js +1 -1
  397. package/lib/commonjs/web/util/BrowserPathHelper.js +1 -3
  398. package/lib/commonjs/web/util/BrowserPathHelper.js.map +1 -1
  399. package/lib/module/CLAUDE.md +7 -2
  400. package/lib/module/features/battery.js +16 -12
  401. package/lib/module/features/battery.js.map +1 -1
  402. package/lib/module/features/browser-config.js +1 -1
  403. package/lib/module/features/browser.js +74 -24
  404. package/lib/module/features/browser.js.map +1 -1
  405. package/lib/module/features/carConnection.js +3 -4
  406. package/lib/module/features/carConnection.js.map +1 -1
  407. package/lib/module/features/equalizer.js +9 -5
  408. package/lib/module/features/equalizer.js.map +1 -1
  409. package/lib/module/features/errors.js +35 -21
  410. package/lib/module/features/errors.js.map +1 -1
  411. package/lib/module/features/favorites.js +15 -13
  412. package/lib/module/features/favorites.js.map +1 -1
  413. package/lib/module/features/gate.js +12 -6
  414. package/lib/module/features/gate.js.map +1 -1
  415. package/lib/module/features/metadata.js +16 -14
  416. package/lib/module/features/metadata.js.map +1 -1
  417. package/lib/module/features/network.js +5 -1
  418. package/lib/module/features/network.js.map +1 -1
  419. package/lib/module/features/nowPlaying.js +28 -14
  420. package/lib/module/features/nowPlaying.js.map +1 -1
  421. package/lib/module/features/output.js +8 -4
  422. package/lib/module/features/output.js.map +1 -1
  423. package/lib/module/features/playback/controls.js +10 -5
  424. package/lib/module/features/playback/controls.js.map +1 -1
  425. package/lib/module/features/playback/playWhenReady.js +6 -5
  426. package/lib/module/features/playback/playWhenReady.js.map +1 -1
  427. package/lib/module/features/playback/playing.js +5 -3
  428. package/lib/module/features/playback/playing.js.map +1 -1
  429. package/lib/module/features/playback/progress.js +11 -5
  430. package/lib/module/features/playback/progress.js.map +1 -1
  431. package/lib/module/features/playback/state.js +3 -3
  432. package/lib/module/features/playback/state.js.map +1 -1
  433. package/lib/module/features/playback/trackPlaybackTime.js +6 -1
  434. package/lib/module/features/playback/trackPlaybackTime.js.map +1 -1
  435. package/lib/module/features/playback/volume.js +6 -5
  436. package/lib/module/features/playback/volume.js.map +1 -1
  437. package/lib/module/features/player/options.js +20 -10
  438. package/lib/module/features/player/options.js.map +1 -1
  439. package/lib/module/features/player/setup.js +34 -38
  440. package/lib/module/features/player/setup.js.map +1 -1
  441. package/lib/module/features/queue/activeTrack.js +0 -1
  442. package/lib/module/features/queue/activeTrack.js.map +1 -1
  443. package/lib/module/features/queue/queue.js +48 -20
  444. package/lib/module/features/queue/queue.js.map +1 -1
  445. package/lib/module/features/queue/repeatMode.js +2 -1
  446. package/lib/module/features/queue/repeatMode.js.map +1 -1
  447. package/lib/module/features/queue/shuffle.js +0 -1
  448. package/lib/module/features/queue/shuffle.js.map +1 -1
  449. package/lib/module/features/remoteControls.js +59 -35
  450. package/lib/module/features/remoteControls.js.map +1 -1
  451. package/lib/module/features/sleepTimer.js +15 -6
  452. package/lib/module/features/sleepTimer.js.map +1 -1
  453. package/lib/module/utils/LazyNativeEmitter.js +6 -9
  454. package/lib/module/utils/LazyNativeEmitter.js.map +1 -1
  455. package/lib/module/utils/NativeUpdatedValue.js +13 -12
  456. package/lib/module/utils/NativeUpdatedValue.js.map +1 -1
  457. package/lib/module/utils/getTrackIdentity.js +6 -4
  458. package/lib/module/utils/getTrackIdentity.js.map +1 -1
  459. package/lib/module/utils/useDebug.js +16 -3
  460. package/lib/module/utils/useDebug.js.map +1 -1
  461. package/lib/module/web/NativeAudioBrowser.js +2 -4
  462. package/lib/module/web/NativeAudioBrowser.js.map +1 -1
  463. package/lib/module/web/browser/parseSearchResponse.js +3 -4
  464. package/lib/module/web/browser/parseSearchResponse.js.map +1 -1
  465. package/lib/module/web/browser/sections.js +1 -1
  466. package/lib/module/web/util/BrowserPathHelper.js +1 -3
  467. package/lib/module/web/util/BrowserPathHelper.js.map +1 -1
  468. package/lib/typescript/src/features/battery.d.ts +17 -12
  469. package/lib/typescript/src/features/battery.d.ts.map +1 -1
  470. package/lib/typescript/src/features/browser.d.ts +64 -24
  471. package/lib/typescript/src/features/browser.d.ts.map +1 -1
  472. package/lib/typescript/src/features/carConnection.d.ts +3 -4
  473. package/lib/typescript/src/features/carConnection.d.ts.map +1 -1
  474. package/lib/typescript/src/features/equalizer.d.ts +9 -5
  475. package/lib/typescript/src/features/equalizer.d.ts.map +1 -1
  476. package/lib/typescript/src/features/errors.d.ts +37 -22
  477. package/lib/typescript/src/features/errors.d.ts.map +1 -1
  478. package/lib/typescript/src/features/favorites.d.ts +15 -13
  479. package/lib/typescript/src/features/favorites.d.ts.map +1 -1
  480. package/lib/typescript/src/features/gate.d.ts +14 -8
  481. package/lib/typescript/src/features/gate.d.ts.map +1 -1
  482. package/lib/typescript/src/features/metadata.d.ts +37 -17
  483. package/lib/typescript/src/features/metadata.d.ts.map +1 -1
  484. package/lib/typescript/src/features/network.d.ts +5 -1
  485. package/lib/typescript/src/features/network.d.ts.map +1 -1
  486. package/lib/typescript/src/features/nowPlaying.d.ts +28 -14
  487. package/lib/typescript/src/features/nowPlaying.d.ts.map +1 -1
  488. package/lib/typescript/src/features/output.d.ts +8 -4
  489. package/lib/typescript/src/features/output.d.ts.map +1 -1
  490. package/lib/typescript/src/features/playback/controls.d.ts +10 -5
  491. package/lib/typescript/src/features/playback/controls.d.ts.map +1 -1
  492. package/lib/typescript/src/features/playback/playWhenReady.d.ts +6 -5
  493. package/lib/typescript/src/features/playback/playWhenReady.d.ts.map +1 -1
  494. package/lib/typescript/src/features/playback/playing.d.ts +16 -3
  495. package/lib/typescript/src/features/playback/playing.d.ts.map +1 -1
  496. package/lib/typescript/src/features/playback/progress.d.ts +11 -5
  497. package/lib/typescript/src/features/playback/progress.d.ts.map +1 -1
  498. package/lib/typescript/src/features/playback/state.d.ts +8 -3
  499. package/lib/typescript/src/features/playback/state.d.ts.map +1 -1
  500. package/lib/typescript/src/features/playback/trackPlaybackTime.d.ts +9 -2
  501. package/lib/typescript/src/features/playback/trackPlaybackTime.d.ts.map +1 -1
  502. package/lib/typescript/src/features/playback/volume.d.ts +6 -5
  503. package/lib/typescript/src/features/playback/volume.d.ts.map +1 -1
  504. package/lib/typescript/src/features/player/options.d.ts +52 -37
  505. package/lib/typescript/src/features/player/options.d.ts.map +1 -1
  506. package/lib/typescript/src/features/player/setup.d.ts +65 -60
  507. package/lib/typescript/src/features/player/setup.d.ts.map +1 -1
  508. package/lib/typescript/src/features/queue/activeTrack.d.ts +0 -1
  509. package/lib/typescript/src/features/queue/activeTrack.d.ts.map +1 -1
  510. package/lib/typescript/src/features/queue/queue.d.ts +48 -20
  511. package/lib/typescript/src/features/queue/queue.d.ts.map +1 -1
  512. package/lib/typescript/src/features/queue/repeatMode.d.ts +1 -1
  513. package/lib/typescript/src/features/queue/repeatMode.d.ts.map +1 -1
  514. package/lib/typescript/src/features/queue/shuffle.d.ts +0 -1
  515. package/lib/typescript/src/features/queue/shuffle.d.ts.map +1 -1
  516. package/lib/typescript/src/features/remoteControls.d.ts +58 -25
  517. package/lib/typescript/src/features/remoteControls.d.ts.map +1 -1
  518. package/lib/typescript/src/features/sleepTimer.d.ts +15 -7
  519. package/lib/typescript/src/features/sleepTimer.d.ts.map +1 -1
  520. package/lib/typescript/src/types/browser-nodes.d.ts +54 -57
  521. package/lib/typescript/src/types/browser-nodes.d.ts.map +1 -1
  522. package/lib/typescript/src/types/browser.d.ts +181 -144
  523. package/lib/typescript/src/types/browser.d.ts.map +1 -1
  524. package/lib/typescript/src/utils/LazyNativeEmitter.d.ts +6 -9
  525. package/lib/typescript/src/utils/LazyNativeEmitter.d.ts.map +1 -1
  526. package/lib/typescript/src/utils/NativeUpdatedValue.d.ts +13 -12
  527. package/lib/typescript/src/utils/NativeUpdatedValue.d.ts.map +1 -1
  528. package/lib/typescript/src/utils/getTrackIdentity.d.ts +6 -4
  529. package/lib/typescript/src/utils/getTrackIdentity.d.ts.map +1 -1
  530. package/lib/typescript/src/utils/useDebug.d.ts +16 -3
  531. package/lib/typescript/src/utils/useDebug.d.ts.map +1 -1
  532. package/package.json +1 -1
  533. package/src/CLAUDE.md +7 -2
  534. package/src/docs-floors.test.ts +71 -0
  535. package/src/features/battery.ts +17 -13
  536. package/src/features/browser-config.ts +1 -1
  537. package/src/features/browser.ts +65 -24
  538. package/src/features/carConnection.ts +3 -4
  539. package/src/features/equalizer.ts +9 -5
  540. package/src/features/errors.ts +37 -22
  541. package/src/features/favorites.ts +15 -13
  542. package/src/features/gate.ts +14 -8
  543. package/src/features/metadata.ts +37 -17
  544. package/src/features/network.ts +5 -1
  545. package/src/features/nowPlaying.ts +28 -14
  546. package/src/features/output.ts +8 -4
  547. package/src/features/playback/controls.ts +10 -5
  548. package/src/features/playback/playWhenReady.ts +6 -5
  549. package/src/features/playback/playing.ts +16 -3
  550. package/src/features/playback/progress.ts +11 -5
  551. package/src/features/playback/state.ts +8 -3
  552. package/src/features/playback/trackPlaybackTime.ts +9 -2
  553. package/src/features/playback/volume.ts +6 -5
  554. package/src/features/player/options.ts +54 -43
  555. package/src/features/player/setup.ts +67 -61
  556. package/src/features/queue/activeTrack.ts +0 -1
  557. package/src/features/queue/queue.ts +48 -20
  558. package/src/features/queue/repeatMode.ts +1 -1
  559. package/src/features/queue/shuffle.ts +0 -1
  560. package/src/features/remoteControls.ts +59 -35
  561. package/src/features/sleepTimer.ts +15 -7
  562. package/src/types/browser-nodes.ts +54 -57
  563. package/src/types/browser.ts +183 -146
  564. package/src/utils/LazyNativeEmitter.ts +6 -9
  565. package/src/utils/NativeUpdatedValue.ts +13 -12
  566. package/src/utils/getTrackIdentity.ts +6 -4
  567. package/src/utils/useDebug.ts +16 -3
  568. package/src/web/NativeAudioBrowser.ts +2 -4
  569. package/src/web/browser/parseSearchResponse.ts +3 -4
  570. package/src/web/browser/sections.ts +1 -1
  571. package/src/web/util/BrowserPathHelper.ts +1 -3
  572. package/website/guide/android-auto.md +25 -13
  573. package/website/guide/android-certificates.md +199 -120
  574. package/website/guide/artwork.md +93 -48
  575. package/website/guide/audio-output.md +86 -68
  576. package/website/guide/automotive.md +15 -10
  577. package/website/guide/basic-usage.md +5 -2
  578. package/website/guide/battery.md +50 -23
  579. package/website/guide/browser.md +155 -68
  580. package/website/guide/carplay.md +132 -49
  581. package/website/guide/configuration.md +85 -49
  582. package/website/guide/equalizer.md +36 -32
  583. package/website/guide/errors.md +106 -64
  584. package/website/guide/favorites.md +41 -31
  585. package/website/guide/gate.md +24 -10
  586. package/website/guide/getting-started.md +55 -2
  587. package/website/guide/hooks.md +53 -47
  588. package/website/guide/live-streams.md +80 -49
  589. package/website/guide/metadata.md +87 -53
  590. package/website/guide/migrating-from-track-player.md +94 -49
  591. package/website/guide/native-callback-fetch.md +46 -36
  592. package/website/guide/network.md +36 -20
  593. package/website/guide/now-playing.md +72 -44
  594. package/website/guide/playback.md +112 -35
  595. package/website/guide/queue.md +77 -43
  596. package/website/guide/remote-controls.md +87 -29
  597. package/website/guide/search.md +37 -22
  598. package/website/guide/sleep-timer.md +35 -14
  599. package/website/guide/track.md +59 -35
@@ -2,10 +2,6 @@ import Testing
2
2
 
3
3
  @testable import AudioBrowserTestable
4
4
 
5
- // The (resolved style, platform capability) → rendered-form mapping (ADR
6
- // 0011): degradation drops decorations before layout, and the one layout drop
7
- // is a wrapping grid on a platform without a wrapping tile container.
8
-
9
5
  @Suite("SectionPresentation")
10
6
  struct SectionPresentationTests {
11
7
  private func style(display: StyleDisplay?, gridWrap: Bool? = nil) -> SectionStyle {
@@ -24,14 +20,10 @@ struct SectionPresentationTests {
24
20
  @Test func wrappingGridNeedsTheWrappingContainer() {
25
21
  #expect(
26
22
  SectionPresentation(for: style(display: .grid), supportsWrappingGrid: true) == .wrappingGrid)
27
- // The one layout drop: a wrapping grid has nowhere to go but a list —
28
- // every item stays reachable instead of truncating at an unknowable width.
29
23
  #expect(SectionPresentation(for: style(display: .grid), supportsWrappingGrid: false) == .list)
30
24
  }
31
25
 
32
26
  @Test func singleLineGridRendersOnEveryOS() {
33
- // gridWrap: false is the legacy image row's own shape, so it never
34
- // degrades — declaring it INCREASES pre-26 fidelity.
35
27
  #expect(
36
28
  SectionPresentation(for: style(display: .grid, gridWrap: false), supportsWrappingGrid: true)
37
29
  == .singleLineRow)
@@ -50,7 +42,6 @@ struct SectionPresentationTests {
50
42
  }
51
43
 
52
44
  @Test func gridWrapIsInertOnLists() {
53
- // Declaring a decoration never changes the layout you'd get without it.
54
45
  #expect(
55
46
  SectionPresentation(for: style(display: .list, gridWrap: false), supportsWrappingGrid: true)
56
47
  == .list)
@@ -60,8 +51,6 @@ struct SectionPresentationTests {
60
51
  }
61
52
 
62
53
  @Test func tileFamilyFollowsGridTile() {
63
- // The family follows the declaration alone; the wrap mode only decides
64
- // whether its elements take more than one line.
65
54
  #expect(SectionPresentation.tileFamily(for: SectionStyle(gridTile: .card)) == .cardElements)
66
55
  #expect(
67
56
  SectionPresentation.tileFamily(for: SectionStyle(gridTile: .image)) == .imageGridElements)
@@ -75,18 +64,16 @@ struct SectionPresentationTests {
75
64
  let viewAll = Section(title: "Popular", path: "/popular", children: [])
76
65
  let preview = Section(title: "Popular", children: [])
77
66
  let untitled = Section(children: [])
78
- // The image row's own text carries a chevron, so it is kept for the
79
- // shelf that has somewhere to go.
67
+ // CarPlay draws a chevron beside the image row's text, so a shelf with a path titles it there.
80
68
  #expect(SectionPresentation.tileSectionHeader(viewAll, supportsElements: true) == nil)
81
69
  #expect(SectionPresentation.tileSectionHeader(preview, supportsElements: true) == "Popular")
82
70
  #expect(SectionPresentation.tileSectionHeader(untitled, supportsElements: true) == nil)
83
- // The legacy row cannot drop its text.
71
+ // Before the iOS 26 element API, the legacy image row's text always carries the title.
84
72
  #expect(SectionPresentation.tileSectionHeader(preview, supportsElements: false) == nil)
85
73
  }
86
74
 
87
75
  @Test func effectiveAccessorySymbol_noneAndAbsenceDrawNothing() {
88
- // A declared symbol draws; 'none' (the inheritance escape) and absence
89
- // both fall back to the derived accessory.
76
+ // nil draws the derived accessory (a browsable row's chevron), not no accessory.
90
77
  #expect(
91
78
  SectionPresentation.effectiveAccessorySymbol(TrackStyle(accessorySymbol: "lock.fill"))
92
79
  == "lock.fill")
@@ -14,9 +14,6 @@ struct SectionScopeTests {
14
14
  scoped.map { $0.section.children.map(\.src) }
15
15
  }
16
16
 
17
- // Two sections sharing an identity — the duplicate-heavy shape the flat
18
- // model had to disambiguate by precedence; sections + the stamped flat
19
- // index make it exact.
20
17
  private var sections: [Section] {
21
18
  [
22
19
  section("First", [track("dup"), track("x")]),
@@ -31,7 +28,7 @@ struct SectionScopeTests {
31
28
  }
32
29
 
33
30
  @Test func flatIndexPinsTheTappedSection() {
34
- // Flat index 3 = second section, offset 1.
31
+ // Flat index 3 is the second section's offset 1.
35
32
  let scoped = SectionScope.scoped(in: sections, containing: "dup", tappedIndex: 3)
36
33
  #expect(srcs(scoped) == ["y", "dup", "z"])
37
34
  #expect(scoped?.tappedOffset == 1)
@@ -44,8 +41,7 @@ struct SectionScopeTests {
44
41
  }
45
42
 
46
43
  @Test func staleIndexFallsBackToTheFirstIdentityMatch() {
47
- // The child at the stamped index no longer carries the tapped identity
48
- // (the list shifted) — resolution ignores the index and pins nothing.
44
+ // Flat index 1 holds "x", not "dup".
49
45
  let scoped = SectionScope.scoped(in: sections, containing: "dup", tappedIndex: 1)
50
46
  #expect(srcs(scoped) == ["dup", "x"])
51
47
  #expect(scoped?.tappedOffset == nil)
@@ -123,6 +119,7 @@ struct SectionScopeTests {
123
119
  section("First", [track("a"), Track(id: "off", src: "off", disabled: true), Track(path: "/browse"), track("b")]),
124
120
  section("Second", [track("c")]),
125
121
  ]
122
+ // The flat index counts the unplayable children too.
126
123
  let result = queue(page, "/p?__trackId=b&__index=3")
127
124
  #expect(result?.0 == ["a", "b"])
128
125
  #expect(result?.1 == 1)
@@ -122,16 +122,12 @@ private func match(_ path: String, _ patterns: [String]) -> (route: TestRoute, m
122
122
  }
123
123
 
124
124
  @Test func computesCorrectSpecificityForTailWildcardPatterns() {
125
- // Regression test for issue #27: specificity must account for
126
- // segment types before the ** wildcard.
127
125
  let result = match("/api/v1/users", ["/api/v1/**"])
128
- // constant "api" (1000) + constant "v1" (1000) + tail(1) + 3 segments = 2004
126
+ // 1000 per constant × 2 + 1 per segment before the tail × 2 + 2 for the tail wildcard
129
127
  #expect(result!.match.specificity == 2004)
130
128
  }
131
129
 
132
130
  @Test func prefersConstantPrefixOverParameterPrefixInTailWildcards() {
133
- // Second part of issue #27: with correct specificity, the constant
134
- // prefix should beat the parameter prefix.
135
131
  let result = match("/api/v1/users", ["/api/{version}/**", "/api/v1/**"])
136
132
  #expect(result!.route.path == "/api/v1/**")
137
133
  }
@@ -2,9 +2,6 @@
2
2
  import Foundation
3
3
  import Testing
4
4
 
5
- // Timing tests drive a ManualSleepTimerScheduler rather than the main queue:
6
- // every deadline below is virtual, so nothing races the real clock.
7
-
8
5
  @MainActor
9
6
  private final class Volume {
10
7
  var level: Float = 0.8
@@ -31,7 +28,7 @@ struct SleepTimerManagerTests {
31
28
  }
32
29
  manager.set(seconds: 0.3, fadeDuration: 0.15)
33
30
 
34
- clock.advance(to: 0.05) // before the fade window
31
+ clock.advance(to: 0.05) // before the fade window opens at 0.15
35
32
  #expect(!manager.isFading)
36
33
  #expect(manager.get() != nil)
37
34
 
@@ -40,9 +37,9 @@ struct SleepTimerManagerTests {
40
37
  #expect(fader.duration == 0.15)
41
38
  #expect(fader.originalVolume == 0.8)
42
39
  #expect(completes == 0)
43
- volume.level = 0.1 // mid-fade
40
+ volume.level = 0.1 // stands in for the fade lowering it
44
41
 
45
- clock.advance(to: 0.4) // past the deadline
42
+ clock.advance(to: 0.4)
46
43
  #expect(completes == 1)
47
44
  #expect(volumeAtHalt == 0.1) // halted before the restore
48
45
  #expect(volume.level == 0.8)
@@ -56,7 +53,7 @@ struct SleepTimerManagerTests {
56
53
 
57
54
  manager.set(seconds: 0.2, fadeDuration: 5)
58
55
 
59
- clock.advance(to: 0.1) // fade should have begun
56
+ clock.advance(to: 0.1)
60
57
  #expect(manager.isFading)
61
58
  #expect(fader.duration == 0.2)
62
59
  }
@@ -66,13 +63,13 @@ struct SleepTimerManagerTests {
66
63
  let (manager, clock, volume, _) = makeManager()
67
64
  manager.set(seconds: 0.2, fadeDuration: 0.15)
68
65
  clock.advance(to: 0.1)
69
- volume.level = 0.1 // mid-fade
66
+ volume.level = 0.1 // stands in for the fade lowering it
70
67
 
71
68
  #expect(manager.clear())
72
69
  #expect(volume.level == 0.8)
73
70
  #expect(!manager.isFading)
74
71
 
75
- clock.advance(to: 0.3) // well past the would-be deadline
72
+ clock.advance(to: 0.3)
76
73
  #expect(!manager.isFading)
77
74
  }
78
75
 
@@ -92,7 +89,7 @@ struct SleepTimerManagerTests {
92
89
  let (manager, clock, volume, _) = makeManager()
93
90
  manager.set(seconds: 60, fadeDuration: 10)
94
91
  clock.advance(to: 55)
95
- volume.level = 0.1 // mid-fade
92
+ volume.level = 0.1 // stands in for the fade lowering it
96
93
 
97
94
  manager.set(seconds: 30)
98
95
 
@@ -105,7 +102,7 @@ struct SleepTimerManagerTests {
105
102
  let (manager, clock, volume, _) = makeManager()
106
103
  manager.set(seconds: 60, fadeDuration: 10)
107
104
  clock.advance(to: 55)
108
- volume.level = 0.1 // mid-fade
105
+ volume.level = 0.1 // stands in for the fade lowering it
109
106
 
110
107
  manager.setToEndOfTrack()
111
108
 
@@ -2,10 +2,7 @@ import Testing
2
2
 
3
3
  @testable import AudioBrowserTestable
4
4
 
5
- // Resolution semantics (ADR 0011): container properties and `display` resolve
6
- // by scope override (`section ?? page`), inherited item properties resolve
7
- // `track ?? section ?? page` — and `display` never inherits onto an item.
8
-
5
+ // Resolution rules: docs/adr/0011-style-is-a-declaration-block.md
9
6
  @Suite("StyleResolver.sectionStyle")
10
7
  struct SectionStyleResolutionTests {
11
8
  @Test func sectionOverridesThePagePerProperty() {
@@ -13,7 +10,6 @@ struct SectionStyleResolutionTests {
13
10
  section: SectionStyle(gridWrap: nil, display: .list, artworkRendering: nil),
14
11
  page: SectionStyle(gridWrap: false, display: .grid, artworkRendering: .stencil),
15
12
  )
16
- // Declared on the section: wins. Undeclared: the page's scope-wide value.
17
13
  #expect(resolved.display == .list)
18
14
  #expect(resolved.artworkRendering == .stencil)
19
15
  #expect(resolved.gridWrap == false)
@@ -37,7 +33,6 @@ struct SectionStyleResolutionTests {
37
33
  }
38
34
 
39
35
  @Test func gridTileResolvesByScopeOverride() {
40
- // A page-wide card treatment; one section opts back to plain tiles.
41
36
  let inherited = StyleResolver.sectionStyle(
42
37
  section: nil,
43
38
  page: SectionStyle(gridTile: .card),
@@ -75,9 +70,8 @@ struct TrackStyleResolutionTests {
75
70
  }
76
71
 
77
72
  @Test func displayNeverInheritsOntoAnItem() {
78
- // The track's own `display` is the page promise for the page IT opens;
79
- // the section's describes its children's layout. Neither may surface as
80
- // the item's resolved display.
73
+ // The track's own `display` is the layout of the page it opens, not of the
74
+ // row it sits in; neither it nor the section's may resolve onto the item.
81
75
  let resolved = StyleResolver.trackStyle(
82
76
  track: TrackStyle(display: .grid, artworkRendering: nil),
83
77
  section: SectionStyle(gridWrap: nil, display: .grid, artworkRendering: nil),
@@ -86,7 +80,6 @@ struct TrackStyleResolutionTests {
86
80
  }
87
81
 
88
82
  @Test func imageShapeInheritsAndOverridesPerItem() {
89
- // Section-wide circular (an artists shelf); one album overrides.
90
83
  let inherited = StyleResolver.trackStyle(
91
84
  track: nil,
92
85
  section: SectionStyle(imageShape: .circular),
@@ -105,8 +98,7 @@ struct TrackStyleResolutionTests {
105
98
  section: SectionStyle(accessorySymbol: "lock.fill"),
106
99
  )
107
100
  #expect(inherited.accessorySymbol == "lock.fill")
108
- // 'none' is the inheritance escape — it must survive resolution intact
109
- // (the renderer, not the resolver, maps it to "no accessory").
101
+ // "none" stays a value here: the renderer, not the resolver, maps it to no accessory.
110
102
  let escaped = StyleResolver.trackStyle(
111
103
  track: TrackStyle(accessorySymbol: "none"),
112
104
  section: SectionStyle(accessorySymbol: "lock.fill"),
@@ -115,7 +107,6 @@ struct TrackStyleResolutionTests {
115
107
  }
116
108
 
117
109
  @Test func cardPropertiesInheritAndOverridePerItem() {
118
- // Section-wide tint/mode; one card overrides its image mode.
119
110
  let inherited = StyleResolver.trackStyle(
120
111
  track: nil,
121
112
  section: SectionStyle(accessorySymbol: nil, cardTint: "#1e3a8a", cardImage: .background),
@@ -1,15 +1,12 @@
1
1
  @testable import AudioBrowserTestable
2
2
  import Foundation
3
3
 
4
- /// A job handed back by `ManualSleepTimerScheduler`.
5
4
  private final class ManualJob: SleepTimerJob {
6
5
  nonisolated(unsafe) var isCancelled = false
7
6
  func cancel() { isCancelled = true }
8
7
  }
9
8
 
10
- /// Deterministic stand-in for the main-queue scheduler: jobs fire only when the
11
- /// test advances the clock, so an assertion can never lose a race against a
12
- /// real deadline on a loaded CI runner.
9
+ /// Fires jobs only when the test calls `advance(to:)`, so no assertion races a real deadline.
13
10
  @MainActor
14
11
  final class ManualSleepTimerScheduler: SleepTimerScheduling {
15
12
  private struct Entry {
@@ -30,10 +27,8 @@ final class ManualSleepTimerScheduler: SleepTimerScheduling {
30
27
  return job
31
28
  }
32
29
 
33
- /// Moves the virtual clock to `time`, firing every due job in deadline order.
34
- /// Jobs run one at a time so a job that schedules or cancels another (the
35
- /// fade landing before completion) sees the same ordering it would in
36
- /// production.
30
+ /// Moves the clock to `time` and runs each due job one at a time in deadline order, so a job
31
+ /// that schedules or cancels another sees the same ordering it would in production.
37
32
  func advance(to time: TimeInterval) {
38
33
  now = time
39
34
  while let next = entries
@@ -1,7 +1,6 @@
1
1
  @testable import AudioBrowserTestable
2
2
  import AVFoundation
3
3
 
4
- /// Creates an AVMetadataItem with the specified properties for testing.
5
4
  func makeMetadataItem(
6
5
  identifier: AVMetadataIdentifier? = nil,
7
6
  commonKey: AVMetadataKey? = nil,
@@ -31,12 +30,10 @@ func makeMetadataItem(
31
30
  final class MockPlayerEngine: PlayerEngine {
32
31
  var onEvent: (@MainActor (EngineEvent) -> Void)?
33
32
 
34
- /// Reports `event` as the media stack would.
35
33
  func emit(_ event: EngineEvent) {
36
34
  onEvent?(event)
37
35
  }
38
36
 
39
- // The current item
40
37
  var hasItem = false
41
38
  var hasLoadedAsset = false
42
39
  var currentTime: Double = 0
@@ -48,7 +45,6 @@ final class MockPlayerEngine: PlayerEngine {
48
45
  var isAirPlayRoute = false
49
46
  var volume: Float = 1
50
47
 
51
- // Loading
52
48
  var resolveAndLoadCalls: [String] = []
53
49
  var cancelLoadingCount = 0
54
50
  var dropAssetCount = 0
@@ -63,7 +59,6 @@ final class MockPlayerEngine: PlayerEngine {
63
59
  func stopObservingItem() { stopObservingItemCount += 1 }
64
60
  func recreate() { recreateCount += 1 }
65
61
 
66
- // Transport
67
62
  var startPlaybackCallCount = 0
68
63
  var pausePlaybackCallCount = 0
69
64
  var setTimePitchCallCount = 0
@@ -82,7 +77,6 @@ final class MockPlayerEngine: PlayerEngine {
82
77
  if let seekResult { completion(seekResult) } else { seeksInFlight.append(completion) }
83
78
  }
84
79
 
85
- /// Lands the seeks left in flight while `seekResult` was nil.
86
80
  func completeSeeks(_ finished: Bool) {
87
81
  let pending = seeksInFlight
88
82
  seeksInFlight = []
@@ -93,7 +87,6 @@ final class MockPlayerEngine: PlayerEngine {
93
87
 
94
88
  func applyTimePitchAlgorithm() { setTimePitchCallCount += 1 }
95
89
 
96
- // Now playing and remote commands
97
90
  var primeCount = 0
98
91
  var loadNowPlayingMetadataCalls: [Track] = []
99
92
  var clearNowPlayingCallCount = 0
@@ -110,14 +103,13 @@ final class MockPlayerEngine: PlayerEngine {
110
103
  updateSkipAvailabilityCalls.append((canNext, canPrevious))
111
104
  }
112
105
 
113
- // Now-playing lines and the audio session, in the order the Player drove them
114
106
  var nowPlayingRenderCount = 0
115
107
  var nowPlayingTrackChangedCount = 0
116
108
  var appliedTimedMetadata: [TimedMetadata] = []
117
109
  var activateAudioSessionCount = 0
118
110
  var cancelAudioSessionReleaseCount = 0
119
111
  var scheduleAudioSessionReleaseCount = 0
120
- /// Called with the name of each of these calls, so a test can interleave them with callbacks.
112
+ /// Called with the name of each seam call above, so a test can interleave them with callbacks.
121
113
  var onSeamCall: ((String) -> Void)?
122
114
 
123
115
  func renderNowPlaying() {
@@ -151,8 +143,8 @@ final class MockPlayerEngine: PlayerEngine {
151
143
  }
152
144
  }
153
145
 
154
- /// A Player over `engine` whose retries reload while `retries` and otherwise give up, keeping
155
- /// its resume snapshot out of the app's defaults.
146
+ /// A Player whose retries reload while `retries` and otherwise give up, persisting to a
147
+ /// test-only defaults suite.
156
148
  @MainActor
157
149
  func makePlayer(
158
150
  engine: MockPlayerEngine = MockPlayerEngine(),
@@ -165,6 +157,7 @@ func makePlayer(
165
157
  engine: engine, retry: retry, sleepTimerScheduler: sleepTimerScheduler,
166
158
  persistenceDefaults: UserDefaults(suiteName: "PlayerTests")!, persistenceSaveInterval: saveInterval,
167
159
  )
160
+ // Player's init installs its own `shouldRetry`; replace it afterwards.
168
161
  retry.shouldRetry = { retries }
169
162
  return player
170
163
  }
@@ -180,7 +173,6 @@ final class MockPlayerCallbacks: PlayerCallbacks {
180
173
  var playingStateChanges: [PlayingState] = []
181
174
  var queueEndedEvents: [PlaybackQueueEndedEvent] = []
182
175
  var queueChanges: [[Track]] = []
183
- /// The order in which the queue and active-track callbacks arrived.
184
176
  var queueAndTrackOrder: [String] = []
185
177
  var repeatModeChanges: [RepeatModeChangedEvent] = []
186
178
  var shuffleEnabledChanges: [Bool] = []
@@ -188,7 +180,6 @@ final class MockPlayerCallbacks: PlayerCallbacks {
188
180
  var playbackIntervalFiredCount = 0
189
181
  var timedMetadata: [TimedMetadata] = []
190
182
 
191
- /// The order playback, intent and playing-state changes arrived in.
192
183
  var publishOrder: [String] = []
193
184
 
194
185
  func playerDidChangePlayback(_ playback: Playback) {
@@ -253,8 +244,7 @@ final class MockPlayerCallbacks: PlayerCallbacks {
253
244
 
254
245
  // MARK: - RetryLoop
255
246
 
256
- /// A RetryLoop for tests: enabled, with an instant backoff unless `delay`, whose attempts reload
257
- /// while `retries` and otherwise give up, as an exhausted budget does.
247
+ /// An enabled RetryLoop that backs off for `delay` seconds and reloads while `retries`.
258
248
  @MainActor
259
249
  func makeRetryLoop(retries: Bool = true, delay: TimeInterval = 0) -> RetryLoop {
260
250
  let loop = RetryLoop(sleep: { _ in
@@ -60,8 +60,6 @@ struct TabBarEntriesTests {
60
60
  }
61
61
 
62
62
  @Test func nonRenderedFieldChangeIsSame() {
63
- // Only fields the tab bar renders are compared; other track fields may
64
- // drift without churning the tab bar.
65
63
  #expect(
66
64
  TabBarEntries.same(
67
65
  [tab("Explore", path: "/explore", artist: "a")],
@@ -28,7 +28,7 @@ struct TimedMetadataICYTests {
28
28
  return item
29
29
  }
30
30
 
31
- // "Песня" as windows-1251 bytes, decoded as Latin-1 the way AVFoundation does when it guesses wrong.
31
+ // "Песня" as windows-1251 bytes read as Latin-1, as AVFoundation decodes it when it guesses wrong.
32
32
  private let latin1Shaped = "\u{CF}\u{E5}\u{F1}\u{ED}\u{FF}"
33
33
 
34
34
  @Test func icyCharset_redecodesLatin1ShapedTitle() {
@@ -115,11 +115,10 @@ struct TimedMetadataID3Tests {
115
115
  }
116
116
 
117
117
  @Test func id3AllEmpty_returnsNil() {
118
- // Items exist but don't match any known ID3 identifiers
118
+ // An ID3 item, but not one any field is read from.
119
119
  let item = makeMetadataItem(identifier: .id3MetadataEncodedBy, value: "encoder")
120
120
 
121
121
  let result = TimedMetadata.from(items: [item])
122
- // The item has id3 keySpace, so it enters fromId3 which doesn't match .id3MetadataEncodedBy
123
122
  #expect(result == nil)
124
123
  }
125
124
  }
@@ -9,7 +9,7 @@ private final class Page {
9
9
  }
10
10
 
11
11
  /// A template stack whose mutations complete only when the test steps them,
12
- /// the way CarPlay's complete on a later run-loop turn.
12
+ /// as CarPlay's complete on a later run-loop turn.
13
13
  @MainActor
14
14
  private final class FakeStack: TemplateStack {
15
15
  private(set) var templates: [Page]
@@ -1,11 +1,8 @@
1
1
  @testable import AudioBrowserTestable
2
2
  import Testing
3
3
 
4
- /// `{id}` template substitution used by artwork URL resolution
5
- /// (RequestPipeline.substituteTrackId). A track without a non-blank id must leave
6
- /// the token LITERALLY in place — never substitute an empty string, never skip — so the
7
- /// resulting request 404s with a self-describing URL (the resolver logs a warning keyed off
8
- /// `containsToken`). Mirrors Android's `substituteTrackId` / `configContainsIdToken`.
4
+ /// Without a non-blank id the `{id}` token stays literal, never blanked or skipped, so the
5
+ /// request fails with a self-describing URL. Android's `substituteTrackId` must match.
9
6
  struct TrackIdTemplateTests {
10
7
  // MARK: substitution with an id
11
8
 
@@ -60,7 +57,6 @@ struct TrackIdTemplateTests {
60
57
  }
61
58
 
62
59
  @Test func substitutionThenDetectionNeverBothMatch() {
63
- // With an id, substitution clears the token, so no warning fires.
64
60
  let subbed = TrackIdTemplate.substitute("/artwork/{id}", id: "abc")
65
61
  #expect(!TrackIdTemplate.containsToken(subbed))
66
62
  }
@@ -50,16 +50,13 @@ struct TrackMetadataCommonIdentifierTests {
50
50
  }
51
51
 
52
52
  @Test func identifierWinsOverCommonKey() {
53
- // .quickTimeMetadataTitle doesn't match the identifier switch
54
- // but has commonKey .commonKeyTitle — so it only matches the fallback path.
53
+ // .quickTimeMetadataTitle reaches title only through its commonKey fallback.
55
54
  let items = [
56
55
  makeMetadataItem(identifier: .commonIdentifierTitle, value: "Identifier Title"),
57
56
  makeMetadataItem(identifier: .quickTimeMetadataTitle, value: "QuickTime Title"),
58
57
  ]
59
58
 
60
59
  let metadata = TrackMetadata.from(items: items)
61
- // The first item sets title via identifier match.
62
- // The second item falls through to commonKey, which uses title ?? ... (no overwrite).
63
60
  #expect(metadata.title == "Identifier Title")
64
61
  }
65
62
  }
@@ -10,7 +10,6 @@ private final class BrowserMock: TrackSelectionBrowser {
10
10
  var expandQueueResult: (tracks: [Track], selectedIndex: Int)?
11
11
  var expandQueueError: Error?
12
12
 
13
- // Record calls for verification
14
13
  var trackLoadEvents: [TrackLoadEvent] = []
15
14
  var expandedPaths: [String] = []
16
15
 
@@ -126,7 +125,7 @@ struct ContextualPathQueueReuseTests {
126
125
  let trackSrc = "song.mp3"
127
126
  let contextualPath = BrowserPathHelper.build(parentPath: parentPath, trackId: trackSrc)
128
127
 
129
- // Id-less queue tracks: identity falls back to src.
128
+ // Queue tracks carry no id, so identity falls back to src.
130
129
  player.queueSourcePath = parentPath
131
130
  player.tracks = [
132
131
  Track(src: "other.mp3"),
@@ -149,9 +148,6 @@ struct ContextualPathQueueReuseTests {
149
148
  #expect(browser.expandedPaths.isEmpty)
150
149
  }
151
150
 
152
- // Skip-in-place matches by id when queue tracks carry ids: the contextual
153
- // trackId is the row's identity (its id), and the queue row is found even
154
- // though its src differs textually from the tapped track's.
155
151
  @Test func matchingQueueSourcePath_skipsToTrackByIdWhenSrcDiffers() async {
156
152
  let (selector, browser, player) = makeSelector()
157
153
  let parentPath = "/library/radio"
@@ -199,9 +195,6 @@ struct ContextualPathQueueReuseTests {
199
195
  #expect(browser.expandedPaths.isEmpty)
200
196
  }
201
197
 
202
- // A queue holding the same identity twice (normal for music playlists):
203
- // exact contextual-path equality — which carries the stamped page index —
204
- // pins the tapped copy instead of the first one.
205
198
  @Test func duplicateIdentityInQueue_pathMatchPinsTheTappedCopy() async {
206
199
  let (selector, browser, player) = makeSelector()
207
200
  let parentPath = "/playlist"
@@ -226,10 +219,6 @@ struct ContextualPathQueueReuseTests {
226
219
  #expect(browser.expandedPaths.isEmpty)
227
220
  }
228
221
 
229
- // A tap in section B whose identity also sits in the active section-A
230
- // queue: the exact surface is not in the queue, so the selection
231
- // re-expands (re-scoping to the tapped section) instead of silently
232
- // skipping inside the old section's queue.
233
222
  @Test func indexStampedPathNotInQueue_reExpandsInsteadOfIdentitySkip() async {
234
223
  let (selector, browser, player) = makeSelector()
235
224
  let parentPath = "/city"
@@ -237,6 +226,8 @@ struct ContextualPathQueueReuseTests {
237
226
  BrowserPathHelper.build(parentPath: parentPath, trackId: id, index: index)
238
227
  }
239
228
 
229
+ // "dup" is in the queue at another stamped index: an identity match would skip to it,
230
+ // but a tap on another surface re-expands to scope the queue to that surface.
240
231
  player.queueSourcePath = parentPath
241
232
  player.tracks = [
242
233
  Track(path: stamped("dup", 0), src: "dup"),
@@ -371,13 +362,10 @@ struct DisabledTrackTests {
371
362
  Issue.record("Expected .none for a disabled track, got \(result)")
372
363
  return
373
364
  }
374
- // Refused outright: not even the JS load handler hears about it.
375
365
  #expect(browser.trackLoadEvents.isEmpty)
376
366
  }
377
367
 
378
368
  @Test func disabledBrowsable_returnsNone() async {
379
- // Unavailable means unavailable — a disabled browsable doesn't navigate
380
- // either (the ladder grays or hides it; a delivered tap stays inert).
381
369
  let (selector, _, player) = makeSelector()
382
370
  let track = Track(id: "t1", path: "/gone", disabled: true)
383
371
  let result = await selector.select(track: track, player: player)
@@ -13,13 +13,8 @@ import os.log
13
13
  var queueSourcePath: String? { get }
14
14
  }
15
15
 
16
- /// Encapsulates the shared track selection decision tree used by both
17
- /// HybridAudioBrowser and CarPlaySession.
18
- ///
19
- /// Resolves a track selection to a concrete `SelectionResult` describing
20
- /// what the caller should do. Each caller then executes the action in its
21
- /// own way (CarPlay: showNowPlaying + completion; HybridAudioBrowser:
22
- /// direct player calls).
16
+ /// Decides what selecting a track does, for both HybridAudioBrowser and CarPlaySession;
17
+ /// each caller carries out the returned `SelectionResult` its own way.
23
18
  @MainActor
24
19
  class TrackSelector {
25
20
  private let logger = Logger(subsystem: "com.audiobrowser", category: "TrackSelector")
@@ -32,35 +27,31 @@ class TrackSelector {
32
27
  // MARK: - Result Types
33
28
 
34
29
  enum SelectionResult {
35
- /// Playback action determined and not intercepted by JS handler.
36
30
  case play(PlaybackIntent)
37
- /// JS handleTrackLoad handler intercepted — caller should not play.
31
+ /// The app's `handleTrackLoad` took the selection; the caller plays nothing.
38
32
  case intercepted
39
- /// Track is browsable — caller should navigate to this path.
33
+ /// The track has no `src`; the caller navigates to `path`.
40
34
  case browse(path: String)
41
- /// Nothing to do (no src, no path).
42
35
  case none
43
36
  }
44
37
 
45
38
  enum PlaybackIntent {
46
- /// Skip to an index in the existing queue.
47
39
  case skipTo(index: Int)
48
- /// Replace queue with new tracks.
49
40
  case setQueue(tracks: [Track], startIndex: Int, sourcePath: String?)
50
- /// Load a single track.
51
41
  case loadTrack(Track)
52
42
  }
53
43
 
54
44
  // MARK: - Selection
55
45
 
56
- /// Resolves a track selection to a concrete action.
57
- /// Handles contextual path expansion, queue reuse, and handler interception.
46
+ /// Resolves a selection: nothing for a disabled track; for a contextual path, a skip within
47
+ /// the current queue when it came from the same parent, else the parent expanded into a queue
48
+ /// (the track alone if expansion fails); a single track for a `src`; browse for a bare `path`.
49
+ /// A playback is first offered to the app's `handleTrackLoad`, which can intercept it.
58
50
  func select(
59
51
  track: Track,
60
52
  player: some TrackSelectionPlayer,
61
53
  ) async -> SelectionResult {
62
- // A disabled track is unavailable — it never plays, whichever surface or
63
- // stale resume path delivered the selection (Track.disabled).
54
+ // Checked here, not only in the UI: a stale resume path can still deliver a disabled track.
64
55
  if track.disabled == true {
65
56
  return .none
66
57
  }
@@ -104,13 +95,10 @@ class TrackSelector {
104
95
  let parentPath = BrowserPathHelper.stripTrackId(path)
105
96
  let trackId = BrowserPathHelper.extractTrackId(path)
106
97
 
107
- // Check if queue already came from this parent path — just skip to the
108
- // track. Exact-surface match first: a contextual path carries the tapped
109
- // page position (`__index`), so path equality pins the exact copy when
110
- // the page holds the same identity more than once. The identity match
111
- // remains for index-less paths (e.g. pre-stamp persisted state); an
112
- // index-stamped path with no exact match falls through to expansion,
113
- // which re-scopes the queue to the tapped section.
98
+ // Exact path first: its `__index` pins the tapped copy when the page holds the same identity
99
+ // more than once. Identity matching is only for index-less paths (e.g. from persisted state
100
+ // without one); an indexed path with no exact match expands instead, re-scoping
101
+ // the queue to the tapped section.
114
102
  if parentPath == player.queueSourcePath {
115
103
  var skipIndex = player.tracks.firstIndex(where: { $0.path == path })
116
104
  if skipIndex == nil, BrowserPathHelper.extractIndex(path) == nil, let trackId {