react-native-audio-browser 0.2.0-next.53 → 0.2.0-next.55

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (599) hide show
  1. package/README.md +32 -19
  2. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  3. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  5. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  6. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  7. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  8. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  9. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  10. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  11. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  12. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  13. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  15. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  16. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  17. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  18. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  19. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  20. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  21. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  22. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  23. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  24. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  25. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  26. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  27. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  28. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  29. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  30. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  31. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  32. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  33. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  34. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  35. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  36. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  37. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  38. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  39. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  40. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  41. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  42. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  43. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  45. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  46. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  50. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  51. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  52. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  53. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  54. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  55. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  56. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  58. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  59. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  60. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  61. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  63. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  64. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  66. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +28 -48
  67. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  68. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  71. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  78. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  80. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  81. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  82. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  84. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  85. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  86. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  90. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  91. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  92. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  93. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  94. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  96. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  97. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  98. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  99. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  100. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  102. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  103. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  104. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  105. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  106. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  107. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  108. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  109. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  110. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  111. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  112. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  113. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  114. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  115. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  116. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  121. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  122. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  123. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  124. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  125. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  126. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  127. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  128. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  129. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  130. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  131. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  132. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  133. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  134. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  135. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  136. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  137. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  138. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  139. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  143. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  144. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +2 -2
  145. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  146. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +5 -1
  149. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  150. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  151. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  152. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  153. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  154. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  155. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  156. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +9 -10
  157. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +0 -1
  158. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  159. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  167. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  168. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  169. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  170. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  172. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  174. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  175. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  177. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  178. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  179. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  180. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  181. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  183. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  184. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  185. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  186. package/ios/AVPlayerEngine.swift +13 -21
  187. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  188. package/ios/Browser/BrowseGate.swift +7 -8
  189. package/ios/Browser/BrowserConfig.swift +19 -34
  190. package/ios/Browser/BrowserError.swift +0 -1
  191. package/ios/Browser/BrowserManager.swift +29 -75
  192. package/ios/Browser/BrowserPathHelper.swift +13 -93
  193. package/ios/Browser/FavoriteSet.swift +7 -10
  194. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  195. package/ios/Browser/JsonModels.swift +11 -51
  196. package/ios/Browser/NavigationErrorState.swift +3 -2
  197. package/ios/Browser/PageResolver.swift +13 -23
  198. package/ios/Browser/RequestLayer.swift +16 -20
  199. package/ios/Browser/RequestPipeline.swift +33 -43
  200. package/ios/Browser/SearchDrillIn.swift +7 -13
  201. package/ios/Browser/SectionScope.swift +14 -26
  202. package/ios/Browser/SimpleRouter.swift +8 -15
  203. package/ios/Browser/StyleResolver.swift +12 -29
  204. package/ios/Browser/TabBarEntries.swift +6 -11
  205. package/ios/Browser/TrackIdTemplate.swift +6 -14
  206. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  207. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  208. package/ios/CarPlay/CarPlayController.swift +4 -4
  209. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  210. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  211. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  212. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  213. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  214. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  215. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  216. package/ios/CarPlay/CarPlaySession.swift +13 -17
  217. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  218. package/ios/CarPlay/IntentHandlers.swift +3 -5
  219. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  220. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  221. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  222. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  223. package/ios/CarPlay/SectionPresentation.swift +18 -28
  224. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  225. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  226. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  227. package/ios/Extension/CxxVectorConformances.swift +4 -16
  228. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  229. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  230. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  231. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  232. package/ios/Extension/SearchParams+Query.swift +4 -4
  233. package/ios/Extension/Section+Copying.swift +3 -6
  234. package/ios/Extension/String+IcyCharset.swift +5 -5
  235. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  236. package/ios/Extension/Track+AVPlayer.swift +1 -2
  237. package/ios/Extension/Track+Copying.swift +2 -8
  238. package/ios/Extension/Track+Identity.swift +4 -9
  239. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  240. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  241. package/ios/Extension/Variant+Artwork.swift +8 -22
  242. package/ios/Http/HttpClient.swift +3 -3
  243. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  244. package/ios/HybridAudioBrowser+Options.swift +6 -9
  245. package/ios/HybridAudioBrowser+Player.swift +8 -16
  246. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  247. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  248. package/ios/HybridAudioBrowser.swift +54 -79
  249. package/ios/Model/NitroTypeStubs.swift +15 -22
  250. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  251. package/ios/Model/RemoteCommand.swift +2 -2
  252. package/ios/Model/TrackPlayerError.swift +9 -22
  253. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  254. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  255. package/ios/Observer/ItemObserver.swift +7 -5
  256. package/ios/Observer/PlayerObserver.swift +5 -5
  257. package/ios/PlaybackEvent.swift +2 -2
  258. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  259. package/ios/Player/AudioSessionController.swift +14 -15
  260. package/ios/Player/DeferredSeek.swift +2 -2
  261. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  262. package/ios/Player/ErrorStatus.swift +8 -7
  263. package/ios/Player/MediaLoader.swift +20 -24
  264. package/ios/Player/NowPlayingLines.swift +1 -4
  265. package/ios/Player/NowPlayingUpdater.swift +35 -61
  266. package/ios/Player/PersistedPlaybackState.swift +1 -2
  267. package/ios/Player/PlaybackFailure.swift +20 -24
  268. package/ios/Player/PlaybackPersistence.swift +5 -6
  269. package/ios/Player/PlaybackStateMachine.swift +8 -11
  270. package/ios/Player/PlaybackTimer.swift +8 -11
  271. package/ios/Player/Player.swift +6 -13
  272. package/ios/Player/PlayerEngine.swift +20 -20
  273. package/ios/Player/PlayerStatusTypes.swift +1 -2
  274. package/ios/Player/QueueManager.swift +23 -67
  275. package/ios/Player/RetryLoop.swift +39 -50
  276. package/ios/Player/ShuffleOrder.swift +17 -57
  277. package/ios/Player/SleepTimerManager.swift +13 -28
  278. package/ios/Player/VolumeFader.swift +16 -16
  279. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  280. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  281. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  282. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  283. package/ios/Tests/DeferredSeekTests.swift +1 -3
  284. package/ios/Tests/EmitterTests.swift +0 -1
  285. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  286. package/ios/Tests/FavoriteSetTests.swift +1 -0
  287. package/ios/Tests/GenerationMemoTests.swift +2 -2
  288. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  289. package/ios/Tests/JsonModelsTests.swift +5 -12
  290. package/ios/Tests/LRUCacheTests.swift +1 -5
  291. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  292. package/ios/Tests/MediaLoaderTests.swift +3 -12
  293. package/ios/Tests/ObserverTests.swift +3 -3
  294. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  295. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  296. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  297. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  298. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  299. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  300. package/ios/Tests/PlayerTests.swift +53 -88
  301. package/ios/Tests/PlayingStateTests.swift +0 -1
  302. package/ios/Tests/QueueManagerTests.swift +30 -80
  303. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  304. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  305. package/ios/Tests/RetryLoopTests.swift +12 -35
  306. package/ios/Tests/SearchDrillInTests.swift +4 -5
  307. package/ios/Tests/SectionPresentationTests.swift +3 -16
  308. package/ios/Tests/SectionScopeTests.swift +3 -6
  309. package/ios/Tests/SimpleRouterTests.swift +1 -5
  310. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  311. package/ios/Tests/StyleResolverTests.swift +4 -13
  312. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  313. package/ios/Tests/Support/TestTypes.swift +5 -15
  314. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  315. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  316. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  317. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  318. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  319. package/ios/Tests/TrackSelectorTests.swift +3 -15
  320. package/ios/TrackSelector.swift +13 -25
  321. package/ios/Util/ArtworkFreshness.swift +6 -6
  322. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  323. package/ios/Util/ConcurrentMap.swift +2 -2
  324. package/ios/Util/Emitter.swift +8 -13
  325. package/ios/Util/NetworkMonitor.swift +4 -6
  326. package/ios/Util/OutputPicker.swift +1 -1
  327. package/ios/Util/ReadyValue.swift +3 -2
  328. package/ios/Util/SFSymbolRenderer.swift +17 -30
  329. package/ios/Util/SVGProcessor.swift +5 -9
  330. package/lib/commonjs/CLAUDE.md +7 -2
  331. package/lib/commonjs/features/battery.js +16 -12
  332. package/lib/commonjs/features/battery.js.map +1 -1
  333. package/lib/commonjs/features/browser-config.js +1 -1
  334. package/lib/commonjs/features/browser.js +74 -24
  335. package/lib/commonjs/features/browser.js.map +1 -1
  336. package/lib/commonjs/features/carConnection.js +3 -4
  337. package/lib/commonjs/features/carConnection.js.map +1 -1
  338. package/lib/commonjs/features/equalizer.js +9 -5
  339. package/lib/commonjs/features/equalizer.js.map +1 -1
  340. package/lib/commonjs/features/errors.js +35 -21
  341. package/lib/commonjs/features/errors.js.map +1 -1
  342. package/lib/commonjs/features/favorites.js +15 -13
  343. package/lib/commonjs/features/favorites.js.map +1 -1
  344. package/lib/commonjs/features/gate.js +12 -6
  345. package/lib/commonjs/features/gate.js.map +1 -1
  346. package/lib/commonjs/features/metadata.js +16 -14
  347. package/lib/commonjs/features/metadata.js.map +1 -1
  348. package/lib/commonjs/features/network.js +5 -1
  349. package/lib/commonjs/features/network.js.map +1 -1
  350. package/lib/commonjs/features/nowPlaying.js +28 -14
  351. package/lib/commonjs/features/nowPlaying.js.map +1 -1
  352. package/lib/commonjs/features/output.js +8 -4
  353. package/lib/commonjs/features/output.js.map +1 -1
  354. package/lib/commonjs/features/playback/controls.js +10 -5
  355. package/lib/commonjs/features/playback/controls.js.map +1 -1
  356. package/lib/commonjs/features/playback/playWhenReady.js +6 -5
  357. package/lib/commonjs/features/playback/playWhenReady.js.map +1 -1
  358. package/lib/commonjs/features/playback/playing.js +5 -3
  359. package/lib/commonjs/features/playback/playing.js.map +1 -1
  360. package/lib/commonjs/features/playback/progress.js +11 -5
  361. package/lib/commonjs/features/playback/progress.js.map +1 -1
  362. package/lib/commonjs/features/playback/state.js +3 -3
  363. package/lib/commonjs/features/playback/state.js.map +1 -1
  364. package/lib/commonjs/features/playback/trackPlaybackTime.js +6 -1
  365. package/lib/commonjs/features/playback/trackPlaybackTime.js.map +1 -1
  366. package/lib/commonjs/features/playback/volume.js +6 -5
  367. package/lib/commonjs/features/playback/volume.js.map +1 -1
  368. package/lib/commonjs/features/player/options.js +20 -10
  369. package/lib/commonjs/features/player/options.js.map +1 -1
  370. package/lib/commonjs/features/player/setup.js +34 -38
  371. package/lib/commonjs/features/player/setup.js.map +1 -1
  372. package/lib/commonjs/features/queue/activeTrack.js +0 -1
  373. package/lib/commonjs/features/queue/activeTrack.js.map +1 -1
  374. package/lib/commonjs/features/queue/queue.js +48 -20
  375. package/lib/commonjs/features/queue/queue.js.map +1 -1
  376. package/lib/commonjs/features/queue/repeatMode.js +2 -1
  377. package/lib/commonjs/features/queue/repeatMode.js.map +1 -1
  378. package/lib/commonjs/features/queue/shuffle.js +0 -1
  379. package/lib/commonjs/features/queue/shuffle.js.map +1 -1
  380. package/lib/commonjs/features/remoteControls.js +59 -35
  381. package/lib/commonjs/features/remoteControls.js.map +1 -1
  382. package/lib/commonjs/features/sleepTimer.js +15 -6
  383. package/lib/commonjs/features/sleepTimer.js.map +1 -1
  384. package/lib/commonjs/utils/LazyNativeEmitter.js +6 -9
  385. package/lib/commonjs/utils/LazyNativeEmitter.js.map +1 -1
  386. package/lib/commonjs/utils/NativeUpdatedValue.js +13 -12
  387. package/lib/commonjs/utils/NativeUpdatedValue.js.map +1 -1
  388. package/lib/commonjs/utils/getTrackIdentity.js +6 -4
  389. package/lib/commonjs/utils/getTrackIdentity.js.map +1 -1
  390. package/lib/commonjs/utils/useDebug.js +16 -3
  391. package/lib/commonjs/utils/useDebug.js.map +1 -1
  392. package/lib/commonjs/web/NativeAudioBrowser.js +2 -4
  393. package/lib/commonjs/web/NativeAudioBrowser.js.map +1 -1
  394. package/lib/commonjs/web/browser/parseSearchResponse.js +3 -4
  395. package/lib/commonjs/web/browser/parseSearchResponse.js.map +1 -1
  396. package/lib/commonjs/web/browser/sections.js +1 -1
  397. package/lib/commonjs/web/util/BrowserPathHelper.js +1 -3
  398. package/lib/commonjs/web/util/BrowserPathHelper.js.map +1 -1
  399. package/lib/module/CLAUDE.md +7 -2
  400. package/lib/module/features/battery.js +16 -12
  401. package/lib/module/features/battery.js.map +1 -1
  402. package/lib/module/features/browser-config.js +1 -1
  403. package/lib/module/features/browser.js +74 -24
  404. package/lib/module/features/browser.js.map +1 -1
  405. package/lib/module/features/carConnection.js +3 -4
  406. package/lib/module/features/carConnection.js.map +1 -1
  407. package/lib/module/features/equalizer.js +9 -5
  408. package/lib/module/features/equalizer.js.map +1 -1
  409. package/lib/module/features/errors.js +35 -21
  410. package/lib/module/features/errors.js.map +1 -1
  411. package/lib/module/features/favorites.js +15 -13
  412. package/lib/module/features/favorites.js.map +1 -1
  413. package/lib/module/features/gate.js +12 -6
  414. package/lib/module/features/gate.js.map +1 -1
  415. package/lib/module/features/metadata.js +16 -14
  416. package/lib/module/features/metadata.js.map +1 -1
  417. package/lib/module/features/network.js +5 -1
  418. package/lib/module/features/network.js.map +1 -1
  419. package/lib/module/features/nowPlaying.js +28 -14
  420. package/lib/module/features/nowPlaying.js.map +1 -1
  421. package/lib/module/features/output.js +8 -4
  422. package/lib/module/features/output.js.map +1 -1
  423. package/lib/module/features/playback/controls.js +10 -5
  424. package/lib/module/features/playback/controls.js.map +1 -1
  425. package/lib/module/features/playback/playWhenReady.js +6 -5
  426. package/lib/module/features/playback/playWhenReady.js.map +1 -1
  427. package/lib/module/features/playback/playing.js +5 -3
  428. package/lib/module/features/playback/playing.js.map +1 -1
  429. package/lib/module/features/playback/progress.js +11 -5
  430. package/lib/module/features/playback/progress.js.map +1 -1
  431. package/lib/module/features/playback/state.js +3 -3
  432. package/lib/module/features/playback/state.js.map +1 -1
  433. package/lib/module/features/playback/trackPlaybackTime.js +6 -1
  434. package/lib/module/features/playback/trackPlaybackTime.js.map +1 -1
  435. package/lib/module/features/playback/volume.js +6 -5
  436. package/lib/module/features/playback/volume.js.map +1 -1
  437. package/lib/module/features/player/options.js +20 -10
  438. package/lib/module/features/player/options.js.map +1 -1
  439. package/lib/module/features/player/setup.js +34 -38
  440. package/lib/module/features/player/setup.js.map +1 -1
  441. package/lib/module/features/queue/activeTrack.js +0 -1
  442. package/lib/module/features/queue/activeTrack.js.map +1 -1
  443. package/lib/module/features/queue/queue.js +48 -20
  444. package/lib/module/features/queue/queue.js.map +1 -1
  445. package/lib/module/features/queue/repeatMode.js +2 -1
  446. package/lib/module/features/queue/repeatMode.js.map +1 -1
  447. package/lib/module/features/queue/shuffle.js +0 -1
  448. package/lib/module/features/queue/shuffle.js.map +1 -1
  449. package/lib/module/features/remoteControls.js +59 -35
  450. package/lib/module/features/remoteControls.js.map +1 -1
  451. package/lib/module/features/sleepTimer.js +15 -6
  452. package/lib/module/features/sleepTimer.js.map +1 -1
  453. package/lib/module/utils/LazyNativeEmitter.js +6 -9
  454. package/lib/module/utils/LazyNativeEmitter.js.map +1 -1
  455. package/lib/module/utils/NativeUpdatedValue.js +13 -12
  456. package/lib/module/utils/NativeUpdatedValue.js.map +1 -1
  457. package/lib/module/utils/getTrackIdentity.js +6 -4
  458. package/lib/module/utils/getTrackIdentity.js.map +1 -1
  459. package/lib/module/utils/useDebug.js +16 -3
  460. package/lib/module/utils/useDebug.js.map +1 -1
  461. package/lib/module/web/NativeAudioBrowser.js +2 -4
  462. package/lib/module/web/NativeAudioBrowser.js.map +1 -1
  463. package/lib/module/web/browser/parseSearchResponse.js +3 -4
  464. package/lib/module/web/browser/parseSearchResponse.js.map +1 -1
  465. package/lib/module/web/browser/sections.js +1 -1
  466. package/lib/module/web/util/BrowserPathHelper.js +1 -3
  467. package/lib/module/web/util/BrowserPathHelper.js.map +1 -1
  468. package/lib/typescript/src/features/battery.d.ts +17 -12
  469. package/lib/typescript/src/features/battery.d.ts.map +1 -1
  470. package/lib/typescript/src/features/browser.d.ts +64 -24
  471. package/lib/typescript/src/features/browser.d.ts.map +1 -1
  472. package/lib/typescript/src/features/carConnection.d.ts +3 -4
  473. package/lib/typescript/src/features/carConnection.d.ts.map +1 -1
  474. package/lib/typescript/src/features/equalizer.d.ts +9 -5
  475. package/lib/typescript/src/features/equalizer.d.ts.map +1 -1
  476. package/lib/typescript/src/features/errors.d.ts +37 -22
  477. package/lib/typescript/src/features/errors.d.ts.map +1 -1
  478. package/lib/typescript/src/features/favorites.d.ts +15 -13
  479. package/lib/typescript/src/features/favorites.d.ts.map +1 -1
  480. package/lib/typescript/src/features/gate.d.ts +14 -8
  481. package/lib/typescript/src/features/gate.d.ts.map +1 -1
  482. package/lib/typescript/src/features/metadata.d.ts +37 -17
  483. package/lib/typescript/src/features/metadata.d.ts.map +1 -1
  484. package/lib/typescript/src/features/network.d.ts +5 -1
  485. package/lib/typescript/src/features/network.d.ts.map +1 -1
  486. package/lib/typescript/src/features/nowPlaying.d.ts +28 -14
  487. package/lib/typescript/src/features/nowPlaying.d.ts.map +1 -1
  488. package/lib/typescript/src/features/output.d.ts +8 -4
  489. package/lib/typescript/src/features/output.d.ts.map +1 -1
  490. package/lib/typescript/src/features/playback/controls.d.ts +10 -5
  491. package/lib/typescript/src/features/playback/controls.d.ts.map +1 -1
  492. package/lib/typescript/src/features/playback/playWhenReady.d.ts +6 -5
  493. package/lib/typescript/src/features/playback/playWhenReady.d.ts.map +1 -1
  494. package/lib/typescript/src/features/playback/playing.d.ts +16 -3
  495. package/lib/typescript/src/features/playback/playing.d.ts.map +1 -1
  496. package/lib/typescript/src/features/playback/progress.d.ts +11 -5
  497. package/lib/typescript/src/features/playback/progress.d.ts.map +1 -1
  498. package/lib/typescript/src/features/playback/state.d.ts +8 -3
  499. package/lib/typescript/src/features/playback/state.d.ts.map +1 -1
  500. package/lib/typescript/src/features/playback/trackPlaybackTime.d.ts +9 -2
  501. package/lib/typescript/src/features/playback/trackPlaybackTime.d.ts.map +1 -1
  502. package/lib/typescript/src/features/playback/volume.d.ts +6 -5
  503. package/lib/typescript/src/features/playback/volume.d.ts.map +1 -1
  504. package/lib/typescript/src/features/player/options.d.ts +52 -37
  505. package/lib/typescript/src/features/player/options.d.ts.map +1 -1
  506. package/lib/typescript/src/features/player/setup.d.ts +65 -60
  507. package/lib/typescript/src/features/player/setup.d.ts.map +1 -1
  508. package/lib/typescript/src/features/queue/activeTrack.d.ts +0 -1
  509. package/lib/typescript/src/features/queue/activeTrack.d.ts.map +1 -1
  510. package/lib/typescript/src/features/queue/queue.d.ts +48 -20
  511. package/lib/typescript/src/features/queue/queue.d.ts.map +1 -1
  512. package/lib/typescript/src/features/queue/repeatMode.d.ts +1 -1
  513. package/lib/typescript/src/features/queue/repeatMode.d.ts.map +1 -1
  514. package/lib/typescript/src/features/queue/shuffle.d.ts +0 -1
  515. package/lib/typescript/src/features/queue/shuffle.d.ts.map +1 -1
  516. package/lib/typescript/src/features/remoteControls.d.ts +58 -25
  517. package/lib/typescript/src/features/remoteControls.d.ts.map +1 -1
  518. package/lib/typescript/src/features/sleepTimer.d.ts +15 -7
  519. package/lib/typescript/src/features/sleepTimer.d.ts.map +1 -1
  520. package/lib/typescript/src/types/browser-nodes.d.ts +54 -57
  521. package/lib/typescript/src/types/browser-nodes.d.ts.map +1 -1
  522. package/lib/typescript/src/types/browser.d.ts +181 -144
  523. package/lib/typescript/src/types/browser.d.ts.map +1 -1
  524. package/lib/typescript/src/utils/LazyNativeEmitter.d.ts +6 -9
  525. package/lib/typescript/src/utils/LazyNativeEmitter.d.ts.map +1 -1
  526. package/lib/typescript/src/utils/NativeUpdatedValue.d.ts +13 -12
  527. package/lib/typescript/src/utils/NativeUpdatedValue.d.ts.map +1 -1
  528. package/lib/typescript/src/utils/getTrackIdentity.d.ts +6 -4
  529. package/lib/typescript/src/utils/getTrackIdentity.d.ts.map +1 -1
  530. package/lib/typescript/src/utils/useDebug.d.ts +16 -3
  531. package/lib/typescript/src/utils/useDebug.d.ts.map +1 -1
  532. package/package.json +1 -1
  533. package/src/CLAUDE.md +7 -2
  534. package/src/docs-floors.test.ts +71 -0
  535. package/src/features/battery.ts +17 -13
  536. package/src/features/browser-config.ts +1 -1
  537. package/src/features/browser.ts +65 -24
  538. package/src/features/carConnection.ts +3 -4
  539. package/src/features/equalizer.ts +9 -5
  540. package/src/features/errors.ts +37 -22
  541. package/src/features/favorites.ts +15 -13
  542. package/src/features/gate.ts +14 -8
  543. package/src/features/metadata.ts +37 -17
  544. package/src/features/network.ts +5 -1
  545. package/src/features/nowPlaying.ts +28 -14
  546. package/src/features/output.ts +8 -4
  547. package/src/features/playback/controls.ts +10 -5
  548. package/src/features/playback/playWhenReady.ts +6 -5
  549. package/src/features/playback/playing.ts +16 -3
  550. package/src/features/playback/progress.ts +11 -5
  551. package/src/features/playback/state.ts +8 -3
  552. package/src/features/playback/trackPlaybackTime.ts +9 -2
  553. package/src/features/playback/volume.ts +6 -5
  554. package/src/features/player/options.ts +54 -43
  555. package/src/features/player/setup.ts +67 -61
  556. package/src/features/queue/activeTrack.ts +0 -1
  557. package/src/features/queue/queue.ts +48 -20
  558. package/src/features/queue/repeatMode.ts +1 -1
  559. package/src/features/queue/shuffle.ts +0 -1
  560. package/src/features/remoteControls.ts +59 -35
  561. package/src/features/sleepTimer.ts +15 -7
  562. package/src/types/browser-nodes.ts +54 -57
  563. package/src/types/browser.ts +183 -146
  564. package/src/utils/LazyNativeEmitter.ts +6 -9
  565. package/src/utils/NativeUpdatedValue.ts +13 -12
  566. package/src/utils/getTrackIdentity.ts +6 -4
  567. package/src/utils/useDebug.ts +16 -3
  568. package/src/web/NativeAudioBrowser.ts +2 -4
  569. package/src/web/browser/parseSearchResponse.ts +3 -4
  570. package/src/web/browser/sections.ts +1 -1
  571. package/src/web/util/BrowserPathHelper.ts +1 -3
  572. package/website/guide/android-auto.md +25 -13
  573. package/website/guide/android-certificates.md +199 -120
  574. package/website/guide/artwork.md +93 -48
  575. package/website/guide/audio-output.md +86 -68
  576. package/website/guide/automotive.md +15 -10
  577. package/website/guide/basic-usage.md +5 -2
  578. package/website/guide/battery.md +50 -23
  579. package/website/guide/browser.md +155 -68
  580. package/website/guide/carplay.md +132 -49
  581. package/website/guide/configuration.md +85 -49
  582. package/website/guide/equalizer.md +36 -32
  583. package/website/guide/errors.md +106 -64
  584. package/website/guide/favorites.md +41 -31
  585. package/website/guide/gate.md +24 -10
  586. package/website/guide/getting-started.md +55 -2
  587. package/website/guide/hooks.md +53 -47
  588. package/website/guide/live-streams.md +80 -49
  589. package/website/guide/metadata.md +87 -53
  590. package/website/guide/migrating-from-track-player.md +94 -49
  591. package/website/guide/native-callback-fetch.md +46 -36
  592. package/website/guide/network.md +36 -20
  593. package/website/guide/now-playing.md +72 -44
  594. package/website/guide/playback.md +112 -35
  595. package/website/guide/queue.md +77 -43
  596. package/website/guide/remote-controls.md +87 -29
  597. package/website/guide/search.md +37 -22
  598. package/website/guide/sleep-timer.md +35 -14
  599. package/website/guide/track.md +59 -35
@@ -4,64 +4,52 @@ import java.security.cert.X509Certificate
4
4
  import javax.security.auth.x500.X500Principal
5
5
 
6
6
  /**
7
- * Fills in missing intermediate CA certificates by following the Authority Information Access (AIA)
8
- * "CA Issuers" pointer in a certificate, the way Apple's Secure Transport does automatically but
9
- * Android's default trust manager does not.
10
- *
11
- * Many servers (a common misconfiguration) present only their leaf certificate and omit the
12
- * intermediate(s) needed to chain up to a trusted root. Browsers and iOS fetch the missing
13
- * intermediate from the URL in the leaf's AIA extension; Android's `X509TrustManager` validates
14
- * only what the server sent, so such streams fail with "Trust anchor for certification path not
15
- * found".
7
+ * Fills in intermediate certificates a server failed to send, by following each certificate's
8
+ * Authority Information Access (AIA) "CA Issuers" URL, as browsers and iOS do and Android's default
9
+ * trust manager does not.
16
10
  */
17
11
  object AiaCertChaser {
18
- /** How many distinct CA-Issuers URLs from one certificate are worth trying. */
12
+ /**
13
+ * A certificate's AIA extension is written by the server that failed validation and may list
14
+ * hundreds of URLs, each a blocking connect on the handshake thread. Real CAs publish one.
15
+ */
19
16
  const val MAX_URLS_PER_CERT = 3
20
17
 
21
18
  /**
22
- * Wall-clock ceiling on one chain-completion attempt, across all of its fetches. The deadline it
23
- * implies is handed to every fetch, whose connects, handshakes, reads and redirects are all
24
- * clipped to the time remaining — so the whole walk ends at the deadline. The one thing it cannot
25
- * cut short is a DNS lookup already in flight (Java exposes no timeout for resolution), so the
26
- * true bound is this budget plus at most one lookup's duration.
19
+ * Ceiling on one whole chain completion, across all its fetches. A DNS lookup already in flight
20
+ * cannot be cut short (Java has no resolver timeout), so the real bound is this plus one lookup.
27
21
  */
28
22
  const val MAX_CHASE_MILLIS = 20_000L
29
23
 
30
- /** Authority Information Access extension. */
31
24
  private const val AIA_OID = "1.3.6.1.5.5.7.1.1"
32
25
 
33
- /** DER-encoded OID value of id-ad-caIssuers (1.3.6.1.5.5.7.48.2). */
26
+ /** DER encoding of id-ad-caIssuers, 1.3.6.1.5.5.7.48.2. */
34
27
  private val CA_ISSUERS_OID = byteArrayOf(0x2B, 0x06, 0x01, 0x05, 0x05, 0x07, 0x30, 0x02)
35
28
 
36
29
  private const val TAG_SEQUENCE = 0x30
37
30
  private const val TAG_OID = 0x06
38
31
  private const val TAG_OCTET_STRING = 0x04
39
32
 
40
- /**
41
- * GeneralName.uniformResourceIdentifier = [6] IMPLICIT IA5String (context-specific, primitive).
42
- */
33
+ /** GeneralName's uniformResourceIdentifier: context-specific primitive [6]. */
43
34
  private const val TAG_URI = 0x86
44
35
 
45
36
  /**
46
- * Returns the "CA Issuers" URLs from the certificate's AIA extension (the locations from which
47
- * the issuing CA certificate can be fetched), or an empty list if the extension is absent or
48
- * unparseable.
37
+ * The certificate's AIA "CA Issuers" URLs; empty when the extension is absent or malformed. Never
38
+ * throws.
49
39
  */
50
40
  fun extractCaIssuerUrls(cert: X509Certificate): List<String> {
51
41
  val raw = cert.getExtensionValue(AIA_OID) ?: return emptyList()
52
42
  return try {
53
- // getExtensionValue() returns the extension value wrapped in an OCTET STRING.
43
+ // getExtensionValue() returns the value still wrapped in an OCTET STRING.
54
44
  val wrapper = DerReader(raw).read()
55
45
  if (wrapper.tag != TAG_OCTET_STRING) return emptyList()
56
46
 
57
- // AuthorityInfoAccessSyntax ::= SEQUENCE OF AccessDescription
58
47
  val aiaSeq = DerReader(wrapper.content()).read()
59
48
  if (aiaSeq.tag != TAG_SEQUENCE) return emptyList()
60
49
 
61
50
  val urls = mutableListOf<String>()
62
51
  val descriptions = DerReader(aiaSeq.content())
63
52
  while (descriptions.hasNext()) {
64
- // AccessDescription ::= SEQUENCE { accessMethod OID, accessLocation GeneralName }
65
53
  val desc = descriptions.read()
66
54
  if (desc.tag != TAG_SEQUENCE) continue
67
55
  val fields = DerReader(desc.content())
@@ -75,42 +63,23 @@ object AiaCertChaser {
75
63
  }
76
64
  urls
77
65
  } catch (e: Exception) {
78
- // Malformed DER: treat as "no AIA" rather than crashing the handshake.
79
66
  emptyList()
80
67
  }
81
68
  }
82
69
 
83
70
  /**
84
- * Walks up from the presented chain, fetching each missing issuer via its predecessor's AIA "CA
85
- * Issuers" pointer, until it reaches a certificate issued by one of [anchorSubjects], a
86
- * self-signed certificate, an issuer that cannot be fetched, or [maxIntermediates] additions.
87
- * Returns the (possibly extended) chain.
88
- *
89
- * Only ever *adds* certificates — the caller is still responsible for validating the completed
90
- * chain against the system trust anchors, so this can never cause an untrusted chain to be
91
- * accepted. From each URL's candidates the genuine issuer of the preceding certificate is
92
- * selected (defends against an AIA pointer to an unrelated certificate, and picks the right one
93
- * out of a multi-certificate PKCS#7 bundle).
71
+ * Appends to [presented] each missing issuer, fetched through its predecessor's CA-Issuers URLs,
72
+ * until the top is self-signed or issued by one of [anchorSubjects], an issuer cannot be found or
73
+ * repeats, or [maxIntermediates] have been added. Returns the chain, unchanged if nothing was
74
+ * found. Only adds certificates and validates nothing: the caller must still check the result.
94
75
  *
95
- * @param anchorSubjects the subjects of the caller's trust anchors. A chain whose top is already
96
- * issued by one of them is not missing anything, so nothing is fetched — chasing could not help
97
- * and the fetch would be a blocking round trip to a host named by a certificate that just
98
- * failed validation. This is what keeps an expired-but-complete chain, a hostname mismatch or
99
- * any other non-path failure from triggering a chase, and it stops the genuine
100
- * missing-intermediate case one hop early, where the chain reaches a root the caller already
101
- * trusts. Empty means "unknown", and the walk runs to one of the other stopping conditions.
102
- * @param maxUrlsPerCert how many of a certificate's distinct CA-Issuers URLs are tried before
103
- * giving up on it. The extension is authored by the same server that failed validation and
104
- * nothing limits how many URLs it may list — a leaf can carry hundreds — while each one costs a
105
- * blocking connect on the handshake thread. Real CAs publish one. Duplicates are collapsed
106
- * before the cap, so the cap buys distinct hosts, not repeat visits to one dead one.
107
- * @param budgetMs wall-clock ceiling on the whole walk. It is checked before each fetch, and the
108
- * deadline it implies is passed to [fetch], which is expected to clip its own connects,
109
- * handshakes, reads and redirects to the time remaining — so the budget bounds the fetches
110
- * themselves, not just how many of them start.
111
- * @param fetch resolves a CA-Issuers URL to its candidate certificates (e.g. every certificate in
112
- * a PKCS#7 bundle), giving up no later than `deadlineNanos` (absolute, [nowNanos] origin);
113
- * empty if nothing could be retrieved.
76
+ * @param anchorSubjects subjects of the caller's trust anchors. A chain already reaching one is
77
+ * left alone, so a failure that is not a missing intermediate fetches nothing. Empty means
78
+ * unknown.
79
+ * @param maxUrlsPerCert distinct URLs tried per certificate; duplicates do not count.
80
+ * @param budgetMs ceiling on the whole walk, checked before each fetch.
81
+ * @param fetch the candidate certificates at a URL, empty if none; must give up by
82
+ * `deadlineNanos` (absolute, on [nowNanos]'s clock). A throw counts as empty.
114
83
  */
115
84
  fun completeChain(
116
85
  presented: List<X509Certificate>,
@@ -128,18 +97,19 @@ object AiaCertChaser {
128
97
  var added = 0
129
98
  while (added < maxIntermediates) {
130
99
  val last = chain.last()
131
- if (last.subjectX500Principal == last.issuerX500Principal) break // self-signed root
132
- if (last.issuerX500Principal in anchorSubjects) break // already reaches a trust anchor
100
+ if (last.subjectX500Principal == last.issuerX500Principal) break
101
+ if (last.issuerX500Principal in anchorSubjects) break
102
+ // Lazy, so no URL is fetched after one yields the issuer.
133
103
  val issuer =
134
104
  extractCaIssuerUrls(last)
135
105
  .asSequence()
136
106
  .distinct()
137
107
  .take(maxUrlsPerCert)
138
- // Subtraction, not `>`: overflow-safe across nanoTime's arbitrary origin.
108
+ // Subtraction, not `<`: nanoTime's origin is arbitrary, so its values may overflow.
139
109
  .takeWhile { nowNanos() - deadline < 0 }
140
110
  .flatMap { url -> runCatching { fetch(url, deadline) }.getOrElse { emptyList() } }
141
111
  .firstOrNull { it.subjectX500Principal == last.issuerX500Principal } ?: break
142
- if (!seen.add(issuer)) break // cycle guard
112
+ if (!seen.add(issuer)) break
143
113
  chain.add(issuer)
144
114
  added++
145
115
  }
@@ -147,13 +117,9 @@ object AiaCertChaser {
147
117
  }
148
118
 
149
119
  /**
150
- * Minimal DER TLV reader over a byte buffer. Malformed input throws [IllegalArgumentException],
151
- * which the callers above expect and turn into "no AIA".
152
- *
153
- * Every read is bounds-checked, and a declared length is rejected unless it is non-negative and
154
- * within the buffer. Both matter: the extension bytes come from a server-presented certificate,
155
- * so a length that shifts into a negative Int would rewind `pos` and spin [extractCaIssuerUrls]'s
156
- * loop forever on the handshake thread rather than failing.
120
+ * Minimal DER TLV reader. Malformed input throws [IllegalArgumentException]. The bytes come from
121
+ * a server's certificate: a length that went negative would rewind `pos` and loop forever on the
122
+ * handshake thread, so every length is checked against the buffer.
157
123
  */
158
124
  private class DerReader(private val buf: ByteArray) {
159
125
  private var pos = 0
@@ -164,9 +130,7 @@ object AiaCertChaser {
164
130
  val tag = readByte()
165
131
  var len = readByte()
166
132
  if (len and 0x80 != 0) {
167
- // Long form: the low bits give the number of length bytes. Four already covers any
168
- // buffer that fits in memory; more would overflow the Int we shift them into. The
169
- // indefinite form (0x80, i.e. zero length bytes) is not valid DER.
133
+ // More than four length bytes overflows the Int; zero is BER's indefinite form, not DER.
170
134
  val numBytes = len and 0x7F
171
135
  require(numBytes in 1..4) { "unsupported DER length form: $numBytes length bytes" }
172
136
  len = 0
@@ -185,7 +149,6 @@ object AiaCertChaser {
185
149
  }
186
150
  }
187
151
 
188
- /** A parsed tag-length-value: the tag and a view of its content bytes. */
189
152
  private class Tlv(
190
153
  private val buf: ByteArray,
191
154
  val tag: Int,
@@ -13,27 +13,18 @@ import javax.net.ssl.X509TrustManager
13
13
  import javax.security.auth.x500.X500Principal
14
14
 
15
15
  /**
16
- * The [AiaChasingTrustManager] behaviour, as an [X509ExtendedTrustManager].
16
+ * [AiaChasingTrustManager] as an [X509ExtendedTrustManager], for API 24+ (see
17
+ * [AiaTls.trustManager]). Per-domain network security configs are API 24+ too, so the plain variant
18
+ * below that loses nothing.
17
19
  *
18
- * The socket- and engine-aware overloads are the ones the platform actually calls, and they are not
19
- * optional. Android's default trust manager is a `RootTrustManager`, which extends
20
- * [X509ExtendedTrustManager] and whose two-argument `checkServerTrusted` throws unconditionally
21
- * once the app declares any `<domain-config>` in its network security config:
20
+ * A plain [X509TrustManager] wrapper is not safe here. The platform default, `RootTrustManager`,
21
+ * throws from its two-argument `checkServerTrusted` once the app declares any `<domain-config>`:
22
22
  * > Domain specific configurations require that hostname aware
23
23
  * > checkServerTrusted(X509Certificate[], String, String) is used
24
24
  *
25
- * Wrapping it in a plain [X509TrustManager] hides those overloads, so conscrypt falls through to
26
- * the two-argument form and *every* HTTPS connection in the process fails. The socket overload is
27
- * also where endpoint identification happens for a raw `SSLSocket` configured with
28
- * `endpointIdentificationAlgorithm = "HTTPS"`; skipping it skips hostname verification.
29
- *
30
- * [X509ExtendedTrustManager] is API 24+, hence the split from [AiaChasingTrustManager] — see
31
- * [AiaTls.trustManager], which picks by SDK level. Per-domain network security configs are
32
- * themselves API 24+, so the plain variant on 23 loses nothing.
33
- *
34
- * @param delegate the wrapped trust manager, normally the platform default.
35
- * @param fetch resolves a CA-Issuers URL to its candidate certificates, giving up no later than
36
- * `deadlineNanos`.
25
+ * Hiding the socket and engine overloads sends conscrypt to that form and fails every HTTPS
26
+ * connection in the process. The socket overload is also where a raw `SSLSocket` with
27
+ * `endpointIdentificationAlgorithm = "HTTPS"` verifies the hostname.
37
28
  */
38
29
  @RequiresApi(Build.VERSION_CODES.N)
39
30
  class AiaChasingExtendedTrustManager(
@@ -41,18 +32,13 @@ class AiaChasingExtendedTrustManager(
41
32
  private val fetch: (url: String, deadlineNanos: Long) -> List<X509Certificate>,
42
33
  ) : X509ExtendedTrustManager() {
43
34
 
44
- /** The delegate's own extended overloads, when it has them. */
45
35
  private val extended = delegate as? X509ExtendedTrustManager
46
36
 
47
37
  private val anchorSubjects: Set<X500Principal> by lazy { delegate.anchorSubjects() }
48
38
 
49
39
  /**
50
- * The delegate's Android-specific hostname-aware check, if it has one.
51
- *
52
- * `android.net.http.X509TrustManagerExtensions` — how an HTTP client reaches per-host certificate
53
- * pinning — locates this method reflectively and refuses a trust manager that lacks it. It is not
54
- * part of [X509ExtendedTrustManager], and `RootTrustManager` is not a public type, so it is
55
- * forwarded reflectively rather than overridden.
40
+ * The delegate's Android-only `checkServerTrusted(chain, authType, host)`. It is in no public
41
+ * type, so it is found and forwarded by reflection.
56
42
  */
57
43
  private val hostAwareCheck: Method? by lazy {
58
44
  runCatching {
@@ -75,8 +61,7 @@ class AiaChasingExtendedTrustManager(
75
61
  socket: Socket?,
76
62
  ) =
77
63
  withAiaRetry(chain, anchorSubjects, fetch) {
78
- // A delegate without the extended overloads cannot be hostname-aware in the first place,
79
- // so falling back to its two-argument form loses nothing it could have offered.
64
+ // A delegate without the extended overloads is not hostname-aware, so this loses nothing.
80
65
  extended?.checkServerTrusted(it, authType, socket)
81
66
  ?: delegate.checkServerTrusted(it, authType)
82
67
  }
@@ -92,9 +77,10 @@ class AiaChasingExtendedTrustManager(
92
77
  }
93
78
 
94
79
  /**
95
- * The signature `X509TrustManagerExtensions` looks for: validates against [host] and returns the
96
- * chain it accepted. Kept in step with the other overloads, AIA retry included, so installing
97
- * this wrapper does not cost a consumer its certificate pinning.
80
+ * Validates for [host] and returns the chain accepted, which after an AIA retry includes the
81
+ * fetched intermediates. `android.net.http.X509TrustManagerExtensions`, through which HTTP
82
+ * clients pin certificates, looks this signature up by reflection and refuses a trust manager
83
+ * without it.
98
84
  */
99
85
  @Suppress("unused") // called reflectively
100
86
  fun checkServerTrusted(
@@ -104,17 +90,14 @@ class AiaChasingExtendedTrustManager(
104
90
  ): List<X509Certificate> {
105
91
  var accepted: List<X509Certificate> = emptyList()
106
92
  val method = hostAwareCheck
93
+ // Report the chain that passed, not the one presented: a pinning consumer needs the
94
+ // intermediate that made it validate. `ifEmpty` covers a delegate that returns nothing.
107
95
  withAiaRetry(chain, anchorSubjects, fetch) { checked ->
108
- // Whichever chain passed is the one to report — reporting the originally presented chain
109
- // would hand a pinning consumer a chain missing the intermediate that made it validate.
110
- // `ifEmpty` guards a delegate that reports nothing on success; the checked chain is what
111
- // it accepted, so that is the answer.
112
96
  accepted =
113
97
  if (method != null)
114
98
  invokeHostAware(method, checked, authType, host).ifEmpty { checked.toList() }
115
99
  else {
116
- // Same routing as the other overloads: an extended delegate may refuse its
117
- // two-argument form outright (the domain-config case), so prefer its socket overload.
100
+ // An extended delegate may refuse its two-argument form (the `<domain-config>` case).
118
101
  extended?.checkServerTrusted(checked, authType, null as Socket?)
119
102
  ?: delegate.checkServerTrusted(checked, authType)
120
103
  checked.toList()
@@ -133,7 +116,7 @@ class AiaChasingExtendedTrustManager(
133
116
  try {
134
117
  method.invoke(delegate, chain, authType, host) as List<X509Certificate>
135
118
  } catch (e: InvocationTargetException) {
136
- // Unwrap, so a rejection still reaches withAiaRetry as the CertificateException it is.
119
+ // Unwrapped, so withAiaRetry sees a rejection as the CertificateException it is.
137
120
  when (val cause = e.targetException) {
138
121
  is CertificateException -> throw cause
139
122
  is RuntimeException -> throw cause
@@ -141,7 +124,7 @@ class AiaChasingExtendedTrustManager(
141
124
  }
142
125
  }
143
126
 
144
- // Client certificates are the app's own; there is nothing to chase.
127
+ // Client certificates are the app's own: nothing to chase.
145
128
 
146
129
  override fun checkClientTrusted(chain: Array<X509Certificate>, authType: String) =
147
130
  delegate.checkClientTrusted(chain, authType)
@@ -6,21 +6,15 @@ import javax.net.ssl.X509TrustManager
6
6
  import javax.security.auth.x500.X500Principal
7
7
 
8
8
  /**
9
- * An [X509TrustManager] that retries validation after filling in missing intermediate certificates
10
- * via the leaf's Authority Information Access (AIA) "CA Issuers" pointer.
9
+ * An [X509TrustManager] that, when [delegate] rejects a server chain, fills in missing
10
+ * intermediates from the certificates' AIA "CA Issuers" URLs and lets [delegate] check again. It
11
+ * never accepts a chain [delegate] refuses.
11
12
  *
12
- * Wraps a [delegate] (typically the platform default trust manager). On the happy path the delegate
13
- * accepts the server-presented chain on the first try and this adds nothing. Only when the delegate
14
- * rejects the chain *and* the top of the chain is not already issued by one of the delegate's
15
- * anchors does it attempt AIA chasing. That gate is an issuer-name test, not a diagnosis: it rules
16
- * out the common non-path failures (an expired leaf, a hostname mismatch on a complete chain), but
17
- * a chain topping at a root the device does not carry is still chased whatever its real problem
18
- * was. Either way the *completed* chain is still validated by the same delegate against the system
19
- * trust anchors, so trust can never be weakened: an untrusted root still fails. See
20
- * [AiaCertChaser].
13
+ * The API 23 variant only: on 24+ use [AiaChasingExtendedTrustManager], whose documentation says
14
+ * why a plain [X509TrustManager] wrapper breaks HTTPS there.
21
15
  *
22
- * This is the API 23 variant. On 24+ [AiaChasingExtendedTrustManager] is used instead, and must be:
23
- * see its documentation for why a plain [X509TrustManager] is not a safe wrapper there.
16
+ * @param fetch resolves a CA-Issuers URL to its candidate certificates, giving up no later than
17
+ * `deadlineNanos`.
24
18
  */
25
19
  class AiaChasingTrustManager(
26
20
  private val delegate: X509TrustManager,
@@ -38,24 +32,22 @@ class AiaChasingTrustManager(
38
32
  override fun getAcceptedIssuers(): Array<X509Certificate> = delegate.acceptedIssuers
39
33
  }
40
34
 
41
- /** The subjects of a trust manager's accepted issuers; empty if it will not say. */
35
+ /** The subjects of this trust manager's accepted issuers; empty if it throws instead. */
42
36
  internal fun X509TrustManager.anchorSubjects(): Set<X500Principal> =
43
37
  runCatching { acceptedIssuers.mapTo(HashSet()) { it.subjectX500Principal } }
44
38
  .getOrElse { emptySet() }
45
39
 
46
40
  /**
47
- * Runs [check], and on rejection retries it once against the AIA-completed chain.
41
+ * Runs [check] on [chain]; if it throws a [CertificateException], completes the chain via AIA and
42
+ * runs [check] once more on the result.
48
43
  *
49
- * Nothing is fetched when the presented chain already reaches one of the caller's anchors — see
50
- * [AiaCertChaser.completeChain]'s `anchorSubjects`. Without that test *every* failed handshake in
51
- * the process, whatever the cause, would make a blocking outbound request to a host named by the
52
- * certificate that just failed: an expired certificate, a hostname mismatch and a
53
- * certificate-transparency refusal all arrive here as a [CertificateException] from a delegate that
54
- * is perfectly happy with the path. (The test is on issuer names, so a chain topping at an unknown
55
- * root is still chased even when its real failure was something else.)
44
+ * Nothing is fetched when the chain already tops out at an issuer in [anchorSubjects], so an
45
+ * expired leaf or a hostname mismatch does not make the handshake call out to a host the failed
46
+ * certificate names. The test is on issuer names only: a chain ending at a root the device lacks is
47
+ * chased whatever its real failure.
56
48
  *
57
- * The completed chain goes through the same [check], so trust is never weakened: whatever the
58
- * delegate would have refused, it still refuses.
49
+ * Throws the original failure when nothing could be added; otherwise the retry's failure, with the
50
+ * original attached as suppressed.
59
51
  */
60
52
  internal inline fun withAiaRetry(
61
53
  chain: Array<X509Certificate>,
@@ -67,13 +59,12 @@ internal inline fun withAiaRetry(
67
59
  check(chain)
68
60
  } catch (original: CertificateException) {
69
61
  val completed = AiaCertChaser.completeChain(chain.toList(), anchorSubjects, fetch = fetch)
70
- // Nothing could be added — the original failure stands (don't re-check an unchanged chain).
71
62
  if (completed.size == chain.size) throw original
72
63
  try {
73
64
  check(completed.toTypedArray())
74
65
  } catch (retried: CertificateException) {
75
- // The chase can change which failure the caller sees (a missing intermediate can turn out
76
- // to hide an expiry). Keep the first one attached rather than losing it.
66
+ // The retry can surface a different failure (an expiry behind the missing intermediate);
67
+ // keep the first one too.
77
68
  retried.addSuppressed(original)
78
69
  throw retried
79
70
  }
@@ -9,46 +9,31 @@ import javax.net.ssl.X509ExtendedTrustManager
9
9
  import javax.net.ssl.X509TrustManager
10
10
 
11
11
  /**
12
- * Builds TLS components that recover from servers which omit intermediate CA certificates, by
13
- * following the leaf's Authority Information Access (AIA) "CA Issuers" pointer — the behaviour
14
- * Apple's Secure Transport has by default but Android's lacks.
12
+ * TLS components that recover from servers omitting intermediate CA certificates, by fetching them
13
+ * from the AIA "CA Issuers" URL, as Apple's TLS stack does and Android's does not.
15
14
  *
16
- * The returned components wrap the platform default trust manager and only ever *add* a missing
17
- * intermediate before re-validating against the same system trust anchors, so they cannot weaken
18
- * trust: whatever the platform would have refused, it still refuses.
19
- *
20
- * What they are not is side-effect-free. Completing a chain means fetching the missing intermediate
21
- * from a URL named by the certificate that just failed to validate — so a rejected handshake can
22
- * make an outbound request to a host, port and path of that server's choosing, over cleartext, not
23
- * subject to the app's `NetworkSecurityPolicy`. That is inherent to AIA chasing and is what
24
- * browsers and Apple's Secure Transport do too, but it is a real consequence of installing this,
25
- * and it is bounded rather than absent: see [CachingCertificateFetcher] for the per-fetch limits
26
- * and [AiaCertChaser.MAX_CHASE_MILLIS] for the wall-clock ceiling on the whole chase. The fetch is
27
- * skipped when the chain already reaches one of the system anchors — an issuer-name test, so it
28
- * spares the common expired-leaf and hostname-mismatch failures, but a chain topping at a root the
29
- * device does not carry is still chased whatever its real problem was.
30
- *
31
- * Installing them as a process default (e.g.
32
- * `HttpsURLConnection.setDefaultSSLSocketFactory(AiaTls.socketFactory())`) applies that to every
33
- * connection in the process, and is the caller's decision.
15
+ * They wrap the platform default trust manager and re-validate against the same system anchors, so
16
+ * they never accept a chain the platform refuses. They are not free of side effects: a rejected
17
+ * handshake can make a cleartext request to a URL the server's certificate chooses, outside the
18
+ * app's `NetworkSecurityPolicy`. That is bounded by [CachingCertificateFetcher] per fetch and by
19
+ * [AiaCertChaser.MAX_CHASE_MILLIS] per chase, and installing these as the process default (e.g.
20
+ * `HttpsURLConnection.setDefaultSSLSocketFactory(AiaTls.socketFactory())`) applies it to every
21
+ * connection in the process.
34
22
  */
35
23
  object AiaTls {
36
24
 
37
25
  /**
38
- * An [SSLSocketFactory] whose handshake validation chases missing intermediates via AIA. Intended
39
- * to be built once (e.g. installed as the process default at startup); each call gets its own
40
- * fetched-intermediate cache.
26
+ * An [SSLSocketFactory] that chases missing intermediates. Each call gets its own
27
+ * fetched-intermediate cache, so build it once.
41
28
  */
42
29
  fun socketFactory(): SSLSocketFactory =
43
30
  SSLContext.getInstance("TLS").apply { init(null, arrayOf(trustManager()), null) }.socketFactory
44
31
 
45
32
  /**
46
- * An [X509TrustManager] wrapping the platform default with AIA intermediate chasing.
33
+ * The platform default trust manager with AIA chasing, with its own fetched-intermediate cache.
47
34
  *
48
- * On API 24+ this is an [X509ExtendedTrustManager]. That is not cosmetic: the platform's default
49
- * trust manager rejects the two-argument `checkServerTrusted` outright once the app declares any
50
- * `<domain-config>`, so a plain wrapper would break every HTTPS connection in the process. See
51
- * [AiaChasingExtendedTrustManager].
35
+ * On API 24+ it is an [X509ExtendedTrustManager]; see [AiaChasingExtendedTrustManager] for why a
36
+ * plain wrapper would fail every HTTPS connection there.
52
37
  */
53
38
  fun trustManager(): X509TrustManager {
54
39
  val fetcher = CachingCertificateFetcher()