react-native-audio-browser 0.2.0-next.53 → 0.2.0-next.55

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (599) hide show
  1. package/README.md +32 -19
  2. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  3. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  5. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  6. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  7. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  8. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  9. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  10. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  11. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  12. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  13. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  15. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  16. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  17. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  18. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  19. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  20. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  21. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  22. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  23. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  24. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  25. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  26. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  27. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  28. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  29. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  30. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  31. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  32. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  33. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  34. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  35. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  36. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  37. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  38. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  39. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  40. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  41. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  42. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  43. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  45. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  46. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  50. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  51. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  52. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  53. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  54. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  55. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  56. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  58. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  59. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  60. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  61. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  63. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  64. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  66. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +28 -48
  67. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  68. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  71. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  78. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  80. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  81. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  82. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  84. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  85. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  86. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  90. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  91. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  92. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  93. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  94. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  96. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  97. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  98. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  99. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  100. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  102. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  103. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  104. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  105. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  106. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  107. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  108. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  109. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  110. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  111. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  112. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  113. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  114. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  115. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  116. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  121. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  122. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  123. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  124. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  125. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  126. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  127. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  128. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  129. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  130. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  131. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  132. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  133. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  134. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  135. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  136. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  137. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  138. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  139. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  143. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  144. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +2 -2
  145. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  146. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +5 -1
  149. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  150. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  151. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  152. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  153. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  154. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  155. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  156. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +9 -10
  157. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +0 -1
  158. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  159. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  167. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  168. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  169. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  170. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  172. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  174. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  175. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  177. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  178. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  179. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  180. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  181. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  183. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  184. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  185. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  186. package/ios/AVPlayerEngine.swift +13 -21
  187. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  188. package/ios/Browser/BrowseGate.swift +7 -8
  189. package/ios/Browser/BrowserConfig.swift +19 -34
  190. package/ios/Browser/BrowserError.swift +0 -1
  191. package/ios/Browser/BrowserManager.swift +29 -75
  192. package/ios/Browser/BrowserPathHelper.swift +13 -93
  193. package/ios/Browser/FavoriteSet.swift +7 -10
  194. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  195. package/ios/Browser/JsonModels.swift +11 -51
  196. package/ios/Browser/NavigationErrorState.swift +3 -2
  197. package/ios/Browser/PageResolver.swift +13 -23
  198. package/ios/Browser/RequestLayer.swift +16 -20
  199. package/ios/Browser/RequestPipeline.swift +33 -43
  200. package/ios/Browser/SearchDrillIn.swift +7 -13
  201. package/ios/Browser/SectionScope.swift +14 -26
  202. package/ios/Browser/SimpleRouter.swift +8 -15
  203. package/ios/Browser/StyleResolver.swift +12 -29
  204. package/ios/Browser/TabBarEntries.swift +6 -11
  205. package/ios/Browser/TrackIdTemplate.swift +6 -14
  206. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  207. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  208. package/ios/CarPlay/CarPlayController.swift +4 -4
  209. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  210. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  211. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  212. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  213. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  214. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  215. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  216. package/ios/CarPlay/CarPlaySession.swift +13 -17
  217. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  218. package/ios/CarPlay/IntentHandlers.swift +3 -5
  219. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  220. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  221. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  222. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  223. package/ios/CarPlay/SectionPresentation.swift +18 -28
  224. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  225. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  226. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  227. package/ios/Extension/CxxVectorConformances.swift +4 -16
  228. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  229. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  230. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  231. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  232. package/ios/Extension/SearchParams+Query.swift +4 -4
  233. package/ios/Extension/Section+Copying.swift +3 -6
  234. package/ios/Extension/String+IcyCharset.swift +5 -5
  235. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  236. package/ios/Extension/Track+AVPlayer.swift +1 -2
  237. package/ios/Extension/Track+Copying.swift +2 -8
  238. package/ios/Extension/Track+Identity.swift +4 -9
  239. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  240. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  241. package/ios/Extension/Variant+Artwork.swift +8 -22
  242. package/ios/Http/HttpClient.swift +3 -3
  243. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  244. package/ios/HybridAudioBrowser+Options.swift +6 -9
  245. package/ios/HybridAudioBrowser+Player.swift +8 -16
  246. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  247. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  248. package/ios/HybridAudioBrowser.swift +54 -79
  249. package/ios/Model/NitroTypeStubs.swift +15 -22
  250. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  251. package/ios/Model/RemoteCommand.swift +2 -2
  252. package/ios/Model/TrackPlayerError.swift +9 -22
  253. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  254. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  255. package/ios/Observer/ItemObserver.swift +7 -5
  256. package/ios/Observer/PlayerObserver.swift +5 -5
  257. package/ios/PlaybackEvent.swift +2 -2
  258. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  259. package/ios/Player/AudioSessionController.swift +14 -15
  260. package/ios/Player/DeferredSeek.swift +2 -2
  261. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  262. package/ios/Player/ErrorStatus.swift +8 -7
  263. package/ios/Player/MediaLoader.swift +20 -24
  264. package/ios/Player/NowPlayingLines.swift +1 -4
  265. package/ios/Player/NowPlayingUpdater.swift +35 -61
  266. package/ios/Player/PersistedPlaybackState.swift +1 -2
  267. package/ios/Player/PlaybackFailure.swift +20 -24
  268. package/ios/Player/PlaybackPersistence.swift +5 -6
  269. package/ios/Player/PlaybackStateMachine.swift +8 -11
  270. package/ios/Player/PlaybackTimer.swift +8 -11
  271. package/ios/Player/Player.swift +6 -13
  272. package/ios/Player/PlayerEngine.swift +20 -20
  273. package/ios/Player/PlayerStatusTypes.swift +1 -2
  274. package/ios/Player/QueueManager.swift +23 -67
  275. package/ios/Player/RetryLoop.swift +39 -50
  276. package/ios/Player/ShuffleOrder.swift +17 -57
  277. package/ios/Player/SleepTimerManager.swift +13 -28
  278. package/ios/Player/VolumeFader.swift +16 -16
  279. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  280. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  281. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  282. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  283. package/ios/Tests/DeferredSeekTests.swift +1 -3
  284. package/ios/Tests/EmitterTests.swift +0 -1
  285. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  286. package/ios/Tests/FavoriteSetTests.swift +1 -0
  287. package/ios/Tests/GenerationMemoTests.swift +2 -2
  288. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  289. package/ios/Tests/JsonModelsTests.swift +5 -12
  290. package/ios/Tests/LRUCacheTests.swift +1 -5
  291. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  292. package/ios/Tests/MediaLoaderTests.swift +3 -12
  293. package/ios/Tests/ObserverTests.swift +3 -3
  294. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  295. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  296. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  297. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  298. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  299. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  300. package/ios/Tests/PlayerTests.swift +53 -88
  301. package/ios/Tests/PlayingStateTests.swift +0 -1
  302. package/ios/Tests/QueueManagerTests.swift +30 -80
  303. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  304. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  305. package/ios/Tests/RetryLoopTests.swift +12 -35
  306. package/ios/Tests/SearchDrillInTests.swift +4 -5
  307. package/ios/Tests/SectionPresentationTests.swift +3 -16
  308. package/ios/Tests/SectionScopeTests.swift +3 -6
  309. package/ios/Tests/SimpleRouterTests.swift +1 -5
  310. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  311. package/ios/Tests/StyleResolverTests.swift +4 -13
  312. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  313. package/ios/Tests/Support/TestTypes.swift +5 -15
  314. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  315. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  316. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  317. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  318. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  319. package/ios/Tests/TrackSelectorTests.swift +3 -15
  320. package/ios/TrackSelector.swift +13 -25
  321. package/ios/Util/ArtworkFreshness.swift +6 -6
  322. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  323. package/ios/Util/ConcurrentMap.swift +2 -2
  324. package/ios/Util/Emitter.swift +8 -13
  325. package/ios/Util/NetworkMonitor.swift +4 -6
  326. package/ios/Util/OutputPicker.swift +1 -1
  327. package/ios/Util/ReadyValue.swift +3 -2
  328. package/ios/Util/SFSymbolRenderer.swift +17 -30
  329. package/ios/Util/SVGProcessor.swift +5 -9
  330. package/lib/commonjs/CLAUDE.md +7 -2
  331. package/lib/commonjs/features/battery.js +16 -12
  332. package/lib/commonjs/features/battery.js.map +1 -1
  333. package/lib/commonjs/features/browser-config.js +1 -1
  334. package/lib/commonjs/features/browser.js +74 -24
  335. package/lib/commonjs/features/browser.js.map +1 -1
  336. package/lib/commonjs/features/carConnection.js +3 -4
  337. package/lib/commonjs/features/carConnection.js.map +1 -1
  338. package/lib/commonjs/features/equalizer.js +9 -5
  339. package/lib/commonjs/features/equalizer.js.map +1 -1
  340. package/lib/commonjs/features/errors.js +35 -21
  341. package/lib/commonjs/features/errors.js.map +1 -1
  342. package/lib/commonjs/features/favorites.js +15 -13
  343. package/lib/commonjs/features/favorites.js.map +1 -1
  344. package/lib/commonjs/features/gate.js +12 -6
  345. package/lib/commonjs/features/gate.js.map +1 -1
  346. package/lib/commonjs/features/metadata.js +16 -14
  347. package/lib/commonjs/features/metadata.js.map +1 -1
  348. package/lib/commonjs/features/network.js +5 -1
  349. package/lib/commonjs/features/network.js.map +1 -1
  350. package/lib/commonjs/features/nowPlaying.js +28 -14
  351. package/lib/commonjs/features/nowPlaying.js.map +1 -1
  352. package/lib/commonjs/features/output.js +8 -4
  353. package/lib/commonjs/features/output.js.map +1 -1
  354. package/lib/commonjs/features/playback/controls.js +10 -5
  355. package/lib/commonjs/features/playback/controls.js.map +1 -1
  356. package/lib/commonjs/features/playback/playWhenReady.js +6 -5
  357. package/lib/commonjs/features/playback/playWhenReady.js.map +1 -1
  358. package/lib/commonjs/features/playback/playing.js +5 -3
  359. package/lib/commonjs/features/playback/playing.js.map +1 -1
  360. package/lib/commonjs/features/playback/progress.js +11 -5
  361. package/lib/commonjs/features/playback/progress.js.map +1 -1
  362. package/lib/commonjs/features/playback/state.js +3 -3
  363. package/lib/commonjs/features/playback/state.js.map +1 -1
  364. package/lib/commonjs/features/playback/trackPlaybackTime.js +6 -1
  365. package/lib/commonjs/features/playback/trackPlaybackTime.js.map +1 -1
  366. package/lib/commonjs/features/playback/volume.js +6 -5
  367. package/lib/commonjs/features/playback/volume.js.map +1 -1
  368. package/lib/commonjs/features/player/options.js +20 -10
  369. package/lib/commonjs/features/player/options.js.map +1 -1
  370. package/lib/commonjs/features/player/setup.js +34 -38
  371. package/lib/commonjs/features/player/setup.js.map +1 -1
  372. package/lib/commonjs/features/queue/activeTrack.js +0 -1
  373. package/lib/commonjs/features/queue/activeTrack.js.map +1 -1
  374. package/lib/commonjs/features/queue/queue.js +48 -20
  375. package/lib/commonjs/features/queue/queue.js.map +1 -1
  376. package/lib/commonjs/features/queue/repeatMode.js +2 -1
  377. package/lib/commonjs/features/queue/repeatMode.js.map +1 -1
  378. package/lib/commonjs/features/queue/shuffle.js +0 -1
  379. package/lib/commonjs/features/queue/shuffle.js.map +1 -1
  380. package/lib/commonjs/features/remoteControls.js +59 -35
  381. package/lib/commonjs/features/remoteControls.js.map +1 -1
  382. package/lib/commonjs/features/sleepTimer.js +15 -6
  383. package/lib/commonjs/features/sleepTimer.js.map +1 -1
  384. package/lib/commonjs/utils/LazyNativeEmitter.js +6 -9
  385. package/lib/commonjs/utils/LazyNativeEmitter.js.map +1 -1
  386. package/lib/commonjs/utils/NativeUpdatedValue.js +13 -12
  387. package/lib/commonjs/utils/NativeUpdatedValue.js.map +1 -1
  388. package/lib/commonjs/utils/getTrackIdentity.js +6 -4
  389. package/lib/commonjs/utils/getTrackIdentity.js.map +1 -1
  390. package/lib/commonjs/utils/useDebug.js +16 -3
  391. package/lib/commonjs/utils/useDebug.js.map +1 -1
  392. package/lib/commonjs/web/NativeAudioBrowser.js +2 -4
  393. package/lib/commonjs/web/NativeAudioBrowser.js.map +1 -1
  394. package/lib/commonjs/web/browser/parseSearchResponse.js +3 -4
  395. package/lib/commonjs/web/browser/parseSearchResponse.js.map +1 -1
  396. package/lib/commonjs/web/browser/sections.js +1 -1
  397. package/lib/commonjs/web/util/BrowserPathHelper.js +1 -3
  398. package/lib/commonjs/web/util/BrowserPathHelper.js.map +1 -1
  399. package/lib/module/CLAUDE.md +7 -2
  400. package/lib/module/features/battery.js +16 -12
  401. package/lib/module/features/battery.js.map +1 -1
  402. package/lib/module/features/browser-config.js +1 -1
  403. package/lib/module/features/browser.js +74 -24
  404. package/lib/module/features/browser.js.map +1 -1
  405. package/lib/module/features/carConnection.js +3 -4
  406. package/lib/module/features/carConnection.js.map +1 -1
  407. package/lib/module/features/equalizer.js +9 -5
  408. package/lib/module/features/equalizer.js.map +1 -1
  409. package/lib/module/features/errors.js +35 -21
  410. package/lib/module/features/errors.js.map +1 -1
  411. package/lib/module/features/favorites.js +15 -13
  412. package/lib/module/features/favorites.js.map +1 -1
  413. package/lib/module/features/gate.js +12 -6
  414. package/lib/module/features/gate.js.map +1 -1
  415. package/lib/module/features/metadata.js +16 -14
  416. package/lib/module/features/metadata.js.map +1 -1
  417. package/lib/module/features/network.js +5 -1
  418. package/lib/module/features/network.js.map +1 -1
  419. package/lib/module/features/nowPlaying.js +28 -14
  420. package/lib/module/features/nowPlaying.js.map +1 -1
  421. package/lib/module/features/output.js +8 -4
  422. package/lib/module/features/output.js.map +1 -1
  423. package/lib/module/features/playback/controls.js +10 -5
  424. package/lib/module/features/playback/controls.js.map +1 -1
  425. package/lib/module/features/playback/playWhenReady.js +6 -5
  426. package/lib/module/features/playback/playWhenReady.js.map +1 -1
  427. package/lib/module/features/playback/playing.js +5 -3
  428. package/lib/module/features/playback/playing.js.map +1 -1
  429. package/lib/module/features/playback/progress.js +11 -5
  430. package/lib/module/features/playback/progress.js.map +1 -1
  431. package/lib/module/features/playback/state.js +3 -3
  432. package/lib/module/features/playback/state.js.map +1 -1
  433. package/lib/module/features/playback/trackPlaybackTime.js +6 -1
  434. package/lib/module/features/playback/trackPlaybackTime.js.map +1 -1
  435. package/lib/module/features/playback/volume.js +6 -5
  436. package/lib/module/features/playback/volume.js.map +1 -1
  437. package/lib/module/features/player/options.js +20 -10
  438. package/lib/module/features/player/options.js.map +1 -1
  439. package/lib/module/features/player/setup.js +34 -38
  440. package/lib/module/features/player/setup.js.map +1 -1
  441. package/lib/module/features/queue/activeTrack.js +0 -1
  442. package/lib/module/features/queue/activeTrack.js.map +1 -1
  443. package/lib/module/features/queue/queue.js +48 -20
  444. package/lib/module/features/queue/queue.js.map +1 -1
  445. package/lib/module/features/queue/repeatMode.js +2 -1
  446. package/lib/module/features/queue/repeatMode.js.map +1 -1
  447. package/lib/module/features/queue/shuffle.js +0 -1
  448. package/lib/module/features/queue/shuffle.js.map +1 -1
  449. package/lib/module/features/remoteControls.js +59 -35
  450. package/lib/module/features/remoteControls.js.map +1 -1
  451. package/lib/module/features/sleepTimer.js +15 -6
  452. package/lib/module/features/sleepTimer.js.map +1 -1
  453. package/lib/module/utils/LazyNativeEmitter.js +6 -9
  454. package/lib/module/utils/LazyNativeEmitter.js.map +1 -1
  455. package/lib/module/utils/NativeUpdatedValue.js +13 -12
  456. package/lib/module/utils/NativeUpdatedValue.js.map +1 -1
  457. package/lib/module/utils/getTrackIdentity.js +6 -4
  458. package/lib/module/utils/getTrackIdentity.js.map +1 -1
  459. package/lib/module/utils/useDebug.js +16 -3
  460. package/lib/module/utils/useDebug.js.map +1 -1
  461. package/lib/module/web/NativeAudioBrowser.js +2 -4
  462. package/lib/module/web/NativeAudioBrowser.js.map +1 -1
  463. package/lib/module/web/browser/parseSearchResponse.js +3 -4
  464. package/lib/module/web/browser/parseSearchResponse.js.map +1 -1
  465. package/lib/module/web/browser/sections.js +1 -1
  466. package/lib/module/web/util/BrowserPathHelper.js +1 -3
  467. package/lib/module/web/util/BrowserPathHelper.js.map +1 -1
  468. package/lib/typescript/src/features/battery.d.ts +17 -12
  469. package/lib/typescript/src/features/battery.d.ts.map +1 -1
  470. package/lib/typescript/src/features/browser.d.ts +64 -24
  471. package/lib/typescript/src/features/browser.d.ts.map +1 -1
  472. package/lib/typescript/src/features/carConnection.d.ts +3 -4
  473. package/lib/typescript/src/features/carConnection.d.ts.map +1 -1
  474. package/lib/typescript/src/features/equalizer.d.ts +9 -5
  475. package/lib/typescript/src/features/equalizer.d.ts.map +1 -1
  476. package/lib/typescript/src/features/errors.d.ts +37 -22
  477. package/lib/typescript/src/features/errors.d.ts.map +1 -1
  478. package/lib/typescript/src/features/favorites.d.ts +15 -13
  479. package/lib/typescript/src/features/favorites.d.ts.map +1 -1
  480. package/lib/typescript/src/features/gate.d.ts +14 -8
  481. package/lib/typescript/src/features/gate.d.ts.map +1 -1
  482. package/lib/typescript/src/features/metadata.d.ts +37 -17
  483. package/lib/typescript/src/features/metadata.d.ts.map +1 -1
  484. package/lib/typescript/src/features/network.d.ts +5 -1
  485. package/lib/typescript/src/features/network.d.ts.map +1 -1
  486. package/lib/typescript/src/features/nowPlaying.d.ts +28 -14
  487. package/lib/typescript/src/features/nowPlaying.d.ts.map +1 -1
  488. package/lib/typescript/src/features/output.d.ts +8 -4
  489. package/lib/typescript/src/features/output.d.ts.map +1 -1
  490. package/lib/typescript/src/features/playback/controls.d.ts +10 -5
  491. package/lib/typescript/src/features/playback/controls.d.ts.map +1 -1
  492. package/lib/typescript/src/features/playback/playWhenReady.d.ts +6 -5
  493. package/lib/typescript/src/features/playback/playWhenReady.d.ts.map +1 -1
  494. package/lib/typescript/src/features/playback/playing.d.ts +16 -3
  495. package/lib/typescript/src/features/playback/playing.d.ts.map +1 -1
  496. package/lib/typescript/src/features/playback/progress.d.ts +11 -5
  497. package/lib/typescript/src/features/playback/progress.d.ts.map +1 -1
  498. package/lib/typescript/src/features/playback/state.d.ts +8 -3
  499. package/lib/typescript/src/features/playback/state.d.ts.map +1 -1
  500. package/lib/typescript/src/features/playback/trackPlaybackTime.d.ts +9 -2
  501. package/lib/typescript/src/features/playback/trackPlaybackTime.d.ts.map +1 -1
  502. package/lib/typescript/src/features/playback/volume.d.ts +6 -5
  503. package/lib/typescript/src/features/playback/volume.d.ts.map +1 -1
  504. package/lib/typescript/src/features/player/options.d.ts +52 -37
  505. package/lib/typescript/src/features/player/options.d.ts.map +1 -1
  506. package/lib/typescript/src/features/player/setup.d.ts +65 -60
  507. package/lib/typescript/src/features/player/setup.d.ts.map +1 -1
  508. package/lib/typescript/src/features/queue/activeTrack.d.ts +0 -1
  509. package/lib/typescript/src/features/queue/activeTrack.d.ts.map +1 -1
  510. package/lib/typescript/src/features/queue/queue.d.ts +48 -20
  511. package/lib/typescript/src/features/queue/queue.d.ts.map +1 -1
  512. package/lib/typescript/src/features/queue/repeatMode.d.ts +1 -1
  513. package/lib/typescript/src/features/queue/repeatMode.d.ts.map +1 -1
  514. package/lib/typescript/src/features/queue/shuffle.d.ts +0 -1
  515. package/lib/typescript/src/features/queue/shuffle.d.ts.map +1 -1
  516. package/lib/typescript/src/features/remoteControls.d.ts +58 -25
  517. package/lib/typescript/src/features/remoteControls.d.ts.map +1 -1
  518. package/lib/typescript/src/features/sleepTimer.d.ts +15 -7
  519. package/lib/typescript/src/features/sleepTimer.d.ts.map +1 -1
  520. package/lib/typescript/src/types/browser-nodes.d.ts +54 -57
  521. package/lib/typescript/src/types/browser-nodes.d.ts.map +1 -1
  522. package/lib/typescript/src/types/browser.d.ts +181 -144
  523. package/lib/typescript/src/types/browser.d.ts.map +1 -1
  524. package/lib/typescript/src/utils/LazyNativeEmitter.d.ts +6 -9
  525. package/lib/typescript/src/utils/LazyNativeEmitter.d.ts.map +1 -1
  526. package/lib/typescript/src/utils/NativeUpdatedValue.d.ts +13 -12
  527. package/lib/typescript/src/utils/NativeUpdatedValue.d.ts.map +1 -1
  528. package/lib/typescript/src/utils/getTrackIdentity.d.ts +6 -4
  529. package/lib/typescript/src/utils/getTrackIdentity.d.ts.map +1 -1
  530. package/lib/typescript/src/utils/useDebug.d.ts +16 -3
  531. package/lib/typescript/src/utils/useDebug.d.ts.map +1 -1
  532. package/package.json +1 -1
  533. package/src/CLAUDE.md +7 -2
  534. package/src/docs-floors.test.ts +71 -0
  535. package/src/features/battery.ts +17 -13
  536. package/src/features/browser-config.ts +1 -1
  537. package/src/features/browser.ts +65 -24
  538. package/src/features/carConnection.ts +3 -4
  539. package/src/features/equalizer.ts +9 -5
  540. package/src/features/errors.ts +37 -22
  541. package/src/features/favorites.ts +15 -13
  542. package/src/features/gate.ts +14 -8
  543. package/src/features/metadata.ts +37 -17
  544. package/src/features/network.ts +5 -1
  545. package/src/features/nowPlaying.ts +28 -14
  546. package/src/features/output.ts +8 -4
  547. package/src/features/playback/controls.ts +10 -5
  548. package/src/features/playback/playWhenReady.ts +6 -5
  549. package/src/features/playback/playing.ts +16 -3
  550. package/src/features/playback/progress.ts +11 -5
  551. package/src/features/playback/state.ts +8 -3
  552. package/src/features/playback/trackPlaybackTime.ts +9 -2
  553. package/src/features/playback/volume.ts +6 -5
  554. package/src/features/player/options.ts +54 -43
  555. package/src/features/player/setup.ts +67 -61
  556. package/src/features/queue/activeTrack.ts +0 -1
  557. package/src/features/queue/queue.ts +48 -20
  558. package/src/features/queue/repeatMode.ts +1 -1
  559. package/src/features/queue/shuffle.ts +0 -1
  560. package/src/features/remoteControls.ts +59 -35
  561. package/src/features/sleepTimer.ts +15 -7
  562. package/src/types/browser-nodes.ts +54 -57
  563. package/src/types/browser.ts +183 -146
  564. package/src/utils/LazyNativeEmitter.ts +6 -9
  565. package/src/utils/NativeUpdatedValue.ts +13 -12
  566. package/src/utils/getTrackIdentity.ts +6 -4
  567. package/src/utils/useDebug.ts +16 -3
  568. package/src/web/NativeAudioBrowser.ts +2 -4
  569. package/src/web/browser/parseSearchResponse.ts +3 -4
  570. package/src/web/browser/sections.ts +1 -1
  571. package/src/web/util/BrowserPathHelper.ts +1 -3
  572. package/website/guide/android-auto.md +25 -13
  573. package/website/guide/android-certificates.md +199 -120
  574. package/website/guide/artwork.md +93 -48
  575. package/website/guide/audio-output.md +86 -68
  576. package/website/guide/automotive.md +15 -10
  577. package/website/guide/basic-usage.md +5 -2
  578. package/website/guide/battery.md +50 -23
  579. package/website/guide/browser.md +155 -68
  580. package/website/guide/carplay.md +132 -49
  581. package/website/guide/configuration.md +85 -49
  582. package/website/guide/equalizer.md +36 -32
  583. package/website/guide/errors.md +106 -64
  584. package/website/guide/favorites.md +41 -31
  585. package/website/guide/gate.md +24 -10
  586. package/website/guide/getting-started.md +55 -2
  587. package/website/guide/hooks.md +53 -47
  588. package/website/guide/live-streams.md +80 -49
  589. package/website/guide/metadata.md +87 -53
  590. package/website/guide/migrating-from-track-player.md +94 -49
  591. package/website/guide/native-callback-fetch.md +46 -36
  592. package/website/guide/network.md +36 -20
  593. package/website/guide/now-playing.md +72 -44
  594. package/website/guide/playback.md +112 -35
  595. package/website/guide/queue.md +77 -43
  596. package/website/guide/remote-controls.md +87 -29
  597. package/website/guide/search.md +37 -22
  598. package/website/guide/sleep-timer.md +35 -14
  599. package/website/guide/track.md +59 -35
@@ -33,7 +33,7 @@ class BrowseArtworkRegistryTest {
33
33
  reg.register("a", ResolvedArtwork("https://x/a", null, false))
34
34
  reg.register("b", ResolvedArtwork("https://x/b", null, false))
35
35
  reg.register("c", ResolvedArtwork("https://x/c", null, false))
36
- assertNull(reg.lookup("a")) // evicted
36
+ assertNull(reg.lookup("a"))
37
37
  assertEquals("https://x/c", reg.lookup("c")?.finalUrl)
38
38
  }
39
39
  }
@@ -9,10 +9,8 @@ import org.junit.Before
9
9
  import org.junit.Test
10
10
 
11
11
  /**
12
- * Tests [BrowserManager.buildApiRequest] — the single request-building path for browse and search
13
- * (the Kotlin port of iOS `buildApiRequest`). Static layers only: Nitro Promises
14
- * (transforms/resolvers) cannot be constructed on the JVM; transform semantics are covered by
15
- * RequestConfigBuilderTest and the Swift suite.
12
+ * Static layers only: Nitro Promises (transforms, resolvers) cannot be constructed on the JVM, so
13
+ * transforms are covered by RequestConfigBuilderTest and the Swift suite.
16
14
  */
17
15
  class BrowserManagerBuildApiRequestTest {
18
16
 
@@ -49,8 +47,6 @@ class BrowserManagerBuildApiRequestTest {
49
47
  bm.buildApiRequest(
50
48
  kindConfig = transformableConfig(query = mapOf("extra" to "1")),
51
49
  routeConfig = null,
52
- // The caller seeds the kind's path onto the base (as search does) — a
53
- // layer's own static path never applies.
54
50
  path = "/search",
55
51
  params = emptyMap(),
56
52
  initialQuery = mapOf("q" to "jazz", "mode" to "genre"),
@@ -62,8 +58,6 @@ class BrowserManagerBuildApiRequestTest {
62
58
 
63
59
  @Test
64
60
  fun `a layer's static path does not override the base path`() = runTest {
65
- // Mirrors iOS applyLayer and the web stub: the path is carried from the
66
- // base through every Request-Config Layer; only a Transform may change it.
67
61
  bm.config = BrowserConfig(request = transformableConfig(baseUrl = "https://api.example.com"))
68
62
  val request =
69
63
  bm.buildApiRequest(
@@ -10,14 +10,7 @@ import org.junit.Test
10
10
  import org.junit.runner.RunWith
11
11
  import org.robolectric.RobolectricTestRunner
12
12
 
13
- /**
14
- * Favorite hydration keyed by track identity (id when non-blank, else src — see Track.identity /
15
- * ADR 0008). Hydration is exercised through [BrowserManager.resolve], the path every browse page
16
- * takes.
17
- *
18
- * Routes serve `browseStatic` (no JNI/HTTP); Robolectric is required for `android.util.LruCache`
19
- * and `android.net.Uri`.
20
- */
13
+ // Robolectric provides the android.util.LruCache and android.net.Uri that BrowserManager uses.
21
14
  @RunWith(RobolectricTestRunner::class)
22
15
  class BrowserManagerFavoritesTest {
23
16
 
@@ -77,8 +70,6 @@ class BrowserManagerFavoritesTest {
77
70
 
78
71
  @Test
79
72
  fun `a favorite stored under src does not match an id-bearing track`() = runBlocking {
80
- // The identity is the id when present — a src-keyed entry must not light up
81
- // a track whose identity is its id (one rule, no partial matching).
82
73
  servePage("/home", track(title = "A", id = "stable-a", src = "https://s/a.mp3"))
83
74
  browserManager.setFavoriteEnabled(true)
84
75
  browserManager.setFavorites(listOf("https://s/a.mp3"))
@@ -99,14 +90,13 @@ class BrowserManagerFavoritesTest {
99
90
 
100
91
  val resolved = browserManager.resolve("/home")
101
92
 
102
- // API-provided value is never overwritten, even when the identity is favorited.
103
93
  assertEquals(mapOf("A" to false), favoritedByTitle(resolved.flattenedChildren?.toTypedArray()))
104
94
  }
105
95
 
106
96
  @Test
107
97
  fun `disabled favoriting leaves tracks untouched`() = runBlocking {
108
98
  servePage("/home", track(title = "A", id = "stable-a", src = "https://s/a.mp3"))
109
- // favoriteEnabled defaults to false
99
+ // favoriteEnabled defaults to false.
110
100
  browserManager.setFavorites(listOf("stable-a"))
111
101
 
112
102
  val resolved = browserManager.resolve("/home")
@@ -12,26 +12,11 @@ import org.junit.runner.RunWith
12
12
  import org.robolectric.RobolectricTestRunner
13
13
 
14
14
  /**
15
- * Tests the request/browse layer resolution + caching introduced for resolver thunks.
16
- *
17
- * These tests exercise [BrowserManager.ensureLayersResolved]'s generation guard via the STATIC
18
- * layer path (`config.request` / `config.browse`, with the resolver thunks null). The guard is the
19
- * core of the per-content-generation caching: a static layer is resolved once and cached until the
20
- * generation bumps (config-set or [BrowserManager.clearContentCache], which runs from
21
- * `invalidateAllContent`), after which it is re-resolved.
22
- *
23
- * NOTE (gap): a test that proves a *resolver thunk* (`config.requestResolver`) is invoked exactly
24
- * once per generation is not included here. The resolver returns a Nitro `Promise<Variant<...>>`,
25
- * and constructing/awaiting a real Nitro `Promise` requires the JNI bridge (`Promise.initHybrid()`
26
- * / `nativeResolve` are `external`), which is unavailable in a JVM/Robolectric unit test. The
27
- * generation-guard logic those tests would assert (resolve-once-per-generation, re-resolve after a
28
- * bump, no in-flight cache) is identical for the static and resolver paths — `resolveLayer` only
29
- * differs in how it produces the `TransformableRequestConfig` — so the guard is fully covered here.
30
- * The resolver-await path is covered by the TS/web-stub tests and on iOS.
31
- *
32
- * Runs under Robolectric for [BrowserManager]'s `android.util.LruCache` fields: `clearContentCache`
33
- * calls `evictAll()`, which a plain JVM test cannot execute.
15
+ * Covers the generation guard through static layers only. A resolver thunk or viewMoreTitle
16
+ * callback returns a Nitro Promise, which needs the JNI bridge a JVM test lacks; the guard is the
17
+ * same for both paths.
34
18
  */
19
+ // Robolectric provides the android.util.LruCache whose evictAll() clearContentCache calls.
35
20
  @RunWith(RobolectricTestRunner::class)
36
21
  class BrowserManagerLayerResolutionTest {
37
22
 
@@ -62,7 +47,7 @@ class BrowserManagerLayerResolutionTest {
62
47
  val browse = staticConfig("/browse")
63
48
  browserManager.config = BrowserConfig(request = request, browse = browse)
64
49
 
65
- // First resolution: nothing cached yet (resolvedLayerGeneration starts at -1).
50
+ // -1: never resolved.
66
51
  val genAfterConfigSet = browserManager.layerGenerationForTest
67
52
  assertEquals(-1, browserManager.resolvedLayerGenerationForTest)
68
53
 
@@ -72,7 +57,6 @@ class BrowserManagerLayerResolutionTest {
72
57
  assertSame(request, browserManager.resolvedRequestLayerForTest)
73
58
  assertSame(browse, browserManager.resolvedBrowseLayerForTest)
74
59
 
75
- // Second call in the same generation is a no-op: the cached layers are untouched.
76
60
  browserManager.ensureLayersResolved()
77
61
  assertEquals(genAfterConfigSet, browserManager.resolvedLayerGenerationForTest)
78
62
  assertSame(request, browserManager.resolvedRequestLayerForTest)
@@ -86,15 +70,10 @@ class BrowserManagerLayerResolutionTest {
86
70
  val firstGen = browserManager.resolvedLayerGenerationForTest
87
71
  assertSame(request1, browserManager.resolvedRequestLayerForTest)
88
72
 
89
- // invalidateAllContent() routes through clearContentCache(): bump the generation.
90
73
  browserManager.clearContentCache()
91
74
  assertEquals(firstGen + 1, browserManager.layerGenerationForTest)
92
- // Cache is now stale: the resolved generation no longer matches.
93
75
  assertEquals(firstGen, browserManager.resolvedLayerGenerationForTest)
94
76
 
95
- // Swap the underlying config (the resolver/static layer can change between generations)
96
- // WITHOUT bumping generation again via the setter — emulate the resolver returning a new value
97
- // by re-resolving against a fresh config set, which itself bumps once.
98
77
  val request2 = staticConfig("/v2")
99
78
  val genBeforeSet = browserManager.layerGenerationForTest
100
79
  browserManager.config = BrowserConfig(request = request2)
@@ -147,8 +126,6 @@ class BrowserManagerLayerResolutionTest {
147
126
 
148
127
  @Test
149
128
  fun `viewMoreTitle falls back to the in-code default when unconfigured`() = runTest {
150
- // The only viewMoreTitle path a JVM test can reach — a configured callback returns a Nitro
151
- // Promise, see the resolver-thunk gap noted above.
152
129
  browserManager.config = BrowserConfig()
153
130
 
154
131
  assertEquals(BrowserManager.DEFAULT_VIEW_MORE_TITLE, browserManager.viewMoreTitle())
@@ -18,17 +18,10 @@ import org.junit.runner.RunWith
18
18
  import org.robolectric.RobolectricTestRunner
19
19
 
20
20
  /**
21
- * Navigation and queue-expansion glue.
22
- *
23
- * [BrowserManager.expandQueueFromContextualPath] is the seam between the page a listener tapped in
24
- * and the queue that starts playing. Its two halves are covered on their own — the section logic in
25
- * [SectionScopeTest], the caller's single-track fallback in the player tests — but the wiring
26
- * between them is what decides whether tapping row 3 of a page resumes the right station, and only
27
- * these tests exercise it.
28
- *
29
- * Routes serve `browseStatic`, the one browse arm that needs neither the JNI bridge nor HTTP.
30
- * Robolectric is required for `android.net.Uri` (contextual-path parsing) and
31
- * `android.util.LruCache` (the content cache).
21
+ * The wiring between a tapped page and the queue that starts playing; [SectionScopeTest] covers the
22
+ * section logic on its own. Routes serve `browseStatic`, the one browse arm that needs neither the
23
+ * JNI bridge nor HTTP. Robolectric provides `android.net.Uri` (contextual-path parsing) and
24
+ * `android.util.LruCache`.
32
25
  */
33
26
  @RunWith(RobolectricTestRunner::class)
34
27
  class BrowserManagerTest {
@@ -40,7 +33,6 @@ class BrowserManagerTest {
40
33
  browserManager = BrowserManager()
41
34
  }
42
35
 
43
- /** Configures a single static route at [path] serving [children] as its page. */
44
36
  private fun servePage(
45
37
  path: String,
46
38
  vararg children: com.margelo.nitro.audiobrowser.Track,
@@ -54,7 +46,6 @@ class BrowserManagerTest {
54
46
  )
55
47
  }
56
48
 
57
- /** Configures a single static route at [path] serving [sections] as its page. */
58
49
  private fun serveSections(path: String, vararg sections: com.margelo.nitro.audiobrowser.Section) {
59
50
  browserManager.config =
60
51
  BrowserConfig(
@@ -113,8 +104,6 @@ class BrowserManagerTest {
113
104
  val resolved = browserManager.navigate("/library")
114
105
 
115
106
  assertEquals(listOf("A", "B"), resolved.flattenedChildren?.map { it.title })
116
- // The tap target: a child's path is rewritten to point back at this page
117
- // plus its own id and page position (the duplicate-identity tie-breaker).
118
107
  assertEquals(
119
108
  listOf(
120
109
  BrowserPathHelper.build("/library", "a", 0),
@@ -137,7 +126,6 @@ class BrowserManagerTest {
137
126
 
138
127
  val expanded = browserManager.expandQueueFromContextualPath(contextual("/home", "c"))
139
128
 
140
- // "Popular" only — a page aggregating sections must not leak next/previous across them.
141
129
  val (queue, index) = requireNotNull(expanded)
142
130
  assertEquals(listOf("c", "d"), queue.map { it.src })
143
131
  assertEquals(0, index)
@@ -160,9 +148,7 @@ class BrowserManagerTest {
160
148
 
161
149
  @Test
162
150
  fun `expandQueueFromContextualPath pins the tapped copy of a duplicate identity`() = runBlocking {
163
- // The same src twice in one section (normal for music playlists): the
164
- // stamped page index selects the tapped copy, so "next" continues from
165
- // there instead of from the first copy.
151
+ // The stamped index 2 is the second "a".
166
152
  servePage("/playlist", track(src = "a"), track(src = "b"), track(src = "a"), track(src = "c"))
167
153
 
168
154
  val (queue, index) =
@@ -177,8 +163,7 @@ class BrowserManagerTest {
177
163
  @Test
178
164
  fun `expandQueueFromContextualPath scopes a cross-section duplicate to the tapped section`() =
179
165
  runBlocking {
180
- // The same identity in a rail section AND the list section below it:
181
- // the stamped flat index resolves the tap to the list section.
166
+ // Flat index 1 is the "dup" in Stations, not the one in Row.
182
167
  serveSections(
183
168
  "/home",
184
169
  section(
@@ -206,9 +191,7 @@ class BrowserManagerTest {
206
191
  @Test
207
192
  fun `expandQueueFromContextualPath falls back to the first match on a stale index`() =
208
193
  runBlocking {
209
- // The list shifted since the stamp: the child at the index no longer
210
- // carries the identity, so resolution ignores the index and falls back
211
- // to the first identity match instead of aborting.
194
+ // Index 0 holds "x", not "a".
212
195
  servePage("/home", track(src = "x"), track(src = "a"), track(src = "b"))
213
196
 
214
197
  val (queue, index) =
@@ -223,9 +206,6 @@ class BrowserManagerTest {
223
206
  @Test
224
207
  fun `expandQueueFromContextualPath returns null when the id has vanished from the page`() =
225
208
  runBlocking {
226
- // The stored path points at a track the page no longer lists — the page changed under a
227
- // resumed session. Queueing the current list would resume the wrong station, so expansion
228
- // aborts and the caller falls back to the stored single track.
229
209
  servePage("/home", track(src = "a"), track(src = "b"))
230
210
 
231
211
  assertNull(browserManager.expandQueueFromContextualPath(contextual("/home", "gone")))
@@ -266,7 +246,6 @@ class BrowserManagerTest {
266
246
  val (queue, index) =
267
247
  requireNotNull(browserManager.expandQueueFromContextualPath(contextual("/home", "r2")))
268
248
 
269
- // A tile tap queues its section, not the list rows beside it.
270
249
  assertEquals(listOf("r1", "r2"), queue.map { it.src })
271
250
  assertEquals(1, index)
272
251
  }
@@ -280,7 +259,7 @@ class BrowserManagerTest {
280
259
  children =
281
260
  arrayOf(
282
261
  track(src = "a"),
283
- // A browsable row sitting inside the same section — no src, so not queueable.
262
+ // No src: browsable, so not queueable.
284
263
  track(src = null).copy(path = "/sub"),
285
264
  track(src = "b"),
286
265
  ),
@@ -305,7 +284,7 @@ class BrowserManagerTest {
305
284
 
306
285
  val resolved = browserManager.navigate("/home")
307
286
 
308
- // id when non-blank, else src — Track.identity (ADR 0008).
287
+ // id when non-blank, else src (ADR 0008).
309
288
  assertEquals(
310
289
  listOf(
311
290
  BrowserPathHelper.build("/home", "stable-a", 0),
@@ -336,8 +315,7 @@ class BrowserManagerTest {
336
315
  servePage("/home", track(id = "stable-b", src = "https://s/b.mp3", title = "B"))
337
316
  browserManager.navigate("/home")
338
317
 
339
- // A contextual mediaId whose __trackId is the identity (the id), with a parent path that was
340
- // never cached directly — the extract-then-lookup path must find it via the id key.
318
+ // "/elsewhere" was never resolved, so only the id key can find it.
341
319
  val mediaId = contextual("/elsewhere", "stable-b")
342
320
 
343
321
  assertEquals("B", browserManager.getCachedTrack(mediaId)?.title)
@@ -374,10 +352,6 @@ class BrowserManagerTest {
374
352
 
375
353
  @Test
376
354
  fun `expandQueueFromContextualPath aborts when the tapped track is disabled`() = runBlocking {
377
- // A disabled track never plays: with the tapped identity excluded from the
378
- // playable list, expansion aborts, and every caller's fallback refuses the
379
- // disabled track itself — navigateTrack's guard on tap,
380
- // onPlaybackResumption's refusal on resume.
381
355
  servePage("/home", track(src = "a"), track(src = "unavailable", disabled = true))
382
356
 
383
357
  assertNull(browserManager.expandQueueFromContextualPath(contextual("/home", "unavailable")))
@@ -386,9 +360,6 @@ class BrowserManagerTest {
386
360
  @Test
387
361
  fun `resolveMediaItemsForPlayback refuses a disabled track on the legacy INDEX_UNSET path`() =
388
362
  runBlocking {
389
- // Android Auto and Assistant request playback through Media3's legacy
390
- // path, which passes C.INDEX_UNSET ("the default item") — the refusal
391
- // must cover it, or a stale browse row for a now-disabled track plays.
392
363
  servePage("/home", track(src = "unavailable", disabled = true))
393
364
  browserManager.resolve("/home")
394
365
 
@@ -397,9 +368,6 @@ class BrowserManagerTest {
397
368
  try {
398
369
  browserManager.resolveMediaItemsForPlayback(listOf(item), C.INDEX_UNSET, 0)
399
370
  fail("Expected refusal of a disabled track")
400
- } catch (expected: IllegalStateException) {
401
- // Refused by failing the future: Media3 surfaces an error to the
402
- // controller and live playback stays untouched.
403
- }
371
+ } catch (expected: IllegalStateException) {}
404
372
  }
405
373
  }
@@ -14,11 +14,7 @@ import org.junit.Assert.assertTrue
14
14
  import org.junit.Before
15
15
  import org.junit.Test
16
16
 
17
- /**
18
- * Tests browser/BrowserUrlResolution.kt — media/artwork URL resolution owned by BrowserManager (the
19
- * Kotlin analog of iOS RequestPipeline.swift). Static configs only (Nitro Promises are JNI-backed;
20
- * see file-top note in BrowserManagerLayerResolutionTest).
21
- */
17
+ // Static configs only: a Nitro Promise is JNI-backed and cannot be built in a unit test.
22
18
  class BrowserUrlResolutionTest {
23
19
 
24
20
  private lateinit var bm: BrowserManager
@@ -69,8 +65,8 @@ class BrowserUrlResolutionTest {
69
65
  BrowserConfig(
70
66
  media =
71
67
  mediaConfig(
72
- // Records the track and stops there: a Nitro Promise cannot be built off-device.
73
68
  resolveSync = { track ->
69
+ // Records the track and stops: a Nitro Promise cannot be returned off-device.
74
70
  resolvedFor.add(track)
75
71
  throw IllegalStateException("recorded")
76
72
  }
@@ -125,8 +121,6 @@ class BrowserUrlResolutionTest {
125
121
  request = transformableConfig(baseUrl = "https://api.example.com"),
126
122
  artwork = artworkConfig(path = "/artwork/{id}"),
127
123
  )
128
- // The config still runs (no blanket skip); the token stays literal so the resulting request
129
- // 404s with a self-describing URL.
130
124
  val source = bm.resolveArtworkUrl(track(artwork = null, id = null))
131
125
  assertEquals("https://api.example.com/artwork/{id}", source?.uri)
132
126
  }
@@ -181,7 +175,7 @@ class BrowserUrlResolutionTest {
181
175
  artwork = artworkConfig(imageQueryParams = ImageQueryParams(width = "w", height = "h")),
182
176
  )
183
177
  val t = track(artwork = "/art/1.png")
184
- val browseTime = bm.resolveArtworkUrl(t) // no size at browse time
178
+ val browseTime = bm.resolveArtworkUrl(t)
185
179
  bm.artworkResolutions.register(browseTime!!.uri, t, null)
186
180
 
187
181
  val displayTime = bm.displayArtworkSource(browseTime.uri, ImageContext(512.0, 512.0))
@@ -198,10 +192,6 @@ class BrowserUrlResolutionTest {
198
192
  @Test
199
193
  fun `displayArtworkSource entries without a per-route config use the current global config`() =
200
194
  runTest {
201
- // Register under config A (entry stores perRouteConfig = null for the global
202
- // fallback) and replace the global config: display-time must resolve through
203
- // the NEW config, not a pinned old one. Note the config setter clears the
204
- // registry, so re-register after the swap as a browse under config B would.
205
195
  bm.config =
206
196
  BrowserConfig(
207
197
  request = transformableConfig(baseUrl = "https://api.example.com"),
@@ -215,6 +205,7 @@ class BrowserUrlResolutionTest {
215
205
  request = transformableConfig(baseUrl = "https://api.example.com"),
216
206
  artwork = artworkConfig(query = mapOf("sig" to "new")),
217
207
  )
208
+ // Setting the config clears the registry, so register after the swap, as a browse would.
218
209
  bm.artworkResolutions.register(browseTime.uri, t, null)
219
210
 
220
211
  val displayTime = bm.displayArtworkSource(browseTime.uri, null)
@@ -16,12 +16,7 @@ import org.junit.Assert.assertEquals
16
16
  import org.junit.Assert.assertTrue
17
17
  import org.junit.Test
18
18
 
19
- /**
20
- * The dev diagnostic for declarations that can never render (ADR 0011): the recovery for the
21
- * compile-time invalid-combination errors the block model deliberately gave up. Structural
22
- * inertness only — a surface that can't draw a property it understands is intended usage, never a
23
- * finding. Mirrors `ios/Tests/InertStyleDiagnosticTests.swift`.
24
- */
19
+ /** Mirrors `ios/Tests/InertStyleDiagnosticTests.swift`. */
25
20
  class InertStyleDiagnosticTest {
26
21
 
27
22
  private fun findings(
@@ -50,8 +45,6 @@ class InertStyleDiagnosticTest {
50
45
 
51
46
  @Test
52
47
  fun `a section inherits the page's grid display`() {
53
- // `display` resolves by scope override, so the page's grid makes the section's `gridWrap` live
54
- // without the section restating it.
55
48
  val found =
56
49
  findings(
57
50
  listOf(section(style = sectionStyle(gridWrap = false))),
@@ -204,7 +197,6 @@ class InertStyleDiagnosticTest {
204
197
 
205
198
  @Test
206
199
  fun `a page declaration live in one section is not reported`() {
207
- // Card tint reaches both sections; one renders cards. Live is live.
208
200
  val found =
209
201
  findings(
210
202
  listOf(
@@ -233,8 +225,7 @@ class InertStyleDiagnosticTest {
233
225
 
234
226
  @Test
235
227
  fun `a section override shadows the page value`() {
236
- // Every section declares its own tint, so the page's is never resolved — shadowed, not inert;
237
- // the diagnostic reports what can't render, not what isn't reached.
228
+ // The page's tint is never reached, not inert: only what can't render is reported.
238
229
  val found =
239
230
  findings(
240
231
  listOf(
@@ -31,8 +31,6 @@ class JsonArtworkTest {
31
31
 
32
32
  @Test
33
33
  fun `decodes a pair nested in children`() {
34
- // The shape that shipped broken: a container decodes its children eagerly,
35
- // so one unparseable row rejected the whole page rather than losing an image.
36
34
  val resolved =
37
35
  json.decodeFromString<JsonResolvedTrack>(
38
36
  """{"path":"/favorites","title":"Favorites","children":[
@@ -42,8 +42,6 @@ class JsonStyleTest {
42
42
 
43
43
  @Test
44
44
  fun `a stale string style decodes as no declaration - never a parse failure`() {
45
- // The retired string vocabulary must never kill the page (tolerant
46
- // decoding, ADR 0011).
47
45
  val resolved =
48
46
  json.decodeFromString<JsonResolvedTrack>(
49
47
  """{"path":"/home","title":"Home","style":"rail","children":[
@@ -57,8 +55,7 @@ class JsonStyleTest {
57
55
 
58
56
  @Test
59
57
  fun `unknown enum values decode as no declaration`() {
60
- // All-unknown declarations collapse to "no block" — one shape for "no
61
- // declaration" on every platform.
58
+ // A block of only unknown values collapses to no block, the shape iOS gives too.
62
59
  val track =
63
60
  json.decodeFromString<JsonTrack>(
64
61
  """{"title":"X","style":{"display":"carousel","artworkRendering":"embossed","gridWrap":"yes"}}"""
@@ -74,8 +71,7 @@ class JsonStyleTest {
74
71
 
75
72
  @Test
76
73
  fun `a quoted boolean gridWrap is a wrong-typed field - no declaration`() {
77
- // iOS's strict-typed tolerant decode drops a quoted "false"; the lenient
78
- // Kotlin mapper must not read it either, or the same payload renders a
74
+ // iOS's typed decode drops a quoted "false"; reading it here would render a
79
75
  // teaser shelf on one platform and a wrapping grid on the other.
80
76
  val resolved =
81
77
  json.decodeFromString<JsonResolvedTrack>(
@@ -107,8 +103,7 @@ class JsonStyleTest {
107
103
 
108
104
  @Test
109
105
  fun `accessorySymbol 'none' is a value - not emptiness`() {
110
- // The inheritance-escape sentinel must survive the wire — collapsing it
111
- // to "no declaration" would let the section value flow back in.
106
+ // "none" opts out of the section's symbol; dropping it would let that value inherit back.
112
107
  val track =
113
108
  json.decodeFromString<JsonTrack>("""{"title":"X","style":{"accessorySymbol":"none"}}""")
114
109
  assertEquals("none", track.toNitro().style?.accessorySymbol)
@@ -11,9 +11,7 @@ import org.junit.Test
11
11
 
12
12
  class SectionScopeTest {
13
13
 
14
- // Two sections sharing an identity — the duplicate-heavy shape the flat model
15
- // had to disambiguate by precedence; sections + the stamped flat index make
16
- // it exact.
14
+ // "dup" sits at flat indices 0 and 3, "x" at 1.
17
15
  private val sections =
18
16
  listOf(
19
17
  section(title = "First", children = arrayOf(track(src = "dup"), track(src = "x"))),
@@ -32,7 +30,6 @@ class SectionScopeTest {
32
30
 
33
31
  @Test
34
32
  fun `flat index pins the tapped section`() {
35
- // Flat index 3 = second section, offset 1.
36
33
  val scoped = SectionScope.scoped(sections, "dup", tappedIndex = 3)!!
37
34
  assertEquals(listOf("y", "dup", "z"), scoped.section.children.map { it.src })
38
35
  assertEquals(1, scoped.tappedOffset)
@@ -52,8 +49,6 @@ class SectionScopeTest {
52
49
 
53
50
  @Test
54
51
  fun `stale index falls back to the first identity match`() {
55
- // The child at the stamped index no longer carries the tapped identity
56
- // (the list shifted) — resolution ignores the index and pins nothing.
57
52
  val scoped = SectionScope.scoped(sections, "dup", tappedIndex = 1)!!
58
53
  assertEquals(listOf("dup", "x"), scoped.section.children.map { it.src })
59
54
  assertNull(scoped.tappedOffset)
@@ -73,8 +68,6 @@ class SectionScopeTest {
73
68
 
74
69
  @Test
75
70
  fun `locates a track by its id when it has one`() {
76
- // Identity rule (ADR 0008): the id wins over the src, so a __trackId stamped
77
- // from an id-bearing track must resolve — and its src must not.
78
71
  val children =
79
72
  arrayOf(
80
73
  track(id = "stable-a", src = "https://s/a.mp3"),
@@ -83,7 +76,7 @@ class SectionScopeTest {
83
76
  val scoped = SectionScope.scoped(listOf(section(children = children)), "stable-b")!!
84
77
  assertEquals(listOf("stable-a", "stable-b"), scoped.section.children.map { it.id })
85
78
 
86
- // The src is shadowed by the id — it is not the track's identity.
79
+ // An id-bearing track's src is not its identity.
87
80
  assertNull(SectionScope.scoped(listOf(section(children = children)), "https://s/b.mp3"))
88
81
  }
89
82
 
@@ -132,9 +125,6 @@ class SectionScopeTest {
132
125
 
133
126
  @Test
134
127
  fun `an unstyled section reaches the surface with the page's block folded in`() {
135
- // The end-to-end wire for ResolvedTrack.style: without this fold, the
136
- // page tier is a dead field — every existing unit test would stay green
137
- // while a whole tier of ADR 0011 went dark in production.
138
128
  val page =
139
129
  resolvedTrack(
140
130
  style =
@@ -145,8 +135,6 @@ class SectionScopeTest {
145
135
  val folded = page.styleResolvedSections()!!.single()
146
136
  assertEquals(StyleDisplay.GRID, folded.style?.display)
147
137
  assertEquals(false, folded.style?.gridWrap)
148
- // The extras leg of this wire — folded section → per-item grid hint — is
149
- // asserted in MediaExtrasBuilderTest (it needs Robolectric for Bundle).
150
138
  }
151
139
 
152
140
  @Test
@@ -146,17 +146,13 @@ class SimpleRouterTest {
146
146
 
147
147
  @Test
148
148
  fun `computes correct specificity for tail wildcard patterns`() {
149
- // Regression test for issue #27: specificity must account for
150
- // segment types before the ** wildcard.
151
149
  val result = router.findBestMatch("/api/v1/users", mapOf("/api/v1/**" to true))
152
- // constant "api" (1000) + constant "v1" (1000) + tail(1) + 3 segments = 2004
150
+ // constants "api" and "v1" (2 * 1000) + tail wildcard (1) + 3 pattern segments
153
151
  assertEquals(2004, result!!.second.specificity)
154
152
  }
155
153
 
156
154
  @Test
157
155
  fun `prefers constant prefix over parameter prefix in tail wildcards`() {
158
- // Second part of issue #27: with correct specificity, the constant
159
- // prefix should beat the parameter prefix.
160
156
  val routes = mapOf("/api/{version}/**" to true, "/api/v1/**" to true)
161
157
  val result = router.findBestMatch("/api/v1/users", routes)
162
158
  assertEquals("/api/v1/**", result!!.first)
@@ -11,11 +11,6 @@ import org.junit.Assert.assertEquals
11
11
  import org.junit.Assert.assertNull
12
12
  import org.junit.Test
13
13
 
14
- /**
15
- * Resolution semantics (ADR 0011): container properties and `display` resolve by scope override
16
- * (`section ?? page`), inherited item properties resolve `track ?? section ?? page` — and `display`
17
- * never inherits onto an item.
18
- */
19
14
  class StyleResolverTest {
20
15
 
21
16
  @Test
@@ -31,7 +26,6 @@ class StyleResolverTest {
31
26
  gridWrap = false,
32
27
  ),
33
28
  )
34
- // Declared on the section: wins. Undeclared: the page's scope-wide value.
35
29
  assertEquals(StyleDisplay.LIST, resolved.display)
36
30
  assertEquals(ArtworkRendering.STENCIL, resolved.artworkRendering)
37
31
  assertEquals(false, resolved.gridWrap)
@@ -76,9 +70,8 @@ class StyleResolverTest {
76
70
 
77
71
  @Test
78
72
  fun `display never inherits onto an item`() {
79
- // The track's own display is the page promise for the page IT opens; the
80
- // section's describes its children's layout. Neither may surface as the
81
- // item's resolved display.
73
+ // Both scopes declare a display: the track's is for the page it opens, the section's for its
74
+ // children.
82
75
  val resolved =
83
76
  StyleResolver.trackStyle(
84
77
  track = trackStyle(display = StyleDisplay.GRID, artworkRendering = null),
@@ -90,7 +83,6 @@ class StyleResolverTest {
90
83
 
91
84
  @Test
92
85
  fun `imageShape inherits and overrides per item`() {
93
- // Section-wide circular (an artists shelf); one album overrides.
94
86
  val inherited =
95
87
  StyleResolver.trackStyle(
96
88
  track = null,
@@ -110,8 +102,6 @@ class StyleResolverTest {
110
102
  val inherited =
111
103
  StyleResolver.trackStyle(track = null, section = sectionStyle(accessorySymbol = "lock.fill"))
112
104
  assertEquals("lock.fill", inherited.accessorySymbol)
113
- // 'none' is the inheritance escape — it must survive resolution intact
114
- // (the renderer, not the resolver, maps it to "no accessory").
115
105
  val escaped =
116
106
  StyleResolver.trackStyle(
117
107
  track = trackStyle(accessorySymbol = "none"),
@@ -122,7 +112,6 @@ class StyleResolverTest {
122
112
 
123
113
  @Test
124
114
  fun `gridTile resolves by scope override`() {
125
- // A page-wide card treatment; one section opts back to plain tiles.
126
115
  val inherited =
127
116
  StyleResolver.sectionStyle(section = null, page = sectionStyle(gridTile = GridTile.CARD))
128
117
  assertEquals(GridTile.CARD, inherited.gridTile)
@@ -7,11 +7,7 @@ import org.junit.Test
7
7
  import org.junit.runner.RunWith
8
8
  import org.robolectric.RobolectricTestRunner
9
9
 
10
- /**
11
- * The skip-in-place queue match (ADR 0009): exact contextual-path equality pins the tapped copy;
12
- * the identity match remains for index-less paths; an index-stamped path with no exact match
13
- * misses, so the caller re-expands. Robolectric for `android.net.Uri` (contextual-path parsing).
14
- */
10
+ // Robolectric for `android.net.Uri`, which parses contextual paths.
15
11
  @RunWith(RobolectricTestRunner::class)
16
12
  class TappedTrackTest {
17
13
 
@@ -36,8 +32,6 @@ class TappedTrackTest {
36
32
 
37
33
  @Test
38
34
  fun `index-stamped path with no exact match misses instead of identity-skipping`() {
39
- // A tap in another section whose identity also sits in this queue: the
40
- // caller must re-expand (re-scoping to the tapped section), not skip.
41
35
  assertEquals(-1, queue.indexOfTappedTrack(stamped("a", 7), "a"))
42
36
  }
43
37
  }
@@ -5,11 +5,6 @@ import org.junit.Assert.assertEquals
5
5
  import org.junit.Assert.assertNull
6
6
  import org.junit.Test
7
7
 
8
- /**
9
- * THE identity rule (ADR 0008): a track's identity is its `id` when non-blank, else its `src`.
10
- * Everything that compares tracks — favorites, section scoping, skip-in-place, `__trackId` — goes
11
- * through this extension.
12
- */
13
8
  class TrackIdentityTest {
14
9
 
15
10
  @Test