proagents 1.0.0

package/proagents/prompts/06.5-code-review.md

@@ -0,0 +1,512 @@
+# Code Review Prompts
+
+Universal prompts for comprehensive code review phase.
+
+---
+
+## Quick Start
+
+```
+/review
+```
+
+---
+
+## Review Types
+
+### Automated Review
+
+```
+Run automated code review for: [FEATURE/FILES]
+
+Checks to run:
+1. Linting (ESLint/Prettier)
+2. Type checking (TypeScript)
+3. Static analysis
+4. Security scanning
+5. Bundle size analysis
+6. Test coverage check
+```
+
+### AI-Assisted Review
+
+```
+Perform AI code review for: [FEATURE]
+
+Review focus areas:
+1. Code correctness
+2. Logic errors
+3. Security vulnerabilities
+4. Performance issues
+5. Best practice violations
+6. Code style consistency
+7. Documentation completeness
+```
+
+### Peer Review Request
+
+```
+Create peer review request for: [FEATURE]
+
+Include:
+- Summary of changes
+- Files modified
+- Testing done
+- Areas needing attention
+- Related issues/tickets
+```
+
+---
+
+## Comprehensive Code Review
+
+### Full Code Review
+
+```
+Perform comprehensive code review for: [FILES/FEATURE]
+
+CORRECTNESS:
+□ Logic is correct
+□ Edge cases handled
+□ No obvious bugs
+□ Meets requirements
+
+SECURITY:
+□ No SQL injection
+□ No XSS vulnerabilities
+□ Input sanitization
+□ Authentication/authorization correct
+□ No hardcoded secrets
+□ Secure data handling
+
+PERFORMANCE:
+□ No unnecessary re-renders
+□ No memory leaks
+□ Efficient algorithms
+□ Proper caching
+□ No N+1 queries
+
+CODE QUALITY:
+□ DRY (no duplication)
+□ Single responsibility
+□ Clear naming
+□ Proper abstraction level
+□ Maintainable
+
+STYLE:
+□ Follows project conventions
+□ Consistent formatting
+□ Proper imports organization
+□ No commented code
+□ No console.logs
+
+TESTING:
+□ Adequate test coverage
+□ Tests are meaningful
+□ Edge cases tested
+
+DOCUMENTATION:
+□ Code is self-documenting
+□ Complex logic explained
+□ Public APIs documented
+```
+
+---
+
+## Security Review
+
+### Security-Focused Review
+
+```
+Perform security review for: [CODE]
+
+CHECK FOR OWASP TOP 10:
+
+1. Injection:
+□ SQL queries parameterized
+□ Command injection prevented
+□ LDAP injection prevented
+
+2. Broken Authentication:
+□ Strong password requirements
+□ Session management secure
+□ MFA supported (if needed)
+
+3. Sensitive Data Exposure:
+□ Data encrypted in transit
+□ Data encrypted at rest
+□ No sensitive data in logs
+
+4. XML External Entities:
+□ XXE prevented
+□ Parser configured securely
+
+5. Broken Access Control:
+□ Authorization enforced
+□ CORS configured properly
+□ Direct object references secured
+
+6. Security Misconfiguration:
+□ Default credentials removed
+□ Error handling doesn't leak info
+□ Security headers present
+
+7. Cross-Site Scripting (XSS):
+□ Output encoded
+□ CSP configured
+□ User input sanitized
+
+8. Insecure Deserialization:
+□ Deserialization validated
+□ Types checked
+
+9. Known Vulnerabilities:
+□ Dependencies up to date
+□ No known vulnerable packages
+
+10. Insufficient Logging:
+□ Security events logged
+□ Logs don't contain sensitive data
+```
+
+### Secrets Check
+
+```
+Check for hardcoded secrets in: [CODE]
+
+Look for:
+□ API keys
+□ Passwords
+□ Private keys
+□ Access tokens
+□ Connection strings
+□ AWS credentials
+□ Firebase configs
+□ OAuth secrets
+
+Found secrets should:
+- Move to environment variables
+- Use secrets manager
+- Never commit to git
+```
+
+---
+
+## Performance Review
+
+### Performance-Focused Review
+
+```
+Review performance for: [CODE]
+
+RENDERING PERFORMANCE:
+□ No unnecessary re-renders
+□ Proper memoization (useMemo, useCallback)
+□ Virtualization for long lists
+□ Lazy loading implemented
+□ Image optimization
+
+BUNDLE SIZE:
+□ No large dependencies added
+□ Tree shaking works
+□ Code splitting used
+□ Dynamic imports for routes
+
+RUNTIME PERFORMANCE:
+□ Efficient algorithms (O(n) complexity)
+□ No blocking operations
+□ Proper async handling
+□ Debounce/throttle where needed
+
+MEMORY:
+□ No memory leaks
+□ Event listeners cleaned up
+□ Subscriptions unsubscribed
+□ Refs handled properly
+
+DATABASE/API:
+□ No N+1 queries
+□ Proper indexing
+□ Caching implemented
+□ Pagination used
+```
+
+### Bundle Analysis
+
+```
+Analyze bundle impact of: [FEATURE]
+
+Before: [size]
+After: [size]
+Delta: [+/-]
+
+Largest additions:
+1. [dependency/file] - [size]
+2. [dependency/file] - [size]
+
+Recommendations:
+- [How to reduce if needed]
+```
+
+---
+
+## Code Quality Review
+
+### Quality-Focused Review
+
+```
+Review code quality for: [CODE]
+
+SOLID PRINCIPLES:
+□ Single Responsibility
+□ Open/Closed
+□ Liskov Substitution
+□ Interface Segregation
+□ Dependency Inversion
+
+DRY:
+□ No code duplication
+□ Shared utilities used
+□ Common patterns abstracted
+
+KISS:
+□ Simple solutions
+□ No over-engineering
+□ Clear intent
+
+CLEAN CODE:
+□ Meaningful names
+□ Small functions
+□ Few parameters
+□ No magic numbers
+□ Proper error handling
+```
+
+### Naming Review
+
+```
+Review naming in: [CODE]
+
+Check:
+□ Variables describe content
+□ Functions describe action
+□ Classes describe entity
+□ Constants are UPPER_CASE
+□ No abbreviations (unless universal)
+□ Consistent terminology
+□ No misleading names
+```
+
+---
+
+## Review Checklist by File Type
+
+### Component Review
+
+```
+Review React component: [COMPONENT]
+
+STRUCTURE:
+□ Props interface defined
+□ Proper component type (FC, etc.)
+□ Hooks at top level
+□ Early returns for edge cases
+
+RENDERING:
+□ Key props on lists
+□ Fragments used appropriately
+□ No inline function definitions in JSX
+□ Conditional rendering clear
+
+STATE:
+□ Minimal state
+□ Derived state calculated
+□ State updates immutable
+□ Effects have proper deps
+
+ACCESSIBILITY:
+□ Semantic HTML used
+□ ARIA attributes where needed
+□ Keyboard accessible
+□ Focus managed
+```
+
+### Hook Review
+
+```
+Review custom hook: [HOOK]
+
+RULES OF HOOKS:
+□ Only called at top level
+□ Only called in React functions
+□ Dependencies array correct
+
+DESIGN:
+□ Single responsibility
+□ Returns useful values
+□ Handles loading/error states
+□ Cleanup in effects
+
+PERFORMANCE:
+□ Memoized where needed
+□ No unnecessary effects
+□ Proper dependency tracking
+```
+
+### API Service Review
+
+```
+Review API service: [SERVICE]
+
+REQUEST HANDLING:
+□ Proper HTTP methods
+□ Correct headers
+□ Request body formatted
+□ Query params handled
+
+RESPONSE HANDLING:
+□ Response transformed
+□ Errors caught
+□ Types applied
+□ Null/undefined handled
+
+ERROR HANDLING:
+□ Network errors caught
+□ HTTP errors handled
+□ Timeout configured
+□ Retry logic (if needed)
+```
+
+---
+
+## Review Feedback
+
+### Provide Review Feedback
+
+```
+Provide review feedback for: [CODE]
+
+Format feedback as:
+
+MUST FIX (Blocking):
+1. [Issue] - [Location] - [Why it's critical] - [Suggested fix]
+
+SHOULD FIX (Non-blocking but important):
+1. [Issue] - [Location] - [Why] - [Suggested fix]
+
+CONSIDER (Suggestions):
+1. [Suggestion] - [Why it might help]
+
+POSITIVE:
+1. [What's done well]
+```
+
+### Review Comment Templates
+
+```
+Review comment templates:
+
+CRITICAL:
+"🔴 CRITICAL: [description]
+This could cause [issue].
+Suggested fix: [fix]"
+
+IMPORTANT:
+"🟡 IMPORTANT: [description]
+Recommended change: [change]"
+
+SUGGESTION:
+"💡 SUGGESTION: [description]
+This might improve [aspect]."
+
+QUESTION:
+"❓ QUESTION: [question]
+I'm curious about the reason for [decision]."
+
+PRAISE:
+"✅ NICE: [description]
+Good approach for [reason]."
+```
+
+---
+
+## Self-Review
+
+### Pre-PR Self-Review
+
+```
+Self-review checklist before PR:
+
+CODE:
+□ Removed console.logs
+□ Removed commented code
+□ Removed TODO comments (or created issues)
+□ No hardcoded values
+□ No unused imports
+□ No unused variables
+
+FUNCTIONALITY:
+□ Meets all requirements
+□ Edge cases handled
+□ Error states handled
+□ Loading states handled
+
+TESTS:
+□ Tests pass locally
+□ New tests added
+□ Coverage adequate
+
+STYLE:
+□ Linter passes
+□ Formatter applied
+□ Follows conventions
+
+DOCUMENTATION:
+□ Code is clear
+□ Complex logic commented
+□ README updated (if needed)
+□ API docs updated (if needed)
+```
+
+---
+
+## Review Summary
+
+### Generate Review Summary
+
+```
+Generate review summary for: [PR/FEATURE]
+
+SUMMARY:
+- Total files: [X]
+- Lines added: [X]
+- Lines removed: [X]
+
+REVIEW FINDINGS:
+- Critical issues: [X]
+- Important issues: [X]
+- Suggestions: [X]
+
+REVIEW DECISION:
+□ Approve
+□ Request changes
+□ Comment only
+
+KEY FEEDBACK:
+1. [Most important feedback]
+2. [Second most important]
+3. [Third]
+```
+
+---
+
+## Slash Commands Reference
+
+| Command | Description |
+|---------|-------------|
+| `/review` | Start code review |
+| `/review-security` | Security-focused review |
+| `/review-performance` | Performance-focused review |
+| `/review-quality` | Code quality review |
+| `/review-checklist` | Show review checklist |
+| `/self-review` | Pre-PR self-review |