pi-lens 3.1.2 → 3.2.0

package/clients/formatters.js

@@ -81,7 +81,7 @@ export const biomeFormatter = {
         const found = await findUp(configs, cwd);
         if (found.length > 0)
             return true;
-        // Also check if biome is in package.json devDependencies
+        // Check if biome is in package.json devDependencies
         const pkgPath = path.join(cwd, "package.json");
         if (await fileExists(pkgPath)) {
             const pkg = (await readJson(pkgPath));
@@ -177,18 +177,9 @@ export const ruffFormatter = {
                     return true;
             }
         }
-        // Check if ruff binary available and no other Python formatter detected
-        const hasRuff = (await which("ruff")) !== null;
-        if (hasRuff) {
-            // Prefer ruff if no black config found
-            const blackFound = await findUp(["pyproject.toml"], cwd);
-            for (const p of blackFound) {
-                const content = await fs.readFile(p, "utf-8");
-                if (content.includes("[tool.black]"))
-                    return false; // Prefer black if configured
-            }
-            return true;
-        }
+        // Only enable if the project explicitly uses ruff (config or deps).
+        // Do NOT fall back to "ruff binary is installed" — that would format
+        // projects that never asked for ruff.
         return false;
     },
 };
@@ -308,6 +299,53 @@ export const ktlintFormatter = {
         return (await which("ktlint")) !== null;
     },
 };
+export const rubocopFormatter = {
+    name: "rubocop",
+    command: ["rubocop", "-a", "--no-color", "$FILE"],
+    extensions: [".rb", ".rake", ".gemspec", ".ru"],
+    async detect(cwd) {
+        // Only run if project has explicit RuboCop config
+        const configs = [".rubocop.yml", ".rubocop.yaml"];
+        const found = await findUp(configs, cwd);
+        if (found.length > 0)
+            return (await which("rubocop")) !== null;
+        // Or rubocop in Gemfile
+        const gemfile = path.join(cwd, "Gemfile");
+        if (await fileExists(gemfile)) {
+            const content = await fs.readFile(gemfile, "utf-8");
+            if (content.includes("rubocop"))
+                return (await which("rubocop")) !== null;
+        }
+        return false;
+    },
+};
+export const standardrbFormatter = {
+    name: "standardrb",
+    command: ["standardrb", "--fix", "$FILE"],
+    extensions: [".rb", ".rake"],
+    async detect(cwd) {
+        // standardrb is only used if explicitly in Gemfile (no config file — it is the config)
+        const gemfile = path.join(cwd, "Gemfile");
+        if (await fileExists(gemfile)) {
+            const content = await fs.readFile(gemfile, "utf-8");
+            if (content.includes("standard"))
+                return (await which("standardrb")) !== null;
+        }
+        return false;
+    },
+};
+export const gleamFormatter = {
+    name: "gleam",
+    command: ["gleam", "format", "$FILE"],
+    extensions: [".gleam"],
+    async detect(cwd) {
+        // Present if gleam.toml exists (any Gleam project)
+        const found = await findUp(["gleam.toml"], cwd);
+        if (found.length > 0)
+            return (await which("gleam")) !== null;
+        return false;
+    },
+};
 export const terraformFormatter = {
     name: "terraform",
     command: ["terraform", "fmt", "$FILE"],
@@ -333,6 +371,9 @@ const ALL_FORMATTERS = [
     clangFormatFormatter,
     ktlintFormatter,
     terraformFormatter,
+    rubocopFormatter,
+    standardrbFormatter,
+    gleamFormatter,
 ];
 // Cache for detection results - stores array of enabled formatter names per cwd+ext
 const detectionCache = new Map();
@@ -402,9 +443,21 @@ export function clearFormatterCache() {
 export async function formatFile(filePath, formatter) {
     try {
         const absolutePath = path.resolve(filePath);
+        const cwd = path.dirname(absolutePath);
         const contentBefore = await fs.readFile(absolutePath, "utf-8");
         // Replace $FILE placeholder
-        const cmd = formatter.command.map((c) => c.replace("$FILE", absolutePath));
+        let cmd = formatter.command.map((c) => c.replace("$FILE", absolutePath));
+        // OPTIMIZATION: Use local biome binary instead of npx if available
+        if (formatter.name === "biome" && cmd[0] === "npx") {
+            const localBiome = path.join(cwd, "node_modules", ".bin", "biome");
+            const localBiomeWin = path.join(cwd, "node_modules", ".bin", "biome.cmd");
+            if (await fileExists(localBiome)) {
+                cmd = [localBiome, ...cmd.slice(2)]; // Replace "npx" "@biomejs/biome" with local path
+            }
+            else if (await fileExists(localBiomeWin)) {
+                cmd = [localBiomeWin, ...cmd.slice(2)];
+            }
+        }
         // Run formatter
         const result = safeSpawn(cmd[0], cmd.slice(1), { timeout: 15000 });
         if (result.error) {

package/clients/formatters.ts

@@ -111,7 +111,7 @@ export const biomeFormatter: FormatterInfo = {
 		const found = await findUp(configs, cwd);
 		if (found.length > 0) return true;
 
-		// Also check if biome is in package.json devDependencies
+		// Check if biome is in package.json devDependencies
 		const pkgPath = path.join(cwd, "package.json");
 		if (await fileExists(pkgPath)) {
 			const pkg = (await readJson(pkgPath)) as {
@@ -215,18 +215,9 @@ export const ruffFormatter: FormatterInfo = {
 			}
 		}
 
-		// Check if ruff binary available and no other Python formatter detected
-		const hasRuff = (await which("ruff")) !== null;
-		if (hasRuff) {
-			// Prefer ruff if no black config found
-			const blackFound = await findUp(["pyproject.toml"], cwd);
-			for (const p of blackFound) {
-				const content = await fs.readFile(p, "utf-8");
-				if (content.includes("[tool.black]")) return false; // Prefer black if configured
-			}
-			return true;
-		}
-
+		// Only enable if the project explicitly uses ruff (config or deps).
+		// Do NOT fall back to "ruff binary is installed" — that would format
+		// projects that never asked for ruff.
 		return false;
 	},
 };
@@ -356,6 +347,53 @@ export const ktlintFormatter: FormatterInfo = {
 	},
 };
 
+export const rubocopFormatter: FormatterInfo = {
+	name: "rubocop",
+	command: ["rubocop", "-a", "--no-color", "$FILE"],
+	extensions: [".rb", ".rake", ".gemspec", ".ru"],
+	async detect(cwd: string) {
+		// Only run if project has explicit RuboCop config
+		const configs = [".rubocop.yml", ".rubocop.yaml"];
+		const found = await findUp(configs, cwd);
+		if (found.length > 0) return (await which("rubocop")) !== null;
+		// Or rubocop in Gemfile
+		const gemfile = path.join(cwd, "Gemfile");
+		if (await fileExists(gemfile)) {
+			const content = await fs.readFile(gemfile, "utf-8");
+			if (content.includes("rubocop")) return (await which("rubocop")) !== null;
+		}
+		return false;
+	},
+};
+
+export const standardrbFormatter: FormatterInfo = {
+	name: "standardrb",
+	command: ["standardrb", "--fix", "$FILE"],
+	extensions: [".rb", ".rake"],
+	async detect(cwd: string) {
+		// standardrb is only used if explicitly in Gemfile (no config file — it is the config)
+		const gemfile = path.join(cwd, "Gemfile");
+		if (await fileExists(gemfile)) {
+			const content = await fs.readFile(gemfile, "utf-8");
+			if (content.includes("standard"))
+				return (await which("standardrb")) !== null;
+		}
+		return false;
+	},
+};
+
+export const gleamFormatter: FormatterInfo = {
+	name: "gleam",
+	command: ["gleam", "format", "$FILE"],
+	extensions: [".gleam"],
+	async detect(cwd: string) {
+		// Present if gleam.toml exists (any Gleam project)
+		const found = await findUp(["gleam.toml"], cwd);
+		if (found.length > 0) return (await which("gleam")) !== null;
+		return false;
+	},
+};
+
 export const terraformFormatter: FormatterInfo = {
 	name: "terraform",
 	command: ["terraform", "fmt", "$FILE"],
@@ -383,6 +421,9 @@ const ALL_FORMATTERS: FormatterInfo[] = [
 	clangFormatFormatter,
 	ktlintFormatter,
 	terraformFormatter,
+	rubocopFormatter,
+	standardrbFormatter,
+	gleamFormatter,
 ];
 
 // Cache for detection results - stores array of enabled formatter names per cwd+ext
@@ -470,13 +511,25 @@ export async function formatFile(
 ): Promise<FormatterResult> {
 	try {
 		const absolutePath = path.resolve(filePath);
+		const cwd = path.dirname(absolutePath);
 		const contentBefore = await fs.readFile(absolutePath, "utf-8");
 
 		// Replace $FILE placeholder
-		const cmd = formatter.command.map((c) => c.replace("$FILE", absolutePath));
+		let cmd = formatter.command.map((c) => c.replace("$FILE", absolutePath));
+
+		// OPTIMIZATION: Use local biome binary instead of npx if available
+		if (formatter.name === "biome" && cmd[0] === "npx") {
+			const localBiome = path.join(cwd, "node_modules", ".bin", "biome");
+			const localBiomeWin = path.join(cwd, "node_modules", ".bin", "biome.cmd");
+			if (await fileExists(localBiome)) {
+				cmd = [localBiome, ...cmd.slice(2)]; // Replace "npx" "@biomejs/biome" with local path
+			} else if (await fileExists(localBiomeWin)) {
+				cmd = [localBiomeWin, ...cmd.slice(2)];
+			}
+		}
 
 		// Run formatter
-		const result = safeSpawn(cmd[0], cmd.slice(1), { timeout: 15000 });
+		const result = safeSpawn(cmd[0], cmd.slice(1), { timeout: 15000, cwd });
 
 		if (result.error) {
 			return {

package/clients/installer/index.js

@@ -1,14 +1,18 @@
 /**
  * Auto-Installation System for pi-lens
  *
- * Minimal auto-install: Only TypeScript and Python ecosystems.
+ * Minimal auto-install: Core tools that run frequently.
  * Other tools require manual installation with clear instructions.
  *
- * Auto-install (4 tools):
+ * Auto-install (8 tools):
  * - typescript-language-server (TypeScript LSP)
  * - pyright (Python LSP)
  * - ruff (Python linting)
  * - @biomejs/biome (JS/TS/JSON linting/formatting)
+ * - madge (circular dependency detection)
+ * - jscpd (duplicate code detection)
+ * - @ast-grep/cli (structural code search)
+ * - knip (dead code detection)
  *
  * Manual install required (25+ tools):
  * - yaml-language-server: npm install -g yaml-language-server
@@ -18,7 +22,6 @@
  * - vscode-eslint-language-server: npm install -g vscode-langservers-extracted
  * - vscode-css-languageserver: npm install -g vscode-langservers-extracted
  * - @prisma/language-server: npm install -g @prisma/language-server
- * - @ast-grep/cli: npm install -g @ast-grep/cli
  * - dockerfile-language-server: npm install -g dockerfile-language-server-nodejs
  * - @vue/language-server: npm install -g @vue/language-server
  * - And all language-specific servers (gopls, rust-analyzer, etc.)
@@ -72,6 +75,65 @@ const TOOLS = [
         packageName: "@biomejs/biome",
         binaryName: "biome",
     },
+    // Analysis tools (run at session start / turn end)
+    {
+        id: "madge",
+        name: "Madge",
+        checkCommand: "madge",
+        checkArgs: ["--version"],
+        installStrategy: "npm",
+        packageName: "madge",
+        binaryName: "madge",
+    },
+    {
+        id: "jscpd",
+        name: "jscpd",
+        checkCommand: "jscpd",
+        checkArgs: ["--version"],
+        installStrategy: "npm",
+        packageName: "jscpd",
+        binaryName: "jscpd",
+    },
+    // Structural search and dead code detection
+    {
+        id: "ast-grep",
+        name: "ast-grep CLI",
+        checkCommand: "sg",
+        checkArgs: ["--version"],
+        installStrategy: "npm",
+        packageName: "@ast-grep/cli",
+        binaryName: "sg",
+    },
+    {
+        id: "knip",
+        name: "Knip",
+        checkCommand: "knip",
+        checkArgs: ["--version"],
+        installStrategy: "npm",
+        packageName: "knip",
+        binaryName: "knip",
+    },
+    // GitHub release LSP servers
+    {
+        id: "clangd",
+        name: "clangd",
+        checkCommand: "clangd",
+        checkArgs: ["--version"],
+        installStrategy: "github",
+        binaryName: process.platform === "win32" ? "clangd.exe" : "clangd",
+        githubRepo: "clangd/clangd",
+    },
+    {
+        id: "lua-language-server",
+        name: "Lua Language Server",
+        checkCommand: "lua-language-server",
+        checkArgs: ["--version"],
+        installStrategy: "github",
+        binaryName: process.platform === "win32"
+            ? "bin/lua-language-server.exe"
+            : "bin/lua-language-server",
+        githubRepo: "LuaLS/lua-language-server",
+    },
 ];
 // --- Check Functions ---
 /**
@@ -142,9 +204,7 @@ async function verifyToolBinary(binPath) {
     return new Promise((resolve) => {
         // Add .cmd extension on Windows for the actual binary
         const isWindows = process.platform === "win32";
-        const execPath = isWindows && !binPath.endsWith(".cmd")
-            ? `${binPath}.cmd`
-            : binPath;
+        const execPath = isWindows && !binPath.endsWith(".cmd") ? `${binPath}.cmd` : binPath;
         const proc = spawn(execPath, ["--version"], {
             timeout: 10000, // 10 second timeout for verification
             stdio: ["ignore", "pipe", "pipe"],
@@ -190,8 +250,12 @@ async function installNpmTool(packageName, binaryName) {
         // Install via npm or bun (use .cmd on Windows)
         const isWindows = process.platform === "win32";
         const pm = process.env.BUN_INSTALL
-            ? isWindows ? "bun.exe" : "bun"
-            : isWindows ? "npm.cmd" : "npm";
+            ? isWindows
+                ? "bun.exe"
+                : "bun"
+            : isWindows
+                ? "npm.cmd"
+                : "npm";
         const proc = spawn(pm, ["install", packageName], {
             cwd: TOOLS_DIR,
             stdio: ["ignore", "pipe", "pipe"],
@@ -208,7 +272,9 @@ async function installNpmTool(packageName, binaryName) {
                         try {
                             await fs.chmod(binPath, 0o755);
                         }
-                        catch { /* ignore */ }
+                        catch {
+                            /* ignore */
+                        }
                     }
                     // NEW: Verify the binary actually works before returning
                     console.error(`[auto-install] Verifying ${binaryName}...`);
@@ -225,7 +291,9 @@ async function installNpmTool(packageName, binaryName) {
                                 await fs.rm(`${binPath}.ps1`, { force: true });
                             }
                         }
-                        catch { /* ignore cleanup errors */ }
+                        catch {
+                            /* ignore cleanup errors */
+                        }
                         resolve(undefined);
                         return;
                     }