pi-lens 3.1.2 → 3.2.0

package/clients/dispatch/runners/index.js

@@ -3,9 +3,11 @@
  */
 import { registerRunner } from "../dispatcher.js";
 import architectRunner from "./architect.js";
+import astGrepNapiRunner from "./ast-grep-napi.js";
 import biomeRunner from "./biome.js";
 import configValidationRunner from "./config-validation.js";
 import goVetRunner from "./go-vet.js";
+import lspRunner from "./lsp.js";
 import oxlintRunner from "./oxlint.js";
 import pyrightRunner from "./pyright.js";
 import pythonSlopRunner from "./python-slop.js";
@@ -21,11 +23,13 @@ import tsLspRunner from "./ts-lsp.js";
 import tsSlopRunner from "./ts-slop.js";
 import typeSafetyRunner from "./type-safety.js";
 // Register all runners (ordered by priority)
-registerRunner(tsLspRunner); // TypeScript type-checking (priority 5)
-registerRunner(pyrightRunner); // Python type-checking (priority 5)
+// Unified LSP runner for all languages (TypeScript, Python, Go, Rust, etc.) - priority 4
+registerRunner(lspRunner); // Unified LSP type-checking for all languages (priority 4)
+registerRunner(tsLspRunner); // TypeScript type-checking (priority 5) - fallback when --lens-lsp disabled
+registerRunner(pyrightRunner); // Python type-checking (priority 5) - fallback when --lens-lsp disabled
 registerRunner(configValidationRunner); // Config/env validation (priority 8)
-// DISABLED: ast-grep-napi temporarily disabled for debugging
-// registerRunner(astGrepNapiRunner); // TS/JS structural analysis via NAPI (priority 15)
+// DISABLED in post-write dispatch - ast-grep-napi can crash. Enabled via /lens-booboo plan only.
+registerRunner(astGrepNapiRunner); // TS/JS structural analysis via NAPI (priority 15, post-write disabled)
 registerRunner(biomeRunner); // Biome formatting/linting (priority 10)
 registerRunner(oxlintRunner); // Oxlint fast JS/TS linter (priority 12)
 registerRunner(treeSitterRunner); // Tree-sitter structural analysis (priority 14)

package/clients/dispatch/runners/index.ts

@@ -4,9 +4,11 @@
 
 import { registerRunner } from "../dispatcher.js";
 import architectRunner from "./architect.js";
+import astGrepNapiRunner from "./ast-grep-napi.js";
 import biomeRunner from "./biome.js";
 import configValidationRunner from "./config-validation.js";
 import goVetRunner from "./go-vet.js";
+import lspRunner from "./lsp.js";
 import oxlintRunner from "./oxlint.js";
 import pyrightRunner from "./pyright.js";
 import pythonSlopRunner from "./python-slop.js";
@@ -23,11 +25,13 @@ import tsSlopRunner from "./ts-slop.js";
 import typeSafetyRunner from "./type-safety.js";
 
 // Register all runners (ordered by priority)
-registerRunner(tsLspRunner); // TypeScript type-checking (priority 5)
-registerRunner(pyrightRunner); // Python type-checking (priority 5)
+// Unified LSP runner for all languages (TypeScript, Python, Go, Rust, etc.) - priority 4
+registerRunner(lspRunner); // Unified LSP type-checking for all languages (priority 4)
+registerRunner(tsLspRunner); // TypeScript type-checking (priority 5) - fallback when --lens-lsp disabled
+registerRunner(pyrightRunner); // Python type-checking (priority 5) - fallback when --lens-lsp disabled
 registerRunner(configValidationRunner); // Config/env validation (priority 8)
-// DISABLED: ast-grep-napi temporarily disabled for debugging
-// registerRunner(astGrepNapiRunner); // TS/JS structural analysis via NAPI (priority 15)
+// DISABLED in post-write dispatch - ast-grep-napi can crash. Enabled via /lens-booboo plan only.
+registerRunner(astGrepNapiRunner); // TS/JS structural analysis via NAPI (priority 15, post-write disabled)
 registerRunner(biomeRunner); // Biome formatting/linting (priority 10)
 registerRunner(oxlintRunner); // Oxlint fast JS/TS linter (priority 12)
 registerRunner(treeSitterRunner); // Tree-sitter structural analysis (priority 14)

package/clients/dispatch/runners/lsp.js

@@ -0,0 +1,65 @@
+/**
+ * Unified LSP Runner for pi-lens
+ *
+ * Handles type checking for ALL LSP-supported languages:
+ * - TypeScript/JavaScript (typescript-language-server)
+ * - Python (pyright/pylsp)
+ * - Go (gopls)
+ * - Rust (rust-analyzer)
+ * - Ruby, PHP, C#, Java, Kotlin, Swift, Dart, etc.
+ *
+ * Replaces language-specific runners (ts-lsp, pyright) with a single
+ * unified runner that delegates to the LSP service.
+ */
+import { getLSPService } from "../../lsp/index.js";
+import { readFileContent } from "./utils.js";
+const lspRunner = {
+    id: "lsp",
+    appliesTo: ["jsts", "python", "go", "rust"], // Core LSP languages
+    priority: 4, // Run before everything (even ts-lsp was priority 5)
+    enabledByDefault: true,
+    async run(ctx) {
+        // Only run if --lens-lsp flag is enabled
+        if (!ctx.pi.getFlag("lens-lsp")) {
+            return { status: "skipped", diagnostics: [], semantic: "none" };
+        }
+        const lspService = getLSPService();
+        // Check if we have LSP available for this file
+        const hasLSP = await lspService.hasLSP(ctx.filePath);
+        if (!hasLSP) {
+            return { status: "skipped", diagnostics: [], semantic: "none" };
+        }
+        // Read file content
+        const content = readFileContent(ctx.filePath);
+        if (!content) {
+            return { status: "skipped", diagnostics: [], semantic: "none" };
+        }
+        // Open file in LSP and get diagnostics
+        await lspService.openFile(ctx.filePath, content);
+        // getDiagnostics() internally calls waitForDiagnostics() with bus
+        // subscription + 150ms debounce + 3s timeout
+        const lspDiags = await lspService.getDiagnostics(ctx.filePath);
+        // Convert LSP diagnostics to our format
+        // Defensive: filter out malformed diagnostics that may lack range
+        const diagnostics = lspDiags
+            .filter((d) => d.range?.start?.line !== undefined)
+            .map((d) => ({
+            id: `lsp:${d.code ?? "unknown"}:${d.range.start.line}`,
+            message: d.message,
+            filePath: ctx.filePath,
+            line: d.range.start.line + 1,
+            column: d.range.start.character + 1,
+            severity: d.severity === 1 ? "error" : d.severity === 2 ? "warning" : "info",
+            semantic: d.severity === 1 ? "blocking" : "warning",
+            tool: "lsp",
+            code: String(d.code ?? ""),
+        }));
+        const hasErrors = diagnostics.some((d) => d.semantic === "blocking");
+        return {
+            status: hasErrors ? "failed" : "succeeded",
+            diagnostics,
+            semantic: hasErrors ? "blocking" : "warning",
+        };
+    },
+};
+export default lspRunner;

package/clients/dispatch/runners/lsp.ts

@@ -0,0 +1,125 @@
+/**
+ * Unified LSP Runner for pi-lens
+ *
+ * Handles type checking for ALL LSP-supported languages:
+ * - TypeScript/JavaScript (typescript-language-server)
+ * - Python (pyright/pylsp)
+ * - Go (gopls)
+ * - Rust (rust-analyzer)
+ * - Ruby, PHP, C#, Java, Kotlin, Swift, Dart, etc.
+ *
+ * Replaces language-specific runners (ts-lsp, pyright) with a single
+ * unified runner that delegates to the LSP service.
+ */
+
+import { getLSPService } from "../../lsp/index.js";
+import type {
+	Diagnostic,
+	DispatchContext,
+	RunnerDefinition,
+	RunnerResult,
+} from "../types.js";
+import { readFileContent } from "./utils.js";
+
+const lspRunner: RunnerDefinition = {
+	id: "lsp",
+	appliesTo: ["jsts", "python", "go", "rust"], // Core LSP languages
+	priority: 4, // Run before everything (even ts-lsp was priority 5)
+	enabledByDefault: true,
+
+	async run(ctx: DispatchContext): Promise<RunnerResult> {
+		// Only run if --lens-lsp flag is enabled
+		if (!ctx.pi.getFlag("lens-lsp")) {
+			return { status: "skipped", diagnostics: [], semantic: "none" };
+		}
+
+		const lspService = getLSPService();
+
+		// Check if we have LSP available for this file
+		const hasLSP = await lspService.hasLSP(ctx.filePath);
+		if (!hasLSP) {
+			return { status: "skipped", diagnostics: [], semantic: "none" };
+		}
+
+		// Read file content
+		const content = readFileContent(ctx.filePath);
+		if (!content) {
+			return { status: "skipped", diagnostics: [], semantic: "none" };
+		}
+
+		// Try to open file in LSP and get diagnostics
+		// If the server fails to spawn or crashes, this will be caught
+		let lspDiags: import("../../lsp/client.js").LSPDiagnostic[] = [];
+		let serverFailed = false;
+		let failureReason = "";
+
+		try {
+			await lspService.openFile(ctx.filePath, content);
+			// getDiagnostics() internally calls waitForDiagnostics() with bus
+			// subscription + 150ms debounce + 3s timeout
+			lspDiags = await lspService.getDiagnostics(ctx.filePath);
+		} catch (err) {
+			serverFailed = true;
+			failureReason = err instanceof Error ? err.message : String(err);
+			// Check if this is a server spawn/connection error
+			if (
+				failureReason.includes("spawn") ||
+				failureReason.includes("exited") ||
+				failureReason.includes("connection") ||
+				failureReason.includes("JSON RPC")
+			) {
+				// Mark this server as broken so we don't keep trying
+				console.error(
+					`[lsp-runner] LSP server failed for ${ctx.filePath}: ${failureReason}`,
+				);
+			}
+		}
+
+		// If server failed to provide diagnostics, report as failed status
+		if (serverFailed) {
+			return {
+				status: "failed",
+				diagnostics: [
+					{
+						id: `lsp:server-error:0`,
+						message: `LSP server failed: ${failureReason}`,
+						filePath: ctx.filePath,
+						line: 1,
+						column: 1,
+						severity: "error",
+						semantic: "warning", // Don't block - fallback to other runners
+						tool: "lsp",
+					},
+				],
+				semantic: "warning",
+			};
+		}
+
+		// Convert LSP diagnostics to our format
+		// Defensive: filter out malformed diagnostics that may lack range
+		const diagnostics: Diagnostic[] = lspDiags
+			.filter((d) => d.range?.start?.line !== undefined)
+			.map((d) => ({
+				id: `lsp:${d.code ?? "unknown"}:${d.range.start.line}`,
+				message: d.message,
+				filePath: ctx.filePath,
+				line: d.range.start.line + 1,
+				column: d.range.start.character + 1,
+				severity:
+					d.severity === 1 ? "error" : d.severity === 2 ? "warning" : "info",
+				semantic: d.severity === 1 ? "blocking" : "warning",
+				tool: "lsp",
+				code: String(d.code ?? ""),
+			}));
+
+		const hasErrors = diagnostics.some((d) => d.semantic === "blocking");
+
+		return {
+			status: hasErrors ? "failed" : "succeeded",
+			diagnostics,
+			semantic: hasErrors ? "blocking" : "warning",
+		};
+	},
+};
+
+export default lspRunner;

package/clients/dispatch/runners/oxlint.js

@@ -13,8 +13,8 @@ const oxlintRunner = {
     id: "oxlint",
     appliesTo: ["jsts"],
     priority: 12,
-    enabledByDefault: true,
-    skipTestFiles: false,
+    enabledByDefault: false, // Opt-in: may conflict with ESLint in existing projects
+    skipTestFiles: true,
     async run(ctx) {
         const cwd = ctx.cwd || process.cwd();
         // Check if oxlint is available

package/clients/dispatch/runners/oxlint.ts

@@ -22,8 +22,8 @@ const oxlintRunner: RunnerDefinition = {
 	id: "oxlint",
 	appliesTo: ["jsts"],
 	priority: 12,
-	enabledByDefault: true,
-	skipTestFiles: false,
+	enabledByDefault: false, // Opt-in: may conflict with ESLint in existing projects
+	skipTestFiles: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
 		const cwd = ctx.cwd || process.cwd();

package/clients/dispatch/runners/pyright.js

@@ -17,15 +17,31 @@ const pyrightRunner = {
     enabledByDefault: true,
     async run(ctx) {
         const cwd = ctx.cwd || process.cwd();
-        // Auto-install pyright if not available (it's one of the 4 auto-install tools)
-        if (!pyright.isAvailable(cwd)) {
-            const installed = await ensureTool("pyright");
-            if (!installed) {
-                return { status: "skipped", diagnostics: [], semantic: "none" };
-            }
+        // Get pyright command - try multiple strategies
+        let cmd = null;
+        // Strategy 1: Check cached availability (fast path)
+        if (pyright.isAvailable(cwd)) {
+            cmd = pyright.getCommand();
+        }
+        // Strategy 2: Try to find pyright via ensureTool (installs if needed)
+        if (!cmd) {
+            const installedPath = await ensureTool("pyright");
+            if (installedPath)
+                cmd = installedPath;
+        }
+        // Strategy 3: Direct PATH check (handles module cache staleness)
+        if (!cmd) {
+            const { findCommandAsync } = await import("../../safe-spawn.js");
+            const foundCmd = await findCommandAsync("pyright");
+            if (foundCmd)
+                cmd = foundCmd;
+        }
+        // If still no pyright, skip this runner
+        if (!cmd) {
+            return { status: "skipped", diagnostics: [], semantic: "none" };
         }
-        // Run pyright with JSON output (use venv-local or global command)
-        const result = await safeSpawnAsync(pyright.getCommand(), ["--outputjson", ctx.filePath], {
+        // Run pyright with JSON output
+        const result = await safeSpawnAsync(cmd, ["--outputjson", ctx.filePath], {
             timeout: 60000,
         });
         // Pyright returns non-zero when errors found, that's OK

package/clients/dispatch/runners/pyright.ts

@@ -28,22 +28,36 @@ const pyrightRunner: RunnerDefinition = {
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
 		const cwd = ctx.cwd || process.cwd();
 
-		// Auto-install pyright if not available (it's one of the 4 auto-install tools)
-		if (!pyright.isAvailable(cwd)) {
-			const installed = await ensureTool("pyright");
-			if (!installed) {
-				return { status: "skipped", diagnostics: [], semantic: "none" };
-			}
+		// Get pyright command - try multiple strategies
+		let cmd: string | null = null;
+
+		// Strategy 1: Check cached availability (fast path)
+		if (pyright.isAvailable(cwd)) {
+			cmd = pyright.getCommand();
+		}
+
+		// Strategy 2: Try to find pyright via ensureTool (installs if needed)
+		if (!cmd) {
+			const installedPath = await ensureTool("pyright");
+			if (installedPath) cmd = installedPath;
+		}
+
+		// Strategy 3: Direct PATH check (handles module cache staleness)
+		if (!cmd) {
+			const { findCommandAsync } = await import("../../safe-spawn.js");
+			const foundCmd: string | null = await findCommandAsync("pyright");
+			if (foundCmd) cmd = foundCmd;
 		}
 
-		// Run pyright with JSON output (use venv-local or global command)
-		const result = await safeSpawnAsync(
-			pyright.getCommand()!,
-			["--outputjson", ctx.filePath],
-			{
-				timeout: 60000,
-			},
-		);
+		// If still no pyright, skip this runner
+		if (!cmd) {
+			return { status: "skipped", diagnostics: [], semantic: "none" };
+		}
+
+		// Run pyright with JSON output
+		const result = await safeSpawnAsync(cmd, ["--outputjson", ctx.filePath], {
+			timeout: 60000,
+		});
 
 		// Pyright returns non-zero when errors found, that's OK
 		if (result.error) {

package/clients/dispatch/runners/rust-clippy.js

@@ -3,6 +3,8 @@
  *
  * Runs `cargo clippy` for Rust files to catch common mistakes.
  */
+import { existsSync } from "node:fs";
+import { dirname, join } from "node:path";
 import { safeSpawn } from "../../safe-spawn.js";
 import { stripAnsi } from "../../sanitize.js";
 const rustClippyRunner = {
@@ -51,8 +53,6 @@ const rustClippyRunner = {
     },
 };
 function findCargoToml(filePath) {
-    const { dirname, join } = require("node:path");
-    const { existsSync } = require("node:fs");
     let dir = dirname(filePath);
     while (dir !== "/" && dir !== ".") {
         const cargoPath = join(dir, "Cargo.toml");

package/clients/dispatch/runners/rust-clippy.ts

@@ -4,7 +4,8 @@
  * Runs `cargo clippy` for Rust files to catch common mistakes.
  */
 
-import { spawnSync } from "node:child_process";
+import { existsSync } from "node:fs";
+import { dirname, join } from "node:path";
 import { safeSpawn } from "../../safe-spawn.js";
 import { stripAnsi } from "../../sanitize.js";
 import type {
@@ -74,9 +75,6 @@ const rustClippyRunner: RunnerDefinition = {
 };
 
 function findCargoToml(filePath: string): string | undefined {
-	const { dirname, join } = require("node:path");
-	const { existsSync } = require("node:fs");
-
 	let dir = dirname(filePath);
 	while (dir !== "/" && dir !== ".") {
 		const cargoPath = join(dir, "Cargo.toml");

package/clients/dispatch/runners/tree-sitter.js

@@ -3,10 +3,21 @@
  *
  * Executes all loaded tree-sitter query files from rules/tree-sitter-queries/
  * for fast AST-based pattern matching.
+ * Updated: ast-grep-napi test
  */
 import path from "node:path";
 import { TreeSitterClient } from "../../tree-sitter-client.js";
 import { queryLoader } from "../../tree-sitter-query-loader.js";
+// Module-level singleton: web-tree-sitter WASM must only be initialized once per process.
+// Creating a new TreeSitterClient() on every write resets TRANSFER_BUFFER (a module-level
+// WASM pointer) — concurrent writes race on _ts_init() and corrupt shared WASM state → crash.
+let _sharedClient = null;
+function getSharedClient() {
+    if (!_sharedClient) {
+        _sharedClient = new TreeSitterClient();
+    }
+    return _sharedClient;
+}
 const treeSitterRunner = {
     id: "tree-sitter",
     appliesTo: ["jsts", "python"],
@@ -14,8 +25,8 @@ const treeSitterRunner = {
     enabledByDefault: true,
     skipTestFiles: false, // Run on test files too (structural issues matter there)
     async run(ctx) {
-        // Initialize tree-sitter client
-        const client = new TreeSitterClient();
+        // Use singleton client — WASM must never be re-initialized after first call
+        const client = getSharedClient();
         if (!client.isAvailable()) {
             return { status: "skipped", diagnostics: [], semantic: "none" };
         }
@@ -105,3 +116,4 @@ const treeSitterRunner = {
     },
 };
 export default treeSitterRunner;
+// test ast-grep-napi re-enable

package/clients/dispatch/runners/tree-sitter.ts

@@ -3,6 +3,7 @@
  *
  * Executes all loaded tree-sitter query files from rules/tree-sitter-queries/
  * for fast AST-based pattern matching.
+ * Updated: ast-grep-napi test
  */
 
 import path from "node:path";
@@ -15,6 +16,17 @@ import type {
 	RunnerResult,
 } from "../types.js";
 
+// Module-level singleton: web-tree-sitter WASM must only be initialized once per process.
+// Creating a new TreeSitterClient() on every write resets TRANSFER_BUFFER (a module-level
+// WASM pointer) — concurrent writes race on _ts_init() and corrupt shared WASM state → crash.
+let _sharedClient: TreeSitterClient | null = null;
+function getSharedClient(): TreeSitterClient {
+	if (!_sharedClient) {
+		_sharedClient = new TreeSitterClient();
+	}
+	return _sharedClient;
+}
+
 const treeSitterRunner: RunnerDefinition = {
 	id: "tree-sitter",
 	appliesTo: ["jsts", "python"],
@@ -23,8 +35,8 @@ const treeSitterRunner: RunnerDefinition = {
 	skipTestFiles: false, // Run on test files too (structural issues matter there)
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
-		// Initialize tree-sitter client
-		const client = new TreeSitterClient();
+		// Use singleton client — WASM must never be re-initialized after first call
+		const client = getSharedClient();
 		if (!client.isAvailable()) {
 			return { status: "skipped", diagnostics: [], semantic: "none" };
 		}
@@ -133,3 +145,4 @@ const treeSitterRunner: RunnerDefinition = {
 };
 
 export default treeSitterRunner;
+// test ast-grep-napi re-enable

package/clients/dispatch/runners/ts-lsp.js

@@ -6,8 +6,8 @@
  *
  * @deprecated The built-in TypeScriptClient is deprecated. Use --lens-lsp for full LSP support.
  */
-import { TypeScriptClient } from "../../typescript-client.js";
 import { getLSPService } from "../../lsp/index.js";
+import { TypeScriptClient } from "../../typescript-client.js";
 import { readFileContent } from "./utils.js";
 const tsLspRunner = {
     id: "ts-lsp",
@@ -45,8 +45,8 @@ async function runWithLSPClient(ctx) {
     }
     // Open file in LSP and get diagnostics
     await lspService.openFile(ctx.filePath, content);
-    // Small delay to let diagnostics propagate
-    await new Promise(r => setTimeout(r, 500));
+    // getDiagnostics() internally calls waitForDiagnostics() with bus
+    // subscription + 150ms debounce + 3s timeout
     const lspDiags = await lspService.getDiagnostics(ctx.filePath);
     // Convert LSP diagnostics to our format
     // Defensive: filter out malformed diagnostics that may lack range

package/clients/dispatch/runners/ts-lsp.ts

@@ -7,8 +7,8 @@
  * @deprecated The built-in TypeScriptClient is deprecated. Use --lens-lsp for full LSP support.
  */
 
-import { TypeScriptClient } from "../../typescript-client.js";
 import { getLSPService } from "../../lsp/index.js";
+import { TypeScriptClient } from "../../typescript-client.js";
 import type {
 	Diagnostic,
 	DispatchContext,
@@ -60,8 +60,8 @@ async function runWithLSPClient(ctx: DispatchContext): Promise<RunnerResult> {
 
 	// Open file in LSP and get diagnostics
 	await lspService.openFile(ctx.filePath, content);
-	// Small delay to let diagnostics propagate
-	await new Promise(r => setTimeout(r, 500));
+	// getDiagnostics() internally calls waitForDiagnostics() with bus
+	// subscription + 150ms debounce + 3s timeout
 	const lspDiags = await lspService.getDiagnostics(ctx.filePath);
 
 	// Convert LSP diagnostics to our format
@@ -74,7 +74,8 @@ async function runWithLSPClient(ctx: DispatchContext): Promise<RunnerResult> {
 			filePath: ctx.filePath,
 			line: d.range.start.line + 1,
 			column: d.range.start.character + 1,
-			severity: d.severity === 1 ? "error" : d.severity === 2 ? "warning" : "info",
+			severity:
+				d.severity === 1 ? "error" : d.severity === 2 ? "warning" : "info",
 			semantic: d.severity === 1 ? "blocking" : "warning",
 			tool: "ts-lsp",
 			code: String(d.code ?? ""),
@@ -91,7 +92,9 @@ async function runWithLSPClient(ctx: DispatchContext): Promise<RunnerResult> {
  * Run with deprecated built-in TypeScriptClient
  * @deprecated Use runWithLSPClient instead
  */
-async function runWithBuiltinClient(ctx: DispatchContext): Promise<RunnerResult> {
+async function runWithBuiltinClient(
+	ctx: DispatchContext,
+): Promise<RunnerResult> {
 	const tsClient = new TypeScriptClient();
 
 	const content = readFileContent(ctx.filePath);