pi-lens 3.1.2 → 3.2.0

package/clients/sg-runner.js

@@ -15,25 +15,67 @@ import { safeSpawn } from "./safe-spawn.js";
  */
 function escapeWindowsArg(arg) {
     // If no special characters, return as-is
-    if (!/[\s\"]/.test(arg))
+    if (!/[\s"]/.test(arg))
         return arg;
     // Escape quotes by doubling them
-    return `"${arg.replace(/"/g, "\"\"")}"`;
+    return `"${arg.replace(/"/g, '""')}"`;
 }
 export class SgRunner {
     constructor(verbose = false) {
+        this.sgPath = null;
+        this.available = null;
         this.log = verbose
             ? (msg) => console.error(`[sg-runner] ${msg}`)
             : () => { };
     }
     /**
-     * Check if ast-grep CLI is available
+     * Check if ast-grep CLI is available, auto-install if not
+     */
+    async ensureAvailable() {
+        // Fast path: already checked
+        if (this.available !== null)
+            return this.available;
+        // Check if available in PATH (fast)
+        const pathResult = safeSpawn("sg", ["--version"], {
+            timeout: 5000,
+        });
+        if (!pathResult.error && pathResult.status === 0) {
+            this.sgPath = "sg";
+            this.available = true;
+            this.log("ast-grep found in PATH");
+            return true;
+        }
+        // Auto-install via pi-lens installer
+        this.log("ast-grep not found, attempting auto-install...");
+        const { ensureTool } = await import("./installer/index.js");
+        const installedPath = await ensureTool("ast-grep");
+        if (installedPath) {
+            this.sgPath = installedPath;
+            this.available = true;
+            this.log(`ast-grep auto-installed: ${installedPath}`);
+            return true;
+        }
+        this.available = false;
+        return false;
+    }
+    /**
+     * Check if ast-grep CLI is available (legacy sync method)
+     * Prefer ensureAvailable() for auto-install behavior
      */
     isAvailable() {
+        if (this.available !== null)
+            return this.available;
         const result = safeSpawn("npx", ["sg", "--version"], {
             timeout: 10000,
         });
-        return !result.error && result.status === 0;
+        this.available = !result.error && result.status === 0;
+        return this.available;
+    }
+    /**
+     * Get the sg command to use (local binary or "sg" from PATH)
+     */
+    getSgCommand() {
+        return this.sgPath || "sg";
     }
     /**
      * Run ast-grep asynchronously, return parsed matches
@@ -54,12 +96,12 @@ export class SgRunner {
                         return `'${arg.replace(/'/g, "'\\''")}'`;
                     }
                     // For other args with spaces/special chars, use double quotes
-                    if (/[\s\"]/.test(arg)) {
-                        return `"${arg.replace(/"/g, "\\\"")}"`;
+                    if (/[\s"]/.test(arg)) {
+                        return `"${arg.replace(/"/g, '\\"')}"`;
                     }
                     return arg;
                 });
-                const bashCommand = `npx sg ${escapedArgs.join(" ")}`;
+                const bashCommand = `${this.getSgCommand()} ${escapedArgs.join(" ")}`;
                 proc = spawn("bash", ["-c", bashCommand], {
                     stdio: ["ignore", "pipe", "pipe"],
                     windowsHide: true,
@@ -67,7 +109,7 @@ export class SgRunner {
             }
             else if (isWindows) {
                 // Fallback: use cmd.exe with standard escaping
-                const fullCommand = `npx sg ${args.map(escapeWindowsArg).join(" ")}`;
+                const fullCommand = `${this.getSgCommand()} ${args.map(escapeWindowsArg).join(" ")}`;
                 proc = spawn(fullCommand, {
                     stdio: ["ignore", "pipe", "pipe"],
                     shell: true,
@@ -76,7 +118,7 @@ export class SgRunner {
             }
             else {
                 // Unix: normal spawn without shell
-                proc = spawn("npx", ["sg", ...args], {
+                proc = spawn(this.getSgCommand(), args, {
                     stdio: ["ignore", "pipe", "pipe"],
                 });
             }

package/clients/sg-runner.ts

@@ -5,7 +5,7 @@
  * Handles: spawn, spawnSync, temp dir management, JSON parsing.
  */
 
-import { spawn, spawnSync } from "node:child_process";
+import { spawn } from "node:child_process";
 import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
@@ -17,10 +17,10 @@ import { safeSpawn } from "./safe-spawn.js";
  */
 function escapeWindowsArg(arg: string): string {
 	// If no special characters, return as-is
-	if (!/[\s\"]/.test(arg)) return arg;
+	if (!/[\s"]/.test(arg)) return arg;
 
 	// Escape quotes by doubling them
-	return `"${arg.replace(/"/g, "\"\"")}"`;
+	return `"${arg.replace(/"/g, '""')}"`;
 }
 
 export interface SgMatch {
@@ -40,6 +40,8 @@ export interface SgResult {
 
 export class SgRunner {
 	private log: (msg: string) => void;
+	private sgPath: string | null = null;
+	private available: boolean | null = null;
 
 	constructor(verbose = false) {
 		this.log = verbose
@@ -48,13 +50,58 @@ export class SgRunner {
 	}
 
 	/**
-	 * Check if ast-grep CLI is available
+	 * Check if ast-grep CLI is available, auto-install if not
+	 */
+	async ensureAvailable(): Promise<boolean> {
+		// Fast path: already checked
+		if (this.available !== null) return this.available;
+
+		// Check if available in PATH (fast)
+		const pathResult = safeSpawn("sg", ["--version"], {
+			timeout: 5000,
+		});
+		if (!pathResult.error && pathResult.status === 0) {
+			this.sgPath = "sg";
+			this.available = true;
+			this.log("ast-grep found in PATH");
+			return true;
+		}
+
+		// Auto-install via pi-lens installer
+		this.log("ast-grep not found, attempting auto-install...");
+		const { ensureTool } = await import("./installer/index.js");
+		const installedPath = await ensureTool("ast-grep");
+
+		if (installedPath) {
+			this.sgPath = installedPath;
+			this.available = true;
+			this.log(`ast-grep auto-installed: ${installedPath}`);
+			return true;
+		}
+
+		this.available = false;
+		return false;
+	}
+
+	/**
+	 * Check if ast-grep CLI is available (legacy sync method)
+	 * Prefer ensureAvailable() for auto-install behavior
 	 */
 	isAvailable(): boolean {
+		if (this.available !== null) return this.available;
+
 		const result = safeSpawn("npx", ["sg", "--version"], {
 			timeout: 10000,
 		});
-		return !result.error && result.status === 0;
+		this.available = !result.error && result.status === 0;
+		return this.available;
+	}
+
+	/**
+	 * Get the sg command to use (local binary or "sg" from PATH)
+	 */
+	private getSgCommand(): string {
+		return this.sgPath || "sg";
 	}
 
 	/**
@@ -77,19 +124,19 @@ export class SgRunner {
 						return `'${arg.replace(/'/g, "'\\''")}'`;
 					}
 					// For other args with spaces/special chars, use double quotes
-					if (/[\s\"]/.test(arg)) {
-						return `"${arg.replace(/"/g, "\\\"")}"`;
+					if (/[\s"]/.test(arg)) {
+						return `"${arg.replace(/"/g, '\\"')}"`;
 					}
 					return arg;
 				});
-				const bashCommand = `npx sg ${escapedArgs.join(" ")}`;
+				const bashCommand = `${this.getSgCommand()} ${escapedArgs.join(" ")}`;
 				proc = spawn("bash", ["-c", bashCommand], {
 					stdio: ["ignore", "pipe", "pipe"],
 					windowsHide: true,
 				});
 			} else if (isWindows) {
 				// Fallback: use cmd.exe with standard escaping
-				const fullCommand = `npx sg ${args.map(escapeWindowsArg).join(" ")}`;
+				const fullCommand = `${this.getSgCommand()} ${args.map(escapeWindowsArg).join(" ")}`;
 				proc = spawn(fullCommand, {
 					stdio: ["ignore", "pipe", "pipe"],
 					shell: true,
@@ -97,7 +144,7 @@ export class SgRunner {
 				});
 			} else {
 				// Unix: normal spawn without shell
-				proc = spawn("npx", ["sg", ...args], {
+				proc = spawn(this.getSgCommand(), args, {
 					stdio: ["ignore", "pipe", "pipe"],
 				});
 			}
@@ -206,11 +253,7 @@ export class SgRunner {
 	/**
 	 * Run a rule file scan (temporary config approach) - alias for tempScan
 	 */
-	scanWithRule(
-		ruleYaml: string,
-		dir: string,
-		timeout = 30000,
-	): SgMatch[] {
+	scanWithRule(ruleYaml: string, dir: string, timeout = 30000): SgMatch[] {
 		const sessionDir = path.join(os.tmpdir(), `sg-scan-${Date.now()}`);
 		const rulesSubdir = path.join(sessionDir, "rules");
 		const configFile = path.join(sessionDir, ".sgconfig.yml");

package/clients/tree-sitter-client.js

@@ -446,6 +446,18 @@ export class TreeSitterClient {
                             continue; // Skip console.dbg()
                     }
                 }
+                if (postFilter === "no_super_call") {
+                    const bodyNode = captures.BODY;
+                    if (bodyNode) {
+                        // Check if body contains actual super() call (not in comments)
+                        const bodyText = bodyNode.text;
+                        // Match super() or super.method() but not // super() in comments
+                        const superCallRegex = /(?<!\/\/.*)super\s*\(/;
+                        const hasSuperCall = superCallRegex.test(bodyText);
+                        if (hasSuperCall)
+                            continue; // Skip if has super() - this is the GOOD case
+                    }
+                }
                 // Use first capture for position info
                 if (match.captures.length > 0) {
                     const firstNode = match.captures[0].node;

package/clients/tree-sitter-client.ts

@@ -650,6 +650,18 @@ export class TreeSitterClient {
 					}
 				}
 
+				if (postFilter === "no_super_call") {
+					const bodyNode = captures.BODY;
+					if (bodyNode) {
+						// Check if body contains actual super() call (not in comments)
+						const bodyText = bodyNode.text;
+						// Match super() or super.method() but not // super() in comments
+						const superCallRegex = /(?<!\/\/.*)super\s*\(/;
+						const hasSuperCall = superCallRegex.test(bodyText);
+						if (hasSuperCall) continue; // Skip if has super() - this is the GOOD case
+					}
+				}
+
 				// Use first capture for position info
 				if (match.captures.length > 0) {
 					const firstNode = match.captures[0].node;

package/clients/typescript-client.js

@@ -462,9 +462,13 @@ export class TypeScriptClient {
      * Get all quick fixes for all diagnostics in a file.
      * Returns a map of diagnostic line → fixes.
      */
-    getAllCodeFixes(filePath) {
+    /**
+     * Accept pre-computed diagnostics to avoid a second getSemanticDiagnostics call
+     * when the caller already has them (saves ~1–2s on large files).
+     */
+    getAllCodeFixes(filePath, precomputedDiags) {
         const fixesByLine = new Map();
-        const diagnostics = this.getDiagnostics(filePath);
+        const diagnostics = precomputedDiags ?? this.getDiagnostics(filePath);
         for (const diag of diagnostics) {
             if (diag.severity !== 1 || diag.code === undefined)
                 continue;

package/clients/typescript-client.ts

@@ -617,7 +617,14 @@ export class TypeScriptClient {
 	 * Get all quick fixes for all diagnostics in a file.
 	 * Returns a map of diagnostic line → fixes.
 	 */
-	getAllCodeFixes(filePath: string): Map<
+	/**
+	 * Accept pre-computed diagnostics to avoid a second getSemanticDiagnostics call
+	 * when the caller already has them (saves ~1–2s on large files).
+	 */
+	getAllCodeFixes(
+		filePath: string,
+		precomputedDiags?: Diagnostic[],
+	): Map<
 		number,
 		Array<{
 			description: string;
@@ -644,7 +651,7 @@ export class TypeScriptClient {
 			}>
 		>();
 
-		const diagnostics = this.getDiagnostics(filePath);
+		const diagnostics = precomputedDiags ?? this.getDiagnostics(filePath);
 		for (const diag of diagnostics) {
 			if (diag.severity !== 1 || diag.code === undefined) continue;
 			const fixes = this.getCodeFixes(

package/commands/booboo.js

@@ -44,8 +44,8 @@ export async function handleBooboo(args, ctx, clients, pi) {
     const targetPath = args.trim() || ctx.cwd || process.cwd();
     // Detect project metadata for richer reporting
     const projectMeta = detectProjectMetadata(targetPath);
-    const metaDisplay = formatProjectMetadata(projectMeta);
-    ctx.ui.notify(`🔍 Running full codebase review...\n${metaDisplay}`, "info");
+    const _metaDisplay = formatProjectMetadata(projectMeta);
+    // No noisy notification at start - just run the review silently
     // Detect project type once for all runners
     const isTsProject = nodeFs.existsSync(path.join(targetPath, "tsconfig.json"));
     // Get available commands for the project
@@ -966,9 +966,7 @@ ${fullReport.join("\n")}`;
         const summaryLines = [
             `📊 Code Review: ${totalIssues} issues`,
             ...runnerLines,
-            `  🔧 ${fixableCount} fixable | 🏗️ ${refactorNeeded} refactor`,
             `  ⏱️  Total: ${jsonReport.meta.totalTime}`,
-            `📄 JSON: ${jsonPath}`,
             `📄 MD: ${mdPath}`,
         ];
         ctx.ui.notify(summaryLines.join("\n"), "info");

package/commands/booboo.ts

@@ -82,9 +82,9 @@ export async function handleBooboo(
 
 	// Detect project metadata for richer reporting
 	const projectMeta = detectProjectMetadata(targetPath);
-	const metaDisplay = formatProjectMetadata(projectMeta);
+	const _metaDisplay = formatProjectMetadata(projectMeta);
 
-	ctx.ui.notify(`🔍 Running full codebase review...\n${metaDisplay}`, "info");
+	// No noisy notification at start - just run the review silently
 
 	// Detect project type once for all runners
 	const isTsProject = nodeFs.existsSync(path.join(targetPath, "tsconfig.json"));
@@ -1229,9 +1229,7 @@ ${fullReport.join("\n")}`;
 		const summaryLines = [
 			`📊 Code Review: ${totalIssues} issues`,
 			...runnerLines,
-			`  🔧 ${fixableCount} fixable | 🏗️ ${refactorNeeded} refactor`,
 			`  ⏱️  Total: ${jsonReport.meta.totalTime}`,
-			`📄 JSON: ${jsonPath}`,
 			`📄 MD: ${mdPath}`,
 		];