nativescript 9.0.0-alpha.2 → 9.0.0-alpha.4

package/lib/controllers/update-controller.js

@@ -28,12 +28,15 @@ class UpdateController extends update_controller_base_1.UpdateControllerBase {
         this.spinner = this.$terminalSpinnerService.createSpinner();
         const projectData = this.$projectDataService.getProjectData(updateOptions.projectDir);
         updateOptions.version = updateOptions.version || constants_1.PackageVersion.LATEST;
+        // back up project files and folders
         this.spinner.info("Backing up project files before update");
         await this.backupProject();
         this.spinner.succeed("Project files have been backed up");
+        // clean up project files
         this.spinner.info("Cleaning up project files before update");
         await this.cleanUpProject();
         this.spinner.succeed("Project files have been cleaned up");
+        // update dependencies
         this.spinner.info("Updating project dependencies");
         await this.updateDependencies(projectData, updateOptions.version);
         this.spinner.succeed("Project dependencies have been updated");
@@ -79,6 +82,10 @@ class UpdateController extends update_controller_base_1.UpdateControllerBase {
         if (!shouldUpdate) {
             return;
         }
+        // check if the coerced version is the same as desired and prefix it with a ~
+        // for example:
+        // 8.0.0 -> ~8.0.0
+        // 8.0.8-next-XXX -> 8.0.8-next-XXX
         const updatedVersion = (() => {
             if (desiredVersion === version) {
                 return desiredVersion;
@@ -131,9 +138,11 @@ class UpdateController extends update_controller_base_1.UpdateControllerBase {
 }
 exports.UpdateController = UpdateController;
 UpdateController.updatableDependencies = [
+    // dependencies
     {
         packageName: "@nativescript/core",
     },
+    // devDependencies
     {
         packageName: "@nativescript/webpack",
         isDev: true,
@@ -142,6 +151,7 @@ UpdateController.updatableDependencies = [
         packageName: "@nativescript/types",
         isDev: true,
     },
+    // runtimes
     {
         packageName: "@nativescript/ios",
         isDev: true,
@@ -161,3 +171,4 @@ UpdateController.pathsToBackup = [
     constants.CONFIG_NS_FILE_NAME,
 ];
 yok_1.injector.register("updateController", UpdateController);
+//# sourceMappingURL=update-controller.js.map

package/lib/data/build-data.js

@@ -42,3 +42,4 @@ class AndroidBuildData extends BuildData {
     }
 }
 exports.AndroidBuildData = AndroidBuildData;
+//# sourceMappingURL=build-data.js.map

package/lib/data/controller-data-base.js

@@ -9,3 +9,4 @@ class ControllerDataBase {
     }
 }
 exports.ControllerDataBase = ControllerDataBase;
+//# sourceMappingURL=controller-data-base.js.map

package/lib/data/debug-data.js

@@ -4,3 +4,4 @@ exports.DebugData = void 0;
 class DebugData {
 }
 exports.DebugData = DebugData;
+//# sourceMappingURL=debug-data.js.map

package/lib/data/platform-data.js

@@ -11,3 +11,4 @@ class AddPlatformData extends controller_data_base_1.ControllerDataBase {
     }
 }
 exports.AddPlatformData = AddPlatformData;
+//# sourceMappingURL=platform-data.js.map

package/lib/data/prepare-data.js

@@ -49,3 +49,4 @@ exports.IOSPrepareData = IOSPrepareData;
 class AndroidPrepareData extends PrepareData {
 }
 exports.AndroidPrepareData = AndroidPrepareData;
+//# sourceMappingURL=prepare-data.js.map

package/lib/data/run-data.js

@@ -9,3 +9,4 @@ class RunData {
     }
 }
 exports.RunData = RunData;
+//# sourceMappingURL=run-data.js.map

package/lib/detached-processes/cleanup-js-subprocess.js

@@ -1,6 +1,8 @@
 #!/usr/bin/env node
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+// NOTE: This file is used to call JS functions when cleaning resources used by CLI, after the CLI is killed.
+// The instances here are not shared with the ones in main CLI process.
 const fs = require("fs");
 const uuid_1 = require("uuid");
 const file_log_service_1 = require("./file-log-service");
@@ -9,6 +11,7 @@ const pathToBootstrap = process.argv[2];
 if (!pathToBootstrap || !fs.existsSync(pathToBootstrap)) {
     throw new Error("Invalid path to bootstrap.");
 }
+// After requiring the bootstrap we can use $injector
 require(pathToBootstrap);
 const logFile = process.argv[3];
 const jsFilePath = process.argv[4];
@@ -32,6 +35,7 @@ catch (err) {
 const logMessage = (msg, type) => {
     fileLogService.logData({ message: `[${uniqueId}] ${msg}`, type });
 };
+/* tslint:disable:no-floating-promises */
 (async () => {
     try {
         logMessage(`Requiring file ${jsFilePath}`);
@@ -43,11 +47,13 @@ const logMessage = (msg, type) => {
                 logMessage(`Finished execution with data: ${JSON.stringify(data)} to the default function exported by currently required file ${jsFilePath}`);
             }
             catch (err) {
-                logMessage(`Unable to execute action of file ${jsFilePath} when passed data is ${JSON.stringify(data)}. Error is: ${err}.`, "Error");
+                logMessage(`Unable to execute action of file ${jsFilePath} when passed data is ${JSON.stringify(data)}. Error is: ${err}.`, "Error" /* FileLogMessageType.Error */);
             }
         }
     }
     catch (err) {
-        logMessage(`Unable to require file: ${jsFilePath}. Error is: ${err}.`, "Error");
+        logMessage(`Unable to require file: ${jsFilePath}. Error is: ${err}.`, "Error" /* FileLogMessageType.Error */);
     }
 })();
+/* tslint:enable:no-floating-promises */
+//# sourceMappingURL=cleanup-js-subprocess.js.map

package/lib/detached-processes/cleanup-process.js

@@ -1,5 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+// NOTE: This file is used to clean up resources used by CLI, when the CLI is killed.
+// The instances here are not shared with the ones in main CLI process.
 const fs = require("fs");
 const path = require("path");
 const shelljs = require("shelljs");
@@ -11,6 +13,7 @@ if (!pathToBootstrap || !fs.existsSync(pathToBootstrap)) {
     throw new Error("Invalid path to bootstrap.");
 }
 const logFile = process.argv[3];
+// After requiring the bootstrap we can use $injector
 require(pathToBootstrap);
 const fileLogService = yok_1.injector.resolve(file_log_service_1.FileLogService, {
     logFile,
@@ -63,7 +66,7 @@ const executeJSCleanup = async (jsCommand) => {
     catch (err) {
         fileLogService.logData({
             message: `Unable to execute action for file ${jsCommand.filePath} with data ${JSON.stringify(jsCommand.data)}. Error is: ${err}.`,
-            type: "Error",
+            type: "Error" /* FileLogMessageType.Error */,
         });
     }
 };
@@ -88,7 +91,7 @@ const executeCleanup = async () => {
         catch (err) {
             fileLogService.logData({
                 message: `Unable to execute command: ${JSON.stringify(commandInfo)}. Error is: ${err}.`,
-                type: "Error",
+                type: "Error" /* FileLogMessageType.Error */,
             });
         }
     }
@@ -102,7 +105,7 @@ const executeCleanup = async () => {
         catch (err) {
             fileLogService.logData({
                 message: `Unable to delete files: ${JSON.stringify(filesToDelete)}. Error is: ${err}.`,
-                type: "Error",
+                type: "Error" /* FileLogMessageType.Error */,
             });
         }
     }
@@ -224,36 +227,36 @@ process.on("message", async (cleanupProcessMessage) => {
         message: `cleanup-process received message of type: ${JSON.stringify(cleanupProcessMessage)}`,
     });
     switch (cleanupProcessMessage.messageType) {
-        case "AddCleanCommand":
+        case "AddCleanCommand" /* CleanupProcessMessage.AddCleanCommand */:
             addCleanupAction(cleanupProcessMessage.commandInfo);
             break;
-        case "RemoveCleanCommand":
+        case "RemoveCleanCommand" /* CleanupProcessMessage.RemoveCleanCommand */:
             removeCleanupAction(cleanupProcessMessage.commandInfo);
             break;
-        case "AddRequest":
+        case "AddRequest" /* CleanupProcessMessage.AddRequest */:
             addRequest(cleanupProcessMessage.requestInfo);
             break;
-        case "RemoveRequest":
+        case "RemoveRequest" /* CleanupProcessMessage.RemoveRequest */:
             removeRequest(cleanupProcessMessage.requestInfo);
             break;
-        case "AddDeleteFileAction":
+        case "AddDeleteFileAction" /* CleanupProcessMessage.AddDeleteFileAction */:
             addDeleteAction(cleanupProcessMessage.filePath);
             break;
-        case "RemoveDeleteFileAction":
+        case "RemoveDeleteFileAction" /* CleanupProcessMessage.RemoveDeleteFileAction */:
             removeDeleteAction(cleanupProcessMessage.filePath);
             break;
-        case "AddJSFileToRequire":
+        case "AddJSFileToRequire" /* CleanupProcessMessage.AddJSFileToRequire */:
             const jsCleanupMessage = cleanupProcessMessage;
             addJSFile(jsCleanupMessage.jsCommand);
             break;
-        case "RemoveJSFileToRequire":
+        case "RemoveJSFileToRequire" /* CleanupProcessMessage.RemoveJSFileToRequire */:
             const msgToRemove = cleanupProcessMessage;
             removeJSFile(msgToRemove.jsCommand);
             break;
         default:
             fileLogService.logData({
                 message: `Unable to handle message of type ${cleanupProcessMessage.messageType}. Full message is ${JSON.stringify(cleanupProcessMessage)}`,
-                type: "Error",
+                type: "Error" /* FileLogMessageType.Error */,
             });
             break;
     }
@@ -267,6 +270,7 @@ process.on("disconnect", async () => {
     process.exit();
 });
 fileLogService.logData({
-    message: `cleanup-process will send ${"ProcessReadyToReceive"} message`,
+    message: `cleanup-process will send ${"ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */} message`,
 });
-process.send("ProcessReadyToReceive");
+process.send("ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */);
+//# sourceMappingURL=cleanup-process.js.map

package/lib/detached-processes/file-log-service.js

@@ -11,10 +11,11 @@ class FileLogService {
     logData(fileLoggingMessage) {
         if (this.logFile && fileLoggingMessage && fileLoggingMessage.message) {
             fileLoggingMessage.type =
-                fileLoggingMessage.type || "Info";
+                fileLoggingMessage.type || "Info" /* FileLogMessageType.Info */;
             const formattedDate = (0, helpers_1.getFixedLengthDateString)();
             this.$fs.appendFile(this.logFile, `[${formattedDate}] [${fileLoggingMessage.type}] ${fileLoggingMessage.message}${os_1.EOL}`);
         }
     }
 }
 exports.FileLogService = FileLogService;
+//# sourceMappingURL=file-log-service.js.map

package/lib/device-path-provider.js

@@ -47,3 +47,4 @@ class DevicePathProvider {
 }
 exports.DevicePathProvider = DevicePathProvider;
 yok_1.injector.register("devicePathProvider", DevicePathProvider);
+//# sourceMappingURL=device-path-provider.js.map

package/lib/device-sockets/ios/app-debug-socket-proxy-factory.js

@@ -76,6 +76,7 @@ class AppDebugSocketProxyFactory extends events_1.EventEmitter {
         const existingWebProxy = this.deviceWebServers[`${device.deviceInfo.identifier}-${appId}`];
         const result = existingWebProxy ||
             (await this.addWebSocketProxy(device, appId, projectName, projectDir));
+        // TODO: do not remove till VSCode waits for this message in order to reattach
         this.$logger.info("Opened localhost " + result.options.port);
         return result;
     }
@@ -86,8 +87,13 @@ class AppDebugSocketProxyFactory extends events_1.EventEmitter {
         if (existingServer) {
             this.$errors.fail(`Web socket proxy is already running for device '${device.deviceInfo.identifier}' and app '${appId}'`);
         }
+        // NOTE: We will try to provide command line options to select ports, at least on the localhost.
         const localPort = await this.$net.getAvailablePortInRange(41000);
         this.$logger.info("\nSetting up debugger proxy...\nPress Ctrl + C to terminate, or disconnect.\n");
+        // NB: When the inspector frontend connects we might not have connected to the inspector backend yet.
+        // That's why we use the verifyClient callback of the websocket server to stall the upgrade request until we connect.
+        // We store the socket that connects us to the device in the upgrade request object itself and later on retrieve it
+        // in the connection callback.
         let currentAppSocket = null;
         let currentWebSocket = null;
         const server = new ws.Server({
@@ -200,3 +206,4 @@ class AppDebugSocketProxyFactory extends events_1.EventEmitter {
 }
 exports.AppDebugSocketProxyFactory = AppDebugSocketProxyFactory;
 yok_1.injector.register("appDebugSocketProxyFactory", AppDebugSocketProxyFactory);
+//# sourceMappingURL=app-debug-socket-proxy-factory.js.map

package/lib/device-sockets/ios/notification.js

@@ -6,6 +6,8 @@ const constants_1 = require("../../common/constants");
 const yok_1 = require("../../common/yok");
 class IOSNotification extends events_1.EventEmitter {
     getAttachRequest(appId, deviceId) {
+        // It could be too early to emit this event, but we rely that if you construct attach request,
+        // you will execute it immediately.
         this.emit(constants_1.ATTACH_REQUEST_EVENT_NAME, { deviceId, appId });
         return this.formatNotification(IOSNotification.ATTACH_REQUEST_NOTIFICATION_NAME, appId);
     }
@@ -28,3 +30,4 @@ IOSNotification.APP_REFRESH_STARTED_NOTIFICATION_NAME = "AppRefreshStarted";
 IOSNotification.ATTACH_REQUEST_NOTIFICATION_NAME = "AttachRequest";
 IOSNotification.READY_FOR_ATTACH_NOTIFICATION_NAME = "ReadyForAttach";
 yok_1.injector.register("iOSNotification", IOSNotification);
+//# sourceMappingURL=notification.js.map

package/lib/device-sockets/ios/socket-request-executor.js

@@ -25,6 +25,8 @@ class IOSSocketRequestExecutor {
     async executeRequest(mainRequestName, successfulyExecutedNotificationName, appId, deviceId, timeout) {
         let isSuccessful = false;
         try {
+            // We should create this promise here because we need to send the ObserveNotification on the device
+            // before we send the PostNotification.
             const socket = await this.$iOSNotificationService.postNotification(deviceId, successfulyExecutedNotificationName, constants.IOS_OBSERVE_NOTIFICATION_COMMAND_TYPE);
             const notificationPromise = this.$iOSNotificationService.awaitNotification(deviceId, +socket, timeout);
             await this.$iOSNotificationService.postNotification(deviceId, mainRequestName);
@@ -39,3 +41,4 @@ class IOSSocketRequestExecutor {
 }
 exports.IOSSocketRequestExecutor = IOSSocketRequestExecutor;
 yok_1.injector.register("iOSSocketRequestExecutor", IOSSocketRequestExecutor);
+//# sourceMappingURL=socket-request-executor.js.map

package/lib/helpers/android-bundle-validator-helper.js

@@ -22,7 +22,7 @@ class AndroidBundleValidatorHelper extends version_validator_helper_1.VersionVal
     }
     validateRuntimeVersion(projectData) {
         if (this.$options.aab) {
-            const runtimePackage = this.$projectDataService.getRuntimePackage(projectData.projectDir, "android");
+            const runtimePackage = this.$projectDataService.getRuntimePackage(projectData.projectDir, "android" /* PlatformTypes.android */);
             const androidRuntimeVersion = runtimePackage
                 ? runtimePackage.version
                 : "";
@@ -50,3 +50,4 @@ exports.AndroidBundleValidatorHelper = AndroidBundleValidatorHelper;
 AndroidBundleValidatorHelper.MIN_RUNTIME_VERSION = "5.0.0";
 AndroidBundleValidatorHelper.MIN_ANDROID_WITH_AAB_SUPPORT = "4.4.0";
 yok_1.injector.register("androidBundleValidatorHelper", AndroidBundleValidatorHelper);
+//# sourceMappingURL=android-bundle-validator-helper.js.map

package/lib/helpers/deploy-command-helper.js

@@ -63,3 +63,4 @@ class DeployCommandHelper {
 }
 exports.DeployCommandHelper = DeployCommandHelper;
 yok_1.injector.register("deployCommandHelper", DeployCommandHelper);
+//# sourceMappingURL=deploy-command-helper.js.map

package/lib/helpers/key-command-helper.js

@@ -8,7 +8,8 @@ class KeyCommandHelper {
         this.overrides = {};
         this.onKeyPressed = async (data) => {
             const key = data.toString();
-            if (this.keyCommandExecutionBlocked && key !== "\u0003")
+            // Allow Ctrl + C always.
+            if (this.keyCommandExecutionBlocked && key !== "\u0003" /* SpecialKeys.CtrlC */)
                 return;
             try {
                 const exists = yok_1.injector.getRegisteredKeyCommandsNames().includes(key);
@@ -31,7 +32,7 @@ class KeyCommandHelper {
                                 return;
                             }
                         }
-                        if (keyCommand.key !== "\u0003") {
+                        if (keyCommand.key !== "\u0003" /* SpecialKeys.CtrlC */) {
                             const line = ` ${color_1.color.dim("→")} ${color_1.color.bold(keyCommand.key)} — ${keyCommand.description}`;
                             const lineLength = (0, color_1.stripColors)(line).length - 1;
                             console.log(color_1.color.dim(` ┌${"─".repeat(lineLength)}┐`));
@@ -113,3 +114,4 @@ class KeyCommandHelper {
 }
 exports.default = KeyCommandHelper;
 yok_1.injector.register("keyCommandHelper", KeyCommandHelper);
+//# sourceMappingURL=key-command-helper.js.map

package/lib/helpers/livesync-command-helper.js

@@ -25,6 +25,7 @@ class LiveSyncCommandHelper {
     get $platformsDataService() {
         return this.$injector.resolve("platformsDataService");
     }
+    // TODO: Remove this and replace it with buildData
     getLiveSyncData(projectDir) {
         const liveSyncInfo = {
             projectDir,
@@ -54,6 +55,7 @@ class LiveSyncCommandHelper {
         return devices;
     }
     async createDeviceDescriptors(devices, platform, additionalOptions) {
+        // Now let's take data for each device:
         const deviceDescriptors = devices.map((d) => {
             const outputPath = additionalOptions &&
                 additionalOptions.getOutputDirectory &&
@@ -133,7 +135,7 @@ class LiveSyncCommandHelper {
             const remainingDevicesToSync = devices.map((d) => d.deviceInfo.identifier);
             _.remove(remainingDevicesToSync, (d) => d === data.deviceIdentifier);
             if (remainingDevicesToSync.length === 0 && !data.keepProcessAlive) {
-                process.exit(134);
+                process.exit(134 /* ErrorCodes.ALL_DEVICES_DISCONNECTED */);
             }
         });
     }
@@ -203,3 +205,4 @@ class LiveSyncCommandHelper {
 }
 exports.LiveSyncCommandHelper = LiveSyncCommandHelper;
 yok_1.injector.register("liveSyncCommandHelper", LiveSyncCommandHelper);
+//# sourceMappingURL=livesync-command-helper.js.map

package/lib/helpers/network-connectivity-validator.js

@@ -34,3 +34,4 @@ NetworkConnectivityValidator.DNS_LOOKUP_URL = "play.nativescript.org";
 NetworkConnectivityValidator.NO_INTERNET_ERROR_CODE = "ENOTFOUND";
 NetworkConnectivityValidator.NO_INTERNET_ERROR_MESSAGE = "No internet connection. Check your internet settings and try again.";
 yok_1.injector.register("networkConnectivityValidator", NetworkConnectivityValidator);
+//# sourceMappingURL=network-connectivity-validator.js.map

package/lib/helpers/options-track-helper.js

@@ -11,7 +11,7 @@ class OptionsTracker {
     async trackOptions(options) {
         const trackObject = this.getTrackObject(options);
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Options",
+            action: "Options" /* TrackActionNames.Options */,
             additionalData: JSON.stringify(trackObject),
         });
     }
@@ -58,7 +58,7 @@ class OptionsTracker {
             return true;
         }
         const optionDef = options[key];
-        if (optionDef && optionDef.type === "boolean") {
+        if (optionDef && optionDef.type === "boolean" /* OptionType.Boolean */) {
             if ((optionDef.default !== true && value === false) ||
                 (optionDef.default === true && value === true)) {
                 return true;
@@ -75,3 +75,4 @@ OptionsTracker.PRIVATE_REPLACE_VALUE = "private";
 OptionsTracker.PATH_REPLACE_VALUE = "_localpath";
 OptionsTracker.SIZE_EXEEDED_REPLACE_VALUE = "sizeExceeded";
 yok_1.injector.register("optionsTracker", OptionsTracker);
+//# sourceMappingURL=options-track-helper.js.map

package/lib/helpers/package-path-helper.js

@@ -4,3 +4,4 @@ exports.resolvePackageJSONPath = exports.resolvePackagePath = void 0;
 const resolve_package_path_1 = require("@rigor789/resolve-package-path");
 Object.defineProperty(exports, "resolvePackagePath", { enumerable: true, get: function () { return resolve_package_path_1.resolvePackagePath; } });
 Object.defineProperty(exports, "resolvePackageJSONPath", { enumerable: true, get: function () { return resolve_package_path_1.resolvePackageJSONPath; } });
+//# sourceMappingURL=package-path-helper.js.map

package/lib/helpers/platform-command-helper.js

@@ -70,6 +70,10 @@ class PlatformCommandHelper {
                 const platformDir = path.join(projectData.platformsDir, platform.toLowerCase());
                 this.$fs.deleteDirectory(platformDir);
                 await this.$packageInstallationManager.uninstall(platformData.frameworkPackageName, projectData.projectDir);
+                // this.$projectDataService.removeNSProperty(
+                // 	projectData.projectDir,
+                // 	platformData.frameworkPackageName
+                // );
                 this.$logger.info(`Platform ${platform} successfully removed.`);
             }
             catch (err) {
@@ -108,7 +112,7 @@ class PlatformCommandHelper {
         const installedPlatforms = this.getInstalledPlatforms(projectData);
         return _.filter(this.$mobileHelper.platformNames, (p) => {
             return (installedPlatforms.indexOf(p) < 0 &&
-                this.$platformValidationService.isPlatformSupportedForOS(p, projectData));
+                this.$platformValidationService.isPlatformSupportedForOS(p, projectData)); // Only those not already installed
         });
     }
     getPreparedPlatforms(projectData) {
@@ -132,7 +136,7 @@ class PlatformCommandHelper {
             return true;
         }
         return (prepareInfo.nativePlatformStatus !==
-            "1");
+            "1" /* constants.NativePlatformStatus.requiresPlatformAdd */);
     }
     async updatePlatform(platform, version, projectData) {
         const platformData = this.$platformsDataService.getPlatformData(platform, projectData);
@@ -178,3 +182,4 @@ class PlatformCommandHelper {
 }
 exports.PlatformCommandHelper = PlatformCommandHelper;
 yok_1.injector.register("platformCommandHelper", PlatformCommandHelper);
+//# sourceMappingURL=platform-command-helper.js.map

package/lib/helpers/version-validator-helper.js

@@ -23,3 +23,4 @@ class VersionValidatorHelper {
     }
 }
 exports.VersionValidatorHelper = VersionValidatorHelper;
+//# sourceMappingURL=version-validator-helper.js.map

package/lib/key-commands/bootstrap.js

@@ -13,9 +13,10 @@ yok_1.injector.requireKeyCommand("R", path);
 yok_1.injector.requireKeyCommand("w", path);
 yok_1.injector.requireKeyCommand("c", path);
 yok_1.injector.requireKeyCommand("n", path);
-yok_1.injector.requireKeyCommand("?", path);
-yok_1.injector.requireKeyCommand("\u0003", path);
+yok_1.injector.requireKeyCommand("?" /* SpecialKeys.QuestionMark */, path);
+yok_1.injector.requireKeyCommand("\u0003" /* SpecialKeys.CtrlC */, path);
 yok_1.injector.requireCommand("open|ios", path);
 yok_1.injector.requireCommand("open|android", path);
 yok_1.injector.requireCommand("open|visionos", path);
 yok_1.injector.requireCommand("open|vision", path);
+//# sourceMappingURL=bootstrap.js.map

package/lib/key-commands/index.js

@@ -294,7 +294,7 @@ class ShiftR {
 exports.ShiftR = ShiftR;
 class CtrlC {
     constructor() {
-        this.key = "\u0003";
+        this.key = "\u0003" /* SpecialKeys.CtrlC */;
         this.platform = "all";
         this.group = "Development Workflow";
         this.willBlockKeyCommandExecution = false;
@@ -365,7 +365,7 @@ exports.N = N;
 class QuestionMark {
     constructor($keyCommandHelper) {
         this.$keyCommandHelper = $keyCommandHelper;
-        this.key = "?";
+        this.key = "?" /* SpecialKeys.QuestionMark */;
         this.platform = "all";
         this.description = "Show this help";
         this.group = "Development Workflow";
@@ -405,9 +405,10 @@ yok_1.injector.registerKeyCommand("w", W);
 yok_1.injector.registerKeyCommand("c", C);
 yok_1.injector.registerKeyCommand("A", ShiftA);
 yok_1.injector.registerKeyCommand("n", N);
-yok_1.injector.registerKeyCommand("?", QuestionMark);
-yok_1.injector.registerKeyCommand("\u0003", CtrlC);
+yok_1.injector.registerKeyCommand("?" /* SpecialKeys.QuestionMark */, QuestionMark);
+yok_1.injector.registerKeyCommand("\u0003" /* SpecialKeys.CtrlC */, CtrlC);
 yok_1.injector.registerCommand("open|ios", OpenIOSCommand);
 yok_1.injector.registerCommand("open|visionos", OpenVisionOSCommand);
 yok_1.injector.registerCommand("open|vision", OpenVisionOSCommand);
 yok_1.injector.registerCommand("open|android", OpenAndroidCommand);
+//# sourceMappingURL=index.js.map

package/lib/nativescript-cli-lib-bootstrap.js

@@ -3,6 +3,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const yok_1 = require("./common/yok");
 require("./bootstrap");
 yok_1.injector.overrideAlreadyRequiredModule = true;
+// Temporary!!! Should not require appbuilder's entry point of mobile-cli-lib,
+// but once we separate logics in mobile-cli-lib, we should be able to require only specific bootstrap.
+// Use this hack for now, as this will allow requiring {N} CLI as library directly and executing some device specific operations.
 yok_1.injector.requirePublicClass("deviceEmitter", "./common/mobile/device-emitter");
 yok_1.injector.requirePublicClass("deviceLogProvider", "./common/mobile/device-log-emitter");
 yok_1.injector.resolve("staticConfig").disableAnalytics = true;
+//# sourceMappingURL=nativescript-cli-lib-bootstrap.js.map

package/lib/nativescript-cli-lib.js

@@ -3,3 +3,4 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const yok_1 = require("./common/yok");
 require("./nativescript-cli-lib-bootstrap");
 module.exports = yok_1.injector.publicApi;
+//# sourceMappingURL=nativescript-cli-lib.js.map

package/lib/nativescript-cli.js

@@ -9,7 +9,7 @@ const errors_1 = require("./common/errors");
 const helpers_1 = require("./common/helpers");
 const yok_1 = require("./common/yok");
 const color_1 = require("./color");
-(0, errors_1.installUncaughtExceptionListener)(process.exit.bind(process, 120));
+(0, errors_1.installUncaughtExceptionListener)(process.exit.bind(process, 120 /* ErrorCodes.UNCAUGHT */));
 const logger = yok_1.injector.resolve("logger");
 exports.originalProcessOn = process.on.bind(process);
 process.on = (event, listener) => {
@@ -23,8 +23,10 @@ process.on = (event, listener) => {
         return (0, exports.originalProcessOn)(event, listener);
     }
 };
+/* tslint:disable:no-floating-promises */
 (async () => {
     if (process.argv.includes("--get-yargs-completions")) {
+        // This is a special case when we want to get the yargs completions as fast as possible...
         yok_1.injector.resolve("$options");
         return;
     }
@@ -41,6 +43,13 @@ process.on = (event, listener) => {
         logger.trace("Unable to load extensions. Error is: ", err);
     }
     const commandDispatcher = yok_1.injector.resolve("commandDispatcher");
+    // unused...
+    // const messages: IMessagesService = injector.resolve("$messagesService");
+    // messages.pathsToMessageJsonFiles = [
+    // 	/* Place client-specific json message file paths here */
+    // ];
     await commandDispatcher.dispatchCommand();
     yok_1.injector.dispose();
 })();
+/* tslint:enable:no-floating-promises */
+//# sourceMappingURL=nativescript-cli.js.map

package/lib/node/pbxproj-dom-xcode.js

@@ -3,3 +3,4 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const pbxprojDomXcodeModule = require("pbxproj-dom/xcode");
 const yok_1 = require("../common/yok");
 yok_1.injector.register("pbxprojDomXcode", pbxprojDomXcodeModule);
+//# sourceMappingURL=pbxproj-dom-xcode.js.map

package/lib/node/xcode.js

@@ -5,3 +5,4 @@ const xcode = require("nativescript-dev-xcode");
 exports.xcode = xcode;
 const yok_1 = require("../common/yok");
 yok_1.injector.register("xcode", xcode);
+//# sourceMappingURL=xcode.js.map

package/lib/node-package-manager.js

@@ -37,8 +37,12 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
         }
         params = params.concat(flags);
         const cwd = pathToSave;
+        // Npm creates `etc` directory in installation dir when --prefix is passed
+        // https://github.com/npm/npm/issues/11486
+        // we should delete it if it was created because of us
         const etcDirectoryLocation = (0, path_1.join)(cwd, "etc");
         const etcExistsPriorToInstallation = this.$fs.exists(etcDirectoryLocation);
+        //TODO: plamen5kov: workaround is here for a reason (remove whole file later)
         if (config.path) {
             let relativePathFromCwdToSource = "";
             if (config.frameworkPath) {
@@ -54,9 +58,13 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
         }
         catch (err) {
             if (err.message && err.message.indexOf("EPEERINVALID") !== -1) {
+                // Not installed peer dependencies are treated by npm 2 as errors, but npm 3 treats them as warnings.
+                // We'll show them as warnings and let the user install them in case they are needed.
                 this.$logger.warn(err.message);
             }
             else {
+                // All other errors should be handled by the caller code.
+                // Revert package.json contents to preserve valid state
                 this.$fs.writeJson(packageJsonPath, jsonContentBefore);
                 throw err;
             }
@@ -78,7 +86,7 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
         return this.$childProcess.exec(`npm search ${filter.join(" ")} ${flags}`);
     }
     async view(packageName, config) {
-        const wrappedConfig = _.extend({}, config, { json: true });
+        const wrappedConfig = _.extend({}, config, { json: true }); // always require view response as JSON
         const flags = this.getFlagsString(wrappedConfig, false);
         let viewResult;
         try {
@@ -95,6 +103,7 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
         }
     }
     async searchNpms(keyword) {
+        // TODO: Fix the generation of url - in case it contains @ or / , the call may fail.
         const httpRequestResult = await this.$httpClient.httpRequest(`https://api.npms.io/v2/search?q=keywords:${keyword}`);
         const result = JSON.parse(httpRequestResult.body);
         return result;
@@ -131,3 +140,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], NodePackageManager.prototype, "getCachePath", null);
 yok_1.injector.register("npm", NodePackageManager);
+//# sourceMappingURL=node-package-manager.js.map