nativescript 9.0.0-alpha.2 → 9.0.0-alpha.4

package/lib/services/ios-log-filter.js

@@ -5,8 +5,20 @@ const yok_1 = require("../common/yok");
 class IOSLogFilter {
     constructor($loggingLevels) {
         this.$loggingLevels = $loggingLevels;
+        // Used to recognize output related to the current project
+        // This looks for artifacts like: AppName[22432] or AppName(SomeTextHere)[23123]
         this.appOutputRegex = /([^\s\(\)]+)(?:\(([^\s]+)\))?\[[0-9]+\]/;
+        // Used to trim the passed messages to a simpler output
+        // Example:
+        // This: "May 24 15:54:52 Dragons-iPhone NativeScript250(NativeScript)[356] <Notice>: CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:3477:36: ORIGINAL STACKTRACE:"
+        // Becomes: CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:3477:36: ORIGINAL STACKTRACE:
         this.infoFilterRegex = new RegExp(`^.*(?:<Notice>:[ \t]?|<Error>:[ \t]?|<Warning>:[ \t]?|\\(NativeScript\\)[ \t]?|${this.appOutputRegex.source}:[ \t]?){1}`);
+        // Used to post filter messages that slip through but are not coming from NativeScript itself.
+        // Looks for text in parenthesis at the beginning
+        // Example:
+        // (RunningBoardServices) [com.apple.runningboard:connection] Identity resolved as application<...>
+        // ^(~~capture group~~~)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+        // we then use this to filter out non-NativeScript lines
         this.postFilterRegex = /^\((.+)\) \[com\.apple.+\]/;
         this.filterActive = true;
         this.partialLine = null;
@@ -29,11 +41,15 @@ class IOSLogFilter {
                 this.partialLine = currentLine;
                 break;
             }
+            // Legacy filter moved to preFilter
             if (this.preFilter(data, currentLine)) {
                 continue;
             }
             const matchResult = this.appOutputRegex.exec(currentLine);
             if (matchResult && matchResult.length > 1) {
+                // Check if the name of the app equals the name of the CLI project and turn on the filter if not.
+                // We call initializeProjectData in order to obtain the current project name as the instance
+                // of this filter may be used accross multiple projects.
                 const projectName = loggingOptions && loggingOptions.projectName;
                 this.filterActive = matchResult[1] !== projectName;
                 if (matchResult === null || matchResult === void 0 ? void 0 : matchResult[2]) {
@@ -48,8 +64,11 @@ class IOSLogFilter {
                 currentLine = currentLine.replace(filteredLineInfo[0], "");
             }
             currentLine = currentLine
+                // remove lading space before CONSOLE
                 .replace(/^\s*CONSOLE/, "CONSOLE")
+                // trim trailing spaces only to preserve indentation
                 .trimEnd();
+            // post filtering: (<anything>) check if <anything> is not "NativeScript"
             const postFilterMatch = this.postFilterRegex.exec(currentLine);
             if (postFilterMatch && (postFilterMatch === null || postFilterMatch === void 0 ? void 0 : postFilterMatch[1]) !== "NativeScript") {
                 continue;
@@ -68,3 +87,4 @@ class IOSLogFilter {
 }
 exports.IOSLogFilter = IOSLogFilter;
 yok_1.injector.register("iOSLogFilter", IOSLogFilter);
+//# sourceMappingURL=ios-log-filter.js.map

package/lib/services/ios-native-target-service.js

@@ -58,8 +58,8 @@ class IOSNativeTargetService {
     setXcodeTargetBuildConfigurationProperties(properties, targetName, project) {
         properties.forEach((property) => {
             const buildNames = property.buildNames || [
-                "Debug",
-                "Release",
+                "Debug" /* BuildNames.debug */,
+                "Release" /* BuildNames.release */,
             ];
             buildNames.forEach((buildName) => {
                 project.addBuildProperty(property.name, property.value, buildName, targetName);
@@ -76,6 +76,7 @@ class IOSNativeTargetService {
                 project.addToBuildSettings("ASSETCATALOG_COMPILER_APPICON_NAME", configurationJson.assetcatalogCompilerAppiconName, targetUuid);
             }
             const properties = [];
+            // Set for both release and debug
             if (configurationJson.targetBuildConfigurationProperties) {
                 _.forEach(configurationJson.targetBuildConfigurationProperties, (value, name) => properties.push({ value, name }));
             }
@@ -84,11 +85,11 @@ class IOSNativeTargetService {
                     var buildName = null;
                     switch (name) {
                         case "debug": {
-                            buildName = "Debug";
+                            buildName = "Debug" /* BuildNames.debug */;
                             break;
                         }
                         case "release": {
-                            buildName = "Release";
+                            buildName = "Release" /* BuildNames.release */;
                             break;
                         }
                         default: {
@@ -106,3 +107,4 @@ class IOSNativeTargetService {
 }
 exports.IOSNativeTargetService = IOSNativeTargetService;
 yok_1.injector.register("iOSNativeTargetService", IOSNativeTargetService);
+//# sourceMappingURL=ios-native-target-service.js.map

package/lib/services/ios-project-service.js

@@ -138,7 +138,7 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                     ".ico",
                     ".cur",
                     ".xbm",
-                ],
+                ], // https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIImage_Class/
             };
         }
         return this._platformData;
@@ -185,8 +185,11 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
         this.$fs.ensureDirectoryExists(path.join(this.getPlatformData(projectData).projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER));
         shell.cp("-R", path.join(frameworkDir, "*"), this.getPlatformData(projectData).projectRoot);
     }
+    //TODO: plamen5kov: revisit this method, might have unnecessary/obsolete logic
     async interpolateData(projectData) {
         const projectRootFilePath = path.join(this.getPlatformData(projectData).projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER);
+        // Starting with NativeScript for iOS 1.6.0, the project Info.plist file resides not in the platform project,
+        // but in the hello-world app template as a platform specific resource.
         if (this.$fs.exists(path.join(projectRootFilePath, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER + "-Info.plist"))) {
             this.replaceFileName("-Info.plist", projectRootFilePath, projectData);
         }
@@ -289,16 +292,32 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
             frameworkAddOptions["sign"] = true;
         }
         if (this.$options.hostProjectPath) {
+            // always mark xcframeworks for embedding
             frameworkAddOptions["embed"] = true;
             frameworkAddOptions["sign"] = false;
         }
+        // Note: we used to prepend "$(SRCROOT)/" to the framework path, but seems like it's not needed anymore
+        // "$(SRCROOT)/" +
         const frameworkRelativePath = this.getLibSubpathRelativeToProjectPath(frameworkPath, projectData);
         project.addFramework(frameworkRelativePath, frameworkAddOptions);
+        // filePathsArray, buildPhaseType, comment, target, optionsOrFolderType, subfolderPath
+        // project.addBuildPhase(
+        // 	[],
+        // 	"PBXShellScriptBuildPhase",
+        // 	"Debug SRCROOT",
+        // 	undefined,
+        // 	{
+        // 		shellPath: "/bin/sh",
+        // 		shellScript: `echo "SRCROOT: $SRCROOT"`,
+        // 	}
+        // );
         this.savePbxProj(project, projectData);
     }
     async addStaticLibrary(staticLibPath, projectData) {
+        // Copy files to lib folder.
         const libraryName = path.basename(staticLibPath, ".a");
         const headersSubpath = path.join(path.dirname(staticLibPath), "include", libraryName);
+        // Add static library to project file and setup header search paths
         const project = this.createPbxProj(projectData);
         const relativeStaticLibPath = this.getLibSubpathRelativeToProjectPath(staticLibPath, projectData);
         project.addFramework(relativeStaticLibPath);
@@ -333,10 +352,58 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                     filesRelativeToProject: true,
                     uuid: "NATIVESCRIPTNATIVESCRIPT",
                 });
+                /**
+                 * 1. Add platforms/ios/{projectname}/app build to the host app
+                 */
+                // Note: allow customization of this targetFolderName
+                // const targetFolderName = "app";
                 const buildFolderPath = path.join(this.$options.hostProjectPath, projectData.projectName);
                 project.addResourceFile(buildFolderPath, {}, "NATIVESCRIPTNATIVESCRIPT");
+                // filePathsArray, buildPhaseType, comment, target, optionsOrFolderType, subfolderPath
+                // project.addBuildPhase(
+                // 	[],
+                // 	"PBXShellScriptBuildPhase",
+                // 	"Copy Metadata (DEBUG)",
+                // 	undefined,
+                // 	{
+                // 		shellPath: "/bin/sh",
+                // 		shellScript: `cp ./platforms/ios/build/Debug-iphonesimulator/metadata-arm64.bin $CONFIGURATION_BUILD_DIR`,
+                // 		outputPaths: [
+                // 			JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-arm64.bin"),
+                // 			// JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-arm64e.bin"),
+                // 			// JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-i386.bin"),
+                // 			// JSON.stringify("$(CONFIGURATION_BUILD_DIR)/metadata-x86_64.bin"),
+                // 		],
+                // 	}
+                // );
                 const metadataPath = path.relative(this.$options.hostProjectPath, buildFolderPath);
                 project.addToOtherLinkerFlags(JSON.stringify(`-sectcreate __DATA __TNSMetadata "${metadataPath}/metadata-arm64.bin"`));
+                // // no shorthand way to get UUID of build phase that i can tell
+                // // methods return the phase as an object but ommitted the actual key (uuid we need)
+                // // this does it same way nativescript-dev-xcode does but gets the uuid we need
+                // const resourcesBuildPhaseKeys = Object.keys(
+                // 	project.hash.project.objects["PBXResourcesBuildPhase"]
+                // );
+                // // console.log('resourcesBuildPhaseKeys:', resourcesBuildPhaseKeys);
+                // const buildPhaseUUID = resourcesBuildPhaseKeys[0];
+                // const comment = `${targetFolderName} in Resources`;
+                // project.hash.project.objects["PBXResourcesBuildPhase"][
+                // 	buildPhaseUUID
+                // ].files.forEach((f: any) => {
+                // 	console.log(f);
+                // });
+                // if (
+                // 	!project.hash.project.objects["PBXResourcesBuildPhase"][
+                // 		buildPhaseUUID
+                // 	].files.find((f: any) => f.comment === comment)
+                // ) {
+                // 	project.addResourceFile(buildFolderPath, {}, buildPhaseUUID);
+                // }
+                /**
+                 * 2. Ensure metadata is copied as a file
+                 * 		The apps metadata-{arch}.bin should be added as a file reference.
+                 */
+                // TODO
                 this.savePbxProj(project, projectData);
             }
             catch (err) {
@@ -389,10 +456,12 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
         this.$fs.deleteDirectory(platformsAppResourcesPath);
         this.$fs.ensureDirectoryExists(platformsAppResourcesPath);
         const platformAppResourcesPath = path.join(projectAppResourcesPath, platformData.normalizedPlatformName);
+        // this allows App_Resources/visionOS
         if (this.$fs.exists(platformAppResourcesPath)) {
             this.$fs.copyFile(path.join(platformAppResourcesPath, "*"), platformsAppResourcesPath);
         }
         else {
+            // otherwise falls back to App_Resources/iOS
             this.$fs.copyFile(path.join(projectAppResourcesPath, this.$devicePlatformsConstants.iOS, "*"), platformsAppResourcesPath);
         }
         this.$fs.deleteFile(path.join(platformsAppResourcesPath, platformData.configurationFileName));
@@ -491,6 +560,12 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
     getLibSubpathRelativeToProjectPath(targetPath, projectData) {
         const projectRoot = this.getPlatformData(projectData).projectRoot;
         const frameworkPath = path.relative(projectRoot, targetPath);
+        // console.log({
+        // 	targetPath,
+        // 	projectRoot,
+        // 	frameworkPath,
+        // 	resolved: path.resolve(projectRoot, frameworkPath),
+        // });
         return frameworkPath;
     }
     getPbxProjPath(projectData) {
@@ -538,6 +613,10 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
         const projectPodfilePath = this.$cocoapodsService.getProjectPodfilePath(platformData.projectRoot);
         if (this.$fs.exists(projectPodfilePath)) {
             await this.$cocoapodsService.executePodInstall(platformData.projectRoot, this.$xcprojService.getXcodeprojPath(projectData, platformData.projectRoot));
+            // The `pod install` command adds a new target to the .pbxproject. This target adds additional build phases to Xcode project.
+            // Some of these phases relies on env variables (like PODS_PODFILE_DIR_PATH or PODS_ROOT).
+            // These variables are produced from merge of pod's xcconfig file and project's xcconfig file.
+            // So the correct order is `pod install` to be executed before merging pod's xcconfig file.
             await this.$cocoapodsService.mergePodXcconfigFile(projectData, platformData, opts);
         }
         const pluginSpmPackages = [];
@@ -563,6 +642,7 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
         const hasProvision = provision !== undefined;
         const hasTeamId = teamId !== undefined;
         if (hasProvision || hasTeamId) {
+            // Check if the native project's signing is set to the provided provision...
             const pbxprojPath = this.getPbxProjPath(projectData);
             if (this.$fs.exists(pbxprojPath)) {
                 const xcode = this.$pbxprojDomXcode.Xcode.open(pbxprojPath);
@@ -578,6 +658,9 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                         }
                     }
                     else {
+                        // Specifying provisioning profile requires "Manual" signing style.
+                        // If the current signing style was not "Manual" it was probably "Automatic" or,
+                        // it was not uniform for the debug and release build configurations.
                         changesInfo.signingChanged = true;
                     }
                 }
@@ -591,6 +674,8 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
                         }
                     }
                     else {
+                        // Specifying team id or name requires "Automatic" signing style.
+                        // If the current signing style was not "Automatic" it was probably "Manual".
                         changesInfo.signingChanged = true;
                     }
                 }
@@ -807,10 +892,14 @@ class IOSProjectService extends projectServiceBaseLib.PlatformProjectServiceBase
         }
         for (const pluginsXcconfigFilePath of pluginsXcconfigFilePaths) {
             if (!this.$fs.exists(pluginsXcconfigFilePath)) {
+                // We need the pluginsXcconfig file to exist in platforms dir as it is required in the native template:
+                // https://github.com/NativeScript/ios-runtime/blob/9c2b7b5f70b9bee8452b7a24aa6b646214c7d2be/build/project-template/__PROJECT_NAME__/build-debug.xcconfig#L3
+                // From Xcode 10 in case the file is missing, this include fails and the build itself fails (was a warning in previous Xcode versions).
                 this.$fs.writeFile(pluginsXcconfigFilePath, "");
             }
         }
         for (const pluginsXcconfigFilePath of pluginsXcconfigFilePaths) {
+            // Set Entitlements Property to point to default file if not set explicitly by the user.
             const entitlementsPropertyValue = this.$xcconfigService.readPropertyValue(pluginsXcconfigFilePath, constants.CODE_SIGN_ENTITLEMENTS);
             if (entitlementsPropertyValue === null &&
                 this.$fs.exists(this.$iOSEntitlementsService.getPlatformsEntitlementsPath(projectData))) {
@@ -855,3 +944,4 @@ __decorate([
     (0, helpers_2.hook)("buildIOS")
 ], IOSProjectService.prototype, "buildProject", null);
 yok_1.injector.register("iOSProjectService", IOSProjectService);
+//# sourceMappingURL=ios-project-service.js.map

package/lib/services/ios-provision-service.js

@@ -127,6 +127,8 @@ class IOSProvisionService {
     }
     async getDevelopmentTeams() {
         const teams = {};
+        // NOTE: We are reading all provisioning profiles and collect team information from them.
+        // It would be better if we can check the Apple ID registered in Xcode and read the teams associated with it.
         mobileprovision.provision.read().forEach((provision) => provision.TeamIdentifier &&
             provision.TeamIdentifier.forEach((id) => {
                 if (!teams[provision.TeamName]) {
@@ -150,3 +152,4 @@ class IOSProvisionService {
 }
 exports.IOSProvisionService = IOSProvisionService;
 yok_1.injector.register("iOSProvisionService", IOSProvisionService);
+//# sourceMappingURL=ios-provision-service.js.map

package/lib/services/ios-watch-app-service.js

@@ -63,3 +63,4 @@ exports.IOSWatchAppService = IOSWatchAppService;
 IOSWatchAppService.WATCH_APP_IDENTIFIER = "watchkitapp";
 IOSWatchAppService.WACTCH_EXTENSION_IDENTIFIER = "watchkitextension";
 yok_1.injector.register("iOSWatchAppService", IOSWatchAppService);
+//# sourceMappingURL=ios-watch-app-service.js.map

package/lib/services/ip-service.js

@@ -38,6 +38,7 @@ class IPService {
         return ipAddress;
     }
     async getIPAddressFromIpifyOrgAPI() {
+        // https://www.ipify.org/
         const ipifyOrgAPIEndpoint = "https://api.ipify.org";
         let ipAddress = null;
         try {
@@ -61,3 +62,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], IPService.prototype, "getCurrentIPv4Address", null);
 yok_1.injector.register("ipService", IPService);
+//# sourceMappingURL=ip-service.js.map

package/lib/services/itmstransporter-service.js

@@ -191,3 +191,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], ITMSTransporterService.prototype, "getITMSTransporterPath", null);
 yok_1.injector.register("itmsTransporterService", ITMSTransporterService);
+//# sourceMappingURL=itmstransporter-service.js.map

package/lib/services/karma-execution.js

@@ -9,8 +9,10 @@ process.on("message", (data) => {
         });
         const KarmaServer = require(path.join(pathToKarma, "lib/server"));
         const karma = new KarmaServer(data.karmaConfig, (exitCode) => {
+            // Exit with the correct exit code and signal the manager process.
             process.exit(exitCode);
         });
         karma.start();
     }
 });
+//# sourceMappingURL=karma-execution.js.map

package/lib/services/livesync/android-device-livesync-service-base.js

@@ -49,3 +49,4 @@ class AndroidDeviceLiveSyncServiceBase extends device_livesync_service_base_1.De
     }
 }
 exports.AndroidDeviceLiveSyncServiceBase = AndroidDeviceLiveSyncServiceBase;
+//# sourceMappingURL=android-device-livesync-service-base.js.map

package/lib/services/livesync/android-device-livesync-service.js

@@ -97,6 +97,7 @@ class AndroidDeviceLiveSyncService extends android_device_livesync_service_base_
         ]);
         const regex = new RegExp(`^-.*${deviceRootBasename}$`, "m");
         const matchingFile = (listResult || "").match(regex);
+        // Check if there is already a file with deviceRootBasename. If so, delete it as it breaks LiveSyncing.
         if (matchingFile && matchingFile[0] && _.startsWith(matchingFile[0], "-")) {
             await this.device.adb.executeShellCommand(["rm", "-f", deviceRootPath]);
         }
@@ -172,3 +173,4 @@ __decorate([
 __decorate([
     (0, decorators_1.performanceLog)()
 ], AndroidDeviceLiveSyncService.prototype, "removeFiles", null);
+//# sourceMappingURL=android-device-livesync-service.js.map

package/lib/services/livesync/android-device-livesync-sockets-service.js

@@ -95,6 +95,8 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
                 await this.$cleanupService.removeCleanupCommand(cleanupCommand);
             };
             await this.$cleanupService.addCleanupCommand(cleanupCommand);
+            // We need to clear resources when the action fails
+            // But we also need the real result of the action.
             await doSyncPromise.then(actionOnEnd.bind(this), actionOnEnd.bind(this));
             result = await doSyncPromise;
         }
@@ -164,3 +166,4 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
 exports.AndroidDeviceSocketsLiveSyncService = AndroidDeviceSocketsLiveSyncService;
 AndroidDeviceSocketsLiveSyncService.STATUS_UPDATE_INTERVAL = 10000;
 AndroidDeviceSocketsLiveSyncService.MINIMAL_VERSION_LONG_LIVING_CONNECTION = "0.2.0";
+//# sourceMappingURL=android-device-livesync-sockets-service.js.map

package/lib/services/livesync/android-livesync-service.js

@@ -53,3 +53,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], AndroidLiveSyncService.prototype, "fullSync", null);
 yok_1.injector.register("androidLiveSyncService", AndroidLiveSyncService);
+//# sourceMappingURL=android-livesync-service.js.map

package/lib/services/livesync/android-livesync-tool.js

@@ -140,9 +140,12 @@ class AndroidLivesyncTool {
             error =
                 error ||
                     this.getErrorWithMessage("Socket connection ended before sync operation is complete.");
+            //remove listeners and delete this.socketConnection
             this.cleanState(socketUid);
+            //call end of the connection (close and error callbacks won't be called - listeners removed)
             socket.end();
             socket.destroy();
+            //reject all pending sync requests and clear timeouts
             this.rejectPendingSyncOperations(socketUid, error);
         }
     }
@@ -402,3 +405,4 @@ AndroidLivesyncTool.SOCKET_CONNECTION_ALREADY_EXISTS_ERROR = "Socket connection
 AndroidLivesyncTool.SOCKET_CONNECTION_TIMED_OUT_ERROR = "Socket connection timed out.";
 AndroidLivesyncTool.NO_SOCKET_CONNECTION_AVAILABLE_ERROR = "No socket connection available.";
 yok_1.injector.register("androidLivesyncTool", AndroidLivesyncTool);
+//# sourceMappingURL=android-livesync-tool.js.map

package/lib/services/livesync/device-livesync-service-base.js

@@ -40,6 +40,7 @@ class DeviceLiveSyncServiceBase {
         return transferredFiles;
     }
     async finalizeSync(liveSyncInfo, projectData) {
+        //implement in case a sync point for all remove/create operation is needed
         return {
             didRefresh: true,
             operationId: "",
@@ -54,3 +55,4 @@ __decorate([
 __decorate([
     (0, decorators_2.performanceLog)()
 ], DeviceLiveSyncServiceBase.prototype, "transferFiles", null);
+//# sourceMappingURL=device-livesync-service-base.js.map

package/lib/services/livesync/ios-device-livesync-service.js

@@ -37,11 +37,13 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
         return canRefresh;
     }
     async setupSocketIfNeeded(projectData) {
+        // TODO: persist the sockets per app in order to support LiveSync on multiple apps on the same device
         if (this.socket) {
             return true;
         }
         const appId = projectData.projectIdentifiers.ios;
         try {
+            // TODO: temp workaround till we setup the sockets along with the app start
             const ensureAppStarted = true;
             this.socket = await this.device.getDebugSocket(appId, projectData.projectName, projectData.projectDir, ensureAppStarted);
         }
@@ -121,6 +123,7 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
             projectDir: projectData.projectDir,
         });
         if (liveSyncInfo.useHotModuleReload) {
+            // enable HOT updates
             await this.setupSocketIfNeeded(projectData);
         }
     }
@@ -177,6 +180,9 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
     }
     async destroySocket() {
         if (this.socket) {
+            // we do not support LiveSync on multiple apps on the same device
+            // in order to do that, we should cache the socket per app
+            // and destroy just the current app socket when possible
             await this.device.destroyAllSockets();
             this.socket = null;
         }
@@ -187,3 +193,4 @@ IOSDeviceLiveSyncService.MIN_RUNTIME_VERSION_WITH_REFRESH_NOTIFICATION = "6.1.0"
 __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSDeviceLiveSyncService.prototype, "removeFiles", null);
+//# sourceMappingURL=ios-device-livesync-service.js.map

package/lib/services/livesync/ios-livesync-service.js

@@ -58,6 +58,7 @@ class IOSLiveSyncService extends platform_livesync_service_base_1.PlatformLiveSy
     }
     async syncAfterInstall(device, liveSyncInfo) {
         if (!device.isEmulator) {
+            // In this case we should execute fullsync because iOS Runtime requires the full content of app dir to be extracted in the root of sync dir.
             await this.fullSync({
                 projectData: liveSyncInfo.projectData,
                 device,
@@ -77,3 +78,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSLiveSyncService.prototype, "fullSync", null);
 yok_1.injector.register("iOSLiveSyncService", IOSLiveSyncService);
+//# sourceMappingURL=ios-livesync-service.js.map

package/lib/services/livesync/livesync-socket.js

@@ -12,3 +12,4 @@ class LiveSyncSocket extends net.Socket {
 }
 exports.LiveSyncSocket = LiveSyncSocket;
 yok_1.injector.register("LiveSyncSocket", LiveSyncSocket, false);
+//# sourceMappingURL=livesync-socket.js.map

package/lib/services/livesync/platform-livesync-service-base.js

@@ -40,6 +40,7 @@ class PlatformLiveSyncServiceBase {
         return shouldRestart;
     }
     async syncAfterInstall(device, liveSyncInfo) {
+        /* intentionally left blank */
     }
     async restartApplication(projectData, liveSyncInfo) {
         const deviceLiveSyncService = this.getDeviceLiveSyncService(liveSyncInfo.deviceAppData.device, projectData);
@@ -85,6 +86,8 @@ class PlatformLiveSyncServiceBase {
         let modifiedLocalToDevicePaths = [];
         if (liveSyncInfo.filesToSync.length) {
             const filesToSync = liveSyncInfo.filesToSync;
+            // const mappedFiles = _.map(filesToSync, filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData));
+            // Some plugins modify platforms dir on afterPrepare (check nativescript-dev-sass) - we want to sync only existing file.
             const existingFiles = filesToSync.filter((m) => m && this.$fs.exists(m));
             this.$logger.trace("Will execute livesync for files: ", existingFiles);
             const skippedFiles = _.difference(filesToSync, existingFiles);
@@ -103,6 +106,7 @@ class PlatformLiveSyncServiceBase {
             const filePaths = liveSyncInfo.filesToRemove;
             const platformData = this.$platformsDataService.getPlatformData(device.deviceInfo.platform, projectData);
             const mappedFiles = _(filePaths)
+                // .map(filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData))
                 .filter((filePath) => !!filePath)
                 .value();
             const projectFilesPath = path.join(platformData.appDestinationDirectoryPath, constants_1.APP_FOLDER_NAME);
@@ -154,3 +158,4 @@ exports.PlatformLiveSyncServiceBase = PlatformLiveSyncServiceBase;
 __decorate([
     (0, decorators_1.performanceLog)()
 ], PlatformLiveSyncServiceBase.prototype, "liveSyncWatchAction", null);
+//# sourceMappingURL=platform-livesync-service-base.js.map

package/lib/services/livesync-process-data-service.js

@@ -41,3 +41,4 @@ class LiveSyncProcessDataService {
 }
 exports.LiveSyncProcessDataService = LiveSyncProcessDataService;
 yok_1.injector.register("liveSyncProcessDataService", LiveSyncProcessDataService);
+//# sourceMappingURL=livesync-process-data-service.js.map

package/lib/services/log-parser-service.js

@@ -50,3 +50,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], LogParserService.prototype, "startParsingLogCore", null);
 yok_1.injector.register("logParserService", LogParserService);
+//# sourceMappingURL=log-parser-service.js.map

package/lib/services/log-source-map-service.js

@@ -31,6 +31,7 @@ class LogSourceMapService {
             if (!this.$fs.getFsStats(filePath).isDirectory()) {
                 const mapFile = filePath + ".map";
                 let sourceMapRaw;
+                // Skip files bigger than 50MB
                 if (this.$fs.getFileSize(filePath) > 50 * 1000 * 1000) {
                     this.$logger.trace(`Skipping source map for file ${filePath} because it is too big (> 50MB).`);
                     return;
@@ -155,6 +156,8 @@ class LogSourceMapService {
         }
     }
     parseAndroidLog(projectData, rawMessage) {
+        // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap (file:///data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
+        // "System.err: File: "file:///data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         const deviceProjectPath = util.format(constants_1.ANDROID_DEVICE_APP_ROOT_TEMPLATE, projectData.projectIdentifiers.android);
         let separator = ",";
@@ -162,18 +165,25 @@ class LogSourceMapService {
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
+            //"data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
             parts = fileSubstring.split(separator);
             if (parts.length >= 3) {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js"
                 parts[0] = parts[0].replace("'", "");
+                // " line: 304"
                 parts[1] = parts[1].replace(" line: ", "");
+                // " column: 8"
                 parts[2] = parts[2].replace(" column: ", "");
             }
             else {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
                 separator = ":";
                 parts = fileSubstring.split(separator);
             }
             if (parts.length >= 3) {
+                // "/data/data/org.nativescript.sourceMap/files/app/"
                 const devicePath = `${deviceProjectPath}/${constants_1.APP_FOLDER_NAME}/`;
+                // "bundle.js"
                 filePath = path.relative(devicePath, `${"/"}${parts[0]}`);
                 line = parseInt(parts[1]);
                 column = parseInt(parts[2]);
@@ -181,20 +191,24 @@ class LogSourceMapService {
                 for (let i = 3; i < parts.length; i++) {
                     messageSuffix += `${parts[i]}${i === parts.length - 1 ? "" : separator}`;
                 }
+                // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap ("
                 messagePrefix = _.trimEnd(messagePrefix, "(");
             }
         }
         return { filePath, line, column, messagePrefix, messageSuffix };
     }
     parseIosLog(rawMessage) {
+        // "CONSOLE INFO file:///app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         let messageSuffix = "";
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
+            // "app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
             parts = fileSubstring.split(":");
             if (parts && parts.length >= 3) {
                 filePath = parts[0];
+                // "app/vendor.js"
                 if (_.startsWith(filePath, constants_1.APP_FOLDER_NAME)) {
                     filePath = path.relative(constants_1.APP_FOLDER_NAME, parts[0]);
                 }
@@ -223,3 +237,4 @@ LogSourceMapService.FILE_PREFIX = "file:///";
 LogSourceMapService.FILE_PREFIX_REPLACEMENT = "file: ";
 LogSourceMapService.MEMOIZE_FUNCTION_RANDOM_KEY_FOR_JOIN = "__some_random_value__";
 yok_1.injector.register("logSourceMapService", LogSourceMapService);
+//# sourceMappingURL=log-source-map-service.js.map

package/lib/services/marking-mode-service.js

@@ -6,7 +6,7 @@ const constants_1 = require("../constants");
 const yok_1 = require("../common/yok");
 const semver = require("semver/preload");
 const MARKING_MODE_PROP = "markingMode";
-const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full"}" is no longer supported.`;
+const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}" is no longer supported.`;
 class MarkingModeService {
     constructor($logger, $projectConfigService, $projectHelper, $projectDataService) {
         this.$logger = $logger;
@@ -18,11 +18,13 @@ class MarkingModeService {
         const markingModeValue = this.$projectConfigService.getValue("android.markingMode");
         const { skipWarnings, forceSwitch } = options;
         if (forceSwitch) {
-            await this.setMarkingMode("none");
+            await this.setMarkingMode("none" /* MarkingMode.None */);
             return;
         }
-        if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none") {
-            const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android");
+        if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none" /* MarkingMode.None */) {
+            // only warn if runtime is less than 7.0.0-rc.5 - where the default has been changed to None
+            // if version is null - we are about to add the latest runtime, so no need to warn
+            const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android" /* PlatformTypes.android */);
             const isMarkingModeFullDefault = version && semver.lt(semver.coerce(version), "7.0.0-rc.5");
             if (isMarkingModeFullDefault) {
                 this.showMarkingModeFullWarning();
@@ -33,7 +35,7 @@ class MarkingModeService {
         await this.$projectConfigService.setValue("android.markingMode", newMode);
     }
     showMarkingModeFullWarning() {
-        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full"}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
+        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
         this.$logger.warn(markingModeFullWarning, {
             [constants_1.LoggerConfigData.wrapMessageWithBorders]: true,
         });
@@ -41,3 +43,4 @@ class MarkingModeService {
 }
 exports.MarkingModeService = MarkingModeService;
 yok_1.injector.register("markingModeService", MarkingModeService);
+//# sourceMappingURL=marking-mode-service.js.map

package/lib/services/metadata-filtering-service.js

@@ -103,3 +103,4 @@ class MetadataFilteringService {
 }
 exports.MetadataFilteringService = MetadataFilteringService;
 yok_1.injector.register("metadataFilteringService", MetadataFilteringService);
+//# sourceMappingURL=metadata-filtering-service.js.map