nativescript 9.0.0-alpha.2 → 9.0.0-alpha.4

package/lib/common/mobile/android/logcat-helper.js

@@ -40,6 +40,7 @@ class LogcatHelper {
                     }
                 }
                 catch (err) {
+                    // Ignore the error, the process is dead.
                 }
             });
             lineStream.on("data", (lineBuffer) => {
@@ -60,6 +61,7 @@ class LogcatHelper {
                     return;
                 const lines = (lineBuffer.toString() || "").split("\n");
                 for (let line of lines) {
+                    // 2024-06-26 16:43:22.286   630-659   ActivityManager system_server I  Start proc 8854:org.nativescript.uitestsapp/u0a190 for next-top-activity {org.nativescript.uitestsapp/com.tns.NativeScriptActivity}
                     const startProc = /Start proc (?<pid>[0-9]+):(?<appId>.+?)\//.exec(line);
                     if (startProc &&
                         ((_b = startProc.groups) === null || _b === void 0 ? void 0 : _b.appId) === options.appId &&
@@ -86,6 +88,9 @@ class LogcatHelper {
             lineStream.removeAllListeners();
         });
     }
+    /**
+     * Stops the logcat process for the specified device if keepSingleProcess is not passed on start
+     */
     stop(deviceIdentifier) {
         if (this.mapDevicesLoggingData[deviceIdentifier] &&
             !this.mapDevicesLoggingData[deviceIdentifier].keepSingleProcess) {
@@ -102,6 +107,9 @@ class LogcatHelper {
         (_e = loggingData.lineStream) === null || _e === void 0 ? void 0 : _e.removeAllListeners();
         delete this.mapDevicesLoggingData[deviceIdentifier];
     }
+    /**
+     * @deprecated - we likely don't need this anymore, and can simplify the code...
+     */
     async isLogcatPidSupported(deviceIdentifier) {
         const device = await this.$devicesService.getDevice(deviceIdentifier);
         const minAndroidWithLogcatPidSupport = "7.0.0";
@@ -111,6 +119,7 @@ class LogcatHelper {
     async getLogcatStream(deviceIdentifier, pid) {
         const isLogcatPidSupported = await this.isLogcatPidSupported(deviceIdentifier);
         const adb = this.$injector.resolve(device_android_debug_bridge_1.DeviceAndroidDebugBridge, { identifier: deviceIdentifier });
+        // -T 1 - shows only new logs after starting adb logcat
         const logcatCommand = ["logcat", "-T", "1"];
         const acceptedTags = [
             "chromium",
@@ -123,6 +132,7 @@ class LogcatHelper {
         if (pid && isLogcatPidSupported) {
             logcatCommand.push(`--pid=${pid}`);
             acceptedTags.forEach((tag) => {
+                // -s <tag> - shows only logs with the specified tag
                 logcatCommand.push("-s", tag);
             });
         }
@@ -133,6 +143,8 @@ class LogcatHelper {
     }
     async getAppStartTrackingLogcatStream(deviceIdentifier, appId) {
         const adb = this.$injector.resolve(device_android_debug_bridge_1.DeviceAndroidDebugBridge, { identifier: deviceIdentifier });
+        // -b system  - shows the system buffer/logs only
+        // -T 1 			- shows only new logs after starting adb logcat
         const logcatCommand = [
             `logcat`,
             `-b`,
@@ -153,3 +165,4 @@ class LogcatHelper {
 }
 exports.LogcatHelper = LogcatHelper;
 yok_1.injector.register("logcatHelper", LogcatHelper);
+//# sourceMappingURL=logcat-helper.js.map

package/lib/common/mobile/application-manager-base.js

@@ -36,6 +36,9 @@ class ApplicationManagerBase extends events_1.EventEmitter {
         if (!this.checkForApplicationUpdatesPromise) {
             this.checkForApplicationUpdatesPromise = new Promise(async (resolve, reject) => {
                 let isFulfilled = false;
+                // As this method is called on 500ms, but it's execution may last much longer
+                // use locking, so the next executions will not get into the body, while the first one is still working.
+                // In case we do not break the next executions, we'll report each app as newly installed several times.
                 try {
                     const currentlyInstalledAppIdentifiers = await this.getInstalledApplications();
                     const previouslyInstalledAppIdentifiers = this.lastInstalledAppIdentifiers || [];
@@ -80,6 +83,7 @@ class ApplicationManagerBase extends events_1.EventEmitter {
         _.each(notAvailableAppsForDebugging, (appInfo) => {
             this.emit("debuggableAppLost", appInfo);
             if (_.has(this.lastAvailableDebuggableAppViews, appInfo.appIdentifier)) {
+                // Prevent emitting debuggableViewLost when application cannot be debugged anymore.
                 delete this.lastAvailableDebuggableAppViews[appInfo.appIdentifier];
             }
         });
@@ -98,6 +102,7 @@ class ApplicationManagerBase extends events_1.EventEmitter {
             _.each(newAvailableViews, (debugWebViewInfo) => {
                 this.emit("debuggableViewFound", appIdentifier, debugWebViewInfo);
             });
+            // Determine which of the views had changed since last check and raise debuggableViewChanged event for them:
             const keptViews = _.differenceBy(currentlyAvailableViews, newAvailableViews, "id");
             _.each(keptViews, (view) => {
                 const previousTimeViewInfo = _.find(previouslyAvailableViews, (previousView) => previousView.id === view.id);
@@ -111,3 +116,4 @@ class ApplicationManagerBase extends events_1.EventEmitter {
     }
 }
 exports.ApplicationManagerBase = ApplicationManagerBase;
+//# sourceMappingURL=application-manager-base.js.map

package/lib/common/mobile/device-emitter.js

@@ -15,7 +15,10 @@ class DeviceEmitter extends events_1.EventEmitter {
         this.$devicesService.on(constants_1.DeviceDiscoveryEventNames.DEVICE_FOUND, (device) => {
             this.emit(constants_1.DeviceDiscoveryEventNames.DEVICE_FOUND, device.deviceInfo);
             this.attachApplicationChangedHandlers(device);
+            // await: Do not await as this will require to mark the lambda with async keyword, but there's no way to await the lambda itself.
+            /* tslint:disable:no-floating-promises */
             device.openDeviceLogStream();
+            /* tslint:enable:no-floating-promises */
         });
         this.$devicesService.on(constants_1.DeviceDiscoveryEventNames.DEVICE_LOST, (device) => {
             this.emit(constants_1.DeviceDiscoveryEventNames.DEVICE_LOST, device.deviceInfo);
@@ -59,3 +62,4 @@ class DeviceEmitter extends events_1.EventEmitter {
 }
 exports.DeviceEmitter = DeviceEmitter;
 yok_1.injector.register("deviceEmitter", DeviceEmitter);
+//# sourceMappingURL=device-emitter.js.map

package/lib/common/mobile/device-log-emitter.js

@@ -38,3 +38,4 @@ class DeviceLogEmitter extends device_log_provider_base_1.DeviceLogProviderBase
 }
 exports.DeviceLogEmitter = DeviceLogEmitter;
 yok_1.injector.register("deviceLogProvider", DeviceLogEmitter);
+//# sourceMappingURL=device-log-emitter.js.map

package/lib/common/mobile/device-log-provider-base.js

@@ -63,3 +63,4 @@ class DeviceLogProviderBase extends events_1.EventEmitter {
     }
 }
 exports.DeviceLogProviderBase = DeviceLogProviderBase;
+//# sourceMappingURL=device-log-provider-base.js.map

package/lib/common/mobile/device-log-provider.js

@@ -36,6 +36,7 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
         this.colorPoolIndex = 0;
     }
     logData(lineText, platform, deviceIdentifier) {
+        // console.log(lineText)
         const loggingOptions = this.getDeviceLogOptionsForDevice(deviceIdentifier);
         let data = this.$logFilter.filterData(platform, lineText, loggingOptions);
         data = this.$logSourceMapService.replaceWithOriginalFileLocations(platform, data, loggingOptions);
@@ -53,6 +54,7 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
             return this.deviceColorMap.get(deviceIdentifier);
         }
         const color = this.colorPool[this.colorPoolIndex];
+        // wrap around if we have no more colors in the pool
         this.colorPoolIndex =
             this.colorPoolIndex === this.colorPool.length - 1
                 ? 0
@@ -62,10 +64,13 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
     }
     logDataCore(data, deviceIdentifier) {
         var _a, _b, _c;
+        // todo: use config to set logger - --env.classicLogs is temporary!
         if ("classicLogs" in ((_a = this.$options.env) !== null && _a !== void 0 ? _a : {})) {
+            // legacy logging
             this.$logger.info(data, { [constants_2.LoggerConfigData.skipNewLine]: true });
             return;
         }
+        // todo: extract into an injectable printer/logger service
         let shouldPrepend = false;
         let splitIndexes = [];
         const lines = data
@@ -120,7 +125,25 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
     printLine(prefix, ...parts) {
         const fullLine = parts.join(" ");
         console.log(prefix, fullLine);
+        /**
+         * Note: Disabled
+         *
+         * This splits the output into lines that fit within the current
+         * terminal width, however this makes copying json objects that
+         * span across multiple lines difficult, as it introduces
+         * whitespace & line breaks
+         */
+        // const maxWidth = process.stdout.columns - 2;
+        // if (!maxWidth || maxWidth < 10 || fullLine.length < maxWidth) {
+        // 	console.log(prefix, fullLine);
+        // } else {
+        // 	for (let i = 0; i < fullLine.length; i += maxWidth) {
+        // 		const part = fullLine.substring(i, i + maxWidth);
+        // 		console.log(prefix, part);
+        // 	}
+        // }
     }
 }
 exports.DeviceLogProvider = DeviceLogProvider;
 yok_1.injector.register("deviceLogProvider", DeviceLogProvider);
+//# sourceMappingURL=device-log-provider.js.map

package/lib/common/mobile/device-platforms-constants.js

@@ -20,3 +20,4 @@ class DevicePlatformsConstants {
 }
 exports.DevicePlatformsConstants = DevicePlatformsConstants;
 yok_1.injector.register("devicePlatformsConstants", DevicePlatformsConstants);
+//# sourceMappingURL=device-platforms-constants.js.map

package/lib/common/mobile/emulator-helper.js

@@ -6,7 +6,9 @@ const _ = require("lodash");
 const yok_1 = require("../yok");
 class EmulatorHelper {
     constructor() {
+        // https://developer.android.com/guide/topics/manifest/uses-sdk-element
         this.mapAndroidApiLevelToVersion = {
+            "android-36": "16.0.0",
             "android-35": "15.0.0",
             "android-34": "14.0.0",
             "android-33": "13.0.0",
@@ -79,7 +81,9 @@ class EmulatorHelper {
         emulator.identifier = emulatorId;
         emulator.status = constants_1.RUNNING_EMULATOR_STATUS;
         emulator.type = constants_1.DeviceTypes.Device;
+        //emulator.isTablet; // TODO: consider to do this here!!!
     }
 }
 exports.EmulatorHelper = EmulatorHelper;
 yok_1.injector.register("emulatorHelper", EmulatorHelper);
+//# sourceMappingURL=emulator-helper.js.map

package/lib/common/mobile/ios/device/ios-application-manager.js

@@ -115,9 +115,11 @@ class IOSApplicationManager extends application_manager_base_1.ApplicationManage
         await this.device.openDeviceLogStream();
     }
     getDebuggableApps() {
+        // Implement when we can find debuggable applications for iOS.
         return Promise.resolve([]);
     }
     getDebuggableAppViews(appIdentifiers) {
+        // Implement when we can find debuggable applications for iOS.
         return Promise.resolve(null);
     }
 }
@@ -128,3 +130,4 @@ __decorate([
 __decorate([
     (0, decorators_1.cache)()
 ], IOSApplicationManager.prototype, "startDeviceLog", null);
+//# sourceMappingURL=ios-application-manager.js.map

package/lib/common/mobile/ios/device/ios-device-file-system.js

@@ -104,3 +104,4 @@ class IOSDeviceFileSystem {
 }
 exports.IOSDeviceFileSystem = IOSDeviceFileSystem;
 IOSDeviceFileSystem.AFC_DELETE_FILE_NOT_FOUND_ERROR = 8;
+//# sourceMappingURL=ios-device-file-system.js.map

package/lib/common/mobile/ios/device/ios-device-operations.js

@@ -44,6 +44,7 @@ class IOSDeviceOperations extends events_1.EventEmitter {
             if (options && options.shouldReturnImmediateResult) {
                 return;
             }
+            // We need this because we need to make sure that we have devices.
             await new Promise((resolve, reject) => {
                 let iterationsCount = 0;
                 const maxIterationsCount = 3;
@@ -125,6 +126,8 @@ class IOSDeviceOperations extends events_1.EventEmitter {
         return this.getMultipleResults(() => this.deviceLib.stop(stopArray), errorHandler);
     }
     dispose(signal) {
+        // We need to check if we should dispose the device lib.
+        // For example we do not want to dispose it when we start printing the device logs.
         if (this.shouldDispose && this.deviceLib) {
             this.deviceLib.removeAllListeners();
             this.deviceLib.dispose(signal);
@@ -195,3 +198,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], IOSDeviceOperations.prototype, "attacheDeviceLogDataHandler", null);
 yok_1.injector.register("iosDeviceOperations", IOSDeviceOperations);
+//# sourceMappingURL=ios-device-operations.js.map

package/lib/common/mobile/ios/device/ios-device.js

@@ -106,6 +106,7 @@ class IOSDevice extends ios_device_base_1.IOSDeviceBase {
             const majorVersionAsString = productType.match(/.*?(\d+)\,(\d+)/)[1];
             const majorVersion = parseInt(majorVersionAsString);
             let isArm64Architecture = false;
+            //https://en.wikipedia.org/wiki/List_of_iOS_devices
             if (_.startsWith(productType, "iphone")) {
                 isArm64Architecture = majorVersion >= 6;
             }
@@ -116,6 +117,7 @@ class IOSDevice extends ios_device_base_1.IOSDeviceBase {
                 isArm64Architecture = majorVersion >= 7;
             }
             else if (_.startsWith(productType, "realitydevice")) {
+                // visionos
                 isArm64Architecture = true;
             }
             activeArchitecture = isArm64Architecture ? "arm64" : "armv7";
@@ -125,6 +127,7 @@ class IOSDevice extends ios_device_base_1.IOSDeviceBase {
     getPlatform(productType) {
         productType = productType.toLowerCase().trim();
         if (_.startsWith(productType, "realitydevice")) {
+            // visionos
             return this.$devicePlatformsConstants.visionOS;
         }
         return this.$devicePlatformsConstants.iOS;
@@ -135,3 +138,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], IOSDevice.prototype, "openDeviceLogStream", null);
 yok_1.injector.register("iOSDevice", IOSDevice);
+//# sourceMappingURL=ios-device.js.map

package/lib/common/mobile/ios/ios-device-base.js

@@ -83,3 +83,4 @@ exports.IOSDeviceBase = IOSDeviceBase;
 __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSDeviceBase.prototype, "getDebugSocket", null);
+//# sourceMappingURL=ios-device-base.js.map

package/lib/common/mobile/ios/ios-device-product-name-mapper.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const yok_1 = require("../../yok");
 class IosDeviceProductNameMapper {
     constructor() {
+        // http://support.hockeyapp.net/kb/client-integration-ios-mac-os-x/ios-device-types
         this.map = {
             "iPhone1,1": "iPhone",
             "iPhone1,2": "iPhone 3G",
@@ -63,3 +64,4 @@ class IosDeviceProductNameMapper {
     }
 }
 yok_1.injector.register("iOSDeviceProductNameMapper", IosDeviceProductNameMapper);
+//# sourceMappingURL=ios-device-product-name-mapper.js.map

package/lib/common/mobile/ios/ios-log-filter.js

@@ -22,3 +22,4 @@ class IOSLogFilter {
 }
 exports.IOSLogFilter = IOSLogFilter;
 yok_1.injector.register("iOSLogFilter", IOSLogFilter);
+//# sourceMappingURL=ios-log-filter.js.map

package/lib/common/mobile/ios/simulator/ios-emulator-services.js

@@ -18,6 +18,7 @@ class IosEmulatorServices {
         try {
             if (options.platform === this.$devicePlatformsConstants.visionOS &&
                 !options.emulatorIdOrName) {
+                // find first available visionOS simulator (for now).
                 const { devices } = await this.tryGetiOSSimDevices();
                 options.emulatorIdOrName = (_a = devices.find((device) => device.platform === this.$devicePlatformsConstants.visionOS)) === null || _a === void 0 ? void 0 : _a.id;
             }
@@ -51,6 +52,8 @@ class IosEmulatorServices {
     }
     async connectToPort(data) {
         try {
+            // node v17+ resolves localhost to ::1 (ipv6) instead of 127.0.0.1 (ipv4)
+            // so we explicitly pass ipv4
             const socket = net.connect(data.port, "127.0.0.1");
             return socket;
         }
@@ -108,3 +111,4 @@ class IosEmulatorServices {
     }
 }
 yok_1.injector.register("iOSEmulatorServices", IosEmulatorServices);
+//# sourceMappingURL=ios-emulator-services.js.map

package/lib/common/mobile/ios/simulator/ios-sim-resolver.js

@@ -21,3 +21,4 @@ exports.IOSSimResolver = IOSSimResolver;
 IOSSimResolver.iOSSimName = "ios-sim-portable";
 IOSSimResolver.iOSStandaloneExecutableName = "ios-sim-standalone.js";
 yok_1.injector.register("iOSSimResolver", IOSSimResolver);
+//# sourceMappingURL=ios-sim-resolver.js.map

package/lib/common/mobile/ios/simulator/ios-simulator-application-manager.js

@@ -73,8 +73,13 @@ class IOSSimulatorApplicationManager extends application_manager_base_1.Applicat
         return [];
     }
     async getDebuggableAppViews(appIdentifiers) {
+        // Implement when we can find debuggable applications for iOS.
         return Promise.resolve(null);
     }
+    // iOS will kill the app if we freeze it in the NativeScript Runtime and wait for debug-brk.
+    // In order to avoid that, we are attaching lldb and passing it "process continue".
+    // In this way, iOS will not kill the app because it has a native debugger attached
+    // and the users will be able to attach a debug session using the debug-brk flag.
     attachNativeDebugger(appId, pid) {
         this._lldbProcesses[appId] = this.$childProcess.spawn("lldb", ["-p", pid]);
         if (log4js.levels.TRACE.isGreaterThanOrEqualTo(this.$logger.getLevel())) {
@@ -116,3 +121,4 @@ __decorate([
 __decorate([
     (0, decorators_1.cache)()
 ], IOSSimulatorApplicationManager.prototype, "startDeviceLog", null);
+//# sourceMappingURL=ios-simulator-application-manager.js.map

package/lib/common/mobile/ios/simulator/ios-simulator-device.js

@@ -65,11 +65,15 @@ class IOSSimulator extends ios_device_base_1.IOSDeviceBase {
         let socket;
         const attachRequestMessage = this.$iOSNotification.getAttachRequest(appId, this.deviceInfo.identifier);
         await this.$iOSEmulatorServices.postDarwinNotification(attachRequestMessage, this.deviceInfo.identifier);
+        // Retry posting the notification every five seconds, in case the AttachRequest
+        // event handler wasn't registered when the first one was sent
         const postNotificationRetryInterval = setInterval(() => {
             this.$iOSEmulatorServices
                 .postDarwinNotification(attachRequestMessage, this.deviceInfo.identifier)
                 .catch((e) => this.$logger.error(e));
         }, 5e3);
+        // the internal retry-mechanism of getDebuggerPort will ensure the above
+        // interval has a chance to execute multiple times
         const port = await super.getDebuggerPort(appId).finally(() => {
             clearInterval(postNotificationRetryInterval);
         });
@@ -88,3 +92,4 @@ exports.IOSSimulator = IOSSimulator;
 __decorate([
     (0, decorators_1.cache)()
 ], IOSSimulator.prototype, "openDeviceLogStream", null);
+//# sourceMappingURL=ios-simulator-device.js.map

package/lib/common/mobile/ios/simulator/ios-simulator-file-system.js

@@ -54,3 +54,4 @@ class IOSSimulatorFileSystem {
     }
 }
 exports.IOSSimulatorFileSystem = IOSSimulatorFileSystem;
+//# sourceMappingURL=ios-simulator-file-system.js.map

package/lib/common/mobile/ios/simulator/ios-simulator-log-provider.js

@@ -56,3 +56,4 @@ class IOSSimulatorLogProvider extends events_1.EventEmitter {
 }
 exports.IOSSimulatorLogProvider = IOSSimulatorLogProvider;
 yok_1.injector.register("iOSSimulatorLogProvider", IOSSimulatorLogProvider);
+//# sourceMappingURL=ios-simulator-log-provider.js.map

package/lib/common/mobile/local-to-device-path-data-factory.js

@@ -35,3 +35,4 @@ class LocalToDevicePathDataFactory {
 }
 exports.LocalToDevicePathDataFactory = LocalToDevicePathDataFactory;
 yok_1.injector.register("localToDevicePathDataFactory", LocalToDevicePathDataFactory);
+//# sourceMappingURL=local-to-device-path-data-factory.js.map

package/lib/common/mobile/log-filter.js

@@ -24,6 +24,7 @@ class LogFilter {
         if (deviceLogFilter) {
             return deviceLogFilter.filterData(data, loggingOptions);
         }
+        // In case the platform is not valid, just return the data without filtering.
         return data;
     }
     getDeviceLogFilterInstance(platform) {
@@ -49,3 +50,4 @@ class LogFilter {
 }
 exports.LogFilter = LogFilter;
 yok_1.injector.register("logFilter", LogFilter);
+//# sourceMappingURL=log-filter.js.map

package/lib/common/mobile/logging-levels.js

@@ -10,3 +10,4 @@ class LoggingLevels {
 }
 exports.LoggingLevels = LoggingLevels;
 yok_1.injector.register("loggingLevels", LoggingLevels);
+//# sourceMappingURL=logging-levels.js.map

package/lib/common/mobile/mobile-core/android-device-discovery.js

@@ -38,6 +38,7 @@ class AndroidDeviceDiscovery extends device_discovery_1.DeviceDiscovery {
     }
     async checkCurrentData(result) {
         const currentDevices = result.map((element) => {
+            // http://developer.android.com/tools/help/adb.html#devicestatus
             const data = element.split("\t");
             const identifier = data[0];
             const status = data[1];
@@ -70,3 +71,4 @@ class AndroidDeviceDiscovery extends device_discovery_1.DeviceDiscovery {
 }
 exports.AndroidDeviceDiscovery = AndroidDeviceDiscovery;
 yok_1.injector.register("androidDeviceDiscovery", AndroidDeviceDiscovery);
+//# sourceMappingURL=android-device-discovery.js.map

package/lib/common/mobile/mobile-core/android-emulator-discovery.js

@@ -21,9 +21,11 @@ class AndroidEmulatorDiscovery extends events_1.EventEmitter {
         const availableEmulatorsOutput = await this.$androidEmulatorServices.getEmulatorImages();
         const currentEmulators = availableEmulatorsOutput.devices;
         const cachedEmulators = _.values(this._emulators);
+        // Remove old emulators
         const lostEmulators = _(cachedEmulators)
             .reject((e) => _.some(currentEmulators, (emulator) => emulator && e && emulator.imageIdentifier === e.imageIdentifier))
             .value();
+        // Add new emulators
         const foundEmulators = _(currentEmulators)
             .reject((e) => _.some(cachedEmulators, (emulator) => emulator && e && emulator.imageIdentifier === e.imageIdentifier))
             .value();
@@ -52,3 +54,4 @@ class AndroidEmulatorDiscovery extends events_1.EventEmitter {
 }
 exports.AndroidEmulatorDiscovery = AndroidEmulatorDiscovery;
 yok_1.injector.register("androidEmulatorDiscovery", AndroidEmulatorDiscovery);
+//# sourceMappingURL=android-emulator-discovery.js.map

package/lib/common/mobile/mobile-core/android-process-service.js

@@ -71,6 +71,19 @@ class AndroidProcessService {
     async getDebuggableApps(deviceIdentifier) {
         const adb = this.getAdb(deviceIdentifier);
         const androidWebViewPortInformation = (await this.getAbstractPortsInformation(adb)).split(os_1.EOL);
+        // TODO: Add tests and make sure only unique names are returned. Input before groupBy is:
+        // [ { deviceIdentifier: 'SH26BW100473',
+        // 	appIdentifier: 'com.telerik.EmptyNS',
+        // 	framework: 'NativeScript' },
+        // 	{ deviceIdentifier: 'SH26BW100473',
+        // 	appIdentifier: 'com.telerik.EmptyNS',
+        // 	framework: 'Cordova' },
+        // 	{ deviceIdentifier: 'SH26BW100473',
+        // 	appIdentifier: 'chrome',
+        // 	framework: 'Cordova' },
+        // 	{ deviceIdentifier: 'SH26BW100473',
+        // 	appIdentifier: 'chrome',
+        // 	framework: 'Cordova' } ]
         const portInformation = await Promise.all(_.map(androidWebViewPortInformation, async (line) => (await this.getApplicationInfoFromWebViewPortInformation(adb, deviceIdentifier, line)) ||
             (await this.getNativeScriptApplicationInformation(adb, deviceIdentifier, line))));
         return _(portInformation)
@@ -109,6 +122,7 @@ class AndroidProcessService {
         return adb;
     }
     async getApplicationInfoFromWebViewPortInformation(adb, deviceIdentifier, information) {
+        // Need to search by processId to check for old Android webviews (@webview_devtools_remote_<processId>).
         const processIdRegExp = /@webview_devtools_remote_(.+)/g;
         const processIdMatches = processIdRegExp.exec(information);
         let cordovaAppIdentifier;
@@ -117,6 +131,7 @@ class AndroidProcessService {
             cordovaAppIdentifier = await this.getApplicationIdentifierFromPid(adb, processId);
         }
         else {
+            // Search for appIdentifier (@<appIdentifier>_devtools_remote).
             const chromeAppIdentifierRegExp = /@(.+)_devtools_remote\s?/g;
             const chromeAppIdentifierMatches = chromeAppIdentifierRegExp.exec(information);
             if (chromeAppIdentifierMatches && chromeAppIdentifierMatches.length > 0) {
@@ -133,6 +148,7 @@ class AndroidProcessService {
         return null;
     }
     async getNativeScriptApplicationInformation(adb, deviceIdentifier, information) {
+        // Search for appIdentifier (@<appIdentifier-debug>).
         const nativeScriptAppIdentifierRegExp = /@(.+)-(debug|inspectorServer)/g;
         const nativeScriptAppIdentifierMatches = nativeScriptAppIdentifierRegExp.exec(information);
         if (nativeScriptAppIdentifierMatches &&
@@ -147,6 +163,10 @@ class AndroidProcessService {
         return null;
     }
     async getAbstractPortForApplication(adb, processId, appIdentifier, abstractPortsInformation, framework) {
+        // The result will look like this (without the columns names):
+        // Num       		 RefCount Protocol Flags    Type St Inode  Path
+        // 0000000000000000: 00000002 00000000 00010000 0001 01 189004 @webview_devtools_remote_25512
+        // The Path column is the abstract port.
         framework = framework || "";
         switch (framework.toLowerCase()) {
             case constants_1.TARGET_FRAMEWORK_IDENTIFIERS.Cordova.toLowerCase():
@@ -173,6 +193,9 @@ class AndroidProcessService {
         return match && match[1];
     }
     async getProcessIds(adb, appIdentifiers) {
+        // Process information will look like this (without the columns names):
+        // USER     PID   PPID  VSIZE   RSS   WCHAN    PC         NAME
+        // u0_a63   25512 1334  1519560 96040 ffffffff f76a8f75 S com.telerik.appbuildertabstest
         const result = {};
         const processIdInformation = await adb.executeShellCommand(["ps"]);
         _.each(appIdentifiers, (appIdentifier) => {
@@ -183,6 +206,11 @@ class AndroidProcessService {
     }
     async getAlreadyMappedPort(adb, deviceIdentifier, abstractPort, adbForwardList) {
         const allForwardedPorts = adbForwardList || (await adb.executeCommand(["forward", "--list"])) || "";
+        // Sample output:
+        // 5e2e580b tcp:62503 localabstract:webview_devtools_remote_7985
+        // 5e2e580b tcp:62524 localabstract:webview_devtools_remote_7986
+        // 5e2e580b tcp:63160 localabstract:webview_devtools_remote_7987
+        // 5e2e580b tcp:57577 localabstract:com.telerik.nrel-debug
         const regex = new RegExp(`${deviceIdentifier}\\s+?tcp:(\\d+?)\\s+?.*?${abstractPort}$`);
         return this.getFirstMatchingGroupFromMultilineResult(allForwardedPorts, regex);
     }
@@ -196,6 +224,9 @@ class AndroidProcessService {
     }
     async getApplicationIdentifierFromPid(adb, pid, psData) {
         psData = psData || (await adb.executeShellCommand(["ps"]));
+        // Process information will look like this (without the columns names):
+        // USER     PID   PPID  VSIZE   RSS   WCHAN    PC         NAME
+        // u0_a63   25512 1334  1519560 96040 ffffffff f76a8f75 S com.telerik.appbuildertabstest
         return this.getFirstMatchingGroupFromMultilineResult(psData, new RegExp(`\\s+${pid}(?:\\s+\\d+){3}\\s+.*\\s+(.*?)$`));
     }
     getFirstMatchingGroupFromMultilineResult(input, regex) {
@@ -218,3 +249,4 @@ __decorate([
     (0, decorators_1.exported)("androidProcessService")
 ], AndroidProcessService.prototype, "getAppProcessId", null);
 yok_1.injector.register("androidProcessService", AndroidProcessService);
+//# sourceMappingURL=android-process-service.js.map

package/lib/common/mobile/mobile-core/device-discovery.js

@@ -51,3 +51,4 @@ class DeviceDiscovery extends events_1.EventEmitter {
 }
 exports.DeviceDiscovery = DeviceDiscovery;
 yok_1.injector.register("deviceDiscovery", DeviceDiscovery);
+//# sourceMappingURL=device-discovery.js.map