nativescript 8.7.0-rc.0 → 8.7.0-rc.2

package/lib/common/http-client.js

@@ -36,6 +36,9 @@ class HttpClient {
             catch (err) {
                 if (err.message === HttpClient.STUCK_REQUEST_ERROR_MESSAGE ||
                     err.message === HttpClient.STUCK_RESPONSE_ERROR_MESSAGE) {
+                    // Retry the request immediately because there are at least 10 seconds between the two requests.
+                    // We have to retry only once the sporadically stuck requests/responses.
+                    // We can add exponential backoff retry here if we decide that we need to workaround bigger network issues on the client side.
                     this.$logger.warn("%s Retrying request to %s...", err.message, options.url || options);
                     const retryResult = yield this.httpRequestCore(options, proxySettings);
                     return {
@@ -63,6 +66,7 @@ class HttpClient {
             yield this.useProxySettings(proxySettings, cliProxySettings, options, headers, requestProto);
             if (!headers["User-Agent"]) {
                 if (!this.defaultUserAgent) {
+                    //TODO: the user agent client name is also passed explicitly during login and should be kept in sync
                     this.defaultUserAgent = `${this.$staticConfig.USER_AGENT_NAME}/${this.$staticConfig.version} (Node.js ${process.versions.node}; ${process.platform}; ${process.arch})`;
                     this.$logger.trace("User-Agent: %s", this.defaultUserAgent);
                 }
@@ -91,14 +95,19 @@ class HttpClient {
             }).catch((err) => {
                 this.$logger.trace("An error occurred while sending the request:", err);
                 if (err.response) {
+                    // The request was made and the server responded with a status code
+                    // that falls out of the range of 2xx
                     const errorMessage = this.getErrorMessage(err.response.status, null);
                     err.proxyAuthenticationRequired =
                         err.response.status === constants_1.HttpStatusCodes.PROXY_AUTHENTICATION_REQUIRED;
                     err.message = errorMessage || err.message;
                 }
                 else if (err.request) {
+                    // The request was made but no response was received
+                    // `err.request` is an instance of XMLHttpRequest in the browser and an instance of
                 }
                 else {
+                    // Something happened in setting up the request that triggered an Error
                 }
                 throw err;
             });
@@ -145,9 +154,18 @@ class HttpClient {
             return body;
         }
     }
+    /**
+     * This method respects the proxySettings (or proxyCache) by modifying headers and options passed to http(s) module.
+     * @param {IProxySettings} proxySettings The settings passed for this specific call.
+     * @param {IProxySettings} cliProxySettings The globally set proxy for this CLI.
+     * @param {any}options The object that will be passed to http(s) module.
+     * @param {any} headers Headers of the current request.
+     * @param {string} requestProto The protocol used for the current request - http or https.
+     */
     useProxySettings(proxySettings, cliProxySettings, options, headers, requestProto) {
         return __awaiter(this, void 0, void 0, function* () {
             const isLocalRequest = options.host === "localhost" || options.host === "127.0.0.1";
+            // don't use the proxy for requests to localhost
             if (!isLocalRequest && (proxySettings || cliProxySettings)) {
                 const proto = (proxySettings && proxySettings.protocol) ||
                     cliProxySettings.protocol ||
@@ -158,6 +176,7 @@ class HttpClient {
                 if (cliProxySettings.username && cliProxySettings.password) {
                     credentialsPart = `${cliProxySettings.username}:${cliProxySettings.password}@`;
                 }
+                // Note that proto ends with :
                 options.proxy = `${proto}//${credentialsPart}${host}:${port}`;
                 options.rejectUnauthorized = proxySettings
                     ? proxySettings.rejectUnauthorized
@@ -171,3 +190,4 @@ HttpClient.STUCK_REQUEST_ERROR_MESSAGE = "The request can't receive any response
 HttpClient.STUCK_RESPONSE_ERROR_MESSAGE = "Can't receive all parts of the response.";
 exports.HttpClient = HttpClient;
 yok_1.injector.register("httpClient", HttpClient);
+//# sourceMappingURL=http-client.js.map

package/lib/common/logger/appenders/cli-appender.js

@@ -15,10 +15,14 @@ function cliAppender(layout) {
     return appender;
 }
 function configure(config, layouts) {
+    // the default layout for the appender
     let layout = layouts.messagePassThroughLayout;
+    // check if there is another layout specified
     if (config.layout) {
         layout = layouts.layout(config.layout.type, config.layout);
     }
+    // create a new appender instance
     return cliAppender(layout);
 }
 exports.configure = configure;
+//# sourceMappingURL=cli-appender.js.map

package/lib/common/logger/appenders/emit-appender.js

@@ -21,10 +21,14 @@ function configure(config, layouts) {
     if (!config.emitter.emit || typeof config.emitter.emit !== "function") {
         throw new Error("The passed emitter must be instance of EventEmitter");
     }
+    // the default layout for the appender
     let layout = layouts.messagePassThroughLayout;
+    // check if there is another layout specified
     if (config.layout) {
         layout = layouts.layout(config.layout.type, config.layout);
     }
+    // create a new appender instance
     return emitAppender(layout, config.emitter);
 }
 exports.configure = configure;
+//# sourceMappingURL=emit-appender.js.map

package/lib/common/logger/layouts/cli-layout.js

@@ -31,3 +31,4 @@ function layout(config) {
     };
 }
 exports.layout = layout;
+//# sourceMappingURL=cli-layout.js.map

package/lib/common/logger/logger.js

@@ -98,9 +98,11 @@ class Logger {
         if (typeof item === "string") {
             return item;
         }
+        // do not try to read streams, because they may not be rewindable
         if (item instanceof stream.Readable) {
             return "[ReadableStream]";
         }
+        // There's no point in printing buffers
         if (item instanceof Buffer) {
             return "[Buffer]";
         }
@@ -153,12 +155,14 @@ class Logger {
     getLogOptionsForMessage(data) {
         const loggerOptionKeys = _.keys(constants_1.LoggerConfigData);
         const dataToCheck = data.filter((el) => {
+            // objects created with Object.create(null) do not have `hasOwnProperty` function
             if (!!el &&
                 typeof el === "object" &&
                 el.hasOwnProperty &&
                 typeof el.hasOwnProperty === "function") {
                 for (const key of loggerOptionKeys) {
                     if (el.hasOwnProperty(key)) {
+                        // include only the elements which have one of the keys we've specified as logger options
                         return true;
                     }
                 }
@@ -197,3 +201,4 @@ __decorate([
 ], Logger.prototype, "initialize", null);
 exports.Logger = Logger;
 yok_1.injector.register("logger", Logger);
+//# sourceMappingURL=logger.js.map

package/lib/common/messages/messages.js

@@ -1,7 +1,11 @@
 "use strict";
+//
+// automatically generated code; do not edit manually!
+//
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Messages = void 0;
 const yok_1 = require("../yok");
+/* tslint:disable:all */
 class Messages {
     constructor() {
         this.Devices = {
@@ -13,3 +17,5 @@ class Messages {
 }
 exports.Messages = Messages;
 yok_1.injector.register("messages", Messages);
+/* tslint:enable */
+//# sourceMappingURL=messages.js.map

package/lib/common/mobile/android/android-application-manager.js

@@ -38,7 +38,7 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
         this.$deviceLogProvider = $deviceLogProvider;
         this.$errors = $errors;
         this.PID_CHECK_INTERVAL = 100;
-        this.PID_CHECK_TIMEOUT = 10000;
+        this.PID_CHECK_TIMEOUT = 10000; // 10 secs
     }
     getInstalledApplications() {
         return __awaiter(this, void 0, void 0, function* () {
@@ -80,6 +80,7 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
         });
     }
     uninstallApplication(appIdentifier) {
+        // Need to set the treatErrorsAsWarnings to true because when using tns run command if the application is not installed on the device it will throw error
         return this.adb.executeShellCommand(["pm", "uninstall", `${appIdentifier}`], { treatErrorsAsWarnings: true });
     }
     startApplication(appData) {
@@ -89,9 +90,24 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
                     `cat /dev/null > ${constants_1.LiveSyncPaths.ANDROID_TMP_DIR_NAME}/${appData.appId}-debugbreak`,
                 ]);
             }
+            // If the app is debuggable, the Runtime will update the file when its ready for debugging
+            // and we will be able to take decisions and synchronize the debug experience based on the content
             yield this.adb.executeShellCommand([
                 `cat /dev/null > ${constants_1.LiveSyncPaths.ANDROID_TMP_DIR_NAME}/${appData.appId}-debugger-started`,
             ]);
+            /*
+            Example "pm dump <app_identifier> | grep -A 1 MAIN" output"
+                android.intent.action.MAIN:
+                3b2df03 org.nativescript.cliapp/com.tns.NativeScriptActivity filter 50dd82e
+                Action: "android.intent.action.MAIN"
+                Category: "android.intent.category.LAUNCHER"
+                --
+                intent={act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=org.nativescript.cliapp/com.tns.NativeScriptActivity}
+                realActivity=org.nativescript.cliapp/com.tns.NativeScriptActivity
+                --
+                Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=org.nativescript.cliapp/com.tns.NativeScriptActivity }
+                frontOfTask=true task=TaskRecord{fe592ac #449 A=org.nativescript.cliapp U=0 StackId=1 sz=1}
+            */
             const appIdentifier = appData.appId;
             const pmDumpOutput = yield this.adb.executeShellCommand([
                 "pm",
@@ -143,6 +159,8 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
                         pid: processIdentifier,
                         appId: appIdentifier,
                         onAppRestarted: () => {
+                            // If the app restarts, we update the PID and
+                            // restart log helper.
                             this.onAppLaunch(appData);
                         },
                     });
@@ -226,3 +244,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], AndroidApplicationManager.prototype, "getFullyQualifiedActivityRegex", null);
 exports.AndroidApplicationManager = AndroidApplicationManager;
+//# sourceMappingURL=android-application-manager.js.map

package/lib/common/mobile/android/android-debug-bridge-result-handler.js

@@ -330,3 +330,4 @@ AndroidDebugBridgeResultHandler.ANDROID_DEBUG_BRIDGE_ERRORS = [
 ];
 exports.AndroidDebugBridgeResultHandler = AndroidDebugBridgeResultHandler;
 yok_1.injector.register("androidDebugBridgeResultHandler", AndroidDebugBridgeResultHandler);
+//# sourceMappingURL=android-debug-bridge-result-handler.js.map

package/lib/common/mobile/android/android-debug-bridge.js

@@ -50,11 +50,15 @@ class AndroidDebugBridge {
                     return this.$childProcess.spawn(command.command, command.args);
                 }
             }
+            // If adb -s <invalid device id> install <smth> is executed the childProcess won't get any response
+            // because the adb will be waiting for valid device and will not send close or exit event.
+            // For example `adb -s <invalid device id> install <smth>` throws error 'error: device \'030939f508e6c773\' not found\r\n' exitCode 4294967295
             const result = yield this.$childProcess.spawnFromEvent(command.command, command.args, event, childProcessOptions, { throwError: false });
             const errors = this.$androidDebugBridgeResultHandler.checkForErrors(result);
             if (errors && errors.length > 0) {
                 this.$androidDebugBridgeResultHandler.handleErrors(errors, treatErrorsAsWarnings);
             }
+            // Some adb commands returns array of strings instead of object with stdout and stderr. (adb start-server)
             return result.stdout === undefined || result.stdout === null
                 ? result
                 : result.stdout;
@@ -143,6 +147,7 @@ class AndroidDebugBridge {
     pushFile(localFilePath, deviceFilePath) {
         return __awaiter(this, void 0, void 0, function* () {
             const fileDirectory = (0, helpers_1.fromWindowsRelativePathToUnix)(path.dirname(deviceFilePath));
+            // starting from API level 28, the push command is returning an error if the directory does not exist
             yield this.executeShellCommand(["mkdir", "-p", fileDirectory]);
             yield this.executeCommand(["push", localFilePath, deviceFilePath]);
             yield this.executeShellCommand(["chmod", "0777", fileDirectory]);
@@ -165,3 +170,4 @@ __decorate([
 ], AndroidDebugBridge.prototype, "getDevices", null);
 exports.AndroidDebugBridge = AndroidDebugBridge;
 yok_1.injector.register("adb", AndroidDebugBridge);
+//# sourceMappingURL=android-debug-bridge.js.map

package/lib/common/mobile/android/android-device-file-system.js

@@ -94,6 +94,8 @@ class AndroidDeviceFileSystem {
     }
     transferDirectory(deviceAppData, localToDevicePaths, projectFilesPath) {
         return __awaiter(this, void 0, void 0, function* () {
+            // starting from Android 9, adb push is throwing an exception when there are subfolders
+            // the check could be removed when we start supporting only runtime versions with sockets
             const minAndroidWithoutAdbPushDir = "9.0.0";
             const isAdbPushDirSupported = semver.lt(semver.coerce(deviceAppData.device.deviceInfo.version), minAndroidWithoutAdbPushDir);
             const deviceProjectDir = yield deviceAppData.getDeviceProjectRootPath();
@@ -148,6 +150,7 @@ class AndroidDeviceFileSystem {
             const hostTmpDir = yield this.$tempService.mkdirSync("application-");
             const commandsFileHostPath = path.join(hostTmpDir, "temp.commands.file");
             this.$fs.writeFile(commandsFileHostPath, fileContent);
+            // copy it to the device
             yield this.transferFile(commandsFileHostPath, deviceFilePath);
             yield this.adb.executeShellCommand(["chmod", "0777", deviceFilePath]);
         });
@@ -174,3 +177,4 @@ class AndroidDeviceFileSystem {
     }
 }
 exports.AndroidDeviceFileSystem = AndroidDeviceFileSystem;
+//# sourceMappingURL=android-device-file-system.js.map

package/lib/common/mobile/android/android-device-hash-service.js

@@ -69,6 +69,8 @@ class AndroidDeviceHashService {
             const action = (localToDevicePathData) => __awaiter(this, void 0, void 0, function* () {
                 const localPath = localToDevicePathData.getLocalPath();
                 if (this.$fs.getFsStats(localPath).isFile()) {
+                    // TODO: Use relative to project path for key
+                    // This will speed up livesync on the same device for the same project on different PCs.
                     initialShasums[localPath] = yield this.$fs.getFileShasum(localPath);
                 }
             });
@@ -131,3 +133,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], AndroidDeviceHashService.prototype, "getTempDir", null);
 exports.AndroidDeviceHashService = AndroidDeviceHashService;
+//# sourceMappingURL=android-device-hash-service.js.map

package/lib/common/mobile/android/android-device.js

@@ -42,6 +42,8 @@ class AndroidDevice {
             this.fileSystem = this.$injector.resolve(fileSystemPath.AndroidDeviceFileSystem, { adb: this.adb });
             let details = yield this.getDeviceDetails(["getprop"]);
             if (!details || !details.name) {
+                // In older CLI versions we are calling cat /system/build.prop to get details.
+                // Keep this logic for compatibility and possibly for devices for which getprop is not working
                 details = yield this.getDeviceDetails(["cat", "/system/build.prop"]);
             }
             this.$logger.trace(details);
@@ -102,6 +104,9 @@ class AndroidDevice {
             try {
                 const details = yield this.adb.executeShellCommand(shellCommandArgs);
                 details.split(/\r?\n|\r/).forEach((value) => {
+                    // sample line is "ro.build.version.release=4.4" in /system/build.prop
+                    // sample line from getprop is:  [ro.build.version.release]: [6.0]
+                    // NOTE: some props do not have value: [ro.build.version.base_os]: []
                     const match = /(?:\[?ro\.build\.version|ro\.product|ro\.build)\.(.+?)]?(?:\:|=)(?:\s*?\[)?(.*?)]?$/.exec(value);
                     if (match) {
                         parsedDetails[match[1]] = match[2];
@@ -116,6 +121,7 @@ class AndroidDevice {
         });
     }
     getIsTablet(details) {
+        //version 3.x.x (also known as Honeycomb) is a tablet only version
         return (details &&
             (_.startsWith(details.release, "3.") ||
                 _.includes((details.characteristics || "").toLowerCase(), "tablet")));
@@ -130,6 +136,7 @@ class AndroidDevice {
         });
     }
 }
+// http://stackoverflow.com/questions/31178195/what-does-adb-device-status-mean
 AndroidDevice.ADB_DEVICE_STATUS_INFO = {
     device: {
         errorHelp: null,
@@ -156,3 +163,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], AndroidDevice.prototype, "init", null);
 exports.AndroidDevice = AndroidDevice;
+//# sourceMappingURL=android-device.js.map

package/lib/common/mobile/android/android-emulator-services.js

@@ -121,7 +121,7 @@ class AndroidEmulatorServices {
                         endTimeEpoch,
                     };
                 }
-                yield (0, helpers_1.sleep)(10000);
+                yield (0, helpers_1.sleep)(10000); // the emulator definitely takes its time to wake up
                 hasTimeLeft = (0, helpers_1.getCurrentEpochTime)() < endTimeEpoch;
             }
             if (!hasTimeLeft && !isInfiniteWait) {
@@ -203,3 +203,4 @@ class AndroidEmulatorServices {
 }
 exports.AndroidEmulatorServices = AndroidEmulatorServices;
 yok_1.injector.register("androidEmulatorServices", AndroidEmulatorServices);
+//# sourceMappingURL=android-emulator-services.js.map

package/lib/common/mobile/android/android-ini-file-parser.js

@@ -12,6 +12,8 @@ class AndroidIniFileParser {
         if (!this.$fs.exists(iniFilePath)) {
             return null;
         }
+        // avd files can have different encoding, defined on the first line.
+        // find which one it is (if any) and use it to correctly read the file contents
         const encoding = this.getAvdEncoding(iniFilePath);
         const contents = this.$fs.readText(iniFilePath, encoding).split("\n");
         return _.reduce(contents, (result, line) => {
@@ -42,6 +44,8 @@ class AndroidIniFileParser {
         }, Object.create(null));
     }
     getAvdEncoding(avdName) {
+        // avd files can have different encoding, defined on the first line.
+        // find which one it is (if any) and use it to correctly read the file contents
         let encoding = "utf8";
         let contents = this.$fs.readText(avdName, "ascii");
         if (contents.length > 0) {
@@ -55,18 +59,22 @@ class AndroidIniFileParser {
         }
         return encoding;
     }
+    // Android L is not written as a number in the .ini files, and we need to convert it
     readTargetNum(target) {
         const platform = target.replace("android-", "");
         let platformNumber = +platform;
         if (isNaN(platformNumber)) {
+            // this may be a google image
             const googlePlatform = target.split(":")[2];
             if (googlePlatform) {
                 platformNumber = +googlePlatform;
             }
             else if (platform === "L") {
+                // Android SDK 20 preview
                 platformNumber = 20;
             }
             else if (platform === "MNC") {
+                // Android M preview
                 platformNumber = 22;
             }
         }
@@ -75,3 +83,4 @@ class AndroidIniFileParser {
 }
 exports.AndroidIniFileParser = AndroidIniFileParser;
 yok_1.injector.register("androidIniFileParser", AndroidIniFileParser);
+//# sourceMappingURL=android-ini-file-parser.js.map

package/lib/common/mobile/android/android-log-filter.js

@@ -36,7 +36,11 @@ class AndroidLogFilter {
         return consoleLogMessage;
     }
 }
+//sample line is "I/Web Console(    4438): Received Event: deviceready at file:///storage/emulated/0/Icenium/com.telerik.TestApp/js/index.js:48"
 AndroidLogFilter.LINE_REGEX = /.\/(.+?)\s*\(\s*\d+?\): (.*)/;
+// sample line is "11-23 12:39:07.310  1584  1597 I art     : Background sticky concurrent mark sweep GC freed 21966(1780KB) AllocSpace objects, 4(80KB) LOS objects, 77% free, 840KB/3MB, paused 4.018ms total 158.629ms"
+// or '12-28 10:45:08.020  3329  3329 W chromium: [WARNING:data_reduction_proxy_settings.cc(328)] SPDY proxy OFF at startup'
 AndroidLogFilter.API_LEVEL_23_LINE_REGEX = /.+?\s+?(?:[A-Z]\s+?)([A-Za-z \.]+?)\s*?\: (.*)/;
 exports.AndroidLogFilter = AndroidLogFilter;
 yok_1.injector.register("androidLogFilter", AndroidLogFilter);
+//# sourceMappingURL=android-log-filter.js.map

package/lib/common/mobile/android/android-virtual-device-service.js

@@ -84,6 +84,9 @@ class AndroidVirtualDeviceService {
     get pathToEmulatorExecutable() {
         const emulatorExecutableName = "emulator";
         if (this.androidHome) {
+            // Check https://developer.android.com/studio/releases/sdk-tools.html (25.3.0)
+            // Since this version of SDK tools, the emulator is a separate package.
+            // However the emulator executable still exists in the "tools" dir.
             const pathToEmulatorFromAndroidStudio = path.join(this.androidHome, emulatorExecutableName, emulatorExecutableName);
             const realFilePath = this.$hostInfo.isWindows
                 ? `${pathToEmulatorFromAndroidStudio}.exe`
@@ -123,6 +126,17 @@ class AndroidVirtualDeviceService {
             client.on("data", (data) => {
                 output += data.toString();
                 const imageIdentifier = this.getImageIdentifierFromClientOutput(output);
+                // old output should look like:
+                // Android Console: type 'help' for a list of commands
+                // OK
+                // <Name of image>
+                // OK
+                // new output should look like:
+                // Android Console: type 'help' for a list of commands
+                // OK
+                // a\u001b[K\u001b[Dav\u001b[K\u001b[D\u001b[Davd\u001b...
+                // <Name of image>
+                // OK
                 if (imageIdentifier && !isResolved) {
                     this.mapEmulatorIdToImageIdentifier[emulatorId] = imageIdentifier;
                     this.clearNetConnection(client, timer);
@@ -174,6 +188,8 @@ class AndroidVirtualDeviceService {
             if (this.pathToAvdManagerExecutable &&
                 this.$fs.exists(this.pathToAvdManagerExecutable)) {
                 if (process.env.JAVA_HOME) {
+                    // In case JAVA_HOME is set, but it points to incorrect directory (i.e. there's no java in $JAVA_HOME/bin/java), avdmanager will fail
+                    // no matter if you have correct java in PATH.
                     canExecute = !!(yield this.$sysInfo.getJavaVersionFromJavaHome());
                 }
                 else {
@@ -248,6 +264,13 @@ class AndroidVirtualDeviceService {
         const avdOutput = output.split(constants_1.AndroidVirtualDevice.AVAILABLE_AVDS_MESSAGE);
         const availableDevices = avdOutput && avdOutput[1] && avdOutput[1].trim();
         if (availableDevices) {
+            // In some cases `avdmanager list avds` command prints:
+            //	`The following Android Virtual Devices could not be loaded:
+            //	Name: Pixel_2_XL_API_28
+            //	Path: /Users/<username>/.android/avd/Pixel_2_XL_API_28.avd
+            //	Error: Google pixel_2_xl no longer exists as a device`
+            // These devices sometimes are valid so try to parse them.
+            // Also these devices are printed at the end of the output and are separated with 2 new lines from the valid devices output.
             const parts = availableDevices.split(/(?:\r?\n){2}/);
             const items = [parts[0], parts[1]].filter((item) => !!item);
             for (const item of items) {
@@ -264,6 +287,7 @@ class AndroidVirtualDeviceService {
     }
     getAvdManagerDeviceInfo(output) {
         const avdManagerDeviceInfo = Object.create(null);
+        // Split by `\n`, not EOL as the avdmanager and android executables print results with `\n` only even on Windows
         _.reduce(output.split("\n"), (result, row) => {
             const [key, value] = row.split(": ").map((part) => part.trim());
             switch (key) {
@@ -310,6 +334,7 @@ class AndroidVirtualDeviceService {
         };
     }
     getImageIdentifierFromClientOutput(output) {
+        // The lines should be trimmed after the split because the output has \r\n and when using split(EOL) on mac each line ends with \r.
         const lines = _.map(output.split(os_1.EOL), (line) => line.trim());
         const firstIndexOfOk = _.indexOf(lines, "OK");
         if (firstIndexOfOk < 0) {
@@ -358,3 +383,4 @@ __decorate([
 ], AndroidVirtualDeviceService.prototype, "getConfigurationError", null);
 exports.AndroidVirtualDeviceService = AndroidVirtualDeviceService;
 yok_1.injector.register("androidVirtualDeviceService", AndroidVirtualDeviceService);
+//# sourceMappingURL=android-virtual-device-service.js.map

package/lib/common/mobile/android/device-android-debug-bridge.js

@@ -46,3 +46,4 @@ class DeviceAndroidDebugBridge extends android_debug_bridge_1.AndroidDebugBridge
     }
 }
 exports.DeviceAndroidDebugBridge = DeviceAndroidDebugBridge;
+//# sourceMappingURL=device-android-debug-bridge.js.map

package/lib/common/mobile/android/genymotion/genymotion-service.js

@@ -54,6 +54,7 @@ class AndroidGenymotionService {
                 .map((row) => __awaiter(this, void 0, void 0, function* () {
                 const match = row.match(/^(.+?)\s+device$/);
                 if (match && match[1]) {
+                    // possible genymotion emulator
                     const emulatorId = match[1];
                     const result = (yield this.isGenymotionEmulator(emulatorId))
                         ? emulatorId
@@ -113,6 +114,7 @@ class AndroidGenymotionService {
             return runningEmulator;
         });
     }
+    // https://wiki.appcelerator.org/display/guides2/Installing+Genymotion
     get playerSearchPaths() {
         return {
             darwin: [
@@ -163,6 +165,7 @@ class AndroidGenymotionService {
         };
     }
     getSdkVersion(output) {
+        // Example -> Name: android_version, value: 6.0.0, timestamp: 1530090506102029000, flags:
         const androidApiLevelRow = output
             .split("\n")
             .filter((row) => !!row)
@@ -191,6 +194,7 @@ In case you have installed Genymotion in a different location, please add the pa
     getConfigurationError() {
         return __awaiter(this, void 0, void 0, function* () {
             const result = yield this.$childProcess.trySpawnFromCloseEvent(this.pathToEmulatorExecutable, [], {}, { throwError: false });
+            // When player is spawned, it always prints message on stderr.
             if (result &&
                 result.stderr &&
                 result.stderr.indexOf(constants_1.AndroidVirtualDevice.GENYMOTION_DEFAULT_STDERR_STRING) === -1) {
@@ -209,3 +213,4 @@ __decorate([
 ], AndroidGenymotionService.prototype, "getConfigurationError", null);
 exports.AndroidGenymotionService = AndroidGenymotionService;
 yok_1.injector.register("androidGenymotionService", AndroidGenymotionService);
+//# sourceMappingURL=genymotion-service.js.map

package/lib/common/mobile/android/genymotion/virtualbox-service.js

@@ -44,6 +44,7 @@ class VirtualBoxService {
                         .split(os_1.EOL)
                         .filter((row) => !!row)
                         .map((row) => {
+                        // Example row: "Google Nexus 4 - 5.0.0 - API 21 - 768x1280" {9d9beef2-cc60-4a54-bcc0-cc1dbf89811f}
                         const [rawName, rawId] = row.split('" ');
                         const id = rawId.substr(1, rawId.length - 2);
                         const name = rawName.substr(1, rawName.length - 1);
@@ -84,6 +85,15 @@ class VirtualBoxService {
             if (this.$hostInfo.isWindows) {
                 let searchPath = null;
                 try {
+                    /* This can be used as interface!!!!
+                        arch:null
+                        hive:"HKLM"
+                        host:""
+                        key:"\Software\Oracle\VirtualBox"
+                        name:"InstallDir"
+                        type:"REG_SZ"
+                        value:"C:\Program Files\Oracle\VirtualBox\"
+                    */
                     const result = yield (0, helpers_1.getWinRegPropertyValue)("\\Software\\Oracle\\VirtualBox", "InstallDir");
                     searchPath = result && result.value ? result.value : null;
                 }
@@ -119,3 +129,4 @@ __decorate([
 ], VirtualBoxService.prototype, "getvBoxManagePath", null);
 exports.VirtualBoxService = VirtualBoxService;
 yok_1.injector.register("virtualBoxService", VirtualBoxService);
+//# sourceMappingURL=virtualbox-service.js.map

package/lib/common/mobile/android/logcat-helper.js

@@ -50,6 +50,7 @@ class LogcatHelper {
                         }
                     }
                     catch (err) {
+                        // Ignore the error, the process is dead.
                     }
                 });
                 lineStream.on("data", (lineBuffer) => {
@@ -70,8 +71,15 @@ class LogcatHelper {
                         return;
                     const lines = (lineBuffer.toString() || "").split("\n");
                     for (let line of lines) {
-                        if (line.includes("START") &&
+                        // 09-11 17:50:26.311   598  1979 I ActivityTaskManager: START u0 {flg=0x10000000 cmp=org.nativescript.myApp/com.tns.NativeScriptActivity} from uid 2000
+                        //                                                       ^^^^^                          ^^^^^^^^^^^^^^^^^^^^^^                                        ^^^^
+                        // 																										   action                         appId                                                         pid
+                        if (
+                        // action
+                        line.includes("START") &&
+                            // appId
                             line.includes(options.appId) &&
+                            // pid - only if it's not the current pid...
                             !line.includes(options.pid)) {
                             this.forceStop(deviceIdentifier);
                             (_b = options.onAppRestarted) === null || _b === void 0 ? void 0 : _b.call(options);
@@ -98,6 +106,9 @@ class LogcatHelper {
             });
         });
     }
+    /**
+     * Stops the logcat process for the specified device if keepSingleProcess is not passed on start
+     */
     stop(deviceIdentifier) {
         if (this.mapDevicesLoggingData[deviceIdentifier] &&
             !this.mapDevicesLoggingData[deviceIdentifier].keepSingleProcess) {
@@ -114,6 +125,9 @@ class LogcatHelper {
         (_e = loggingData.lineStream) === null || _e === void 0 ? void 0 : _e.removeAllListeners();
         delete this.mapDevicesLoggingData[deviceIdentifier];
     }
+    /**
+     * @deprecated - we likely don't need this anymore, and can simplify the code...
+     */
     isLogcatPidSupported(deviceIdentifier) {
         return __awaiter(this, void 0, void 0, function* () {
             const device = yield this.$devicesService.getDevice(deviceIdentifier);
@@ -126,6 +140,7 @@ class LogcatHelper {
         return __awaiter(this, void 0, void 0, function* () {
             const isLogcatPidSupported = yield this.isLogcatPidSupported(deviceIdentifier);
             const adb = this.$injector.resolve(device_android_debug_bridge_1.DeviceAndroidDebugBridge, { identifier: deviceIdentifier });
+            // -T 1 - shows only new logs after starting adb logcat
             const logcatCommand = ["logcat", "-T", "1"];
             const acceptedTags = [
                 "chromium",
@@ -138,6 +153,7 @@ class LogcatHelper {
             if (pid && isLogcatPidSupported) {
                 logcatCommand.push(`--pid=${pid}`);
                 acceptedTags.forEach((tag) => {
+                    // -s <tag> - shows only logs with the specified tag
                     logcatCommand.push("-s", tag);
                 });
             }
@@ -150,6 +166,8 @@ class LogcatHelper {
     getAppStartTrackingLogcatStream(deviceIdentifier, appId) {
         return __awaiter(this, void 0, void 0, function* () {
             const adb = this.$injector.resolve(device_android_debug_bridge_1.DeviceAndroidDebugBridge, { identifier: deviceIdentifier });
+            // -b system  - shows the system buffer/logs only
+            // -T 1 			- shows only new logs after starting adb logcat
             const logcatCommand = [`logcat`, `-b`, `system`, `-T`, `1`];
             if (appId) {
                 logcatCommand.push(`--regex=START.*${appId}`);
@@ -163,3 +181,4 @@ class LogcatHelper {
 }
 exports.LogcatHelper = LogcatHelper;
 yok_1.injector.register("logcatHelper", LogcatHelper);
+//# sourceMappingURL=logcat-helper.js.map

package/lib/common/mobile/application-manager-base.js

@@ -54,6 +54,9 @@ class ApplicationManagerBase extends events_1.EventEmitter {
             if (!this.checkForApplicationUpdatesPromise) {
                 this.checkForApplicationUpdatesPromise = new Promise((resolve, reject) => __awaiter(this, void 0, void 0, function* () {
                     let isFulfilled = false;
+                    // As this method is called on 500ms, but it's execution may last much longer
+                    // use locking, so the next executions will not get into the body, while the first one is still working.
+                    // In case we do not break the next executions, we'll report each app as newly installed several times.
                     try {
                         const currentlyInstalledAppIdentifiers = yield this.getInstalledApplications();
                         const previouslyInstalledAppIdentifiers = this.lastInstalledAppIdentifiers || [];
@@ -102,6 +105,7 @@ class ApplicationManagerBase extends events_1.EventEmitter {
             _.each(notAvailableAppsForDebugging, (appInfo) => {
                 this.emit("debuggableAppLost", appInfo);
                 if (_.has(this.lastAvailableDebuggableAppViews, appInfo.appIdentifier)) {
+                    // Prevent emitting debuggableViewLost when application cannot be debugged anymore.
                     delete this.lastAvailableDebuggableAppViews[appInfo.appIdentifier];
                 }
             });
@@ -120,6 +124,7 @@ class ApplicationManagerBase extends events_1.EventEmitter {
                 _.each(newAvailableViews, (debugWebViewInfo) => {
                     this.emit("debuggableViewFound", appIdentifier, debugWebViewInfo);
                 });
+                // Determine which of the views had changed since last check and raise debuggableViewChanged event for them:
                 const keptViews = _.differenceBy(currentlyAvailableViews, newAvailableViews, "id");
                 _.each(keptViews, (view) => {
                     const previousTimeViewInfo = _.find(previouslyAvailableViews, (previousView) => previousView.id === view.id);
@@ -133,3 +138,4 @@ class ApplicationManagerBase extends events_1.EventEmitter {
     }
 }
 exports.ApplicationManagerBase = ApplicationManagerBase;
+//# sourceMappingURL=application-manager-base.js.map