nativescript 8.7.0-rc.0 → 8.7.0-rc.2

package/lib/node-package-manager.js

@@ -47,8 +47,12 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
             }
             params = params.concat(flags);
             const cwd = pathToSave;
+            // Npm creates `etc` directory in installation dir when --prefix is passed
+            // https://github.com/npm/npm/issues/11486
+            // we should delete it if it was created because of us
             const etcDirectoryLocation = (0, path_1.join)(cwd, "etc");
             const etcExistsPriorToInstallation = this.$fs.exists(etcDirectoryLocation);
+            //TODO: plamen5kov: workaround is here for a reason (remove whole file later)
             if (config.path) {
                 let relativePathFromCwdToSource = "";
                 if (config.frameworkPath) {
@@ -64,9 +68,13 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
             }
             catch (err) {
                 if (err.message && err.message.indexOf("EPEERINVALID") !== -1) {
+                    // Not installed peer dependencies are treated by npm 2 as errors, but npm 3 treats them as warnings.
+                    // We'll show them as warnings and let the user install them in case they are needed.
                     this.$logger.warn(err.message);
                 }
                 else {
+                    // All other errors should be handled by the caller code.
+                    // Revert package.json contents to preserve valid state
                     this.$fs.writeJson(packageJsonPath, jsonContentBefore);
                     throw err;
                 }
@@ -94,7 +102,7 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
     }
     view(packageName, config) {
         return __awaiter(this, void 0, void 0, function* () {
-            const wrappedConfig = _.extend({}, config, { json: true });
+            const wrappedConfig = _.extend({}, config, { json: true }); // always require view response as JSON
             const flags = this.getFlagsString(wrappedConfig, false);
             let viewResult;
             try {
@@ -113,6 +121,7 @@ class NodePackageManager extends base_package_manager_1.BasePackageManager {
     }
     searchNpms(keyword) {
         return __awaiter(this, void 0, void 0, function* () {
+            // TODO: Fix the generation of url - in case it contains @ or / , the call may fail.
             const httpRequestResult = yield this.$httpClient.httpRequest(`https://api.npms.io/v2/search?q=keywords:${keyword}`);
             const result = JSON.parse(httpRequestResult.body);
             return result;
@@ -154,3 +163,4 @@ __decorate([
 ], NodePackageManager.prototype, "getCachePath", null);
 exports.NodePackageManager = NodePackageManager;
 yok_1.injector.register("npm", NodePackageManager);
+//# sourceMappingURL=node-package-manager.js.map

package/lib/options.js

@@ -22,6 +22,7 @@ class Options {
             this.setArgv();
         }
         this.argv.bundle = "webpack";
+        // Check if the user has explicitly provide --hmr and --release options from command line
         if (this.initialArgv.release && this.initialArgv.hmr) {
             this.$errors.fail("The options --release and --hmr cannot be used simultaneously.");
         }
@@ -29,6 +30,8 @@ class Options {
             this.argv.hmr = !this.argv.release;
         }
         if (this.argv.debugBrk) {
+            // we cannot use HMR along with debug-brk because we have to restart the app
+            // on each livesync in order to stop and allow debugging on app start
             this.argv.hmr = false;
         }
         if (this.argv.justlaunch) {
@@ -46,17 +49,18 @@ class Options {
             "timeout",
             "_",
             "$0",
-        ];
+        ]; // These options shouldn't be validated
         this.globalOptions = {
-            log: { type: "string", hasSensitiveValue: false },
-            verbose: { type: "boolean", hasSensitiveValue: false },
-            version: { type: "boolean", alias: "v", hasSensitiveValue: false },
-            help: { type: "boolean", alias: "h", hasSensitiveValue: false },
-            profileDir: { type: "string", hasSensitiveValue: true },
-            analyticsClient: { type: "string", hasSensitiveValue: false },
-            path: { type: "string", alias: "p", hasSensitiveValue: true },
-            config: { type: "string", alias: "c", hasSensitiveValue: true },
-            _: { type: "string", hasSensitiveValue: false },
+            log: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            verbose: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            version: { type: "boolean" /* OptionType.Boolean */, alias: "v", hasSensitiveValue: false },
+            help: { type: "boolean" /* OptionType.Boolean */, alias: "h", hasSensitiveValue: false },
+            profileDir: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            analyticsClient: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            path: { type: "string" /* OptionType.String */, alias: "p", hasSensitiveValue: true },
+            config: { type: "string" /* OptionType.String */, alias: "c", hasSensitiveValue: true },
+            // This will parse all non-hyphenated values as strings.
+            _: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
         };
         this.options = _.extend({}, this.commonOptions, this.globalOptions);
         this.setArgv();
@@ -72,155 +76,157 @@ class Options {
     }
     get commonOptions() {
         return {
-            ipa: { type: "string", hasSensitiveValue: true },
-            frameworkPath: { type: "string", hasSensitiveValue: true },
-            frameworkName: { type: "string", hasSensitiveValue: false },
-            framework: { type: "string", hasSensitiveValue: false },
-            frameworkVersion: { type: "string", hasSensitiveValue: false },
-            forDevice: { type: "boolean", hasSensitiveValue: false },
+            ipa: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            frameworkPath: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            frameworkName: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            framework: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            frameworkVersion: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            forDevice: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
             iCloudContainerEnvironment: {
-                type: "string",
+                type: "string" /* OptionType.String */,
                 hasSensitiveValue: false,
             },
-            provision: { type: "object", hasSensitiveValue: true },
+            provision: { type: "object" /* OptionType.Object */, hasSensitiveValue: true },
             client: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 default: true,
                 hasSensitiveValue: false,
             },
-            env: { type: "object", hasSensitiveValue: false },
-            production: { type: "boolean", hasSensitiveValue: false },
-            debugTransport: { type: "boolean", hasSensitiveValue: false },
-            keyStorePath: { type: "string", hasSensitiveValue: true },
-            keyStorePassword: { type: "string", hasSensitiveValue: true },
-            keyStoreAlias: { type: "string", hasSensitiveValue: true },
+            env: { type: "object" /* OptionType.Object */, hasSensitiveValue: false },
+            production: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            debugTransport: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            keyStorePath: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            keyStorePassword: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            keyStoreAlias: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
             keyStoreAliasPassword: {
-                type: "string",
+                type: "string" /* OptionType.String */,
                 hasSensitiveValue: true,
             },
-            ignoreScripts: { type: "boolean", hasSensitiveValue: false },
-            disableNpmInstall: { type: "boolean", hasSensitiveValue: false },
-            compileSdk: { type: "number", hasSensitiveValue: false },
-            port: { type: "number", hasSensitiveValue: false },
-            copyTo: { type: "string", hasSensitiveValue: true },
-            js: { type: "boolean", hasSensitiveValue: false },
-            javascript: { type: "boolean", hasSensitiveValue: false },
-            ng: { type: "boolean", hasSensitiveValue: false },
-            angular: { type: "boolean", hasSensitiveValue: false },
-            react: { type: "boolean", hasSensitiveValue: false },
-            reactjs: { type: "boolean", hasSensitiveValue: false },
-            vue: { type: "boolean", hasSensitiveValue: false },
-            vuejs: { type: "boolean", hasSensitiveValue: false },
-            svelte: { type: "boolean", hasSensitiveValue: false },
-            "vision-ng": { type: "boolean", hasSensitiveValue: false },
-            "vision-react": { type: "boolean", hasSensitiveValue: false },
-            "vision-solid": { type: "boolean", hasSensitiveValue: false },
-            "vision-svelte": { type: "boolean", hasSensitiveValue: false },
-            "vision-vue": { type: "boolean", hasSensitiveValue: false },
-            tsc: { type: "boolean", hasSensitiveValue: false },
-            ts: { type: "boolean", hasSensitiveValue: false },
-            typescript: { type: "boolean", hasSensitiveValue: false },
-            yarn: { type: "boolean", hasSensitiveValue: false },
-            yarn2: { type: "boolean", hasSensitiveValue: false },
-            pnpm: { type: "boolean", hasSensitiveValue: false },
-            androidTypings: { type: "boolean", hasSensitiveValue: false },
-            bundle: { type: "string", hasSensitiveValue: false },
-            all: { type: "boolean", hasSensitiveValue: false },
-            teamId: { type: "object", hasSensitiveValue: true },
-            chrome: { type: "boolean", hasSensitiveValue: false },
-            inspector: { type: "boolean", hasSensitiveValue: false },
-            clean: { type: "boolean", hasSensitiveValue: false },
+            ignoreScripts: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            disableNpmInstall: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            compileSdk: { type: "number" /* OptionType.Number */, hasSensitiveValue: false },
+            port: { type: "number" /* OptionType.Number */, hasSensitiveValue: false },
+            copyTo: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            js: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            javascript: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            ng: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            angular: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            react: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            reactjs: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            vue: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            vuejs: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            svelte: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            vision: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            "vision-ng": { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            "vision-react": { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            "vision-solid": { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            "vision-svelte": { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            "vision-vue": { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            tsc: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            ts: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            typescript: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            yarn: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            yarn2: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            pnpm: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            androidTypings: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            bundle: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            all: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            teamId: { type: "object" /* OptionType.Object */, hasSensitiveValue: true },
+            chrome: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            inspector: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            clean: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
             watch: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 default: true,
                 hasSensitiveValue: false,
             },
-            background: { type: "string", hasSensitiveValue: false },
-            username: { type: "string", hasSensitiveValue: true },
-            pluginName: { type: "string", hasSensitiveValue: false },
+            background: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            username: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            pluginName: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
             includeTypeScriptDemo: {
-                type: "string",
+                type: "string" /* OptionType.String */,
                 hasSensitiveValue: false,
             },
-            includeAngularDemo: { type: "string", hasSensitiveValue: false },
+            includeAngularDemo: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
             hmr: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 hasSensitiveValue: false,
                 default: true,
             },
             collection: {
-                type: "string",
+                type: "string" /* OptionType.String */,
                 alias: "c",
                 hasSensitiveValue: false,
             },
-            json: { type: "boolean", hasSensitiveValue: false },
-            avd: { type: "string", hasSensitiveValue: true },
-            config: { type: "array", hasSensitiveValue: false },
+            json: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            avd: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            // check not used
+            config: { type: "array" /* OptionType.Array */, hasSensitiveValue: false },
             insecure: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 alias: "k",
                 hasSensitiveValue: false,
             },
-            debug: { type: "boolean", alias: "d", hasSensitiveValue: false },
-            timeout: { type: "string", hasSensitiveValue: false },
-            device: { type: "string", hasSensitiveValue: true },
-            availableDevices: { type: "boolean", hasSensitiveValue: false },
-            appid: { type: "string", hasSensitiveValue: true },
-            geny: { type: "string", hasSensitiveValue: true },
-            debugBrk: { type: "boolean", hasSensitiveValue: false },
-            debugPort: { type: "number", hasSensitiveValue: false },
-            start: { type: "boolean", hasSensitiveValue: false },
-            stop: { type: "boolean", hasSensitiveValue: false },
-            ddi: { type: "string", hasSensitiveValue: true },
-            justlaunch: { type: "boolean", hasSensitiveValue: false },
-            file: { type: "string", hasSensitiveValue: true },
-            force: { type: "boolean", alias: "f", hasSensitiveValue: false },
-            emulator: { type: "boolean", hasSensitiveValue: false },
-            simulator: { type: "boolean", hasSensitiveValue: false },
-            sdk: { type: "string", hasSensitiveValue: false },
-            template: { type: "string", hasSensitiveValue: true },
-            certificate: { type: "string", hasSensitiveValue: true },
-            certificatePassword: { type: "string", hasSensitiveValue: true },
+            debug: { type: "boolean" /* OptionType.Boolean */, alias: "d", hasSensitiveValue: false },
+            timeout: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            device: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            availableDevices: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            appid: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            geny: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            debugBrk: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            debugPort: { type: "number" /* OptionType.Number */, hasSensitiveValue: false },
+            start: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            stop: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            ddi: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            justlaunch: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            file: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            force: { type: "boolean" /* OptionType.Boolean */, alias: "f", hasSensitiveValue: false },
+            emulator: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            simulator: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            sdk: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            template: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            certificate: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            certificatePassword: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
             release: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 alias: "r",
                 hasSensitiveValue: false,
             },
-            markingMode: { type: "boolean", hasSensitiveValue: false },
-            var: { type: "object", hasSensitiveValue: true },
-            default: { type: "boolean", hasSensitiveValue: false },
-            count: { type: "number", hasSensitiveValue: false },
-            analyticsLogFile: { type: "string", hasSensitiveValue: true },
-            disableAnalytics: { type: "boolean", hasSensitiveValue: false },
-            cleanupLogFile: { type: "string", hasSensitiveValue: true },
+            markingMode: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            var: { type: "object" /* OptionType.Object */, hasSensitiveValue: true },
+            default: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            count: { type: "number" /* OptionType.Number */, hasSensitiveValue: false },
+            analyticsLogFile: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            disableAnalytics: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            cleanupLogFile: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
             hooks: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 default: true,
                 hasSensitiveValue: false,
             },
             link: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 default: false,
                 hasSensitiveValue: false,
             },
-            gradlePath: { type: "string", hasSensitiveValue: false },
-            gradleArgs: { type: "string", hasSensitiveValue: false },
-            aab: { type: "boolean", hasSensitiveValue: false },
-            performance: { type: "object", hasSensitiveValue: true },
+            gradlePath: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            gradleArgs: { type: "string" /* OptionType.String */, hasSensitiveValue: false },
+            aab: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
+            performance: { type: "object" /* OptionType.Object */, hasSensitiveValue: true },
             appleApplicationSpecificPassword: {
-                type: "string",
+                type: "string" /* OptionType.String */,
                 hasSensitiveValue: true,
             },
-            appleSessionBase64: { type: "string", hasSensitiveValue: true },
-            jar: { type: "string", hasSensitiveValue: true },
-            aar: { type: "string", hasSensitiveValue: true },
-            filter: { type: "string", hasSensitiveValue: true },
+            appleSessionBase64: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            jar: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            aar: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
+            filter: { type: "string" /* OptionType.String */, hasSensitiveValue: true },
             git: {
-                type: "boolean",
+                type: "boolean" /* OptionType.Boolean */,
                 hasSensitiveValue: false,
                 default: true,
             },
-            dryRun: { type: "boolean", hasSensitiveValue: false },
+            dryRun: { type: "boolean" /* OptionType.Boolean */, hasSensitiveValue: false },
         };
     }
     get optionNames() {
@@ -238,6 +244,7 @@ class Options {
             parsed[optionName] = this.getOptionValue(optionName);
         }
         _.each(parsed, (value, originalOptionName) => {
+            // when this.options are passed to yargs, it returns all of them and the ones that are not part of process.argv are set to undefined.
             if (value === undefined) {
                 return;
             }
@@ -247,14 +254,14 @@ class Options {
                     this.$errors.failWithHelp(`The option '${originalOptionName}' is not supported.`);
                 }
                 const optionType = this.getOptionType(optionName), optionValue = parsed[optionName];
-                if (_.isArray(optionValue) && optionType !== "array") {
+                if (_.isArray(optionValue) && optionType !== "array" /* OptionType.Array */) {
                     this.$errors.failWithHelp("The '%s' option requires a single value.", originalOptionName);
                 }
-                else if (optionType === "string" &&
+                else if (optionType === "string" /* OptionType.String */ &&
                     helpers.isNullOrWhitespace(optionValue)) {
                     this.$errors.failWithHelp("The option '%s' requires non-empty value.", originalOptionName);
                 }
-                else if (optionType === "array" &&
+                else if (optionType === "array" /* OptionType.Array */ &&
                     optionValue.length === 0) {
                     this.$errors.failWithHelp(`The option '${originalOptionName}' requires one or more values, separated by a space.`);
                 }
@@ -282,9 +289,16 @@ class Options {
         }
         return true;
     }
+    // If you pass value with dash, yargs adds it to yargs.argv in two ways:
+    // with dash and without dash, replacing first symbol after it with its toUpper equivalent
+    // ex, "$ <cli name> emulate android --profile-dir" will add profile-dir to yargs.argv as profile-dir and profileDir
+    // IMPORTANT: In your code, it is better to use the value without dashes (profileDir in the example).
+    // This way your code will work in case "$ <cli name> emulate android --profile-dir" or "$ <cli name> emulate android --profileDir" is used by user.
     getNonDashedOptionName(optionName) {
         const matchUpperCaseLetters = optionName.match(Options.NONDASHED_OPTION_REGEX);
         if (matchUpperCaseLetters) {
+            // get here if option with upperCase letter is specified, for example profileDir
+            // check if in knownOptions we have its kebabCase presentation
             const secondaryOptionName = matchUpperCaseLetters[1] +
                 matchUpperCaseLetters[2].toUpperCase() +
                 matchUpperCaseLetters[3] || "";
@@ -313,15 +327,18 @@ class Options {
             const args = argv._.slice(1);
             const commands = yok_1.injector
                 .getRegisteredCommandsNames(false)
-                .filter((c) => c != "/?");
+                .filter((c) => c != "/?"); // remove the /? command, looks weird... :D
             const currentDepth = args.length > 0 ? args.length - 1 : 0;
             const current = (_a = current_ !== null && current_ !== void 0 ? current_ : args[currentDepth]) !== null && _a !== void 0 ? _a : "";
+            // split all commands into their components ie. "device|list" => ["device", "list"]
             const matchGroups = commands.map((c) => c.split("|"));
+            // find all commands that match the current depth and all the previous args
             const possibleMatches = matchGroups.filter((group) => {
                 return group.slice(0, currentDepth).every((g, i) => {
                     return g === args[i] || args[i].at(0) === "-";
                 });
             });
+            // filter out duplicates
             const completions = [
                 ...new Set(possibleMatches
                     .map((match) => {
@@ -329,21 +346,28 @@ class Options {
                 })
                     .filter(Boolean)),
             ];
+            // autocomplete long -- options
             if (current.startsWith("--")) {
                 return this.optionNames.filter((o) => o !== "_").map((o) => `--${o}`);
             }
+            // autocomple short - options
             if (current.startsWith("-")) {
                 return this.shorthands.map((o) => `-${o}`);
             }
+            // autocomplete matched completions
             return completions;
         }));
         this.initialArgv = parsed.argv;
         this.argv = parsed.options(opts).argv;
+        // For backwards compatibility
+        // Previously profileDir had a default option and calling `this.$options.profileDir` always returned valid result.
+        // Now the profileDir should be used from $settingsService, but ensure the `this.$options.profileDir` returns the same value.
         this.$settingsService.setSettings({
             profileDir: this.argv.profileDir,
         });
         this.argv.profileDir = this.argv["profile-dir"] =
             this.$settingsService.getProfileDir();
+        // if justlaunch is set, it takes precedence over the --watch flag and the default true value
         if (this.argv.justlaunch) {
             this.argv.watch = false;
         }
@@ -359,6 +383,7 @@ class Options {
         if (this.argv.javascript) {
             this.argv.js = true;
         }
+        // alias --simulator to --emulator
         if (this.argv.simulator) {
             this.argv.emulator = this.argv.simulator;
         }
@@ -383,3 +408,4 @@ Options.DASHED_OPTION_REGEX = /(.+?)([A-Z])(.*)/;
 Options.NONDASHED_OPTION_REGEX = /(.+?)[-]([a-zA-Z])(.*)/;
 exports.Options = Options;
 yok_1.injector.register("options", Options);
+//# sourceMappingURL=options.js.map

package/lib/package-installation-manager.js

@@ -38,6 +38,7 @@ class PackageInstallationManager {
         return __awaiter(this, void 0, void 0, function* () {
             referenceVersion = referenceVersion || this.$staticConfig.version;
             const isPreReleaseVersion = semver.prerelease(referenceVersion) !== null;
+            // if the user has some v.v.v-prerelease-xx.xx pre-release version, include pre-release versions in the search query.
             const compatibleVersionRange = isPreReleaseVersion
                 ? `~${referenceVersion}`
                 : `~${semver.major(referenceVersion)}.${semver.minor(referenceVersion)}.0`;
@@ -133,13 +134,14 @@ class PackageInstallationManager {
     getInspectorFromCache(inspectorNpmPackageName, projectDir) {
         return __awaiter(this, void 0, void 0, function* () {
             const inspectorPath = path.join(projectDir, constants.NODE_MODULES_FOLDER_NAME, inspectorNpmPackageName);
+            // local installation takes precedence over cache
             if (this.inspectorAlreadyInstalled(inspectorPath)) {
                 return inspectorPath;
             }
             const cachePath = this.getInspectorCachePath();
             this.prepareCacheDir(cachePath);
             const pathToPackageInCache = path.join(cachePath, constants.NODE_MODULES_FOLDER_NAME, inspectorNpmPackageName);
-            const iOSFrameworkNSValue = this.$projectDataService.getRuntimePackage(projectDir, "ios");
+            const iOSFrameworkNSValue = this.$projectDataService.getRuntimePackage(projectDir, "ios" /* constants.PlatformTypes.ios */);
             const version = yield this.getLatestCompatibleVersion(inspectorNpmPackageName, iOSFrameworkNSValue.version);
             let shouldInstall = !this.$fs.exists(pathToPackageInCache);
             if (!shouldInstall) {
@@ -205,6 +207,10 @@ class PackageInstallationManager {
             return yield this.$packageManager.install(packageName, pathToSave, npmOptions);
         });
     }
+    /**
+     * This function must not be used with packageName being a URL or local file,
+     * because npm view doens't work with those
+     */
     getVersion(packageName, version) {
         var _a;
         return __awaiter(this, void 0, void 0, function* () {
@@ -219,3 +225,4 @@ class PackageInstallationManager {
 }
 exports.PackageInstallationManager = PackageInstallationManager;
 yok_1.injector.register("packageInstallationManager", PackageInstallationManager);
+//# sourceMappingURL=package-installation-manager.js.map

package/lib/package-manager.js

@@ -113,6 +113,7 @@ class PackageManager {
                 }
             }
             catch (err) {
+                // ignore error, but log info
                 this.$logger.trace("Tried to read cli.packageManager from project config and failed. Error is: ", err);
             }
             if (pm === constants_1.PackageManagers.yarn || this.$options.yarn) {
@@ -177,3 +178,4 @@ __decorate([
 ], PackageManager.prototype, "getCachePath", null);
 exports.PackageManager = PackageManager;
 yok_1.injector.register("packageManager", PackageManager);
+//# sourceMappingURL=package-manager.js.map

package/lib/platform-command-param.js

@@ -27,3 +27,4 @@ class PlatformCommandParameter {
 }
 exports.PlatformCommandParameter = PlatformCommandParameter;
 yok_1.injector.register("platformCommandParameter", PlatformCommandParameter);
+//# sourceMappingURL=platform-command-param.js.map

package/lib/pnpm-package-manager.js

@@ -34,13 +34,14 @@ class PnpmPackageManager extends base_package_manager_1.BasePackageManager {
             if (config.disableNpmInstall) {
                 return;
             }
-            delete config.dev;
+            delete config.dev; // temporary fix for unsupported yarn flag
             if (config.ignoreScripts) {
                 config["ignore-scripts"] = true;
             }
             const packageJsonPath = path.join(pathToSave, "package.json");
             const jsonContentBefore = this.$fs.readJson(packageJsonPath);
             const flags = this.getFlagsString(config, true);
+            // With pnpm we need to install as "flat" or some imports wont be found
             let params = ["i", "--shamefully-hoist"];
             const isInstallingAllDependencies = packageName === pathToSave;
             if (!isInstallingAllDependencies) {
@@ -59,6 +60,7 @@ class PnpmPackageManager extends base_package_manager_1.BasePackageManager {
         });
     }
     uninstall(packageName, config, cwd) {
+        // pnpm does not want save option in remove. It saves it by default
         delete config["save"];
         const flags = this.getFlagsString(config, false);
         return this.$childProcess.exec(`pnpm remove ${packageName} ${flags}`, {
@@ -134,3 +136,4 @@ __decorate([
 ], PnpmPackageManager.prototype, "getCachePath", null);
 exports.PnpmPackageManager = PnpmPackageManager;
 yok_1.injector.register("pnpm", PnpmPackageManager);
+//# sourceMappingURL=pnpm-package-manager.js.map

package/lib/project-data.js

@@ -19,6 +19,7 @@ class ProjectData {
         this.warnProjectId();
         return this.projectIdentifiers.ios;
     }
+    //just in case hook/extension modifies it.
     set projectId(identifier) {
         this.warnProjectId();
         this.projectIdentifiers.ios = identifier;
@@ -44,6 +45,7 @@ class ProjectData {
             return;
         }
         projectDir = projectDir || this.$projectHelper.projectDir;
+        // If no project found, projectDir should be null
         if (projectDir) {
             const projectFilePath = this.getProjectFilePath(projectDir);
             if (this.$fs.exists(projectFilePath)) {
@@ -107,6 +109,7 @@ class ProjectData {
     errorInvalidProject(projectDir) {
         const currentDir = path.resolve(".");
         this.$logger.trace(`Unable to find project. projectDir: ${projectDir}, options.path: ${this.$options.path}, ${currentDir}`);
+        // This is the case when no project file found
         this.$errors.fail("No project found at or above '%s' and neither was a --path specified.", projectDir || this.$options.path || currentDir);
     }
     getProjectFilePath(projectDir) {
@@ -122,6 +125,10 @@ class ProjectData {
             return this.nsConfig[constants.CONFIG_NS_APP_RESOURCES_ENTRY];
         }
         return constants.APP_RESOURCES_FOLDER_NAME;
+        // return path.join(
+        // 	this.getAppDirectoryRelativePath(),
+        // 	constants.APP_RESOURCES_FOLDER_NAME
+        // );
     }
     getAppDirectoryPath(projectDir) {
         const appRelativePath = this.getAppDirectoryRelativePath();
@@ -135,6 +142,7 @@ class ProjectData {
             return constants.SRC_DIR;
         }
         else {
+            // legacy project setup often uses app folder
             return constants.APP_FOLDER_NAME;
         }
     }
@@ -191,6 +199,9 @@ class ProjectData {
         this.$logger.warn("[WARNING]: IProjectData.projectId is deprecated. Please use IProjectData.projectIdentifiers[platform].");
     }
 }
+/**
+ * NOTE: Order of the elements is important as the TypeScript dependencies are commonly included in Angular project as well.
+ */
 ProjectData.PROJECT_TYPES = [
     {
         type: constants.ProjectTypes.JsFlavorName,
@@ -229,3 +240,4 @@ __decorate([
 ], ProjectData.prototype, "warnProjectId", null);
 exports.ProjectData = ProjectData;
 yok_1.injector.register("projectData", ProjectData, true);
+//# sourceMappingURL=project-data.js.map

package/lib/providers/project-files-provider.js

@@ -44,3 +44,4 @@ class ProjectFilesProvider extends project_files_provider_base_1.ProjectFilesPro
 ProjectFilesProvider.INTERNAL_NONPROJECT_FILES = ["**/*.ts"];
 exports.ProjectFilesProvider = ProjectFilesProvider;
 yok_1.injector.register("projectFilesProvider", ProjectFilesProvider);
+//# sourceMappingURL=project-files-provider.js.map

package/lib/resolvers/livesync-service-resolver.js

@@ -9,7 +9,7 @@ class LiveSyncServiceResolver {
         this.$mobileHelper = $mobileHelper;
     }
     resolveLiveSyncService(platform) {
-        if (this.$mobileHelper.isApplePlatfrom(platform)) {
+        if (this.$mobileHelper.isApplePlatform(platform)) {
             return this.$injector.resolve("iOSLiveSyncService");
         }
         else if (this.$mobileHelper.isAndroidPlatform(platform)) {
@@ -20,3 +20,4 @@ class LiveSyncServiceResolver {
 }
 exports.LiveSyncServiceResolver = LiveSyncServiceResolver;
 yok_1.injector.register("liveSyncServiceResolver", LiveSyncServiceResolver);
+//# sourceMappingURL=livesync-service-resolver.js.map