nativescript 8.7.0-rc.0 → 8.7.0-rc.2

package/lib/services/ios-watch-app-service.js

@@ -74,3 +74,4 @@ IOSWatchAppService.WATCH_APP_IDENTIFIER = "watchkitapp";
 IOSWatchAppService.WACTCH_EXTENSION_IDENTIFIER = "watchkitextension";
 exports.IOSWatchAppService = IOSWatchAppService;
 yok_1.injector.register("iOSWatchAppService", IOSWatchAppService);
+//# sourceMappingURL=ios-watch-app-service.js.map

package/lib/services/ip-service.js

@@ -52,6 +52,7 @@ class IPService {
     }
     getIPAddressFromIpifyOrgAPI() {
         return __awaiter(this, void 0, void 0, function* () {
+            // https://www.ipify.org/
             const ipifyOrgAPIEndpoint = "https://api.ipify.org";
             let ipAddress = null;
             try {
@@ -76,3 +77,4 @@ __decorate([
 ], IPService.prototype, "getCurrentIPv4Address", null);
 exports.IPService = IPService;
 yok_1.injector.register("ipService", IPService);
+//# sourceMappingURL=ip-service.js.map

package/lib/services/itmstransporter-service.js

@@ -214,3 +214,4 @@ __decorate([
 ], ITMSTransporterService.prototype, "getITMSTransporterPath", null);
 exports.ITMSTransporterService = ITMSTransporterService;
 yok_1.injector.register("itmsTransporterService", ITMSTransporterService);
+//# sourceMappingURL=itmstransporter-service.js.map

package/lib/services/karma-execution.js

@@ -9,8 +9,10 @@ process.on("message", (data) => {
         });
         const KarmaServer = require(path.join(pathToKarma, "lib/server"));
         const karma = new KarmaServer(data.karmaConfig, (exitCode) => {
+            // Exit with the correct exit code and signal the manager process.
             process.exit(exitCode);
         });
         karma.start();
     }
 });
+//# sourceMappingURL=karma-execution.js.map

package/lib/services/livesync/android-device-livesync-service-base.js

@@ -66,3 +66,4 @@ class AndroidDeviceLiveSyncServiceBase extends device_livesync_service_base_1.De
     }
 }
 exports.AndroidDeviceLiveSyncServiceBase = AndroidDeviceLiveSyncServiceBase;
+//# sourceMappingURL=android-device-livesync-service-base.js.map

package/lib/services/livesync/android-device-livesync-service.js

@@ -119,6 +119,7 @@ class AndroidDeviceLiveSyncService extends android_device_livesync_service_base_
             ]);
             const regex = new RegExp(`^-.*${deviceRootBasename}$`, "m");
             const matchingFile = (listResult || "").match(regex);
+            // Check if there is already a file with deviceRootBasename. If so, delete it as it breaks LiveSyncing.
             if (matchingFile && matchingFile[0] && _.startsWith(matchingFile[0], "-")) {
                 yield this.device.adb.executeShellCommand(["rm", "-f", deviceRootPath]);
             }
@@ -201,3 +202,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], AndroidDeviceLiveSyncService.prototype, "removeFiles", null);
 exports.AndroidDeviceLiveSyncService = AndroidDeviceLiveSyncService;
+//# sourceMappingURL=android-device-livesync-service.js.map

package/lib/services/livesync/android-device-livesync-sockets-service.js

@@ -112,6 +112,8 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
                     yield this.$cleanupService.removeCleanupCommand(cleanupCommand);
                 });
                 yield this.$cleanupService.addCleanupCommand(cleanupCommand);
+                // We need to clear resources when the action fails
+                // But we also need the real result of the action.
                 yield doSyncPromise.then(actionOnEnd.bind(this), actionOnEnd.bind(this));
                 result = yield doSyncPromise;
             }
@@ -196,3 +198,4 @@ class AndroidDeviceSocketsLiveSyncService extends android_device_livesync_servic
 AndroidDeviceSocketsLiveSyncService.STATUS_UPDATE_INTERVAL = 10000;
 AndroidDeviceSocketsLiveSyncService.MINIMAL_VERSION_LONG_LIVING_CONNECTION = "0.2.0";
 exports.AndroidDeviceSocketsLiveSyncService = AndroidDeviceSocketsLiveSyncService;
+//# sourceMappingURL=android-device-livesync-sockets-service.js.map

package/lib/services/livesync/android-livesync-service.js

@@ -74,3 +74,4 @@ __decorate([
 ], AndroidLiveSyncService.prototype, "fullSync", null);
 exports.AndroidLiveSyncService = AndroidLiveSyncService;
 yok_1.injector.register("androidLiveSyncService", AndroidLiveSyncService);
+//# sourceMappingURL=android-livesync-service.js.map

package/lib/services/livesync/android-livesync-tool.js

@@ -159,9 +159,12 @@ class AndroidLivesyncTool {
             error =
                 error ||
                     this.getErrorWithMessage("Socket connection ended before sync operation is complete.");
+            //remove listeners and delete this.socketConnection
             this.cleanState(socketUid);
+            //call end of the connection (close and error callbacks won't be called - listeners removed)
             socket.end();
             socket.destroy();
+            //reject all pending sync requests and clear timeouts
             this.rejectPendingSyncOperations(socketUid, error);
         }
     }
@@ -425,3 +428,4 @@ AndroidLivesyncTool.SOCKET_CONNECTION_TIMED_OUT_ERROR = "Socket connection timed
 AndroidLivesyncTool.NO_SOCKET_CONNECTION_AVAILABLE_ERROR = "No socket connection available.";
 exports.AndroidLivesyncTool = AndroidLivesyncTool;
 yok_1.injector.register("androidLivesyncTool", AndroidLivesyncTool);
+//# sourceMappingURL=android-livesync-tool.js.map

package/lib/services/livesync/device-livesync-service-base.js

@@ -52,6 +52,7 @@ class DeviceLiveSyncServiceBase {
     }
     finalizeSync(liveSyncInfo, projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            //implement in case a sync point for all remove/create operation is needed
             return {
                 didRefresh: true,
                 operationId: "",
@@ -67,3 +68,4 @@ __decorate([
     (0, decorators_2.performanceLog)()
 ], DeviceLiveSyncServiceBase.prototype, "transferFiles", null);
 exports.DeviceLiveSyncServiceBase = DeviceLiveSyncServiceBase;
+//# sourceMappingURL=device-livesync-service-base.js.map

package/lib/services/livesync/ios-device-livesync-service.js

@@ -47,11 +47,13 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
     }
     setupSocketIfNeeded(projectData) {
         return __awaiter(this, void 0, void 0, function* () {
+            // TODO: persist the sockets per app in order to support LiveSync on multiple apps on the same device
             if (this.socket) {
                 return true;
             }
             const appId = projectData.projectIdentifiers.ios;
             try {
+                // TODO: temp workaround till we setup the sockets along with the app start
                 const ensureAppStarted = true;
                 this.socket = yield this.device.getDebugSocket(appId, projectData.projectName, projectData.projectDir, ensureAppStarted);
             }
@@ -143,6 +145,7 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
                 projectDir: projectData.projectDir,
             });
             if (liveSyncInfo.useHotModuleReload) {
+                // enable HOT updates
                 yield this.setupSocketIfNeeded(projectData);
             }
         });
@@ -205,6 +208,9 @@ class IOSDeviceLiveSyncService extends device_livesync_service_base_1.DeviceLive
     destroySocket() {
         return __awaiter(this, void 0, void 0, function* () {
             if (this.socket) {
+                // we do not support LiveSync on multiple apps on the same device
+                // in order to do that, we should cache the socket per app
+                // and destroy just the current app socket when possible
                 yield this.device.destroyAllSockets();
                 this.socket = null;
             }
@@ -216,3 +222,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], IOSDeviceLiveSyncService.prototype, "removeFiles", null);
 exports.IOSDeviceLiveSyncService = IOSDeviceLiveSyncService;
+//# sourceMappingURL=ios-device-livesync-service.js.map

package/lib/services/livesync/ios-livesync-service.js

@@ -73,6 +73,7 @@ class IOSLiveSyncService extends platform_livesync_service_base_1.PlatformLiveSy
     syncAfterInstall(device, liveSyncInfo) {
         return __awaiter(this, void 0, void 0, function* () {
             if (!device.isEmulator) {
+                // In this case we should execute fullsync because iOS Runtime requires the full content of app dir to be extracted in the root of sync dir.
                 yield this.fullSync({
                     projectData: liveSyncInfo.projectData,
                     device,
@@ -93,3 +94,4 @@ __decorate([
 ], IOSLiveSyncService.prototype, "fullSync", null);
 exports.IOSLiveSyncService = IOSLiveSyncService;
 yok_1.injector.register("iOSLiveSyncService", IOSLiveSyncService);
+//# sourceMappingURL=ios-livesync-service.js.map

package/lib/services/livesync/livesync-socket.js

@@ -12,3 +12,4 @@ class LiveSyncSocket extends net.Socket {
 }
 exports.LiveSyncSocket = LiveSyncSocket;
 yok_1.injector.register("LiveSyncSocket", LiveSyncSocket, false);
+//# sourceMappingURL=livesync-socket.js.map

package/lib/services/livesync/platform-livesync-service-base.js

@@ -51,6 +51,7 @@ class PlatformLiveSyncServiceBase {
     }
     syncAfterInstall(device, liveSyncInfo) {
         return __awaiter(this, void 0, void 0, function* () {
+            /* intentionally left blank */
         });
     }
     restartApplication(projectData, liveSyncInfo) {
@@ -104,6 +105,8 @@ class PlatformLiveSyncServiceBase {
             let modifiedLocalToDevicePaths = [];
             if (liveSyncInfo.filesToSync.length) {
                 const filesToSync = liveSyncInfo.filesToSync;
+                // const mappedFiles = _.map(filesToSync, filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData));
+                // Some plugins modify platforms dir on afterPrepare (check nativescript-dev-sass) - we want to sync only existing file.
                 const existingFiles = filesToSync.filter((m) => m && this.$fs.exists(m));
                 this.$logger.trace("Will execute livesync for files: ", existingFiles);
                 const skippedFiles = _.difference(filesToSync, existingFiles);
@@ -122,6 +125,7 @@ class PlatformLiveSyncServiceBase {
                 const filePaths = liveSyncInfo.filesToRemove;
                 const platformData = this.$platformsDataService.getPlatformData(device.deviceInfo.platform, projectData);
                 const mappedFiles = _(filePaths)
+                    // .map(filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData))
                     .filter((filePath) => !!filePath)
                     .value();
                 const projectFilesPath = path.join(platformData.appDestinationDirectoryPath, constants_1.APP_FOLDER_NAME);
@@ -178,3 +182,4 @@ __decorate([
     (0, decorators_1.performanceLog)()
 ], PlatformLiveSyncServiceBase.prototype, "liveSyncWatchAction", null);
 exports.PlatformLiveSyncServiceBase = PlatformLiveSyncServiceBase;
+//# sourceMappingURL=platform-livesync-service-base.js.map

package/lib/services/livesync-process-data-service.js

@@ -41,3 +41,4 @@ class LiveSyncProcessDataService {
 }
 exports.LiveSyncProcessDataService = LiveSyncProcessDataService;
 yok_1.injector.register("liveSyncProcessDataService", LiveSyncProcessDataService);
+//# sourceMappingURL=livesync-process-data-service.js.map

package/lib/services/log-parser-service.js

@@ -50,3 +50,4 @@ __decorate([
 ], LogParserService.prototype, "startParsingLogCore", null);
 exports.LogParserService = LogParserService;
 yok_1.injector.register("logParserService", LogParserService);
+//# sourceMappingURL=log-parser-service.js.map

package/lib/services/log-source-map-service.js

@@ -40,6 +40,7 @@ class LogSourceMapService {
                 if (!this.$fs.getFsStats(filePath).isDirectory()) {
                     const mapFile = filePath + ".map";
                     let sourceMapRaw;
+                    // Skip files bigger than 50MB
                     if (this.$fs.getFileSize(filePath) > 50 * 1000 * 1000) {
                         this.$logger.trace(`Skipping source map for file ${filePath} because it is too big (> 50MB).`);
                         return;
@@ -165,6 +166,8 @@ class LogSourceMapService {
         }
     }
     parseAndroidLog(projectData, rawMessage) {
+        // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap (file:///data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
+        // "System.err: File: "file:///data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         const deviceProjectPath = util.format(constants_1.ANDROID_DEVICE_APP_ROOT_TEMPLATE, projectData.projectIdentifiers.android);
         let separator = ",";
@@ -172,18 +175,25 @@ class LogSourceMapService {
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
+            //"data/data/org.nativescript.sourceMap/files/app/bundle.js, line: 304, column: 8"
             parts = fileSubstring.split(separator);
             if (parts.length >= 3) {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js"
                 parts[0] = parts[0].replace("'", "");
+                // " line: 304"
                 parts[1] = parts[1].replace(" line: ", "");
+                // " column: 8"
                 parts[2] = parts[2].replace(" column: ", "");
             }
             else {
+                // "data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)"
                 separator = ":";
                 parts = fileSubstring.split(separator);
             }
             if (parts.length >= 3) {
+                // "/data/data/org.nativescript.sourceMap/files/app/"
                 const devicePath = `${deviceProjectPath}/${constants_1.APP_FOLDER_NAME}/`;
+                // "bundle.js"
                 filePath = path.relative(devicePath, `${"/"}${parts[0]}`);
                 line = parseInt(parts[1]);
                 column = parseInt(parts[2]);
@@ -191,20 +201,24 @@ class LogSourceMapService {
                 for (let i = 3; i < parts.length; i++) {
                     messageSuffix += `${parts[i]}${i === parts.length - 1 ? "" : separator}`;
                 }
+                // "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap ("
                 messagePrefix = _.trimEnd(messagePrefix, "(");
             }
         }
         return { filePath, line, column, messagePrefix, messageSuffix };
     }
     parseIosLog(rawMessage) {
+        // "CONSOLE INFO file:///app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
         const fileIndex = rawMessage.lastIndexOf(LogSourceMapService.FILE_PREFIX);
         let messageSuffix = "";
         let parts, filePath, line, column, messagePrefix;
         if (fileIndex >= 0) {
+            // "app/vendor.js:131:36: HMR: Hot Module Replacement Enabled. Waiting for signal."
             const fileSubstring = rawMessage.substring(fileIndex + LogSourceMapService.FILE_PREFIX.length);
             parts = fileSubstring.split(":");
             if (parts && parts.length >= 3) {
                 filePath = parts[0];
+                // "app/vendor.js"
                 if (_.startsWith(filePath, constants_1.APP_FOLDER_NAME)) {
                     filePath = path.relative(constants_1.APP_FOLDER_NAME, parts[0]);
                 }
@@ -233,3 +247,4 @@ LogSourceMapService.FILE_PREFIX_REPLACEMENT = "file: ";
 LogSourceMapService.MEMOIZE_FUNCTION_RANDOM_KEY_FOR_JOIN = "__some_random_value__";
 exports.LogSourceMapService = LogSourceMapService;
 yok_1.injector.register("logSourceMapService", LogSourceMapService);
+//# sourceMappingURL=log-source-map-service.js.map

package/lib/services/marking-mode-service.js

@@ -15,7 +15,7 @@ const constants_1 = require("../constants");
 const yok_1 = require("../common/yok");
 const semver = require("semver/preload");
 const MARKING_MODE_PROP = "markingMode";
-const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full"}" is no longer supported.`;
+const MARKING_MODE_FULL_DEPRECATION_MSG = `In the current version of NativeScript "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}" is no longer supported.`;
 class MarkingModeService {
     constructor($logger, $projectConfigService, $projectHelper, $projectDataService) {
         this.$logger = $logger;
@@ -28,11 +28,13 @@ class MarkingModeService {
             const markingModeValue = this.$projectConfigService.getValue("android.markingMode");
             const { skipWarnings, forceSwitch } = options;
             if (forceSwitch) {
-                yield this.setMarkingMode("none");
+                yield this.setMarkingMode("none" /* MarkingMode.None */);
                 return;
             }
-            if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none") {
-                const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android");
+            if (!skipWarnings && (markingModeValue === null || markingModeValue === void 0 ? void 0 : markingModeValue.toLowerCase()) !== "none" /* MarkingMode.None */) {
+                // only warn if runtime is less than 7.0.0-rc.5 - where the default has been changed to None
+                // if version is null - we are about to add the latest runtime, so no need to warn
+                const { version } = this.$projectDataService.getRuntimePackage(this.$projectHelper.projectDir, "android" /* PlatformTypes.android */);
                 const isMarkingModeFullDefault = version && semver.lt(semver.coerce(version), "7.0.0-rc.5");
                 if (isMarkingModeFullDefault) {
                     this.showMarkingModeFullWarning();
@@ -46,7 +48,7 @@ class MarkingModeService {
         });
     }
     showMarkingModeFullWarning() {
-        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full"}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
+        const markingModeFullWarning = `You are using the deprecated "${MARKING_MODE_PROP}:${"full" /* MarkingMode.Full */}".${os_1.EOL}${os_1.EOL}${MARKING_MODE_FULL_DEPRECATION_MSG}${os_1.EOL}${os_1.EOL}You should update your marking mode by executing 'ns update --markingMode'.`;
         this.$logger.warn(markingModeFullWarning, {
             [constants_1.LoggerConfigData.wrapMessageWithBorders]: true,
         });
@@ -54,3 +56,4 @@ class MarkingModeService {
 }
 exports.MarkingModeService = MarkingModeService;
 yok_1.injector.register("markingModeService", MarkingModeService);
+//# sourceMappingURL=marking-mode-service.js.map

package/lib/services/metadata-filtering-service.js

@@ -103,3 +103,4 @@ class MetadataFilteringService {
 }
 exports.MetadataFilteringService = MetadataFilteringService;
 yok_1.injector.register("metadataFilteringService", MetadataFilteringService);
+//# sourceMappingURL=metadata-filtering-service.js.map

package/lib/services/npm-config-service.js

@@ -21,8 +21,11 @@ class NpmConfigService {
     readConfig() {
         try {
             const res = (0, child_process_1.execSync)("npm config list --json --global");
+            // const data: any = npmconfig.read();
             const data = JSON.parse(res.toString());
+            // todo: remove if not needed with npm config list --json?
             Object.entries(data).forEach(([key, value]) => {
+                // replace env ${VARS} in strings with the process.env value
                 this.config[key] =
                     typeof value !== "string"
                         ? value
@@ -37,3 +40,4 @@ __decorate([
 ], NpmConfigService.prototype, "readConfig", null);
 exports.NpmConfigService = NpmConfigService;
 yok_1.injector.register("npmConfigService", NpmConfigService);
+//# sourceMappingURL=npm-config-service.js.map

package/lib/services/pacote-service.js

@@ -33,6 +33,7 @@ class PacoteService {
         this.$proxyService = $proxyService;
     }
     get $packageManager() {
+        // need to be resolved here due to cyclic dependency
         return this.$injector.resolve("packageManager");
     }
     manifest(packageName, options) {
@@ -51,6 +52,8 @@ class PacoteService {
     }
     extractPackage(packageName, destinationDirectory, options) {
         return __awaiter(this, void 0, void 0, function* () {
+            // strip: Remove the specified number of leading path elements. Pathnames with fewer elements will be silently skipped. More info: https://github.com/npm/node-tar/blob/e89c4d37519b1c20133a9f49d5f6b85fa34c203b/README.md
+            // C: Create an archive
             this.$logger.trace(`Calling pacoteService.extractPackage for packageName: '${packageName}', destinationDir: '${destinationDirectory}' and options: ${options}`);
             const extractOptions = { strip: 1, C: destinationDirectory };
             if (options) {
@@ -68,6 +71,7 @@ class PacoteService {
                 });
                 this.$logger.trace(`Creating extract tar stream with options: ${JSON.stringify(extractOptions, null, 2)}`);
                 const destination = tar.x(extractOptions);
+                // Initiate the source
                 const sourceStream = new stream_1.PassThrough();
                 sourceStream.end(source);
                 sourceStream.pipe(destination);
@@ -84,7 +88,9 @@ class PacoteService {
     }
     getPacoteBaseOptions() {
         return __awaiter(this, void 0, void 0, function* () {
+            // In case `tns create myapp --template https://github.com/NativeScript/template-hello-world.git` command is executed, pacote module throws an error if cache option is not provided.
             const cachePath = yield this.$packageManager.getCachePath();
+            // Add NPM Configuration to our Manifest options
             const npmConfig = this.$npmConfigService.getConfig();
             const pacoteOptions = _.extend(npmConfig, { cache: cachePath, Arborist: arborist_1.Arborist });
             const proxySettings = yield this.$proxyService.getCache();
@@ -107,3 +113,4 @@ __decorate([
 ], PacoteService.prototype, "$packageManager", null);
 exports.PacoteService = PacoteService;
 yok_1.injector.register("pacoteService", PacoteService);
+//# sourceMappingURL=pacote-service.js.map

package/lib/services/performance-service.js

@@ -41,7 +41,7 @@ class PerformanceService {
     trackAnalyticsData(methodInfo, executionTime) {
         this.$analyticsService
             .trackEventActionInGoogleAnalytics({
-            action: "Performance",
+            action: "Performance" /* TrackActionNames.Performance */,
             additionalData: methodInfo,
             value: executionTime,
         })
@@ -71,6 +71,7 @@ class PerformanceService {
             this.$logger.info(PerformanceService.LOG_MESSAGE_TEMPLATE, methodInfo, executionTime);
         }
     }
+    //removes any injected members of the arguments and excludes the options object even if it was renamed
     getJsonSanitizer() {
         const seen = new WeakSet();
         seen.add(this.$options);
@@ -90,3 +91,4 @@ PerformanceService.FAIL_LOG_MESSAGE_TEMPLATE = `Failed to log pefromance data in
 PerformanceService.MIN_NODE_PERFORMANCE_MODULE_VERSION = "8.5.0";
 exports.PerformanceService = PerformanceService;
 yok_1.injector.register("performanceService", PerformanceService);
+//# sourceMappingURL=performance-service.js.map

package/lib/services/platform/add-platform-service.js

@@ -21,7 +21,11 @@ const constants_1 = require("../../constants");
 const decorators_1 = require("../../common/decorators");
 const yok_1 = require("../../common/yok");
 class AddPlatformService {
-    constructor($fs, $logger, $packageManager, $terminalSpinnerService, $analyticsService) {
+    constructor($fs, $logger, 
+    // private $pacoteService: IPacoteService,
+    // private $projectDataService: IProjectDataService,
+    $packageManager, $terminalSpinnerService, $analyticsService // private $tempService: ITempService
+    ) {
         this.$fs = $fs;
         this.$logger = $logger;
         this.$packageManager = $packageManager;
@@ -33,9 +37,13 @@ class AddPlatformService {
             const spinner = this.$terminalSpinnerService.createSpinner();
             try {
                 spinner.start();
+                // const frameworkDirPath = addPlatformData.frameworkPath ?
+                // 	await this.extractPackage(packageToInstall)
+                // 	: await this.installPackage(projectData.projectDir, packageToInstall);
                 const frameworkDirPath = yield this.installPackage(projectData.projectDir, packageToInstall);
                 const frameworkPackageJsonContent = this.$fs.readJson(path.join(frameworkDirPath, "..", "package.json"));
                 const frameworkVersion = frameworkPackageJsonContent.version;
+                // await this.setPlatformVersion(platformData, projectData, frameworkVersion);
                 yield this.trackPlatformVersion(frameworkVersion, platformData);
                 if (!addPlatformData.nativePrepare ||
                     !addPlatformData.nativePrepare.skipNativePrepare) {
@@ -58,10 +66,22 @@ class AddPlatformService {
             yield this.installPackage(projectData.projectDir, `${platformData.frameworkPackageName}@${frameworkVersion}`);
         });
     }
+    // private async extractPackage(pkg: string): Promise<string> {
+    // 	const downloadedPackagePath = await this.$tempService.mkdirSync(
+    // 		"runtimeDir"
+    // 	);
+    // 	await this.$pacoteService.extractPackage(pkg, downloadedPackagePath);
+    // 	const frameworkDir = path.join(
+    // 		downloadedPackagePath,
+    // 		PROJECT_FRAMEWORK_FOLDER_NAME
+    // 	);
+    // 	return path.resolve(frameworkDir);
+    // }
     installPackage(projectDir, packageName) {
         return __awaiter(this, void 0, void 0, function* () {
             const frameworkDir = this.resolveFrameworkDir(projectDir, packageName);
             if (frameworkDir && this.$fs.exists(frameworkDir)) {
+                // don't install if it's already installed
                 return frameworkDir;
             }
             const installedPackage = yield this.$packageManager.install(packageName, projectDir, {
@@ -78,6 +98,30 @@ class AddPlatformService {
     }
     resolveFrameworkDir(projectDir, packageName) {
         try {
+            // strip version info if present <package>@1.2.3-rc.0 -> <package>
+            // tested cases:
+            // @nativescript/ios
+            // @nativescript/ios@1
+            // @nativescript/ios@1.2
+            // @nativescript/ios@1.2.3
+            // @nativescript/ios@1.2.3-
+            // @nativescript/ios@1.2.3-rc
+            // @nativescript/ios@1.2.3-rc.
+            // @nativescript/ios@1.2.3-rc.0
+            // @nativescript/ios@rc
+            // @nativescript/ios@^7.0.0
+            // @nativescript/ios@~7.0.0
+            // tns-ios
+            // tns-ios@1
+            // tns-ios@1.2
+            // tns-ios@1.2.3
+            // tns-ios@1.2.3-
+            // tns-ios@1.2.3-rc
+            // tns-ios@1.2.3-rc.
+            // tns-ios@1.2.3-rc.0
+            // tns-ios@rc
+            // tns-ios@^7.0.0
+            // tns-ios@~7.0.0
             packageName = packageName.replace(/(.+)@.+$/g, "$1");
             const frameworkDir = require
                 .resolve(`${packageName}/package.json`, {
@@ -106,7 +150,7 @@ class AddPlatformService {
     trackPlatformVersion(frameworkVersion, platformData) {
         return __awaiter(this, void 0, void 0, function* () {
             yield this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Add Platform",
+                action: "Add Platform" /* TrackActionNames.AddPlatform */,
                 additionalData: `${platformData.platformNameLowerCase}${constants_1.AnalyticsEventLabelDelimiter}${frameworkVersion}`,
             });
         });
@@ -117,3 +161,4 @@ __decorate([
 ], AddPlatformService.prototype, "addNativePlatform", null);
 exports.AddPlatformService = AddPlatformService;
 yok_1.injector.register("addPlatformService", AddPlatformService);
+//# sourceMappingURL=add-platform-service.js.map

package/lib/services/platform/platform-validation-service.js

@@ -83,3 +83,4 @@ class PlatformValidationService {
 }
 exports.PlatformValidationService = PlatformValidationService;
 yok_1.injector.register("platformValidationService", PlatformValidationService);
+//# sourceMappingURL=platform-validation-service.js.map

package/lib/services/platform/prepare-native-platform-service.js

@@ -56,19 +56,21 @@ class PrepareNativePlatformService {
                 this.$metadataFilteringService.generateMetadataFilters(projectData, platformData.platformNameLowerCase);
             }
             platformData.platformProjectService.interpolateConfigurationFile(projectData);
-            yield this.$projectChangesService.setNativePlatformStatus(platformData, projectData, { nativePlatformStatus: "3" });
+            yield this.$projectChangesService.setNativePlatformStatus(platformData, projectData, { nativePlatformStatus: "3" /* NativePlatformStatus.alreadyPrepared */ });
             return hasChanges;
         });
     }
     cleanProject(platformData, options) {
         return __awaiter(this, void 0, void 0, function* () {
+            // android build artifacts need to be cleaned up
+            // when switching between debug, release and webpack builds
             if (platformData.platformNameLowerCase !== "android") {
                 return;
             }
             const previousPrepareInfo = this.$projectChangesService.getPrepareInfo(platformData);
             if (!previousPrepareInfo ||
                 previousPrepareInfo.nativePlatformStatus !==
-                    "3") {
+                    "3" /* NativePlatformStatus.alreadyPrepared */) {
                 return;
             }
             const { release: previousWasRelease } = previousPrepareInfo;
@@ -85,3 +87,4 @@ __decorate([
 ], PrepareNativePlatformService.prototype, "prepareNativePlatform", null);
 exports.PrepareNativePlatformService = PrepareNativePlatformService;
 yok_1.injector.register("prepareNativePlatformService", PrepareNativePlatformService);
+//# sourceMappingURL=prepare-native-platform-service.js.map

package/lib/services/platform-environment-requirements.js

@@ -20,7 +20,9 @@ const helpers_1 = require("../common/helpers");
 const os_1 = require("os");
 const yok_1 = require("../common/yok");
 class PlatformEnvironmentRequirements {
-    constructor($doctorService, $errors, $analyticsService, $injector) {
+    constructor($doctorService, $errors, $analyticsService, 
+    // @ts-ignore - required by the hook helper!
+    $injector) {
         this.$doctorService = $doctorService;
         this.$errors = $errors;
         this.$analyticsService = $analyticsService;
@@ -32,7 +34,7 @@ class PlatformEnvironmentRequirements {
             const selectedOption = null;
             if (process.env.NS_SKIP_ENV_CHECK) {
                 yield this.$analyticsService.trackEventActionInGoogleAnalytics({
-                    action: "Check Environment Requirements",
+                    action: "Check Environment Requirements" /* TrackActionNames.CheckEnvironmentRequirements */,
                     additionalData: "Skipped: NS_SKIP_ENV_CHECK is set",
                 });
                 return {
@@ -47,8 +49,9 @@ class PlatformEnvironmentRequirements {
                 forceCheck: input.forceCheck,
             });
             if (!canExecute) {
+                // if (!isInteractive()) {
                 yield this.$analyticsService.trackEventActionInGoogleAnalytics({
-                    action: "Check Environment Requirements",
+                    action: "Check Environment Requirements" /* TrackActionNames.CheckEnvironmentRequirements */,
                     additionalData: "Non-interactive terminal, unable to execute local builds.",
                 });
                 this.fail(this.getNonInteractiveConsoleMessage(platform));
@@ -69,6 +72,7 @@ class PlatformEnvironmentRequirements {
         ].join(os_1.EOL);
     }
     getEnvVerificationMessage(platform) {
+        // map process.platform to OS name used in docs
         const os = {
             linux: "linux",
             win32: "windows",
@@ -85,3 +89,4 @@ __decorate([
 ], PlatformEnvironmentRequirements.prototype, "checkEnvironmentRequirements", null);
 exports.PlatformEnvironmentRequirements = PlatformEnvironmentRequirements;
 yok_1.injector.register("platformEnvironmentRequirements", PlatformEnvironmentRequirements);
+//# sourceMappingURL=platform-environment-requirements.js.map

package/lib/services/platform-project-service-base.js

@@ -30,3 +30,4 @@ class PlatformProjectServiceBase extends events_1.EventEmitter {
     }
 }
 exports.PlatformProjectServiceBase = PlatformProjectServiceBase;
+//# sourceMappingURL=platform-project-service-base.js.map

package/lib/services/platforms-data-service.js

@@ -29,3 +29,4 @@ class PlatformsDataService {
 }
 exports.PlatformsDataService = PlatformsDataService;
 yok_1.injector.register("platformsDataService", PlatformsDataService);
+//# sourceMappingURL=platforms-data-service.js.map