muonroi-cli 1.4.0 → 1.4.1

package/src/ops/doctor.test.ts

@@ -1,108 +0,0 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-
-// RED phase: import module under test (will fail until doctor.ts is created)
-import { type CheckResult, formatDoctorReport, runDoctor } from "./doctor.js";
-
-describe("doctor — runDoctor returns 9 checks", () => {
-  beforeEach(() => {
-    // Mock fetch to avoid real network calls in tests
-    vi.stubGlobal("fetch", vi.fn().mockResolvedValue({ ok: false, status: 503 }));
-  });
-
-  afterEach(() => {
-    vi.unstubAllGlobals();
-    vi.restoreAllMocks();
-  });
-
-  it("returns exactly 9 CheckResult entries (council_mcp_nudge added in CQ-23)", async () => {
-    const results = await runDoctor();
-    expect(results).toHaveLength(9);
-  });
-
-  it("each CheckResult has valid name, status, and detail fields", async () => {
-    const results = await runDoctor();
-    const validStatuses = ["pass", "warn", "fail"];
-    for (const r of results) {
-      expect(typeof r.name).toBe("string");
-      expect(r.name.length).toBeGreaterThan(0);
-      expect(validStatuses).toContain(r.status);
-      expect(typeof r.detail).toBe("string");
-      expect(r.detail.length).toBeGreaterThan(0);
-    }
-  });
-
-  it("includes expected check names", async () => {
-    const results = await runDoctor();
-    const names = results.map((r) => r.name);
-    expect(names).toContain("bun_version");
-    expect(names).toContain("os");
-    expect(names).toContain("key_presence");
-    expect(names).toContain("ollama");
-    expect(names).toContain("ee.health");
-    expect(names).toContain("ee.brain");
-    expect(names).toContain("qdrant");
-    expect(names).toContain("error_rate");
-  });
-
-  it("unreachable services return warn (not fail or throw)", async () => {
-    vi.stubGlobal("fetch", vi.fn().mockRejectedValue(new Error("Network unreachable")));
-    const results = await runDoctor();
-    const ollamaCheck = results.find((r) => r.name === "ollama")!;
-    const eeCheck = results.find((r) => r.name === "ee.health")!;
-    const qdrantCheck = results.find((r) => r.name === "qdrant")!;
-    expect(ollamaCheck.status).toBe("warn");
-    expect(eeCheck.status).toBe("warn");
-    expect(qdrantCheck.status).toBe("warn");
-  });
-});
-
-describe("doctor — bun_version check", () => {
-  afterEach(() => {
-    vi.unstubAllGlobals();
-    vi.restoreAllMocks();
-  });
-
-  it("returns pass when bun version >= 1.3.13", async () => {
-    vi.stubGlobal("fetch", vi.fn().mockResolvedValue({ ok: false, status: 503 }));
-    // In test environment: process.versions.bun may or may not be set
-    // We just verify bun_version is one of the valid statuses
-    const results = await runDoctor();
-    const bunCheck = results.find((r) => r.name === "bun_version")!;
-    expect(["pass", "fail", "warn"]).toContain(bunCheck.status);
-    expect(bunCheck.detail).toMatch(/Bun|Not running/);
-  });
-});
-
-describe("doctor — formatDoctorReport", () => {
-  it("contains [PASS] icon for passing check", () => {
-    const results: CheckResult[] = [{ name: "os", status: "pass", detail: "linux 5.15" }];
-    const report = formatDoctorReport(results);
-    expect(report).toContain("[PASS]");
-    expect(report).toContain("os");
-  });
-
-  it("contains [WARN] icon for warn check", () => {
-    const results: CheckResult[] = [{ name: "ollama", status: "warn", detail: "Ollama VPS unreachable" }];
-    const report = formatDoctorReport(results);
-    expect(report).toContain("[WARN]");
-  });
-
-  it("contains [FAIL] icon for fail check", () => {
-    const results: CheckResult[] = [{ name: "bun_version", status: "fail", detail: "Not running under Bun" }];
-    const report = formatDoctorReport(results);
-    expect(report).toContain("[FAIL]");
-  });
-
-  it("includes summary line with counts", () => {
-    const results: CheckResult[] = [
-      { name: "os", status: "pass", detail: "linux" },
-      { name: "ollama", status: "warn", detail: "unreachable" },
-      { name: "bun_version", status: "fail", detail: "missing" },
-    ];
-    const report = formatDoctorReport(results);
-    expect(report).toContain("Summary:");
-    expect(report).toContain("1 pass");
-    expect(report).toContain("1 warn");
-    expect(report).toContain("1 fail");
-  });
-});

package/src/ops/doctor.ts

@@ -1,366 +0,0 @@
-/**
- * src/ops/doctor.ts
- *
- * Health check runner for muonroi-cli doctor command.
- * Runs 7 named checks and returns pass/warn/fail results.
- *
- * Checks: bun_version, os, key_presence, ollama, ee, qdrant, error_rate
- * Never throws — all checks handle errors gracefully (warn, not crash).
- */
-
-import { readFile } from "fs/promises";
-import os from "os";
-import path from "path";
-import type { EEHealthResult } from "../ee/health.js";
-import { healthDetailed } from "../ee/health.js";
-import { listStoredProviders } from "../providers/keychain.js";
-import { getDatabase } from "../storage/db.js";
-import { loadMcpServers, loadUserSettings } from "../utils/settings.js";
-
-export interface CheckResult {
-  name: string;
-  status: "pass" | "warn" | "fail";
-  detail: string;
-}
-
-function icon(status: "pass" | "warn" | "fail"): string {
-  return status === "pass" ? "[PASS]" : status === "warn" ? "[WARN]" : "[FAIL]";
-}
-
-export function formatDoctorReport(results: CheckResult[], version?: string): string {
-  const lines: string[] = [];
-  lines.push(`  muonroi-cli v${version || "unknown"}`);
-  lines.push("");
-  for (const r of results) {
-    lines.push(`  ${icon(r.status)} ${r.name}: ${r.detail}`);
-  }
-  const passCount = results.filter((r) => r.status === "pass").length;
-  const warnCount = results.filter((r) => r.status === "warn").length;
-  const failCount = results.filter((r) => r.status === "fail").length;
-  lines.push("");
-  lines.push(`  Summary: ${passCount} pass, ${warnCount} warn, ${failCount} fail`);
-  lines.push("");
-  lines.push("  For managed Experience Engine: https://muonroi.com/cloud");
-  return lines.join("\n");
-}
-
-async function checkBunVersion(): Promise<CheckResult> {
-  const bunVersion = process.versions.bun;
-  if (!bunVersion) {
-    return { name: "bun_version", status: "fail", detail: "Not running under Bun" };
-  }
-  // Compare semver: need >= 1.3.13
-  const [major, minor, patch] = bunVersion.split(".").map(Number);
-  const ok = major > 1 || (major === 1 && (minor > 3 || (minor === 3 && patch >= 13)));
-  return {
-    name: "bun_version",
-    status: ok ? "pass" : "fail",
-    detail: `Bun ${bunVersion}${ok ? "" : " (need >= 1.3.13)"}`,
-  };
-}
-
-async function checkOS(): Promise<CheckResult> {
-  return {
-    name: "os",
-    status: "pass",
-    detail: `${os.platform()} ${os.release()} ${os.arch()}`,
-  };
-}
-
-async function checkKeyPresence(): Promise<CheckResult> {
-  const envKey = process.env.MUONROI_API_KEY;
-  if (envKey && envKey.length > 0) {
-    return {
-      name: "key_presence",
-      status: "pass",
-      detail: "MUONROI_API_KEY set via env var",
-    };
-  }
-  try {
-    const stored = await listStoredProviders();
-    if (stored.length > 0) {
-      return {
-        name: "key_presence",
-        status: "pass",
-        detail: `API key(s) in OS keychain: ${stored.join(", ")}`,
-      };
-    }
-  } catch {
-    /* keytar unavailable — fall through */
-  }
-  try {
-    const settings = loadUserSettings();
-    if (settings.apiKey && settings.apiKey.length > 0) {
-      return {
-        name: "key_presence",
-        status: "warn",
-        detail:
-          "API key in plaintext user-settings.json — run 'muonroi-cli keys cleanup-settings' to migrate to OS keychain",
-      };
-    }
-  } catch {
-    /* settings file unreadable — fall through */
-  }
-  return {
-    name: "key_presence",
-    status: "fail",
-    detail: "No API key found (run 'muonroi-cli keys set <provider>' or set MUONROI_API_KEY)",
-  };
-}
-
-async function checkOllamaHealth(): Promise<CheckResult> {
-  try {
-    const ollamaUrl = process.env.OLLAMA_URL ?? "http://localhost:11434";
-    const resp = await fetch(`${ollamaUrl.replace(/\/+$/, "")}/api/tags`, {
-      signal: AbortSignal.timeout(2000),
-    });
-    return {
-      name: "ollama",
-      status: resp.ok ? "pass" : "warn",
-      detail: resp.ok ? `Ollama reachable (${ollamaUrl})` : `Ollama responded ${resp.status}`,
-    };
-  } catch {
-    return { name: "ollama", status: "warn", detail: "Ollama not running (optional — needed for warm-path routing)" };
-  }
-}
-
-async function checkEEDetailed(): Promise<CheckResult> {
-  try {
-    const result: EEHealthResult = await healthDetailed();
-
-    const serverOk = result.components.server.ok;
-    const gatesOk = result.components.gates?.ok ?? true; // null if local mode
-    const isHealthy = result.ok;
-
-    const parts = [
-      `mode=${result.mode}`,
-      `circuit=${result.circuit}`,
-      `server=${serverOk ? "ok" : `fail(${result.components.server.status})`}`,
-    ];
-    if (result.components.gates !== null) {
-      parts.push(`gates=${gatesOk ? "ok" : `fail(${result.components.gates.status})`}`);
-    }
-
-    if (!isHealthy) {
-      const hint =
-        result.mode === "thin-client"
-          ? "Hint: check VPS 72.61.127.154:8082 is reachable; verify ~/.experience/config.json serverBaseUrl + serverReadAuthToken"
-          : "Hint: start EE locally or configure thin-client in ~/.experience/config.json";
-      return {
-        name: "ee.health",
-        status: "warn",
-        detail: `EE unreachable — ${parts.join(", ")}. ${hint}`,
-      };
-    }
-
-    return {
-      name: "ee.health",
-      status: "pass",
-      detail: parts.join(", "),
-    };
-  } catch (err) {
-    return {
-      name: "ee.health",
-      status: "warn",
-      detail: `EE health probe failed: ${(err as Error).message} — optional, CLI works without EE`,
-    };
-  }
-}
-
-// Threshold: >= 50 consecutive no_match events → brain likely needs bootstrapping
-const BRAIN_EMPTY_THRESHOLD = 50;
-
-async function checkBrainEmptiness(): Promise<CheckResult> {
-  try {
-    const db = getDatabase();
-
-    // Count ee_injection events with event_subtype='no_match' in last 30 days
-    const cutoff = new Date(Date.now() - 30 * 86_400_000).toISOString();
-    const row = db
-      .prepare(
-        `SELECT COUNT(*) as cnt FROM interaction_logs
-         WHERE event_type = 'ee_injection'
-           AND event_subtype = 'no_match'
-           AND created_at >= ?`,
-      )
-      .get(cutoff) as { cnt: number } | undefined;
-
-    const noMatchCount = row?.cnt ?? 0;
-
-    if (noMatchCount >= BRAIN_EMPTY_THRESHOLD) {
-      return {
-        name: "ee.brain",
-        status: "warn",
-        detail: [
-          `${noMatchCount} no_match injection events in 30d — brain may need bootstrapping.`,
-          `Run 'experience extract' over recent sessions to seed the brain,`,
-          `then 'experience evolve' to abstract principles.`,
-          `Or lower MUONROI_PIL_SCORE_FLOOR below 0.55 if matches exist but are filtered as noise.`,
-        ].join(" "),
-      };
-    }
-
-    if (noMatchCount > 0) {
-      return {
-        name: "ee.brain",
-        status: "pass",
-        detail: `${noMatchCount} no_match events in 30d (within normal range)`,
-      };
-    }
-
-    return {
-      name: "ee.brain",
-      status: "pass",
-      detail: "No no_match injection events in 30d",
-    };
-  } catch {
-    // fail-open: DB may not be initialized yet
-    return { name: "ee.brain", status: "pass", detail: "brain check skipped (DB unavailable)" };
-  }
-}
-
-async function checkQdrant(): Promise<CheckResult> {
-  try {
-    const qdrantUrl = process.env.QDRANT_URL ?? "http://localhost:6333";
-    const resp = await fetch(`${qdrantUrl.replace(/\/+$/, "")}/healthz`, {
-      signal: AbortSignal.timeout(1000),
-    });
-    return {
-      name: "qdrant",
-      status: resp.ok ? "pass" : "warn",
-      detail: resp.ok ? `Qdrant healthy (${qdrantUrl})` : `Qdrant responded ${resp.status}`,
-    };
-  } catch {
-    return { name: "qdrant", status: "warn", detail: "Qdrant not running locally (OK if EE is remote)" };
-  }
-}
-
-async function checkRecentErrorRate(): Promise<CheckResult> {
-  const errorLogPath = path.join(os.homedir(), ".muonroi-cli", "errors.log");
-  try {
-    const content = await readFile(errorLogPath, "utf-8");
-    const lines = content.split("\n").filter(Boolean);
-    const oneDayAgo = Date.now() - 86400000;
-    // Count lines with ISO timestamps in last 24h (best-effort)
-    const recentCount = lines.filter((l) => {
-      const match = l.match(/^(\d{4}-\d{2}-\d{2}T[\d:.]+Z?)/);
-      return match && new Date(match[1]).getTime() > oneDayAgo;
-    }).length;
-    if (recentCount > 50) {
-      return { name: "error_rate", status: "fail", detail: `${recentCount} errors in last 24h` };
-    }
-    if (recentCount > 10) {
-      return { name: "error_rate", status: "warn", detail: `${recentCount} errors in last 24h` };
-    }
-    return { name: "error_rate", status: "pass", detail: `${recentCount} errors in last 24h` };
-  } catch {
-    return { name: "error_rate", status: "pass", detail: "No error log found (clean)" };
-  }
-}
-
-// CQ-23: threshold for qualifying council sessions to trigger MCP nudge
-const COUNCIL_MCP_NUDGE_THRESHOLD = 3;
-const RESEARCH_KEYWORDS =
-  /research|find\s|look\s*up|search\s|investigate|what\s+is\s|latest|current\s+version|news\s|documentation|compare\s/i;
-
-async function checkCouncilMcpNudge(): Promise<CheckResult> {
-  try {
-    // 1. Check if tavily or playwright is enabled in MCP config
-    const mcpServers = loadMcpServers();
-    // McpServerConfig has: id, label, enabled, transport, command?, ...
-    // Match tavily/playwright by id or label (case-insensitive)
-    const serverNames = mcpServers.map((s) => `${s.id ?? ""} ${s.label ?? ""} ${s.command ?? ""}`.toLowerCase());
-    const tavilyEnabled = serverNames.some((n) => n.includes("tavily"));
-    const playwrightEnabled = serverNames.some((n) => n.includes("playwright") || n.includes("chrome"));
-
-    if (tavilyEnabled && playwrightEnabled) {
-      return { name: "council.mcp", status: "pass", detail: "tavily + playwright enabled" };
-    }
-    if (tavilyEnabled || playwrightEnabled) {
-      const enabled = tavilyEnabled ? "tavily" : "playwright";
-      return {
-        name: "council.mcp",
-        status: "pass",
-        detail: `${enabled} enabled (partial MCP coverage)`,
-      };
-    }
-
-    // 2. Query DB for [Council Memory] records with URL or research topics
-    const db = getDatabase();
-    const rows = db
-      .prepare(
-        `SELECT message_json FROM messages
-         WHERE role = 'system'
-           AND message_json LIKE '%[Council Memory]%'
-         ORDER BY created_at DESC
-         LIMIT 50`,
-      )
-      .all() as Array<{ message_json: string }>;
-
-    let qualifyingCount = 0;
-    for (const row of rows) {
-      try {
-        const content = (() => {
-          try {
-            const parsed = JSON.parse(row.message_json) as { content?: string };
-            return typeof parsed.content === "string" ? parsed.content : row.message_json;
-          } catch {
-            return row.message_json;
-          }
-        })();
-
-        if (!content.startsWith("[Council Memory] ")) continue;
-        const record = JSON.parse(content.slice("[Council Memory] ".length)) as { topic?: string };
-        const topic = record.topic ?? "";
-        if (/https?:\/\//.test(topic) || RESEARCH_KEYWORDS.test(topic)) {
-          qualifyingCount++;
-        }
-      } catch {
-        /* skip malformed rows */
-      }
-    }
-
-    if (qualifyingCount >= COUNCIL_MCP_NUDGE_THRESHOLD) {
-      const missing = [!tavilyEnabled && "tavily", !playwrightEnabled && "playwright"].filter(Boolean).join(", ");
-      return {
-        name: "council.mcp",
-        status: "warn",
-        detail: [
-          `${qualifyingCount} council session(s) ran URL/research topics without MCP enabled.`,
-          `Missing: ${missing}.`,
-          `Enable these in ~/.muonroi-cli/user-settings.json under "mcpServers"`,
-          `to allow tavily internet search and playwright browser access during debates.`,
-        ].join(" "),
-      };
-    }
-
-    return {
-      name: "council.mcp",
-      status: "pass",
-      detail:
-        qualifyingCount === 0
-          ? "No URL/research council sessions detected"
-          : `${qualifyingCount} URL/research session(s) (threshold ${COUNCIL_MCP_NUDGE_THRESHOLD} not reached)`,
-    };
-  } catch {
-    return {
-      name: "council.mcp",
-      status: "pass",
-      detail: "council mcp check skipped (DB unavailable)",
-    };
-  }
-}
-
-export async function runDoctor(): Promise<CheckResult[]> {
-  return Promise.all([
-    checkBunVersion(),
-    checkOS(),
-    checkKeyPresence(),
-    checkOllamaHealth(),
-    checkEEDetailed(), // replaces checkEE() — CQ-16c
-    checkBrainEmptiness(), // NEW — CQ-16d
-    checkQdrant(),
-    checkRecentErrorRate(),
-    checkCouncilMcpNudge(), // NEW — CQ-23
-  ]);
-}

package/src/orchestrator/__tests__/agent-base-url-switch.test.ts

@@ -1,87 +0,0 @@
-/**
- * Regression: Agent.setModel / Agent.setApiKey must NOT carry a previous
- * provider's default baseURL into the new provider's factory.
- *
- * Evidence (session 2492d6579b1d, see DB `interaction_logs.error api` row
- * with metadata 'The supported API model names are deepseek-v4-pro or
- * deepseek-v4-flash, but you passed deepseek-ai/DeepSeek-V4-Flash.'):
- *
- * Before the fix, switching defaultProvider from deepseek → siliconflow via
- * the UI left this.baseURL = "https://api.deepseek.com" from startup. The
- * setModel rebuild path constructed a SiliconflowStrategy factory but bound
- * it to the DeepSeek apiBase, so requests landed at api.deepseek.com with a
- * SiliconFlow-prefixed model id, which DeepSeek rejected with the literal
- * error string above.
- *
- * This test exercises the public Agent surface to confirm the fix detects a
- * stale "this is another provider's default apiBase" baseURL and drops it.
- */
-import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
-import { loadCatalog } from "../../models/registry.js";
-import { apiBaseFor } from "../../providers/endpoints.js";
-import { Agent } from "../orchestrator.js";
-
-describe("Agent provider switch — baseURL hygiene", () => {
-  beforeAll(async () => {
-    await loadCatalog();
-  });
-
-  beforeEach(() => {
-    // Tests run in-process with no real key persistence; skip session DB to
-    // keep the assertions on pure provider/URL state.
-    process.env.MUONROI_TEST_NO_PERSIST = "1";
-    process.env.MUONROI_TEST_NO_KEYCHAIN = "1";
-  });
-
-  afterEach(() => {
-    delete process.env.MUONROI_TEST_NO_PERSIST;
-    delete process.env.MUONROI_TEST_NO_KEYCHAIN;
-  });
-
-  it("setModel drops stale baseURL when switching to a different provider", () => {
-    const agent = new Agent("sk-test-deepseek", apiBaseFor("deepseek"), "deepseek-v4-flash", undefined, {
-      persistSession: false,
-    });
-    expect(agent.getProviderId()).toBe("deepseek");
-    expect((agent as unknown as { baseURL: string | null }).baseURL).toBe(apiBaseFor("deepseek"));
-
-    agent.setModel("deepseek-ai/DeepSeek-V4-Flash");
-    expect(agent.getProviderId()).toBe("siliconflow");
-    // Stale DS apiBase must be dropped so the SF factory binds to SF's URL.
-    expect((agent as unknown as { baseURL: string | null }).baseURL).toBeNull();
-  });
-
-  it("setModel preserves a genuine custom baseURL (not a known provider apiBase)", () => {
-    const customURL = "https://proxy.internal.example.com/v1";
-    const agent = new Agent("sk-test", customURL, "deepseek-v4-flash", undefined, {
-      persistSession: false,
-    });
-    expect((agent as unknown as { baseURL: string | null }).baseURL).toBe(customURL);
-
-    agent.setModel("deepseek-ai/DeepSeek-V4-Flash");
-    // Custom URL doesn't match any known provider apiBase → kept as override.
-    expect((agent as unknown as { baseURL: string | null }).baseURL).toBe(customURL);
-  });
-
-  it("setModel does NOT drop baseURL when staying on the same provider", () => {
-    const agent = new Agent("sk-test", apiBaseFor("siliconflow"), "alibaba/Qwen3-30B-A3B-Instruct-2507", undefined, {
-      persistSession: false,
-    });
-    expect(agent.getProviderId()).toBe("siliconflow");
-
-    agent.setModel("deepseek-ai/DeepSeek-V4-Flash");
-    expect(agent.getProviderId()).toBe("siliconflow");
-    expect((agent as unknown as { baseURL: string | null }).baseURL).toBe(apiBaseFor("siliconflow"));
-  });
-
-  it("setApiKey drops a stale apiBase that targets a different provider", () => {
-    const agent = new Agent(undefined, undefined, "deepseek-ai/DeepSeek-V4-Flash", undefined, {
-      persistSession: false,
-    });
-    expect(agent.getProviderId()).toBe("siliconflow");
-
-    // Caller hands setApiKey a stale DeepSeek apiBase — must be dropped.
-    agent.setApiKey("sk-test", apiBaseFor("deepseek"));
-    expect((agent as unknown as { baseURL: string | null }).baseURL).toBeNull();
-  });
-});