muonroi-cli 1.4.0 → 1.4.1

package/src/scaffold/bb-quality-gate.ts

@@ -1,287 +0,0 @@
-/**
- * bb-quality-gate.ts — Quality gate runner for BB-aware scaffold output.
- *
- * Tasks implemented:
- *   6.13 — Gate runner: dotnet restore + build + boundary script + sentinel grep
- *   6.14 — Retry-once via council on gate failure
- *   6.15 — Soft fallback: emit EE-GATE-FAILURES.md when retry still fails
- */
-
-import { spawnSync } from "node:child_process";
-import { existsSync, writeFileSync } from "node:fs";
-import * as path from "node:path";
-import type { ContinueAsCouncilOptions } from "./continue-as-council.js";
-import { continueAsCouncil } from "./continue-as-council.js";
-
-// ---------------------------------------------------------------------------
-// Public types
-// ---------------------------------------------------------------------------
-
-export interface GateStepFailure {
-  step: string;
-  output: string;
-}
-
-export interface GateResult {
-  passed: boolean;
-  failures: GateStepFailure[];
-}
-
-export interface BBQualityGateOptions {
-  /** Root of the scaffolded server directory. */
-  serverDir: string;
-  /** Original user intent prompt (used in retry council call). */
-  intentPrompt: string;
-  /**
-   * Inject exec for testability. Defaults to real spawnSync.
-   * Receives (cmd, args, cwd) and returns { stdout, stderr, status }.
-   */
-  exec?: (
-    cmd: string,
-    args: string[],
-    cwd: string,
-    timeoutMs: number,
-  ) => { stdout: string; stderr: string; status: number | null };
-  /**
-   * Inject council runner for retry-once (task 6.14).
-   * Defaults to continueAsCouncil with the failure appended.
-   */
-  runCouncil?: ContinueAsCouncilOptions["runCouncil"];
-  /**
-   * Inject writeFile for testability (task 6.15 fallback file).
-   */
-  writeFile?: (p: string, content: string) => void;
-  /**
-   * Inject fetchBBContext for remediation hints in EE-GATE-FAILURES.md.
-   * When absent, fallback file is emitted without EE hints.
-   */
-  fetchBBContext?: (query: string) => Promise<{ behavioralRules: Array<{ text: string }> }>;
-}
-
-// ---------------------------------------------------------------------------
-// Task 6.13 — Gate runner
-// ---------------------------------------------------------------------------
-
-const SENTINEL_OPEN = "// >>> muonroi-cli:injected:bb-ecosystem";
-
-function defaultExec(
-  cmd: string,
-  args: string[],
-  cwd: string,
-  timeoutMs: number,
-): { stdout: string; stderr: string; status: number | null } {
-  const result = spawnSync(cmd, args, { cwd, encoding: "utf8", timeout: timeoutMs });
-  return {
-    stdout: result.stdout ?? "",
-    stderr: result.stderr ?? "",
-    status: result.status ?? (result.error ? 1 : 0),
-  };
-}
-
-export async function runQualityGate(opts: BBQualityGateOptions): Promise<GateResult> {
-  const { serverDir } = opts;
-  const exec = opts.exec ?? defaultExec;
-  const failures: GateStepFailure[] = [];
-
-  // Step 1: dotnet restore (timeout 120s)
-  const restore = exec("dotnet", ["restore", "--nologo"], serverDir, 120_000);
-  if (restore.status !== 0) {
-    failures.push({ step: "dotnet restore", output: `${restore.stdout}\n${restore.stderr}`.trim() });
-  }
-
-  // Step 2: dotnet build -c Debug --nologo (timeout 180s)
-  const build = exec("dotnet", ["build", "-c", "Debug", "--nologo"], serverDir, 180_000);
-  if (build.status !== 0) {
-    failures.push({ step: "dotnet build", output: `${build.stdout}\n${build.stderr}`.trim() });
-  }
-
-  // Step 3: pwsh check-modular-boundaries.ps1 (timeout 30s)
-  const scriptPath = path.join(serverDir, "scripts", "check-modular-boundaries.ps1");
-  if (opts.exec ? true : existsSync(scriptPath)) {
-    const boundary = exec("pwsh", [scriptPath, "-RepoRoot", "."], serverDir, 30_000);
-    if (boundary.status !== 0) {
-      failures.push({ step: "check-modular-boundaries", output: `${boundary.stdout}\n${boundary.stderr}`.trim() });
-    }
-  }
-
-  // Step 4: Sentinel grep — verify injected block present
-  const programCs = path.join(serverDir, "Program.cs");
-  if (opts.exec ? true : existsSync(programCs)) {
-    const grep = exec(
-      "pwsh",
-      ["-Command", `Select-String -Path '${programCs}' -Pattern '${SENTINEL_OPEN}' -Quiet`],
-      serverDir,
-      5_000,
-    );
-    if (grep.status !== 0) {
-      failures.push({
-        step: "sentinel-check",
-        output: `BB ecosystem sentinel block not found in Program.cs. Expected: ${SENTINEL_OPEN}`,
-      });
-    }
-  }
-
-  // Step 5: Leftover template sentinel — fail when sample-only names linger.
-  // BB template ships `BaseTemplate`, `DocTemplate`, `TemplateSample` strings
-  // as placeholder identifiers. Agent is expected to rename/delete these
-  // during scaffold; if any survive, treat it as a gate failure and let the
-  // retry-via-council path feed the list back to the LLM.
-  const templateSentinels = ["BaseTemplate", "DocTemplate", "TemplateSample"];
-  if (opts.exec ? true : existsSync(serverDir)) {
-    const pattern = templateSentinels.join("|");
-    const grep = exec(
-      "pwsh",
-      [
-        "-Command",
-        `Get-ChildItem -Path '${serverDir}' -Recurse -Include *.cs,*.csproj | Select-String -Pattern '${pattern}' -List | ForEach-Object { $_.Path }`,
-      ],
-      serverDir,
-      15_000,
-    );
-    const hits = grep.stdout
-      .split(/\r?\n/)
-      .map((s) => s.trim())
-      .filter((s) => s.length > 0);
-    if (hits.length > 0) {
-      failures.push({
-        step: "template-leftover",
-        output:
-          `Template sample identifiers still present in ${hits.length} file(s) — rename or delete before shipping.\n` +
-          `Tokens: ${templateSentinels.join(", ")}\n` +
-          `Files:\n${hits.slice(0, 20).join("\n")}`,
-      });
-    }
-  }
-
-  return { passed: failures.length === 0, failures };
-}
-
-// ---------------------------------------------------------------------------
-// Task 6.14 — Retry-once on failure
-// ---------------------------------------------------------------------------
-
-export async function runQualityGateWithRetry(
-  opts: BBQualityGateOptions,
-  onRetryCodeGen?: () => Promise<void>,
-): Promise<GateResult> {
-  const firstResult = await runQualityGate(opts);
-  if (firstResult.passed) return firstResult;
-
-  // Build failure summary for council
-  const failureSummary = firstResult.failures
-    .map((f) => `### ${f.step}\n\`\`\`\n${f.output.slice(0, 500)}\n\`\`\``)
-    .join("\n\n");
-
-  const councilPrompt = `${opts.intentPrompt}
-
-## Gate failures (please fix in next iteration)
-${failureSummary}
-
-Please revise the BB ecosystem wiring to fix these compilation/boundary errors.`;
-
-  // Call council once with failures appended
-  await continueAsCouncil({
-    prompt: councilPrompt,
-    outputDir: opts.serverDir,
-    runCouncil: opts.runCouncil,
-  });
-
-  // Re-run code-gen if callback provided
-  if (onRetryCodeGen) {
-    await onRetryCodeGen();
-  }
-
-  // Run gate again
-  return runQualityGate(opts);
-}
-
-// ---------------------------------------------------------------------------
-// Task 6.15 — Soft fallback: emit EE-GATE-FAILURES.md
-// ---------------------------------------------------------------------------
-
-export async function emitGateFailuresFallback(opts: {
-  serverDir: string;
-  failures: GateStepFailure[];
-  fetchBBContext?: BBQualityGateOptions["fetchBBContext"];
-  writeFile?: (p: string, content: string) => void;
-}): Promise<void> {
-  const { serverDir, failures } = opts;
-  const writeFileFn = opts.writeFile ?? ((p: string, c: string) => writeFileSync(p, c, "utf-8"));
-
-  const lines: string[] = [
-    "# EE-GATE-FAILURES.md",
-    "",
-    `Generated by muonroi-cli on ${new Date().toISOString().slice(0, 10)}.`,
-    "",
-    "## Gate Failures",
-    "",
-  ];
-
-  for (const f of failures) {
-    lines.push(`### ${f.step}`);
-    lines.push("```");
-    lines.push(f.output.slice(0, 1000));
-    lines.push("```");
-    lines.push("");
-
-    // Task 6.15 — fetch remediation hints from EE behavioral rules
-    if (opts.fetchBBContext) {
-      try {
-        // Extract key error keywords from stderr (first 200 chars of output)
-        const keywords = f.output
-          .slice(0, 200)
-          .replace(/[^\w\s]/g, " ")
-          .trim();
-        const ctx = await opts.fetchBBContext(keywords);
-        if (ctx.behavioralRules.length > 0) {
-          lines.push("**Remediation hints from EE:**");
-          for (const rule of ctx.behavioralRules.slice(0, 3)) {
-            lines.push(`- ${rule.text.slice(0, 200)}`);
-          }
-          lines.push("");
-        }
-      } catch {
-        // EE unavailable — skip hints
-      }
-    }
-  }
-
-  lines.push("## Next steps");
-  lines.push("");
-  lines.push("Run `/ideal --resume .` to attempt interactive fixes.");
-  lines.push("");
-  lines.push("Or fix manually and re-run:");
-  lines.push("```");
-  lines.push("dotnet restore && dotnet build -c Debug --nologo");
-  lines.push("pwsh ./scripts/check-modular-boundaries.ps1 -RepoRoot .");
-  lines.push("```");
-
-  const outPath = path.join(serverDir, "EE-GATE-FAILURES.md");
-  writeFileFn(outPath, lines.join("\n"));
-
-  process.stdout.write(
-    `⚠️ Scaffold complete with ${failures.length} gate failure(s) — see EE-GATE-FAILURES.md. Run /ideal --resume to attempt fixes interactively.\n`,
-  );
-}
-
-// ---------------------------------------------------------------------------
-// Convenience: run gate + retry + soft fallback in one call
-// ---------------------------------------------------------------------------
-
-export async function runGatePipeline(
-  opts: BBQualityGateOptions,
-  onRetryCodeGen?: () => Promise<void>,
-): Promise<GateResult> {
-  const result = await runQualityGateWithRetry(opts, onRetryCodeGen);
-
-  if (!result.passed) {
-    await emitGateFailuresFallback({
-      serverDir: opts.serverDir,
-      failures: result.failures,
-      fetchBBContext: opts.fetchBBContext,
-      writeFile: opts.writeFile,
-    });
-  }
-
-  return result;
-}

package/src/scaffold/continuation-prompt.ts

@@ -1,80 +0,0 @@
-/**
- * Build the concrete continuation prompt fed to the LLM after an init_new
- * scaffold completes. The prompt MUST be specific enough that the LLM stops
- * asking "what do you want?" and starts generating domain code.
- */
-export interface ContinuationPromptInput {
-  originalPrompt: string;
-  projectDir: string;
-  templateName: string;
-  installedPackages?: readonly string[];
-}
-
-export function buildIdealContinuationPrompt(input: ContinuationPromptInput): string {
-  const { originalPrompt, projectDir, templateName, installedPackages } = input;
-
-  const packagesSuffix =
-    installedPackages && installedPackages.length > 0 ? ` with packages: ${installedPackages.join(", ")}` : "";
-
-  return `You are continuing a /ideal product loop. The project has been scaffolded at ${projectDir} using the BB template ${templateName}${packagesSuffix}.
-
-User's original request:
-"${originalPrompt}"
-
-You MUST implement this feature now. Do NOT ask the user for clarification unless a hard blocker is reached (missing API key, ambiguous schema requirement, etc.).
-
-Execute these steps in order:
-
-1. Discover structure (1-2 tool calls max)
-   - PREFERRED: if a \`muonroi-docs\` MCP tool is in your tool list (look for any \`mcp_*docs*_docs_search\` tool), call it with query \`"${templateName} structure overview"\`. This is faster than reading files.
-   - FALLBACK: list the project directory, then read whichever of \`README.md\`, \`AGENTS.md\`, \`Agent.md\`, \`EE-INTENT.md\` actually exist (do NOT assume — missing files are fine, just skip them).
-   - Identify: project name, main entry point (Program.cs / Gateway), modular boundaries, where to add new domain code.
-
-IMPORTANT — Template sample files are REFERENCE ONLY:
-   - The BB template ships example code (e.g. \`todo-app.Catalog\`, sample \`TodoRepository\`, \`Catalog\` controller, \`DocTemplateDbContext\`, \`BaseTemplateDbContext\`) named after the template/demo, NOT after the user's project.
-   - Read AT MOST ONE such sample file to learn the convention, then DELETE all template sample directories before generating your real domain code. They are reference, not the user's feature.
-   - Do not re-read the same sample file repeatedly. If you need its pattern again, recall from memory or rely on \`docs.search\`.
-   - RENAME every file/class/namespace that still contains the literal token \`BaseTemplate\`, \`DocTemplate\`, or \`TemplateSample\` to a project-appropriate name BEFORE writing domain code. After cleanup, \`git grep -i basetemplate\` MUST return zero hits — the post-scaffold quality gate fails if any survive.
-   - DELETE any stub \`<projectName>.Catalog/\` directory that lives at server root next to \`server/src/Services/\` — \`dotnet new\` may emit a duplicate empty stub.
-
-.NET / C# conventions to follow:
-   - Async methods MUST accept and forward \`CancellationToken\` to every downstream await; suffix names with \`Async\`.
-   - Prefer singular folder names that already exist in the template; if you add new folders, use \`Infrastructure\` (singular), \`Enums\` (plural), \`Authorization\` instead of "Permissioning".
-   - Namespace MUST mirror the folder path under the project, in PascalCase.
-   - DTO ≠ Entity. Don't return EF entities from controllers — always project to a DTO.
-   - DI registration uses \`AddX*\` extension methods in a static class under \`Extensions/\` or \`DependencyInjection/\`; wire them from \`Program.cs\`. Do not register services inline in \`Program.cs\`.
-
-Frontend / client/ conventions (apply ONLY if a \`client/\` directory exists in the scaffold):
-   - NEVER delete or overwrite \`SemanticProvider\`, \`createSemanticRegistry\`, or any \`<Semantic ...>\` wrapper that the scaffold wrote into \`main.tsx\` / \`app.component.ts\`. The agent harness depends on them — removing them silently breaks all E2E specs. If you rewrite \`main.tsx\`, re-include the existing SemanticProvider block verbatim.
-   - Wrap every NEW user-visible region with \`<Semantic id="..." role="..." name="...">\` (composer, list, listitem, modal, statusbar). Pick \`role\` from the union in \`@muonroi/agent-harness-core/protocol\`.
-   - NEVER hardcode API URLs in components. Read from \`import.meta.env.VITE_API_BASE\` (React/Vite) or \`environment.apiBase\` (Angular). If \`.env.example\` does not exist yet, create it with a sensible default; never inline \`http://localhost:5000\` or similar in source.
-   - Put HTTP + DTO code under \`client/src/api/\`. Define request/response types in \`api/types.ts\` (mirror the C# DTO names). Components import a typed client; never call \`fetch\` directly.
-   - Every async view needs THREE states: loading, empty, error. Surface errors via a toast/notification component, not \`console.error\`. Provide an \`ErrorBoundary\` at the app shell.
-   - No inline \`style={{...}}\` literals — use CSS modules (\`*.module.css\`) or utility classes (Tailwind if scaffolded). If neither is present, write tokens + reset into \`src/styles/app.css\` and import it ONCE in main; reference variables via \`var(--color-...)\`.
-   - TypeScript MUST be strict. If \`tsconfig.json\` does not have \`"strict": true\`, add it. Run \`bunx tsc --noEmit\` before declaring done — it must exit 0.
-   - Run \`bun run build\` from \`client/\` before declaring done — it must exit 0 with zero browser-side console errors.
-
-2. Design the feature
-   - List the domain entity(ies), DTOs, endpoints, persistence model.
-   - Match BB conventions (controller-per-resource, MediatR/CQRS if used, validation patterns observed in step 1).
-   - State your design in 5-10 lines before generating code.
-
-3. Generate code
-   - Create files in the locations identified in step 1.
-   - Wire DI in Program.cs (use BB extension methods if present).
-   - Mirror existing patterns — same namespaces, attributes, error-handling style.
-
-4. Verify
-   - Run \`dotnet build\` from the server root — must exit 0.
-   - If a \`client/\` directory exists, also run \`bun install\` and \`bun run build\` from \`client/\`.
-   - Report concrete evidence: build output excerpt + file list created.
-
-5. Summarize
-   - 3-5 bullets: what was added, where, how to test manually.
-
-Constraints:
-- Don't re-scaffold. Don't run \`dotnet new\` again.
-- Don't \`cd\` into ${projectDir} — your working directory is already there.
-- Don't ask "do you want me to continue?" — proceed end-to-end.
-- If you hit a blocker that genuinely needs the user, state EXACTLY which decision is blocking and stop.`;
-}

package/src/scaffold/continue-as-council.ts

@@ -1,99 +0,0 @@
-/**
- * continue-as-council.ts — Brainstorm-mode fallback for the halt recovery flow.
- *
- * When the user picks "Continue as council brainstorm" from the HaltRecoveryCard,
- * this scaffolder:
- *   1. Runs a lightweight council debate over the original prompt (or accepts a
- *      mock via the `runCouncil` injection point for testability).
- *   2. Collects all delta text into a spec.md skeleton.
- *   3. Writes spec.md to outputDir.
- *   4. Returns the spec path and a `hasContent` flag.
- *
- * IMPORTANT: This module does NOT call the verify gate, sprint-runner, or any
- * code path that would re-enter CB-3. Production council wiring is deferred per the
- * Task 5.5 decision recorded in the plan; the caller (app.tsx) emits a
- * "switch-to-council" event when the real orchestrator is available.
- */
-
-import * as nodePath from "node:path";
-
-// ---------------------------------------------------------------------------
-// Public types
-// ---------------------------------------------------------------------------
-
-export interface ContinueAsCouncilOptions {
-  /** The original /ideal prompt the user issued. */
-  prompt: string;
-  /** Where to write spec.md. Defaults to process.cwd(). */
-  outputDir?: string;
-  /**
-   * Inject the council runner for testability.
-   * The real production caller wires this to src/council/index.ts runCouncil.
-   * If omitted a no-op empty stream is used (results in hasContent: false).
-   */
-  runCouncil?: (prompt: string) => AsyncIterable<{ type: "delta" | "done"; content?: string }>;
-  /** Inject filesystem ops for testability. */
-  fs?: {
-    writeFile: (p: string, content: string) => Promise<void>;
-  };
-}
-
-export interface ContinueAsCouncilResult {
-  /** Absolute path to the written spec.md */
-  specPath: string;
-  /** Whether the council produced any content. */
-  hasContent: boolean;
-}
-
-// ---------------------------------------------------------------------------
-// Implementation
-// ---------------------------------------------------------------------------
-
-/**
- * Run a council brainstorm and write the result to spec.md.
- *
- * Skips the verify gate, does NOT touch sprint-runner, does NOT re-enter CB-3.
- */
-export async function continueAsCouncil(opts: ContinueAsCouncilOptions): Promise<ContinueAsCouncilResult> {
-  const outputDir = opts.outputDir ?? process.cwd();
-  const specPath = nodePath.resolve(outputDir, "spec.md");
-
-  // ── Collect council delta text ──────────────────────────────────────────────
-  let body = "";
-
-  if (opts.runCouncil) {
-    for await (const chunk of opts.runCouncil(opts.prompt)) {
-      if (chunk.type === "delta" && chunk.content) {
-        body += chunk.content;
-      }
-      if (chunk.type === "done") {
-        break;
-      }
-    }
-  }
-
-  const hasContent = body.trim().length > 0;
-
-  // ── Build spec.md skeleton ──────────────────────────────────────────────────
-  const heading = `# Council brainstorm output\n\n**Prompt:** ${opts.prompt}\n\n`;
-  const bodySection = hasContent
-    ? `## Notes from council debate\n\n${body.trim()}\n`
-    : `## Notes from council debate\n\n_(No content was produced by the council stream.)_\n`;
-
-  const specContent = heading + bodySection;
-
-  // ── Write spec.md ───────────────────────────────────────────────────────────
-  const writeFile = opts.fs?.writeFile ?? defaultWriteFile;
-  await writeFile(specPath, specContent);
-
-  return { specPath, hasContent };
-}
-
-// ---------------------------------------------------------------------------
-// Default fs helpers (swapped out in tests via opts.fs)
-// ---------------------------------------------------------------------------
-
-async function defaultWriteFile(p: string, content: string): Promise<void> {
-  const { writeFile } = await import("node:fs/promises");
-  await writeFile(p, content, "utf-8");
-}