muonroi-cli 1.4.0 → 1.4.1

package/src/product-loop/discovery-ecosystem.ts

@@ -1,239 +0,0 @@
-/**
- * Ecosystem-aware prompt fragments for the Muonroi /ideal pipeline.
- *
- * Problem this solves:
- *   Without bias, leader LLMs default to general-purpose answers ("Node.js +
- *   Express" for SaaS web) — ignoring the fact that the user is running the
- *   *Muonroi ecosystem CLI* and almost certainly wants to build inside it.
- *   Discovery recommendations, debate stances, and research questions all
- *   need the same ecosystem framing so the council reasons WITHIN the
- *   existing template + package set instead of suggesting greenfield
- *   reinventions.
- *
- * Single source of truth for:
- *   - `buildEcosystemPreamble()` — discovery recommender prompt prefix.
- *   - `buildEcosystemDebateContext()` — debate-planner system-prompt suffix.
- *   - `buildEcosystemResearchSeed()` — research-stance lens augmentation.
- *   - `isEcosystemBiasEnabled()` — opt-out via userSettings (default ON).
- *
- * Opt-out: `userSettings.discoveryEcosystemBias = false` disables ALL four
- * inject sites in one switch, for users running muonroi-cli to build
- * something outside the ecosystem.
- *
- * Auto-suppress: even when the setting is ON, `shouldApplyEcosystemBias` will
- * suppress the bias for existing non-.NET repos (e.g. a TypeScript CLI). The
- * old behavior — pushing Muonroi.BaseTemplate / .NET 9 as defaults for a
- * TypeScript repo — caused councils to debate the wrong stack. See session
- * cfc711c57df0 (improve council quality in muonroi-cli) for the regression.
- */
-
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { loadUserSettings } from "../utils/settings.js";
-
-/**
- * Default ON. Reads `userSettings.discoveryEcosystemBias` — only `false`
- * explicitly disables. `undefined`/`true` both → enabled.
- */
-export function isEcosystemBiasEnabled(): boolean {
-  try {
-    const s = loadUserSettings();
-    return s.discoveryEcosystemBias !== false;
-  } catch {
-    // Settings unreadable — fail OPEN (ecosystem bias active). Better to
-    // over-bias than under-bias for the CLI of a specific ecosystem.
-    return true;
-  }
-}
-
-/**
- * Detection signal shape accepted by `shouldApplyEcosystemBias`. Kept loose
- * (Partial) so callers from different layers (discovery, council, loop-driver)
- * can pass whatever they have without coupling to the full ExistingProjectSignals type.
- */
-export interface EcosystemBiasDetection {
-  classification?: "greenfield" | "existing" | "ambiguous" | string;
-  languages?: string[];
-  manifests?: Array<{ type?: string; name?: string }>;
-}
-
-/**
- * Decide whether to apply Muonroi-ecosystem bias for the CURRENT call.
- *
- * Rule (binary, on folder state):
- *  - **Greenfield** (empty folder / no folder) → return true. Scaffolding a
- *    new project into the Muonroi ecosystem is the legitimate use of the
- *    preamble; .NET / BB / harness defaults belong here.
- *  - **Any folder with existing code** (existing OR ambiguous classification,
- *    OR cwd-probe finds manifests/source files) → return false. The leader
- *    must explore the existing stack and clarify the user's intent against
- *    THAT, not push a vendor-default stack on top of an unrelated codebase.
- *
- * Suppression also happens unconditionally when
- * `userSettings.discoveryEcosystemBias === false`.
- *
- * Signal precedence:
- *   1. setting → if `false`, return false immediately.
- *   2. detection.classification → if present, the literal value decides
- *      (greenfield ⇒ true; anything else ⇒ false). No language / manifest
- *      inspection — the user's rule is binary on folder state, not stack.
- *   3. cwd-probe fallback (sync, ~1ms) when detection is unavailable. Treats
- *      cwd as greenfield only when no source files AND no manifests are
- *      present at the top level. Any of `package.json`, `Cargo.toml`,
- *      `go.mod`, `pyproject.toml`, `pom.xml`, `build.gradle`, `*.csproj`,
- *      `*.sln`, `Directory.Build.props`, or any source extension at the
- *      top level disqualifies. Probe errors are swallowed and treated as
- *      "not greenfield" (better to suppress bias than to over-bias on
- *      uncertainty for existing-project workflows).
- *   4. If neither detection nor cwd is provided, default to true
- *      (legacy behaviour — most discovery call sites pass detection).
- */
-const _MANIFEST_FILENAMES = new Set([
-  "package.json",
-  "cargo.toml",
-  "go.mod",
-  "pyproject.toml",
-  "pom.xml",
-  "build.gradle",
-  "directory.build.props",
-]);
-const _SOURCE_EXTS = new Set([
-  ".ts",
-  ".tsx",
-  ".js",
-  ".jsx",
-  ".mjs",
-  ".cjs",
-  ".rs",
-  ".go",
-  ".py",
-  ".cs",
-  ".java",
-  ".kt",
-  ".swift",
-  ".rb",
-  ".php",
-]);
-
-function probeCwdIsGreenfield(cwd: string): boolean {
-  let entries: string[];
-  try {
-    entries = fs.readdirSync(cwd);
-  } catch {
-    return false;
-  }
-  for (const name of entries) {
-    if (name.startsWith(".")) continue;
-    const lower = name.toLowerCase();
-    if (_MANIFEST_FILENAMES.has(lower)) return false;
-    if (lower.endsWith(".csproj") || lower.endsWith(".sln")) return false;
-    const dot = lower.lastIndexOf(".");
-    if (dot > 0 && _SOURCE_EXTS.has(lower.slice(dot))) return false;
-  }
-  return true;
-}
-
-export function shouldApplyEcosystemBias(opts?: { detection?: EcosystemBiasDetection; cwd?: string }): boolean {
-  if (!isEcosystemBiasEnabled()) return false;
-
-  const det = opts?.detection;
-  if (det?.classification !== undefined) {
-    return det.classification === "greenfield";
-  }
-
-  const cwd = opts?.cwd;
-  if (cwd) {
-    try {
-      return probeCwdIsGreenfield(cwd);
-    } catch {
-      return false;
-    }
-  }
-
-  return true;
-}
-
-/**
- * Discovery-recommender preamble. Prepended to the leader prompt for every
- * AskCard question so the leader recommends WITHIN the Muonroi ecosystem.
- *
- * Kept concise (~12 lines) — recommender uses maxTokens=4096 but the prompt
- * still competes with detection signals, prior runs, and context-so-far.
- */
-export function buildEcosystemPreamble(): string {
-  return [
-    "Ecosystem context: this CLI ships with the Muonroi ecosystem. Recommend WITHIN it.",
-    "",
-    "Backend default:",
-    "- .NET 9 with one of the Muonroi templates (nupkgs published on NuGet):",
-    "  - Muonroi.BaseTemplate (greenfield, modular monolith)",
-    "  - Muonroi.Microservices.Template (microservices)",
-    "  - Muonroi.Modular.Template (modular monolith, larger scope)",
-    "- Building blocks: muonroi-building-block (BB) — auth, audit, modular boundaries, rule engines.",
-    "- DB: PostgreSQL via EF Core / Npgsql.",
-    "",
-    "Frontend default:",
-    "- React with @muonroi/agent-harness-react wrapper, or",
-    "- Angular with @muonroi/agent-harness-angular directive.",
-    'When recommending `frontendApproach`, ALWAYS fill the optional `agentHarness` slot — pick "react" for React/Next, "angular" for Angular, "opentui" for terminal UI, "core" for non-DOM integration. Only use "none" when the project has no UI at all.',
-    "",
-    "Recommend non-ecosystem options ONLY when the user's prompt explicitly opts out (e.g. mentions Node.js/Express/Django by name).",
-  ].join("\n");
-}
-
-/**
- * Debate-planner system-prompt suffix. Appended after the base debate prompt
- * so the leader plans stances framed around "optimal use of EXISTING ecosystem
- * packages" rather than greenfield analysis.
- *
- * Differs from the recommender preamble: this targets the stance LENS, not
- * the answer value. Tells the leader to pick stances that compare BB recipes,
- * not stances that compare general architectures.
- */
-export function buildEcosystemDebateContext(): string {
-  return [
-    "## Ecosystem framing (Muonroi)",
-    "Stances and output sections MUST be framed around optimal use of the existing Muonroi ecosystem packages:",
-    "- muonroi-building-block (BB) — auth, audit, modular boundaries, rule engines",
-    "- Muonroi.BaseTemplate / Muonroi.Microservices.Template / Muonroi.Modular.Template",
-    "- @muonroi/agent-harness-{core,opentui,react,angular}",
-    "",
-    "When designing stances, prefer lenses that:",
-    "1. Compare which BB package(s) solve the user's need without writing new infra.",
-    "2. Identify modular boundaries (Authorization, Infrastructure, Application/Queries vs Commands) using existing template conventions.",
-    "3. Surface mismatches between the user's brief and the conventions baked into the templates.",
-    "",
-    "Avoid stances that propose greenfield reinventions of features already shipped by BB.",
-  ].join("\n");
-}
-
-/**
- * Research-stance lens augmentation. Returns a string appended to the
- * `Researcher` and `Architect` stance lenses in the research phase, so the
- * debate prioritizes `muonroi-docs` MCP queries + existing-package
- * composition before reaching for the open web.
- */
-export interface EcosystemResearchSeed {
-  researcherLens: string;
-  architectLens: string;
-  skepticLens: string;
-}
-
-export function buildEcosystemResearchSeed(): EcosystemResearchSeed {
-  return {
-    researcherLens:
-      "Query muonroi-docs MCP first (`docs_search` for BB package usage, recipes, conventions). " +
-      "Fall back to web search ONLY when muonroi-docs returns nothing relevant. " +
-      "When the user names a specific URL on docs.muonroi.com, fetch it directly via web_fetch — " +
-      "the same content is in MCP but the URL anchor signals the user wants that exact page. " +
-      "Identify which existing BB / template packages address the user's need before proposing new code.",
-    architectLens:
-      "Compose the solution from EXISTING ecosystem packages (BB, Muonroi.* templates, " +
-      "@muonroi/agent-harness-*). Greenfield code is allowed only for domain logic that " +
-      "no shipped package covers. Mirror the directory/namespace conventions of the chosen template.",
-    skepticLens:
-      "Stress-test claims against the ACTUAL behavior of BB packages. " +
-      "If a proposal cites a feature, demand evidence from muonroi-docs that the package supports it. " +
-      "Flag every greenfield-reinvention risk where an ecosystem package would have sufficed.",
-  };
-}

package/src/product-loop/discovery-interview.ts

@@ -1,288 +0,0 @@
-// src/product-loop/discovery-interview.ts
-
-import {
-  appendUserOverride,
-  buildProjectContextFromState,
-  markDone,
-  markUserGatePassed,
-  readDiscoveryState,
-  recordRecommendation,
-  saveDiscoveryAnswer,
-  writeProjectContext,
-} from "./discovery-persistence.js";
-import {
-  computePromptSpecificity,
-  type RecommendInput,
-  type RecommendOutput,
-  toEntry,
-} from "./discovery-recommender.js";
-import {
-  DISCOVERY_QUESTIONS,
-  isFePolicyAccepted,
-  isRequiredForPlatform,
-  REQUIRED_QUESTION_IDS,
-  validateAnswer,
-} from "./discovery-schema.js";
-import { buildRepoBrief, type RepoBrief } from "./repo-brief.js";
-import type { ExistingProjectSignals, PlatformT, ProjectContext } from "./types.js";
-
-export type UserPromptResult =
-  | { action: "accept" }
-  | { action: "override"; value: any; reason: string }
-  | { action: "skip" }
-  | { action: "more-options" }
-  | { action: "proceed" }
-  | { action: "ask-more" }
-  | { action: "abort" };
-
-export interface UserPromptArgs {
-  questionId: string;
-  recommendation?: RecommendOutput;
-  prefilled?: any;
-  message?: string;
-}
-
-export type UserPromptFn = (args: UserPromptArgs) => Promise<UserPromptResult>;
-
-export interface RecommenderLike {
-  leaderRecommend: (input: RecommendInput) => Promise<RecommendOutput>;
-  councilRecommend: (input: RecommendInput) => Promise<RecommendOutput>;
-}
-
-export interface IterateOpts {
-  flowDir: string;
-  runId: string;
-  idea: string;
-  capUsd: number;
-  detection: ExistingProjectSignals;
-  userPrompt: UserPromptFn;
-  recommender: RecommenderLike;
-  /**
-   * Working directory used to build the repo brief when `detection.classification`
-   * is not `greenfield`. Defaults to `process.cwd()`. Tests can override with a
-   * sandboxed temp dir to exercise existing-project paths deterministically.
-   */
-  cwd?: string;
-}
-
-export async function iterateInterview(opts: IterateOpts): Promise<ProjectContext> {
-  const { flowDir, runId, detection } = opts;
-  const _itvDbg = process.env.MUONROI_DEBUG_LEADER === "1";
-  const _itvId = Math.random().toString(36).slice(2, 8);
-  if (_itvDbg) {
-    process.stderr.write(`[interview-entry] iterateInterview-CALLED itvId=${_itvId} runId=${runId}\n`);
-  }
-  const state0 = await readDiscoveryState(flowDir, runId);
-  if (!state0) throw new Error("discovery state not initialized — call initDiscoveryState first");
-
-  // P2-4: when user's prompt is minimal (<=10 words, no qualifiers), skip
-  // optional questions. Asking 8 cards for a 5-word prompt cascades user
-  // accept-spam into a locked-in spec the council debates against. The required
-  // questions still run — they're needed to pin productType/audience/stack —
-  // but optional ones (baStatus, designStatus, deployment, frontendApproach when
-  // not web) are deferred unless the user explicitly re-runs with more context.
-  const specificity = computePromptSpecificity(opts.idea);
-  const skipOptionalForMinimal = specificity === "minimal";
-
-  // Build the repo brief ONCE per interview run for existing projects. The
-  // brief replaces the Muonroi vendor preamble inside leader prompts so
-  // rationales must cite real files, deps, and scripts. Skipped for greenfield —
-  // there's no source tree to summarize.
-  let repoBrief: RepoBrief | undefined;
-  if (detection.classification !== "greenfield") {
-    try {
-      repoBrief = await buildRepoBrief(opts.cwd ?? process.cwd(), detection);
-    } catch (err) {
-      // Brief failure should NEVER block discovery — fall through with no
-      // brief; leader will see no preamble + no brief and still produce
-      // a (less grounded) answer.
-      if (_itvDbg) {
-        process.stderr.write(`[interview-entry] repoBrief-build-failed: ${(err as Error).message}\n`);
-      }
-    }
-  }
-
-  for (const question of DISCOVERY_QUESTIONS) {
-    if (_itvDbg) {
-      process.stderr.write(`[interview-entry] outer-for itvId=${_itvId} questionId=${question.id}\n`);
-    }
-    const state = await readDiscoveryState(flowDir, runId);
-    if (!state) throw new Error("state lost mid-iteration");
-    const isPrefilled =
-      state.prefillSource.fromDetection.includes(question.id) || state.prefillSource.fromPrompt.includes(question.id);
-    if (state.questionsAnswered.includes(question.id) || isPrefilled) continue;
-
-    const _isOptional = !question.required;
-    const platforms = (state.answers.targetPlatform ?? []) as PlatformT[];
-    const platformRequires = isRequiredForPlatform(question.id, platforms);
-    const effectivelyRequired = question.required || platformRequires;
-
-    // P2-4: skip non-effectively-required questions when prompt is minimal.
-    if (skipOptionalForMinimal && !effectivelyRequired) {
-      if (_itvDbg) {
-        process.stderr.write(
-          `[interview-entry] skip-optional itvId=${_itvId} questionId=${question.id} reason=minimal-prompt\n`,
-        );
-      }
-      continue;
-    }
-
-    const recInput: RecommendInput = {
-      question,
-      context: state.answers,
-      detection,
-      userIdea: opts.idea,
-      repoBrief,
-    };
-
-    let recommendation: RecommendOutput;
-    if (question.recommendMode === "council") {
-      recommendation = await opts.recommender.councilRecommend(recInput);
-    } else {
-      recommendation = await opts.recommender.leaderRecommend(recInput);
-    }
-
-    // Per-question skip-attempt counter for required questions.
-    // Resets when the user provides a real answer (accept/override).
-    let skipAttempts = 0;
-    const MAX_SKIP_ATTEMPTS = 3;
-    const _debugInterview = process.env.MUONROI_DEBUG_LEADER === "1";
-
-    for (;;) {
-      const _iterStart = Date.now();
-      if (_debugInterview) {
-        process.stderr.write(
-          `[interview-timing] iter-start: ${JSON.stringify({ questionId: question.id, skipAttempts })}\n`,
-        );
-      }
-      const ans = await opts.userPrompt({
-        questionId: question.id,
-        recommendation,
-      });
-      if (_debugInterview) {
-        process.stderr.write(
-          `[interview-timing] userPrompt-resolved: ${JSON.stringify({
-            questionId: question.id,
-            durationMs: Date.now() - _iterStart,
-            action: ans.action,
-          })}\n`,
-        );
-      }
-
-      if (ans.action === "skip") {
-        if (effectivelyRequired) {
-          skipAttempts += 1;
-          if (skipAttempts >= MAX_SKIP_ATTEMPTS) {
-            // Budget exhausted: escalate this question as unspecified and
-            // break out of the inner loop. Downstream CB-3 will surface a
-            // clean halt-card because a required dimension stays unresolved.
-            break;
-          }
-          await opts.userPrompt({ questionId: question.id, message: "Required question cannot be skipped" });
-          continue;
-        }
-        break;
-      }
-
-      // NOTE: skipAttempts is intentionally NOT reset here. A successful answer
-      // breaks out of the inner loop and the outer for-loop re-declares
-      // skipAttempts = 0 for the next question, so the reset is redundant on
-      // the happy path. Resetting on every non-skip action (including invalid
-      // overrides) would allow an infinite skip→override(invalid)→skip loop —
-      // the budget must accumulate across all non-answer iterations.
-      let chosenValue: any;
-      if (ans.action === "accept") {
-        chosenValue = recommendation.primary.value;
-      } else if (ans.action === "override") {
-        chosenValue = ans.value;
-      } else if (ans.action === "more-options") {
-        // current iteration: re-prompt; future ext could fetch more
-        continue;
-      } else if (ans.action === "abort") {
-        throw new Error("discovery aborted by user");
-      } else {
-        continue;
-      }
-
-      const validation = validateAnswer(question.id, chosenValue);
-      if (!validation.ok) {
-        // For frontendApproach, the FE policy block below handles rejection (no extra message call)
-        if (question.id !== "frontendApproach") {
-          await opts.userPrompt({ questionId: question.id, message: validation.reason ?? "invalid answer" });
-        }
-        continue;
-      }
-
-      // FE policy hard-block
-      if (question.id === "frontendApproach") {
-        const lib = (chosenValue as any)?.library;
-        if (lib && !isFePolicyAccepted(lib)) {
-          await opts.userPrompt({
-            questionId: question.id,
-            message: "FE policy: library must be shadcn, radix, headlessui, or none",
-          });
-          continue;
-        }
-      }
-
-      if (ans.action === "override") {
-        await appendUserOverride(flowDir, runId, question.id, recommendation.primary.value, chosenValue, ans.reason);
-      }
-
-      if (_debugInterview) {
-        process.stderr.write(`[persist-start] recordRecommendation ${question.id}\n`);
-      }
-      await recordRecommendation(flowDir, runId, question.id, toEntry(recommendation), recommendation.costUsd);
-      if (_debugInterview) {
-        process.stderr.write(`[persist-mid] saveDiscoveryAnswer ${question.id}\n`);
-      }
-      await saveDiscoveryAnswer(flowDir, runId, question.id, chosenValue);
-      if (_debugInterview) {
-        process.stderr.write(`[persist-end] ${question.id} saved\n`);
-      }
-      break;
-    }
-    if (_itvDbg) {
-      process.stderr.write(`[interview-entry] inner-loop-exit itvId=${_itvId} questionId=${question.id}\n`);
-    }
-
-    // After each required answered, check if we've satisfied all effectively-required questions for user gate
-    const refreshed = await readDiscoveryState(flowDir, runId);
-    const refreshedPlatforms = (refreshed?.answers.targetPlatform ?? []) as PlatformT[];
-    if (
-      refreshed &&
-      allRequiredAnswered(refreshed.questionsAnswered, refreshedPlatforms) &&
-      !refreshed.userGatePassed
-    ) {
-      const gate = await opts.userPrompt({ questionId: "__user_gate__" });
-      if (gate.action === "proceed") {
-        await markUserGatePassed(flowDir, runId);
-        break;
-      }
-      if (gate.action === "abort") throw new Error("discovery aborted at user gate");
-      // ask-more: continue iterating optional questions
-    }
-  }
-
-  const finalState = await readDiscoveryState(flowDir, runId);
-  if (!finalState) throw new Error("state lost at end");
-  if (!finalState.userGatePassed) {
-    await markUserGatePassed(flowDir, runId);
-  }
-  const ctx = buildProjectContextFromState(finalState, opts.idea, detection);
-  await writeProjectContext(flowDir, runId, ctx);
-  await markDone(flowDir, runId);
-  return ctx;
-}
-
-function allRequiredAnswered(answered: string[], platforms: PlatformT[]): boolean {
-  const baseRequired = REQUIRED_QUESTION_IDS.every((id) => answered.includes(id));
-  if (!baseRequired) return false;
-  // Also check platform-required optional questions (e.g. frontendApproach for web)
-  for (const q of DISCOVERY_QUESTIONS) {
-    if (!q.required && isRequiredForPlatform(q.id, platforms) && !answered.includes(q.id)) {
-      return false;
-    }
-  }
-  return true;
-}

package/src/product-loop/discovery-migrations.ts

@@ -1,40 +0,0 @@
-// src/product-loop/discovery-migrations.ts
-import type { ProjectContext } from "./types.js";
-
-export const CURRENT_SCHEMA_VERSION = 1 as const;
-
-export type Migrator = (prev: any) => any;
-
-export const migrators: Record<number, Migrator> = {
-  0: (prev) => ({ ...prev, version: 1, schemaName: "project-context" }),
-};
-
-function stripCodeFences(raw: string): string {
-  return raw
-    .trim()
-    .replace(/^```(?:json)?\s*/, "")
-    .replace(/\s*```$/, "");
-}
-
-export function readProjectContextWithMigration(raw: string): ProjectContext | null {
-  if (!raw || typeof raw !== "string") return null;
-  let parsed: any;
-  try {
-    parsed = JSON.parse(stripCodeFences(raw));
-  } catch {
-    return null;
-  }
-  if (!parsed || typeof parsed !== "object") return null;
-  let current = parsed.version === undefined ? { ...parsed, version: 0 } : parsed;
-  try {
-    while (current.version < CURRENT_SCHEMA_VERSION) {
-      const m = migrators[current.version];
-      if (!m) return null;
-      current = m(current);
-    }
-  } catch {
-    return null;
-  }
-  if (current.version !== CURRENT_SCHEMA_VERSION) return null;
-  return current as ProjectContext;
-}