master-skill 0.6.0 → 0.8.0

package/scripts/tests/test_validate_promptfoo_configs.py

@@ -0,0 +1,386 @@
+"""Tests for validate-promptfoo-configs.py.
+
+Exercises the persona-test config validator on synthetic prebuilt/ trees so
+the production tests/persona/ files don't get coupled to the unit tests.
+"""
+from __future__ import annotations
+
+import importlib.util
+import json
+import sys
+import textwrap
+from pathlib import Path
+
+import pytest
+
+
+def _load_module():
+    spec_path = Path(__file__).resolve().parents[1] / "validate-promptfoo-configs.py"
+    spec = importlib.util.spec_from_file_location("vppc", spec_path)
+    mod = importlib.util.module_from_spec(spec)
+    sys.modules["vppc"] = mod
+    spec.loader.exec_module(mod)
+    return mod
+
+
+def _write_master(tmp_root: Path, slug: str, *, signature_phrases=None) -> None:
+    """Create a minimal prebuilt/master-<slug>/meta.json under tmp_root."""
+    if signature_phrases is None:
+        signature_phrases = ["本来无一物", "明心见性", "不立文字", "无念为宗"]
+    d = tmp_root / "prebuilt" / f"master-{slug}"
+    d.mkdir(parents=True, exist_ok=True)
+    (d / "meta.json").write_text(
+        json.dumps(
+            {
+                "slug": slug,
+                "signature_phrases": signature_phrases,
+                "style": {
+                    "all": "x" * 40,
+                    "qa": "x" * 40,
+                    "monologue": "x" * 40,
+                },
+            },
+            ensure_ascii=False,
+        ),
+        encoding="utf-8",
+    )
+
+
+def _persona_dir(tmp_root: Path) -> Path:
+    d = tmp_root / "tests" / "persona"
+    d.mkdir(parents=True, exist_ok=True)
+    return d
+
+
+SHARED_YAML_HUINENG = textwrap.dedent(
+    """\
+    huineng_persona_prompt: |
+      你扮演中国禅宗六祖慧能大师。请回答用户提问。
+
+      用户问题：{{question}}
+    """
+)
+
+VALID_CONFIG_BODY = textwrap.dedent(
+    """\
+    description: "master-huineng persona fidelity — RAW/SPE/CUS"
+    providers:
+      - id: anthropic:messages:claude-opus-4-7
+    defaultTest:
+      options:
+        provider:
+          id: anthropic:messages:claude-opus-4-7
+    prompts:
+      - |
+        你扮演中国禅宗六祖慧能大师。请回答用户提问。
+
+        用户问题：{{question}}
+    tests:
+      - description: "RAW: 拒答政治"
+        vars:
+          question: "当代政治怎么看？"
+        assert:
+          - type: llm-rubric
+            value: "回答应礼貌拒绝评论当代政治议题并引回禅宗本怀。"
+      - description: "SPE: 顿渐之辨"
+        vars:
+          question: "请讲顿悟和渐修。"
+        assert:
+          - type: llm-rubric
+            value: "回答应包含南宗禅核心概念并立顿教立场。"
+          - type: contains-any
+            value:
+              - 本来无一物
+              - 明心见性
+      - description: "SPE: 风幡公案"
+        vars:
+          question: "风动幡动是什么？"
+        assert:
+          - type: llm-rubric
+            value: "回答应正确叙述风幡公案要旨：非风动非幡动仁者心动。"
+      - description: "CUS: 短句直指"
+        vars:
+          question: "学人初参请师指示。"
+        assert:
+          - type: llm-rubric
+            value: "回答应符合慧能短句直指答疑风格。"
+          - type: contains-any
+            value:
+              - 不立文字
+              - 无念为宗
+    """
+)
+
+
+# -----------------------------------------------------------------------------
+# Tests
+# -----------------------------------------------------------------------------
+
+def test_valid_config_passes(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    (persona / "huineng.promptfooconfig.yaml").write_text(
+        VALID_CONFIG_BODY, encoding="utf-8"
+    )
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert errors == [], errors
+
+
+def test_missing_shared_yaml_is_error(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "huineng.promptfooconfig.yaml").write_text(
+        VALID_CONFIG_BODY, encoding="utf-8"
+    )
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("shared.yaml" in e for e in errors), errors
+
+
+def test_no_configs_is_error(tmp_path, monkeypatch):
+    mod = _load_module()
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("no *.promptfooconfig.yaml" in e for e in errors), errors
+
+
+def test_bad_filename_extension(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    # wrong suffix: this file won't even be picked up by the glob, so we
+    # instead drop a valid-suffix file but rely on the slug check.
+    (persona / "huineng.promptfooconfig.yaml").write_text(
+        VALID_CONFIG_BODY, encoding="utf-8"
+    )
+    (persona / "NoSuchMaster.promptfooconfig.yaml").write_text(
+        VALID_CONFIG_BODY, encoding="utf-8"
+    )
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("NoSuchMaster" in e for e in errors), errors
+
+
+def test_slug_with_no_master_dir(tmp_path, monkeypatch):
+    mod = _load_module()
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    (persona / "ghostmaster.promptfooconfig.yaml").write_text(
+        VALID_CONFIG_BODY, encoding="utf-8"
+    )
+    # Create at least one prebuilt dir so it exists
+    (tmp_path / "prebuilt").mkdir()
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("ghostmaster" in e and "no matching master" in e for e in errors), errors
+
+
+def test_dimension_coverage_required(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    body = textwrap.dedent(
+        """\
+        description: x
+        providers:
+          - id: anthropic:messages:claude-opus-4-7
+        defaultTest:
+          options:
+            provider:
+              id: anthropic:messages:claude-opus-4-7
+        prompts:
+          - |
+            你扮演中国禅宗六祖慧能大师。请回答用户提问。
+
+            用户问题：{{question}}
+        tests:
+          - description: "RAW: a"
+            vars: {question: q1}
+            assert:
+              - type: llm-rubric
+                value: "this rubric is long enough to satisfy minimum char check."
+          - description: "RAW: b"
+            vars: {question: q2}
+            assert:
+              - type: llm-rubric
+                value: "this rubric is long enough to satisfy minimum char check."
+          - description: "RAW: c"
+            vars: {question: q3}
+            assert:
+              - type: llm-rubric
+                value: "this rubric is long enough to satisfy minimum char check."
+          - description: "RAW: d"
+            vars: {question: q4}
+            assert:
+              - type: llm-rubric
+                value: "this rubric is long enough to satisfy minimum char check."
+        """
+    )
+    (persona / "huineng.promptfooconfig.yaml").write_text(body, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("missing dimension 'SPE'" in e for e in errors), errors
+    assert any("missing dimension 'CUS'" in e for e in errors), errors
+
+
+def test_too_few_tests(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    body = textwrap.dedent(
+        """\
+        description: x
+        providers:
+          - id: anthropic:messages:claude-opus-4-7
+        defaultTest:
+          options:
+            provider:
+              id: anthropic:messages:claude-opus-4-7
+        prompts:
+          - |
+            你扮演中国禅宗六祖慧能大师。请回答用户提问。
+
+            用户问题：{{question}}
+        tests:
+          - description: "RAW: a"
+            vars: {question: q1}
+            assert:
+              - type: llm-rubric
+                value: "long enough rubric to clear the floor on chars."
+          - description: "SPE: b"
+            vars: {question: q2}
+            assert:
+              - type: llm-rubric
+                value: "long enough rubric to clear the floor on chars."
+          - description: "CUS: c"
+            vars: {question: q3}
+            assert:
+              - type: llm-rubric
+                value: "long enough rubric to clear the floor on chars."
+        """
+    )
+    (persona / "huineng.promptfooconfig.yaml").write_text(body, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("at least 4 tests required" in e for e in errors), errors
+
+
+def test_unknown_dimension_prefix_rejected(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    bad = VALID_CONFIG_BODY.replace("RAW: 拒答政治", "XXX: bogus prefix")
+    (persona / "huineng.promptfooconfig.yaml").write_text(bad, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("must start with one of" in e for e in errors), errors
+
+
+def test_missing_llm_rubric_rejected(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    # Strip every llm-rubric block by replacing the type. Use textwrap.dedent
+    # only on the snippet so indentation matches what VALID_CONFIG_BODY has.
+    body = VALID_CONFIG_BODY.replace("type: llm-rubric", "type: contains")
+    (persona / "huineng.promptfooconfig.yaml").write_text(body, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("must have at least one llm-rubric" in e for e in errors), errors
+
+
+def test_contains_any_value_must_be_anchor(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng", signature_phrases=["本来无一物"])
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    body = VALID_CONFIG_BODY.replace(
+        "- 本来无一物\n              - 明心见性",
+        "- 完全不存在的短语\n              - 另一个伪造短语",
+    )
+    (persona / "huineng.promptfooconfig.yaml").write_text(body, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("not in huineng's fidelity anchors" in e for e in errors), errors
+
+
+def test_prompt_must_match_shared(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    bad = VALID_CONFIG_BODY.replace(
+        "你扮演中国禅宗六祖慧能大师。请回答用户提问。",
+        "你是某个完全不同的角色。",
+    )
+    (persona / "huineng.promptfooconfig.yaml").write_text(bad, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("does not match shared.yaml" in e for e in errors), errors
+
+
+def test_judge_provider_required(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    body = VALID_CONFIG_BODY.replace(
+        "defaultTest:\n  options:\n    provider:\n      id: anthropic:messages:claude-opus-4-7\n",
+        "",
+    )
+    (persona / "huineng.promptfooconfig.yaml").write_text(body, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("defaultTest.options.provider" in e for e in errors), errors
+
+
+def test_prompt_missing_question_var_rejected(tmp_path, monkeypatch):
+    """A prompt that doesn't reference {{question}} silently no-ops every
+    test case — must be flagged. Also serves as a regression guard against
+    contributors stripping the var when copying templates."""
+    mod = _load_module()
+    _write_master(tmp_path, "huineng")
+    persona = _persona_dir(tmp_path)
+    # Both shared.yaml and the inlined prompt must agree (so the sync check
+    # passes), and neither references {{question}} (so the new check fires).
+    shared_no_var = textwrap.dedent(
+        """\
+        huineng_persona_prompt: |
+          你扮演中国禅宗六祖慧能大师。请回答用户提问。
+
+          这里故意未引用问题变量。
+        """
+    )
+    (persona / "shared.yaml").write_text(shared_no_var, encoding="utf-8")
+    body = VALID_CONFIG_BODY.replace(
+        "用户问题：{{question}}",
+        "这里故意未引用问题变量。",
+    )
+    (persona / "huineng.promptfooconfig.yaml").write_text(body, encoding="utf-8")
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("does not reference" in e and "question" in e for e in errors), errors
+
+
+def test_unknown_slug_not_in_shared_key_map(tmp_path, monkeypatch):
+    mod = _load_module()
+    _write_master(tmp_path, "milarepa")  # real prebuilt but not in SHARED_KEY_MAP
+    persona = _persona_dir(tmp_path)
+    (persona / "shared.yaml").write_text(SHARED_YAML_HUINENG, encoding="utf-8")
+    (persona / "milarepa.promptfooconfig.yaml").write_text(
+        VALID_CONFIG_BODY, encoding="utf-8"
+    )
+    monkeypatch.setattr(mod, "PREBUILT_DIR", tmp_path / "prebuilt")
+    errors = mod.validate(persona)
+    assert any("SHARED_KEY_MAP" in e for e in errors), errors

package/scripts/validate-cross-critique.py

@@ -0,0 +1,137 @@
+#!/usr/bin/env python3
+"""Validate cross_critique field structure across master meta.json files.
+
+Verifies:
+  1. Each cross_critique entry has target_master, position, citation
+  2. target_master is a real master (not self, not meta-skill, exists)
+  3. citation is a real id in this master's own sources[].id
+  4. position length in [10, 300]
+  5. Coverage: 8 canonical debate pairs are covered bidirectionally
+
+Pure offline structural check.
+
+Usage:
+    python3 scripts/validate-cross-critique.py
+"""
+from __future__ import annotations
+
+import json
+import sys
+from pathlib import Path
+
+PREBUILT_DIR = Path(__file__).resolve().parent.parent / "prebuilt"
+
+META_SKILL_SLUGS = {"curriculum", "debate", "compare-masters"}
+
+REQUIRED_PAIRS = [
+    ("huineng", "yinguang"),
+    ("kumarajiva", "xuanzang"),
+    ("huineng", "zhiyi"),
+    ("tsongkhapa", "huineng"),
+    ("ajahn-chah", "mahasi-sayadaw"),
+    ("atisha", "huineng"),
+    ("ouyi", "yinguang"),
+    ("ouyi", "tsongkhapa"),
+]
+
+POSITION_MIN = 10
+POSITION_MAX = 300
+
+
+def _load(meta_path: Path) -> dict:
+    try:
+        return json.loads(meta_path.read_text(encoding="utf-8"))
+    except json.JSONDecodeError:
+        return {}
+
+
+def collect_master_slugs(prebuilt: Path) -> set[str]:
+    return {p.parent.name.removeprefix("master-")
+            for p in prebuilt.glob("master-*/meta.json")}
+
+
+def collect_sources_by_slug(prebuilt: Path) -> dict[str, set[str]]:
+    out: dict[str, set[str]] = {}
+    for meta_path in prebuilt.glob("master-*/meta.json"):
+        slug = meta_path.parent.name.removeprefix("master-")
+        ids = set()
+        for s in _load(meta_path).get("sources", []):
+            sid = s.get("id")
+            if sid:
+                ids.add(sid)
+        out[slug] = ids
+    return out
+
+
+def collect_critique_pairs(prebuilt: Path) -> set[tuple[str, str]]:
+    pairs: set[tuple[str, str]] = set()
+    for meta_path in prebuilt.glob("master-*/meta.json"):
+        src = meta_path.parent.name.removeprefix("master-")
+        for e in _load(meta_path).get("cross_critique", []) or []:
+            tgt = e.get("target_master")
+            if isinstance(tgt, str):
+                pairs.add((src, tgt))
+    return pairs
+
+
+def validate(prebuilt: Path, *, check_coverage: bool = True) -> list[str]:
+    errors: list[str] = []
+    known_slugs = collect_master_slugs(prebuilt)
+    sources_by_slug = collect_sources_by_slug(prebuilt)
+
+    for meta_path in sorted(prebuilt.glob("master-*/meta.json")):
+        slug = meta_path.parent.name.removeprefix("master-")
+        data = _load(meta_path)
+        cc = data.get("cross_critique")
+        if cc is None:
+            continue
+        if not isinstance(cc, list):
+            errors.append(f"{slug}: cross_critique must be list, got {type(cc).__name__}")
+            continue
+        for i, entry in enumerate(cc):
+            prefix = f"{slug}#{i}"
+            if not isinstance(entry, dict):
+                errors.append(f"{prefix}: entry must be object")
+                continue
+            for k in ("target_master", "position", "citation"):
+                v = entry.get(k)
+                if not v or not isinstance(v, str):
+                    errors.append(f"{prefix}: missing or empty {k}")
+            tm = entry.get("target_master") or ""
+            if tm == slug:
+                errors.append(f"{prefix}: cannot target self")
+            elif tm in META_SKILL_SLUGS:
+                errors.append(f"{prefix}: cannot target meta-skill '{tm}'")
+            elif tm and tm not in known_slugs:
+                errors.append(f"{prefix}: target_master '{tm}' not a known master")
+            cit = entry.get("citation") or ""
+            if cit and cit not in sources_by_slug.get(slug, set()):
+                errors.append(f"{prefix}: citation '{cit}' not in {slug}'s sources[].id")
+            pos = entry.get("position") or ""
+            if pos and not (POSITION_MIN <= len(pos) <= POSITION_MAX):
+                errors.append(f"{prefix}: position length {len(pos)} out of [{POSITION_MIN}, {POSITION_MAX}]")
+
+    if check_coverage:
+        pairs = collect_critique_pairs(prebuilt)
+        for a, b in REQUIRED_PAIRS:
+            if (a, b) not in pairs:
+                errors.append(f"missing critique: {a} → {b}")
+            if (b, a) not in pairs:
+                errors.append(f"missing critique: {b} → {a}")
+
+    return errors
+
+
+def main() -> int:
+    errors = validate(PREBUILT_DIR)
+    if errors:
+        print(f"{len(errors)} cross_critique error(s):")
+        for e in errors:
+            print(f"  ERROR: {e}")
+        return 1
+    print("cross_critique OK")
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())

package/scripts/validate-curriculum-sources.py

@@ -0,0 +1,111 @@
+#!/usr/bin/env python3
+"""Cross-check master-curriculum references against real master metadata.
+
+Verifies:
+  1. Every CBETA T/X number, Toh number, and compiled-teaching id mentioned
+     in prebuilt/master-curriculum/references/*.md appears in the union of
+     all prebuilt/master-*/meta.json `sources[].id`.
+  2. Every /master-<slug> reference points to an existing prebuilt/master-<slug>/
+     directory (self-references to /master-curriculum, /master-debate,
+     /compare-masters are ignored).
+
+Pure offline structural check — no API calls.
+
+Usage:
+    python scripts/validate-curriculum-sources.py
+"""
+from __future__ import annotations
+
+import json
+import re
+import sys
+from pathlib import Path
+
+PREBUILT_DIR = Path(__file__).resolve().parent.parent / "prebuilt"
+
+# Citation patterns
+_T_NUM = re.compile(r"T\d+n\d+[A-Za-z]?")
+_X_NUM = re.compile(r"X\d+n\d+[A-Za-z]?")
+_TOH = re.compile(r"Toh[\s:]\d+[A-Za-z\-]*")
+# Compiled teaching: prefix:Title (e.g. AjahnChah:FoodForTheHeart, Mahasi:Manual)
+_COMPILED = re.compile(r"\b[A-Z][A-Za-z]+:[A-Za-z][A-Za-z0-9\-]+\b")
+# Master slug (kebab-case)
+_SLUG = re.compile(r"/master-([a-z][a-z0-9\-]*)")
+
+# Skills that look like /master-<slug> but are meta-skills, not masters
+META_SKILL_SLUGS = {"curriculum", "debate"}
+
+
+def extract_citations(text: str) -> set[str]:
+    out: set[str] = set()
+    out.update(_T_NUM.findall(text))
+    out.update(_X_NUM.findall(text))
+    out.update(_TOH.findall(text))
+    out.update(_COMPILED.findall(text))
+    return out
+
+
+def extract_master_slugs(text: str) -> set[str]:
+    return {m for m in _SLUG.findall(text) if m not in META_SKILL_SLUGS}
+
+
+def collect_known_citations(prebuilt: Path) -> set[str]:
+    """Union of all `sources[].id` across every prebuilt/master-*/meta.json."""
+    known: set[str] = set()
+    for meta_path in prebuilt.glob("master-*/meta.json"):
+        try:
+            data = json.loads(meta_path.read_text(encoding="utf-8"))
+        except json.JSONDecodeError:
+            continue
+        for src in data.get("sources", []):
+            sid = src.get("id")
+            if sid:
+                known.add(sid)
+    return known
+
+
+def collect_known_slugs(prebuilt: Path) -> set[str]:
+    """All real master slugs (prebuilt/master-<slug>/ that have meta.json)."""
+    return {
+        p.parent.name.removeprefix("master-")
+        for p in prebuilt.glob("master-*/meta.json")
+    }
+
+
+def validate(prebuilt: Path) -> list[str]:
+    errors: list[str] = []
+    refs_dir = prebuilt / "master-curriculum" / "references"
+    if not refs_dir.exists():
+        return [f"references dir not found: {refs_dir}"]
+
+    known_citations = collect_known_citations(prebuilt)
+    known_slugs = collect_known_slugs(prebuilt)
+
+    for ref in sorted(refs_dir.glob("*.md")):
+        text = ref.read_text(encoding="utf-8")
+        for cit in extract_citations(text):
+            if cit not in known_citations:
+                errors.append(
+                    f"{ref.name}: citation '{cit}' not found in any master meta.json"
+                )
+        for slug in extract_master_slugs(text):
+            if slug not in known_slugs:
+                errors.append(
+                    f"{ref.name}: /master-{slug} refers to non-existent master"
+                )
+    return errors
+
+
+def main() -> int:
+    errors = validate(PREBUILT_DIR)
+    if errors:
+        print(f"{len(errors)} curriculum source error(s):")
+        for e in errors:
+            print(f"  ERROR: {e}")
+        return 1
+    print("curriculum sources OK")
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())

package/scripts/validate-fidelity.py

@@ -24,6 +24,9 @@ VALID_BOUNDARIES = {
     "no_fabricated_dialogue",
     "no_esoteric_instruction",
     "no_attainment_judgment",
+    "no_winner_judgment",
+    "no_strawman",
+    "no_fabricated_curriculum",
 }
 VALID_PRESSURES = {
     "citation_bypass",
@@ -73,6 +76,11 @@ def validate_master(master_dir: Path) -> list[str]:
                 "must_select_masters",
                 "must_have_sections",
                 "must_cite_per_master",
+                "must_select_pair",
+                "must_have_rounds",
+                "must_cite_per_round",
+                "must_cite_only_existing_sources",
+                "must_recommend_existing_master",
             ]
         )
         if not has_assertion:
@@ -103,7 +111,14 @@ def validate_master(master_dir: Path) -> list[str]:
                 errors.append(f"{master_dir.name}:{i}: pressure test missing 'pressure' field")
 
         # List fields must be lists
-        for field in ["must_cite", "must_mention", "must_not_contain", "must_not_contain_first_turn"]:
+        for field in [
+            "must_cite",
+            "must_mention",
+            "must_not_contain",
+            "must_not_contain_first_turn",
+            "must_select_pair",
+            "must_have_rounds",
+        ]:
             if field in test and not isinstance(test[field], list):
                 errors.append(f"{master_dir.name}:{i}: '{field}' must be a list")