maestro-flow 0.5.31 → 0.5.33

package/.agents/skills/team-perf-opt/SKILL.md

@@ -0,0 +1,177 @@
+---
+name: team-perf-opt
+description: Unified team skill for performance optimization. Coordinator orchestrates pipeline, workers are team-worker agents. Supports single/fan-out/independent parallel modes. Triggers on "team perf-opt".
+allowed-tools: delegate_subagent, create_task, list_tasks, get_task, update_task, create_team, delete_team, send_message, ask_user, read_file, write_file, edit_file, shell, find_files, search, mcp__maestro__team_msg
+---
+<!-- Open-standard mirror generated by scripts/build-agents-standard.mjs — do not edit; re-run after editing .claude/ source. -->
+
+
+# Team Performance Optimization
+
+Profile application performance, identify bottlenecks, design optimization strategies, implement changes, benchmark improvements, and review code quality.
+
+## Architecture
+
+```
+invoke_skill(skill="team-perf-opt", args="<task-description>")
+                    |
+         SKILL.md (this file) = Router
+                    |
+     +--------------+--------------+
+     |                             |
+  no --role flag              --role <name>
+     |                             |
+  Coordinator                  Worker
+  roles/coordinator/role.md    roles/<name>/role.md
+     |
+     +-- analyze -> dispatch -> spawn workers -> STOP
+                                    |
+                    +-------+-------+-------+-------+-------+
+                    v       v       v       v       v
+                 [profiler] [strategist] [optimizer] [benchmarker] [reviewer]
+                 (team-worker agents)
+
+Pipeline (Single mode):
+  PROFILE-001 -> STRATEGY-001 -> IMPL-001 -> BENCH-001 + REVIEW-001 (fix cycle)
+
+Pipeline (Fan-out mode):
+  PROFILE-001 -> STRATEGY-001 -> [IMPL-B01..N](parallel) -> BENCH+REVIEW per branch
+
+Pipeline (Independent mode):
+  [Pipeline A: PROFILE-A->STRATEGY-A->IMPL-A->BENCH-A+REVIEW-A]
+  [Pipeline B: PROFILE-B->STRATEGY-B->IMPL-B->BENCH-B+REVIEW-B] (parallel)
+```
+
+## Role Registry
+
+| Role | Path | Prefix | Inner Loop |
+|------|------|--------|------------|
+| coordinator | [roles/coordinator/role.md](roles/coordinator/role.md) | — | — |
+| profiler | [roles/profiler/role.md](roles/profiler/role.md) | PROFILE-* | false |
+| strategist | [roles/strategist/role.md](roles/strategist/role.md) | STRATEGY-* | false |
+| optimizer | [roles/optimizer/role.md](roles/optimizer/role.md) | IMPL-*, FIX-* | true |
+| benchmarker | [roles/benchmarker/role.md](roles/benchmarker/role.md) | BENCH-* | false |
+| reviewer | [roles/reviewer/role.md](roles/reviewer/role.md) | REVIEW-*, QUALITY-* | false |
+
+
+## Pre-load (coordinator, before dispatch)
+
+1. **Codebase docs**: If `.workflow/codebase/ARCHITECTURE.md` exists, read for module boundaries
+2. **Specs (coding)**: `maestro spec load --category coding` — load coding constraints as shared context
+3. **Wiki knowledge**: `maestro search "performance optimization profiling" --json` — top 5 entries as prior context
+4. All optional — proceed without if unavailable
+## Role Router
+
+Parse `$ARGUMENTS`:
+- Has `--role <name>` → Read `roles/<name>/role.md`, execute Phase 2-4
+- No `--role` → `@roles/coordinator/role.md`, execute entry router
+
+## Shared Constants
+
+- **Session prefix**: `PERF-OPT`
+- **Session path**: `.workflow/.team/PERF-OPT-<slug>-<date>/`
+- **Team name**: `perf-opt`
+- **CLI tools**: `maestro delegate --mode analysis` (read-only), `maestro delegate --mode write` (modifications)
+- **Message bus**: `mcp__maestro__team_msg(session_id=<session-id>, ...)`
+
+## Worker Spawn Template
+
+Coordinator spawns workers using this template:
+
+```
+delegate_subagent({
+  subagent_type: "team-worker",
+  description: "Spawn <role> worker",
+  team_name: "perf-opt",
+  name: "<role>",
+  run_in_background: true,
+  prompt: `## Role Assignment
+role: <role>
+role_spec: <skill_root>/roles/<role>/role.md
+session: <session-folder>
+session_id: <session-id>
+team_name: perf-opt
+requirement: <task-description>
+inner_loop: <true|false>
+
+## Progress Milestones
+session_id: <session-id>
+Report progress via team_msg at natural phase boundaries (context loaded -> core work done -> verification).
+Report blockers immediately via team_msg type="blocker".
+Report completion via team_msg type="task_complete" after final send_message.
+
+Read role_spec file (@<skill_root>/roles/<role>/role.md) to load Phase 2-4 domain instructions.
+Execute built-in Phase 1 (task discovery) -> role Phase 2-4 -> built-in Phase 5 (report).`
+})
+```
+
+**Inner Loop roles** (optimizer): Set `inner_loop` dynamically — `true` for single mode, `false` for fan-out/independent (parallel branches).
+**Single-task roles** (profiler, strategist, benchmarker, reviewer): Set `inner_loop: false`.
+
+## User Commands
+
+| Command | Action |
+|---------|--------|
+| `check` / `status` | Output execution status graph (branch-grouped), no advancement |
+| `resume` / `continue` | Check worker states, advance next step |
+| `revise <TASK-ID> [feedback]` | Create revision task + cascade downstream (scoped to branch) |
+| `feedback <text>` | Analyze feedback impact, create targeted revision chain |
+| `recheck` | Re-run quality check |
+| `improve [dimension]` | Auto-improve weakest dimension |
+
+## Session Directory
+
+```
+.workflow/.team/PERF-OPT-<slug>-<date>/
++-- session.json                    # Session metadata + status + parallel_mode
++-- artifacts/
+|   +-- baseline-metrics.json       # Profiler: before-optimization metrics
+|   +-- bottleneck-report.md        # Profiler: ranked bottleneck findings
+|   +-- optimization-plan.md        # Strategist: prioritized optimization plan
+|   +-- benchmark-results.json      # Benchmarker: after-optimization metrics
+|   +-- review-report.md            # Reviewer: code review findings
+|   +-- branches/B01/...            # Fan-out branch artifacts
+|   +-- pipelines/A/...             # Independent pipeline artifacts
++-- explorations/                   # Shared explore cache
++-- wisdom/patterns.md              # Discovered patterns and conventions
++-- discussions/                    # Discussion records
++-- .msg/messages.jsonl             # Team message bus
++-- .msg/meta.json                  # Session metadata
+```
+
+## Completion Action
+
+When the pipeline completes:
+
+```
+ask_user({
+  questions: [{
+    question: "Team pipeline complete. What would you like to do?",
+    header: "Completion",
+    multiSelect: false,
+    options: [
+      { label: "Archive & Clean (Recommended)", description: "Archive session, clean up tasks and team resources" },
+      { label: "Keep Active", description: "Keep session active for follow-up work or inspection" },
+      { label: "Export Results", description: "Export deliverables to a specified location, then clean" }
+    ]
+  }]
+})
+```
+
+## Specs Reference
+
+- [specs/pipelines.md](specs/pipelines.md) — Pipeline definitions and task registry
+- [specs/team-config.json](specs/team-config.json) — Team configuration
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| Unknown --role value | Error with role registry list |
+| Role file not found | Error with expected path (roles/{name}/role.md) |
+| Profiling tool not available | Fallback to static analysis methods |
+| Benchmark regression detected | Auto-create FIX task with regression details |
+| Review-fix cycle exceeds 3 iterations | Escalate to user |
+| One branch IMPL fails | Mark that branch failed, other branches continue |
+| Fast-advance conflict | Coordinator reconciles on next callback |
+| Completion action fails | Default to Keep Active |

package/.agents/skills/team-perf-opt/roles/benchmarker/role.md

@@ -0,0 +1,91 @@
+---
+role: benchmarker
+prefix: BENCH
+inner_loop: false
+message_types:
+  success: bench_complete
+  error: error
+  fix: fix_required
+---
+<!-- Open-standard mirror generated by scripts/build-agents-standard.mjs — do not edit; re-run after editing .claude/ source. -->
+
+
+# Performance Benchmarker
+
+Run benchmarks comparing before/after optimization metrics. Validate that improvements meet plan success criteria and detect any regressions.
+
+## Phase 2: Environment & Baseline Loading
+
+| Input | Source | Required |
+|-------|--------|----------|
+| Baseline metrics | <session>/artifacts/baseline-metrics.json (shared) | Yes |
+| Optimization plan / detail | Varies by mode (see below) | Yes |
+| .msg/meta.json | <session>/.msg/meta.json | Yes |
+
+1. Extract session path from task description
+2. **Detect branch/pipeline context** from task description:
+
+| Task Description Field | Value | Context |
+|----------------------|-------|---------|
+| `BranchId: B{NN}` | Present | Fan-out branch -- benchmark only this branch's metrics |
+| `PipelineId: {P}` | Present | Independent pipeline -- use pipeline-scoped baseline |
+| Neither present | - | Single mode -- full benchmark |
+
+3. **Load baseline metrics**:
+   - Single / Fan-out: Read `<session>/artifacts/baseline-metrics.json` (shared baseline)
+   - Independent: Read `<session>/artifacts/pipelines/{P}/baseline-metrics.json`
+
+4. **Load optimization context**:
+   - Single: Read `<session>/artifacts/optimization-plan.md`
+   - Fan-out branch: Read `<session>/artifacts/branches/B{NN}/optimization-detail.md`
+   - Independent: Read `<session>/artifacts/pipelines/{P}/optimization-plan.md`
+
+5. Load .msg/meta.json for project type and optimization scope
+6. Detect available benchmark tools from project:
+
+| Signal | Benchmark Tool | Method |
+|--------|---------------|--------|
+| package.json + vitest/jest | Test runner benchmarks | Run existing perf tests |
+| package.json + webpack/vite | Bundle analysis | Compare build output sizes |
+| Cargo.toml + criterion | Rust benchmarks | cargo bench |
+| go.mod | Go benchmarks | go test -bench |
+| Makefile with bench target | Custom benchmarks | make bench |
+| No tooling detected | Manual measurement | Timed execution via Bash |
+
+7. Get changed files scope from shared-memory (optimizer namespace, scoped by branch/pipeline)
+
+## Phase 3: Benchmark Execution
+
+Run benchmarks matching detected project type:
+
+**Frontend benchmarks**: Compare bundle size, render performance, dependency weight changes.
+
+**Backend benchmarks**: Measure endpoint response times, memory usage under load, database query improvements.
+
+**CLI / Library benchmarks**: Execution time, memory peak, throughput under sustained load.
+
+**All project types**:
+- Run existing test suite to verify no regressions
+- Collect post-optimization metrics matching baseline format
+- Calculate improvement percentages per metric
+
+**Branch-scoped benchmarking** (fan-out mode):
+- Only benchmark metrics relevant to this branch's optimization
+- Still check for regressions across all metrics
+
+## Phase 4: Result Analysis
+
+Compare against baseline and plan criteria:
+
+| Metric | Threshold | Verdict |
+|--------|-----------|---------|
+| Target improvement vs baseline | Meets plan success criteria | PASS |
+| No regression in unrelated metrics | < 5% degradation allowed | PASS |
+| All plan success criteria met | Every criterion satisfied | PASS |
+| Improvement below target | > 50% of target achieved | WARN |
+| Regression detected | Any unrelated metric degrades > 5% | FAIL -> fix_required |
+| Plan criteria not met | Any criterion not satisfied | FAIL -> fix_required |
+
+1. Write benchmark results to output path (scoped by branch/pipeline/single)
+2. Update `<session>/.msg/meta.json` under scoped namespace
+3. If verdict is FAIL, include detailed feedback in message for FIX task creation

package/.agents/skills/team-perf-opt/roles/coordinator/commands/analyze.md

@@ -0,0 +1,61 @@
+# Analyze Task - Performance Optimization
+
+Parse optimization request -> detect parallel mode -> determine scope -> design pipeline structure.
+
+**CONSTRAINT**: Text-level analysis only. NO source code reading, NO codebase exploration.
+
+## Signal Detection
+
+### Parallel Mode Detection
+
+| Flag | Value | Pipeline Shape |
+|------|-------|----------------|
+| `--parallel-mode=single` | explicit | Single linear pipeline |
+| `--parallel-mode=fan-out` | explicit | Shared profile+strategy, N parallel IMPL branches |
+| `--parallel-mode=independent` | explicit | M fully independent pipelines |
+| `--parallel-mode=auto` or absent | default | Auto-detect from bottleneck count at CP-2.5 |
+| `auto` with count <= 2 | auto-resolved | single mode |
+| `auto` with count >= 3 | auto-resolved | fan-out mode |
+
+### Scope Detection
+
+| Signal | Target |
+|--------|--------|
+| Specific file/module mentioned | Scoped optimization |
+| "slow", "performance", generic | Full application profiling |
+| Specific metric mentioned (FCP, memory, startup) | Targeted metric optimization |
+| Multiple quoted targets (independent mode) | Per-target scoped optimization |
+
+### Optimization Keywords
+
+| Keywords | Capability |
+|----------|------------|
+| profile, bottleneck, slow, benchmark | profiler |
+| optimize, improve, reduce, speed | optimizer |
+| strategy, plan, prioritize | strategist |
+| verify, test, validate | benchmarker |
+| review, audit, quality | reviewer |
+
+## Output
+
+Coordinator state from this command (used by dispatch.md):
+
+```json
+{
+  "parallel_mode": "<auto|single|fan-out|independent>",
+  "max_branches": 5,
+  "optimization_targets": ["<target1>", "<target2>"],
+  "independent_targets": [],
+  "scope": "<specific|full-app|targeted>",
+  "target_metrics": ["<metric1>", "<metric2>"]
+}
+```
+
+## Pipeline Structure by Mode
+
+| Mode | Stages |
+|------|--------|
+| single | PROFILE-001 -> STRATEGY-001 -> IMPL-001 -> BENCH-001 + REVIEW-001 |
+| fan-out | PROFILE-001 -> STRATEGY-001 -> [IMPL-B01..N in parallel] -> BENCH+REVIEW per branch |
+| independent | N complete pipelines (PROFILE+STRATEGY+IMPL+BENCH+REVIEW) in parallel |
+| auto | Decided at CP-2.5 after STRATEGY-001 completes based on bottleneck count |