lighthouse 12.6.1 → 12.7.0-dev.20250627

package/core/lib/deprecations-strings.d.ts

@@ -1,6 +1,7 @@
 export namespace UIStrings {
     let AuthorizationCoveredByWildcard: string;
     let CanRequestURLHTTPContainingNewline: string;
+    let CharsetAutoDetectionISO2022JP: string;
     let ChromeLoadTimesConnectionInfo: string;
     let ChromeLoadTimesFirstPaintAfterLoadTime: string;
     let ChromeLoadTimesWasAlternateProtocolAvailable: string;
@@ -11,7 +12,6 @@ export namespace UIStrings {
     let CSSSelectorInternalMediaControlsOverlayCastButton: string;
     let CSSValueAppearanceSliderVertical: string;
     let DataUrlInSvgUse: string;
-    let DOMMutationEvents: string;
     let GeolocationInsecureOrigin: string;
     let GeolocationInsecureOriginDeprecatedNotRemoved: string;
     let GetUserMediaInsecureOrigin: string;
@@ -54,6 +54,7 @@ export namespace UIStrings {
     let TextToSpeech_DisallowedByAutoplay: string;
     let UnloadHandler: string;
     let V8SharedArrayBufferConstructedInExtensionWithoutIsolation: string;
+    let WebGPUAdapterIsFallbackAdapter: string;
     let XHRJSONEncodingDetection: string;
     let XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload: string;
 }
@@ -76,20 +77,25 @@ export namespace DEPRECATIONS_METADATA {
         export { chromeStatusFeature_2 as chromeStatusFeature };
     }
     export { CanRequestURLHTTPContainingNewline_1 as CanRequestURLHTTPContainingNewline };
-    export namespace ChromeLoadTimesConnectionInfo_1 {
+    export namespace CharsetAutoDetectionISO2022JP_1 {
         let chromeStatusFeature_3: number;
         export { chromeStatusFeature_3 as chromeStatusFeature };
     }
-    export { ChromeLoadTimesConnectionInfo_1 as ChromeLoadTimesConnectionInfo };
-    export namespace ChromeLoadTimesFirstPaintAfterLoadTime_1 {
+    export { CharsetAutoDetectionISO2022JP_1 as CharsetAutoDetectionISO2022JP };
+    export namespace ChromeLoadTimesConnectionInfo_1 {
         let chromeStatusFeature_4: number;
         export { chromeStatusFeature_4 as chromeStatusFeature };
     }
-    export { ChromeLoadTimesFirstPaintAfterLoadTime_1 as ChromeLoadTimesFirstPaintAfterLoadTime };
-    export namespace ChromeLoadTimesWasAlternateProtocolAvailable_1 {
+    export { ChromeLoadTimesConnectionInfo_1 as ChromeLoadTimesConnectionInfo };
+    export namespace ChromeLoadTimesFirstPaintAfterLoadTime_1 {
         let chromeStatusFeature_5: number;
         export { chromeStatusFeature_5 as chromeStatusFeature };
     }
+    export { ChromeLoadTimesFirstPaintAfterLoadTime_1 as ChromeLoadTimesFirstPaintAfterLoadTime };
+    export namespace ChromeLoadTimesWasAlternateProtocolAvailable_1 {
+        let chromeStatusFeature_6: number;
+        export { chromeStatusFeature_6 as chromeStatusFeature };
+    }
     export { ChromeLoadTimesWasAlternateProtocolAvailable_1 as ChromeLoadTimesWasAlternateProtocolAvailable };
     export namespace CookieWithTruncatingChar_1 {
         let milestone_1: number;
@@ -101,25 +107,18 @@ export namespace DEPRECATIONS_METADATA {
         export { milestone_2 as milestone };
     }
     export { CrossOriginAccessBasedOnDocumentDomain_1 as CrossOriginAccessBasedOnDocumentDomain };
-    export namespace DOMMutationEvents_1 {
-        let chromeStatusFeature_6: number;
-        export { chromeStatusFeature_6 as chromeStatusFeature };
-        let milestone_3: number;
-        export { milestone_3 as milestone };
-    }
-    export { DOMMutationEvents_1 as DOMMutationEvents };
     export namespace DataUrlInSvgUse_1 {
         let chromeStatusFeature_7: number;
         export { chromeStatusFeature_7 as chromeStatusFeature };
-        let milestone_4: number;
-        export { milestone_4 as milestone };
+        let milestone_3: number;
+        export { milestone_3 as milestone };
     }
     export { DataUrlInSvgUse_1 as DataUrlInSvgUse };
     export namespace H1UserAgentFontSizeInSection_1 {
         let chromeStatusFeature_8: number;
         export { chromeStatusFeature_8 as chromeStatusFeature };
-        let milestone_5: number;
-        export { milestone_5 as milestone };
+        let milestone_4: number;
+        export { milestone_4 as milestone };
     }
     export { H1UserAgentFontSizeInSection_1 as H1UserAgentFontSizeInSection };
     export namespace IdentityDigitalCredentials_1 {
@@ -135,13 +134,13 @@ export namespace DEPRECATIONS_METADATA {
     export namespace InsecurePrivateNetworkSubresourceRequest_1 {
         let chromeStatusFeature_11: number;
         export { chromeStatusFeature_11 as chromeStatusFeature };
-        let milestone_6: number;
-        export { milestone_6 as milestone };
+        let milestone_5: number;
+        export { milestone_5 as milestone };
     }
     export { InsecurePrivateNetworkSubresourceRequest_1 as InsecurePrivateNetworkSubresourceRequest };
     export namespace LocalCSSFileExtensionRejected_1 {
-        let milestone_7: number;
-        export { milestone_7 as milestone };
+        let milestone_6: number;
+        export { milestone_6 as milestone };
     }
     export { LocalCSSFileExtensionRejected_1 as LocalCSSFileExtensionRejected };
     export namespace MediaSourceAbortRemove_1 {
@@ -157,8 +156,8 @@ export namespace DEPRECATIONS_METADATA {
     export namespace NoSysexWebMIDIWithoutPermission_1 {
         let chromeStatusFeature_14: number;
         export { chromeStatusFeature_14 as chromeStatusFeature };
-        let milestone_8: number;
-        export { milestone_8 as milestone };
+        let milestone_7: number;
+        export { milestone_7 as milestone };
     }
     export { NoSysexWebMIDIWithoutPermission_1 as NoSysexWebMIDIWithoutPermission };
     export namespace NotificationPermissionRequestedIframe_1 {
@@ -167,20 +166,20 @@ export namespace DEPRECATIONS_METADATA {
     }
     export { NotificationPermissionRequestedIframe_1 as NotificationPermissionRequestedIframe };
     export namespace ObsoleteCreateImageBitmapImageOrientationNone_1 {
-        let milestone_9: number;
-        export { milestone_9 as milestone };
+        let milestone_8: number;
+        export { milestone_8 as milestone };
     }
     export { ObsoleteCreateImageBitmapImageOrientationNone_1 as ObsoleteCreateImageBitmapImageOrientationNone };
     export namespace ObsoleteWebRtcCipherSuite_1 {
-        let milestone_10: number;
-        export { milestone_10 as milestone };
+        let milestone_9: number;
+        export { milestone_9 as milestone };
     }
     export { ObsoleteWebRtcCipherSuite_1 as ObsoleteWebRtcCipherSuite };
     export namespace OverflowVisibleOnReplacedElement_1 {
         let chromeStatusFeature_16: number;
         export { chromeStatusFeature_16 as chromeStatusFeature };
-        let milestone_11: number;
-        export { milestone_11 as milestone };
+        let milestone_10: number;
+        export { milestone_10 as milestone };
     }
     export { OverflowVisibleOnReplacedElement_1 as OverflowVisibleOnReplacedElement };
     export namespace PaymentInstruments_1 {
@@ -196,25 +195,25 @@ export namespace DEPRECATIONS_METADATA {
     export namespace PersistentQuotaType_1 {
         let chromeStatusFeature_19: number;
         export { chromeStatusFeature_19 as chromeStatusFeature };
-        let milestone_12: number;
-        export { milestone_12 as milestone };
+        let milestone_11: number;
+        export { milestone_11 as milestone };
     }
     export { PersistentQuotaType_1 as PersistentQuotaType };
     export namespace RTCConstraintEnableDtlsSrtpFalse_1 {
-        let milestone_13: number;
-        export { milestone_13 as milestone };
+        let milestone_12: number;
+        export { milestone_12 as milestone };
     }
     export { RTCConstraintEnableDtlsSrtpFalse_1 as RTCConstraintEnableDtlsSrtpFalse };
     export namespace RTCConstraintEnableDtlsSrtpTrue_1 {
-        let milestone_14: number;
-        export { milestone_14 as milestone };
+        let milestone_13: number;
+        export { milestone_13 as milestone };
     }
     export { RTCConstraintEnableDtlsSrtpTrue_1 as RTCConstraintEnableDtlsSrtpTrue };
     export namespace RTCPeerConnectionGetStatsLegacyNonCompliant_1 {
         let chromeStatusFeature_20: number;
         export { chromeStatusFeature_20 as chromeStatusFeature };
-        let milestone_15: number;
-        export { milestone_15 as milestone };
+        let milestone_14: number;
+        export { milestone_14 as milestone };
     }
     export { RTCPeerConnectionGetStatsLegacyNonCompliant_1 as RTCPeerConnectionGetStatsLegacyNonCompliant };
     export namespace RequestedSubresourceWithEmbeddedCredentials_1 {
@@ -225,20 +224,20 @@ export namespace DEPRECATIONS_METADATA {
     export namespace RtcpMuxPolicyNegotiate_1 {
         let chromeStatusFeature_22: number;
         export { chromeStatusFeature_22 as chromeStatusFeature };
-        let milestone_16: number;
-        export { milestone_16 as milestone };
+        let milestone_15: number;
+        export { milestone_15 as milestone };
     }
     export { RtcpMuxPolicyNegotiate_1 as RtcpMuxPolicyNegotiate };
     export namespace SharedArrayBufferConstructedWithoutIsolation_1 {
-        let milestone_17: number;
-        export { milestone_17 as milestone };
+        let milestone_16: number;
+        export { milestone_16 as milestone };
     }
     export { SharedArrayBufferConstructedWithoutIsolation_1 as SharedArrayBufferConstructedWithoutIsolation };
     export namespace TextToSpeech_DisallowedByAutoplay_1 {
         let chromeStatusFeature_23: number;
         export { chromeStatusFeature_23 as chromeStatusFeature };
-        let milestone_18: number;
-        export { milestone_18 as milestone };
+        let milestone_17: number;
+        export { milestone_17 as milestone };
     }
     export { TextToSpeech_DisallowedByAutoplay_1 as TextToSpeech_DisallowedByAutoplay };
     export namespace UnloadHandler_1 {
@@ -247,13 +246,18 @@ export namespace DEPRECATIONS_METADATA {
     }
     export { UnloadHandler_1 as UnloadHandler };
     export namespace V8SharedArrayBufferConstructedInExtensionWithoutIsolation_1 {
-        let milestone_19: number;
-        export { milestone_19 as milestone };
+        let milestone_18: number;
+        export { milestone_18 as milestone };
     }
     export { V8SharedArrayBufferConstructedInExtensionWithoutIsolation_1 as V8SharedArrayBufferConstructedInExtensionWithoutIsolation };
+    export namespace WebGPUAdapterIsFallbackAdapter_1 {
+        let chromeStatusFeature_25: number;
+        export { chromeStatusFeature_25 as chromeStatusFeature };
+    }
+    export { WebGPUAdapterIsFallbackAdapter_1 as WebGPUAdapterIsFallbackAdapter };
     export namespace XHRJSONEncodingDetection_1 {
-        let milestone_20: number;
-        export { milestone_20 as milestone };
+        let milestone_19: number;
+        export { milestone_19 as milestone };
     }
     export { XHRJSONEncodingDetection_1 as XHRJSONEncodingDetection };
 }

package/core/lib/deprecations-strings.js

@@ -16,6 +16,10 @@ export const UIStrings = {
    * @description This warning occurs when a page attempts to request a resource whose URL contained both a newline character (`\n` or `\r`), and a less-than character (`<`). These resources are blocked.
    */
   CanRequestURLHTTPContainingNewline: "Resource requests whose URLs contained both removed whitespace `(n|r|t)` characters and less-than characters (`<`) are blocked. Please remove newlines and encode less-than characters from places like element attribute values in order to load these resources.",
+  /**
+   * @description Warning displayed to developers that they did not specify character encoding for HTML document, and that auto-detection of specific character set (i.e. ISO-2022-JP) used by the webiste won't be supported in the near futre.
+   */
+  CharsetAutoDetectionISO2022JP: "Auto-detection of ISO-2022-JP character set is deprecated and it will be disabled in the near future. Please specify character set in the Content Type header or by using a meta tag (https://developer.mozilla.org/en-US/docs/Glossary/Character_encoding).",
   /**
    * @description This warning occurs when the website attempts to invoke the deprecated `chrome.loadTimes().connectionInfo` API.
    */
@@ -56,10 +60,6 @@ export const UIStrings = {
    * @description Warning displayed to developers when a data: URL is assigned to SVGUseElement to let them know that the support is deprecated.
    */
   DataUrlInSvgUse: "Support for data: URLs in SVGUseElement is deprecated and it will be removed in the future.",
-  /**
-   * @description Warning displayed to developers when non-standard Mutation Events are used. These are deprecated and will be removed.
-   */
-  DOMMutationEvents: "DOM Mutation Events, including `DOMSubtreeModified`, `DOMNodeInserted`, `DOMNodeRemoved`, `DOMNodeRemovedFromDocument`, `DOMNodeInsertedIntoDocument`, and `DOMCharacterDataModified` are deprecated (https://w3c.github.io/uievents/#legacy-event-types) and will be removed. Please use `MutationObserver` instead.",
   /**
    * @description Warning displayed to developers when the Geolocation API is used from an insecure origin (one that isn't localhost or doesn't use HTTPS) to notify them that this use is no longer supported.
    */
@@ -228,6 +228,10 @@ export const UIStrings = {
    * @description A deprecation warning shown in the DevTools Issues tab. The placeholder is always the noun 'SharedArrayBuffer' which refers to a JavaScript construct. 'Extensions' refers to Chrome extensions. The warning is shown when Chrome Extensions attempt to use 'SharedArrayBuffer's under insecure circumstances.
    */
   V8SharedArrayBufferConstructedInExtensionWithoutIsolation: "Extensions should opt into cross-origin isolation to continue using `SharedArrayBuffer`. See https://developer.chrome.com/docs/extensions/mv3/cross-origin-isolation/.",
+  /**
+   * @description This warning occurs when the website attempts to use the deprecated GPUAdapter `isFallbackAdapter` attribute.
+   */
+  WebGPUAdapterIsFallbackAdapter: "The GPUAdapter `isFallbackAdapter` attribute is deprecated, instead use the GPUAdapterInfo `isFallbackAdapter` attribute.",
   /**
    * @description Warning displayed to developers that they are using `XMLHttpRequest` API in a way that they expect an unsupported character encoding `UTF-16` could be used in the server reply.
    */
@@ -255,6 +259,9 @@ export const DEPRECATIONS_METADATA = {
   "CanRequestURLHTTPContainingNewline": {
     "chromeStatusFeature": 5735596811091968
   },
+  "CharsetAutoDetectionISO2022JP": {
+    "chromeStatusFeature": 6576566521561088
+  },
   "ChromeLoadTimesConnectionInfo": {
     "chromeStatusFeature": 5637885046816768
   },
@@ -270,10 +277,6 @@ export const DEPRECATIONS_METADATA = {
   "CrossOriginAccessBasedOnDocumentDomain": {
     "milestone": 115
   },
-  "DOMMutationEvents": {
-    "chromeStatusFeature": 5083947249172480,
-    "milestone": 127
-  },
   "DataUrlInSvgUse": {
     "chromeStatusFeature": 5128825141198848,
     "milestone": 119
@@ -358,6 +361,9 @@ export const DEPRECATIONS_METADATA = {
   "V8SharedArrayBufferConstructedInExtensionWithoutIsolation": {
     "milestone": 96
   },
+  "WebGPUAdapterIsFallbackAdapter": {
+    "chromeStatusFeature": 4870179714236416
+  },
   "XHRJSONEncodingDetection": {
     "milestone": 93
   }

package/core/lib/i18n/i18n.js

@@ -17,7 +17,6 @@ import {LH_ROOT} from '../../../shared/root.js';
 import {isIcuMessage, formatMessage, DEFAULT_LOCALE} from '../../../shared/localization/format.js';
 import {getModulePath} from '../../../shared/esm-utils.js';
 
-/* eslint-disable max-len */
 const UIStrings = {
   /** Used to show the duration in milliseconds that something lasted. The `{timeInMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 63 ms) */
   ms: '{timeInMs, number, milliseconds}\xa0ms',
@@ -114,7 +113,6 @@ const UIStrings = {
   /** Table item value for the severity of a high impact, or dangerous vulnerability. Part of a ranking scale in the form: low, medium, high. */
   itemSeverityHigh: 'High',
 };
-/* eslint-enable max-len */
 
 /**
  * Look up the best available locale for the requested language through these fall backs:

package/core/lib/lantern-trace-saver.js

@@ -153,7 +153,7 @@ function convertNodeTimingsToTrace(nodeTimings) {
 
     // 0ms requests get super-messed up rendering
     // Use 0.3ms instead so they're still hoverable, https://github.com/GoogleChrome/lighthouse/pull/5350#discussion_r194563201
-    let {startTime, endTime} = timing; // eslint-disable-line prefer-const
+    let {startTime, endTime} = timing;
     if (startTime === endTime) endTime += 0.3;
 
     const requestData = {requestId: requestId.toString(), frame};

package/core/lib/lh-error.js

@@ -214,7 +214,6 @@ class LighthouseError extends Error {
     if (typeof possibleError === 'object' && possibleError !== null) {
       if (possibleError.sentinel === LHERROR_SENTINEL) {
         // Include sentinel in destructuring so it doesn't end up in `properties`.
-        // eslint-disable-next-line no-unused-vars
         const {code, stack, cause, properties} = /** @type {SerializedLighthouseError} */ (possibleError);
         const errorDefinition = LighthouseError.errors[/** @type {keyof typeof ERRORS} */ (code)];
         const lhError = new LighthouseError(errorDefinition, properties, {cause});

package/core/lib/manifest-parser.js

@@ -458,7 +458,6 @@ function parseManifest(string, manifestUrl, documentUrl) {
     };
   }
 
-  /* eslint-disable camelcase */
   const manifest = {
     name: parseName(jsonInput),
     short_name: parseShortName(jsonInput),
@@ -471,7 +470,6 @@ function parseManifest(string, manifestUrl, documentUrl) {
     theme_color: parseThemeColor(jsonInput),
     background_color: parseBackgroundColor(jsonInput),
   };
-  /* eslint-enable camelcase */
 
   /** @type {string|undefined} */
   let manifestUrlWarning;

package/core/lib/minify-devtoolslog.js

@@ -4,8 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/* eslint-disable no-console */
-
 /**
  * @fileoverview Minifies a devtools log by removing noisy header values, eliminating data URIs, etc.
  */

package/core/lib/sentry.d.ts

@@ -17,7 +17,7 @@ export namespace Sentry {
 export type Breadcrumb = import("@sentry/node").Breadcrumb;
 export type NodeClient = import("@sentry/node").NodeClient;
 export type NodeOptions = import("@sentry/node").NodeOptions;
-export type Severity = import("@sentry/node").Severity;
+export type SeverityLevel = import("@sentry/node").SeverityLevel;
 /**
  * When called, replaces noops with actual Sentry implementation.
  * @param {{url: string, flags: LH.CliFlags, config?: LH.Config, environmentData: NodeOptions}} opts

package/core/lib/sentry.js

@@ -11,7 +11,7 @@ import {initializeConfig} from '../config/config.js';
 /** @typedef {import('@sentry/node').Breadcrumb} Breadcrumb */
 /** @typedef {import('@sentry/node').NodeClient} NodeClient */
 /** @typedef {import('@sentry/node').NodeOptions} NodeOptions */
-/** @typedef {import('@sentry/node').Severity} Severity */
+/** @typedef {import('@sentry/node').SeverityLevel} SeverityLevel */
 
 const SENTRY_URL = 'https://a6bb0da87ee048cc9ae2a345fc09ab2e:63a7029f46f74265981b7e005e0f69f8@sentry.io/174697';
 
@@ -26,7 +26,7 @@ const noop = () => { };
  */
 const sentryDelegate = {
   init,
-  /** @type {(message: string, level?: Severity) => void} */
+  /** @type {(message: string, level?: SeverityLevel) => void} */
   captureMessage: noop,
   /** @type {(breadcrumb: Breadcrumb) => void} */
   captureBreadcrumb: noop,

package/core/runner.js

@@ -312,10 +312,8 @@ class Runner {
         if (!isEqual(normalizedGatherSettings[k], normalizedAuditSettings[k])) {
           throw new Error(
             `Cannot change settings between gathering and auditing…
-Difference found at: \`${k}\`
-    ${normalizedGatherSettings[k]}
-vs
-    ${normalizedAuditSettings[k]}`);
+Difference found at: \`${k}\`: ${JSON.stringify(normalizedGatherSettings[k], null, 2)}
+vs: ${JSON.stringify(normalizedAuditSettings[k], null, 2)}`);
         }
       }
 
@@ -451,21 +449,26 @@ vs
    * @return {LH.RawIcu<LH.Result['runtimeError']>|undefined}
    */
   static getArtifactRuntimeError(artifacts) {
+    /** @type {Array<[string, LighthouseError|object]>} */
     const possibleErrorArtifacts = [
-      artifacts.PageLoadError, // Preferentially use `PageLoadError`, if it exists.
-      ...Object.values(artifacts), // Otherwise check amongst all artifacts.
+      ['PageLoadError', artifacts.PageLoadError], // Preferentially use `PageLoadError`, if it exists.
+      ...Object.entries(artifacts), // Otherwise check amongst all artifacts.
     ];
 
-    for (const possibleErrorArtifact of possibleErrorArtifacts) {
+    for (const [artifactKey, possibleErrorArtifact] of possibleErrorArtifacts) {
       const isError = possibleErrorArtifact instanceof LighthouseError;
 
-      // eslint-disable-next-line max-len
       if (isError && possibleErrorArtifact.lhrRuntimeError) {
         const errorMessage = possibleErrorArtifact.friendlyMessage || possibleErrorArtifact.message;
+        // Prefer the stack trace closest to the error.
+        const stack =
+          /** @type {any} */ (possibleErrorArtifact.cause)?.stack ?? possibleErrorArtifact.stack;
 
         return {
           code: possibleErrorArtifact.code,
           message: errorMessage,
+          errorStack: stack,
+          artifactKey,
         };
       }
     }