lighthouse 10.4.0 → 11.0.0

package/core/gather/driver/service-workers.d.ts

@@ -4,13 +4,13 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {Promise<LH.Crdp.ServiceWorker.WorkerVersionUpdatedEvent>}
  */
-export function getServiceWorkerVersions(session: LH.Gatherer.FRProtocolSession): Promise<LH.Crdp.ServiceWorker.WorkerVersionUpdatedEvent>;
+export function getServiceWorkerVersions(session: LH.Gatherer.ProtocolSession): Promise<LH.Crdp.ServiceWorker.WorkerVersionUpdatedEvent>;
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {Promise<LH.Crdp.ServiceWorker.WorkerRegistrationUpdatedEvent>}
  */
-export function getServiceWorkerRegistrations(session: LH.Gatherer.FRProtocolSession): Promise<LH.Crdp.ServiceWorker.WorkerRegistrationUpdatedEvent>;
+export function getServiceWorkerRegistrations(session: LH.Gatherer.ProtocolSession): Promise<LH.Crdp.ServiceWorker.WorkerRegistrationUpdatedEvent>;
 //# sourceMappingURL=service-workers.d.ts.map

package/core/gather/driver/service-workers.js

@@ -5,7 +5,7 @@
  */
 
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {Promise<LH.Crdp.ServiceWorker.WorkerVersionUpdatedEvent>}
  */
 function getServiceWorkerVersions(session) {
@@ -37,7 +37,7 @@ function getServiceWorkerVersions(session) {
 }
 
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {Promise<LH.Crdp.ServiceWorker.WorkerRegistrationUpdatedEvent>}
  */
 function getServiceWorkerRegistrations(session) {

package/core/gather/driver/storage.d.ts

@@ -1,21 +1,21 @@
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {string} url
  * @return {Promise<LH.IcuMessage[]>}
  */
-export function clearDataForOrigin(session: LH.Gatherer.FRProtocolSession, url: string): Promise<LH.IcuMessage[]>;
+export function clearDataForOrigin(session: LH.Gatherer.ProtocolSession, url: string): Promise<LH.IcuMessage[]>;
 /**
  * Clear the network cache on disk and in memory.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {Promise<LH.IcuMessage[]>}
  */
-export function clearBrowserCaches(session: LH.Gatherer.FRProtocolSession): Promise<LH.IcuMessage[]>;
+export function clearBrowserCaches(session: LH.Gatherer.ProtocolSession): Promise<LH.IcuMessage[]>;
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {string} url
  * @return {Promise<LH.IcuMessage | undefined>}
  */
-export function getImportantStorageWarning(session: LH.Gatherer.FRProtocolSession, url: string): Promise<LH.IcuMessage | undefined>;
+export function getImportantStorageWarning(session: LH.Gatherer.ProtocolSession, url: string): Promise<LH.IcuMessage | undefined>;
 export namespace UIStrings {
     const warningData: string;
     const warningCacheTimeout: string;

package/core/gather/driver/storage.js

@@ -34,7 +34,7 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {string} url
  * @return {Promise<LH.IcuMessage[]>}
  */
@@ -82,7 +82,7 @@ async function clearDataForOrigin(session, url) {
 }
 
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {string} url
  * @return {Promise<LH.IcuMessage | undefined>}
  */
@@ -112,7 +112,7 @@ async function getImportantStorageWarning(session, url) {
 
 /**
  * Clear the network cache on disk and in memory.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {Promise<LH.IcuMessage[]>}
  */
 async function clearBrowserCaches(session) {

package/core/gather/driver/target-manager.d.ts

@@ -1,7 +1,7 @@
 export type TargetWithSession = {
     target: LH.Crdp.Target.TargetInfo;
     cdpSession: LH.Puppeteer.CDPSession;
-    session: LH.Gatherer.FRProtocolSession;
+    session: LH.Gatherer.ProtocolSession;
     protocolListener: (event: unknown) => void;
 };
 export type ProtocolEventMap = {
@@ -46,14 +46,14 @@ export class TargetManager extends TargetManager_base {
     _onExecutionContextsCleared(): void;
     /**
      * @param {string} sessionId
-     * @return {LH.Gatherer.FRProtocolSession}
+     * @return {LH.Gatherer.ProtocolSession}
      */
-    _findSession(sessionId: string): LH.Gatherer.FRProtocolSession;
+    _findSession(sessionId: string): LH.Gatherer.ProtocolSession;
     /**
      * Returns the root session.
-     * @return {LH.Gatherer.FRProtocolSession}
+     * @return {LH.Gatherer.ProtocolSession}
      */
-    rootSession(): LH.Gatherer.FRProtocolSession;
+    rootSession(): LH.Gatherer.ProtocolSession;
     mainFrameExecutionContexts(): import("devtools-protocol").Protocol.Runtime.ExecutionContextDescription[];
     /**
      * Returns a listener for all protocol events from session, and augments the
@@ -71,5 +71,6 @@ export class TargetManager extends TargetManager_base {
      */
     disable(): Promise<void>;
 }
+import { ProtocolSession } from '../session.js';
 export {};
 //# sourceMappingURL=target-manager.d.ts.map

package/core/gather/driver/target-manager.js

@@ -19,7 +19,7 @@ import {ProtocolSession} from '../session.js';
  * @typedef {{
  *   target: LH.Crdp.Target.TargetInfo,
  *   cdpSession: LH.Puppeteer.CDPSession,
- *   session: LH.Gatherer.FRProtocolSession,
+ *   session: LH.Gatherer.ProtocolSession,
  *   protocolListener: (event: unknown) => void,
  * }} TargetWithSession
  */
@@ -84,7 +84,7 @@ class TargetManager extends ProtocolEventEmitter {
 
   /**
    * @param {string} sessionId
-   * @return {LH.Gatherer.FRProtocolSession}
+   * @return {LH.Gatherer.ProtocolSession}
    */
   _findSession(sessionId) {
     for (const {session, cdpSession} of this._targetIdToTargets.values()) {
@@ -96,7 +96,7 @@ class TargetManager extends ProtocolEventEmitter {
 
   /**
    * Returns the root session.
-   * @return {LH.Gatherer.FRProtocolSession}
+   * @return {LH.Gatherer.ProtocolSession}
    */
   rootSession() {
     const rootSessionId = this._rootCdpSession.id();

package/core/gather/driver/wait-for-condition.d.ts

@@ -49,35 +49,35 @@ export function waitForNothing(): {
 /**
  * Returns a promise that resolve when a frame has been navigated.
  * Used for detecting that our about:blank reset has been completed.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {CancellableWait<LH.Crdp.Page.FrameNavigatedEvent>}
  */
-export function waitForFrameNavigated(session: LH.Gatherer.FRProtocolSession): CancellableWait<LH.Crdp.Page.FrameNavigatedEvent>;
+export function waitForFrameNavigated(session: LH.Gatherer.ProtocolSession): CancellableWait<LH.Crdp.Page.FrameNavigatedEvent>;
 /**
  * Returns a promise that resolve when a frame has a FCP.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {number} pauseAfterFcpMs
  * @param {number} maxWaitForFcpMs
  * @return {CancellableWait}
  */
-export function waitForFcp(session: LH.Gatherer.FRProtocolSession, pauseAfterFcpMs: number, maxWaitForFcpMs: number): CancellableWait;
+export function waitForFcp(session: LH.Gatherer.ProtocolSession, pauseAfterFcpMs: number, maxWaitForFcpMs: number): CancellableWait;
 /**
  * Return a promise that resolves `pauseAfterLoadMs` after the load event
  * fires and a method to cancel internal listeners and timeout.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {number} pauseAfterLoadMs
  * @return {CancellableWait}
  */
-export function waitForLoadEvent(session: LH.Gatherer.FRProtocolSession, pauseAfterLoadMs: number): CancellableWait;
+export function waitForLoadEvent(session: LH.Gatherer.ProtocolSession, pauseAfterLoadMs: number): CancellableWait;
 /**
  * Returns a promise that resolves when the network has been idle (after DCL) for
  * `networkQuietThresholdMs` ms and a method to cancel internal network listeners/timeout.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {NetworkMonitor} networkMonitor
  * @param {{networkQuietThresholdMs: number, busyEvent: NetworkMonitorEvent, idleEvent: NetworkMonitorEvent, isIdle(recorder: NetworkMonitor): boolean, pretendDCLAlreadyFired?: boolean}} networkQuietOptions
  * @return {CancellableWait}
  */
-export function waitForNetworkIdle(session: LH.Gatherer.FRProtocolSession, networkMonitor: NetworkMonitor, networkQuietOptions: {
+export function waitForNetworkIdle(session: LH.Gatherer.ProtocolSession, networkMonitor: NetworkMonitor, networkQuietOptions: {
     networkQuietThresholdMs: number;
     busyEvent: NetworkMonitorEvent;
     idleEvent: NetworkMonitorEvent;
@@ -86,11 +86,11 @@ export function waitForNetworkIdle(session: LH.Gatherer.FRProtocolSession, netwo
 }): CancellableWait;
 /**
  * Resolves when there have been no long tasks for at least waitForCPUQuiet ms.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {number} waitForCPUQuiet
  * @return {CancellableWait}
  */
-export function waitForCPUIdle(session: LH.Gatherer.FRProtocolSession, waitForCPUQuiet: number): CancellableWait;
+export function waitForCPUIdle(session: LH.Gatherer.ProtocolSession, waitForCPUQuiet: number): CancellableWait;
 /**
  * Returns a promise that resolves when:
  * - All of the following conditions have been met:
@@ -101,16 +101,16 @@ export function waitForCPUIdle(session: LH.Gatherer.FRProtocolSession, waitForCP
  *    - cpuQuietThresholdMs have passed since the last long task after network-2-quiet.
  * - maxWaitForLoadedMs milliseconds have passed.
  * See https://github.com/GoogleChrome/lighthouse/issues/627 for more.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {NetworkMonitor} networkMonitor
  * @param {WaitOptions} options
  * @return {Promise<{timedOut: boolean}>}
  */
-export function waitForFullyLoaded(session: LH.Gatherer.FRProtocolSession, networkMonitor: NetworkMonitor, options: WaitOptions): Promise<{
+export function waitForFullyLoaded(session: LH.Gatherer.ProtocolSession, networkMonitor: NetworkMonitor, options: WaitOptions): Promise<{
     timedOut: boolean;
 }>;
 /**
- * @param {LH.Gatherer.FRTransitionalDriver} driver
+ * @param {LH.Gatherer.Driver} driver
  */
-export function waitForUserToContinue(driver: LH.Gatherer.FRTransitionalDriver): Promise<void>;
+export function waitForUserToContinue(driver: LH.Gatherer.Driver): Promise<void>;
 //# sourceMappingURL=wait-for-condition.d.ts.map

package/core/gather/driver/wait-for-condition.js

@@ -45,7 +45,7 @@ function waitForNothing() {
 /**
  * Returns a promise that resolve when a frame has been navigated.
  * Used for detecting that our about:blank reset has been completed.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {CancellableWait<LH.Crdp.Page.FrameNavigatedEvent>}
  */
 function waitForFrameNavigated(session) {
@@ -68,7 +68,7 @@ function waitForFrameNavigated(session) {
 
 /**
  * Returns a promise that resolve when a frame has a FCP.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {number} pauseAfterFcpMs
  * @param {number} maxWaitForFcpMs
  * @return {CancellableWait}
@@ -119,7 +119,7 @@ function waitForFcp(session, pauseAfterFcpMs, maxWaitForFcpMs) {
 /**
  * Returns a promise that resolves when the network has been idle (after DCL) for
  * `networkQuietThresholdMs` ms and a method to cancel internal network listeners/timeout.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {NetworkMonitor} networkMonitor
  * @param {{networkQuietThresholdMs: number, busyEvent: NetworkMonitorEvent, idleEvent: NetworkMonitorEvent, isIdle(recorder: NetworkMonitor): boolean, pretendDCLAlreadyFired?: boolean}} networkQuietOptions
  * @return {CancellableWait}
@@ -213,7 +213,7 @@ function waitForNetworkIdle(session, networkMonitor, networkQuietOptions) {
 
 /**
  * Resolves when there have been no long tasks for at least waitForCPUQuiet ms.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {number} waitForCPUQuiet
  * @return {CancellableWait}
  */
@@ -344,7 +344,7 @@ function checkTimeSinceLastLongTaskInPage() {
 /**
  * Return a promise that resolves `pauseAfterLoadMs` after the load event
  * fires and a method to cancel internal listeners and timeout.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {number} pauseAfterLoadMs
  * @return {CancellableWait}
  */
@@ -379,7 +379,7 @@ function waitForLoadEvent(session, pauseAfterLoadMs) {
 
 /**
  * Returns whether the page appears to be hung.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @return {Promise<boolean>}
  */
 async function isPageHung(session) {
@@ -410,7 +410,7 @@ const DEFAULT_WAIT_FUNCTIONS = {waitForFcp, waitForLoadEvent, waitForCPUIdle, wa
  *    - cpuQuietThresholdMs have passed since the last long task after network-2-quiet.
  * - maxWaitForLoadedMs milliseconds have passed.
  * See https://github.com/GoogleChrome/lighthouse/issues/627 for more.
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {NetworkMonitor} networkMonitor
  * @param {WaitOptions} options
  * @return {Promise<{timedOut: boolean}>}
@@ -519,7 +519,7 @@ async function waitForFullyLoaded(session, networkMonitor, options) {
 }
 
 /**
- * @param {LH.Gatherer.FRTransitionalDriver} driver
+ * @param {LH.Gatherer.Driver} driver
  */
 function waitForUserToContinue(driver) {
   /* c8 ignore start */

package/core/gather/driver.d.ts

@@ -1,5 +1,5 @@
-/** @implements {LH.Gatherer.FRTransitionalDriver} */
-export class Driver implements LH.Gatherer.FRTransitionalDriver {
+/** @implements {LH.Gatherer.Driver} */
+export class Driver implements LH.Gatherer.Driver {
     /**
      * @param {LH.Puppeteer.Page} page
      */
@@ -7,16 +7,18 @@ export class Driver implements LH.Gatherer.FRTransitionalDriver {
     _page: import("../../types/puppeteer.js").default.Page;
     /** @type {TargetManager|undefined} */
     _targetManager: TargetManager | undefined;
+    /** @type {NetworkMonitor|undefined} */
+    _networkMonitor: NetworkMonitor | undefined;
     /** @type {ExecutionContext|undefined} */
     _executionContext: ExecutionContext | undefined;
     /** @type {Fetcher|undefined} */
     _fetcher: Fetcher | undefined;
-    defaultSession: import("../../types/gatherer.js").default.FRProtocolSession;
-    /** @return {LH.Gatherer.FRTransitionalDriver['executionContext']} */
+    defaultSession: import("../../types/gatherer.js").default.ProtocolSession;
+    /** @return {LH.Gatherer.Driver['executionContext']} */
     get executionContext(): ExecutionContext;
-    /** @return {Fetcher} */
-    get fetcher(): Fetcher;
+    get fetcher(): any;
     get targetManager(): any;
+    get networkMonitor(): any;
     /** @return {Promise<string>} */
     url(): Promise<string>;
     /** @return {Promise<void>} */
@@ -25,6 +27,7 @@ export class Driver implements LH.Gatherer.FRTransitionalDriver {
     disconnect(): Promise<void>;
 }
 import { TargetManager } from './driver/target-manager.js';
+import { NetworkMonitor } from './driver/network-monitor.js';
 import { ExecutionContext } from './driver/execution-context.js';
 import { Fetcher } from './fetcher.js';
 //# sourceMappingURL=driver.d.ts.map

package/core/gather/driver.js

@@ -9,13 +9,14 @@ import log from 'lighthouse-logger';
 import {ExecutionContext} from './driver/execution-context.js';
 import {TargetManager} from './driver/target-manager.js';
 import {Fetcher} from './fetcher.js';
+import {NetworkMonitor} from './driver/network-monitor.js';
 
 /** @return {*} */
 const throwNotConnectedFn = () => {
   throw new Error('Session not connected');
 };
 
-/** @type {LH.Gatherer.FRProtocolSession} */
+/** @type {LH.Gatherer.ProtocolSession} */
 const throwingSession = {
   setTargetInfo: throwNotConnectedFn,
   hasNextProtocolTimeout: throwNotConnectedFn,
@@ -28,7 +29,7 @@ const throwingSession = {
   dispose: throwNotConnectedFn,
 };
 
-/** @implements {LH.Gatherer.FRTransitionalDriver} */
+/** @implements {LH.Gatherer.Driver} */
 class Driver {
   /**
    * @param {LH.Puppeteer.Page} page
@@ -37,6 +38,8 @@ class Driver {
     this._page = page;
     /** @type {TargetManager|undefined} */
     this._targetManager = undefined;
+    /** @type {NetworkMonitor|undefined} */
+    this._networkMonitor = undefined;
     /** @type {ExecutionContext|undefined} */
     this._executionContext = undefined;
     /** @type {Fetcher|undefined} */
@@ -45,13 +48,12 @@ class Driver {
     this.defaultSession = throwingSession;
   }
 
-  /** @return {LH.Gatherer.FRTransitionalDriver['executionContext']} */
+  /** @return {LH.Gatherer.Driver['executionContext']} */
   get executionContext() {
     if (!this._executionContext) return throwNotConnectedFn();
     return this._executionContext;
   }
 
-  /** @return {Fetcher} */
   get fetcher() {
     if (!this._fetcher) return throwNotConnectedFn();
     return this._fetcher;
@@ -62,6 +64,11 @@ class Driver {
     return this._targetManager;
   }
 
+  get networkMonitor() {
+    if (!this._networkMonitor) return throwNotConnectedFn();
+    return this._networkMonitor;
+  }
+
   /** @return {Promise<string>} */
   async url() {
     return this._page.url();
@@ -75,6 +82,8 @@ class Driver {
     const cdpSession = await this._page.target().createCDPSession();
     this._targetManager = new TargetManager(cdpSession);
     await this._targetManager.enable();
+    this._networkMonitor = new NetworkMonitor(this._targetManager);
+    await this._networkMonitor.enable();
     this.defaultSession = this._targetManager.rootSession();
     this._executionContext = new ExecutionContext(this.defaultSession);
     this._fetcher = new Fetcher(this.defaultSession);
@@ -85,6 +94,7 @@ class Driver {
   async disconnect() {
     if (this.defaultSession === throwingSession) return;
     await this._targetManager?.disable();
+    await this._networkMonitor?.disable();
     await this.defaultSession.dispose();
   }
 }

package/core/gather/fetcher.d.ts

@@ -9,10 +9,10 @@ export type FetchResponse = {
 /** @typedef {{content: string|null, status: number|null}} FetchResponse */
 export class Fetcher {
     /**
-     * @param {LH.Gatherer.FRProtocolSession} session
+     * @param {LH.Gatherer.ProtocolSession} session
      */
-    constructor(session: LH.Gatherer.FRProtocolSession);
-    session: LH.Gatherer.FRProtocolSession;
+    constructor(session: LH.Gatherer.ProtocolSession);
+    session: LH.Gatherer.ProtocolSession;
     /**
      * Fetches any resource using the network directly.
      *

package/core/gather/fetcher.js

@@ -17,7 +17,7 @@ import * as LH from '../../types/lh.js';
 
 class Fetcher {
   /**
-   * @param {LH.Gatherer.FRProtocolSession} session
+   * @param {LH.Gatherer.ProtocolSession} session
    */
   constructor(session) {
     this.session = session;

package/core/gather/gatherers/accessibility.d.ts

@@ -1,16 +1,16 @@
 export default Accessibility;
-declare class Accessibility extends FRGatherer {
+declare class Accessibility extends BaseGatherer {
     static pageFns: {
         runA11yChecks: typeof runA11yChecks;
         createAxeRuleResultArtifact: typeof createAxeRuleResultArtifact;
     };
     /**
-     * @param {LH.Gatherer.FRTransitionalContext} passContext
+     * @param {LH.Gatherer.Context} passContext
      * @return {Promise<LH.Artifacts.Accessibility>}
      */
-    getArtifact(passContext: LH.Gatherer.FRTransitionalContext): Promise<LH.Artifacts.Accessibility>;
+    getArtifact(passContext: LH.Gatherer.Context): Promise<LH.Artifacts.Accessibility>;
 }
-import FRGatherer from '../base-gatherer.js';
+import BaseGatherer from '../base-gatherer.js';
 /**
  * @return {Promise<LH.Artifacts.Accessibility>}
  */

package/core/gather/gatherers/accessibility.js

@@ -6,7 +6,7 @@
 
 /* global window, document, getNodeDetails */
 
-import FRGatherer from '../base-gatherer.js';
+import BaseGatherer from '../base-gatherer.js';
 import {axeSource} from '../../lib/axe.js';
 import {pageFunctions} from '../../lib/page-functions.js';
 
@@ -41,6 +41,7 @@ async function runA11yChecks() {
       // Consider http://go/prcpg for expert review of the aXe rules.
       'accesskeys': {enabled: true},
       'area-alt': {enabled: false},
+      'aria-allowed-role': {enabled: true},
       'aria-dialog-name': {enabled: true},
       'aria-roledescription': {enabled: false},
       'aria-treeitem-name': {enabled: true},
@@ -54,7 +55,9 @@ async function runA11yChecks() {
       'heading-order': {enabled: true},
       'html-xml-lang-mismatch': {enabled: true},
       'identical-links-same-purpose': {enabled: true},
+      'image-redundant-alt': {enabled: true},
       'input-button-name': {enabled: true},
+      'label-content-name-mismatch': {enabled: true},
       'landmark-one-main': {enabled: true},
       'link-in-text-block': {enabled: true},
       'marquee': {enabled: false},
@@ -66,8 +69,10 @@ async function runA11yChecks() {
       'scrollable-region-focusable': {enabled: false},
       'select-name': {enabled: true},
       'server-side-image-map': {enabled: false},
+      'skip-link': {enabled: true},
       'svg-img-alt': {enabled: false},
       'tabindex': {enabled: true},
+      'table-duplicate-name': {enabled: true},
       'table-fake-caption': {enabled: true},
       'target-size': {enabled: true},
       'td-has-header': {enabled: true},
@@ -169,7 +174,7 @@ function createAxeRuleResultArtifact(result) {
 }
 /* c8 ignore stop */
 
-class Accessibility extends FRGatherer {
+class Accessibility extends BaseGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
@@ -181,7 +186,7 @@ class Accessibility extends FRGatherer {
   };
 
   /**
-   * @param {LH.Gatherer.FRTransitionalContext} passContext
+   * @param {LH.Gatherer.Context} passContext
    * @return {Promise<LH.Artifacts.Accessibility>}
    */
   getArtifact(passContext) {

package/core/gather/gatherers/anchor-elements.d.ts

@@ -1,10 +1,10 @@
 export default AnchorElements;
-declare class AnchorElements extends FRGatherer {
+declare class AnchorElements extends BaseGatherer {
     /**
-     * @param {LH.Gatherer.FRTransitionalContext} passContext
+     * @param {LH.Gatherer.Context} passContext
      * @return {Promise<LH.Artifacts['AnchorElements']>}
      */
-    getArtifact(passContext: LH.Gatherer.FRTransitionalContext): Promise<LH.Artifacts['AnchorElements']>;
+    getArtifact(passContext: LH.Gatherer.Context): Promise<LH.Artifacts['AnchorElements']>;
 }
-import FRGatherer from '../base-gatherer.js';
+import BaseGatherer from '../base-gatherer.js';
 //# sourceMappingURL=anchor-elements.d.ts.map

package/core/gather/gatherers/anchor-elements.js

@@ -6,7 +6,7 @@
 
 /* global getNodeDetails */
 
-import FRGatherer from '../base-gatherer.js';
+import BaseGatherer from '../base-gatherer.js';
 import {pageFunctions} from '../../lib/page-functions.js';
 import {resolveDevtoolsNodePathToObjectId} from '../driver/dom.js';
 
@@ -76,7 +76,7 @@ function collectAnchorElements() {
 /* c8 ignore stop */
 
 /**
- * @param {LH.Gatherer.FRProtocolSession} session
+ * @param {LH.Gatherer.ProtocolSession} session
  * @param {string} devtoolsNodePath
  * @return {Promise<Array<{type: string}>>}
  */
@@ -91,14 +91,14 @@ async function getEventListeners(session, devtoolsNodePath) {
   return response.listeners.map(({type}) => ({type}));
 }
 
-class AnchorElements extends FRGatherer {
+class AnchorElements extends BaseGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
   };
 
   /**
-   * @param {LH.Gatherer.FRTransitionalContext} passContext
+   * @param {LH.Gatherer.Context} passContext
    * @return {Promise<LH.Artifacts['AnchorElements']>}
    */
   async getArtifact(passContext) {

package/core/gather/gatherers/bf-cache-failures.d.ts

@@ -1,5 +1,5 @@
 export default BFCacheFailures;
-declare class BFCacheFailures extends FRGatherer {
+declare class BFCacheFailures extends BaseGatherer {
     /**
      * @param {LH.Crdp.Page.BackForwardCacheNotRestoredExplanation[]} errorList
      * @return {LH.Artifacts.BFCacheFailure}
@@ -18,26 +18,20 @@ declare class BFCacheFailures extends FRGatherer {
     /** @type {LH.Gatherer.GathererMeta<'DevtoolsLog'>} */
     meta: LH.Gatherer.GathererMeta<'DevtoolsLog'>;
     /**
-     * @param {LH.Gatherer.FRTransitionalContext} context
+     * @param {LH.Gatherer.Context} context
      * @return {Promise<LH.Crdp.Page.BackForwardCacheNotUsedEvent|undefined>}
      */
-    activelyCollectBFCacheEvent(context: LH.Gatherer.FRTransitionalContext): Promise<LH.Crdp.Page.BackForwardCacheNotUsedEvent | undefined>;
+    activelyCollectBFCacheEvent(context: LH.Gatherer.Context): Promise<LH.Crdp.Page.BackForwardCacheNotUsedEvent | undefined>;
     /**
-     * @param {LH.Gatherer.FRTransitionalContext<'DevtoolsLog'>} context
+     * @param {LH.Gatherer.Context<'DevtoolsLog'>} context
      * @return {LH.Crdp.Page.BackForwardCacheNotUsedEvent[]}
      */
-    passivelyCollectBFCacheEvents(context: LH.Gatherer.FRTransitionalContext<'DevtoolsLog'>): LH.Crdp.Page.BackForwardCacheNotUsedEvent[];
+    passivelyCollectBFCacheEvents(context: LH.Gatherer.Context<'DevtoolsLog'>): LH.Crdp.Page.BackForwardCacheNotUsedEvent[];
     /**
-     * @param {LH.Gatherer.FRTransitionalContext<'DevtoolsLog'>} context
+     * @param {LH.Gatherer.Context<'DevtoolsLog'>} context
      * @return {Promise<LH.Artifacts['BFCacheFailures']>}
      */
-    getArtifact(context: LH.Gatherer.FRTransitionalContext<'DevtoolsLog'>): Promise<LH.Artifacts['BFCacheFailures']>;
-    /**
-     * @param {LH.Gatherer.PassContext} passContext
-     * @param {LH.Gatherer.LoadData} loadData
-     * @return {Promise<LH.Artifacts['BFCacheFailures']>}
-     */
-    afterPass(passContext: LH.Gatherer.PassContext, loadData: LH.Gatherer.LoadData): Promise<LH.Artifacts['BFCacheFailures']>;
+    getArtifact(context: LH.Gatherer.Context<'DevtoolsLog'>): Promise<LH.Artifacts['BFCacheFailures']>;
 }
-import FRGatherer from '../base-gatherer.js';
+import BaseGatherer from '../base-gatherer.js';
 //# sourceMappingURL=bf-cache-failures.d.ts.map