lighthouse 10.4.0 → 11.0.0

package/CONTRIBUTING.md

@@ -85,7 +85,7 @@ A PR adding or changing a gatherer almost always needs to include the following:
    yarn update:sample-artifacts ScriptElements
    ```
 
-   This command works for updating `yarn update:sample-artifacts devtoolsLogs` or `traces` as well, but the resulting `sample_v2.json` churn may be extensive and you might be better off editing manually.
+   This command works for updating `yarn update:sample-artifacts DevtoolsLog` or `Trace` as well, but the resulting `sample_v2.json` churn may be extensive and you might be better off editing manually.
 
 1. Run `yarn update:sample-json` to update the [sample Lighthouse result JSON](core/test/results/sample_v2.json) kept in the repo for testing. This will also pull any strings needed for localization into the correct files.
 

package/cli/cli-flags.d.ts

@@ -24,7 +24,7 @@ export function getYargsParser(manualArgv?: string | undefined): yargs.Argv<yarg
         default: boolean;
         describe: string;
     };
-}>, "port" | "screenEmulation" | "emulatedUserAgent" | "hostname" | "preset" | "save-assets" | "list-all-audits" | "list-locales" | "list-trace-categories" | "debug-navigation" | "legacy-navigation" | "additional-trace-categories" | "config-path" | "chrome-flags" | "form-factor" | "max-wait-for-load" | "enable-error-reporting" | "gather-mode" | "audit-mode" | "only-audits" | "only-categories" | "skip-audits" | "budget-path" | "disable-full-page-screenshot"> & yargs.InferredOptionTypes<{
+}>, "port" | "screenEmulation" | "emulatedUserAgent" | "hostname" | "preset" | "save-assets" | "list-all-audits" | "list-locales" | "list-trace-categories" | "debug-navigation" | "additional-trace-categories" | "config-path" | "chrome-flags" | "form-factor" | "max-wait-for-load" | "enable-error-reporting" | "gather-mode" | "audit-mode" | "only-audits" | "only-categories" | "skip-audits" | "budget-path" | "disable-full-page-screenshot"> & yargs.InferredOptionTypes<{
     'save-assets': {
         type: "boolean";
         default: boolean;
@@ -49,11 +49,6 @@ export function getYargsParser(manualArgv?: string | undefined): yargs.Argv<yarg
         type: "boolean";
         describe: string;
     };
-    'legacy-navigation': {
-        type: "boolean";
-        default: boolean;
-        describe: string;
-    };
     'additional-trace-categories': {
         type: "string";
         describe: string;

package/cli/cli-flags.js

@@ -117,11 +117,6 @@ function getYargsParser(manualArgv) {
         type: 'boolean',
         describe: 'Pause after page load to wait for permission to continue the run, evaluate `continueLighthouseRun` in the console to continue.',
       },
-      'legacy-navigation': {
-        type: 'boolean',
-        default: false,
-        describe: '[DEPRECATED] Use the legacy navigation runner to gather results. Only use this if you are using a pre-10.0 custom Lighthouse config, or if Lighthouse unexpectedly fails after updating to 10.0. Please file a bug if you need this flag for Lighthouse to work.',
-      },
       'additional-trace-categories': {
         type: 'string',
         describe: 'Additional categories to capture with the trace (comma-delimited).',

package/cli/run.js

@@ -16,7 +16,7 @@ import log from 'lighthouse-logger';
 import open from 'open';
 
 import * as Printer from './printer.js';
-import lighthouse, {legacyNavigation} from '../core/index.js';
+import lighthouse from '../core/index.js';
 import {getLhrFilenamePrefix} from '../report/generator/file-namer.js';
 import * as assetSaver from '../core/lib/asset-saver.js';
 import UrlUtils from '../core/lib/url-utils.js';
@@ -238,16 +238,9 @@ async function runLighthouse(url, flags, config) {
       flags.port = launchedChrome.port;
     }
 
-    if (flags.legacyNavigation) {
-      log.warn('CLI', 'Legacy navigation CLI is deprecated');
-      flags.channel = 'legacy-navigation-cli';
-    } else if (!flags.channel) {
-      flags.channel = 'cli';
-    }
+    flags.channel = 'cli';
 
-    const runnerResult = flags.legacyNavigation ?
-       await legacyNavigation(url, flags, config) :
-       await lighthouse(url, flags, config);
+    const runnerResult = await lighthouse(url, flags, config);
 
     // If in gatherMode only, there will be no runnerResult.
     if (runnerResult) {

package/cli/sentry-prompt.js

@@ -10,10 +10,12 @@ import log from 'lighthouse-logger';
 
 const MAXIMUM_WAIT_TIME = 20 * 1000;
 
-// eslint-disable-next-line max-len
+/* eslint-disable max-len */
 const MESSAGE = `${log.reset}We're constantly trying to improve Lighthouse and its reliability.\n  ` +
   `${log.reset}Learn more: https://github.com/GoogleChrome/lighthouse/blob/main/docs/error-reporting.md \n ` +
-  ` ${log.bold}May we anonymously report runtime exceptions to improve the tool over time?${log.reset} `; // eslint-disable-line max-len
+  ` ${log.bold}May we anonymously report runtime exceptions to improve the tool over time?${log.reset}\n  ` +
+  `We'll remember your choice, but you can also use the flag --[no-]enable-error-reporting`;
+/* eslint-enable max-len */
 
 /**
  * @return {Promise<boolean>}

package/cli/test/smokehouse/core-tests.js

@@ -33,7 +33,6 @@ import metricsTrickyTtiLateFcp from './test-definitions/metrics-tricky-tti-late-
 import offlineOnlineOnly from './test-definitions/offline-online-only.js';
 import offlineReady from './test-definitions/offline-ready.js';
 import offlineSwBroken from './test-definitions/offline-sw-broken.js';
-import offlineSwSlow from './test-definitions/offline-sw-slow.js';
 import oopifRequests from './test-definitions/oopif-requests.js';
 import oopifScripts from './test-definitions/oopif-scripts.js';
 import perfBudgets from './test-definitions/perf-budgets.js';
@@ -97,7 +96,6 @@ const smokeTests = [
   offlineOnlineOnly,
   offlineReady,
   offlineSwBroken,
-  offlineSwSlow,
   oopifRequests,
   oopifScripts,
   perfBudgets,

package/cli/test/smokehouse/frontends/smokehouse-bin.js

@@ -136,11 +136,6 @@ async function begin() {
         default: false,
         describe: 'Save test artifacts and output verbose logs',
       },
-      'legacy-navigation': {
-        type: 'boolean',
-        default: false,
-        describe: 'Use the legacy navigation runner',
-      },
       'jobs': {
         type: 'number',
         alias: 'j',
@@ -218,7 +213,6 @@ async function begin() {
       jobs,
       retries,
       isDebug: argv.debug,
-      useLegacyNavigation: argv.legacyNavigation,
       lighthouseRunner: runLighthouse,
       takeNetworkRequestUrls,
       setup,
@@ -229,17 +223,25 @@ async function begin() {
     servers?.forEach(s => s.close());
   }
 
+  let smokehouseOutputDir;
+  let testResultsToOutput;
   if (!smokehouseResult.success) {
-    const failedTestResults = smokehouseResult.testResults.filter(r => r.failed);
-
     // Save failed runs to directory. In CI, this is uploaded as an artifact.
-    const failuresDir = `${LH_ROOT}/.tmp/smokehouse-failures`;
-    fs.rmSync(failuresDir, {recursive: true, force: true});
-    fs.mkdirSync(failuresDir);
+    smokehouseOutputDir = `${LH_ROOT}/.tmp/smokehouse-failures`;
+    testResultsToOutput = smokehouseResult.testResults.filter(r => r.failed);
+  } else if (!process.env.CI) {
+    // Otherwise, only write to disk in debug mode.
+    smokehouseOutputDir = `${LH_ROOT}/.tmp/smokehouse-output`;
+    testResultsToOutput = smokehouseResult.testResults;
+  }
 
-    for (const testResult of failedTestResults) {
+  if (smokehouseOutputDir && testResultsToOutput) {
+    fs.rmSync(smokehouseOutputDir, {recursive: true, force: true});
+    fs.mkdirSync(smokehouseOutputDir, {recursive: true});
+
+    for (const testResult of testResultsToOutput) {
       for (let i = 0; i < testResult.runs.length; i++) {
-        const runDir = `${failuresDir}/${i}/${testResult.id}`;
+        const runDir = `${smokehouseOutputDir}/${i}/${testResult.id}`;
         fs.mkdirSync(runDir, {recursive: true});
 
         const run = testResult.runs[i];
@@ -250,10 +252,18 @@ async function begin() {
         if (run.networkRequests) {
           fs.writeFileSync(`${runDir}/networkRequests.txt`, run.networkRequests.join('\n'));
         }
+        const config = testDefns.find(test => test.id === testResult.id)?.config;
+        if (config) {
+          fs.writeFileSync(`${runDir}/config.json`, JSON.stringify(config, null, 2));
+        }
       }
     }
 
-    const cmd = `yarn smoke ${failedTestResults.map(r => r.id).join(' ')}`;
+    console.log(`smokehouse artifacts written to ${smokehouseOutputDir}`);
+  }
+
+  if (!smokehouseResult.success && testResultsToOutput) {
+    const cmd = `yarn smoke ${testResultsToOutput.map(r => r.id).join(' ')}`;
     console.log(`rerun failures: ${cmd}`);
   }
 

package/cli/test/smokehouse/lighthouse-runners/bundle.d.ts

@@ -2,12 +2,11 @@
  * Launch Chrome and do a full Lighthouse run via the Lighthouse DevTools bundle.
  * @param {string} url
  * @param {LH.Config=} config
- * @param {{isDebug?: boolean, useLegacyNavigation?: boolean}=} testRunnerOptions
+ * @param {{isDebug?: boolean}=} testRunnerOptions
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts, log: string}>}
  */
 export function runLighthouse(url: string, config?: LH.Config | undefined, testRunnerOptions?: {
     isDebug?: boolean;
-    useLegacyNavigation?: boolean;
 } | undefined): Promise<{
     lhr: LH.Result;
     artifacts: LH.Artifacts;

package/cli/test/smokehouse/lighthouse-runners/bundle.js

@@ -17,9 +17,8 @@ import {Worker, isMainThread, parentPort, workerData} from 'worker_threads';
 import {once} from 'events';
 
 import puppeteer from 'puppeteer-core';
-import ChromeLauncher from 'chrome-launcher';
+import * as ChromeLauncher from 'chrome-launcher';
 
-import {CriConnection} from '../../../../core/legacy/gather/connections/cri.js';
 import {LH_ROOT} from '../../../../root.js';
 import {loadArtifacts, saveArtifacts} from '../../../../core/lib/asset-saver.js';
 
@@ -39,7 +38,7 @@ if (!isMainThread && parentPort) {
       parentPort?.postMessage({type: 'result', value});
     } catch (err) {
       console.error(err);
-      parentPort?.postMessage({type: 'error', value: err});
+      parentPort?.postMessage({type: 'error', value: err.toString()});
     }
   })();
 }
@@ -47,7 +46,7 @@ if (!isMainThread && parentPort) {
 /**
  * @param {string} url
  * @param {LH.Config|undefined} config
- * @param {{isDebug?: boolean, useLegacyNavigation?: boolean}} testRunnerOptions
+ * @param {{isDebug?: boolean}} testRunnerOptions
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts}>}
  */
 async function runBundledLighthouse(url, config, testRunnerOptions) {
@@ -57,6 +56,7 @@ async function runBundledLighthouse(url, config, testRunnerOptions) {
 
   const originalBuffer = global.Buffer;
   const originalRequire = global.require;
+  const originalProcess = global.process;
   if (typeof globalThis === 'undefined') {
     // @ts-expect-error - exposing for loading of dt-bundle.
     global.globalThis = global;
@@ -67,15 +67,12 @@ async function runBundledLighthouse(url, config, testRunnerOptions) {
 
   global.require = originalRequire;
   global.Buffer = originalBuffer;
+  global.process = originalProcess;
 
   /** @type {import('../../../../core/index.js')['default']} */
   // @ts-expect-error - not worth giving test global an actual type.
   const lighthouse = global.runBundledLighthouse;
 
-  /** @type {import('../../../../core/index.js')['legacyNavigation']} */
-  // @ts-expect-error - not worth giving test global an actual type.
-  const legacyNavigation = global.runBundledLighthouseLegacyNavigation;
-
   // Launch and connect to Chrome.
   const launchedChrome = await ChromeLauncher.launch();
   const port = launchedChrome.port;
@@ -83,17 +80,11 @@ async function runBundledLighthouse(url, config, testRunnerOptions) {
   // Run Lighthouse.
   try {
     const logLevel = testRunnerOptions.isDebug ? 'verbose' : 'info';
-    let runnerResult;
-    if (testRunnerOptions.useLegacyNavigation) {
-      const connection = new CriConnection(port);
-      runnerResult =
-        await legacyNavigation(url, {port, logLevel}, config, connection);
-    } else {
-      // Puppeteer is not included in the bundle, we must create the page here.
-      const browser = await puppeteer.connect({browserURL: `http://localhost:${port}`});
-      const page = await browser.newPage();
-      runnerResult = await lighthouse(url, {port, logLevel}, config, page);
-    }
+
+    // Puppeteer is not included in the bundle, we must create the page here.
+    const browser = await puppeteer.connect({browserURL: `http://127.0.0.1:${port}`});
+    const page = await browser.newPage();
+    const runnerResult = await lighthouse(url, {port, logLevel}, config, page);
     if (!runnerResult) throw new Error('No runnerResult');
 
     return {
@@ -110,7 +101,7 @@ async function runBundledLighthouse(url, config, testRunnerOptions) {
  * Launch Chrome and do a full Lighthouse run via the Lighthouse DevTools bundle.
  * @param {string} url
  * @param {LH.Config=} config
- * @param {{isDebug?: boolean, useLegacyNavigation?: boolean}=} testRunnerOptions
+ * @param {{isDebug?: boolean}=} testRunnerOptions
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts, log: string}>}
  */
 async function runLighthouse(url, config, testRunnerOptions = {}) {
@@ -133,7 +124,7 @@ async function runLighthouse(url, config, testRunnerOptions = {}) {
   const log = logs.join('') + '\n';
 
   if (workerResponse.type === 'error') {
-    new Error(`Worker returned an error: ${workerResponse.value}\nLog:\n${log}`);
+    throw new Error(`Worker returned an error: ${workerResponse.value}\nLog:\n${log}`);
   }
 
   const result = workerResponse.value;

package/cli/test/smokehouse/lighthouse-runners/cli.d.ts

@@ -1,14 +1,12 @@
-/// <reference path="../../../../../../types/internal/lighthouse-logger.d.ts" />
 /**
  * Launch Chrome and do a full Lighthouse run via the Lighthouse CLI.
  * @param {string} url
  * @param {LH.Config=} config
- * @param {{isDebug?: boolean, useFraggleRock?: boolean}=} testRunnerOptions
+ * @param {{isDebug?: boolean}=} testRunnerOptions
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts, log: string}>}
  */
 export function runLighthouse(url: string, config?: LH.Config | undefined, testRunnerOptions?: {
     isDebug?: boolean | undefined;
-    useFraggleRock?: boolean | undefined;
 } | undefined): Promise<{
     lhr: LH.Result;
     artifacts: LH.Artifacts;

package/cli/test/smokehouse/lighthouse-runners/cli.js

@@ -28,7 +28,7 @@ const execFileAsync = promisify(execFile);
  * Launch Chrome and do a full Lighthouse run via the Lighthouse CLI.
  * @param {string} url
  * @param {LH.Config=} config
- * @param {{isDebug?: boolean, useFraggleRock?: boolean}=} testRunnerOptions
+ * @param {{isDebug?: boolean}=} testRunnerOptions
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts, log: string}>}
  */
 async function runLighthouse(url, config, testRunnerOptions = {}) {
@@ -46,11 +46,11 @@ async function runLighthouse(url, config, testRunnerOptions = {}) {
  * @param {string} url
  * @param {string} tmpPath
  * @param {LH.Config=} config
- * @param {{isDebug?: boolean, useLegacyNavigation?: boolean}=} options
+ * @param {{isDebug?: boolean}=} options
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts, log: string}>}
  */
 async function internalRun(url, tmpPath, config, options) {
-  const {isDebug = false, useLegacyNavigation = false} = options || {};
+  const {isDebug = false} = options || {};
   const localConsole = new LocalConsole();
 
   const outputPath = `${tmpPath}/smokehouse.report.json`;
@@ -67,10 +67,6 @@ async function internalRun(url, tmpPath, config, options) {
     '--quiet',
   ];
 
-  if (useLegacyNavigation) {
-    args.push('--legacy-navigation');
-  }
-
   // Config can be optionally provided.
   if (config) {
     const configPath = `${tmpPath}/config.json`;

package/cli/test/smokehouse/lighthouse-runners/devtools.d.ts

@@ -5,13 +5,9 @@
  * CHROME_PATH determines which Chrome is used–otherwise the default is puppeteer's chrome binary.
  * @param {string} url
  * @param {LH.Config=} config
- * @param {{isDebug?: boolean, useLegacyNavigation?: boolean}=} testRunnerOptions
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts, log: string}>}
  */
-export function runLighthouse(url: string, config?: LH.Config | undefined, testRunnerOptions?: {
-    isDebug?: boolean;
-    useLegacyNavigation?: boolean;
-} | undefined): Promise<{
+export function runLighthouse(url: string, config?: LH.Config | undefined): Promise<{
     lhr: LH.Result;
     artifacts: LH.Artifacts;
     log: string;

package/cli/test/smokehouse/lighthouse-runners/devtools.js

@@ -8,8 +8,6 @@
  * @fileoverview A runner that launches Chrome and executes Lighthouse via DevTools.
  */
 
-import fs from 'fs';
-import os from 'os';
 import {execFileSync} from 'child_process';
 
 import {LH_ROOT} from '../../../../root.js';
@@ -42,26 +40,17 @@ async function setup() {
  * CHROME_PATH determines which Chrome is used–otherwise the default is puppeteer's chrome binary.
  * @param {string} url
  * @param {LH.Config=} config
- * @param {{isDebug?: boolean, useLegacyNavigation?: boolean}=} testRunnerOptions
  * @return {Promise<{lhr: LH.Result, artifacts: LH.Artifacts, log: string}>}
  */
-async function runLighthouse(url, config, testRunnerOptions = {}) {
+async function runLighthouse(url, config) {
   const chromeFlags = [
     `--custom-devtools-frontend=file://${devtoolsDir}/out/LighthouseIntegration/gen/front_end`,
   ];
   const {lhr, artifacts, logs} = await testUrlFromDevtools(url, {
     config,
     chromeFlags,
-    useLegacyNavigation: testRunnerOptions.useLegacyNavigation,
   });
 
-  if (testRunnerOptions.isDebug) {
-    const outputDir = fs.mkdtempSync(os.tmpdir() + '/lh-smoke-cdt-runner-');
-    fs.writeFileSync(`${outputDir}/lhr.json`, JSON.stringify(lhr));
-    fs.writeFileSync(`${outputDir}/artifacts.json`, JSON.stringify(artifacts));
-    console.log(`${url} results saved at ${outputDir}`);
-  }
-
   const log = logs.join('') + '\n';
   return {lhr, artifacts, log};
 }

package/cli/test/smokehouse/readme.md

@@ -118,8 +118,6 @@ All pruning checks:
 
 - `_minChromiumVersion`
 - `_maxChromiumVersion`
-- `_legacyOnly`
-- `_fraggleRockOnly`
 - `_runner` (set to same value provided to CLI --runner flag, ex: `'devtools'`)
 - `_excludeRunner` (set to same value provided to CLI --runner flag, ex: `'devtools'`)
 

package/cli/test/smokehouse/report-assert.d.ts

@@ -1,4 +1,3 @@
-/// <reference path="../../../../../types/internal/lighthouse-logger.d.ts" />
 export type Difference = {
     path: string;
     actual: any;
@@ -16,7 +15,7 @@ export type Comparison = {
  * summary. Returns count of passed and failed tests.
  * @param {{lhr: LH.Result, artifacts: LH.Artifacts, networkRequests?: string[]}} actual
  * @param {Smokehouse.ExpectedRunnerResult} expected
- * @param {{runner?: string, isDebug?: boolean, useLegacyNavigation?: boolean}=} reportOptions
+ * @param {{runner?: string, isDebug?: boolean}=} reportOptions
  * @return {{passed: number, failed: number, log: string}}
  */
 export function getAssertionReport(actual: {
@@ -26,7 +25,6 @@ export function getAssertionReport(actual: {
 }, expected: Smokehouse.ExpectedRunnerResult, reportOptions?: {
     runner?: string;
     isDebug?: boolean;
-    useLegacyNavigation?: boolean;
 } | undefined): {
     passed: number;
     failed: number;

package/cli/test/smokehouse/report-assert.js

@@ -237,11 +237,9 @@ function makeComparison(name, actualResult, expectedResult) {
  * @param {LocalConsole} localConsole
  * @param {LH.Result} lhr
  * @param {Smokehouse.ExpectedRunnerResult} expected
- * @param {{runner?: string, useLegacyNavigation?: boolean}=} reportOptions
+ * @param {{runner?: string}=} reportOptions
  */
 function pruneExpectations(localConsole, lhr, expected, reportOptions) {
-  const isLegacyNavigation = reportOptions?.useLegacyNavigation;
-
   /**
    * Lazily compute the Chrome version because some reports are explicitly asserting error conditions.
    * @returns {string}
@@ -295,19 +293,6 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) {
           `Actual Chromium version: ${getChromeVersionString()}`,
         ].join(' '));
         remove(key);
-      } else if (value._legacyOnly && !isLegacyNavigation) {
-        localConsole.log([
-          `[${key}] marked legacy only but run is Fraggle Rock, pruning expectation:`,
-          JSON.stringify(value, null, 2),
-        ].join(' '));
-        remove(key);
-      } else if (value._fraggleRockOnly && isLegacyNavigation) {
-        localConsole.log([
-          `[${key}] marked Fraggle Rock only but run is legacy, pruning expectation:`,
-          JSON.stringify(value, null, 2),
-          `Actual channel: ${lhr.configSettings.channel}`,
-        ].join(' '));
-        remove(key);
       } else if (value._runner && reportOptions?.runner !== value._runner) {
         localConsole.log([
           `[${key}] is only for runner ${value._runner}, pruning expectation:`,
@@ -325,8 +310,6 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) {
       }
     }
 
-    delete obj._legacyOnly;
-    delete obj._fraggleRockOnly;
     delete obj._skipInBundled;
     delete obj._minChromiumVersion;
     delete obj._maxChromiumVersion;
@@ -483,7 +466,7 @@ function reportAssertion(localConsole, assertion) {
  * summary. Returns count of passed and failed tests.
  * @param {{lhr: LH.Result, artifacts: LH.Artifacts, networkRequests?: string[]}} actual
  * @param {Smokehouse.ExpectedRunnerResult} expected
- * @param {{runner?: string, isDebug?: boolean, useLegacyNavigation?: boolean}=} reportOptions
+ * @param {{runner?: string, isDebug?: boolean}=} reportOptions
  * @return {{passed: number, failed: number, log: string}}
  */
 function getAssertionReport(actual, expected, reportOptions = {}) {

package/cli/test/smokehouse/smokehouse.js

@@ -53,7 +53,6 @@ const DEFAULT_RETRIES = 0;
 async function runSmokehouse(smokeTestDefns, smokehouseOptions) {
   const {
     isDebug,
-    useLegacyNavigation,
     jobs = DEFAULT_CONCURRENT_RUNS,
     retries = DEFAULT_RETRIES,
     lighthouseRunner = Object.assign(cliLighthouseRunner, {runnerName: 'cli'}),
@@ -76,7 +75,6 @@ async function runSmokehouse(smokeTestDefns, smokehouseOptions) {
 
   const testOptions = {
     isDebug,
-    useLegacyNavigation,
     retries,
     lighthouseRunner,
     takeNetworkRequestUrls,
@@ -133,39 +131,18 @@ function purpleify(str) {
   return `${log.purple}${str}${log.reset}`;
 }
 
-/**
- * @param {LH.Config=} config
- * @return {LH.Config|undefined}
- */
-function convertToLegacyConfig(config) {
-  if (!config) return config;
-
-  return {
-    ...config,
-    passes: [{
-      passName: 'defaultPass',
-      pauseAfterFcpMs: config.settings?.pauseAfterFcpMs,
-      pauseAfterLoadMs: config.settings?.pauseAfterLoadMs,
-      networkQuietThresholdMs: config.settings?.networkQuietThresholdMs,
-      cpuQuietThresholdMs: config.settings?.cpuQuietThresholdMs,
-      blankPage: config.settings?.blankPage,
-    }],
-  };
-}
-
 /**
  * Run Lighthouse in the selected runner.
  * @param {Smokehouse.TestDfn} smokeTestDefn
- * @param {{isDebug?: boolean, useLegacyNavigation?: boolean, retries: number, lighthouseRunner: Smokehouse.LighthouseRunner, takeNetworkRequestUrls?: () => string[]}} testOptions
+ * @param {{isDebug?: boolean, retries: number, lighthouseRunner: Smokehouse.LighthouseRunner, takeNetworkRequestUrls?: () => string[]}} testOptions
  * @return {Promise<SmokehouseResult>}
  */
 async function runSmokeTest(smokeTestDefn, testOptions) {
-  const {id, expectations} = smokeTestDefn;
+  const {id, expectations, config} = smokeTestDefn;
   const {
     lighthouseRunner,
     retries,
     isDebug,
-    useLegacyNavigation,
     takeNetworkRequestUrls,
   } = testOptions;
   const requestedUrl = expectations.lhr.requestedUrl;
@@ -184,15 +161,10 @@ async function runSmokeTest(smokeTestDefn, testOptions) {
       bufferedConsole.log(`  Retrying run (${i} out of ${retries} retries)…`);
     }
 
-    let config = smokeTestDefn.config;
-    if (useLegacyNavigation) {
-      config = convertToLegacyConfig(config);
-    }
-
     // Run Lighthouse.
     try {
       result = {
-        ...await lighthouseRunner(requestedUrl, config, {isDebug, useLegacyNavigation}),
+        ...await lighthouseRunner(requestedUrl, config, {isDebug}),
         networkRequests: takeNetworkRequestUrls ? takeNetworkRequestUrls() : undefined,
       };
 
@@ -213,7 +185,6 @@ async function runSmokeTest(smokeTestDefn, testOptions) {
     report = getAssertionReport(result, expectations, {
       runner: lighthouseRunner.runnerName,
       isDebug,
-      useLegacyNavigation,
     });
 
     runs.push({

package/core/audits/accessibility/aria-allowed-role.d.ts

@@ -0,0 +1,10 @@
+export default ARIAAllowedRole;
+declare class ARIAAllowedRole extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=aria-allowed-role.d.ts.map

package/core/audits/accessibility/aria-allowed-role.js

@@ -0,0 +1,46 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+/**
+ * @fileoverview Ensures ARIA attributes are appropriate for an element's role.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if the ARIA role attributes are valid for the HTML element. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Values assigned to `role=""` are valid ARIA roles.',
+  /** Title of an accesibility audit that evaluates if the ARIA role attributes are valid for the HTML element. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Values assigned to `role=""` are not valid ARIA roles.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'ARIA `role`s enable assistive technologies to know the role of each element on ' +
+      'the web page. If the `role` values are misspelled, not existing ARIA `role` values, or ' +
+      'abstract roles, then the purpose of the element will not be communicated to users of ' +
+      'assistive technologies. ' +
+      '[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.7/aria-allowed-roles).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class ARIAAllowedRole extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'aria-allowed-role',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default ARIAAllowedRole;
+export {UIStrings};

package/core/audits/accessibility/image-redundant-alt.d.ts

@@ -0,0 +1,10 @@
+export default ImageRedundantAlt;
+declare class ImageRedundantAlt extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=image-redundant-alt.d.ts.map