lighthouse 10.4.0 → 11.0.0

package/core/audits/work-during-interaction.js

@@ -13,7 +13,7 @@ import {MainThreadTasks} from '../lib/tracehouse/main-thread-tasks.js';
 import {taskGroups} from '../lib/tracehouse/task-groups.js';
 import {TraceProcessor} from '../lib/tracehouse/trace-processor.js';
 import {getExecutionTimingsByURL} from '../lib/tracehouse/task-summary.js';
-import ExperimentalInteractionToNextPaint from './metrics/experimental-interaction-to-next-paint.js';
+import InteractionToNextPaint from './metrics/interaction-to-next-paint.js';
 import {LighthouseError} from '../lib/lh-error.js';
 
 /** @typedef {import('../computed/metrics/responsiveness.js').EventTimingEvent} EventTimingEvent */
@@ -273,7 +273,7 @@ class WorkDuringInteraction extends Audit {
     const duration = interactionEvent.args.data.duration;
     const displayValue = str_(UIStrings.displayValue, {timeInMs: duration, interactionType});
     return {
-      score: duration < ExperimentalInteractionToNextPaint.defaultOptions.p10 ? 1 : 0,
+      score: duration < InteractionToNextPaint.defaultOptions.p10 ? 1 : 0,
       displayValue,
       details: {
         type: 'list',

package/core/computed/processed-navigation.d.ts

@@ -1,6 +1,6 @@
 export { ProcessedNavigationComputed as ProcessedNavigation };
 declare const ProcessedNavigationComputed: typeof ProcessedNavigation & {
-    request: (dependencies: import("../index.js").Trace | import("../index.js").Artifacts.ProcessedTrace, context: import("../../types/utility-types.js").default.ImmutableObject<{
+    request: (dependencies: import("../index.js").Artifacts.ProcessedTrace | import("../index.js").Trace, context: import("../../types/utility-types.js").default.ImmutableObject<{
         computedCache: Map<string, import("../lib/arbitrary-equality-map.js").ArbitraryEqualityMap>;
     }>) => Promise<import("../index.js").Artifacts.ProcessedNavigation>;
 };

package/core/config/config-helpers.d.ts

@@ -1,4 +1,4 @@
-export type GathererConstructor = typeof import('../gather/gatherers/gatherer.js').Gatherer;
+export type GathererConstructor = typeof import('../gather/base-gatherer.js').default;
 export type Audit = typeof import('../audits/audit.js')['Audit'];
 export type Gatherer = InstanceType<GathererConstructor>;
 /**
@@ -71,9 +71,9 @@ export function resolveAuditsToDefns(audits: LH.Config['audits'], configDir?: st
  * @param {LH.Config.GathererJson} gathererJson
  * @param {Array<string>} coreGathererList
  * @param {string=} configDir
- * @return {Promise<LH.Config.GathererDefn>}
+ * @return {Promise<LH.Config.AnyGathererDefn>}
  */
-export function resolveGathererToDefn(gathererJson: LH.Config.GathererJson, coreGathererList: Array<string>, configDir?: string | undefined): Promise<LH.Config.GathererDefn>;
+export function resolveGathererToDefn(gathererJson: LH.Config.GathererJson, coreGathererList: Array<string>, configDir?: string | undefined): Promise<LH.Config.AnyGathererDefn>;
 /**
  * Resolves the location of the specified module and returns an absolute
  * string path to the file. Used for loading custom audits and gatherers.

package/core/config/config-helpers.js

@@ -20,7 +20,7 @@ import {getModuleDirectory} from '../../esm-utils.js';
 
 const require = createRequire(import.meta.url);
 
-/** @typedef {typeof import('../gather/gatherers/gatherer.js').Gatherer} GathererConstructor */
+/** @typedef {typeof import('../gather/base-gatherer.js').default} GathererConstructor */
 /** @typedef {typeof import('../audits/audit.js')['Audit']} Audit */
 /** @typedef {InstanceType<GathererConstructor>} Gatherer */
 
@@ -160,7 +160,7 @@ function mergeConfigFragmentArrayByKey(baseArray, extensionArray, keyFn) {
  *  - {instance: myGathererInstance}
  *
  * @param {LH.Config.GathererJson} gatherer
- * @return {{instance?: Gatherer, implementation?: GathererConstructor, path?: string}} passes
+ * @return {{instance?: Gatherer, implementation?: GathererConstructor, path?: string}}
  */
 function expandGathererShorthand(gatherer) {
   if (typeof gatherer === 'string') {
@@ -178,7 +178,7 @@ function expandGathererShorthand(gatherer) {
   } else if (typeof gatherer === 'function') {
     // just GathererConstructor
     return {implementation: gatherer};
-  } else if (gatherer && typeof gatherer.beforePass === 'function') {
+  } else if (gatherer && typeof gatherer.getArtifact === 'function') {
     // just GathererInstance
     return {instance: gatherer};
   } else {
@@ -254,7 +254,7 @@ async function requireWrapper(requirePath) {
  * @param {string} gathererPath
  * @param {Array<string>} coreGathererList
  * @param {string=} configDir
- * @return {Promise<LH.Config.GathererDefn>}
+ * @return {Promise<LH.Config.AnyGathererDefn>}
  */
 async function requireGatherer(gathererPath, coreGathererList, configDir) {
   const coreGatherer = coreGathererList.find(a => a === `${gathererPath}.js`);
@@ -399,7 +399,7 @@ async function mergePlugins(config, configDir, flags) {
  * @param {LH.Config.GathererJson} gathererJson
  * @param {Array<string>} coreGathererList
  * @param {string=} configDir
- * @return {Promise<LH.Config.GathererDefn>}
+ * @return {Promise<LH.Config.AnyGathererDefn>}
  */
 async function resolveGathererToDefn(gathererJson, coreGathererList, configDir) {
   const gathererDefn = expandGathererShorthand(gathererJson);
@@ -595,13 +595,6 @@ function deepCloneConfigJson(json) {
 
   // Copy arrays that could contain non-serializable properties to allow for programmatic
   // injection of audit and gatherer implementations.
-  if (Array.isArray(cloned.passes) && Array.isArray(json.passes)) {
-    for (let i = 0; i < cloned.passes.length; i++) {
-      const pass = cloned.passes[i];
-      pass.gatherers = (json.passes[i].gatherers || []).map(gatherer => shallowClone(gatherer));
-    }
-  }
-
   if (Array.isArray(json.audits)) {
     cloned.audits = json.audits.map(audit => shallowClone(audit));
   }

package/core/config/config.js

@@ -12,7 +12,6 @@ import {Runner} from '../runner.js';
 import defaultConfig from './default-config.js';
 import {defaultNavigationConfig, nonSimulatedPassConfigOverrides} from './constants.js'; // eslint-disable-line max-len
 import {
-  isFRGathererDefn,
   throwInvalidDependencyOrder,
   isValidArtifactDependency,
   throwInvalidArtifactDependency,
@@ -104,7 +103,7 @@ function resolveExtensions(config) {
  * Looks up the required artifact IDs for each dependency, throwing if no earlier artifact satisfies the dependency.
  *
  * @param {LH.Config.ArtifactJson} artifact
- * @param {LH.Config.AnyFRGathererDefn} gatherer
+ * @param {LH.Config.AnyGathererDefn} gatherer
  * @param {Map<Symbol, LH.Config.AnyArtifactDefn>} artifactDefnsBySymbol
  * @return {LH.Config.AnyArtifactDefn['dependencies']}
  */
@@ -154,14 +153,9 @@ async function resolveArtifactsToDefns(artifacts, configDir) {
   const coreGathererList = Runner.getGathererList();
   const artifactDefns = [];
   for (const artifactJson of sortedArtifacts) {
-    /** @type {LH.Config.GathererJson} */
-    // @ts-expect-error - remove when legacy runner path is removed.
     const gathererJson = artifactJson.gatherer;
 
     const gatherer = await resolveGathererToDefn(gathererJson, coreGathererList, configDir);
-    if (!isFRGathererDefn(gatherer)) {
-      throw new Error(`${gatherer.instance.name} gatherer does not have a Fraggle Rock meta obj`);
-    }
 
     /** @type {LH.Config.AnyArtifactDefn} */
     // @ts-expect-error - Typescript can't validate the gatherer and dependencies match

package/core/config/constants.d.ts

@@ -48,8 +48,6 @@ export namespace userAgents {
 }
 /** @type {LH.Config.Settings} */
 export const defaultSettings: LH.Config.Settings;
-/** @type {LH.Config.Pass} */
-export const defaultPassConfig: LH.Config.Pass;
 /** @type {Required<LH.Config.NavigationJson>} */
 export const defaultNavigationConfig: Required<LH.Config.NavigationJson>;
 export namespace nonSimulatedPassConfigOverrides {

package/core/config/constants.js

@@ -17,7 +17,7 @@ const throttling = {
   DEVTOOLS_RTT_ADJUSTMENT_FACTOR,
   DEVTOOLS_THROUGHPUT_ADJUSTMENT_FACTOR,
   // These values align with WebPageTest's definition of "Fast 3G"
-  // But offer similar charateristics to roughly the 75th percentile of 4G connections.
+  // But offer similar characteristics to roughly the 75th percentile of 4G connections.
   mobileSlow4G: {
     rttMs: 150,
     throughputKbps: 1.6 * 1024,
@@ -127,24 +127,9 @@ const defaultSettings = {
   skipAudits: null,
 };
 
-/** @type {LH.Config.Pass} */
-const defaultPassConfig = {
-  passName: 'defaultPass',
-  loadFailureMode: 'fatal',
-  recordTrace: false,
-  useThrottling: false,
-  pauseAfterFcpMs: 0,
-  pauseAfterLoadMs: 0,
-  networkQuietThresholdMs: 0,
-  cpuQuietThresholdMs: 0,
-  blockedUrlPatterns: [],
-  blankPage: 'about:blank',
-  gatherers: [],
-};
-
 /** @type {Required<LH.Config.NavigationJson>} */
 const defaultNavigationConfig = {
-  id: 'default',
+  id: 'defaultPass',
   loadFailureMode: 'fatal',
   disableThrottling: false,
   disableStorageReset: false,
@@ -169,7 +154,6 @@ export {
   screenEmulationMetrics,
   userAgents,
   defaultSettings,
-  defaultPassConfig,
   defaultNavigationConfig,
   nonSimulatedPassConfigOverrides,
 };

package/core/config/default-config.js

@@ -38,8 +38,8 @@ const UIStrings = {
   diagnosticsGroupDescription: 'More information about the performance of your application. These numbers don\'t [directly affect](https://developer.chrome.com/docs/lighthouse/performance/performance-scoring/) the Performance score.',
   /** Title of the Accessibility category of audits. This section contains audits focused on making web content accessible to all users. Also used as a label of a score gauge; try to limit to 20 characters. */
   a11yCategoryTitle: 'Accessibility',
-  /** Description of the Accessibility category. This is displayed at the top of a list of audits focused on making web content accessible to all users. No character length limits. 'improve the accessibility of your web app' becomes link text to additional documentation. */
-  a11yCategoryDescription: 'These checks highlight opportunities to [improve the accessibility of your web app](https://developer.chrome.com/docs/lighthouse/accessibility/). Only a subset of accessibility issues can be automatically detected so manual testing is also encouraged.',
+  /** Description of the Accessibility category. This is displayed at the top of a list of audits focused on making web content accessible to all users. No character length limits. 'improve the accessibility of your web app' and 'manual testing' become link texts to additional documentation. */
+  a11yCategoryDescription: 'These checks highlight opportunities to [improve the accessibility of your web app](https://developer.chrome.com/docs/lighthouse/accessibility/). Automatic detection can only detect a subset of issues and does not guarantee the accessibility of your web app, so [manual testing](https://web.dev/how-to-review/) is also encouraged.',
   /** Description of the Accessibility manual checks category. This description is displayed above a list of accessibility audits that currently have no automated test and so must be verified manually by the user. No character length limits. 'conducting an accessibility review' becomes link text to additional documentation. */
   a11yCategoryManualDescription: 'These items address areas which an automated testing tool cannot cover. Learn more in our guide on [conducting an accessibility review](https://web.dev/how-to-review/).',
   /** Title of the best practices section of the Accessibility category. Within this section are audits with descriptive titles that highlight common accessibility best practices. */
@@ -176,7 +176,6 @@ const defaultConfig = {
   ],
   audits: [
     'is-on-https',
-    'service-worker',
     'viewport',
     'metrics/first-contentful-paint',
     'metrics/largest-contentful-paint',
@@ -187,7 +186,7 @@ const defaultConfig = {
     'metrics/total-blocking-time',
     'metrics/max-potential-fid',
     'metrics/cumulative-layout-shift',
-    'metrics/experimental-interaction-to-next-paint',
+    'metrics/interaction-to-next-paint',
     'errors-in-console',
     'server-response-time',
     'metrics/interactive',
@@ -216,7 +215,6 @@ const defaultConfig = {
     'metrics',
     'performance-budget',
     'timing-budget',
-    'resource-summary',
     'third-party-summary',
     'third-party-facades',
     'largest-contentful-paint-element',
@@ -235,6 +233,7 @@ const defaultConfig = {
     'manual/pwa-each-page-has-url',
     'accessibility/accesskeys',
     'accessibility/aria-allowed-attr',
+    'accessibility/aria-allowed-role',
     'accessibility/aria-command-name',
     'accessibility/aria-dialog-name',
     'accessibility/aria-hidden-body',
@@ -269,8 +268,10 @@ const defaultConfig = {
     'accessibility/html-xml-lang-mismatch',
     'accessibility/identical-links-same-purpose',
     'accessibility/image-alt',
+    'accessibility/image-redundant-alt',
     'accessibility/input-button-name',
     'accessibility/input-image-alt',
+    'accessibility/label-content-name-mismatch',
     'accessibility/label',
     'accessibility/landmark-one-main',
     'accessibility/link-name',
@@ -281,7 +282,9 @@ const defaultConfig = {
     'accessibility/meta-viewport',
     'accessibility/object-alt',
     'accessibility/select-name',
+    'accessibility/skip-link',
     'accessibility/tabindex',
+    'accessibility/table-duplicate-name',
     'accessibility/table-fake-caption',
     'accessibility/target-size',
     'accessibility/td-has-header',
@@ -432,7 +435,7 @@ const defaultConfig = {
         {id: 'total-blocking-time', weight: 30, group: 'metrics', acronym: 'TBT', relevantAudits: metricsToAudits.tbtRelevantAudits},
         {id: 'cumulative-layout-shift', weight: 25, group: 'metrics', acronym: 'CLS', relevantAudits: metricsToAudits.clsRelevantAudits},
         {id: 'speed-index', weight: 10, group: 'metrics', acronym: 'SI'},
-        {id: 'experimental-interaction-to-next-paint', weight: 0, group: 'metrics', acronym: 'INP', relevantAudits: metricsToAudits.inpRelevantAudits},
+        {id: 'interaction-to-next-paint', weight: 0, group: 'metrics', acronym: 'INP', relevantAudits: metricsToAudits.inpRelevantAudits},
 
         // These are our "invisible" metrics. Not displayed, but still in the LHR.
         {id: 'interactive', weight: 0, group: 'hidden', acronym: 'TTI'},
@@ -467,7 +470,6 @@ const defaultConfig = {
         {id: 'bootup-time', weight: 0},
         {id: 'mainthread-work-breakdown', weight: 0},
         {id: 'font-display', weight: 0},
-        {id: 'resource-summary', weight: 0},
         {id: 'third-party-summary', weight: 0},
         {id: 'third-party-facades', weight: 0},
         {id: 'largest-contentful-paint-element', weight: 0},
@@ -506,72 +508,77 @@ const defaultConfig = {
       supportedModes: ['navigation', 'snapshot'],
       // Audit weights are meant to match the aXe scoring system of
       // minor, moderate, serious, and critical.
-      // See the audits listed at dequeuniversity.com/rules/axe/4.1.
+      // See the audits listed at dequeuniversity.com/rules/axe/4.7.
       // Click on an audit and check the right hand column to see its severity.
       auditRefs: [
-        {id: 'accesskeys', weight: 3, group: 'a11y-navigation'},
+        {id: 'accesskeys', weight: 7, group: 'a11y-navigation'},
         {id: 'aria-allowed-attr', weight: 10, group: 'a11y-aria'},
-        {id: 'aria-command-name', weight: 3, group: 'a11y-aria'},
-        {id: 'aria-dialog-name', weight: 3, group: 'a11y-aria'},
+        {id: 'aria-allowed-role', weight: 1, group: 'a11y-aria'},
+        {id: 'aria-command-name', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-dialog-name', weight: 7, group: 'a11y-aria'},
         {id: 'aria-hidden-body', weight: 10, group: 'a11y-aria'},
-        {id: 'aria-hidden-focus', weight: 3, group: 'a11y-aria'},
-        {id: 'aria-input-field-name', weight: 3, group: 'a11y-aria'},
-        {id: 'aria-meter-name', weight: 3, group: 'a11y-aria'},
-        {id: 'aria-progressbar-name', weight: 3, group: 'a11y-aria'},
+        {id: 'aria-hidden-focus', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-input-field-name', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-meter-name', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-progressbar-name', weight: 7, group: 'a11y-aria'},
         {id: 'aria-required-attr', weight: 10, group: 'a11y-aria'},
         {id: 'aria-required-children', weight: 10, group: 'a11y-aria'},
         {id: 'aria-required-parent', weight: 10, group: 'a11y-aria'},
-        {id: 'aria-roles', weight: 10, group: 'a11y-aria'},
-        {id: 'aria-text', weight: 3, group: 'a11y-aria'},
-        {id: 'aria-toggle-field-name', weight: 3, group: 'a11y-aria'},
-        {id: 'aria-tooltip-name', weight: 3, group: 'a11y-aria'},
-        {id: 'aria-treeitem-name', weight: 3, group: 'a11y-aria'},
+        {id: 'aria-roles', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-text', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-toggle-field-name', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-tooltip-name', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-treeitem-name', weight: 7, group: 'a11y-aria'},
         {id: 'aria-valid-attr-value', weight: 10, group: 'a11y-aria'},
         {id: 'aria-valid-attr', weight: 10, group: 'a11y-aria'},
         {id: 'button-name', weight: 10, group: 'a11y-names-labels'},
-        {id: 'bypass', weight: 3, group: 'a11y-navigation'},
-        {id: 'color-contrast', weight: 3, group: 'a11y-color-contrast'},
-        {id: 'definition-list', weight: 3, group: 'a11y-tables-lists'},
-        {id: 'dlitem', weight: 3, group: 'a11y-tables-lists'},
-        {id: 'document-title', weight: 3, group: 'a11y-names-labels'},
-        {id: 'duplicate-id-active', weight: 3, group: 'a11y-navigation'},
+        {id: 'bypass', weight: 7, group: 'a11y-navigation'},
+        {id: 'color-contrast', weight: 7, group: 'a11y-color-contrast'},
+        {id: 'definition-list', weight: 7, group: 'a11y-tables-lists'},
+        {id: 'dlitem', weight: 7, group: 'a11y-tables-lists'},
+        {id: 'document-title', weight: 7, group: 'a11y-names-labels'},
+        {id: 'duplicate-id-active', weight: 7, group: 'a11y-navigation'},
         {id: 'duplicate-id-aria', weight: 10, group: 'a11y-aria'},
-        {id: 'form-field-multiple-labels', weight: 2, group: 'a11y-names-labels'},
-        {id: 'frame-title', weight: 3, group: 'a11y-names-labels'},
-        {id: 'heading-order', weight: 2, group: 'a11y-navigation'},
-        {id: 'html-has-lang', weight: 3, group: 'a11y-language'},
-        {id: 'html-lang-valid', weight: 3, group: 'a11y-language'},
-        {id: 'html-xml-lang-mismatch', weight: 2, group: 'a11y-language'},
+        {id: 'form-field-multiple-labels', weight: 3, group: 'a11y-names-labels'},
+        {id: 'frame-title', weight: 7, group: 'a11y-names-labels'},
+        {id: 'heading-order', weight: 3, group: 'a11y-navigation'},
+        {id: 'html-has-lang', weight: 7, group: 'a11y-language'},
+        {id: 'html-lang-valid', weight: 7, group: 'a11y-language'},
+        {id: 'html-xml-lang-mismatch', weight: 3, group: 'a11y-language'},
         {id: 'image-alt', weight: 10, group: 'a11y-names-labels'},
+        {id: 'image-redundant-alt', weight: 1, group: 'a11y-names-labels'},
         {id: 'input-button-name', weight: 10, group: 'a11y-names-labels'},
         {id: 'input-image-alt', weight: 10, group: 'a11y-names-labels'},
-        {id: 'label', weight: 10, group: 'a11y-names-labels'},
-        {id: 'link-in-text-block', weight: 3, group: 'a11y-color-contrast'},
-        {id: 'link-name', weight: 3, group: 'a11y-names-labels'},
-        {id: 'list', weight: 3, group: 'a11y-tables-lists'},
-        {id: 'listitem', weight: 3, group: 'a11y-tables-lists'},
+        {id: 'label-content-name-mismatch', weight: 7, group: 'a11y-names-labels'},
+        {id: 'label', weight: 7, group: 'a11y-names-labels'},
+        {id: 'link-in-text-block', weight: 7, group: 'a11y-color-contrast'},
+        {id: 'link-name', weight: 7, group: 'a11y-names-labels'},
+        {id: 'list', weight: 7, group: 'a11y-tables-lists'},
+        {id: 'listitem', weight: 7, group: 'a11y-tables-lists'},
         {id: 'meta-refresh', weight: 10, group: 'a11y-best-practices'},
         {id: 'meta-viewport', weight: 10, group: 'a11y-best-practices'},
-        {id: 'object-alt', weight: 3, group: 'a11y-names-labels'},
-        {id: 'select-name', weight: 3, group: 'a11y-names-labels'},
-        {id: 'tabindex', weight: 3, group: 'a11y-navigation'},
-        {id: 'table-fake-caption', weight: 3, group: 'a11y-tables-lists'},
+        {id: 'object-alt', weight: 7, group: 'a11y-names-labels'},
+        {id: 'select-name', weight: 7, group: 'a11y-names-labels'},
+        {id: 'skip-link', weight: 3, group: 'a11y-names-labels'},
+        {id: 'tabindex', weight: 7, group: 'a11y-navigation'},
+        {id: 'table-duplicate-name', weight: 1, group: 'a11y-tables-lists'},
+        {id: 'table-fake-caption', weight: 7, group: 'a11y-tables-lists'},
         {id: 'td-has-header', weight: 10, group: 'a11y-tables-lists'},
-        {id: 'td-headers-attr', weight: 3, group: 'a11y-tables-lists'},
-        {id: 'th-has-data-cells', weight: 3, group: 'a11y-tables-lists'},
-        {id: 'valid-lang', weight: 3, group: 'a11y-language'},
+        {id: 'td-headers-attr', weight: 7, group: 'a11y-tables-lists'},
+        {id: 'th-has-data-cells', weight: 7, group: 'a11y-tables-lists'},
+        {id: 'valid-lang', weight: 7, group: 'a11y-language'},
         {id: 'video-caption', weight: 10, group: 'a11y-audio-video'},
         // Manual audits
-        {id: 'logical-tab-order', weight: 0},
         {id: 'focusable-controls', weight: 0},
         {id: 'interactive-element-affordance', weight: 0},
-        {id: 'managed-focus', weight: 0},
+        {id: 'logical-tab-order', weight: 0},
+        {id: 'visual-order-follows-dom', weight: 0},
         {id: 'focus-traps', weight: 0},
+        {id: 'managed-focus', weight: 0},
+        {id: 'use-landmarks', weight: 0},
+        {id: 'offscreen-content-hidden', weight: 0},
         {id: 'custom-controls-labels', weight: 0},
         {id: 'custom-controls-roles', weight: 0},
-        {id: 'visual-order-follows-dom', weight: 0},
-        {id: 'offscreen-content-hidden', weight: 0},
-        {id: 'use-landmarks', weight: 0},
         // Hidden audits
         {id: 'empty-heading', weight: 0, group: 'hidden'},
         {id: 'identical-links-same-purpose', weight: 0, group: 'hidden'},
@@ -584,12 +591,12 @@ const defaultConfig = {
       supportedModes: ['navigation', 'timespan', 'snapshot'],
       auditRefs: [
         // Trust & Safety
-        {id: 'is-on-https', weight: 1, group: 'best-practices-trust-safety'},
+        {id: 'is-on-https', weight: 5, group: 'best-practices-trust-safety'},
         {id: 'geolocation-on-start', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'notification-on-start', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'csp-xss', weight: 0, group: 'best-practices-trust-safety'},
         // User Experience
-        {id: 'paste-preventing-inputs', weight: 1, group: 'best-practices-ux'},
+        {id: 'paste-preventing-inputs', weight: 3, group: 'best-practices-ux'},
         {id: 'image-aspect-ratio', weight: 1, group: 'best-practices-ux'},
         {id: 'image-size-responsive', weight: 1, group: 'best-practices-ux'},
         {id: 'preload-fonts', weight: 1, group: 'best-practices-ux'},
@@ -599,7 +606,7 @@ const defaultConfig = {
         // General Group
         {id: 'no-unload-listeners', weight: 1, group: 'best-practices-general'},
         {id: 'js-libraries', weight: 0, group: 'best-practices-general'},
-        {id: 'deprecations', weight: 1, group: 'best-practices-general'},
+        {id: 'deprecations', weight: 5, group: 'best-practices-general'},
         {id: 'errors-in-console', weight: 1, group: 'best-practices-general'},
         {id: 'valid-source-maps', weight: 0, group: 'best-practices-general'},
         {id: 'inspector-issues', weight: 1, group: 'best-practices-general'},
@@ -638,7 +645,6 @@ const defaultConfig = {
         // Installable
         {id: 'installable-manifest', weight: 2, group: 'pwa-installable'},
         // PWA Optimized
-        {id: 'service-worker', weight: 1, group: 'pwa-optimized'},
         {id: 'splash-screen', weight: 1, group: 'pwa-optimized'},
         {id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
         {id: 'content-width', weight: 1, group: 'pwa-optimized'},

package/core/config/filters.js

@@ -8,7 +8,7 @@ import log from 'lighthouse-logger';
 
 import {Audit} from '../audits/audit.js';
 
-/** @type {Record<keyof LH.FRBaseArtifacts, string>} */
+/** @type {Record<keyof LH.BaseArtifacts, string>} */
 const baseArtifactKeySource = {
   fetchTime: '',
   LighthouseRunWarnings: '',

package/core/config/validation.d.ts

@@ -1,17 +1,12 @@
-/**
- * @param {LH.Config.GathererDefn | LH.Config.AnyFRGathererDefn} gathererDefn
- * @return {gathererDefn is LH.Config.AnyFRGathererDefn}
- */
-export function isFRGathererDefn(gathererDefn: LH.Config.GathererDefn | LH.Config.AnyFRGathererDefn): gathererDefn is import("../../types/config.js").default.AnyFRGathererDefn;
 /**
  * Determines if the artifact dependency direction is valid. The dependency's minimum supported mode
  * must be less than or equal to the dependent's.
  *
- * @param {LH.Config.AnyFRGathererDefn} dependent The artifact that depends on the other.
- * @param {LH.Config.AnyFRGathererDefn} dependency The artifact that is being depended on by the other.
+ * @param {LH.Config.AnyGathererDefn} dependent The artifact that depends on the other.
+ * @param {LH.Config.AnyGathererDefn} dependency The artifact that is being depended on by the other.
  * @return {boolean}
  */
-export function isValidArtifactDependency(dependent: LH.Config.AnyFRGathererDefn, dependency: LH.Config.AnyFRGathererDefn): boolean;
+export function isValidArtifactDependency(dependent: LH.Config.AnyGathererDefn, dependency: LH.Config.AnyGathererDefn): boolean;
 /**
  * Throws if pluginName is invalid or (somehow) collides with a category in the
  * config being added to.
@@ -20,16 +15,16 @@ export function isValidArtifactDependency(dependent: LH.Config.AnyFRGathererDefn
  */
 export function assertValidPluginName(config: LH.Config, pluginName: string): void;
 /**
- * Throws an error if the provided object does not implement the required Fraggle Rock gatherer interface.
- * @param {LH.Config.AnyFRGathererDefn} gathererDefn
+ * Throws an error if the provided object does not implement the required gatherer interface.
+ * @param {LH.Config.AnyArtifactDefn} artifactDefn
  */
-export function assertValidFRGatherer(gathererDefn: LH.Config.AnyFRGathererDefn): void;
+export function assertValidArtifact(artifactDefn: LH.Config.AnyArtifactDefn): void;
 /**
  * Throws an error if the provided object does not implement the required navigations interface.
  * @param {LH.Config.ResolvedConfig['navigations']} navigationsDefn
  * @return {{warnings: string[]}}
  */
-export function assertValidFRNavigations(navigationsDefn: LH.Config.ResolvedConfig['navigations']): {
+export function assertValidNavigations(navigationsDefn: LH.Config.ResolvedConfig['navigations']): {
     warnings: string[];
 };
 /**

package/core/config/validation.js

@@ -5,23 +5,15 @@
  */
 
 import {Audit} from '../audits/audit.js';
-import BaseFRGatherer from '../gather/base-gatherer.js';
+import BaseGatherer from '../gather/base-gatherer.js';
 import * as i18n from '../lib/i18n/i18n.js';
 
-/**
- * @param {LH.Config.GathererDefn | LH.Config.AnyFRGathererDefn} gathererDefn
- * @return {gathererDefn is LH.Config.AnyFRGathererDefn}
- */
-function isFRGathererDefn(gathererDefn) {
-  return 'meta' in gathererDefn.instance;
-}
-
 /**
  * Determines if the artifact dependency direction is valid. The dependency's minimum supported mode
  * must be less than or equal to the dependent's.
  *
- * @param {LH.Config.AnyFRGathererDefn} dependent The artifact that depends on the other.
- * @param {LH.Config.AnyFRGathererDefn} dependency The artifact that is being depended on by the other.
+ * @param {LH.Config.AnyGathererDefn} dependent The artifact that depends on the other.
+ * @param {LH.Config.AnyGathererDefn} dependency The artifact that is being depended on by the other.
  * @return {boolean}
  */
 function isValidArtifactDependency(dependent, dependency) {
@@ -54,26 +46,25 @@ function assertValidPluginName(config, pluginName) {
 }
 
 /**
- * Throws an error if the provided object does not implement the required Fraggle Rock gatherer interface.
- * @param {LH.Config.AnyFRGathererDefn} gathererDefn
+ * Throws an error if the provided object does not implement the required gatherer interface.
+ * @param {LH.Config.AnyArtifactDefn} artifactDefn
  */
-function assertValidFRGatherer(gathererDefn) {
-  const gatherer = gathererDefn.instance;
-  const gathererName = gatherer.name;
+function assertValidArtifact(artifactDefn) {
+  const gatherer = artifactDefn.gatherer.instance;
 
   if (typeof gatherer.meta !== 'object') {
-    throw new Error(`${gathererName} gatherer did not provide a meta object.`);
+    throw new Error(`Gatherer for ${artifactDefn.id} did not provide a meta object.`);
   }
 
   if (gatherer.meta.supportedModes.length === 0) {
-    throw new Error(`${gathererName} gatherer did not support any gather modes.`);
+    throw new Error(`Gatherer for ${artifactDefn.id} did not support any gather modes.`);
   }
 
   if (
     typeof gatherer.getArtifact !== 'function' ||
-    gatherer.getArtifact === BaseFRGatherer.prototype.getArtifact
+    gatherer.getArtifact === BaseGatherer.prototype.getArtifact
   ) {
-    throw new Error(`${gathererName} gatherer did not define a "getArtifact" method.`);
+    throw new Error(`Gatherer for ${artifactDefn.id} did not define a "getArtifact" method.`);
   }
 }
 
@@ -82,7 +73,7 @@ function assertValidFRGatherer(gathererDefn) {
  * @param {LH.Config.ResolvedConfig['navigations']} navigationsDefn
  * @return {{warnings: string[]}}
  */
-function assertValidFRNavigations(navigationsDefn) {
+function assertValidNavigations(navigationsDefn) {
   if (!navigationsDefn || !navigationsDefn.length) return {warnings: []};
 
   /** @type {string[]} */
@@ -257,7 +248,7 @@ function assertArtifactTopologicalOrder(navigations) {
  * @return {{warnings: string[]}}
  */
 function assertValidConfig(resolvedConfig) {
-  const {warnings} = assertValidFRNavigations(resolvedConfig.navigations);
+  const {warnings} = assertValidNavigations(resolvedConfig.navigations);
 
   /** @type {Set<string>} */
   const artifactIds = new Set();
@@ -266,7 +257,7 @@ function assertValidConfig(resolvedConfig) {
       throw new Error(`Config defined multiple artifacts with id '${artifactDefn.id}'`);
     }
     artifactIds.add(artifactDefn.id);
-    assertValidFRGatherer(artifactDefn.gatherer);
+    assertValidArtifact(artifactDefn);
   }
 
   for (const auditDefn of resolvedConfig.audits || []) {
@@ -309,11 +300,10 @@ function throwInvalidArtifactDependency(artifactId, dependencyKey) {
 }
 
 export {
-  isFRGathererDefn,
   isValidArtifactDependency,
   assertValidPluginName,
-  assertValidFRGatherer,
-  assertValidFRNavigations,
+  assertValidArtifact,
+  assertValidNavigations,
   assertValidAudit,
   assertValidCategories,
   assertValidSettings,

package/core/gather/base-artifacts.d.ts

@@ -1,16 +1,16 @@
 /**
  * @param {LH.Config.ResolvedConfig} resolvedConfig
- * @param {LH.Gatherer.FRTransitionalDriver} driver
+ * @param {LH.Gatherer.Driver} driver
  * @param {{gatherMode: LH.Gatherer.GatherMode}} context
  * @return {Promise<LH.BaseArtifacts>}
  */
-export function getBaseArtifacts(resolvedConfig: LH.Config.ResolvedConfig, driver: LH.Gatherer.FRTransitionalDriver, context: {
+export function getBaseArtifacts(resolvedConfig: LH.Config.ResolvedConfig, driver: LH.Gatherer.Driver, context: {
     gatherMode: LH.Gatherer.GatherMode;
 }): Promise<LH.BaseArtifacts>;
 /**
- * @param {LH.FRBaseArtifacts} baseArtifacts
+ * @param {LH.BaseArtifacts} baseArtifacts
  * @param {Partial<LH.Artifacts>} gathererArtifacts
  * @return {LH.Artifacts}
  */
-export function finalizeArtifacts(baseArtifacts: LH.FRBaseArtifacts, gathererArtifacts: Partial<LH.Artifacts>): LH.Artifacts;
+export function finalizeArtifacts(baseArtifacts: LH.BaseArtifacts, gathererArtifacts: Partial<LH.Artifacts>): LH.Artifacts;
 //# sourceMappingURL=base-artifacts.d.ts.map

package/core/gather/base-artifacts.js

@@ -13,7 +13,7 @@ import {
 
 /**
  * @param {LH.Config.ResolvedConfig} resolvedConfig
- * @param {LH.Gatherer.FRTransitionalDriver} driver
+ * @param {LH.Gatherer.Driver} driver
  * @param {{gatherMode: LH.Gatherer.GatherMode}} context
  * @return {Promise<LH.BaseArtifacts>}
  */
@@ -38,10 +38,6 @@ async function getBaseArtifacts(resolvedConfig, driver, context) {
     },
     PageLoadError: null,
     GatherContext: context,
-    // Artifacts that have been replaced by regular gatherers in Fraggle Rock.
-    NetworkUserAgent: '',
-    traces: {},
-    devtoolsLogs: {},
   };
 }
 
@@ -63,7 +59,7 @@ function deduplicateWarnings(warnings) {
 }
 
 /**
- * @param {LH.FRBaseArtifacts} baseArtifacts
+ * @param {LH.BaseArtifacts} baseArtifacts
  * @param {Partial<LH.Artifacts>} gathererArtifacts
  * @return {LH.Artifacts}
  */