npm - lighthouse - Versions diffs - 10.2.0 → 10.3.0-dev.20230614 - Mend

lighthouse 10.2.0 → 10.3.0-dev.20230614

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (133) hide show

package/cli/test/smokehouse/__snapshots__/report-assert-test.js.snap +4 -6
package/core/audits/accessibility/html-xml-lang-mismatch.d.ts +10 -0
package/core/audits/accessibility/html-xml-lang-mismatch.js +47 -0
package/core/audits/accessibility/input-button-name.d.ts +10 -0
package/core/audits/accessibility/input-button-name.js +44 -0
package/core/audits/accessibility/table-fake-caption.d.ts +10 -0
package/core/audits/accessibility/table-fake-caption.js +47 -0
package/core/audits/accessibility/td-has-header.d.ts +10 -0
package/core/audits/accessibility/td-has-header.js +45 -0
package/core/audits/audit.d.ts +2 -1
package/core/audits/audit.js +5 -2
package/core/audits/byte-efficiency/byte-efficiency-audit.d.ts +3 -3
package/core/audits/byte-efficiency/byte-efficiency-audit.js +14 -19
package/core/audits/deprecations.js +1 -1
package/core/audits/largest-contentful-paint-element.d.ts +14 -2
package/core/audits/largest-contentful-paint-element.js +49 -31
package/core/audits/layout-shift-elements.d.ts +3 -2
package/core/audits/layout-shift-elements.js +10 -2
package/core/audits/metrics.js +0 -2
package/core/audits/network-requests.js +6 -0
package/core/audits/seo/crawlable-anchors.js +4 -0
package/core/audits/server-response-time.d.ts +2 -1
package/core/audits/server-response-time.js +17 -3
package/core/audits/uses-rel-preconnect.js +20 -4
package/core/computed/entity-classification.d.ts +14 -1
package/core/computed/entity-classification.js +61 -6
package/core/computed/metrics/cumulative-layout-shift.d.ts +2 -9
package/core/computed/metrics/cumulative-layout-shift.js +3 -16
package/core/computed/metrics/time-to-first-byte.js +10 -7
package/core/computed/metrics/timing-summary.js +0 -3
package/core/config/default-config.js +8 -0
package/core/gather/driver/execution-context.js +13 -5
package/core/gather/driver/target-manager.d.ts +13 -0
package/core/gather/driver/target-manager.js +49 -0
package/core/gather/gatherers/accessibility.js +19 -20
package/core/gather/gatherers/anchor-elements.js +2 -0
package/core/gather/gatherers/global-listeners.js +38 -21
package/core/gather/gatherers/inspector-issues.js +2 -1
package/core/gather/gatherers/trace-elements.d.ts +3 -2
package/core/gather/gatherers/trace-elements.js +10 -19
package/core/legacy/config/config.d.ts +1 -1
package/core/legacy/config/config.js +1 -1
package/core/legacy/gather/driver.d.ts +1 -0
package/core/legacy/gather/driver.js +11 -0
package/core/lib/asset-saver.d.ts +4 -0
package/core/lib/asset-saver.js +19 -0
package/core/lib/bf-cache-strings.d.ts +3 -0
package/core/lib/bf-cache-strings.js +248 -232
package/core/lib/cdt/generated/SourceMap.d.ts +18 -31
package/core/lib/cdt/generated/SourceMap.js +51 -101
package/core/lib/dependency-graph/simulator/network-analyzer.d.ts +6 -2
package/core/lib/dependency-graph/simulator/network-analyzer.js +45 -13
package/core/lib/deprecation-description.d.ts +17 -0
package/core/lib/deprecation-description.js +71 -0
package/core/lib/deprecations-strings.d.ts +282 -63
package/core/lib/deprecations-strings.js +282 -551
package/core/lib/lh-error.d.ts +9 -4
package/core/lib/lh-error.js +15 -11
package/core/lib/network-request.d.ts +13 -6
package/core/lib/network-request.js +39 -14
package/core/lib/stack-packs.js +4 -0
package/core/lib/tracehouse/trace-processor.js +1 -1
package/core/lib/url-utils.js +4 -0
package/core/runner.js +4 -2
package/dist/report/bundle.esm.js +24 -7
package/dist/report/flow.js +3 -3
package/dist/report/standalone.js +8 -8
package/package.json +13 -13
package/readme.md +7 -0
package/report/assets/styles.css +18 -2
package/report/assets/templates.html +4 -0
package/report/renderer/category-renderer.js +5 -2
package/report/renderer/components.js +2 -2
package/report/renderer/dom.d.ts +4 -1
package/report/renderer/dom.js +3 -2
package/shared/localization/locales/ar-XB.json +20 -170
package/shared/localization/locales/ar.json +20 -170
package/shared/localization/locales/bg.json +19 -169
package/shared/localization/locales/ca.json +19 -169
package/shared/localization/locales/cs.json +19 -169
package/shared/localization/locales/da.json +19 -169
package/shared/localization/locales/de.json +19 -169
package/shared/localization/locales/el.json +19 -169
package/shared/localization/locales/en-GB.json +9 -159
package/shared/localization/locales/en-US.json +166 -70
package/shared/localization/locales/en-XA.json +20 -170
package/shared/localization/locales/en-XL.json +166 -70
package/shared/localization/locales/es-419.json +19 -169
package/shared/localization/locales/es.json +19 -169
package/shared/localization/locales/fi.json +19 -169
package/shared/localization/locales/fil.json +17 -167
package/shared/localization/locales/fr.json +18 -168
package/shared/localization/locales/he.json +19 -169
package/shared/localization/locales/hi.json +20 -170
package/shared/localization/locales/hr.json +19 -169
package/shared/localization/locales/hu.json +19 -169
package/shared/localization/locales/id.json +19 -169
package/shared/localization/locales/it.json +19 -169
package/shared/localization/locales/ja.json +19 -169
package/shared/localization/locales/ko.json +19 -169
package/shared/localization/locales/lt.json +20 -170
package/shared/localization/locales/lv.json +20 -170
package/shared/localization/locales/nl.json +18 -168
package/shared/localization/locales/no.json +19 -169
package/shared/localization/locales/pl.json +19 -169
package/shared/localization/locales/pt-PT.json +19 -169
package/shared/localization/locales/pt.json +19 -169
package/shared/localization/locales/ro.json +19 -169
package/shared/localization/locales/ru.json +19 -169
package/shared/localization/locales/sk.json +20 -170
package/shared/localization/locales/sl.json +19 -169
package/shared/localization/locales/sr-Latn.json +19 -169
package/shared/localization/locales/sr.json +19 -169
package/shared/localization/locales/sv.json +19 -169
package/shared/localization/locales/ta.json +19 -169
package/shared/localization/locales/te.json +19 -169
package/shared/localization/locales/th.json +19 -169
package/shared/localization/locales/tr.json +19 -169
package/shared/localization/locales/uk.json +19 -169
package/shared/localization/locales/vi.json +20 -170
package/shared/localization/locales/zh-HK.json +19 -169
package/shared/localization/locales/zh-TW.json +19 -169
package/shared/localization/locales/zh.json +19 -169
package/shared/util.d.ts +6 -0
package/shared/util.js +14 -1
package/third-party/chromium-synchronization/inspector-issueAdded-types-test.js +2 -1
package/tsconfig-base.json +1 -1
package/types/artifacts.d.ts +10 -8
package/types/audit.d.ts +5 -0
package/types/gatherer.d.ts +1 -0
package/types/lhr/audit-details.d.ts +1 -0
package/types/lhr/audit-result.d.ts +10 -0
package/types/internal/es-main.d.ts +0 -18

package/cli/test/smokehouse/__snapshots__/report-assert-test.js.snap CHANGED Viewed

@@ -3,7 +3,7 @@
 exports[`getAssertionReport works (multiple failing) 1`] = `
 "X difference at cumulative-layout-shift audit.details.items.length
               expected: []
-                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444,\\"totalCumulativeLayoutShift\\":0.13570762803819444}]
+                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444}]
   X difference at cumulative-layout-shift audit.details.blah
@@ -24,8 +24,7 @@ exports[`getAssertionReport works (multiple failing) 1`] = `
           \\"type\\": \\"debugdata\\",
           \\"items\\": [
             {
-              \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444,
-              \\"totalCumulativeLayoutShift\\": 0.13570762803819444
+              \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444
             }
           ]
         }
@@ -35,7 +34,7 @@ exports[`getAssertionReport works (multiple failing) 1`] = `
 exports[`getAssertionReport works (trivial failing) 1`] = `
 "X difference at cumulative-layout-shift audit.details.items.length
               expected: []
-                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444,\\"totalCumulativeLayoutShift\\":0.13570762803819444}]
+                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444}]
           found result:
       {
@@ -51,8 +50,7 @@ exports[`getAssertionReport works (trivial failing) 1`] = `
           \\"type\\": \\"debugdata\\",
           \\"items\\": [
             {
-              \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444,
-              \\"totalCumulativeLayoutShift\\": 0.13570762803819444
+              \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444
             }
           ]
         }

package/core/audits/accessibility/html-xml-lang-mismatch.d.ts ADDED Viewed

@@ -0,0 +1,10 @@
+export default HTMLXMLLangMismatch;
+declare class HTMLXMLLangMismatch extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=html-xml-lang-mismatch.d.ts.map

package/core/audits/accessibility/html-xml-lang-mismatch.js ADDED Viewed

@@ -0,0 +1,47 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+/**
+ * @fileoverview Ensures that, if present, the `[xml:lang]` attribute value in an HTML document has
+ * the same base language as the `[lang]` attribute.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if the xml:lang attribute, if present, has the same base language as the `lang` attribute. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: '`<html>` element has an `[xml:lang]` attribute with the same base language as the ' +
+      '`[lang]` attribute.',
+  /** Title of an accesibility audit that evaluates if the xml:lang attribute, if present, has the same base language as the `lang` attribute. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: '`<html>` element does not have an `[xml:lang]` attribute with the same base ' +
+      'language as the `[lang]` attribute.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'If the webpage does not specify a consistent language, then the screen ' +
+      'reader might not announce the page\'s text correctly. ' +
+      '[Learn more about the `lang` attribute](https://dequeuniversity.com/rules/axe/4.7/html-xml-lang-mismatch).',
+};
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+class HTMLXMLLangMismatch extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'html-xml-lang-mismatch',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+export default HTMLXMLLangMismatch;
+export {UIStrings};

package/core/audits/accessibility/input-button-name.d.ts ADDED Viewed

@@ -0,0 +1,10 @@
+export default InputButtonName;
+declare class InputButtonName extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=input-button-name.d.ts.map

package/core/audits/accessibility/input-button-name.js ADDED Viewed

@@ -0,0 +1,44 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+/**
+ * @fileoverview Ensures input buttons have discernible text.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if all input buttons have discernible text. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Input buttons have discernible text.',
+  /** Title of an accesibility audit that evaluates if all input buttons have discernible text. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Input buttons do not have discernible text.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Adding discernable and accessible text to input buttons may help screen reader ' +
+      'users understand the purpose of the input button. ' +
+      '[Learn more about input buttons](https://dequeuniversity.com/rules/axe/4.7/input-button-name).',
+};
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+class InputButtonName extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'input-button-name',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+export default InputButtonName;
+export {UIStrings};

package/core/audits/accessibility/table-fake-caption.d.ts ADDED Viewed

@@ -0,0 +1,10 @@
+export default TableFakeCaption;
+declare class TableFakeCaption extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=table-fake-caption.d.ts.map

package/core/audits/accessibility/table-fake-caption.js ADDED Viewed

@@ -0,0 +1,47 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+/**
+ * @fileoverview Ensure that tables use `<caption>` instead of colspan for a caption.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if all tables use caption instead of colspan to indicate a caption. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Tables use `<caption>` instead of cells with the `[colspan]` attribute to indicate a ' +
+      'caption.',
+  /** Title of an accesibility audit that evaluates if all tables use caption instead of colspan to indicate a caption. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Tables do not use `<caption>` instead of cells with the `[colspan]` attribute ' +
+      'to indicate a caption.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
+      'that tables use the actual caption element instead of cells with the `[colspan]` ' +
+      'attribute may improve the experience for screen reader users. ' +
+      '[Learn more about captions](https://dequeuniversity.com/rules/axe/4.7/table-fake-caption).',
+};
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+class TableFakeCaption extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'table-fake-caption',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+export default TableFakeCaption;
+export {UIStrings};

package/core/audits/accessibility/td-has-header.d.ts ADDED Viewed

@@ -0,0 +1,10 @@
+export default TDHasHeader;
+declare class TDHasHeader extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=td-has-header.d.ts.map

package/core/audits/accessibility/td-has-header.js ADDED Viewed

@@ -0,0 +1,45 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+/**
+ * @fileoverview Ensure that large tables have `[header]` attributes.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if all large table elements use the headers HTML attribute. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: '`<td>` elements in a large `<table>` have one or more table headers.',
+  /** Title of an accesibility audit that evaluates if all large table elements use the headers HTML attribute. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: '`<td>` elements in a large `<table>` do not have table headers.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
+      'that `<td>` elements in a large table (3 or more cells in width and height) have an ' +
+      'associated table header may improve the experience for screen reader users. ' +
+      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.7/td-has-header).',
+};
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+class TDHasHeader extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'td-has-header',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+export default TDHasHeader;
+export {UIStrings};

package/core/audits/audit.d.ts CHANGED Viewed

@@ -149,9 +149,10 @@ export class Audit {
     /**
      * @param {typeof Audit} audit
      * @param {string | LH.IcuMessage} errorMessage
+     * @param {string=} errorStack
      * @return {LH.RawIcu<LH.Audit.Result>}
      */
-    static generateErrorAuditResult(audit: typeof Audit, errorMessage: string | LH.IcuMessage): LH.RawIcu<LH.Audit.Result>;
+    static generateErrorAuditResult(audit: typeof Audit, errorMessage: string | LH.IcuMessage, errorStack?: string | undefined): LH.RawIcu<LH.Audit.Result>;
     /**
      * @param {typeof Audit} audit
      * @param {LH.Audit.Product} product

package/core/audits/audit.js CHANGED Viewed

@@ -348,12 +348,14 @@ class Audit {
   /**
    * @param {typeof Audit} audit
    * @param {string | LH.IcuMessage} errorMessage
+   * @param {string=} errorStack
    * @return {LH.RawIcu<LH.Audit.Result>}
    */
-  static generateErrorAuditResult(audit, errorMessage) {
+  static generateErrorAuditResult(audit, errorMessage, errorStack) {
     return Audit.generateAuditResult(audit, {
       score: null,
       errorMessage,
+      errorStack,
     });
   }
@@ -371,7 +373,7 @@ class Audit {
     let scoreDisplayMode = audit.meta.scoreDisplayMode || Audit.SCORING_MODES.BINARY;
     // But override if product contents require it.
-    if (product.errorMessage) {
+    if (product.errorMessage !== undefined) {
       // Error result.
       scoreDisplayMode = Audit.SCORING_MODES.ERROR;
     } else if (product.notApplicable) {
@@ -407,6 +409,7 @@ class Audit {
       displayValue: product.displayValue,
       explanation: product.explanation,
       errorMessage: product.errorMessage,
+      errorStack: product.errorStack,
       warnings: product.warnings,
       details: product.details,

package/core/audits/byte-efficiency/byte-efficiency-audit.d.ts CHANGED Viewed

@@ -25,9 +25,9 @@ export type ByteEfficiencyProduct = {
  */
 export class ByteEfficiencyAudit extends Audit {
     /**
-     * Creates a score based on the wastedMs value using linear interpolation between control points.
-     * A negative wastedMs is scored as 1, assuming time is not being wasted with respect to the
-     * opportunity being measured.
+     * Creates a score based on the wastedMs value using log-normal distribution scoring. A negative
+     * wastedMs will be scored as 1, assuming time is not being wasted with respect to the opportunity
+     * being measured.
      *
      * @param {number} wastedMs
      * @return {number}

package/core/audits/byte-efficiency/byte-efficiency-audit.js CHANGED Viewed

@@ -5,7 +5,6 @@
  */
 import {Audit} from '../audit.js';
-import {linearInterpolation} from '../../lib/statistics.js';
 import {LanternInteractive} from '../../computed/metrics/lantern-interactive.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 import {NetworkRecords} from '../../computed/network-records.js';
@@ -17,9 +16,13 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, {});
 /** @typedef {import('../../lib/dependency-graph/simulator/simulator').Simulator} Simulator */
 /** @typedef {import('../../lib/dependency-graph/base-node.js').Node} Node */
-const WASTED_MS_FOR_AVERAGE = 300;
-const WASTED_MS_FOR_POOR = 750;
-const WASTED_MS_FOR_SCORE_OF_ZERO = 5000;
+// Parameters for log-normal distribution scoring. These values were determined by fitting the
+// log-normal cumulative distribution function curve to the former method of linear interpolation
+// scoring between the control points {average = 300 ms, poor = 750 ms, zero = 5000 ms} using the
+// curve-fit tool at https://mycurvefit.com/ rounded to the nearest integer. See
+// https://www.desmos.com/calculator/gcexiyesdi for an interactive visualization of the curve fit.
+const WASTED_MS_P10 = 150;
+const WASTED_MS_MEDIAN = 935;
 /**
  * @typedef {object} ByteEfficiencyProduct
@@ -38,26 +41,18 @@ const WASTED_MS_FOR_SCORE_OF_ZERO = 5000;
  */
 class ByteEfficiencyAudit extends Audit {
   /**
-   * Creates a score based on the wastedMs value using linear interpolation between control points.
-   * A negative wastedMs is scored as 1, assuming time is not being wasted with respect to the
-   * opportunity being measured.
+   * Creates a score based on the wastedMs value using log-normal distribution scoring. A negative
+   * wastedMs will be scored as 1, assuming time is not being wasted with respect to the opportunity
+   * being measured.
    *
    * @param {number} wastedMs
    * @return {number}
    */
   static scoreForWastedMs(wastedMs) {
-    if (wastedMs <= 0) {
-      return 1;
-    } else if (wastedMs < WASTED_MS_FOR_AVERAGE) {
-      return linearInterpolation(0, 1, WASTED_MS_FOR_AVERAGE, 0.75, wastedMs);
-    } else if (wastedMs < WASTED_MS_FOR_POOR) {
-      return linearInterpolation(WASTED_MS_FOR_AVERAGE, 0.75, WASTED_MS_FOR_POOR, 0.5, wastedMs);
-    } else {
-      return Math.max(
-        0,
-        linearInterpolation(WASTED_MS_FOR_POOR, 0.5, WASTED_MS_FOR_SCORE_OF_ZERO, 0, wastedMs)
-      );
-    }
+    return Audit.computeLogNormalScore(
+      {p10: WASTED_MS_P10, median: WASTED_MS_MEDIAN},
+      wastedMs
+    );
   }
   /**

package/core/audits/deprecations.js CHANGED Viewed

@@ -11,7 +11,7 @@
 import {Audit} from './audit.js';
 import {JSBundles} from '../computed/js-bundles.js';
 import * as i18n from '../lib/i18n/i18n.js';
-import {getIssueDetailDescription} from '../lib/deprecations-strings.js';
+import {getIssueDetailDescription} from '../lib/deprecation-description.js';
 /* eslint-disable max-len */
 const UIStrings = {

package/core/audits/largest-contentful-paint-element.d.ts CHANGED Viewed

@@ -1,11 +1,23 @@
 export default LargestContentfulPaintElement;
 declare class LargestContentfulPaintElement extends Audit {
+    /**
+     * @param {LH.Artifacts.MetricComputationDataInput} metricComputationData
+     * @param {LH.Audit.Context} context
+     * @return {Promise<number|undefined>}
+     */
+    static getOptionalLCPMetric(metricComputationData: LH.Artifacts.MetricComputationDataInput, context: LH.Audit.Context): Promise<number | undefined>;
     /**
      * @param {LH.Artifacts} artifacts
+     * @return {LH.Audit.Details.Table|undefined}
+     */
+    static makeElementTable(artifacts: LH.Artifacts): LH.Audit.Details.Table | undefined;
+    /**
+     * @param {number} metricLcp
+     * @param {LH.Artifacts.MetricComputationDataInput} metricComputationData
      * @param {LH.Audit.Context} context
-     * @return {Promise<LH.Audit.Details.Table|undefined>}
+     * @return {Promise<LH.Audit.Details.Table>}
      */
-    static makePhaseTable(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Details.Table | undefined>;
+    static makePhaseTable(metricLcp: number, metricComputationData: LH.Artifacts.MetricComputationDataInput, context: LH.Audit.Context): Promise<LH.Audit.Details.Table>;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/largest-contentful-paint-element.js CHANGED Viewed

@@ -50,19 +50,44 @@ class LargestContentfulPaintElement extends Audit {
   }
   /**
-   * @param {LH.Artifacts} artifacts
+   * @param {LH.Artifacts.MetricComputationDataInput} metricComputationData
    * @param {LH.Audit.Context} context
-   * @return {Promise<LH.Audit.Details.Table|undefined>}
+   * @return {Promise<number|undefined>}
    */
-  static async makePhaseTable(artifacts, context) {
-    const trace = artifacts.traces[Audit.DEFAULT_PASS];
-    const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
-    const gatherContext = artifacts.GatherContext;
-    const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+  static async getOptionalLCPMetric(metricComputationData, context) {
+    try {
+      const {timing: metricLcp} =
+        await LargestContentfulPaint.request(metricComputationData, context);
+      return metricLcp;
+    } catch {}
+  }
+  /**
+   * @param {LH.Artifacts} artifacts
+   * @return {LH.Audit.Details.Table|undefined}
+   */
+  static makeElementTable(artifacts) {
+    const lcpElement = artifacts.TraceElements
+      .find(element => element.traceEventType === 'largest-contentful-paint');
+    if (!lcpElement) return;
+    /** @type {LH.Audit.Details.Table['headings']} */
+    const headings = [
+      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
+    ];
-    const {timing: metricLcp} =
-      await LargestContentfulPaint.request(metricComputationData, context);
+    const lcpElementDetails = [{node: Audit.makeNodeItem(lcpElement.node)}];
+    return Audit.makeTableDetails(headings, lcpElementDetails);
+  }
+  /**
+   * @param {number} metricLcp
+   * @param {LH.Artifacts.MetricComputationDataInput} metricComputationData
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Details.Table>}
+   */
+  static async makePhaseTable(metricLcp, metricComputationData, context) {
     const {ttfb, loadStart, loadEnd} = await LCPBreakdown.request(metricComputationData, context);
     let loadDelay = 0;
@@ -102,36 +127,29 @@ class LargestContentfulPaintElement extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const lcpElement = artifacts.TraceElements
-      .find(element => element.traceEventType === 'largest-contentful-paint');
-    const lcpElementDetails = [];
-    if (lcpElement) {
-      lcpElementDetails.push({
-        node: Audit.makeNodeItem(lcpElement.node),
-      });
-    }
-    /** @type {LH.Audit.Details.Table['headings']} */
-    const headings = [
-      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
-    ];
+    const trace = artifacts.traces[Audit.DEFAULT_PASS];
+    const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
+    const gatherContext = artifacts.GatherContext;
+    const metricComputationData = {trace, devtoolsLog, gatherContext,
+      settings: context.settings, URL: artifacts.URL};
-    const elementTable = Audit.makeTableDetails(headings, lcpElementDetails);
+    const elementTable = this.makeElementTable(artifacts);
+    if (!elementTable) return {score: null, notApplicable: true};
     const items = [elementTable];
-    if (elementTable.items.length) {
-      const phaseTable = await this.makePhaseTable(artifacts, context);
-      if (phaseTable) items.push(phaseTable);
+    let displayValue;
+    const metricLcp = await this.getOptionalLCPMetric(metricComputationData, context);
+    if (metricLcp) {
+      displayValue = str_(i18n.UIStrings.ms, {timeInMs: metricLcp});
+      const phaseTable = await this.makePhaseTable(metricLcp, metricComputationData, context);
+      items.push(phaseTable);
     }
     const details = Audit.makeListDetails(items);
-    const displayValue = str_(i18n.UIStrings.displayValueElementsFound,
-      {nodeCount: lcpElementDetails.length});
     return {
       score: 1,
-      notApplicable: lcpElementDetails.length === 0,
       displayValue,
       details,
     };

package/core/audits/layout-shift-elements.d.ts CHANGED Viewed

@@ -2,9 +2,10 @@ export default LayoutShiftElements;
 declare class LayoutShiftElements extends Audit {
     /**
      * @param {LH.Artifacts} artifacts
-     * @return {LH.Audit.Product}
+     * @param {LH.Audit.Context} context
+     * @return {Promise<LH.Audit.Product>}
      */
-    static audit(artifacts: LH.Artifacts): LH.Audit.Product;
+    static audit(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Product>;
 }
 export namespace UIStrings {
     const title: string;

package/core/audits/layout-shift-elements.js CHANGED Viewed

@@ -6,6 +6,7 @@
 import {Audit} from './audit.js';
 import * as i18n from '../lib/i18n/i18n.js';
+import {CumulativeLayoutShift} from '../computed/metrics/cumulative-layout-shift.js';
 const UIStrings = {
   /** Descriptive title of a diagnostic audit that provides up to the top five elements contributing to Cumulative Layout Shift. */
@@ -34,9 +35,10 @@ class LayoutShiftElements extends Audit {
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
+  static async audit(artifacts, context) {
     const clsElements = artifacts.TraceElements
       .filter(element => element.traceEventType === 'layout-shift');
@@ -61,8 +63,14 @@ class LayoutShiftElements extends Audit {
         {nodeCount: clsElementData.length});
     }
+    const {cumulativeLayoutShift: clsSavings} =
+      await CumulativeLayoutShift.request(artifacts.traces[Audit.DEFAULT_PASS], context);
     return {
       score: 1,
+      metricSavings: {
+        CLS: clsSavings,
+      },
       notApplicable: details.items.length === 0,
       displayValue,
       details,

package/core/audits/metrics.js CHANGED Viewed

@@ -11,10 +11,8 @@ import {TimingSummary} from '../computed/metrics/timing-summary.js';
 const DECIMAL_METRIC_KEYS = new Set([
   'cumulativeLayoutShift',
   'cumulativeLayoutShiftMainFrame',
-  'totalCumulativeLayoutShift',
   'observedCumulativeLayoutShift',
   'observedCumulativeLayoutShiftMainFrame',
-  'observedTotalCumulativeLayoutShift',
 ]);
 class Metrics extends Audit {

package/core/audits/network-requests.js CHANGED Viewed

@@ -8,6 +8,7 @@ import {Audit} from './audit.js';
 import UrlUtils from '../lib/url-utils.js';
 import {NetworkRecords} from '../computed/network-records.js';
 import {MainResource} from '../computed/main-resource.js';
+import {EntityClassification} from '../computed/entity-classification.js';
 class NetworkRequests extends Audit {
   /**
@@ -31,6 +32,8 @@ class NetworkRequests extends Audit {
   static async audit(artifacts, context) {
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const records = await NetworkRecords.request(devtoolsLog, context);
+    const classifiedEntities = await EntityClassification.request(
+      {URL: artifacts.URL, devtoolsLog}, context);
     const earliestRendererStartTime = records.reduce(
       (min, record) => Math.min(min, record.rendererStartTime),
       Infinity
@@ -61,6 +64,8 @@ class NetworkRequests extends Audit {
         ((record.frameId === mainFrameId) || undefined) :
         undefined;
+      const entity = classifiedEntities.entityByUrl.get(record.url);
       return {
         url: UrlUtils.elideDataURI(record.url),
         sessionTargetType: record.sessionTargetType,
@@ -77,6 +82,7 @@ class NetworkRequests extends Audit {
         priority: record.priority,
         isLinkPreload,
         experimentalFromMainFrame,
+        entity: entity?.name,
         lrEndTimeDeltaMs: endTimeDeltaMs, // Only exists on Lightrider runs
         lrTCPMs: TCPMs, // Only exists on Lightrider runs
         lrRequestMs: requestMs, // Only exists on Lightrider runs

package/core/audits/seo/crawlable-anchors.js CHANGED Viewed

@@ -43,6 +43,7 @@ class CrawlableAnchors extends Audit {
       rawHref,
       name = '',
       role = '',
+      id,
     }) => {
       rawHref = rawHref.replace( /\s/g, '');
       name = name.trim();
@@ -52,6 +53,9 @@ class CrawlableAnchors extends Audit {
       // Ignore mailto links even if they use one of the failing patterns. See https://github.com/GoogleChrome/lighthouse/issues/11443#issuecomment-694898412
       if (rawHref.startsWith('mailto:')) return;
+      // Ignore `<a id="something">` elements acting as an anchor.
+      if (rawHref === '' && id) return;
       const javaScriptVoidRegExp = /javascript:void(\(|)0(\)|)/;
       if (rawHref.startsWith('file:')) return true;