iobroker.poolcontrol 1.2.0 → 1.2.1

package/lib/stateDefinitions/statisticsStates.js

@@ -20,43 +20,67 @@
  * @param {ioBroker.Adapter} adapter - Instanz des ioBroker-Adapters
  */
 async function createStatisticsStates(adapter) {
-    adapter.log.debug('statisticsStates: Initialisierung der Temperaturstatistiken gestartet.');
+    adapter.log.debug('statisticsStates: Temperature statistics initialization started.');
 
     // Oberstruktur
     await adapter.setObjectNotExistsAsync('analytics', {
         type: 'channel',
-        common: { name: 'Analysen & Auswertungen (Statistik, Historie, Berichte)' },
+        common: {
+            name: {
+                de: 'Analysen & Auswertungen (Statistik, Historie, Berichte)',
+                en: 'Analytics & insights (statistics, history, reports)',
+            },
+        },
         native: {},
     });
 
     await adapter.setObjectNotExistsAsync('analytics.statistics', {
         type: 'channel',
-        common: { name: 'Statistische Auswertungen' },
+        common: {
+            name: {
+                de: 'Statistische Auswertungen',
+                en: 'Statistical evaluations',
+            },
+        },
         native: {},
     });
 
     await adapter.setObjectNotExistsAsync('analytics.statistics.temperature', {
         type: 'channel',
-        common: { name: 'Temperaturstatistik' },
+        common: {
+            name: {
+                de: 'Temperaturstatistik',
+                en: 'Temperature statistics',
+            },
+        },
         native: {},
     });
 
     // -------------------------------------------------------------
     // 🔹 TAGESSTATISTIK
     // -------------------------------------------------------------
-    await _createTemperatureStatsGroup(adapter, 'today', 'Tagesstatistik (Temperaturen)');
+    await _createTemperatureStatsGroup(adapter, 'today', {
+        de: 'Tagesstatistik (Temperaturen)',
+        en: 'Daily statistics (temperatures)',
+    });
 
     // -------------------------------------------------------------
     // 🔹 WOCHENSTATISTIK
     // -------------------------------------------------------------
-    await _createTemperatureStatsGroup(adapter, 'week', 'Wochenstatistik (Temperaturen)');
+    await _createTemperatureStatsGroup(adapter, 'week', {
+        de: 'Wochenstatistik (Temperaturen)',
+        en: 'Weekly statistics (temperatures)',
+    });
 
     // -------------------------------------------------------------
     // 🔹 MONATSSTATISTIK (NEU)
     // -------------------------------------------------------------
-    await _createTemperatureStatsGroup(adapter, 'month', 'Monatsstatistik (Temperaturen)');
+    await _createTemperatureStatsGroup(adapter, 'month', {
+        de: 'Monatsstatistik (Temperaturen)',
+        en: 'Monthly statistics (temperatures)',
+    });
 
-    adapter.log.debug('statisticsStates: Tages-, Wochen- und Monatsstatistik (Temperatur) erfolgreich angelegt.');
+    adapter.log.debug('statisticsStates: Daily, weekly and monthly temperature statistics created successfully.');
 }
 
 /**
@@ -64,7 +88,7 @@ async function createStatisticsStates(adapter) {
  *
  * @param {ioBroker.Adapter} adapter - Aktive ioBroker-Adapterinstanz
  * @param {string} periodId - z. B. "today", "week" oder "month"
- * @param {string} displayName - Anzeigename im Objektbaum
+ * @param {{de: string, en: string}} displayName - Anzeigename im Objektbaum (DE/EN)
  */
 async function _createTemperatureStatsGroup(adapter, periodId, displayName) {
     const basePathRoot = `analytics.statistics.temperature.${periodId}`;
@@ -76,39 +100,82 @@ async function _createTemperatureStatsGroup(adapter, periodId, displayName) {
 
     // Definierte Sensoren
     const sensors = [
-        { id: 'outside', name: 'Außentemperatur' },
-        { id: 'ground', name: 'Bodentemperatur' },
-        { id: 'surface', name: 'Pooloberfläche' },
-        { id: 'flow', name: 'Vorlauf' },
-        { id: 'return', name: 'Rücklauf' },
-        { id: 'collector', name: 'Kollektor (Solar)' },
+        { id: 'outside', name: { de: 'Außentemperatur', en: 'Outside temperature' } },
+        { id: 'ground', name: { de: 'Bodentemperatur', en: 'Ground temperature' } },
+        { id: 'surface', name: { de: 'Pooloberfläche', en: 'Pool surface' } },
+        { id: 'flow', name: { de: 'Vorlauf', en: 'Flow' } },
+        { id: 'return', name: { de: 'Rücklauf', en: 'Return' } },
+        { id: 'collector', name: { de: 'Kollektor (Solar)', en: 'Collector (solar)' } },
     ];
 
     for (const sensor of sensors) {
         const basePath = `${basePathRoot}.${sensor.id}`;
         await adapter.setObjectNotExistsAsync(basePath, {
             type: 'channel',
-            common: { name: `${sensor.name} (${displayName})` },
+            common: {
+                name: {
+                    de: `${sensor.name.de} (${displayName.de})`,
+                    en: `${sensor.name.en} (${displayName.en})`,
+                },
+            },
             native: {},
         });
 
         const stateDefs = [
-            { id: 'temp_min', name: 'Niedrigste Temperatur', type: 'number', role: 'value.temperature', unit: '°C' },
-            { id: 'temp_max', name: 'Höchste Temperatur', type: 'number', role: 'value.temperature', unit: '°C' },
-            { id: 'temp_min_time', name: 'Zeitpunkt Minimum', type: 'string', role: 'value.time' },
-            { id: 'temp_max_time', name: 'Zeitpunkt Maximum', type: 'string', role: 'value.time' },
-            { id: 'temp_avg', name: 'Durchschnittstemperatur', type: 'number', role: 'value.temperature', unit: '°C' },
-            { id: 'data_points_count', name: 'Anzahl Messwerte', type: 'number', role: 'value' },
-            { id: 'last_update', name: 'Letzte Aktualisierung', type: 'string', role: 'value.time' },
+            {
+                id: 'temp_min',
+                name: { de: 'Niedrigste Temperatur', en: 'Lowest temperature' },
+                type: 'number',
+                role: 'value.temperature',
+                unit: '°C',
+            },
+            {
+                id: 'temp_max',
+                name: { de: 'Höchste Temperatur', en: 'Highest temperature' },
+                type: 'number',
+                role: 'value.temperature',
+                unit: '°C',
+            },
+            {
+                id: 'temp_min_time',
+                name: { de: 'Zeitpunkt Minimum', en: 'Time of minimum' },
+                type: 'string',
+                role: 'value.time',
+            },
+            {
+                id: 'temp_max_time',
+                name: { de: 'Zeitpunkt Maximum', en: 'Time of maximum' },
+                type: 'string',
+                role: 'value.time',
+            },
+            {
+                id: 'temp_avg',
+                name: { de: 'Durchschnittstemperatur', en: 'Average temperature' },
+                type: 'number',
+                role: 'value.temperature',
+                unit: '°C',
+            },
+            {
+                id: 'data_points_count',
+                name: { de: 'Anzahl Messwerte', en: 'Number of values' },
+                type: 'number',
+                role: 'value',
+            },
+            {
+                id: 'last_update',
+                name: { de: 'Letzte Aktualisierung', en: 'Last update' },
+                type: 'string',
+                role: 'value.time',
+            },
             {
                 id: 'summary_json',
-                name: `${displayName} (JSON)`,
+                name: { de: `${displayName.de} (JSON)`, en: `${displayName.en} (JSON)` },
                 type: 'string',
                 role: 'json',
             },
             {
                 id: 'summary_html',
-                name: `${displayName} (HTML)`,
+                name: { de: `${displayName.de} (HTML)`, en: `${displayName.en} (HTML)` },
                 type: 'string',
                 role: 'html',
             },
@@ -118,7 +185,7 @@ async function _createTemperatureStatsGroup(adapter, periodId, displayName) {
         if (periodId === 'today') {
             stateDefs.push({
                 id: 'reset_today',
-                name: 'Tagesstatistik zurücksetzen',
+                name: { de: 'Tagesstatistik zurücksetzen', en: 'Reset daily statistics' },
                 type: 'boolean',
                 role: 'button',
             });
@@ -146,19 +213,30 @@ async function _createTemperatureStatsGroup(adapter, periodId, displayName) {
     const outputBase = `${basePathRoot}.outputs`;
     await adapter.setObjectNotExistsAsync(outputBase, {
         type: 'channel',
-        common: { name: 'Gesamtausgaben (alle Sensoren)' },
+        common: {
+            name: {
+                de: 'Gesamtausgaben (alle Sensoren)',
+                en: 'Overall outputs (all sensors)',
+            },
+        },
         native: {},
     });
 
     const outputs = [
         {
             id: 'summary_all_json',
-            name: `Gesamtzusammenfassung aller Sensoren (${displayName}, JSON)`,
+            name: {
+                de: `Gesamtzusammenfassung aller Sensoren (${displayName.de}, JSON)`,
+                en: `Overall summary of all sensors (${displayName.en}, JSON)`,
+            },
             role: 'json',
         },
         {
             id: 'summary_all_html',
-            name: `Gesamtzusammenfassung aller Sensoren (${displayName}, HTML)`,
+            name: {
+                de: `Gesamtzusammenfassung aller Sensoren (${displayName.de}, HTML)`,
+                en: `Overall summary of all sensors (${displayName.en}, HTML)`,
+            },
             role: 'html',
         },
     ];

package/lib/stateDefinitions/statusStates.js

@@ -20,7 +20,9 @@ async function createStatusStates(adapter) {
     // Root-Kanal "status"
     await adapter.setObjectNotExistsAsync('status', {
         type: 'channel',
-        common: { name: 'Statusübersicht' },
+        common: {
+            name: { de: 'Statusübersicht', en: 'Status overview' },
+        },
         native: {},
     });
 
@@ -28,7 +30,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.summary', {
         type: 'state',
         common: {
-            name: 'Zusammenfassung als Text',
+            name: { de: 'Zusammenfassung als Text', en: 'Summary as text' },
             type: 'string',
             role: 'text',
             read: true,
@@ -43,7 +45,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.overview_json', {
         type: 'state',
         common: {
-            name: 'Übersicht als JSON',
+            name: { de: 'Übersicht als JSON', en: 'Overview as JSON' },
             type: 'string',
             role: 'json',
             read: true,
@@ -57,7 +59,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.last_summary_update', {
         type: 'state',
         common: {
-            name: 'Letzte Aktualisierung der Zusammenfassung',
+            name: { de: 'Letzte Aktualisierung der Zusammenfassung', en: 'Last summary update' },
             type: 'string',
             role: 'date',
             read: true,
@@ -71,7 +73,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.pump_last_start', {
         type: 'state',
         common: {
-            name: 'Letzter Pumpenstart',
+            name: { de: 'Letzter Pumpenstart', en: 'Last pump start' },
             type: 'string',
             role: 'date',
             read: true,
@@ -86,7 +88,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.pump_last_stop', {
         type: 'state',
         common: {
-            name: 'Letztes Pumpenende',
+            name: { de: 'Letztes Pumpenende', en: 'Last pump stop' },
             type: 'string',
             role: 'date',
             read: true,
@@ -101,7 +103,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.pump_was_on_today', {
         type: 'state',
         common: {
-            name: 'Pumpe war heute eingeschaltet',
+            name: { de: 'Pumpe war heute eingeschaltet', en: 'Pump was on today' },
             type: 'boolean',
             role: 'indicator',
             read: true,
@@ -116,7 +118,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.pump_today_count', {
         type: 'state',
         common: {
-            name: 'Pumpenstarts heute',
+            name: { de: 'Pumpenstarts heute', en: 'Pump starts today' },
             type: 'number',
             role: 'value',
             read: true,
@@ -131,7 +133,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.system_ok', {
         type: 'state',
         common: {
-            name: 'System OK',
+            name: { de: 'System OK', en: 'System OK' },
             type: 'boolean',
             role: 'indicator',
             read: true,
@@ -145,7 +147,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.system_warning', {
         type: 'state',
         common: {
-            name: 'System-Warnung aktiv',
+            name: { de: 'System-Warnung aktiv', en: 'System warning active' },
             type: 'boolean',
             role: 'indicator',
             read: true,
@@ -159,7 +161,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.system_warning_text', {
         type: 'state',
         common: {
-            name: 'Beschreibung der Systemwarnung',
+            name: { de: 'Beschreibung der Systemwarnung', en: 'System warning description' },
             type: 'string',
             role: 'text',
             read: true,
@@ -173,7 +175,7 @@ async function createStatusStates(adapter) {
     await adapter.setObjectNotExistsAsync('status.season_active', {
         type: 'state',
         common: {
-            name: 'Poolsaison aktiv',
+            name: { de: 'Poolsaison aktiv', en: 'Pool season active' },
             type: 'boolean',
             role: 'switch',
             read: true,

package/lib/stateDefinitions/temperatureStates.js

@@ -24,14 +24,18 @@ async function createTemperatureStates(adapter) {
     // Root-Kanal (robustheitshalber explizit anlegen)
     await adapter.setObjectNotExistsAsync('temperature', {
         type: 'channel',
-        common: { name: 'Temperaturverwaltung' },
+        common: {
+            name: { de: 'Temperaturverwaltung', en: 'Temperature management' },
+        },
         native: {},
     });
 
     // Kanal für Deltas
     await adapter.setObjectNotExistsAsync('temperature.delta', {
         type: 'channel',
-        common: { name: 'Temperatur-Differenzen' },
+        common: {
+            name: { de: 'Temperatur-Differenzen', en: 'Temperature deltas' },
+        },
         native: {},
     });
 
@@ -41,7 +45,7 @@ async function createTemperatureStates(adapter) {
         await adapter.setObjectNotExistsAsync(`temperature.${sensorKey}_temp_active`, {
             type: 'state',
             common: {
-                name: `Sensor ${label} verwenden`,
+                name: { de: `Sensor ${label} verwenden`, en: `Use sensor ${label}` },
                 type: 'boolean',
                 role: 'switch',
                 read: true,
@@ -57,7 +61,7 @@ async function createTemperatureStates(adapter) {
         await adapter.setObjectNotExistsAsync(`temperature.${sensorKey}_temp_sensor`, {
             type: 'state',
             common: {
-                name: `Objekt-ID Sensor ${label}`,
+                name: { de: `Objekt-ID Sensor ${label}`, en: `Object ID sensor ${label}` },
                 type: 'string',
                 role: 'text',
                 read: true,
@@ -73,14 +77,16 @@ async function createTemperatureStates(adapter) {
         // 2) Messkanal + Werte-States
         await adapter.setObjectNotExistsAsync(`temperature.${sensorKey}`, {
             type: 'channel',
-            common: { name: `Sensor ${label}` },
+            common: {
+                name: { de: `Sensor ${label}`, en: `Sensor ${label}` },
+            },
             native: {},
         });
 
         await adapter.setObjectNotExistsAsync(`temperature.${sensorKey}.current`, {
             type: 'state',
             common: {
-                name: `Aktueller Wert Sensor ${label}`,
+                name: { de: `Aktueller Wert Sensor ${label}`, en: `Current value sensor ${label}` },
                 type: 'number',
                 role: 'value.temperature',
                 unit: '°C',
@@ -93,7 +99,7 @@ async function createTemperatureStates(adapter) {
         await adapter.setObjectNotExistsAsync(`temperature.${sensorKey}.min_today`, {
             type: 'state',
             common: {
-                name: `Tagesminimum Sensor ${label}`,
+                name: { de: `Tagesminimum Sensor ${label}`, en: `Daily minimum sensor ${label}` },
                 type: 'number',
                 role: 'value.temperature',
                 unit: '°C',
@@ -107,7 +113,7 @@ async function createTemperatureStates(adapter) {
         await adapter.setObjectNotExistsAsync(`temperature.${sensorKey}.max_today`, {
             type: 'state',
             common: {
-                name: `Tagesmaximum Sensor ${label}`,
+                name: { de: `Tagesmaximum Sensor ${label}`, en: `Daily maximum sensor ${label}` },
                 type: 'number',
                 role: 'value.temperature',
                 unit: '°C',
@@ -121,7 +127,7 @@ async function createTemperatureStates(adapter) {
         await adapter.setObjectNotExistsAsync(`temperature.${sensorKey}.delta_per_hour`, {
             type: 'state',
             common: {
-                name: `Veränderung pro Stunde Sensor ${label}`,
+                name: { de: `Veränderung pro Stunde Sensor ${label}`, en: `Change per hour sensor ${label}` },
                 type: 'number',
                 role: 'value.temperature',
                 unit: '°C/h',
@@ -144,7 +150,7 @@ async function createTemperatureStates(adapter) {
     await adapter.setObjectNotExistsAsync('temperature.delta.collector_outside', {
         type: 'state',
         common: {
-            name: 'Differenz Kollektor - Luft',
+            name: { de: 'Differenz Kollektor - Luft', en: 'Delta collector - air' },
             type: 'number',
             role: 'value.temperature',
             unit: '°C',
@@ -157,7 +163,7 @@ async function createTemperatureStates(adapter) {
     await adapter.setObjectNotExistsAsync('temperature.delta.surface_ground', {
         type: 'state',
         common: {
-            name: 'Differenz Oberfläche - Grund',
+            name: { de: 'Differenz Oberfläche - Grund', en: 'Delta surface - ground' },
             type: 'number',
             role: 'value.temperature',
             unit: '°C',
@@ -170,7 +176,7 @@ async function createTemperatureStates(adapter) {
     await adapter.setObjectNotExistsAsync('temperature.delta.flow_return', {
         type: 'state',
         common: {
-            name: 'Differenz Vorlauf - Rücklauf',
+            name: { de: 'Differenz Vorlauf - Rücklauf', en: 'Delta flow - return' },
             type: 'number',
             role: 'value.temperature',
             unit: '°C',

package/lib/stateDefinitions/timeStates.js

@@ -13,7 +13,7 @@ async function createTimeStates(adapter) {
     await adapter.setObjectNotExistsAsync('timecontrol', {
         type: 'channel',
         common: {
-            name: 'Zeitsteuerung',
+            name: { de: 'Zeitsteuerung', en: 'Time control' },
         },
         native: {},
     });
@@ -23,7 +23,7 @@ async function createTimeStates(adapter) {
         await adapter.setObjectNotExistsAsync(`timecontrol.${prefix}_active`, {
             type: 'state',
             common: {
-                name: `Zeitfenster ${label} aktiv`,
+                name: { de: `Zeitfenster ${label} aktiv`, en: `Time window ${label} active` },
                 type: 'boolean',
                 role: 'switch',
                 read: true,
@@ -40,7 +40,7 @@ async function createTimeStates(adapter) {
         await adapter.setObjectNotExistsAsync(`timecontrol.${prefix}_start`, {
             type: 'state',
             common: {
-                name: `Zeitfenster ${label} Start (HH:MM)`,
+                name: { de: `Zeitfenster ${label} Start (HH:MM)`, en: `Time window ${label} start (HH:MM)` },
                 type: 'string',
                 role: 'value.time',
                 read: true,
@@ -57,7 +57,7 @@ async function createTimeStates(adapter) {
         await adapter.setObjectNotExistsAsync(`timecontrol.${prefix}_end`, {
             type: 'state',
             common: {
-                name: `Zeitfenster ${label} Ende (HH:MM)`,
+                name: { de: `Zeitfenster ${label} Ende (HH:MM)`, en: `Time window ${label} end (HH:MM)` },
                 type: 'string',
                 role: 'value.time',
                 read: true,
@@ -85,7 +85,7 @@ async function createTimeStates(adapter) {
             await adapter.setObjectNotExistsAsync(`timecontrol.${prefix}_day_${key}`, {
                 type: 'state',
                 common: {
-                    name: `Zeitfenster ${label} ${labelDay}`,
+                    name: { de: `Zeitfenster ${label} ${labelDay}`, en: `Time window ${label} ${labelDay}` },
                     type: 'boolean',
                     role: 'switch',
                     read: true,

package/main.js

@@ -62,11 +62,32 @@ class Poolcontrol extends utils.Adapter {
             ...options,
             name: 'poolcontrol',
         });
+
         this.on('ready', this.onReady.bind(this));
         this.on('stateChange', this.onStateChange.bind(this));
         this.on('unload', this.onUnload.bind(this));
     }
 
+    // FIX: Determine whether an own state is writable (command-like). Cached for performance.
+    async _isWritableOwnState(id) {
+        this._ackWritableCache = this._ackWritableCache || new Map();
+
+        if (this._ackWritableCache.has(id)) {
+            return this._ackWritableCache.get(id);
+        }
+
+        try {
+            const obj = await this.getObjectAsync(id);
+            const isWritable = !!obj?.common?.write;
+            this._ackWritableCache.set(id, isWritable);
+            return isWritable;
+        } catch {
+            // If we cannot read the object, play safe: do NOT filter it out.
+            this._ackWritableCache.set(id, false);
+            return false;
+        }
+    }
+
     async onReady() {
         this.log.info('Adapter gestartet');
 
@@ -250,6 +271,23 @@ class Poolcontrol extends utils.Adapter {
             this.log.debug(`state ${id} deleted`);
         }
 
+        // FIX: ignore deleted states completely
+        if (!state) {
+            return;
+        }
+
+        const isOwnState = id.startsWith(`${this.namespace}.`);
+
+        // ACK handling guard (own states)
+        // - ignore ack=true for OWN writeable states (commands)
+        // - still allow ack=true for read-only OWN states (status/live values)
+        if (isOwnState && state.ack === true) {
+            const isWritable = await this._isWritableOwnState(id);
+            if (isWritable) {
+                return;
+            }
+        }
+
         // Saisonstatus manuell ändern (z.B. über VIS)
         if (id.endsWith('status.season_active') && state && state.ack === false) {
             this.log.info(`[main] Saisonstatus geändert: ${state.val}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.poolcontrol",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Steuerung & Automatisierung für den Pool (Pumpe, Heizung, Ventile, Sensoren).",
   "author": "DasBo1975 <dasbo1975@outlook.de>",
   "homepage": "https://github.com/DasBo1975/ioBroker.poolcontrol",
@@ -24,15 +24,14 @@
     "@iobroker/adapter-core": "^3.3.2"
   },
   "devDependencies": {
-    "@alcalzone/release-script": "^4.0.0",
+    "@alcalzone/release-script": "^5.0.0",
+    "@alcalzone/release-script-plugin-iobroker": "^4.0.0",
+    "@alcalzone/release-script-plugin-license": "^4.0.0",
     "@iobroker/adapter-dev": "^1.5.0",
     "@iobroker/eslint-config": "^2.2.0",
-    "@iobroker/testing": "^5.1.1",
+    "@iobroker/testing": "^5.2.2",
     "baseline-browser-mapping": "^2.8.32",
-    "eslint": "^9.36.0",
-    "prettier": "^3.6.2",
-    "proxyquire": "^2.1.3",
-    "release-it": "^19.0.5"
+    "proxyquire": "^2.1.3"
   },
   "main": "main.js",
   "files": [
@@ -51,7 +50,7 @@
     "test": "npm run test:js && npm run test:package",
     "lint": "eslint .",
     "translate": "translate-adapter",
-    "release": "release-it"
+    "release": "release-script"
   },
   "bugs": {
     "url": "https://github.com/DasBo1975/ioBroker.poolcontrol/issues"