gsd-pi 2.60.0-dev.2580e65 → 2.60.0-dev.d9052f5

package/src/resources/extensions/gsd/tests/silent-catch-diagnostics.test.ts

@@ -1,284 +0,0 @@
-/**
- * Verify that catch blocks across GSD source files use the centralized
- * workflow-logger (logWarning/logError) instead of raw process.stderr.write,
- * console.error, or being completely empty (#3348, #3345).
- *
- * Two tests:
- * 1. Auto-mode files must have zero empty catch blocks (fully migrated).
- * 2. All GSD files must not use raw stderr/console in catch blocks.
- */
-
-import { describe, test } from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync, readdirSync, statSync } from "node:fs";
-import { join, dirname, relative } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const gsdDir = join(__dirname, "..");
-
-/** Files exempt from the raw-stderr/console check */
-const EXEMPT_FILES = new Set([
-  "workflow-logger.ts",       // The logger itself
-  "debug-logger.ts",          // Separate opt-in debug system
-]);
-
-/**
- * Files that have been fully migrated to workflow-logger and must not
- * regress to empty catch blocks. Covers auto-mode, tools, bootstrap,
- * and core infrastructure files.
- */
-const MIGRATED_FILES = new Set([
-  // auto-mode (detected dynamically below)
-  // tools/
-  "tools/complete-task.ts",
-  "tools/complete-slice.ts",
-  "tools/complete-milestone.ts",
-  "tools/plan-milestone.ts",
-  "tools/plan-slice.ts",
-  "tools/plan-task.ts",
-  "tools/reassess-roadmap.ts",
-  "tools/reopen-task.ts",
-  "tools/reopen-slice.ts",
-  "tools/replan-slice.ts",
-  "tools/validate-milestone.ts",
-  // bootstrap/
-  "bootstrap/agent-end-recovery.ts",
-  "bootstrap/system-context.ts",
-  "bootstrap/db-tools.ts",
-  "bootstrap/dynamic-tools.ts",
-  "bootstrap/journal-tools.ts",
-  // core infrastructure
-  "gsd-db.ts",
-  "workflow-logger.ts",
-  "workflow-reconcile.ts",
-  "workflow-migration.ts",
-  "workflow-projections.ts",
-  "workflow-events.ts",
-  "worktree-manager.ts",
-  "parallel-orchestrator.ts",
-  "parallel-merge.ts",
-  "guided-flow.ts",
-  "preferences.ts",
-  "commands-maintenance.ts",
-  "commands-inspect.ts",
-  "safe-fs.ts",
-  "markdown-renderer.ts",
-  "md-importer.ts",
-  "milestone-actions.ts",
-  "milestone-ids.ts",
-  "rule-registry.ts",
-  "custom-verification.ts",
-  "prompt-loader.ts",
-  "auto-verification.ts",
-]);
-
-/** Patterns that indicate a catch block already uses workflow-logger */
-const LOGGER_PATTERNS = [
-  /logWarning\s*\(/,
-  /logError\s*\(/,
-];
-
-function getAutoModeFiles(): string[] {
-  const files: string[] = [];
-
-  // Top-level auto*.ts files
-  for (const f of readdirSync(gsdDir)) {
-    if (f.startsWith("auto") && f.endsWith(".ts") && !f.endsWith(".test.ts")) {
-      files.push(join(gsdDir, f));
-    }
-  }
-
-  // auto/ subdirectory
-  const autoSubDir = join(gsdDir, "auto");
-  for (const f of readdirSync(autoSubDir)) {
-    if (f.endsWith(".ts") && !f.endsWith(".test.ts")) {
-      files.push(join(autoSubDir, f));
-    }
-  }
-
-  return files;
-}
-
-function getGsdSourceFiles(): string[] {
-  const files: string[] = [];
-
-  function walk(dir: string): void {
-    for (const entry of readdirSync(dir)) {
-      const full = join(dir, entry);
-      if (entry === "tests" || entry === "node_modules") continue;
-      try {
-        const st = statSync(full);
-        if (st.isDirectory()) {
-          walk(full);
-        } else if (entry.endsWith(".ts") && !entry.endsWith(".test.ts") && !entry.endsWith(".d.ts")) {
-          files.push(full);
-        }
-      } catch {
-        continue;
-      }
-    }
-  }
-
-  walk(gsdDir);
-  return files;
-}
-
-/**
- * Scan a file for empty catch blocks — catches whose body contains
- * only whitespace and/or comments but no executable statements.
- */
-function findEmptyCatches(filePath: string): Array<{ line: number; text: string }> {
-  const content = readFileSync(filePath, "utf-8");
-  const lines = content.split("\n");
-  const results: Array<{ line: number; text: string }> = [];
-
-  for (let i = 0; i < lines.length; i++) {
-    const line = lines[i];
-
-    // Match catch block opening
-    if (!/\}\s*catch\s*(\([^)]*\))?\s*\{/.test(line)) continue;
-
-    // Inline single-line catch: } catch { ... }
-    const inlineMatch = line.match(/\}\s*catch\s*(\([^)]*\))?\s*\{(.*)\}\s*;?\s*$/);
-    if (inlineMatch) {
-      const body = inlineMatch[2].trim();
-      const stripped = body.replace(/\/\*.*?\*\//g, "").replace(/\/\/.*/g, "").trim();
-      if (!stripped) {
-        results.push({ line: i + 1, text: line.trim() });
-      }
-      continue;
-    }
-
-    // Multi-line catch — scan until matching }
-    let j = i + 1;
-    let depth = 1;
-    const bodyLines: string[] = [];
-    while (j < lines.length && depth > 0) {
-      for (const ch of lines[j]) {
-        if (ch === "{") depth++;
-        else if (ch === "}") depth--;
-      }
-      bodyLines.push(lines[j].trim());
-      j++;
-    }
-
-    const meaningful = bodyLines.slice(0, -1).filter(
-      (l) => l && !l.startsWith("//") && !l.startsWith("/*") && !l.startsWith("*") && l !== "}",
-    );
-
-    if (meaningful.length === 0) {
-      results.push({ line: i + 1, text: line.trim() });
-    }
-  }
-
-  return results;
-}
-
-/**
- * Scan a file for catch blocks that use raw process.stderr.write or
- * console.error/warn instead of workflow-logger.
- */
-function findRawStderrCatches(filePath: string): Array<{ line: number; text: string }> {
-  const content = readFileSync(filePath, "utf-8");
-  const lines = content.split("\n");
-  const results: Array<{ line: number; text: string }> = [];
-
-  for (let i = 0; i < lines.length; i++) {
-    const line = lines[i];
-    if (!/\}\s*catch\s*(\([^)]*\))?\s*\{/.test(line)) continue;
-
-    // Inline single-line catch
-    const inlineMatch = line.match(/\}\s*catch\s*(\([^)]*\))?\s*\{(.*)\}\s*;?\s*$/);
-    if (inlineMatch) {
-      const body = inlineMatch[2];
-      if (!LOGGER_PATTERNS.some((p) => p.test(body))) {
-        if (/process\.stderr\.write/.test(body) || /console\.(error|warn)/.test(body)) {
-          results.push({ line: i + 1, text: line.trim() });
-        }
-      }
-      continue;
-    }
-
-    // Multi-line catch
-    let j = i + 1;
-    let depth = 1;
-    const bodyLines: string[] = [];
-    while (j < lines.length && depth > 0) {
-      for (const ch of lines[j]) {
-        if (ch === "{") depth++;
-        else if (ch === "}") depth--;
-      }
-      bodyLines.push(lines[j]);
-      j++;
-    }
-
-    const bodyText = bodyLines.slice(0, -1).join("\n");
-    if (!LOGGER_PATTERNS.some((p) => p.test(bodyText))) {
-      if (/process\.stderr\.write/.test(bodyText) || /console\.(error|warn)/.test(bodyText)) {
-        results.push({ line: i + 1, text: line.trim() });
-      }
-    }
-  }
-
-  return results;
-}
-
-describe("workflow-logger coverage (#3348)", () => {
-  test("no empty catch blocks remain in migrated files", () => {
-    // Combine auto-mode files + explicitly migrated files
-    const autoFiles = getAutoModeFiles();
-    const allFiles = getGsdSourceFiles();
-    const migratedPaths = new Set(autoFiles);
-    for (const file of allFiles) {
-      const rel = relative(gsdDir, file);
-      if (MIGRATED_FILES.has(rel)) {
-        migratedPaths.add(file);
-      }
-    }
-
-    assert.ok(migratedPaths.size > 0, "should find migrated source files");
-
-    const violations: string[] = [];
-    for (const file of migratedPaths) {
-      const rel = relative(gsdDir, file);
-      const basename = rel.split("/").pop()!;
-      // gsd-db.ts has intentionally silent provider probes
-      if (basename === "gsd-db.ts" || basename === "session-lock.ts") continue;
-
-      const empties = findEmptyCatches(file);
-      for (const empty of empties) {
-        violations.push(`${rel}:${empty.line} — ${empty.text}`);
-      }
-    }
-
-    assert.equal(
-      violations.length,
-      0,
-      `Found ${violations.length} empty catch block(s) in migrated files:\n${violations.join("\n")}`,
-    );
-  });
-
-  test("catch blocks use workflow-logger instead of raw stderr/console", () => {
-    const files = getGsdSourceFiles();
-    assert.ok(files.length > 0, "should find GSD source files");
-
-    const violations: string[] = [];
-    for (const file of files) {
-      const rel = relative(gsdDir, file);
-      const basename = rel.split("/").pop()!;
-      if (EXEMPT_FILES.has(basename)) continue;
-
-      const issues = findRawStderrCatches(file);
-      for (const issue of issues) {
-        violations.push(`${rel}:${issue.line} — ${issue.text}`);
-      }
-    }
-
-    assert.equal(
-      violations.length,
-      0,
-      `Found ${violations.length} catch block(s) using raw stderr/console instead of workflow-logger:\n${violations.join("\n")}`,
-    );
-  });
-});

package/src/resources/extensions/gsd/tests/workflow-logger-audit.test.ts

@@ -1,120 +0,0 @@
-// GSD Extension — Workflow Logger Audit Persistence Tests
-// Validates error-only persistence, sanitization, and warning ephemeral behavior.
-
-import { describe, test, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, readFileSync, existsSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import {
-  logWarning,
-  logError,
-  setLogBasePath,
-  _resetLogs,
-  peekLogs,
-  drainLogs,
-} from "../workflow-logger.ts";
-
-function createTempProject(): string {
-  const tmp = mkdtempSync(join(tmpdir(), "gsd-wflog-test-"));
-  mkdirSync(join(tmp, ".gsd"), { recursive: true });
-  return tmp;
-}
-
-function readAuditLines(basePath: string): Record<string, unknown>[] {
-  const auditPath = join(basePath, ".gsd", "audit-log.jsonl");
-  if (!existsSync(auditPath)) return [];
-  const content = readFileSync(auditPath, "utf-8").trim();
-  if (!content) return [];
-  return content.split("\n").map((line) => JSON.parse(line));
-}
-
-describe("workflow-logger audit persistence", () => {
-  let tmp: string;
-
-  beforeEach(() => {
-    tmp = createTempProject();
-    _resetLogs();
-    setLogBasePath(tmp);
-  });
-
-  afterEach(() => {
-    _resetLogs();
-    setLogBasePath(null as unknown as string);
-    rmSync(tmp, { recursive: true, force: true });
-  });
-
-  test("logError persists to audit-log.jsonl", () => {
-    logError("engine", "something broke");
-    const lines = readAuditLines(tmp);
-    assert.equal(lines.length, 1);
-    assert.equal(lines[0].severity, "error");
-    assert.equal(lines[0].component, "engine");
-  });
-
-  test("logWarning does NOT persist to audit-log.jsonl", () => {
-    logWarning("engine", "something fishy");
-    const lines = readAuditLines(tmp);
-    assert.equal(lines.length, 0, "warnings must not be persisted to audit log");
-  });
-
-  test("logWarning still appears in in-memory buffer", () => {
-    logWarning("recovery", "probe miss");
-    const entries = peekLogs();
-    assert.equal(entries.length, 1);
-    assert.equal(entries[0].severity, "warn");
-    assert.equal(entries[0].component, "recovery");
-  });
-
-  test("persisted error messages are truncated at 200 chars", () => {
-    const longMessage = "x".repeat(300);
-    logError("engine", longMessage);
-    const lines = readAuditLines(tmp);
-    assert.equal(lines.length, 1);
-    const msg = lines[0].message as string;
-    assert.ok(msg.length <= 215, `message should be truncated, got ${msg.length} chars`);
-    assert.ok(msg.endsWith("…[truncated]"));
-  });
-
-  test("persisted errors have context filtered to safe allowlist", () => {
-    logError("tool", "tool failed", {
-      fn: "saveDecisionToDb",
-      tool: "gsd_decision_save",
-      error: "SQLITE_BUSY: database is locked",
-      file: "/home/user/project/gsd.db",
-    });
-    const lines = readAuditLines(tmp);
-    assert.equal(lines.length, 1);
-    const ctx = lines[0].context as Record<string, string>;
-    assert.ok(ctx, "context should exist");
-    assert.equal(ctx.fn, "saveDecisionToDb");
-    assert.equal(ctx.tool, "gsd_decision_save");
-    assert.equal(ctx.error, undefined, "error key must be stripped from persisted context");
-    assert.equal(ctx.file, undefined, "file key must be stripped from persisted context");
-  });
-
-  test("persisted errors omit context when no safe keys present", () => {
-    logError("bootstrap", "ensureDbOpen failed", {
-      error: "ENOENT",
-      cwd: "/home/user/project",
-    });
-    const lines = readAuditLines(tmp);
-    assert.equal(lines.length, 1);
-    assert.equal(lines[0].context, undefined, "context should be omitted when no safe keys match");
-  });
-
-  test("mixed warnings and errors only persist errors", () => {
-    logWarning("recovery", "main not found");
-    logWarning("recovery", "master not found");
-    logError("engine", "fatal failure");
-    logWarning("prompt", "cache miss");
-
-    const lines = readAuditLines(tmp);
-    assert.equal(lines.length, 1, "only the error should be persisted");
-    assert.equal(lines[0].severity, "error");
-
-    const buffered = drainLogs();
-    assert.equal(buffered.length, 4, "all entries should be in the in-memory buffer");
-  });
-});

package/src/resources/extensions/shared/tests/interview-notes-loop.test.ts

@@ -1,144 +0,0 @@
-// GSD2 — Regression test for interview-ui "None of the above" notes loop
-// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
-
-/**
- * Regression test for bug #3502:
- *
- * Selecting "None of the above" opens the notes field, but pressing Enter
- * after typing a note called goNextOrSubmit() which saw the cursor still
- * on the "None of the above" slot and re-opened notes — trapping the user
- * in an infinite loop.
- *
- * The fix adds a `!states[currentIdx].notes` guard so auto-open only fires
- * when notes are still empty.
- */
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import { showInterviewRound, type Question, type RoundResult } from "../interview-ui.js";
-
-// Raw terminal sequences that matchesKey() recognises
-const ENTER = "\r";
-const DOWN = "\x1b[B";
-const TAB = "\t";
-
-/**
- * Drive showInterviewRound with a scripted sequence of key inputs.
- * We mock ctx.ui.custom() to capture the widget, feed it inputs, and
- * resolve when done() is called.
- */
-function runWithInputs(
-	questions: Question[],
-	inputs: string[],
-): Promise<RoundResult> {
-	return new Promise((resolve, reject) => {
-		const timeout = setTimeout(() => reject(new Error("Timed out — likely stuck in infinite loop")), 3000);
-
-		const mockCtx = {
-			ui: {
-				custom: (factory: any) => {
-					const mockTui = {
-						requestRender: () => {},
-					};
-					const mockTheme = {
-						// Minimal theme stubs — render output is not asserted
-						fg: (_c: string, t: string) => t,
-						bold: (t: string) => t,
-						dim: (t: string) => t,
-						italic: (t: string) => t,
-						strikethrough: (t: string) => t,
-						accent: (t: string) => t,
-						success: (t: string) => t,
-						warning: (t: string) => t,
-						error: (t: string) => t,
-						info: (t: string) => t,
-						muted: (t: string) => t,
-						dimmed: (t: string) => t,
-					};
-					const mockKb = {};
-
-					const widget = factory(mockTui, mockTheme, mockKb, (result: RoundResult) => {
-						clearTimeout(timeout);
-						resolve(result);
-					});
-
-					// Feed each input sequentially
-					for (const input of inputs) {
-						widget.handleInput(input);
-					}
-				},
-			},
-		};
-
-		showInterviewRound(questions, {}, mockCtx as any).catch(reject);
-	});
-}
-
-describe("interview-ui notes loop regression (#3502)", () => {
-	const questions: Question[] = [
-		{
-			id: "q1",
-			header: "Project Type",
-			question: "What type of project?",
-			options: [
-				{ label: "Web App", description: "Frontend or full-stack" },
-				{ label: "CLI Tool", description: "Command-line utility" },
-			],
-		},
-	];
-
-	it("does not loop when Enter is pressed after typing a note on 'None of the above'", async () => {
-		// With 2 options, "None of the above" is index 2 (0-based)
-		// Cursor starts at 0, so press Down twice to reach it
-		const result = await runWithInputs(questions, [
-			DOWN,        // cursor → index 1 (CLI Tool)
-			DOWN,        // cursor → index 2 (None of the above)
-			ENTER,       // commit → auto-opens notes field
-			"u", "n", "s", "u", "r", "e",  // type "unsure"
-			ENTER,       // should advance to review, NOT reopen notes
-			ENTER,       // submit from review screen
-		]);
-
-		// If we get here, the loop did not occur (timeout would have fired)
-		assert.ok(result, "should return a result");
-		assert.equal(result.endInterview, false);
-
-		const answer = result.answers.q1;
-		assert.ok(answer, "answer for q1 should exist");
-		assert.equal(answer.notes, "unsure", "notes should contain typed text");
-		assert.equal(answer.selected, "None of the above");
-	});
-
-	it("still auto-opens notes when selecting 'None of the above' with no prior notes", async () => {
-		// Press Down twice to "None of the above", Enter to select
-		// Then immediately Enter again (empty notes) — this should re-open notes
-		// because the guard only skips when notes are non-empty.
-		// Type something on second open, then Enter to proceed.
-		const result = await runWithInputs(questions, [
-			DOWN,        // cursor → 1
-			DOWN,        // cursor → 2 (None of the above)
-			ENTER,       // commit → auto-opens notes
-			ENTER,       // empty notes → goNextOrSubmit → should re-open notes (empty guard)
-			"o", "k",    // type "ok"
-			ENTER,       // now notes = "ok" → should advance to review
-			ENTER,       // submit
-		]);
-
-		assert.ok(result, "should return a result");
-		const answer = result.answers.q1;
-		assert.ok(answer, "answer for q1 should exist");
-		assert.equal(answer.notes, "ok");
-	});
-
-	it("normal option selection is unaffected", async () => {
-		const result = await runWithInputs(questions, [
-			ENTER,       // select first option (Web App) and advance to review
-			ENTER,       // submit from review screen
-		]);
-
-		assert.ok(result, "should return a result");
-		const answer = result.answers.q1;
-		assert.ok(answer, "answer for q1 should exist");
-		assert.equal(answer.selected, "Web App");
-	});
-});