gsd-pi 2.60.0-dev.2580e65 → 2.60.0-dev.d9052f5

package/src/resources/extensions/gsd/complexity-classifier.ts

@@ -16,7 +16,6 @@ export interface ClassificationResult {
   tier: ComplexityTier;
   reason: string;
   downgraded: boolean;   // true if budget pressure lowered the tier
-  taskMetadata?: TaskMetadata;
 }
 
 export interface TaskMetadata {
@@ -72,20 +71,17 @@ export function classifyUnitComplexity(
 ): ClassificationResult {
   // Hook units default to light
   if (unitType.startsWith("hook/")) {
-    const result: ClassificationResult = { tier: "light", reason: "hook unit", downgraded: false, taskMetadata: undefined };
+    const result: ClassificationResult = { tier: "light", reason: "hook unit", downgraded: false };
     return applyBudgetPressure(result, budgetPct);
   }
 
   // Start with the default tier for this unit type
   let tier = UNIT_TYPE_TIERS[unitType] ?? "standard";
   let reason = `unit type: ${unitType}`;
-  let taskMeta: TaskMetadata | undefined;
 
   // For execute-task, analyze task metadata for complexity signals
   if (unitType === "execute-task") {
-    // Extract metadata once and reuse throughout to avoid double-extraction
-    taskMeta = metadata ?? extractTaskMetadata(unitId, basePath);
-    const taskAnalysis = analyzeTaskComplexity(unitId, basePath, taskMeta);
+    const taskAnalysis = analyzeTaskComplexity(unitId, basePath, metadata);
     tier = taskAnalysis.tier;
     reason = taskAnalysis.reason;
   }
@@ -100,15 +96,14 @@ export function classifyUnitComplexity(
   }
 
   // Adaptive learning: check if history suggests bumping the tier
-  // Use already-extracted taskMeta.tags if available to avoid double-extraction
-  const tags = taskMeta?.tags ?? metadata?.tags;
+  const tags = metadata?.tags ?? extractTaskMetadata(unitId, basePath).tags;
   const adaptiveAdjustment = getAdaptiveTierAdjustment(unitType, tier, tags);
   if (adaptiveAdjustment && tierOrdinal(adaptiveAdjustment) > tierOrdinal(tier)) {
     reason = `${reason} (adaptive: high failure rate at ${tier})`;
     tier = adaptiveAdjustment;
   }
 
-  const result: ClassificationResult = { tier, reason, downgraded: false, taskMetadata: taskMeta };
+  const result: ClassificationResult = { tier, reason, downgraded: false };
   return applyBudgetPressure(result, budgetPct);
 }
 

package/src/resources/extensions/gsd/custom-verification.ts

@@ -17,7 +17,6 @@
  * - The frozen DEFINITION.yaml on disk is the single source of truth for step policies.
  */
 
-import { logWarning } from "./workflow-logger.js";
 import { readFileSync, existsSync, statSync } from "node:fs";
 import { join, resolve, sep } from "node:path";
 import { spawnSync } from "node:child_process";
@@ -131,8 +130,8 @@ function handleContentHeuristic(
         if (!new RegExp(verify.pattern).test(content)) {
           return "pause";
         }
-      } catch (e) {
-        logWarning("engine", `content-heuristic regex failed: ${(e as Error).message}`);
+      } catch {
+        // Invalid regex at runtime — treat as verification failure
         return "pause";
       }
     }

package/src/resources/extensions/gsd/gsd-db.ts

@@ -10,7 +10,7 @@ import { existsSync, copyFileSync, mkdirSync, realpathSync } from "node:fs";
 import { dirname } from "node:path";
 import type { Decision, Requirement, GateRow, GateId, GateScope, GateStatus, GateVerdict } from "./types.js";
 import { GSDError, GSD_STALE_STATE } from "./errors.js";
-import { logError, logWarning } from "./workflow-logger.js";
+import { logError } from "./workflow-logger.js";
 
 const _require = createRequire(import.meta.url);
 
@@ -787,11 +787,11 @@ export function openDatabase(path: string): boolean {
         initSchema(adapter, fileBacked);
         process.stderr.write("gsd-db: recovered corrupt database via VACUUM\n");
       } catch (retryErr) {
-        try { adapter.close(); } catch (e) { logWarning("db", `close after VACUUM failed: ${(e as Error).message}`); }
+        try { adapter.close(); } catch { /* swallow */ }
         throw retryErr;
       }
     } else {
-      try { adapter.close(); } catch (e) { logWarning("db", `close after VACUUM failed: ${(e as Error).message}`); }
+      try { adapter.close(); } catch { /* swallow */ }
       throw err;
     }
   }
@@ -802,7 +802,7 @@ export function openDatabase(path: string): boolean {
 
   if (!_exitHandlerRegistered) {
     _exitHandlerRegistered = true;
-    process.on("exit", () => { try { closeDatabase(); } catch (e) { logWarning("db", `exit handler close failed: ${(e as Error).message}`); } });
+    process.on("exit", () => { try { closeDatabase(); } catch {} });
   }
 
   return true;
@@ -812,14 +812,16 @@ export function closeDatabase(): void {
   if (currentDb) {
     try {
       currentDb.exec('PRAGMA wal_checkpoint(TRUNCATE)');
-    } catch (e) { logWarning("db", `WAL checkpoint failed: ${(e as Error).message}`); }
+    } catch { /* non-fatal — best effort before close */ }
     try {
       // Incremental vacuum to reclaim space without blocking
       currentDb.exec('PRAGMA incremental_vacuum(64)');
-    } catch (e) { logWarning("db", `incremental vacuum failed: ${(e as Error).message}`); }
+    } catch { /* non-fatal */ }
     try {
       currentDb.close();
-    } catch (e) { logWarning("db", `database close failed: ${(e as Error).message}`); }
+    } catch {
+      // swallow close errors
+    }
     currentDb = null;
     currentPath = null;
     currentPid = 0;
@@ -831,7 +833,7 @@ export function vacuumDatabase(): void {
   if (!currentDb) return;
   try {
     currentDb.exec('VACUUM');
-  } catch (e) { logWarning("db", `VACUUM failed: ${(e as Error).message}`); }
+  } catch { /* non-fatal */ }
 }
 
 let _txDepth = 0;
@@ -1036,7 +1038,7 @@ export function upsertRequirement(r: Requirement): void {
 
 export function clearArtifacts(): void {
   if (!currentDb) return;
-  try { currentDb.exec("DELETE FROM artifacts"); } catch (e) { logWarning("db", `clearArtifacts failed: ${(e as Error).message}`); }
+  try { currentDb.exec("DELETE FROM artifacts"); } catch { /* cache clear is best effort */ }
 }
 
 export function insertArtifact(a: {
@@ -1799,7 +1801,7 @@ export function reconcileWorktreeDb(
   // ATTACHing a WAL-mode DB to itself corrupts the WAL (#2823).
   try {
     if (realpathSync(mainDbPath) === realpathSync(worktreeDbPath)) return zero;
-  } catch (e) { logWarning("db", `realpathSync failed: ${(e as Error).message}`); }
+  } catch { /* path resolution failed — fall through to existing checks */ }
   // Sanitize path: reject any characters that could break ATTACH syntax.
   // ATTACH DATABASE doesn't support parameterized paths in all providers,
   // so we use strict allowlist validation instead.
@@ -1936,12 +1938,12 @@ export function reconcileWorktreeDb(
 
         adapter.exec("COMMIT");
       } catch (txErr) {
-        try { adapter.exec("ROLLBACK"); } catch (e) { logWarning("db", `rollback failed: ${(e as Error).message}`); }
+        try { adapter.exec("ROLLBACK"); } catch { /* best effort */ }
         throw txErr;
       }
       return { ...merged, conflicts };
     } finally {
-      try { adapter.exec("DETACH DATABASE wt"); } catch (e) { logWarning("db", `detach worktree DB failed: ${(e as Error).message}`); }
+      try { adapter.exec("DETACH DATABASE wt"); } catch { /* best effort */ }
     }
   } catch (err) {
     logError("db", "worktree DB reconciliation failed", { error: (err as Error).message });

package/src/resources/extensions/gsd/guided-flow.ts

@@ -52,7 +52,6 @@ export {
   buildExistingMilestonesContext,
 } from "./guided-flow-queue.js";
 import { getErrorMessage } from "./error-utils.js";
-import { logWarning } from "./workflow-logger.js";
 
 // ─── ID Generation with Reservation ─────────────────────────────────────────
 
@@ -181,7 +180,7 @@ export function checkAutoStartAfterDiscuss(): boolean {
           );
         }
       }
-    } catch (e) { logWarning("guided", `PROJECT.md parsing failed: ${(e as Error).message}`); }
+    } catch { /* non-fatal — PROJECT.md parsing failure shouldn't block auto-start */ }
   }
 
   // Gate 4: Discussion manifest process verification (multi-milestone only)
@@ -213,7 +212,7 @@ export function checkAutoStartAfterDiscuss(): boolean {
           );
         }
       }
-    } catch (e) { logWarning("guided", `discussion manifest verification failed: ${(e as Error).message}`); }
+    } catch { /* malformed manifest — warn but don't block */ }
   }
 
   // Draft promotion cleanup: if a CONTEXT-DRAFT.md exists alongside the new
@@ -221,16 +220,16 @@ export function checkAutoStartAfterDiscuss(): boolean {
   try {
     const draftFile = resolveMilestoneFile(basePath, milestoneId, "CONTEXT-DRAFT");
     if (draftFile) unlinkSync(draftFile);
-  } catch (e) { logWarning("guided", `CONTEXT-DRAFT.md unlink failed: ${(e as Error).message}`); }
+  } catch { /* non-fatal — stale draft doesn't break anything, CONTEXT.md wins */ }
 
   // Cleanup: remove discussion manifest after auto-start (only needed during discussion)
-  try { unlinkSync(manifestPath); } catch (e) { logWarning("guided", `manifest unlink failed: ${(e as Error).message}`); }
+  try { unlinkSync(manifestPath); } catch { /* may not exist for single-milestone */ }
 
   pendingAutoStartMap.delete(basePath);
   ctx.ui.notify(`Milestone ${milestoneId} ready.`, "info");
   startAuto(ctx, pi, basePath, false, { step }).catch((err) => {
     ctx.ui.notify(`Auto-start failed: ${getErrorMessage(err)}`, "error");
-    logWarning("guided", `auto start error: ${getErrorMessage(err)}`);
+    if (process.env.GSD_DEBUG) console.error('[gsd] auto start error:', err);
     debugLog("auto-start-failed", { error: getErrorMessage(err) });
   });
   return true;
@@ -896,8 +895,8 @@ function selfHealRuntimeRecords(basePath: string, ctx: ExtensionContext): { clea
       ctx.ui.notify(`Self-heal: cleared ${cleared} stale runtime record(s) from a previous session.`, "info");
     }
     return { cleared };
-  } catch (e) {
-    logWarning("guided", `self-heal stale runtime records failed: ${(e as Error).message}`);
+  } catch {
+    // Non-fatal — self-heal should never block the wizard
     return { cleared: 0 };
   }
 }
@@ -1143,7 +1142,7 @@ export async function showSmartEntry(
             );
             return;
           }
-        } catch (e) { logWarning("guided", `directory read failed: ${(e as Error).message}`); }
+        } catch { /* directory exists but unreadable — fall through to normal flow */ }
       }
     }
 

package/src/resources/extensions/gsd/init-wizard.ts

@@ -16,7 +16,6 @@ import { gsdRoot } from "./paths.js";
 import { assertSafeDirectory } from "./validate-directory.js";
 import type { ProjectDetection, ProjectSignals } from "./detection.js";
 import { runSkillInstallStep } from "./skill-catalog.js";
-import { generateCodebaseMap, writeCodebaseMap } from "./codebase-generator.js";
 
 // ─── Types ──────────────────────────────────────────────────────────────────────
 
@@ -239,17 +238,6 @@ export async function showProjectInit(
   ensureGitignore(basePath);
   untrackRuntimeFiles(basePath);
 
-  // Auto-generate codebase map for instant agent orientation
-  try {
-    const result = generateCodebaseMap(basePath);
-    if (result.fileCount > 0) {
-      writeCodebaseMap(basePath, result.content);
-      ctx.ui.notify(`Codebase map generated: ${result.fileCount} files`, "info");
-    }
-  } catch {
-    // Non-fatal — codebase map generation failure should never block project init
-  }
-
   ctx.ui.notify("GSD initialized. Starting your first milestone...", "info");
 
   return { completed: true, bootstrapped: true };

package/src/resources/extensions/gsd/markdown-renderer.ts

@@ -9,7 +9,6 @@
 // parseRoadmap(), parsePlan(), parseSummary() in files.ts.
 
 import { readFileSync, existsSync, mkdirSync } from "node:fs";
-import { logWarning } from "./workflow-logger.js";
 import { isClosedStatus } from "./status-guards.js";
 import { join, relative } from "node:path";
 import { createRequire } from "node:module";
@@ -94,7 +93,9 @@ function loadArtifactContent(
   try {
     content = readFileSync(absPath, "utf-8");
   } catch {
-    logWarning("renderer", `cannot read file from disk: ${absPath}`);
+    process.stderr.write(
+      `markdown-renderer: cannot read file from disk: ${absPath}\n`,
+    );
     return null;
   }
 
@@ -110,7 +111,9 @@ function loadArtifactContent(
     });
   } catch {
     // Non-fatal: we have the content, DB storage is best-effort
-    logWarning("renderer", `failed to store disk fallback in DB: ${artifactPath}`);
+    process.stderr.write(
+      `markdown-renderer: warning — failed to store disk fallback in DB: ${artifactPath}\n`,
+    );
   }
 
   return content;
@@ -143,7 +146,9 @@ async function writeAndStore(
     });
   } catch {
     // Non-fatal: file is on disk, DB is best-effort
-    logWarning("renderer", `failed to update artifact in DB: ${artifactPath}`);
+    process.stderr.write(
+      `markdown-renderer: warning — failed to update artifact in DB: ${artifactPath}\n`,
+    );
   }
 
   invalidateCaches();
@@ -801,8 +806,7 @@ export function detectStaleRenders(basePath: string): StaleEntry[] {
   try {
     const m = _require("./parsers-legacy.ts");
     parseRoadmap = m.parseRoadmap; parsePlan = m.parsePlan;
-  } catch (e) {
-    logWarning("renderer", `parsers-legacy.ts require failed, falling back to .js: ${(e as Error).message}`);
+  } catch {
     const m = _require("./parsers-legacy.js");
     parseRoadmap = m.parseRoadmap; parsePlan = m.parsePlan;
   }
@@ -837,8 +841,8 @@ export function detectStaleRenders(basePath: string): StaleEntry[] {
             });
           }
         }
-      } catch (e) {
-        logWarning("renderer", `roadmap parse failed: ${(e as Error).message}`);
+      } catch {
+        // Can't parse roadmap — skip silently
       }
     }
 
@@ -870,8 +874,8 @@ export function detectStaleRenders(basePath: string): StaleEntry[] {
               });
             }
           }
-        } catch (e) {
-          logWarning("renderer", `plan parse failed: ${(e as Error).message}`);
+        } catch {
+          // Can't parse plan — skip silently
         }
       }
 
@@ -1021,7 +1025,9 @@ export async function repairStaleRenders(basePath: string): Promise<number> {
         }
       }
     } catch (err) {
-      logWarning("renderer", `repair failed for ${entry.path}: ${(err as Error).message}`);
+      process.stderr.write(
+        `markdown-renderer: repair failed for ${entry.path}: ${(err as Error).message}\n`,
+      );
     }
   }
 

package/src/resources/extensions/gsd/md-importer.ts

@@ -31,7 +31,6 @@ import {
 import { findMilestoneIds } from './guided-flow.js';
 import { parseRoadmap, parsePlan } from './parsers-legacy.js';
 import { parseContextDependsOn } from './files.js';
-import { logWarning } from './workflow-logger.js';
 
 // ─── DECISIONS.md Parser ───────────────────────────────────────────────────
 
@@ -713,25 +712,25 @@ export function migrateFromMarkdown(gsdDir: string): {
     try {
       decisions = importDecisions(gsdDir);
     } catch (err) {
-      logWarning("migration", `skipping decisions import: ${(err as Error).message}`);
+      process.stderr.write(`gsd-migrate: skipping decisions import: ${(err as Error).message}\n`);
     }
 
     try {
       requirements = importRequirements(gsdDir);
     } catch (err) {
-      logWarning("migration", `skipping requirements import: ${(err as Error).message}`);
+      process.stderr.write(`gsd-migrate: skipping requirements import: ${(err as Error).message}\n`);
     }
 
     try {
       artifacts = importHierarchyArtifacts(gsdDir);
     } catch (err) {
-      logWarning("migration", `skipping artifacts import: ${(err as Error).message}`);
+      process.stderr.write(`gsd-migrate: skipping artifacts import: ${(err as Error).message}\n`);
     }
 
     try {
       hierarchy = migrateHierarchyToDb(gsdDir);
     } catch (err) {
-      logWarning("migration", `skipping hierarchy migration: ${(err as Error).message}`);
+      process.stderr.write(`gsd-migrate: skipping hierarchy migration: ${(err as Error).message}\n`);
     }
   });
 

package/src/resources/extensions/gsd/milestone-actions.ts

@@ -21,7 +21,6 @@ import {
 import { invalidateAllCaches } from "./cache.js";
 import { loadQueueOrder, saveQueueOrder } from "./queue-order.js";
 import { isDbAvailable, updateMilestoneStatus } from "./gsd-db.js";
-import { logWarning } from "./workflow-logger.js";
 
 // ─── Park ──────────────────────────────────────────────────────────────────
 
@@ -59,7 +58,7 @@ export function parkMilestone(basePath: string, milestoneId: string, reason: str
     try {
       updateMilestoneStatus(milestoneId, "parked");
     } catch (err) {
-      logWarning("engine", `parkMilestone DB sync failed for ${milestoneId}: ${(err as Error).message}`);
+      process.stderr.write(`gsd: parkMilestone DB sync failed for ${milestoneId}: ${(err as Error).message}\n`);
     }
   }
   invalidateAllCaches();
@@ -85,7 +84,7 @@ export function unparkMilestone(basePath: string, milestoneId: string): boolean
     try {
       updateMilestoneStatus(milestoneId, "active");
     } catch (err) {
-      logWarning("engine", `unparkMilestone DB sync failed for ${milestoneId}: ${(err as Error).message}`);
+      process.stderr.write(`gsd: unparkMilestone DB sync failed for ${milestoneId}: ${(err as Error).message}\n`);
     }
   }
   invalidateAllCaches();

package/src/resources/extensions/gsd/milestone-ids.ts

@@ -6,7 +6,6 @@
  */
 
 import { randomInt } from "node:crypto";
-import { logWarning } from "./workflow-logger.js";
 import { readdirSync, existsSync } from "node:fs";
 import { milestonesDir } from "./paths.js";
 import { loadQueueOrder, sortByQueueOrder } from "./queue-order.js";
@@ -129,7 +128,7 @@ export function findMilestoneIds(basePath: string): string[] {
   } catch (err) {
     // Log why milestone scanning failed — silent [] here causes infinite loops (#456)
     if (existsSync(dir)) {
-      logWarning("engine", `findMilestoneIds: .gsd/milestones/ exists but readdirSync failed — ${getErrorMessage(err)}`);
+      console.error(`[gsd] findMilestoneIds: .gsd/milestones/ exists but readdirSync failed — ${getErrorMessage(err)}`);
     }
     return [];
   }