gsd-pi 2.60.0-dev.2580e65 → 2.60.0-dev.d9052f5

package/src/resources/extensions/gsd/preferences-types.ts

@@ -103,7 +103,6 @@ export const KNOWN_PREFERENCE_KEYS = new Set<string>([
   "stale_commit_threshold_minutes",
   "context_management",
   "experimental",
-  "codebase",
 ]);
 
 /** Canonical list of all dispatch unit types. */
@@ -212,16 +211,6 @@ export interface ExperimentalPreferences {
   rtk?: boolean;
 }
 
-/** Configuration for the codebase map generator (/gsd codebase). */
-export interface CodebaseMapPreferences {
-  /** Additional directory/file patterns to exclude (e.g. ["docs/", "fixtures/"]). Merged with built-in defaults. */
-  exclude_patterns?: string[];
-  /** Max files to include in the map. Default: 500. */
-  max_files?: number;
-  /** Files-per-directory threshold before collapsing to a summary line. Default: 20. */
-  collapse_threshold?: number;
-}
-
 export interface GSDPreferences {
   version?: number;
   mode?: WorkflowMode;
@@ -286,8 +275,6 @@ export interface GSDPreferences {
    * See the preferences reference for details on each feature.
    */
   experimental?: ExperimentalPreferences;
-  /** Configuration for the codebase map generator (/gsd codebase). */
-  codebase?: CodebaseMapPreferences;
 }
 
 export interface LoadedGSDPreferences {

package/src/resources/extensions/gsd/preferences-validation.ts

@@ -857,50 +857,5 @@ export function validatePreferences(preferences: GSDPreferences): {
     }
   }
 
-  // ─── Codebase Map ──────────────────────────────────────────────────
-  if (preferences.codebase !== undefined) {
-    if (typeof preferences.codebase === "object" && preferences.codebase !== null) {
-      const cb = preferences.codebase as Record<string, unknown>;
-      const validCb: import("./preferences-types.js").CodebaseMapPreferences = {};
-
-      if (cb.exclude_patterns !== undefined) {
-        if (Array.isArray(cb.exclude_patterns) && cb.exclude_patterns.every((p: unknown) => typeof p === "string")) {
-          validCb.exclude_patterns = cb.exclude_patterns as string[];
-        } else {
-          errors.push("codebase.exclude_patterns must be an array of strings");
-        }
-      }
-      if (cb.max_files !== undefined) {
-        const mf = typeof cb.max_files === "number" ? cb.max_files : Number(cb.max_files);
-        if (Number.isFinite(mf) && mf >= 1) {
-          validCb.max_files = Math.floor(mf);
-        } else {
-          errors.push("codebase.max_files must be a positive integer");
-        }
-      }
-      if (cb.collapse_threshold !== undefined) {
-        const ct = typeof cb.collapse_threshold === "number" ? cb.collapse_threshold : Number(cb.collapse_threshold);
-        if (Number.isFinite(ct) && ct >= 1) {
-          validCb.collapse_threshold = Math.floor(ct);
-        } else {
-          errors.push("codebase.collapse_threshold must be a positive integer");
-        }
-      }
-
-      const knownCbKeys = new Set(["exclude_patterns", "max_files", "collapse_threshold"]);
-      for (const key of Object.keys(cb)) {
-        if (!knownCbKeys.has(key)) {
-          warnings.push(`unknown codebase key "${key}" — ignored`);
-        }
-      }
-
-      if (Object.keys(validCb).length > 0) {
-        validated.codebase = validCb;
-      }
-    } else {
-      errors.push("codebase must be an object");
-    }
-  }
-
   return { preferences: validated, errors, warnings };
 }

package/src/resources/extensions/gsd/preferences.ts

@@ -19,7 +19,6 @@ import { parse as parseYaml } from "yaml";
 import type { PostUnitHookConfig, PreDispatchHookConfig, TokenProfile } from "./types.js";
 import type { DynamicRoutingConfig } from "./model-router.js";
 import { normalizeStringArray } from "../shared/format-utils.js";
-import { logWarning } from "./workflow-logger.js";
 import { resolveProfileDefaults as _resolveProfileDefaults } from "./preferences-models.js";
 
 import {
@@ -49,7 +48,6 @@ export type {
   AutoSupervisorConfig,
   RemoteQuestionsConfig,
   CmuxPreferences,
-  CodebaseMapPreferences,
   GSDPreferences,
   LoadedGSDPreferences,
   SkillResolution,
@@ -239,7 +237,7 @@ function parseFrontmatterBlock(frontmatter: string): GSDPreferences {
     }
     return parsed as GSDPreferences;
   } catch (e) {
-    logWarning("guided", `YAML parse error in frontmatter block: ${(e as Error).message}`);
+    console.error("[parseFrontmatterBlock] YAML parse error:", e);
     return {} as GSDPreferences;
   }
 }
@@ -298,8 +296,8 @@ function parseHeadingListFormat(content: string): GSDPreferences {
       }
 
       typed[targetSection] = value;
-    } catch (e) {
-      logWarning("guided", `preferences section parse failed: ${(e as Error).message}`);
+    } catch {
+      /* malformed section — skip */
     }
   }
 
@@ -373,17 +371,6 @@ function mergePreferences(base: GSDPreferences, override: GSDPreferences): GSDPr
     service_tier: override.service_tier ?? base.service_tier,
     forensics_dedup: override.forensics_dedup ?? base.forensics_dedup,
     show_token_cost: override.show_token_cost ?? base.show_token_cost,
-    codebase: (base.codebase || override.codebase)
-      ? {
-          ...(base.codebase ?? {}),
-          ...(override.codebase ?? {}),
-          // Merge exclude_patterns arrays rather than overriding
-          exclude_patterns: [
-            ...((base.codebase?.exclude_patterns) ?? []),
-            ...((override.codebase?.exclude_patterns) ?? []),
-          ].filter(Boolean),
-        }
-      : undefined,
   };
 }
 

package/src/resources/extensions/gsd/prompt-loader.ts

@@ -22,7 +22,6 @@ import { GSDError, GSD_PARSE_ERROR } from "./errors.js";
 import { join, dirname } from "node:path";
 import { fileURLToPath } from "node:url";
 import { homedir } from "node:os";
-import { logWarning } from "./workflow-logger.js";
 
 /**
  * Resolve the GSD extension directory.
@@ -73,7 +72,7 @@ function warmCache(): void {
     // prompts/ may not exist in test environments — lazy loading still works.
     // Emit a diagnostic when running outside tests so wrong-path bugs are visible.
     if (!process.env.VITEST && !process.env.NODE_TEST) {
-      logWarning("prompt", `warmCache: prompts dir not found: ${promptsDir}`);
+      process.stderr.write(`[gsd:prompt-loader] warmCache: prompts dir not found: ${promptsDir}\n`);
     }
   }
 
@@ -88,7 +87,7 @@ function warmCache(): void {
   } catch {
     // templates/ may not exist in test environments — lazy loading still works.
     if (!process.env.VITEST && !process.env.NODE_TEST) {
-      logWarning("prompt", `warmCache: templates dir not found: ${templatesDir}`);
+      process.stderr.write(`[gsd:prompt-loader] warmCache: templates dir not found: ${templatesDir}\n`);
     }
   }
 }

package/src/resources/extensions/gsd/prompts/rethink.md

@@ -48,7 +48,7 @@ Remove the `{ID}-PARKED.md` file from the milestone directory to reactivate it.
 ### Skip a slice
 Mark a slice as skipped so auto-mode advances past it without executing. Use the `gsd_skip_slice` tool:
 ```
-gsd_skip_slice({ milestoneId: "M003", sliceId: "S02", reason: "Descoped — feature moved to M005" })
+gsd_skip_slice({ milestone_id: "M003", slice_id: "S02", reason: "Descoped — feature moved to M005" })
 ```
 Skipped slices are treated as closed by the state machine (like "complete" but distinct). Use when a slice is no longer needed or has been superseded. The slice data is preserved for reference.
 

package/src/resources/extensions/gsd/rule-registry.ts

@@ -6,7 +6,6 @@
 //
 // A module-level singleton accessor allows existing code to migrate incrementally.
 
-import { logWarning } from "./workflow-logger.js";
 import type { UnifiedRule, RulePhase } from "./rule-types.js";
 import type { DispatchAction, DispatchContext, DispatchRule } from "./auto-dispatch.js";
 import type {
@@ -388,8 +387,8 @@ export class RuleRegistry {
       const dir = join(basePath, ".gsd");
       if (!existsSync(dir)) mkdirSync(dir, { recursive: true });
       writeFileSync(this._hookStatePath(basePath), JSON.stringify(state, null, 2), "utf-8");
-    } catch (e) {
-      logWarning("registry", `failed to persist hook state: ${(e as Error).message}`);
+    } catch {
+      // Non-fatal — state is recreatable from artifacts
     }
   }
 
@@ -408,8 +407,8 @@ export class RuleRegistry {
           }
         }
       }
-    } catch (e) {
-      logWarning("registry", `failed to restore hook state: ${(e as Error).message}`);
+    } catch {
+      // Non-fatal — fresh state is fine
     }
   }
 
@@ -424,8 +423,8 @@ export class RuleRegistry {
           "utf-8",
         );
       }
-    } catch (e) {
-      logWarning("registry", `failed to clear hook state: ${(e as Error).message}`);
+    } catch {
+      // Non-fatal
     }
   }
 

package/src/resources/extensions/gsd/safe-fs.ts

@@ -1,24 +1,23 @@
 import { existsSync, mkdirSync, cpSync, type CopySyncOptions } from "node:fs"
 import { dirname } from "node:path"
-import { logWarning } from "./workflow-logger.js"
 
 /**
  * Safely creates a directory. Returns true if successful, false on error.
- * Logs warnings via workflow-logger on failure.
+ * Logs to stderr when GSD_DEBUG is set.
  */
 export function safeMkdir(dirPath: string): boolean {
   try {
     mkdirSync(dirPath, { recursive: true })
     return true
   } catch (err) {
-    logWarning("fs", `mkdir failed: ${dirPath}: ${(err as Error).message}`)
+    if (process.env.GSD_DEBUG) console.error(`[gsd] mkdir failed: ${dirPath}`, err)
     return false
   }
 }
 
 /**
  * Safely copies src to dst. Returns true if successful, false if src doesn't exist or copy fails.
- * Logs warnings via workflow-logger on failure.
+ * Logs to stderr when GSD_DEBUG is set.
  */
 export function safeCopy(src: string, dst: string, opts?: CopySyncOptions): boolean {
   if (!existsSync(src)) return false
@@ -26,7 +25,7 @@ export function safeCopy(src: string, dst: string, opts?: CopySyncOptions): bool
     cpSync(src, dst, opts)
     return true
   } catch (err) {
-    logWarning("fs", `copy failed: ${src} → ${dst}: ${(err as Error).message}`)
+    if (process.env.GSD_DEBUG) console.error(`[gsd] copy failed: ${src} → ${dst}`, err)
     return false
   }
 }
@@ -42,7 +41,7 @@ export function safeCopyRecursive(src: string, dst: string, opts?: Omit<CopySync
     cpSync(src, dst, { ...opts, recursive: true })
     return true
   } catch (err) {
-    logWarning("fs", `recursive copy failed: ${src} → ${dst}: ${(err as Error).message}`)
+    if (process.env.GSD_DEBUG) console.error(`[gsd] recursive copy failed: ${src} → ${dst}`, err)
     return false
   }
 }

package/src/resources/extensions/gsd/tests/codebase-generator.test.ts

@@ -486,66 +486,3 @@ test("getCodebaseMapStats: reads total file count from header for accuracy with
     cleanup(base);
   }
 });
-
-// ─── excludePatterns from options ────────────────────────────────────────
-
-test("generateCodebaseMap: custom excludePatterns filters additional directories", () => {
-  const base = makeTmpRepo();
-  try {
-    addFile(base, "src/main.ts");
-    addFile(base, "src/utils.ts");
-    addFile(base, ".cache-data/data/index.lance");
-    addFile(base, "docs/guide.md");
-
-    const result = generateCodebaseMap(base, {
-      excludePatterns: [".cache-data/", "docs/"],
-    });
-    assert.ok(result.content.includes("`src/main.ts`"));
-    assert.ok(result.content.includes("`src/utils.ts`"));
-    assert.ok(!result.content.includes(".cache-data"));
-    assert.ok(!result.content.includes("guide.md"));
-    assert.equal(result.fileCount, 2);
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("generateCodebaseMap: collapseThreshold option overrides default", () => {
-  const base = makeTmpRepo();
-  try {
-    // Create 10 files in one directory — below default threshold (20)
-    // but above a custom threshold of 5
-    for (let i = 0; i < 10; i++) {
-      addFile(base, `src/comp${i}.ts`);
-    }
-
-    // With default threshold (20), files should NOT collapse
-    const expanded = generateCodebaseMap(base);
-    assert.ok(expanded.content.includes("`src/comp0.ts`"));
-
-    // With custom threshold (5), files SHOULD collapse
-    const collapsed = generateCodebaseMap(base, { collapseThreshold: 5 });
-    assert.ok(collapsed.content.includes("10 files"));
-    assert.ok(!collapsed.content.includes("`src/comp0.ts`\n"));
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("updateCodebaseMap: respects excludePatterns option", () => {
-  const base = makeTmpRepo();
-  try {
-    addFile(base, "src/main.ts");
-    addFile(base, "vendor-extra/lib.js");
-
-    const initial = generateCodebaseMap(base);
-    writeCodebaseMap(base, initial.content);
-
-    // Update with exclusion should remove vendor-extra files
-    const result = updateCodebaseMap(base, { excludePatterns: ["vendor-extra/"] });
-    assert.ok(result.content.includes("`src/main.ts`"));
-    assert.ok(!result.content.includes("vendor-extra"));
-  } finally {
-    cleanup(base);
-  }
-});

package/src/resources/extensions/gsd/tests/complexity-classifier.test.ts

@@ -1,7 +1,7 @@
-import test, { describe } from "node:test";
+import test from "node:test";
 import assert from "node:assert/strict";
 
-import { classifyUnitComplexity, tierLabel, tierOrdinal, extractTaskMetadata } from "../complexity-classifier.js";
+import { classifyUnitComplexity, tierLabel, tierOrdinal } from "../complexity-classifier.js";
 import type { ComplexityTier, TaskMetadata } from "../complexity-classifier.js";
 
 // ─── tierLabel ───────────────────────────────────────────────────────────────
@@ -179,28 +179,3 @@ test("execute-task with few code blocks stays standard", () => {
   const result = classifyUnitComplexity("execute-task", "M001/S01/T01", "/tmp/fake", undefined, metadata);
   assert.equal(result.tier, "standard");
 });
-
-// ─── ClassificationResult taskMetadata passthrough ───────────────────────────
-
-describe("ClassificationResult taskMetadata", () => {
-  test("classifyUnitComplexity for execute-task returns result with taskMetadata populated", () => {
-    const metadata: TaskMetadata = { fileCount: 3, tags: ["docs"] };
-    const result = classifyUnitComplexity("execute-task", "M001/S01/T01", "/tmp/fake", undefined, metadata);
-    assert.ok(result.taskMetadata !== undefined, "taskMetadata should be populated for execute-task");
-    assert.equal(result.taskMetadata!.tags?.[0], "docs");
-  });
-
-  test("classifyUnitComplexity for hook/xyz returns result with taskMetadata undefined", () => {
-    const result = classifyUnitComplexity("hook/verify", "M001/S01/T01", "/tmp/fake");
-    assert.equal(result.taskMetadata, undefined, "taskMetadata should be undefined for hook units");
-  });
-
-  test("classifyUnitComplexity for plan-slice returns result with taskMetadata undefined", () => {
-    const result = classifyUnitComplexity("plan-slice", "M001/S01", "/tmp/fake");
-    assert.equal(result.taskMetadata, undefined, "taskMetadata should be undefined for plan-slice");
-  });
-
-  test("extractTaskMetadata is importable as a named export and is a function", () => {
-    assert.equal(typeof extractTaskMetadata, "function", "extractTaskMetadata should be a callable function");
-  });
-});

package/src/resources/extensions/gsd/tests/db-path-worktree-symlink.test.ts

@@ -94,11 +94,11 @@ const dynamicToolsSrc = readFileSync(
   "utf-8",
 );
 
-// ensureDbOpen should surface diagnostic context, not just boolean false
-// Check that the catch block logs error details via workflow-logger
+// ensureDbOpen should return a structured result, not just boolean false
+// Check that the catch block provides diagnostic information
 assertTrue(
-  dynamicToolsSrc.includes("ensureDbOpen failed") && dynamicToolsSrc.includes("logWarning"),
-  "ensureDbOpen catch block surfaces diagnostic information via logWarning instead of bare false (#2517)",
+  dynamicToolsSrc.includes("resolvedPath") || dynamicToolsSrc.includes("diagnostic"),
+  "ensureDbOpen catch block surfaces diagnostic information (resolvedPath or diagnostic) instead of bare false (#2517)",
 );
 
 // ── Part 3: post-unit does NOT artifact-retry on db_unavailable ──────────