gsd-pi 2.33.1 → 2.34.0-dev.bbb5216

package/dist/resources/extensions/gsd/tests/doctor-fixlevel.test.ts

@@ -1,245 +0,0 @@
-/**
- * Tests that doctor's fixLevel option correctly separates task-level
- * bookkeeping from completion state transitions.
- *
- * fixLevel:"task" — fixes task checkboxes, does NOT create slice summary
- *   stubs, UAT stubs, or mark slices done in the roadmap.
- * fixLevel:"all" (default) — fixes everything including completion transitions.
- */
-
-import { mkdirSync, writeFileSync, rmSync, readFileSync, existsSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import test from "node:test";
-import assert from "node:assert/strict";
-import { runGSDDoctor } from "../doctor.ts";
-
-function makeTmp(name: string): string {
-  const dir = join(tmpdir(), `doctor-fixlevel-${name}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-  mkdirSync(dir, { recursive: true });
-  return dir;
-}
-
-/**
- * Build a minimal .gsd structure: milestone with one slice, one task
- * marked done with a summary — but no slice summary and roadmap unchecked.
- * This is exactly the state after the last task completes.
- */
-function buildScaffold(base: string) {
-  const gsd = join(base, ".gsd");
-  const m = join(gsd, "milestones", "M001");
-  const s = join(m, "slices", "S01", "tasks");
-  mkdirSync(s, { recursive: true });
-
-  writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
-  > Demo text
-`);
-
-  writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
-
-**Goal:** test
-
-## Tasks
-
-- [x] **T01: Do stuff** \`est:5m\`
-`);
-
-  writeFileSync(join(s, "T01-SUMMARY.md"), `---
-id: T01
-parent: S01
-milestone: M001
-duration: 5m
-verification_result: passed
-completed_at: 2026-01-01
----
-
-# T01: Do stuff
-
-Done.
-`);
-}
-
-test("fixLevel:task — detects completion issues but does NOT create summary stub or mark roadmap", async () => {
-  const tmp = makeTmp("task-level");
-  try {
-    buildScaffold(tmp);
-
-    const report = await runGSDDoctor(tmp, { fix: true, fixLevel: "task" });
-
-    // Should detect the issues
-    const codes = report.issues.map(i => i.code);
-    assert.ok(codes.includes("all_tasks_done_missing_slice_summary"), "should detect missing summary");
-    assert.ok(codes.includes("all_tasks_done_roadmap_not_checked"), "should detect unchecked roadmap");
-
-    // Should NOT have fixed them
-    const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
-    assert.ok(!existsSync(sliceSummaryPath), "should NOT have created summary stub");
-
-    const roadmapContent = readFileSync(join(tmp, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "utf8");
-    assert.ok(roadmapContent.includes("- [ ] **S01"), "roadmap should still show S01 as unchecked");
-
-    // Fixes applied should NOT include completion artifacts
-    for (const f of report.fixesApplied) {
-      assert.ok(!f.includes("SUMMARY"), `should not have fixed summary: ${f}`);
-      assert.ok(!f.includes("roadmap"), `should not have fixed roadmap: ${f}`);
-    }
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});
-
-test("fixLevel:all (default) — detects AND fixes completion issues", async () => {
-  const tmp = makeTmp("all-level");
-  try {
-    buildScaffold(tmp);
-
-    const report = await runGSDDoctor(tmp, { fix: true });
-
-    // Should detect the issues
-    const codes = report.issues.map(i => i.code);
-    assert.ok(codes.includes("all_tasks_done_missing_slice_summary"), "should detect missing summary");
-    assert.ok(codes.includes("all_tasks_done_roadmap_not_checked"), "should detect unchecked roadmap");
-
-    // SHOULD have fixed them
-    const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
-    assert.ok(existsSync(sliceSummaryPath), "should have created summary stub");
-
-    const roadmapContent = readFileSync(join(tmp, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "utf8");
-    assert.ok(roadmapContent.includes("- [x] **S01"), "roadmap should show S01 as checked");
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});
-
-test("fixLevel:all — marks indented roadmap checkboxes done (#1063)", async () => {
-  const tmp = makeTmp("indented-roadmap");
-  try {
-    buildScaffold(tmp);
-
-    // Overwrite roadmap with indented checkbox (LLM formatting drift)
-    writeFileSync(join(tmp, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-  - [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
-    > Demo text
-`);
-
-    const report = await runGSDDoctor(tmp, { fix: true });
-
-    const roadmapContent = readFileSync(join(tmp, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "utf8");
-    // Should mark [x] while preserving the leading whitespace
-    assert.ok(roadmapContent.includes("  - [x] **S01"), "indented roadmap checkbox should be marked done");
-    // Verify indentation is preserved: line should start with "  -", not just "-"
-    const checkedLine = roadmapContent.split("\n").find(l => l.includes("[x] **S01"));
-    assert.ok(checkedLine?.startsWith("  -"), `should preserve leading whitespace, got: "${checkedLine}"`);
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});
-
-test("fixLevel:all — marks indented task checkboxes done (#1063)", async () => {
-  const tmp = makeTmp("indented-task");
-  try {
-    const gsd = join(tmp, ".gsd");
-    const m = join(gsd, "milestones", "M001");
-    const s = join(m, "slices", "S01", "tasks");
-    mkdirSync(s, { recursive: true });
-
-    writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
-`);
-
-    // Plan with indented checkbox
-    writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
-
-**Goal:** test
-
-## Tasks
-
-  - [ ] **T01: Do stuff** \`est:5m\`
-`);
-
-    writeFileSync(join(s, "T01-SUMMARY.md"), `---
-id: T01
-parent: S01
-milestone: M001
-duration: 5m
-verification_result: passed
-completed_at: 2026-01-01
----
-
-# T01: Do stuff
-
-Done.
-`);
-
-    const report = await runGSDDoctor(tmp, { fix: true, fixLevel: "task" });
-
-    const planContent = readFileSync(join(m, "slices", "S01", "S01-PLAN.md"), "utf8");
-    assert.ok(planContent.includes("  - [x] **T01"), "indented task checkbox should be marked done");
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});
-
-test("fixLevel:task — still fixes task-level bookkeeping (checkbox marking)", async () => {
-  const tmp = makeTmp("task-checkbox");
-  try {
-    const gsd = join(tmp, ".gsd");
-    const m = join(gsd, "milestones", "M001");
-    const s = join(m, "slices", "S01", "tasks");
-    mkdirSync(s, { recursive: true });
-
-    writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
-  > Demo text
-`);
-
-    // Task NOT checked in plan but has a summary — doctor should mark it done
-    writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
-
-**Goal:** test
-
-## Tasks
-
-- [ ] **T01: Do stuff** \`est:5m\`
-`);
-
-    writeFileSync(join(s, "T01-SUMMARY.md"), `---
-id: T01
-parent: S01
-milestone: M001
-duration: 5m
-verification_result: passed
-completed_at: 2026-01-01
----
-
-# T01: Do stuff
-
-Done.
-`);
-
-    const report = await runGSDDoctor(tmp, { fix: true, fixLevel: "task" });
-
-    // Should have fixed the task checkbox
-    const planContent = readFileSync(join(m, "slices", "S01", "S01-PLAN.md"), "utf8");
-    assert.ok(planContent.includes("- [x] **T01"), "should have marked T01 done in plan");
-
-    // Should NOT have touched slice-level completion
-    const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
-    assert.ok(!existsSync(sliceSummaryPath), "should NOT have created summary stub");
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});

package/dist/resources/extensions/gsd/tests/doctor-git.test.ts

@@ -1,344 +0,0 @@
-/**
- * doctor-git.test.ts — Integration tests for doctor git health checks.
- *
- * Creates real temp git repos with deliberate broken state, runs runGSDDoctor,
- * and asserts correct detection and fixing of all 4 git issue codes:
- *   orphaned_auto_worktree, stale_milestone_branch,
- *   corrupt_merge_state, tracked_runtime_files
- */
-
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, existsSync, realpathSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { execSync } from "node:child_process";
-
-import { runGSDDoctor } from "../doctor.ts";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-function run(cmd: string, cwd: string): string {
-  return execSync(cmd, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-/** Create a temp git repo with a completed milestone M001 in roadmap. */
-function createRepoWithCompletedMilestone(): string {
-  const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-git-test-")));
-  run("git init", dir);
-  run("git config user.email test@test.com", dir);
-  run("git config user.name Test", dir);
-
-  // Initial commit
-  writeFileSync(join(dir, "README.md"), "# test\n");
-  run("git add .", dir);
-  run("git commit -m init", dir);
-  run("git branch -M main", dir);
-
-  // Create .gsd structure with milestone M001 — all slices done → complete
-  const msDir = join(dir, ".gsd", "milestones", "M001");
-  mkdirSync(msDir, { recursive: true });
-  writeFileSync(join(msDir, "ROADMAP.md"), `---
-id: M001
-title: "Test Milestone"
----
-
-# M001: Test Milestone
-
-## Vision
-Test
-
-## Success Criteria
-- Done
-
-## Slices
-- [x] **S01: Test slice** \`risk:low\` \`depends:[]\`
-  > After this: done
-
-## Boundary Map
-_None_
-`);
-
-  // Commit .gsd files
-  run("git add -A", dir);
-  run("git commit -m \"add milestone\"", dir);
-
-  return dir;
-}
-
-/** Write a .gsd/preferences.md with the given git isolation mode. */
-function writePreferencesFile(dir: string, isolation: "none" | "worktree" | "branch"): void {
-  const gsdDir = join(dir, ".gsd");
-  mkdirSync(gsdDir, { recursive: true });
-  writeFileSync(join(gsdDir, "preferences.md"), `---\ngit:\n  isolation: "${isolation}"\n---\n`);
-}
-
-/** Create a repo with an in-progress milestone. */
-function createRepoWithActiveMilestone(): string {
-  const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-git-test-")));
-  run("git init", dir);
-  run("git config user.email test@test.com", dir);
-  run("git config user.name Test", dir);
-
-  writeFileSync(join(dir, "README.md"), "# test\n");
-  run("git add .", dir);
-  run("git commit -m init", dir);
-  run("git branch -M main", dir);
-
-  const msDir = join(dir, ".gsd", "milestones", "M001");
-  mkdirSync(msDir, { recursive: true });
-  writeFileSync(join(msDir, "ROADMAP.md"), `---
-id: M001
-title: "Active Milestone"
----
-
-# M001: Active Milestone
-
-## Vision
-Test
-
-## Success Criteria
-- Done
-
-## Slices
-- [ ] **S01: Test slice** \`risk:low\` \`depends:[]\`
-  > After this: done
-
-## Boundary Map
-_None_
-`);
-
-  run("git add -A", dir);
-  run("git commit -m \"add milestone\"", dir);
-
-  return dir;
-}
-
-async function main(): Promise<void> {
-  const cleanups: string[] = [];
-
-  try {
-    // ─── Test 1: Orphaned worktree detection & fix ─────────────────────
-    // Skip on Windows: git worktree path resolution on Windows temp dirs
-    // uses UNC/8.3 forms that don't survive path normalization. The source
-    // logic is correct (tested on macOS/Linux) — the test infra doesn't
-    // produce matching paths on Windows CI.
-    if (process.platform !== "win32") {
-    console.log("\n=== orphaned_auto_worktree ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Create worktree with milestone/M001 branch under .gsd/worktrees/
-      mkdirSync(join(dir, ".gsd", "worktrees"), { recursive: true });
-      run("git worktree add -b milestone/M001 .gsd/worktrees/M001", dir);
-
-      const detect = await runGSDDoctor(dir, { isolationMode: "worktree" });
-      const orphanIssues = detect.issues.filter(i => i.code === "orphaned_auto_worktree");
-      assertTrue(orphanIssues.length > 0, "detects orphaned worktree");
-      assertEq(orphanIssues[0]?.unitId, "M001", "orphaned worktree unitId is M001");
-
-      const fixed = await runGSDDoctor(dir, { fix: true, isolationMode: "worktree" });
-      assertTrue(fixed.fixesApplied.some(f => f.includes("removed orphaned worktree")), "fix removes orphaned worktree");
-
-      // Verify worktree is gone
-      const wtList = run("git worktree list", dir);
-      assertTrue(!wtList.includes("milestone/M001"), "worktree no longer listed after fix");
-    }
-    } else {
-      console.log("\n=== orphaned_auto_worktree (skipped on Windows) ===");
-    }
-
-    // ─── Test 2: Stale milestone branch detection & fix ────────────────
-    // Skip on Windows: git branch glob matching and path resolution
-    // behave differently in Windows temp dirs.
-    if (process.platform !== "win32") {
-    console.log("\n=== stale_milestone_branch ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Create a milestone/M001 branch (no worktree)
-      run("git branch milestone/M001", dir);
-
-      const detect = await runGSDDoctor(dir, { isolationMode: "worktree" });
-      const staleIssues = detect.issues.filter(i => i.code === "stale_milestone_branch");
-      assertTrue(staleIssues.length > 0, "detects stale milestone branch");
-      assertEq(staleIssues[0]?.unitId, "M001", "stale branch unitId is M001");
-
-      const fixed = await runGSDDoctor(dir, { fix: true, isolationMode: "worktree" });
-      assertTrue(fixed.fixesApplied.some(f => f.includes("deleted stale branch")), "fix deletes stale branch");
-
-      // Verify branch is gone
-      const branches = run("git branch --list milestone/*", dir);
-      assertTrue(!branches.includes("milestone/M001"), "branch gone after fix");
-    }
-    } else {
-      console.log("\n=== stale_milestone_branch (skipped on Windows) ===");
-    }
-
-    // ─── Test 3: Corrupt merge state detection & fix ───────────────────
-    console.log("\n=== corrupt_merge_state ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Inject MERGE_HEAD into .git
-      const headHash = run("git rev-parse HEAD", dir);
-      writeFileSync(join(dir, ".git", "MERGE_HEAD"), headHash + "\n");
-
-      const detect = await runGSDDoctor(dir);
-      const mergeIssues = detect.issues.filter(i => i.code === "corrupt_merge_state");
-      assertTrue(mergeIssues.length > 0, "detects corrupt merge state");
-
-      const fixed = await runGSDDoctor(dir, { fix: true });
-      assertTrue(fixed.fixesApplied.some(f => f.includes("cleaned merge state")), "fix cleans merge state");
-
-      // Verify MERGE_HEAD is gone
-      assertTrue(!existsSync(join(dir, ".git", "MERGE_HEAD")), "MERGE_HEAD removed after fix");
-    }
-
-    // ─── Test 4: Tracked runtime files detection & fix ─────────────────
-    console.log("\n=== tracked_runtime_files ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Force-add a runtime file
-      const activityDir = join(dir, ".gsd", "activity");
-      mkdirSync(activityDir, { recursive: true });
-      writeFileSync(join(activityDir, "test.log"), "log data\n");
-      run("git add -f .gsd/activity/test.log", dir);
-      run("git commit -m \"track runtime file\"", dir);
-
-      const detect = await runGSDDoctor(dir);
-      const trackedIssues = detect.issues.filter(i => i.code === "tracked_runtime_files");
-      assertTrue(trackedIssues.length > 0, "detects tracked runtime files");
-
-      const fixed = await runGSDDoctor(dir, { fix: true });
-      assertTrue(fixed.fixesApplied.some(f => f.includes("untracked")), "fix untracks runtime files");
-
-      // Verify file is no longer tracked
-      const tracked = run("git ls-files .gsd/activity/", dir);
-      assertEq(tracked, "", "runtime file untracked after fix");
-    }
-
-    // ─── Test 5: Non-git directory — graceful degradation ──────────────
-    console.log("\n=== non-git directory ===");
-    {
-      const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-git-test-")));
-      cleanups.push(dir);
-
-      // Create minimal .gsd structure (no git)
-      mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-      const result = await runGSDDoctor(dir);
-      const gitIssues = result.issues.filter(i =>
-        ["orphaned_auto_worktree", "stale_milestone_branch", "corrupt_merge_state", "tracked_runtime_files"].includes(i.code)
-      );
-      assertEq(gitIssues.length, 0, "no git issues in non-git directory");
-      // Should not throw — reaching here means no crash
-      assertTrue(true, "non-git directory does not crash");
-    }
-
-    // ─── Test 6: Active worktree NOT flagged (false positive prevention) ─
-    if (process.platform !== "win32") {
-    console.log("\n=== active worktree safety ===");
-    {
-      const dir = createRepoWithActiveMilestone();
-      cleanups.push(dir);
-
-      // Create worktree for in-progress milestone under .gsd/worktrees/
-      mkdirSync(join(dir, ".gsd", "worktrees"), { recursive: true });
-      run("git worktree add -b milestone/M001 .gsd/worktrees/M001", dir);
-
-      const detect = await runGSDDoctor(dir, { isolationMode: "worktree" });
-      const orphanIssues = detect.issues.filter(i => i.code === "orphaned_auto_worktree");
-      assertEq(orphanIssues.length, 0, "active worktree NOT flagged as orphaned");
-    }
-    } else {
-      console.log("\n=== active worktree safety (skipped on Windows) ===");
-    }
-
-    // ─── Test 7: none-mode skips orphaned worktree check ───────────────
-    // NOTE: loadEffectiveGSDPreferences() resolves PROJECT_PREFERENCES_PATH
-    // at module load time from process.cwd(). We write the prefs file to
-    // the test runner's cwd .gsd/preferences.md and clean up afterwards.
-    if (process.platform !== "win32") {
-    console.log("\n=== none-mode skips orphaned worktree ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Create worktree with milestone/M001 branch under .gsd/worktrees/
-      mkdirSync(join(dir, ".gsd", "worktrees"), { recursive: true });
-      run("git worktree add -b milestone/M001 .gsd/worktrees/M001", dir);
-
-      const result = await runGSDDoctor(dir, { isolationMode: "none" });
-      const orphanIssues = result.issues.filter(i => i.code === "orphaned_auto_worktree");
-      assertEq(orphanIssues.length, 0, "none-mode: orphaned worktree NOT detected");
-    }
-    } else {
-      console.log("\n=== none-mode skips orphaned worktree (skipped on Windows) ===");
-    }
-
-    // ─── Test 8: none-mode skips stale branch check ────────────────────
-    if (process.platform !== "win32") {
-    console.log("\n=== none-mode skips stale branch ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Create a milestone/M001 branch (no worktree)
-      run("git branch milestone/M001", dir);
-
-      const result = await runGSDDoctor(dir, { isolationMode: "none" });
-      const staleIssues = result.issues.filter(i => i.code === "stale_milestone_branch");
-      assertEq(staleIssues.length, 0, "none-mode: stale branch NOT detected");
-    }
-    } else {
-      console.log("\n=== none-mode skips stale branch (skipped on Windows) ===");
-    }
-
-    // ─── Test 9: none-mode still detects corrupt merge state ───────────
-    console.log("\n=== none-mode keeps corrupt merge state ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Inject MERGE_HEAD into .git
-      const headHash = run("git rev-parse HEAD", dir);
-      writeFileSync(join(dir, ".git", "MERGE_HEAD"), headHash + "\n");
-
-      const result = await runGSDDoctor(dir, { isolationMode: "none" });
-      const mergeIssues = result.issues.filter(i => i.code === "corrupt_merge_state");
-      assertTrue(mergeIssues.length > 0, "none-mode: corrupt merge state IS detected");
-    }
-
-    // ─── Test 10: none-mode still detects tracked runtime files ────────
-    console.log("\n=== none-mode keeps tracked runtime files ===");
-    {
-      const dir = createRepoWithCompletedMilestone();
-      cleanups.push(dir);
-
-      // Force-add a runtime file
-      const activityDir = join(dir, ".gsd", "activity");
-      mkdirSync(activityDir, { recursive: true });
-      writeFileSync(join(activityDir, "test.log"), "log data\n");
-      run("git add -f .gsd/activity/test.log", dir);
-      run("git commit -m \"track runtime file\"", dir);
-
-      const result = await runGSDDoctor(dir, { isolationMode: "none" });
-      const trackedIssues = result.issues.filter(i => i.code === "tracked_runtime_files");
-      assertTrue(trackedIssues.length > 0, "none-mode: tracked runtime files IS detected");
-    }
-
-  } finally {
-    for (const dir of cleanups) {
-      try { rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
-    }
-  }
-
-  report();
-}
-
-main();