gsd-pi 2.33.1 → 2.34.0-dev.bbb5216

package/dist/resources/extensions/gsd/tests/agent-end-retry.test.ts

@@ -1,107 +0,0 @@
-/**
- * agent-end-retry.test.ts — Verifies the deferred agent_end retry mechanism (#1072).
- *
- * When handleAgentEnd is already running and a second agent_end event fires
- * (e.g. a hook/triage/quick-task unit dispatched inside handleAgentEnd completes
- * before it returns), the reentrancy guard must not silently drop the event.
- * Instead, it should queue a retry via pendingAgentEndRetry so the completed
- * unit's agent_end is processed after the current handler finishes.
- *
- * Without this, auto-mode can stall permanently in the "summarizing" phase
- * with no unit running and no watchdog set.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const AUTO_TS_PATH = join(__dirname, "..", "auto.ts");
-const SESSION_TS_PATH = join(__dirname, "..", "auto", "session.ts");
-
-function getAutoTsSource(): string {
-  return readFileSync(AUTO_TS_PATH, "utf-8");
-}
-
-function getSessionTsSource(): string {
-  return readFileSync(SESSION_TS_PATH, "utf-8");
-}
-
-// ── AutoSession must declare pendingAgentEndRetry ────────────────────────────
-
-test("AutoSession declares pendingAgentEndRetry field", () => {
-  const source = getSessionTsSource();
-  assert.ok(
-    source.includes("pendingAgentEndRetry"),
-    "AutoSession (auto/session.ts) must declare pendingAgentEndRetry field for deferred retry",
-  );
-});
-
-test("AutoSession resets pendingAgentEndRetry in reset()", () => {
-  const source = getSessionTsSource();
-  // Find the reset() method — it's declared as "reset(): void {"
-  const resetIdx = source.indexOf("reset(): void");
-  assert.ok(resetIdx > -1, "AutoSession must have a reset() method");
-  const resetBlock = source.slice(resetIdx, resetIdx + 3000);
-  assert.ok(
-    resetBlock.includes("pendingAgentEndRetry"),
-    "reset() must clear pendingAgentEndRetry",
-  );
-});
-
-// ── handleAgentEnd reentrancy guard must queue retry ─────────────────────────
-
-test("handleAgentEnd sets pendingAgentEndRetry when reentrant", () => {
-  const source = getAutoTsSource();
-  // Find the handleAgentEnd function
-  const fnIdx = source.indexOf("export async function handleAgentEnd");
-  assert.ok(fnIdx > -1, "handleAgentEnd must exist in auto.ts");
-
-  // The reentrancy guard section (within ~500 chars of the function start)
-  const guardBlock = source.slice(fnIdx, fnIdx + 800);
-  assert.ok(
-    guardBlock.includes("s.handlingAgentEnd"),
-    "handleAgentEnd must check s.handlingAgentEnd",
-  );
-  assert.ok(
-    guardBlock.includes("pendingAgentEndRetry = true"),
-    "reentrancy guard must set pendingAgentEndRetry = true instead of silently dropping (#1072)",
-  );
-});
-
-// ── finally block must process pendingAgentEndRetry ──────────────────────────
-
-test("handleAgentEnd finally block retries if pendingAgentEndRetry is set", () => {
-  const source = getAutoTsSource();
-  const fnIdx = source.indexOf("export async function handleAgentEnd");
-  assert.ok(fnIdx > -1, "handleAgentEnd must exist");
-
-  // Find the finally block within handleAgentEnd (search for the closing pattern)
-  const fnBlock = source.slice(fnIdx, source.indexOf("\n// ─── ", fnIdx + 100));
-  assert.ok(
-    fnBlock.includes("pendingAgentEndRetry"),
-    "handleAgentEnd finally block must check pendingAgentEndRetry",
-  );
-  assert.ok(
-    fnBlock.includes("setImmediate"),
-    "deferred retry must use setImmediate to avoid stack overflow (#1072)",
-  );
-  assert.ok(
-    fnBlock.includes("handleAgentEnd(ctx, pi)"),
-    "deferred retry must call handleAgentEnd recursively (#1072)",
-  );
-});
-
-// ── Regression: reentrancy guard must NOT silently return ─────────────────────
-
-test("reentrancy guard references issue #1072", () => {
-  const source = getAutoTsSource();
-  const fnIdx = source.indexOf("export async function handleAgentEnd");
-  const guardBlock = source.slice(fnIdx, fnIdx + 800);
-  assert.ok(
-    guardBlock.includes("1072"),
-    "reentrancy guard comment must reference #1072 for traceability",
-  );
-});

package/dist/resources/extensions/gsd/tests/all-milestones-complete-merge.test.ts

@@ -1,200 +0,0 @@
-/**
- * all-milestones-complete-merge.test.ts — Tests for #962 fix.
- *
- * Verifies that when the final milestone completes and there are no queued
- * follow-up milestones, the worktree is squash-merged to main before
- * stopAuto() tears it down. Without this fix, all work stays on the
- * milestone branch, unmerged to main.
- *
- * Uses both source-level checks (verifying the code path exists in auto.ts)
- * and real git integration tests (verifying merge behavior).
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync, realpathSync, readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { tmpdir } from "node:os";
-import { execSync } from "node:child_process";
-import { fileURLToPath } from "node:url";
-
-import {
-  createAutoWorktree,
-  isInAutoWorktree,
-  getAutoWorktreeOriginalBase,
-  mergeMilestoneToMain,
-} from "../auto-worktree.ts";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-function run(command: string, cwd: string): string {
-  return execSync(command, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-function createTempRepo(): string {
-  const dir = realpathSync(mkdtempSync(join(tmpdir(), "gsd-all-complete-test-")));
-  run("git init", dir);
-  run("git config user.email test@test.com", dir);
-  run("git config user.name Test", dir);
-  writeFileSync(join(dir, "README.md"), "# test\n");
-  // Mirror production: .gsd/worktrees/ is gitignored so autoCommitDirtyState
-  // doesn't pick up the worktrees directory as dirty state (#1127 fix).
-  writeFileSync(join(dir, ".gitignore"), ".gsd/worktrees/\n");
-  run("git add .", dir);
-  run("git commit -m init", dir);
-  run("git branch -M main", dir);
-  return dir;
-}
-
-function createMilestoneArtifacts(dir: string, mid: string): void {
-  const msDir = join(dir, ".gsd", "milestones", mid);
-  mkdirSync(msDir, { recursive: true });
-  writeFileSync(join(msDir, "CONTEXT.md"), `# ${mid} Context\n`);
-  const roadmap = [
-    `# ${mid}: Test Milestone`,
-    "**Vision**: testing",
-    "## Success Criteria",
-    "- It works",
-    "## Slices",
-    "- [x] S01 — First slice",
-  ].join("\n");
-  writeFileSync(join(msDir, `${mid}-ROADMAP.md`), roadmap);
-}
-
-// ─── Source-level: verify the merge code exists in the "all complete" path ────
-
-test("auto.ts 'all milestones complete' path merges before stopping (#962)", () => {
-  const autoSrc = readFileSync(join(__dirname, "..", "auto.ts"), "utf-8");
-
-  // Find the "incomplete.length === 0" block
-  const incompleteIdx = autoSrc.indexOf("incomplete.length === 0");
-  assert.ok(incompleteIdx > -1, "auto.ts should have 'incomplete.length === 0' check");
-
-  // The merge call must appear BETWEEN the incomplete check and the stopAuto call.
-  // After the #1308 refactor, the merge is delegated to tryMergeMilestone.
-  const blockAfterIncomplete = autoSrc.slice(incompleteIdx, incompleteIdx + 3000);
-
-  assert.ok(
-    blockAfterIncomplete.includes("tryMergeMilestone"),
-    "auto.ts should call tryMergeMilestone in the 'all milestones complete' path",
-  );
-
-  // The merge should come before stopAuto in this block
-  const mergePos = blockAfterIncomplete.indexOf("tryMergeMilestone");
-  const stopPos = blockAfterIncomplete.indexOf("stopAuto");
-  assert.ok(
-    mergePos < stopPos,
-    "tryMergeMilestone should be called before stopAuto in the 'all complete' path",
-  );
-
-  // Verify tryMergeMilestone handles both worktree and branch isolation
-  const helperIdx = autoSrc.indexOf("function tryMergeMilestone");
-  assert.ok(helperIdx > -1, "tryMergeMilestone helper should exist");
-  const helperBlock = autoSrc.slice(helperIdx, helperIdx + 2000);
-  assert.ok(
-    helperBlock.includes("isInAutoWorktree"),
-    "tryMergeMilestone should check isInAutoWorktree for worktree mode",
-  );
-  assert.ok(
-    helperBlock.includes("getIsolationMode") || helperBlock.includes("isolationMode"),
-    "tryMergeMilestone should check isolation mode for branch mode",
-  );
-});
-
-// ─── Integration: single milestone completes → merged to main ────────────────
-
-test("single milestone worktree is merged to main when all complete (#962)", () => {
-  const savedCwd = process.cwd();
-  let tempDir = "";
-
-  try {
-    tempDir = createTempRepo();
-
-    // Set up a single milestone
-    createMilestoneArtifacts(tempDir, "M001");
-    run("git add .", tempDir);
-    run('git commit -m "add milestone"', tempDir);
-
-    // Create worktree and simulate work
-    const wt = createAutoWorktree(tempDir, "M001");
-    assert.ok(isInAutoWorktree(tempDir), "should be in auto-worktree");
-
-    writeFileSync(join(wt, "feature.ts"), "export const feature = true;\n");
-    run("git add .", wt);
-    run('git commit -m "feat(M001): add feature"', wt);
-
-    // Simulate the fix: merge before stopping (what the "all complete" path now does)
-    const roadmapPath = join(tempDir, ".gsd", "milestones", "M001", "M001-ROADMAP.md");
-    const roadmapContent = readFileSync(roadmapPath, "utf-8");
-    const mergeResult = mergeMilestoneToMain(tempDir, "M001", roadmapContent);
-
-    // Verify work is on main
-    assert.ok(existsSync(join(tempDir, "feature.ts")), "feature.ts should be on main after merge");
-    assert.equal(process.cwd(), tempDir, "cwd restored to project root");
-    assert.ok(!isInAutoWorktree(tempDir), "no longer in auto-worktree");
-    assert.equal(getAutoWorktreeOriginalBase(), null, "originalBase cleared");
-
-    // Verify milestone branch was cleaned up
-    const branches = run("git branch", tempDir);
-    assert.ok(!branches.includes("milestone/M001"), "milestone branch should be deleted");
-
-    // Verify squash commit on main
-    const log = run("git log --oneline -3", tempDir);
-    assert.ok(log.includes("M001"), "squash commit on main should reference M001");
-
-    assert.ok(mergeResult.commitMessage.length > 0, "commit message returned");
-  } finally {
-    process.chdir(savedCwd);
-    if (tempDir && existsSync(tempDir)) {
-      rmSync(tempDir, { recursive: true, force: true });
-    }
-  }
-});
-
-// ─── Integration: last of multiple milestones completes → merged ─────────────
-
-test("last milestone worktree is merged when it's the final one (#962)", () => {
-  const savedCwd = process.cwd();
-  let tempDir = "";
-
-  try {
-    tempDir = createTempRepo();
-
-    // Set up two milestones
-    createMilestoneArtifacts(tempDir, "M001");
-    createMilestoneArtifacts(tempDir, "M002");
-    run("git add .", tempDir);
-    run('git commit -m "add milestones"', tempDir);
-
-    // Complete M001 first (merge it)
-    const wt1 = createAutoWorktree(tempDir, "M001");
-    writeFileSync(join(wt1, "m001-work.ts"), "export const m001 = true;\n");
-    run("git add .", wt1);
-    run('git commit -m "feat(M001): m001 work"', wt1);
-    const roadmap1 = readFileSync(join(tempDir, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "utf-8");
-    mergeMilestoneToMain(tempDir, "M001", roadmap1);
-
-    // Now complete M002 (the LAST milestone — this is the #962 scenario)
-    const wt2 = createAutoWorktree(tempDir, "M002");
-    writeFileSync(join(wt2, "m002-work.ts"), "export const m002 = true;\n");
-    run("git add .", wt2);
-    run('git commit -m "feat(M002): m002 work"', wt2);
-    const roadmap2 = readFileSync(join(tempDir, ".gsd", "milestones", "M002", "M002-ROADMAP.md"), "utf-8");
-    mergeMilestoneToMain(tempDir, "M002", roadmap2);
-
-    // Both features should now be on main
-    assert.ok(existsSync(join(tempDir, "m001-work.ts")), "M001 work on main");
-    assert.ok(existsSync(join(tempDir, "m002-work.ts")), "M002 work on main");
-    assert.ok(!isInAutoWorktree(tempDir), "not in worktree after final merge");
-
-    // Both milestone branches should be cleaned up
-    const branches = run("git branch", tempDir);
-    assert.ok(!branches.includes("milestone/M001"), "M001 branch deleted");
-    assert.ok(!branches.includes("milestone/M002"), "M002 branch deleted");
-  } finally {
-    process.chdir(savedCwd);
-    if (tempDir && existsSync(tempDir)) {
-      rmSync(tempDir, { recursive: true, force: true });
-    }
-  }
-});

package/dist/resources/extensions/gsd/tests/auto-budget-alerts.test.ts

@@ -1,50 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  getBudgetAlertLevel,
-  getBudgetEnforcementAction,
-  getNewBudgetAlertLevel,
-} from "../auto-budget.js";
-
-test("getBudgetAlertLevel returns the expected threshold bucket", () => {
-  assert.equal(getBudgetAlertLevel(0.10), 0);
-  assert.equal(getBudgetAlertLevel(0.74), 0);
-  assert.equal(getBudgetAlertLevel(0.75), 75);
-  assert.equal(getBudgetAlertLevel(0.79), 75);
-  assert.equal(getBudgetAlertLevel(0.80), 80);
-  assert.equal(getBudgetAlertLevel(0.85), 80);
-  assert.equal(getBudgetAlertLevel(0.89), 80);
-  assert.equal(getBudgetAlertLevel(0.90), 90);
-  assert.equal(getBudgetAlertLevel(1.00), 100);
-});
-
-test("getNewBudgetAlertLevel only emits once per threshold", () => {
-  assert.equal(getNewBudgetAlertLevel(0, 0.74), null);
-  assert.equal(getNewBudgetAlertLevel(0, 0.75), 75);
-  assert.equal(getNewBudgetAlertLevel(75, 0.79), null);
-  assert.equal(getNewBudgetAlertLevel(75, 0.80), 80);
-  assert.equal(getNewBudgetAlertLevel(80, 0.85), null);
-  assert.equal(getNewBudgetAlertLevel(80, 0.90), 90);
-  assert.equal(getNewBudgetAlertLevel(90, 0.95), null);
-  assert.equal(getNewBudgetAlertLevel(90, 1.0), 100);
-  assert.equal(getNewBudgetAlertLevel(100, 1.2), null);
-});
-
-test("80% alert fires exactly once between 75% and 90%", () => {
-  // Transition from 75 → 80 emits 80
-  assert.equal(getNewBudgetAlertLevel(75, 0.80), 80);
-  // Already at 80 — no re-emission
-  assert.equal(getNewBudgetAlertLevel(80, 0.82), null);
-  assert.equal(getNewBudgetAlertLevel(80, 0.89), null);
-  // Transition from 80 → 90 emits 90
-  assert.equal(getNewBudgetAlertLevel(80, 0.90), 90);
-});
-
-test("getBudgetEnforcementAction maps the configured ceiling behavior", () => {
-  assert.equal(getBudgetEnforcementAction("warn", 0.80), "none");
-  assert.equal(getBudgetEnforcementAction("warn", 0.99), "none");
-  assert.equal(getBudgetEnforcementAction("warn", 1.0), "warn");
-  assert.equal(getBudgetEnforcementAction("pause", 1.0), "pause");
-  assert.equal(getBudgetEnforcementAction("halt", 1.0), "halt");
-});

package/dist/resources/extensions/gsd/tests/auto-dashboard.test.ts

@@ -1,166 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  unitVerb,
-  unitPhaseLabel,
-  describeNextUnit,
-  formatAutoElapsed,
-  formatWidgetTokens,
-  estimateTimeRemaining,
-} from "../auto-dashboard.ts";
-
-// ─── unitVerb ─────────────────────────────────────────────────────────────
-
-test("unitVerb maps known unit types to verbs", () => {
-  assert.equal(unitVerb("research-milestone"), "researching");
-  assert.equal(unitVerb("research-slice"), "researching");
-  assert.equal(unitVerb("plan-milestone"), "planning");
-  assert.equal(unitVerb("plan-slice"), "planning");
-  assert.equal(unitVerb("execute-task"), "executing");
-  assert.equal(unitVerb("complete-slice"), "completing");
-  assert.equal(unitVerb("replan-slice"), "replanning");
-  assert.equal(unitVerb("reassess-roadmap"), "reassessing");
-  assert.equal(unitVerb("run-uat"), "running UAT");
-});
-
-test("unitVerb returns raw type for unknown types", () => {
-  assert.equal(unitVerb("custom-thing"), "custom-thing");
-});
-
-test("unitVerb handles hook types", () => {
-  assert.equal(unitVerb("hook/verify-code"), "hook: verify-code");
-  assert.equal(unitVerb("hook/"), "hook: ");
-});
-
-// ─── unitPhaseLabel ───────────────────────────────────────────────────────
-
-test("unitPhaseLabel maps known types to labels", () => {
-  assert.equal(unitPhaseLabel("research-milestone"), "RESEARCH");
-  assert.equal(unitPhaseLabel("research-slice"), "RESEARCH");
-  assert.equal(unitPhaseLabel("plan-milestone"), "PLAN");
-  assert.equal(unitPhaseLabel("plan-slice"), "PLAN");
-  assert.equal(unitPhaseLabel("execute-task"), "EXECUTE");
-  assert.equal(unitPhaseLabel("complete-slice"), "COMPLETE");
-  assert.equal(unitPhaseLabel("replan-slice"), "REPLAN");
-  assert.equal(unitPhaseLabel("reassess-roadmap"), "REASSESS");
-  assert.equal(unitPhaseLabel("run-uat"), "UAT");
-});
-
-test("unitPhaseLabel uppercases unknown types", () => {
-  assert.equal(unitPhaseLabel("custom-thing"), "CUSTOM-THING");
-});
-
-test("unitPhaseLabel returns HOOK for hook types", () => {
-  assert.equal(unitPhaseLabel("hook/verify"), "HOOK");
-});
-
-// ─── describeNextUnit ─────────────────────────────────────────────────────
-
-test("describeNextUnit handles pre-planning phase", () => {
-  const result = describeNextUnit({
-    phase: "pre-planning",
-    activeMilestone: { id: "M001", title: "Test" },
-  } as any);
-  assert.equal(result.label, "Research & plan milestone");
-});
-
-test("describeNextUnit handles executing phase", () => {
-  const result = describeNextUnit({
-    phase: "executing",
-    activeMilestone: { id: "M001", title: "Test" },
-    activeSlice: { id: "S01", title: "Slice" },
-    activeTask: { id: "T01", title: "Task One" },
-  } as any);
-  assert.ok(result.label.includes("T01"));
-  assert.ok(result.label.includes("Task One"));
-});
-
-test("describeNextUnit handles summarizing phase", () => {
-  const result = describeNextUnit({
-    phase: "summarizing",
-    activeMilestone: { id: "M001", title: "Test" },
-    activeSlice: { id: "S01", title: "First Slice" },
-  } as any);
-  assert.ok(result.label.includes("S01"));
-});
-
-test("describeNextUnit handles needs-discussion phase", () => {
-  const result = describeNextUnit({
-    phase: "needs-discussion",
-    activeMilestone: { id: "M001", title: "Test" },
-  } as any);
-  assert.ok(
-    result.label.toLowerCase().includes("discuss") || result.label.toLowerCase().includes("draft"),
-  );
-});
-
-test("describeNextUnit handles completing-milestone phase", () => {
-  const result = describeNextUnit({
-    phase: "completing-milestone",
-    activeMilestone: { id: "M001", title: "Test" },
-  } as any);
-  assert.ok(result.label.toLowerCase().includes("milestone"));
-});
-
-test("describeNextUnit returns fallback for unknown phase", () => {
-  const result = describeNextUnit({
-    phase: "some-future-phase" as any,
-    activeMilestone: { id: "M001", title: "Test" },
-  } as any);
-  assert.equal(result.label, "Continue");
-});
-
-// ─── formatAutoElapsed ────────────────────────────────────────────────────
-
-test("formatAutoElapsed returns empty for zero startTime", () => {
-  assert.equal(formatAutoElapsed(0), "");
-});
-
-test("formatAutoElapsed formats seconds", () => {
-  const result = formatAutoElapsed(Date.now() - 30_000);
-  assert.match(result, /^\d+s$/);
-});
-
-test("formatAutoElapsed formats minutes", () => {
-  const result = formatAutoElapsed(Date.now() - 180_000); // 3 min
-  assert.match(result, /^3m/);
-});
-
-test("formatAutoElapsed formats hours", () => {
-  const result = formatAutoElapsed(Date.now() - 3_700_000); // ~1h
-  assert.match(result, /^1h/);
-});
-
-// ─── formatWidgetTokens ──────────────────────────────────────────────────
-
-test("formatWidgetTokens formats small numbers directly", () => {
-  assert.equal(formatWidgetTokens(0), "0");
-  assert.equal(formatWidgetTokens(500), "500");
-  assert.equal(formatWidgetTokens(999), "999");
-});
-
-test("formatWidgetTokens formats thousands with k", () => {
-  assert.equal(formatWidgetTokens(1000), "1.0k");
-  assert.equal(formatWidgetTokens(5500), "5.5k");
-  assert.equal(formatWidgetTokens(10000), "10k");
-  assert.equal(formatWidgetTokens(99999), "100k");
-});
-
-test("formatWidgetTokens formats millions with M", () => {
-  assert.equal(formatWidgetTokens(1_000_000), "1.0M");
-  assert.equal(formatWidgetTokens(10_000_000), "10M");
-  assert.equal(formatWidgetTokens(25_000_000), "25M");
-});
-
-// ─── estimateTimeRemaining ──────────────────────────────────────────────
-
-test("estimateTimeRemaining returns null when no ledger data", () => {
-  // With no active auto-mode session, ledger is empty
-  const result = estimateTimeRemaining();
-  assert.equal(result, null);
-});
-
-test("estimateTimeRemaining is exported and callable", () => {
-  assert.equal(typeof estimateTimeRemaining, "function");
-});