gsd-pi 2.33.1 → 2.34.0-dev.bbb5216

package/dist/resources/extensions/gsd/tests/dispatch-missing-task-plans.test.ts

@@ -1,132 +0,0 @@
-/**
- * Regression test for issue #909.
- *
- * When S##-PLAN.md exists (causing deriveState → phase:'executing') but the
- * individual task plan files (tasks/T01-PLAN.md, etc.) are absent, the dispatch
- * table must recover by re-running plan-slice — NOT hard-stop.
- *
- * Prior behaviour: action:"stop" → infinite loop on restart.
- * Fixed behaviour: action:"dispatch" unitType:"plan-slice".
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { resolveDispatch } from "../auto-dispatch.ts";
-import type { DispatchContext } from "../auto-dispatch.ts";
-import type { GSDState } from "../types.ts";
-
-function makeState(overrides: Partial<GSDState> = {}): GSDState {
-  return {
-    activeMilestone: { id: "M002", title: "Test Milestone" },
-    activeSlice: { id: "S03", title: "Third Slice" },
-    activeTask: { id: "T01", title: "First Task" },
-    phase: "executing",
-    recentDecisions: [],
-    blockers: [],
-    nextAction: "",
-    registry: [],
-    ...overrides,
-  };
-}
-
-function makeContext(basePath: string, stateOverrides?: Partial<GSDState>): DispatchContext {
-  return {
-    basePath,
-    mid: "M002",
-    midTitle: "Test Milestone",
-    state: makeState(stateOverrides),
-    prefs: undefined,
-  };
-}
-
-// ─── Scaffold helpers ──────────────────────────────────────────────────────
-
-function scaffoldSlicePlan(basePath: string, mid: string, sid: string): void {
-  const dir = join(basePath, ".gsd", "milestones", mid, "slices", sid);
-  mkdirSync(dir, { recursive: true });
-  writeFileSync(join(dir, `${sid}-PLAN.md`), [
-    `# ${sid}: Third Slice`,
-    "",
-    "## Tasks",
-    "- [ ] **T01: Do something** `est:1h`",
-    "- [ ] **T02: Do another thing** `est:30m`",
-    "",
-  ].join("\n"));
-}
-
-function scaffoldTaskPlan(basePath: string, mid: string, sid: string, tid: string): void {
-  const dir = join(basePath, ".gsd", "milestones", mid, "slices", sid, "tasks");
-  mkdirSync(dir, { recursive: true });
-  writeFileSync(join(dir, `${tid}-PLAN.md`), [
-    `# ${tid}: Do something`,
-    "",
-    "## Steps",
-    "- [ ] Step 1",
-    "",
-  ].join("\n"));
-}
-
-// ─── Tests ─────────────────────────────────────────────────────────────────
-
-test("dispatch: missing task plan triggers plan-slice (not stop) — issue #909", async () => {
-  const tmp = mkdtempSync(join(tmpdir(), "gsd-909-"));
-  try {
-    // Slice plan exists with tasks, but tasks/ directory is empty
-    scaffoldSlicePlan(tmp, "M002", "S03");
-
-    const ctx = makeContext(tmp);
-    const result = await resolveDispatch(ctx);
-
-    assert.equal(result.action, "dispatch", "should dispatch, not stop");
-    assert.ok(result.action === "dispatch" && result.unitType === "plan-slice",
-      `unitType should be plan-slice, got: ${result.action === "dispatch" ? result.unitType : "(stop)"}`);
-    assert.ok(result.action === "dispatch" && result.unitId === "M002/S03",
-      `unitId should be M002/S03, got: ${result.action === "dispatch" ? result.unitId : "(stop)"}`);
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});
-
-test("dispatch: present task plan proceeds to execute-task normally", async () => {
-  const tmp = mkdtempSync(join(tmpdir(), "gsd-909-ok-"));
-  try {
-    scaffoldSlicePlan(tmp, "M002", "S03");
-    scaffoldTaskPlan(tmp, "M002", "S03", "T01");
-
-    const ctx = makeContext(tmp);
-    const result = await resolveDispatch(ctx);
-
-    assert.equal(result.action, "dispatch");
-    assert.ok(result.action === "dispatch" && result.unitType === "execute-task",
-      `unitType should be execute-task, got: ${result.action === "dispatch" ? result.unitType : "(stop)"}`);
-    assert.ok(result.action === "dispatch" && result.unitId === "M002/S03/T01",
-      `unitId should be M002/S03/T01, got: ${result.action === "dispatch" ? result.unitId : "(stop)"}`);
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});
-
-test("dispatch: plan-slice recovery loop — second call after plan-slice still recovers cleanly", async () => {
-  // Simulate: plan-slice ran but T01-PLAN.md is still missing (e.g. agent crashed mid-write).
-  // Dispatch should still re-dispatch plan-slice, not hard-stop.
-  const tmp = mkdtempSync(join(tmpdir(), "gsd-909-loop-"));
-  try {
-    scaffoldSlicePlan(tmp, "M002", "S03");
-
-    const ctx = makeContext(tmp);
-    const r1 = await resolveDispatch(ctx);
-    assert.equal(r1.action, "dispatch");
-    assert.ok(r1.action === "dispatch" && r1.unitType === "plan-slice");
-
-    // Still no task plan written — dispatch again
-    const r2 = await resolveDispatch(ctx);
-    assert.equal(r2.action, "dispatch");
-    assert.ok(r2.action === "dispatch" && r2.unitType === "plan-slice",
-      "should keep dispatching plan-slice until task plans appear");
-  } finally {
-    rmSync(tmp, { recursive: true, force: true });
-  }
-});

package/dist/resources/extensions/gsd/tests/dispatch-stall-guard.test.ts

@@ -1,126 +0,0 @@
-/**
- * dispatch-stall-guard.test.ts — Verifies defensive guards against dispatch stalls (#1073).
- *
- * After a slice completes, dispatchNextUnit must reliably dispatch the next unit.
- * These tests verify:
- * 1. newSession() has timeout protection (prevents permanent hang if session creation stalls)
- * 2. handleAgentEnd has a dispatch hang guard (catches dispatchNextUnit itself hanging)
- * 3. Session timeout constants are exported for configurability
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const AUTO_TS_PATH = join(__dirname, "..", "auto.ts");
-const SESSION_TS_PATH = join(__dirname, "..", "auto", "session.ts");
-
-function getAutoTsSource(): string {
-  return readFileSync(AUTO_TS_PATH, "utf-8");
-}
-
-function getSessionTsSource(): string {
-  return readFileSync(SESSION_TS_PATH, "utf-8");
-}
-
-// ── Session timeout constants ───────────────────────────────────────────────
-
-test("AutoSession exports NEW_SESSION_TIMEOUT_MS constant", () => {
-  const source = getSessionTsSource();
-  assert.ok(
-    source.includes("NEW_SESSION_TIMEOUT_MS"),
-    "auto/session.ts must export NEW_SESSION_TIMEOUT_MS for newSession() timeout",
-  );
-});
-
-test("AutoSession exports DISPATCH_HANG_TIMEOUT_MS constant", () => {
-  const source = getSessionTsSource();
-  assert.ok(
-    source.includes("DISPATCH_HANG_TIMEOUT_MS"),
-    "auto/session.ts must export DISPATCH_HANG_TIMEOUT_MS for dispatch hang detection",
-  );
-});
-
-test("NEW_SESSION_TIMEOUT_MS is a reasonable value (15-120 seconds)", () => {
-  const source = getSessionTsSource();
-  const match = source.match(/NEW_SESSION_TIMEOUT_MS\s*=\s*(\d[\d_]*)/);
-  assert.ok(match, "NEW_SESSION_TIMEOUT_MS must have a numeric value");
-  const value = parseInt(match![1]!.replace(/_/g, ""), 10);
-  assert.ok(value >= 15_000 && value <= 120_000,
-    `NEW_SESSION_TIMEOUT_MS must be 15-120s, got ${value}ms`,
-  );
-});
-
-test("DISPATCH_HANG_TIMEOUT_MS is greater than NEW_SESSION_TIMEOUT_MS", () => {
-  const source = getSessionTsSource();
-  const sessionMatch = source.match(/NEW_SESSION_TIMEOUT_MS\s*=\s*(\d[\d_]*)/);
-  const dispatchMatch = source.match(/DISPATCH_HANG_TIMEOUT_MS\s*=\s*(\d[\d_]*)/);
-  assert.ok(sessionMatch && dispatchMatch, "Both timeout constants must exist");
-  const sessionTimeout = parseInt(sessionMatch![1]!.replace(/_/g, ""), 10);
-  const dispatchTimeout = parseInt(dispatchMatch![1]!.replace(/_/g, ""), 10);
-  assert.ok(dispatchTimeout > sessionTimeout,
-    `DISPATCH_HANG_TIMEOUT_MS (${dispatchTimeout}) must be > NEW_SESSION_TIMEOUT_MS (${sessionTimeout})`,
-  );
-});
-
-// ── newSession() timeout in dispatchNextUnit ─────────────────────────────────
-
-test("dispatchNextUnit wraps newSession() with Promise.race timeout", () => {
-  const source = getAutoTsSource();
-  // Search the full file — dispatchNextUnit is very large
-  assert.ok(
-    source.includes("Promise.race") && source.includes("NEW_SESSION_TIMEOUT_MS"),
-    "dispatchNextUnit must use Promise.race with NEW_SESSION_TIMEOUT_MS to timeout newSession() (#1073)",
-  );
-});
-
-test("dispatchNextUnit handles newSession() timeout gracefully", () => {
-  const source = getAutoTsSource();
-  // Must notify user when session times out
-  assert.ok(
-    source.includes("Session creation timed out") || source.includes("Session creation failed"),
-    "dispatchNextUnit must notify user when newSession() times out or fails (#1073)",
-  );
-});
-
-// ── Dispatch hang guard in handleAgentEnd ────────────────────────────────────
-
-test("handleAgentEnd has a dispatch hang guard before dispatchNextUnit", () => {
-  const source = getAutoTsSource();
-  const fnIdx = source.indexOf("export async function handleAgentEnd");
-  assert.ok(fnIdx > -1, "handleAgentEnd must exist");
-
-  // Find the section between step mode check and dispatchNextUnit call
-  const fnBlock = source.slice(fnIdx, source.indexOf("\n// ─── Step Mode", fnIdx + 100));
-  assert.ok(
-    fnBlock.includes("DISPATCH_HANG_TIMEOUT_MS") || fnBlock.includes("dispatchHangGuard"),
-    "handleAgentEnd must have a dispatch hang guard before calling dispatchNextUnit (#1073)",
-  );
-});
-
-test("dispatch hang guard is cleared in finally block", () => {
-  const source = getAutoTsSource();
-  const fnIdx = source.indexOf("export async function handleAgentEnd");
-  const fnBlock = source.slice(fnIdx, source.indexOf("\n// ─── Step Mode", fnIdx + 100));
-  assert.ok(
-    fnBlock.includes("clearTimeout(dispatchHangGuard)"),
-    "dispatch hang guard must be cleared in finally block to prevent false alarms (#1073)",
-  );
-});
-
-// ── Constants are imported in auto.ts ────────────────────────────────────────
-
-test("auto.ts imports NEW_SESSION_TIMEOUT_MS and DISPATCH_HANG_TIMEOUT_MS", () => {
-  const source = getAutoTsSource();
-  assert.ok(
-    source.includes("NEW_SESSION_TIMEOUT_MS"),
-    "auto.ts must import NEW_SESSION_TIMEOUT_MS from session.ts",
-  );
-  assert.ok(
-    source.includes("DISPATCH_HANG_TIMEOUT_MS"),
-    "auto.ts must import DISPATCH_HANG_TIMEOUT_MS from session.ts",
-  );
-});

package/dist/resources/extensions/gsd/tests/doctor-environment.test.ts

@@ -1,314 +0,0 @@
-/**
- * doctor-environment.test.ts — Tests for environment health checks (#1221).
- *
- * Tests:
- *   - Node version detection
- *   - Dependencies installed check
- *   - Env file detection
- *   - Port conflict detection
- *   - Disk space check
- *   - Docker detection
- *   - Project tool detection
- *   - Doctor issue conversion
- *   - Report formatting
- */
-
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { tmpdir } from "node:os";
-
-import {
-  runEnvironmentChecks,
-  runFullEnvironmentChecks,
-  environmentResultsToDoctorIssues,
-  formatEnvironmentReport,
-  checkEnvironmentHealth,
-  type EnvironmentCheckResult,
-} from "../doctor-environment.ts";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertEq, assertTrue, assertMatch, report } = createTestContext();
-
-function createProjectDir(files: Record<string, string> = {}): string {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-env-test-"));
-  for (const [name, content] of Object.entries(files)) {
-    const filePath = join(dir, name);
-    mkdirSync(dirname(filePath), { recursive: true });
-    writeFileSync(filePath, content);
-  }
-  return dir;
-}
-
-async function main(): Promise<void> {
-  const cleanups: string[] = [];
-
-  try {
-    // ── Node Version Check ─────────────────────────────────────────────
-    console.log("\n=== env: no package.json returns empty ===");
-    {
-      const dir = createProjectDir();
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      // No package.json → no node checks
-      const nodeCheck = results.find(r => r.name === "node_version");
-      assertEq(nodeCheck, undefined, "no node version check without package.json");
-    }
-
-    console.log("\n=== env: package.json without engines returns no node check ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test", version: "1.0.0" }),
-      });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const nodeCheck = results.find(r => r.name === "node_version");
-      assertEq(nodeCheck, undefined, "no node version check without engines field");
-    }
-
-    console.log("\n=== env: package.json with engines returns node check ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({
-          name: "test",
-          version: "1.0.0",
-          engines: { node: ">=18.0.0" },
-        }),
-      });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const nodeCheck = results.find(r => r.name === "node_version");
-      assertTrue(nodeCheck !== undefined, "node version check runs with engines field");
-      // Current node should be >= 18 in CI
-      assertEq(nodeCheck!.status, "ok", "node version meets requirement");
-    }
-
-    // ── Dependencies Check ─────────────────────────────────────────────
-    console.log("\n=== env: missing node_modules detected ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test" }),
-      });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const depsCheck = results.find(r => r.name === "dependencies");
-      assertTrue(depsCheck !== undefined, "dependencies check runs");
-      assertEq(depsCheck!.status, "error", "missing node_modules is an error");
-      assertTrue(depsCheck!.message.includes("node_modules missing"), "reports missing node_modules");
-    }
-
-    console.log("\n=== env: existing node_modules detected ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test" }),
-      });
-      mkdirSync(join(dir, "node_modules"), { recursive: true });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const depsCheck = results.find(r => r.name === "dependencies");
-      assertTrue(depsCheck !== undefined, "dependencies check runs");
-      assertEq(depsCheck!.status, "ok", "existing node_modules is ok");
-    }
-
-    // ── Env File Check ─────────────────────────────────────────────────
-    console.log("\n=== env: .env.example without .env detected ===");
-    {
-      const dir = createProjectDir({
-        ".env.example": "DB_URL=xxx\nAPI_KEY=xxx\n",
-      });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const envCheck = results.find(r => r.name === "env_file");
-      assertTrue(envCheck !== undefined, "env file check runs");
-      assertEq(envCheck!.status, "warning", "missing .env is a warning");
-    }
-
-    console.log("\n=== env: .env.example with .env is ok ===");
-    {
-      const dir = createProjectDir({
-        ".env.example": "DB_URL=xxx\n",
-        ".env": "DB_URL=postgres://localhost/test\n",
-      });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const envCheck = results.find(r => r.name === "env_file");
-      assertTrue(envCheck !== undefined, "env file check runs");
-      assertEq(envCheck!.status, "ok", "present .env is ok");
-    }
-
-    console.log("\n=== env: .env.example with .env.local is ok ===");
-    {
-      const dir = createProjectDir({
-        ".env.example": "DB_URL=xxx\n",
-        ".env.local": "DB_URL=postgres://localhost/test\n",
-      });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const envCheck = results.find(r => r.name === "env_file");
-      assertTrue(envCheck !== undefined, "env file check runs");
-      assertEq(envCheck!.status, "ok", ".env.local counts as present");
-    }
-
-    // ── Disk Space Check ───────────────────────────────────────────────
-    console.log("\n=== env: disk space check returns result ===");
-    if (process.platform !== "win32") {
-      const dir = createProjectDir();
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const diskCheck = results.find(r => r.name === "disk_space");
-      assertTrue(diskCheck !== undefined, "disk space check runs on unix");
-      // Should be ok on dev machines with reasonable disk
-      assertTrue(diskCheck!.status === "ok" || diskCheck!.status === "warning", "disk check returns valid status");
-    }
-
-    // ── Project Tools Check ────────────────────────────────────────────
-    console.log("\n=== env: detects missing python when pyproject.toml exists ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test" }),
-        "pyproject.toml": "[build-system]\nrequires = ['setuptools']\n",
-      });
-      mkdirSync(join(dir, "node_modules"), { recursive: true });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const pythonCheck = results.find(r => r.name === "python");
-      // Python is likely installed on CI/dev machines, so just verify the check runs
-      // without error — the result depends on the system
-      assertTrue(true, "python check runs without error");
-    }
-
-    console.log("\n=== env: detects Cargo.toml ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test" }),
-        "Cargo.toml": "[package]\nname = 'test'\n",
-      });
-      mkdirSync(join(dir, "node_modules"), { recursive: true });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      // Just verify it runs without error
-      assertTrue(true, "cargo check runs without error");
-    }
-
-    // ── Docker Check ───────────────────────────────────────────────────
-    console.log("\n=== env: no docker check without Dockerfile ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test" }),
-      });
-      mkdirSync(join(dir, "node_modules"), { recursive: true });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const dockerCheck = results.find(r => r.name === "docker");
-      assertEq(dockerCheck, undefined, "no docker check without Dockerfile");
-    }
-
-    console.log("\n=== env: docker check with Dockerfile ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test" }),
-        "Dockerfile": "FROM node:22\n",
-      });
-      mkdirSync(join(dir, "node_modules"), { recursive: true });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const dockerCheck = results.find(r => r.name === "docker");
-      // Docker may or may not be installed on the test machine
-      assertTrue(dockerCheck !== undefined, "docker check runs when Dockerfile present");
-    }
-
-    // ── Doctor Issue Conversion ────────────────────────────────────────
-    console.log("\n=== env: converts results to doctor issues ===");
-    {
-      const results: EnvironmentCheckResult[] = [
-        { name: "node_version", status: "ok", message: "Node.js v22.0.0" },
-        { name: "dependencies", status: "error", message: "node_modules missing" },
-        { name: "env_file", status: "warning", message: ".env missing", detail: "Copy .env.example" },
-      ];
-
-      const issues = environmentResultsToDoctorIssues(results);
-      assertEq(issues.length, 2, "only non-ok results converted");
-      assertEq(issues[0]!.severity, "error", "error severity preserved");
-      assertEq(issues[0]!.code, "env_dependencies", "code prefixed with env_");
-      assertEq(issues[1]!.severity, "warning", "warning severity preserved");
-      assertTrue(issues[1]!.message.includes("Copy .env.example"), "detail included in message");
-    }
-
-    // ── checkEnvironmentHealth integration ──────────────────────────────
-    console.log("\n=== env: checkEnvironmentHealth adds issues to array ===");
-    {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({ name: "test" }),
-      });
-      cleanups.push(dir);
-
-      const issues: any[] = [];
-      await checkEnvironmentHealth(dir, issues);
-      // Should have at least the missing node_modules issue
-      assertTrue(issues.some(i => i.code === "env_dependencies"), "environment issues added to array");
-    }
-
-    // ── Report Formatting ──────────────────────────────────────────────
-    console.log("\n=== env: formatEnvironmentReport ===");
-    {
-      const results: EnvironmentCheckResult[] = [
-        { name: "node_version", status: "ok", message: "Node.js v22.0.0" },
-        { name: "dependencies", status: "error", message: "node_modules missing", detail: "Run npm install" },
-        { name: "disk_space", status: "ok", message: "50.2GB free" },
-      ];
-
-      const report = formatEnvironmentReport(results);
-      assertTrue(report.includes("Environment Health:"), "has header");
-      assertTrue(report.includes("Node.js v22.0.0"), "includes ok result");
-      assertTrue(report.includes("node_modules missing"), "includes error result");
-      assertTrue(report.includes("Run npm install"), "includes detail for errors");
-    }
-
-    console.log("\n=== env: formatEnvironmentReport empty ===");
-    {
-      const report = formatEnvironmentReport([]);
-      assertEq(report, "No environment checks applicable.", "empty report message");
-    }
-
-    // ── Full environment checks include git remote ─────────────────────
-    console.log("\n=== env: runFullEnvironmentChecks includes git remote ===");
-    {
-      // runFullEnvironmentChecks adds git remote check
-      // We can't easily test this without a real git repo, but verify it doesn't throw
-      const dir = createProjectDir();
-      cleanups.push(dir);
-      const results = runFullEnvironmentChecks(dir);
-      // No git repo → no remote check, but should not throw
-      assertTrue(true, "runFullEnvironmentChecks does not throw on non-git dir");
-    }
-
-    // ── Port Detection from package.json ───────────────────────────────
-    console.log("\n=== env: port detection from scripts ===");
-    if (process.platform !== "win32") {
-      const dir = createProjectDir({
-        "package.json": JSON.stringify({
-          name: "test",
-          scripts: {
-            dev: "next dev --port 3456",
-            start: "node server.js",
-          },
-        }),
-      });
-      mkdirSync(join(dir, "node_modules"), { recursive: true });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      // Port 3456 is unlikely to be in use, so no conflicts expected
-      const portConflicts = results.filter(r => r.name === "port_conflict");
-      // Just verify it ran without error
-      assertTrue(true, "port check with script-detected ports runs without error");
-    }
-
-  } finally {
-    for (const dir of cleanups) {
-      try { rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
-    }
-  }
-
-  report();
-}
-
-main();